[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

ikudrin updated this revision to Diff 520277. ikudrin retitled this revision from "[CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows" to "[CMake] Use LLVM own tools in extract_symbols.py". ikudrin edited the summary of this revision. ikudrin added reviewers: chandlerc,

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vreinterpret.c:1 -// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// NOTE: Assertions have been autogenerated by

[PATCH] D149904: Generic selection expressions that accept a type operand

aaron.ballman updated this revision to Diff 520338. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Added a test case for packs based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149904/new/ https://reviews.llvm.org/D149904 Files:

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:875 1 ? 0 : 1; +sizeof(A); +alignof(A); tbaeder wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > tbaeder wrote: > > > > aaron.ballman wrote: > > > > > Let's make

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 520344. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D150040: [clang][Interp] Call invalid destructors

erichkeane added inline comments. Comment at: clang/test/AST/Interp/records.cpp:606 +S{}; // ref-note {{in call to '{}->~S()'}} +return 1; // expected-note {{in call to '{}->~S()'}} + // FIXME: ^ Wrong line Which DTOR is happening here that

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

Fznamznon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:385 +- Fix handling of constexpr dynamic memory allocations in template + arguments. (`#62462 `) Not an expert in this, but I assume

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

sgraenitz added a comment. In D141215#4272538 , @lhames wrote: > using regular global variable instances to manage the storage on the executor > side, an extended `MemoryAccess` interface to read/write the value from the > REPL side when needed (e.g.

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/lambda.cpp:92 + static_assert(foo() == 1); // expected-error {{not an integral constant expression}} +} + tbaeder wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > How about some tests like:

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov added a comment. Another friendly ping for review. @erichkeane let me know if you feel that exposing the incorrect lambda instantiation behavior is a blocker here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148802/new/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 520324. junaire added a comment. Rebase + Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150063/new/ https://reviews.llvm.org/D150063

[PATCH] D149837: [clang][Interp] Fix ignoring CompoundLiteralExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149837/new/ https://reviews.llvm.org/D149837 ___ cfe-commits mailing

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

aaron.ballman added a comment. Can you also add a release note for the fix? The changes generally LGTM Comment at: clang/test/SemaCXX/cxx23-static-callop-lambda-expression.cpp:12 + + auto lstatic = []() static consteval //expected-note {{declared here}}

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:875 1 ? 0 : 1; +sizeof(A); +alignof(A); tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > > Let's make sure we still reject this: >

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:329 +static void +builtinTransferScopeEnd(const CFGScopeEnd , +TypeErasedDataflowAnalysisState ) { xazax.hun wrote: > mboehme

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 520288. xiongji90 added a comment. Address previous comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146188/new/ https://reviews.llvm.org/D146188 Files: clang/docs/LanguageExtensions.rst

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

This revision was automatically updated to reflect the committed changes. Closed by commit rG743ff9c8bad3: [clang-repl] Do not assert if we have weak references left. (authored by v.g.vassilev). Herald added a project: clang. Changed prior to commit:

[clang] 743ff9c - [clang-repl] Do not assert if we have weak references left.

Author: Vassil Vassilev Date: 2023-05-08T09:13:00Z New Revision: 743ff9c8bad375d4cea0c44a89cdcc117ffc9bf3 URL: https://github.com/llvm/llvm-project/commit/743ff9c8bad375d4cea0c44a89cdcc117ffc9bf3 DIFF: https://github.com/llvm/llvm-project/commit/743ff9c8bad375d4cea0c44a89cdcc117ffc9bf3.diff

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire updated this revision to Diff 520313. junaire added a comment. Update + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ https://reviews.llvm.org/D148997 Files: clang/include/clang/AST/Decl.h

[clang] 14f0776 - Reland "Give NullabilityKind a printing operator<<"

Author: Sam McCall Date: 2023-05-08T13:07:11+02:00 New Revision: 14f0776550b5a49e1c42f49a00213f7f3fa047bf URL: https://github.com/llvm/llvm-project/commit/14f0776550b5a49e1c42f49a00213f7f3fa047bf DIFF: https://github.com/llvm/llvm-project/commit/14f0776550b5a49e1c42f49a00213f7f3fa047bf.diff

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:375 +- A default argument for a non-type template parameter is evaluated and checked + at the point where is is required. This fixes: + (`#62224 `_) and

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. I love it when remove it code fixes a bug! Thanks for the PR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150108/new/

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:875 1 ? 0 : 1; +sizeof(A); +alignof(A); tbaeder wrote: > aaron.ballman wrote: > > Let's make sure we still reject this: > > ``` > > constexpr int oh_my() { > > int

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Thanks for the patch! I think this is a nice and general solution, which rather than solving just a specific problem (e.g. highlighting of `new` as an operator vs. a keyword),

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

ikudrin added a comment. In D149119#4312518 , @simon_tatham wrote: > Do LLVM's current portability goals include the constraint that you can only > build LLVM for a platform it can also target? If not, then there surely still > needs to be //some//

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; sgraenitz wrote: > v.g.vassilev

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/Decl.h:4345 + } + bool isValuePrinting() const { return IsSemiMissing; } + void setValuePrinting(bool Missing = true) { IsSemiMissing = Missing; } We should change the accessors to the

[PATCH] D150072: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150072/new/ https://reviews.llvm.org/D150072

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 520337. skatrak added a comment. Remove handling of `atomic_default_mem_order`, as it's now done in semantics. Fix conflicts with changes to parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520302. CaprYang retitled this revision from "[InferAddressSpaces] Handle vector of pointers type" to "[InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter". CHANGES SINCE LAST ACTION

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 520307. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Herald added a subscriber: arphaman. Move the check from "google" to "misc". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

Fznamznon created this revision. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change a default template argument

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

tbaeder updated this revision to Diff 520331. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150111/new/ https://reviews.llvm.org/D150111 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:875 1 ? 0 : 1; +sizeof(A); +alignof(A); aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > Let's make sure we still reject this: > > > ``` > > >

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520308. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520316. cor3ntin added a comment. Fix release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/lambda.cpp:92 + static_assert(foo() == 1); // expected-error {{not an integral constant expression}} +} + tbaeder wrote: > tbaeder wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > >

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman added a comment. Do you have some performance measurement numbers for how much benefit we get from the changes? Comment at: clang/lib/Sema/SemaExpr.cpp:19195 + + // tryCaptureVariable is called ever ytime a DeclRef is formed, + // it can therefore have

[clang] 6b55e91 - [RISCV] Add MC support of RISCV zcmp Extension

Author: WuXinlong Date: 2023-05-08T14:29:50+08:00 New Revision: 6b55e9117ebbd32d66b6f6ad12326a6b2acaef58 URL: https://github.com/llvm/llvm-project/commit/6b55e9117ebbd32d66b6f6ad12326a6b2acaef58 DIFF: https://github.com/llvm/llvm-project/commit/6b55e9117ebbd32d66b6f6ad12326a6b2acaef58.diff

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b55e9117ebb: [RISCV] Add MC support of RISCV zcmp Extension (authored by VincentWu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D149151: [clang][dataflow][NFC] Remove `SkipPast` parameter from `getStorageLocation(const ValueDecl &).

This revision was automatically updated to reflect the committed changes. Closed by commit rG9940fac75395: [clang][dataflow][NFC] Remove `SkipPast` parameter from `getStorageLocation… (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D149151?vs=516770=520281#toc

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

v.g.vassilev updated this revision to Diff 520286. v.g.vassilev added a comment. Provide a better test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148435/new/ https://reviews.llvm.org/D148435 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

tbaeder updated this revision to Diff 520330. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150111/new/ https://reviews.llvm.org/D150111 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Emit custom byte code for the static invoker

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. @erichkeane @aaron.ballman I think we should determine how much works remains there and if the author is not responsive maybe one of us can push this up the finishing line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin added a comment. In D150038#4326549 , @aaron.ballman wrote: > Do you have some performance measurement numbers for how much benefit we get > from the changes? Not really. The PR that changed the scope of trailing return type had a 0.35%

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

tbaeder updated this revision to Diff 520340. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149834/new/ https://reviews.llvm.org/D149834 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Give folks another 48 hrs to disagree, but this seems fine to me/consistent with other comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1824 -static bool

[PATCH] D150040: [clang][Interp] Call invalid destructors

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:606 +S{}; // ref-note {{in call to '{}->~S()'}} +return 1; // expected-note {{in call to '{}->~S()'}} + // FIXME: ^ Wrong line erichkeane wrote: > Which DTOR is

[clang] 9940fac - [clang][dataflow][NFC] Remove `SkipPast` parameter from `getStorageLocation(const ValueDecl &).

Author: Martin Braenne Date: 2023-05-08T07:10:44Z New Revision: 9940fac7539597c08f03381527011e1280cd7489 URL: https://github.com/llvm/llvm-project/commit/9940fac7539597c08f03381527011e1280cd7489 DIFF: https://github.com/llvm/llvm-project/commit/9940fac7539597c08f03381527011e1280cd7489.diff

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 marked an inline comment as done. xiongji90 added a comment. Hi, @rjmccall I updated the patch to address your previous comments, could you help review again? Thanks very much. Comment at: clang/docs/LanguageExtensions.rst:3272 +3 - toward negative infinity +4 -

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

hans added a comment. Nice! Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11570 getStdNamespace()->setImplicit(true); +Context.getTranslationUnitDecl()->addDecl(getStdNamespace()); +getStdNamespace()->clearIdentifierNamespace(); This could use an

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type

CaprYang updated this revision to Diff 520296. CaprYang removed reviewers: bollu, ldionne, nicolasvasilache, rafauler, Amir, maksfb, NoQ, njames93, libc++, libc++abi, libunwind, rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. CaprYang removed projects: clang-format, Flang,

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. @rsmith, any ideas how to support value printing of constructs such as `int i = 12`, eg, that's not a top-level statement declaration but worth printing its value? It is the shorthand of `int i = 12; i`. Comment at:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 520326. junaire marked an inline comment as done. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev updated this revision to Diff 520322. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman added a comment. In D150038#4326554 , @cor3ntin wrote: > In D150038#4326549 , @aaron.ballman > wrote: > >> Do you have some performance measurement numbers for how much benefit we get >> from the

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 520374. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1614 -TemplateArgument SugaredConverted, CanonicalConverted; -ExprResult DefaultRes = CheckTemplateArgument( Out of curiosity where is the template argument being checked now and

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6331 + if (Arg *A = Args.getLastArg(options::OPT_K); A && !TC.getTriple().isOSAIX()) +D.Diag(diag::err_drv_unsupported_opt_for_target) Let's not claim here, just in case

[PATCH] D149612: [Sema] avoid merge error type

erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( +

[PATCH] D150087: [Clang] Support more stdio builtins

tuliom requested changes to this revision. tuliom added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:109 + {Builtin::BI__builtin___vsnprintf_chk, "__vsnprintfieee128"}, +

[clang] e875de2 - [clang][dataflow] Remove deprecated pass-through APIs for DataflowAnalysisContext.

Author: Samira Bazuzi Date: 2023-05-08T13:59:40Z New Revision: e875de2a3e8e814265c7cb09b908a444df1a498d URL: https://github.com/llvm/llvm-project/commit/e875de2a3e8e814265c7cb09b908a444df1a498d DIFF: https://github.com/llvm/llvm-project/commit/e875de2a3e8e814265c7cb09b908a444df1a498d.diff

[PATCH] D149869: [clang][dataflow] Remove deprecated pass-through APIs for DataflowAnalysisContext.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe875de2a3e8e: [clang][dataflow] Remove deprecated pass-through APIs for… (authored by bazuzi, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150017: [Clang][BPF] Type print btf_type_tag properly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3060304906f0: [Clang][BPF] Type print btf_type_tag properly (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150122: [Clang] Fix status of P0960

cor3ntin added a comment. In D150122#4326935 , @erichkeane wrote: > I've got no problems with this. I'm a little suspicious of marking this done > in clang-16 if this was done only at the end of the branch though? And do we > know there is going to

[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'll fix up the nits when I land on your behalf. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1456-1467 +static bool

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Let's rely on a post-commit review here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 520447. to268 added a comment. Fixed auto char arrays with explicit brackets c auto foo[] = "bar"; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files:

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520455. francii added a comment. Don't claim `-k` when checking target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D150137: [clang][dataflow][NFC] Remove `SkipPast` param from `getValue(const ValueDecl &)`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This parameter was already a no-op, so removing

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Thanks! That was blocking our jupyter integration so I decided to go ahead here since we already missed the clang17 train... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote:

[PATCH] D149999: [clang-tidy] [test] Narrow down a special case to MSVC mode

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___

[clang] 1768898 - [MemProf] Control availability of hot/cold operator new from LTO link

Author: Teresa Johnson Date: 2023-05-08T08:02:21-07:00 New Revision: 176889868024d98db032842bc47b416997d9e349 URL: https://github.com/llvm/llvm-project/commit/176889868024d98db032842bc47b416997d9e349 DIFF:

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG176889868024: [MemProf] Control availability of hot/cold operator new from LTO link (authored by tejohnson). Changed prior to commit:

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594 +if (DiscardResult) + return true; + For my own understanding -- why do we not need to call `discard()` on the operand expression?

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594 +if (DiscardResult) + return true; + aaron.ballman wrote: > For my own understanding -- why do we not need to call `discard()` on the > operand expression? Is

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

tra added a comment. The change may be an improvement, but we may still have a potential issue here. E.g. ideally we may want to be able to cross-compile a CUDA app on a powerpc or ARM build host targeting NVIDIA GPU on a x86 host. So, the compilation tools would need to be found for the

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

jhuber6 added a comment. In D150136#4327570 , @tra wrote: > The change may be an improvement, but we may still have a potential issue > here. > > E.g. ideally we may want to be able to cross-compile a CUDA app on a powerpc > or ARM build host targeting

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev updated this revision to Diff 520368. v.g.vassilev added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 520384. Manna added a comment. Thanks @tahonermann for reviews. I have addressed review comments and updated patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files:

[PATCH] D150122: [Clang] Fix status of P0960

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P0960R3 and P1975R0 were marked not implemented because of #61145, This issue has been fixed and backported to LLVM 16,

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna marked 6 inline comments as done. Manna added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:704 /// Move the given pool's allocations to this pool. AttributePool(AttributePool &) = default; tahonermann wrote: > This class has a

[PATCH] D150122: [Clang] Fix status of P0960

erichkeane added a comment. I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150122: [Clang] Fix status of P0960

erichkeane added a comment. In D150122#4326941 , @cor3ntin wrote: > In D150122#4326935 , @erichkeane > wrote: > >> I've got no problems with this. I'm a little suspicious of marking this >> done in clang-16 if

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao updated this revision to Diff 520429. ayzhao marked an inline comment as done. ayzhao added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files:

[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94252713f9a7: [clang][AST][NFC] Factor out check for structural equivalence of names. (authored by davidstone, committed by aaron.ballman).

[clang] 9425271 - [clang][AST][NFC] Factor out check for structural equivalence of names.

Author: David Stone Date: 2023-05-08T13:27:36-04:00 New Revision: 94252713f9a7fdeeb18a7e43a9d414ea09fc0c13 URL: https://github.com/llvm/llvm-project/commit/94252713f9a7fdeeb18a7e43a9d414ea09fc0c13 DIFF: https://github.com/llvm/llvm-project/commit/94252713f9a7fdeeb18a7e43a9d414ea09fc0c13.diff

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. Hi all! The CI builds are all clean now. Any further comment/review on this? Would love to close this out soon. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews.llvm.org/D149193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote:

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:546 addLinkerCompressDebugSectionsOption(getToolChain(), Args, CmdArgs); AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs, JA); + Args.AddAllArgs(CmdArgs, options::OPT_L);

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520356. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder updated this revision to Diff 520361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147591/new/ https://reviews.llvm.org/D147591 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index:

[clang] 3060304 - [Clang][BPF] Type print btf_type_tag properly

Author: Yonghong Song Date: 2023-05-08T07:41:27-07:00 New Revision: 3060304906f08f933672f0a30cc57d5f09766444 URL: https://github.com/llvm/llvm-project/commit/3060304906f08f933672f0a30cc57d5f09766444 DIFF: https://github.com/llvm/llvm-project/commit/3060304906f08f933672f0a30cc57d5f09766444.diff

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

vitalybuka added a comment. Breaks these bots? https://lab.llvm.org/buildbot/#/builders/18/builds/8898 https://lab.llvm.org/buildbot/#/builders/19/builds/16412 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Fantastic, that's some nice green in there. LGTM modulo nits, please add `NFC` to the patch summary when landing so folks know not to expect test coverage. Repository: rG

  1   2   3   >