[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39 const PreprocessorOptions // Only used for debug info. -const CodeGenOptions CodeGenOpts; // Intentionally copied in. +CodeGenOptions CodeGenOpts; // Intentionally copied in.

[clang] db63fb5 - [Clang][Docs] Fix man page build

Author: Aiden Grossman Date: 2023-05-13T08:51:10Z New Revision: db63fb5d45e0f58a1c657b23a24e85f28e3dbf73 URL: https://github.com/llvm/llvm-project/commit/db63fb5d45e0f58a1c657b23a24e85f28e3dbf73 DIFF: https://github.com/llvm/llvm-project/commit/db63fb5d45e0f58a1c657b23a24e85f28e3dbf73.diff

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi added a comment. @aaron.ballman Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

Amir added a comment. In D143553#4339755 , @beanz wrote: > LGTM. > > Sorry for the delays reviewing! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 521919. Amir added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39 const PreprocessorOptions // Only used for debug info. -const CodeGenOptions CodeGenOpts; // Intentionally copied in. +CodeGenOptions CodeGenOpts; // Intentionally copied in.

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

HazardyKnusperkeks added a comment. Please add the full stop to the code comment(s), and then mark review comments as done. You should also give credit to @sstwcw in the commit message/differential description for the token annotator tests. In D150403#4339530

[PATCH] D149809: [Clang][Docs] Fix man page build

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb63fb5d45e0: [Clang][Docs] Fix man page build (authored by aidengrossman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 521902. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

aaronpuchert added a comment. In several cases it's not completely obvious to me whether a copy assignment operator should or can be defined. But perhaps this doesn't need to be addressed right now: we seem to compile with `-Wextra`, which contains `-Wdeprecated-copy`. That should warn if a

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. https://github.com/bminor/binutils-gdb/blob/master/include/diagnostics.h gdb only suppresses the warning. So this patch will likely break gdb. As per commit: https://github.com/bminor/binutils-gdb/commit/ae61525fcf456ab395d55c45492a106d1275873a Since the current

[clang] 76b2915 - [Clang][CMake] Use perf-training for Clang-BOLT

Author: Amir Ayupov Date: 2023-05-13T10:36:29-07:00 New Revision: 76b2915fdbbba18693c9aabda419768f41106f31 URL: https://github.com/llvm/llvm-project/commit/76b2915fdbbba18693c9aabda419768f41106f31 DIFF: https://github.com/llvm/llvm-project/commit/76b2915fdbbba18693c9aabda419768f41106f31.diff

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76b2915fdbbb: [Clang][CMake] Use perf-training for Clang-BOLT (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/78516/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150282/new/

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

thakis added a comment. Apologies for the noise, looks like my win bot hasn't built in a while. Looks like this is already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150282/new/ https://reviews.llvm.org/D150282

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kuganv updated this revision to Diff 521936. kuganv edited the summary of this revision. kuganv added a comment. Herald added a project: clang. Re-implemented based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/

[PATCH] D150506: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC)

kazu created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, kadircet, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1568 +C++2c implementation status + h-vetinari wrote: > The longer this page gets, the more I feel it should be sorted in reverse > chronological order of the standard versions. It's

[PATCH] D150450: Add C++26 compile flags.

xbolva00 added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:458 +else if (LangOpts.CPlusPlus23) + Builder.defineMacro("__cplusplus", "202302L"); // [C++20] The integer literal 202002L. Separate patch / commit? CHANGES

[clang] c01ea05 - [test] Driver/ftime-trace.cpp: work around -Wmsvc-not-found

Author: Fangrui Song Date: 2023-05-13T00:22:05-07:00 New Revision: c01ea0515f15064e4bcec601f9290854429b8666 URL: https://github.com/llvm/llvm-project/commit/c01ea0515f15064e4bcec601f9290854429b8666 DIFF: https://github.com/llvm/llvm-project/commit/c01ea0515f15064e4bcec601f9290854429b8666.diff

[PATCH] D143553: [Clang][CMake] Use perf-training for Clang-BOLT

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Sorry for the delays reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553

[clang] 2db0812 - [clang] Fix typos in documentation

Author: Kazu Hirata Date: 2023-05-12T23:19:17-07:00 New Revision: 2db081288292f555dd556e066be0c1c7b9548da8 URL: https://github.com/llvm/llvm-project/commit/2db081288292f555dd556e066be0c1c7b9548da8 DIFF: https://github.com/llvm/llvm-project/commit/2db081288292f555dd556e066be0c1c7b9548da8.diff

[clang-tools-extra] 7f28137 - [clang-tidy] Modernize RangeDescriptor (NFC)

Author: Kazu Hirata Date: 2023-05-12T23:19:19-07:00 New Revision: 7f28137b5d2cb0deda4c6171665ef15accfab6ab URL: https://github.com/llvm/llvm-project/commit/7f28137b5d2cb0deda4c6171665ef15accfab6ab DIFF: https://github.com/llvm/llvm-project/commit/7f28137b5d2cb0deda4c6171665ef15accfab6ab.diff

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb marked an inline comment as done. jaredgrubb added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5473 + if (Right.isOneOf(tok::kw___attribute, TT_AttributeMacro)) +return true; + HazardyKnusperkeks wrote: > jaredgrubb wrote: >

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521964. ychen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/DeclCXX.h

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521963. ychen marked 3 inline comments as done. ychen added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 521952. jaredgrubb added a comment. Address review comments: - fix some style - add unit test for each ObjC attribute recognized by the compiler - adjust the docs for the style-option to show a YAML example with all of them in a sane order (something

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521965. ychen marked an inline comment as done. ychen added a comment. - add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 521962. junaire added a comment. Add macro guard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 521953. jaredgrubb added a comment. Address review comments: - remove redundant `&&` - remove part of patch that was not tested by any test and should be its own patch on its own merits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 521961. junaire added a comment. Don't use C++17 because Clang on Windows is not default to that :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files:

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 521967. daiyousei-qz added a comment. 1. Updating D148489 : [clangd] Implement configs to stop clangd produce a certain semantic tokens # 2. Enter a brief description of the changes included in this update. 3. The

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen marked 9 inline comments as done. ychen added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:10338 +Context.getRValueReferenceType(ElementTypes[i]); + else if (isa(ListInit->getInit(i))) +// This deviates from the

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 521969. daiyousei-qz added a comment. Redo arc as some changes are missing from previous update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files: