[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522284. kushanam added a comment. Addressing review changed and removing bf16 registers Depends on D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10682 verifyFormat("a < 0 ? b : a > 0 ? c : d;"); + verifyFormat("ratio{-1, 2} < ratio{-1, 3} == -1 / 3 > -1 / 2;"); verifyFormat("void f() {\n" Do we need to add a token

[clang-tools-extra] 4ddae8b - [clangd] Fix test failure when it's built with compiler flags unknown by clang

Author: Xi Ruoyao Date: 2023-05-16T03:56:26+01:00 New Revision: 4ddae8b941398a6579d3a6f25aa39a260e441371 URL: https://github.com/llvm/llvm-project/commit/4ddae8b941398a6579d3a6f25aa39a260e441371 DIFF: https://github.com/llvm/llvm-project/commit/4ddae8b941398a6579d3a6f25aa39a260e441371.diff

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ddae8b94139: [clangd] Fix test failure when its built with compiler flags unknown by clang (authored by xry111, committed by thesamesam).

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. (I even struggled to find docs for the fix we used for clang-tidy, although it obviously works.) Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. daiyousei-qz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 522432. daiyousei-qz edited the summary of this revision. daiyousei-qz added a comment. minor naming fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635 Files:

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. In D150253#4343699 , @craig.topper wrote: > In D150253#4341545 , @jacquesguan > wrote: > >> To enable specific EEW for specific insturction in instruction selection, I >> will

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

owenpan added inline comments. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:116-117 if (Style.isCpp()) { - if (const auto Pos = Text.find_first_of("_i"); Pos != StringRef::npos) { + // FIXME: This doesn't work for ud-suffix d from

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. This check is similar to the right paren

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 4 inline comments as done. rsundahl added a comment. Suggestions for compiler-rt/docs/asan_abi.md are captured in the successor file compiler-rt/docs/ASanABI.rst and marked complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 40c3054 - [NFC] [C++20] [Modules] Refactoring b6c7177145bc to make it not

Author: Chuanqi Xu Date: 2023-05-16T10:34:02+08:00 New Revision: 40c30543892aa6441eea075ba69864e79f5de82e URL: https://github.com/llvm/llvm-project/commit/40c30543892aa6441eea075ba69864e79f5de82e DIFF: https://github.com/llvm/llvm-project/commit/40c30543892aa6441eea075ba69864e79f5de82e.diff

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

pengfei added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:1043 +///corresponding byte of the 256-bit integer vector result (overflow is +///ignored). For each byte, computes result = __a - __b . +/// It better to move it to

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4343546 , @efriedma wrote: > It's not unprecedented to add flags to copy the behavior of other compilers, > to make porting easier, especially when it doesn't place much burden on > compiler

[clang] 88a720d - [NFC] [C++20] [Modules] Rename ASTContext::getNamedModuleForCodeGen to ASTContext::getCurrentNamedModule

Author: Chuanqi Xu Date: 2023-05-16T11:24:35+08:00 New Revision: 88a720d19479e4cad186f00a9911714c3d77303a URL: https://github.com/llvm/llvm-project/commit/88a720d19479e4cad186f00a9911714c3d77303a DIFF: https://github.com/llvm/llvm-project/commit/88a720d19479e4cad186f00a9911714c3d77303a.diff

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150597/new/ https://reviews.llvm.org/D150597

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 2 inline comments as done. rsundahl added a comment. Suggestions for compiler-rt/docs/asan_abi.md are captured in the successor file compiler-rt/docs/ASanABI.rst and marked complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 522434. daiyousei-qz added a comment. minor naming fix2 (last fix breaks builds) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635 Files:

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:891-895 +for (const FormatToken *Tok = Line->First; Tok; Tok = Tok->Next) { + // Ignore the first token, because in this situation, it applies more + // to the last token of the

[clang] 369e876 - [clang-format] Stop comment disrupting indentation of Verilog ports

Author: sstwcw Date: 2023-05-16T02:56:58Z New Revision: 369e8762b4d658e6e8f8310200aadf043bd7f01e URL: https://github.com/llvm/llvm-project/commit/369e8762b4d658e6e8f8310200aadf043bd7f01e DIFF: https://github.com/llvm/llvm-project/commit/369e8762b4d658e6e8f8310200aadf043bd7f01e.diff LOG:

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG369e8762b4d6: [clang-format] Stop comment disrupting indentation of Verilog ports (authored by sstwcw). Repository: rG LLVM Github Monorepo

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

owenpan updated this revision to Diff 522397. owenpan added a comment. Addressed the review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150539/new/ https://reviews.llvm.org/D150539 Files: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 522417. rsundahl added a comment. Applied suggestions from reviewers Cleaned up options parsing Moved test into stanalone file fsanitize-stable-abi.c Changed target triple to arm64-apple-darwin Changed documentation style from proposal to specification

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 22 inline comments as done. rsundahl added a comment. Thank you for your review and thoughtful input @eugenis, @MaskRay and @vitalybuka. I think we're close to having everything incorporated. (@MaskRay, the doc files went from .md to .rst and I implemented all of your

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. Requesting for some advice Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1666 + +$anon[[struct { + int x; This is unwanted behavior from my understanding. Do you guys have any insight how we could fix

[clang] 7f37066 - Revert "[NFC] [C++20] [Modules] Refactor Sema::isModuleUnitOfCurrentTU into"

Author: Chuanqi Xu Date: 2023-05-16T10:47:53+08:00 New Revision: 7f37066915ab330f153ede708ddc610cf2cb7bdf URL: https://github.com/llvm/llvm-project/commit/7f37066915ab330f153ede708ddc610cf2cb7bdf DIFF: https://github.com/llvm/llvm-project/commit/7f37066915ab330f153ede708ddc610cf2cb7bdf.diff

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat updated this revision to Diff 522411. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522157. domada added a comment. Patch rebased because I applied remarks for parent revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:106-113 +CI.setSema(nullptr); +CI.setASTConsumer(nullptr); +if (CI.getASTReader()) { + CI.getASTReader()->setDeserializationListener(nullptr); + /* This just sets consumer to

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4337148 , @awarzynski wrote: > All in all LGTM, but I'm not sure whether Flang should be defaulting to > OpenMP 5.0. AFAIK, that's not supported yet. If you wish I can set to OpenMP 4.5. But then we need to have two

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

aaron.ballman added a comment. Thank you for working on this! Just a few minor things. Comment at: clang/docs/ReleaseNotes.rst:279-281 +- Clang now correctly diagnoses when the argument to alignas is an incomplete type. + (`#55175:

[clang] e1f34b7 - clang-format: [JS] terminate import sorting on `export type X = Y`

Author: Jan Kuhle Date: 2023-05-15T15:37:18+02:00 New Revision: e1f34b735b669c5978bfdead874ee59d33f99eb0 URL: https://github.com/llvm/llvm-project/commit/e1f34b735b669c5978bfdead874ee59d33f99eb0 DIFF: https://github.com/llvm/llvm-project/commit/e1f34b735b669c5978bfdead874ee59d33f99eb0.diff

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1f34b735b66: clang-format: [JS] terminate import sorting on `export type X = Y` (authored by jankuehle, committed by krasimir). Repository: rG

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

gysit added a comment. Herald added subscribers: bviyer, Moerafaat. @omri123 are you interested in rebasing and landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136746 ___ cfe-commits mailing

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4339561 , @awson wrote: > Now, this > > #include > #include > > auto drop1(const std::vector& s){ > return s | std::views::drop(1); > } > > when compiled against gcc's-13.1 libstdc++ spits: > >

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 522165. hazohelet added a comment. Rebase and Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added a comment. @tlively @aaron.ballman pinging both to get final reviews on the LLVM and Clang parts respectively. It would be great to have this merged soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

yaxunl added a comment. Please make sure we can consume old IR using unmangled llvm.amdgcn.permlanex16 by fixing auto upgrade. Otherwise, it may cause regressions for device libs or existing apps. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10487-10488 "a reduction list item with incomplete type %0">; +def err_omp_reduction_minus_type : Error< + "a reduction list item with minus(-) operator is not supported">; +def

[PATCH] D150553: [SVE ACLE] Change the lowering of SVE integer mla_u/mls_u builtins

mgabka added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1665 def int_aarch64_sve_mla_lane : AdvSIMD_3VectorArgIndexed_Intrinsic; +def int_aarch64_sve_mla_u : AdvSIMD_Pred3VectorArg_Intrinsic; def int_aarch64_sve_mls:

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11329 + /// directive. + void ActOnOpenMPImplicitDeclareTarget(Decl *D); + Do I understand correctly, that the variable itself is marked explicitly, but the initializer shall be marked

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D149733#4342095 , @kadircet wrote: >> I think we probably should have a broader discussion before moving forward >> here. It's not

<    1   2   3