[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

ymandel added a comment. I'm a little confused by one of the points in the description: > `setValueStrict()`: The RFC proposes that this should always create the same > StorageLocation for a given Value, but, in fact, the transfer functions that > exist today don't guarantee this; almost all

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:310-317 } else { +auto *InitStmtVal = Env.getValueStrict(*InitStmt); +if (InitStmtVal == nullptr) + return; + auto =

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val =

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:644 +StorageLocation *Environment::getStorageLocationStrict(const Expr ) const { +

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added a comment. Because I have edited the commit messages several times so I forgot to include the revision link. Sorry. I have landed it as https://reviews.llvm.org/rGa423b7f1d7ca8b263af85944f57a69aa08fc942c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) sammccall wrote: > the name "forward" isn't clear to

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. By the way, I'm fed up with the hack that ElementRegion is used for three separate things ("real" array indexing, casts and pointer arithmetic) and I'm thinking about introducing a subclass hierarchy where a base class `ElementLikeRegion` has three subclasses called

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4343281 , @aaron.ballman wrote: > LGTM! Did you end up requesting commit access? If not, now is probably a good > time: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Thanks, I have commit

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240 +// Returns the `Value` associated with `E` (which may be either a prvalue or +// glvalue). Creates a `Value` or `StorageLocation` as needed if `E` does not

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme updated this revision to Diff 522554. mboehme added a comment. Added a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150657/new/ https://reviews.llvm.org/D150657 Files: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

This revision was automatically updated to reflect the committed changes. Closed by commit rG247fa04116a6: [clang] Add a new annotation token: annot_repl_input_end (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/

[clang] a423b7f - [clang-repl] Introduce Value to capture expression results

Author: Jun Zhang Date: 2023-05-16T20:10:49+08:00 New Revision: a423b7f1d7ca8b263af85944f57a69aa08fc942c URL: https://github.com/llvm/llvm-project/commit/a423b7f1d7ca8b263af85944f57a69aa08fc942c DIFF: https://github.com/llvm/llvm-project/commit/a423b7f1d7ca8b263af85944f57a69aa08fc942c.diff

[clang] 247fa04 - [clang] Add a new annotation token: annot_repl_input_end

Author: Jun Zhang Date: 2023-05-16T20:10:43+08:00 New Revision: 247fa04116a6cabf8378c6c72d90b2f705e969de URL: https://github.com/llvm/llvm-project/commit/247fa04116a6cabf8378c6c72d90b2f705e969de DIFF: https://github.com/llvm/llvm-project/commit/247fa04116a6cabf8378c6c72d90b2f705e969de.diff

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) the name "forward" isn't clear to me - if anything

[PATCH] D150553: [SVE ACLE] Change the lowering of SVE integer mla_u/mls_u builtins

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. The commit message is incorrect because the SVE Clang builtins are not named `mla_u` and so should read `SVE integer mla_x/mls_x builtins` Other than that the patch looks

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240 +// Returns the `Value` associated with `E` (which may be either a prvalue or +//

[clang] d4a6e4c - Revert "[Clang] Fix parsing of `(auto(x))`."

Author: Corentin Jabot Date: 2023-05-16T13:56:33+02:00 New Revision: d4a6e4c1eec0f2634febd15725d921d4a25d47e7 URL: https://github.com/llvm/llvm-project/commit/d4a6e4c1eec0f2634febd15725d921d4a25d47e7 DIFF:

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy updated this revision to Diff 522544. donat.nagy edited the summary of this revision. donat.nagy added a comment. I managed to debug the issue that plagued my commit (see `test_multidim_zero()` for details, I think I'll fix it in a followup change); and I have uploaded a new version

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 522545. junaire added a comment. remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D150661: [clang][Interp] Allow evaluating standalone composite expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We reach visitExpr() when evaluating standalone

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

kadircet added a comment. hi! this seem to have regressed compilation for some valid C++ code: struct Bar { const char *name(); }; struct Baz { static Bar *method(); }; struct Foo { Foo(const char *); }; template void bar() { Foo _(T::method()->name()); } void

[PATCH] D150531: Fix start index for sprintf ovlerap check + tests

steakhal added a comment. I think you should squash this into D150430 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150531/new/ https://reviews.llvm.org/D150531 ___

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. Here is the migrated version of the mentioned discussion: https://discourse.llvm.org/t/static-or-dynamic-code-analysis-for-undefined-behavior-in-sprintf/59624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. I like it. How about an implementation like this: void CStringChecker::evalSprintfCommon(CheckerContext , const CallExpr *CE, bool IsBounded) const { ProgramStateRef State = C.getState(); DestinationArgExpr Dest =

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a teeny tiny whitespace nit. Comment at: clang/include/clang/Interpreter/Value.h:27 +// devices where the JIT infrastructure cannot fit. To support that we will need +// to split the memory

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

mkmvzlb added a comment. In D150552#4345391 , @steakhal wrote: > Thanks for the patch. Should I commit this on your behalf? Thanks for reviewing and - in advance - for commit: --author "Michael Klein " Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I believe we are at the stage of better is enemy of good now. This looks good to me. I'd recommend to wait for @aaron.ballman's final review. Repository: rG LLVM Github

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 522530. junaire added a comment. Address comment from Vassil, thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:23 +// +// NOTE: Since the REPL itself could also include this runtime, extreme caution +// should be taken when MAKING CHANGES to this file, especially when INCLUDE NEW I

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 522527. junaire added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 522523. kuganv added a comment. Fixed missing merge that caused build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://reviews.llvm.org/D148088 Files:

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:292 + + bool VisitRecordDecl(RecordDecl *D) { +if (Cfg.InlayHints.EndDefinitionComments && Not sure why if need to handle this + EnumDecl, can we just handle VisitTagDecl

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGd522c2f39d51: [clang] Convert several OpenMP tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is part of the ongoing migration to strict handling of value

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Good job. Looks good to me. This is pretty much analogous to D27717 . The same reasoning applies. Thanks for the patch. Should I commit this on your

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is part of the ongoing migration to

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch handles the straightforward cases.

[PATCH] D150654: [clang][Interp] ComplexFloatingToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

steakhal added a comment. > In C++17 the initialization rules for enum classes are relaxed. In what way are they relaxed compared to regular enums? Anyway, IMO those are indeed FPs, see https://godbolt.org/z/7z984bz6v I'm looking forward to the fix. Thanks. Repository: rG LLVM Github

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is part of the gradual migration to strict

[PATCH] D150652: [clang] Convert a few OpenMP tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/target_update_codegen.cpp:171-173 -// CK1-DAG: [[BP]] = getelementptr inbounds [1 x i8*], [1 x i8*]* [[BPADDR:%[^,]+]], i[[sz]] 0, i[[sz]] 0 -// CK1-DAG: [[P]] = getelementptr inbounds [1 x i8*], [1 x i8*]*

[PATCH] D150652: [clang] Convert a few OpenMP tests to opaque pointers

barannikov88 added a comment. These tests were updated manually, but I verified that the script produces similar results (modulo the cases that it couldn't handle, mostly CHECK-DAG). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150652/new/

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added a comment. Thanks for doing this! Some high-level comments here, will review implementation next: **There seems to be a lot of "decoration" on the hint text.** If declaring a class "Foo" then we add ` /* class ` before and ` */ ` after Foo, for a total of 14 characters apart

[PATCH] D150579: [*]: fix syntax errors in HTML files

VoltrexMaster updated this revision to Diff 522507. VoltrexMaster added a comment. Fix merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150579/new/ https://reviews.llvm.org/D150579 Files:

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Sorry for chiming in. Left a few nit comments and I hope you don't mind. :) Comment at: clang-tools-extra/clangd/InlayHints.cpp:772 + Label = printName(AST, D); +} else { + // We handle type and namespace decls together.

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result,

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

gamesh411 added a comment. Just the test cases are added so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150647/new/ https://reviews.llvm.org/D150647 ___ cfe-commits mailing list

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

gamesh411 created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. gamesh411 requested review of

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

Hahnfeld abandoned this revision. Hahnfeld added a comment. Linker relaxation and proper alignment handling for RISC-V is implemented in https://reviews.llvm.org/D149526, so this isn't needed anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC has a __cpuidex function implemented to call the underlying cpuid instruction which accepts a leaf,

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei created this revision. pengfei added reviewers: rnk, arlosi, thakis, ajpaverd. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result,

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 522471. kuganv added a comment. As per review, moved Preamble indexing into ClangdServer's IndexTasks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://reviews.llvm.org/D148088 Files:

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2b256a99059: Reapply [clang] [test] Narrow down MSVC specific behaviours from any windows… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c2b256a - Reapply [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

Author: Martin Storsjö Date: 2023-05-16T10:41:30+03:00 New Revision: c2b256a990590dc8b69930259650cfeb085add03 URL: https://github.com/llvm/llvm-project/commit/c2b256a990590dc8b69930259650cfeb085add03 DIFF:

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG258c9bebbdfa: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 258c9be - [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

Author: Balázs Kéri Date: 2023-05-16T09:28:14+02:00 New Revision: 258c9bebbdfa793493b71db555f5deb5ade499b4 URL: https://github.com/llvm/llvm-project/commit/258c9bebbdfa793493b71db555f5deb5ade499b4 DIFF: https://github.com/llvm/llvm-project/commit/258c9bebbdfa793493b71db555f5deb5ade499b4.diff

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated-as mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4054c68644df: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated… (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4054c68 - [XCOFF][DWARF] XCOFF64 should be able to select the dwarf format in intergrated-as mode.

Author: esmeyi Date: 2023-05-16T03:02:00-04:00 New Revision: 4054c68644dfebbb584bca698a25d18d1d312bae URL: https://github.com/llvm/llvm-project/commit/4054c68644dfebbb584bca698a25d18d1d312bae DIFF: https://github.com/llvm/llvm-project/commit/4054c68644dfebbb584bca698a25d18d1d312bae.diff LOG:

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

xry111 added a comment. Hmm, I'd tested the change before creating this but it seems those tests are "UNSUPPORTED" on my system :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150582/new/ https://reviews.llvm.org/D150582

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam added a comment. Sure & thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150582/new/ https://reviews.llvm.org/D150582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] b9c0e59 - [Clang][NFC] Present language version in descending publication date

Author: Corentin Jabot Date: 2023-05-16T08:52:44+02:00 New Revision: b9c0e590f1fd4ea37da5c2b9b78d8e715c885f56 URL: https://github.com/llvm/llvm-project/commit/b9c0e590f1fd4ea37da5c2b9b78d8e715c885f56 DIFF:

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

kadircet added a comment. This broke buildbots because `compile_commands.json` being `empty` has other consequences. Fixing forward in 9ffef0f24de0fc05b946e662a7b233a32ad058e3

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); CaprYang wrote: > arsenm

[clang-tools-extra] 9ffef0f - [clangd] Fix builds after 4ddae8b941398a6579d3

Author: Kadir Cetinkaya Date: 2023-05-16T08:44:53+02:00 New Revision: 9ffef0f24de0fc05b946e662a7b233a32ad058e3 URL: https://github.com/llvm/llvm-project/commit/9ffef0f24de0fc05b946e662a7b233a32ad058e3 DIFF:

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:891-895 +for (const FormatToken *Tok = Line->First; Tok; Tok = Tok->Next) { + // Ignore the first token, because in this situation, it applies more + // to the last token of the

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel updated this revision to Diff 522453. rymiel marked an inline comment as done. rymiel added a comment. Start iteration from second token Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150614/new/ https://reviews.llvm.org/D150614 Files:

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

lhames added a comment. FWIW I'm in favor of this: as @jobnoorman mentioned it'd eliminate JITLink's library dependence on MC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 522452. rsundahl added a comment. Missed one file in revert of combined -mllvm= change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files:

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

dmgreen accepted this revision. dmgreen added a comment. Thanks. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 ___ cfe-commits mailing list

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef47318ec361: [Clang] Fix parsing of `(auto(x))`. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/

[clang] ef47318 - [Clang] Fix parsing of `(auto(x))`.

Author: Corentin Jabot Date: 2023-05-16T08:13:54+02:00 New Revision: ef47318ec3615e83c328b07341046dfb9d869414 URL: https://github.com/llvm/llvm-project/commit/ef47318ec3615e83c328b07341046dfb9d869414 DIFF:

[clang] dce89fe - [clang][NFC] Fix a doc comment mixup

Author: Timm Bäder Date: 2023-05-16T08:12:48+02:00 New Revision: dce89fe7212255b5f76fff3b8d55929920f0eb34 URL: https://github.com/llvm/llvm-project/commit/dce89fe7212255b5f76fff3b8d55929920f0eb34 DIFF: https://github.com/llvm/llvm-project/commit/dce89fe7212255b5f76fff3b8d55929920f0eb34.diff

[PATCH] D150632: [IR] Adds Instruction::setNoSanitizeMetadata()

Enna1 created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. Enna1 edited the summary of this revision. Enna1 updated this revision to Diff 522422. Enna1 added a comment. Enna1 added reviewers: nickdesaulniers, MaskRay, vitalybuka. Enna1 added a subscriber: MTC.

<    1   2   3