[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

dyung added a comment. In D141627#4374757 , @tianshilei1992 wrote: > In D141627#4374753 , @Northbadge > wrote: > >> FYI this is failing- >>

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai added a comment. Kinda a follow-up to D121176 . One big alternative that I've considered is to store interface name in `ObjCCategoryDecl` because when we parse `@interface InterfaceName(CategoryName)` we know the interface name. The intention was to

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. DeduceTemplateArgumentsByTypeMatch() returns null value which is dereferenced without checking since getAsIncompleteArrayType()

[clang] c3e7c6e - [NFC][CLANG] Fix static code analyzer concerns

Author: Manna, Soumi Date: 2023-05-25T20:00:24-07:00 New Revision: c3e7c6e9e0809e2626253af584c7d7acfc4ce60b URL: https://github.com/llvm/llvm-project/commit/c3e7c6e9e0809e2626253af584c7d7acfc4ce60b DIFF: https://github.com/llvm/llvm-project/commit/c3e7c6e9e0809e2626253af584c7d7acfc4ce60b.diff

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 525946. vikramRH added a comment. rebase and ping, apologies for the short frequency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files:

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

Northbadge added a comment. FYI this is failing- https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs/FAIL__Clang__bug59160_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627

[clang] 12d8403 - [Clang] Simplify test `clang/test/OpenMP/bug59160.c`

Author: Shilei Tian Date: 2023-05-25T22:12:16-04:00 New Revision: 12d840375d5a81e9ce1050354371c550669de2d7 URL: https://github.com/llvm/llvm-project/commit/12d840375d5a81e9ce1050354371c550669de2d7 DIFF: https://github.com/llvm/llvm-project/commit/12d840375d5a81e9ce1050354371c550669de2d7.diff

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } jacquesguan wrote: > craig.topper wrote: > > michaelmaitland wrote: > > >

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs updated this revision to Diff 525920. codemzs marked 3 inline comments as done. codemzs added a comment. Addresses feedback on extended floating type documentation from @rjmccall and @pengfei CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150913/new/

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

h-vetinari added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource added a comment. In D151325#4374326 , @NoQ wrote: > I totally support this! There's no reason why the region wouldn't carry such > information. > > This patch is surprisingly tiny, but this matches my grep observations: >

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

NoQ added a comment. > By the way, I'm fed up with the hack that ElementRegion is used for three > separate things ("real" array indexing, casts and pointer arithmetic). To fix > this I'm thinking about introducing a subclass hierarchy where a base class > `ElementLikeRegion` has three

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 525902. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. `12d840375d5a81e9ce1050354371c550669de2d7` should fix the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___ cfe-commits

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

MaskRay added a comment. In D150930#4356732 , @jhuber6 wrote: > In D150930#4355240 , @MaskRay wrote: > >> Note: for options controlling individual optimization behaviors, there is a >> large probability that

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz marked an inline comment as done. daiyousei-qz added a comment. Addressed the remaining comments. Thanks everyone for helping review and improve this patch! Comment at: clang-tools-extra/clangd/InlayHints.cpp:802 +Position HintStart = sourceLocToPosition(SM,

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3e7c6e9e080: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525926. chaitanyav marked an inline comment as done. chaitanyav added a comment. Use single backticks for options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[clang-tools-extra] 8683b2f - [clang-tody] Fix typos in documentation

Author: Kazu Hirata Date: 2023-05-25T22:56:06-07:00 New Revision: 8683b2f1a9a1cb899345452dba097dd1d37efd17 URL: https://github.com/llvm/llvm-project/commit/8683b2f1a9a1cb899345452dba097dd1d37efd17 DIFF: https://github.com/llvm/llvm-project/commit/8683b2f1a9a1cb899345452dba097dd1d37efd17.diff

[clang] 9652eba - [clang] Modernize SourceLocation (NFC)

Author: Kazu Hirata Date: 2023-05-25T22:56:08-07:00 New Revision: 9652eba3cfe004cce533445b7e8aedf96451cc6c URL: https://github.com/llvm/llvm-project/commit/9652eba3cfe004cce533445b7e8aedf96451cc6c DIFF: https://github.com/llvm/llvm-project/commit/9652eba3cfe004cce533445b7e8aedf96451cc6c.diff

[clang] b8e3077 - [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

Author: Shilei Tian Date: 2023-05-25T20:19:07-04:00 New Revision: b8e3077d60de73ddcb1511a68af3fdd37fe81cf7 URL: https://github.com/llvm/llvm-project/commit/b8e3077d60de73ddcb1511a68af3fdd37fe81cf7 DIFF: https://github.com/llvm/llvm-project/commit/b8e3077d60de73ddcb1511a68af3fdd37fe81cf7.diff

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai created this revision. vsapsai added reviewers: martong, shafik, ahatanak. Herald added subscribers: ributzka, rnkovacs. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When this happens, it is

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 525922. daiyousei-qz marked 8 inline comments as done. daiyousei-qz added a comment. - Address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

pengfei added inline comments. Comment at: clang/test/Driver/x86-mabi.c:6 + +// CHECK-NOT: {{error|warning}}: +// ERR: error: unsupported option '-mabi=' for target '{{.*}}' What's the expected result for e.g. `x86_64-pc-windows-gnu/mingw/cygnus` ? Repository:

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An extra test for implicit

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:398 + Removed checks Excessive newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added a comment. Confirming your sense that those loops look a bit suspicious, I've found that this makes some implicit conversions ambiguous. Put a test case up for that at D151532 , I think I understand what those loops should be changed to

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e3077d60de: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still… (authored by tianshilei1992). Repository: rG LLVM

[clang] eaf3de6 - [Clang] Fix test case issue introduced by D141627

Author: Shilei Tian Date: 2023-05-25T20:40:57-04:00 New Revision: eaf3de6970fc6e779310a59fbf8f8452f6b34c55 URL: https://github.com/llvm/llvm-project/commit/eaf3de6970fc6e779310a59fbf8f8452f6b34c55 DIFF: https://github.com/llvm/llvm-project/commit/eaf3de6970fc6e779310a59fbf8f8452f6b34c55.diff

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4374753 , @Northbadge wrote: > FYI this is failing- > https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs/FAIL__Clang__bug59160_c Thanks. I pushed a fix in eaf3de6970fc

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM except for a possible typo. Comment at: clang/lib/Headers/avx2intrin.h:412 +///vectors of [16 x i16] and returns the lower 16 bits of each difference +///in

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. rjmccall wrote: > codemzs

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; hokein wrote: > While this patch is an improvement, I wonder we should move it further. >

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan marked 5 inline comments as done. jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } craig.topper wrote: >

[PATCH] D151429: print user provide value in tabstop diagnostic

csmoe added a comment. thanks for your review :) user: csmoe email: cs...@msn.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151429/new/ https://reviews.llvm.org/D151429 ___ cfe-commits mailing list

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

mstorsjo added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 525896. kushanam added a comment. removing commented td entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D151517: Fix wrong error message when compiling C souce code

jyu2 updated this revision to Diff 525894. jyu2 retitled this revision from "Fix couple of problems in uses_allocators clause." to "Fix wrong error message when compiling C souce code". jyu2 edited the summary of this revision. jyu2 added a comment. Thanks Alexey, sure I am separate the patch.

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4374782 , @dyung wrote: > In D141627#4374757 , > @tianshilei1992 wrote: > >> In D141627#4374753 , @Northbadge >> wrote: >>

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

MaskRay added inline comments. Comment at: clang/test/Driver/x86-mabi.c:6 + +// CHECK-NOT: {{error|warning}}: +// ERR: error: unsupported option '-mabi=' for target '{{.*}}' pengfei wrote: > What's the expected result for e.g.

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/x86-mabi.c:6 + +// CHECK-NOT: {{error|warning}}: +// ERR: error: unsupported option '-mabi=' for target '{{.*}}'

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

mboehme updated this revision to Diff 525501. mboehme added a comment. Add check that the value of the expression is true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151201/new/ https://reviews.llvm.org/D151201 Files:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added a comment. Unfortunately I'm seeing a number of Rust optimization regressions with this change. I'll try to reduce those to some PhaseOrdering tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/

[PATCH] D151253: [clangd] Move completion signatures and labelDetails

sammccall updated this revision to Diff 525517. sammccall retitled this revision from "[clangd] Move completion signatures and insertion markers into labelDetails" to "[clangd] Move completion signatures and labelDetails". sammccall edited the summary of this revision. sammccall added a comment.

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added a comment. Here are two inputs that currently fold down to constants and no longer do so with this patch: https://gist.github.com/nikic/4a714ea550bf2252543570585f642af2 These need further reduction for PhaseOrdering tests, but should be a good starting point for analysis...

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:196 + void popCall(const CallExpr *Call, const Environment ); + void popCall(const CXXConstructExpr *Call, const Environment );

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525463. eopXD marked 3 inline comments as done. eopXD added a comment. Address comments from Craig. Now the patch includes changes to vaadd/vaaddu/vasub/vasubu. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1365 defm vaaddu : RISCVSaturatingBinaryAAX; - defm vaadd : RISCVSaturatingBinaryAAX; - defm vaadd_rm : RISCVSaturatingBinaryAAXRoundingMode; + defm

[clang] 2e6325c - Revert "[-Wunsafe-buffer-usage] Group variables associated by pointer assignments"

Author: Douglas Yung Date: 2023-05-25T02:10:32-07:00 New Revision: 2e6325c71feb5ab45ef3dbf4362db38602288a4e URL: https://github.com/llvm/llvm-project/commit/2e6325c71feb5ab45ef3dbf4362db38602288a4e DIFF: https://github.com/llvm/llvm-project/commit/2e6325c71feb5ab45ef3dbf4362db38602288a4e.diff

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan marked 8 inline comments as done. jacquesguan added a comment. https://reviews.llvm.org/D151414 this is the backend part. Comment at: clang/include/clang/Basic/riscv_vector.td:1856 def vfwcvt_f_x_v : RVVConvBuiltin<"Fw", "Fwv", "csi", "vfwcvt_f">; - def

[clang] 0123deb - [Lex] Warn when defining or undefining any builtin macro

Author: John Brawn Date: 2023-05-25T11:55:44+01:00 New Revision: 0123deb3a6f0a83095287f51b07c77b7b43ab847 URL: https://github.com/llvm/llvm-project/commit/0123deb3a6f0a83095287f51b07c77b7b43ab847 DIFF: https://github.com/llvm/llvm-project/commit/0123deb3a6f0a83095287f51b07c77b7b43ab847.diff

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 525531. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham added a comment. > `-fsanitize=kcfi` only supports aarch64 and x86-64 now. riscv64 is on the > plan. > > % fclang -fsanitize=kcfi --traget=armv7-linux-gnueabi -c a.c > clang: error: unsupported option '--traget=armv7-linux-gnueabi' Sorry to contradict, but that error message

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG64413584dacb: [clang][dataflow] Add support for return values of reference type. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6441358 - [clang][dataflow] Add support for return values of reference type.

Author: Martin Braenne Date: 2023-05-25T08:38:33Z New Revision: 64413584dacba1fccffa345f69043b3509ee1745 URL: https://github.com/llvm/llvm-project/commit/64413584dacba1fccffa345f69043b3509ee1745 DIFF: https://github.com/llvm/llvm-project/commit/64413584dacba1fccffa345f69043b3509ee1745.diff

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

dyung added a comment. @t-rasmud I am sorry, but I had to revert your change, it is randomly failing on the Windows bots causing a lot of instability. See the revert commit message for examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added a comment. In D151047#4369742 , @Sedeniono wrote: > To create a new fix, do I understand the guide > correctly that > I basically execute `arc diff --verbatim` and

[clang] 20d6dee - -fsanitize=function: fix alignment fault on Arm targets.

Author: Simon Tatham Date: 2023-05-25T09:22:45+01:00 New Revision: 20d6dee40d507d467d3312d5e7dfdf088f106d31 URL: https://github.com/llvm/llvm-project/commit/20d6dee40d507d467d3312d5e7dfdf088f106d31 DIFF: https://github.com/llvm/llvm-project/commit/20d6dee40d507d467d3312d5e7dfdf088f106d31.diff

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20d6dee40d50: -fsanitize=function: fix alignment fault on Arm targets. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D151308?vs=525111=525479#toc Repository: rG LLVM

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 525494. jacquesguan added a comment. Split into 2 revisions and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files:

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

hans added a comment. This looks right to me. (I'm out of office at the moment, but this looks like what I tested in https://github.com/llvm/llvm-project/issues/62719 so it should work.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

peter.smith added a comment. In D151308#4369828 , @MaskRay wrote: > In D151308#4367704 , @peter.smith > wrote: > >> This looks good to me. Will be worth waiting for a day to give the US time >> zone time to

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a comment. Thanks @aaron.ballman and @erichkeane for your patience in reviewing the patch and steering me in the right direction. What do you think about the other two patches in the series: - https://reviews.llvm.org/D148699 (comes before this one) -

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

chapuni added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:71 - auto CFCtx = llvm::cantFail( - ControlFlowContext::build(*Func, *Body, AST->getASTContext())); This was the only user of Body in

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. > 150ms is more than noticeable Fair enough. I also see we *are* avoiding the quadratic algorithm in other places in inlay hints, and that we can't easily reuse the getHintRange()

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:5064 +bool target() { + return true || false || false || false; +} xazax.hun wrote: > Should we also test

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

simon_tatham added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector ) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return; This whole patch hinges on the unspoken

[PATCH] D151081: [Clang][SVE2.1] Add svpext builtins

CarolineConcatto updated this revision to Diff 525508. CarolineConcatto marked 2 inline comments as done. CarolineConcatto added a comment. Add doxygen comments to FormSVEBuiltinResult function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D150966 should fix the failure that was seen in buildbots, so I've now re-committed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added a comment. In D151047#4369742 , @Sedeniono wrote: > To create a new fix, do I understand the guide > correctly that > I basically execute `arc diff --verbatim` and

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:61 +void IncludeCleanerCheck::storeOptions(ClangTidyOptions::OptionMap ) { + Options.store(Opts, "Suppress", ""); +} after storing them in the class state on

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525473. eopXD added a comment. Bump CI because previous diff failed in patch application. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files:

[clang-tools-extra] a2f7352 - [clangd] Dont run raw-lexer for OOB source locations

Author: Kadir Cetinkaya Date: 2023-05-25T09:38:04+02:00 New Revision: a2f7352f3e809cb1b267e769d00ea84e4ef46bf0 URL: https://github.com/llvm/llvm-project/commit/a2f7352f3e809cb1b267e769d00ea84e4ef46bf0 DIFF:

[PATCH] D151321: [clangd] Dont run raw-lexer for OOB source locations

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f7352f3e80: [clangd] Dont run raw-lexer for OOB source locations (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151321/new/

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz updated this revision to Diff 525448. daiyousei-qz added a comment. - Fix reversed logic of including inactive region token Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 Files:

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:39 + /// Builds a ControlFlowContext from an AST node. `D` is the function in which /// `S` resides. `D.isTemplated()` must

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

sammccall added a comment. Drive-by nit: want add this to the `disableUnusableChecks()` blocklist in `clangd/TidyProvider.cpp`? Since inside clangd we want to use the direct feature instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525452. HerrCai0907 added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. rjmccall wrote: > pengfei

[clang] 246626a - [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

Author: Martin Braenne Date: 2023-05-25T07:19:12Z New Revision: 246626a8cfd3d4f910baadeff4d5aa544b9d4550 URL: https://github.com/llvm/llvm-project/commit/246626a8cfd3d4f910baadeff4d5aa544b9d4550 DIFF: https://github.com/llvm/llvm-project/commit/246626a8cfd3d4f910baadeff4d5aa544b9d4550.diff

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG246626a8cfd3: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148699/new/ https://reviews.llvm.org/D148699

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This is missing all the usual Sema tests that the attribute only applies to functions, takes no arguments, only works in web assembly targets, etc. Also, the changes should come with a release note so users know about

[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

rmaz accepted this revision. rmaz added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/FileEntry.h:124 +/// Directory the file was found in. OptionalDirectoryEntryRef Dir; If this is always set

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This new representation means that if a string is a valid

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

erichkeane added a comment. Just 1 change I'd like, but otherwise this LGTM. Comment at: clang/lib/AST/AttrImpl.cpp:244 + assert(!isAlignmentDependent()); + auto getAlignmentImpl = [&]() -> unsigned { +if (isAlignmentExpr()) { I don't think it makes

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane added a comment. So I have 1 issue that is throughout the patch, but I'm ok with the patch otherwise. This'll get a LGTM after that is fixed. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2902 S.Diag(AL.getRange().getBegin(),

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings added a comment. @phosek you made some alternative suggestions: 1. Have two separate lists of include and exclude flags. 2. Store flags as a tuple (or a struct?) of string and a tag (that is include or exclude). The reason for not doing that is to keep multilib selection method

[PATCH] D151426: [Clang][NFC] Prepare C++ DR suite for better test isolation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM (verified off-list that the regenerated HTML is identical before and after this change), but let's not land this until we've gotten farther along the review

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman added a comment. In D151162#4369717 , @SlaterLatiao wrote: > In D151162#4369584 , @aaron.ballman > wrote: > >> Please be sure to add a release note for the change, and it'd probably be >> good to

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

aaron.ballman added a comment. In D151087#4363503 , @ebevhan wrote: > In D151087#4362059 , @aaron.ballman > wrote: > >> Based on all this, I think we should go with `__addrspace_cast` as a named >> cast and not

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } jacquesguan wrote: > craig.topper wrote: > > Doesn't HasStdExtZvfh

[PATCH] D151426: [Clang][NFC] Prepare C++ DR suite for better test isolation

Endill added a comment. In D151426#4371730 , @aaron.ballman wrote: > The changes LGTM (verified off-list that the regenerated HTML is identical > before and after this change), I've run `make_cxx_dr_status` on top of this patch, and learned that the

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham added a comment. In D151308#4367704 , @peter.smith wrote: > I note that this is also broken in -fsanitize=kcfi [*] > (https://reviews.llvm.org/D135411) although fixing that is a separate patch. > Would you be able to raise a github issue

[PATCH] D151430: [clang][dataflow][NFC] Remove unused variable.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49946df8211e: [clang][dataflow][NFC] Remove unused variable.

[clang] 49946df - [clang][dataflow][NFC] Remove unused variable.

Author: Martin Braenne Date: 2023-05-25T12:09:52Z New Revision: 49946df8211e9d36f0b3755e64b55bc28c0a4247 URL: https://github.com/llvm/llvm-project/commit/49946df8211e9d36f0b3755e64b55bc28c0a4247 DIFF: https://github.com/llvm/llvm-project/commit/49946df8211e9d36f0b3755e64b55bc28c0a4247.diff

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:71 - auto CFCtx = llvm::cantFail( - ControlFlowContext::build(*Func, *Body, AST->getASTContext()));

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings abandoned this revision. michaelplatings added a comment. Abandoning this in favour of D151437 & D151438 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >