[clang] e6135c2 - [clang] Remove unused declaration IgnoreLinkageSpecDecls

Author: Kazu Hirata Date: 2023-05-25T23:31:17-07:00 New Revision: e6135c27b231c43d84cdc92886d807d7e7a84f1f URL: https://github.com/llvm/llvm-project/commit/e6135c27b231c43d84cdc92886d807d7e7a84f1f DIFF: https://github.com/llvm/llvm-project/commit/e6135c27b231c43d84cdc92886d807d7e7a84f1f.diff

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

nridge added a comment. I went ahead and merged this. When you get a chance, could you update https://github.com/llvm/clangd-www/pull/85 as well so we can merge that too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, jdoerfert, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525951. eopXD added a comment. Resolve test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge planned changes to this revision. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; daiyousei-qz wrote: > hokein wrote: > > While this patch

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe7afcf70c93: [clangd] Remove inline Specifier for DefineOutline Tweak (authored by bgluzman, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] fe7afcf - [clangd] Remove inline Specifier for DefineOutline Tweak

Author: Brian Gluzman Date: 2023-05-26T10:43:08+02:00 New Revision: fe7afcf70c93223a16ec7a2a5e07c4ace16c9a04 URL: https://github.com/llvm/llvm-project/commit/fe7afcf70c93223a16ec7a2a5e07c4ace16c9a04 DIFF: https://github.com/llvm/llvm-project/commit/fe7afcf70c93223a16ec7a2a5e07c4ace16c9a04.diff

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

rjmccall added a comment. One slight miscommunication. Otherwise this LGTM, thank you. Comment at: clang/docs/LanguageExtensions.rst:824 +provide native architectural support for arithmetic on these formats. These +targets are noted in the lists of supported targets above. +

[clang] 7c52520 - [Clang][RISCV] Add test coverage for typedef of RVV intrinsic data types under riscv_vector.h. NFC

Author: eopXD Date: 2023-05-26T01:27:37-07:00 New Revision: 7c52520c8d0c44230bf5b480d83f8148bdea3232 URL: https://github.com/llvm/llvm-project/commit/7c52520c8d0c44230bf5b480d83f8148bdea3232 DIFF: https://github.com/llvm/llvm-project/commit/7c52520c8d0c44230bf5b480d83f8148bdea3232.diff LOG:

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 525978. tomasz-kaminski-sonarsource added a comment. Fixed formatting to match clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Thank you! Since the documentation shouldn't be available until LLVM 17, I'm slowly working on it. Let me update the PR in this weekend :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. Is the __riscv_ntl_* interface finalised and agreed? I'm wary of repeating the mistake we made with the V extension where we exposed intrinsics that weren't yet finalised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151537 Files: clang/test/CodeGen/attr-cpuspecific.c

[clang] 52d3255 - [Clang][RISCV] Add description for test case . NFC

Author: eopXD Date: 2023-05-26T00:22:48-07:00 New Revision: 52d3255704187c3e60de8657d6ece7ab73e07b68 URL: https://github.com/llvm/llvm-project/commit/52d3255704187c3e60de8657d6ece7ab73e07b68 DIFF: https://github.com/llvm/llvm-project/commit/52d3255704187c3e60de8657d6ece7ab73e07b68.diff LOG:

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

porglezomp updated this revision to Diff 525974. porglezomp added a comment. Add significantly more variations in this test case. I discovered multiple inconsistencies while expanding this list out. Filed an issue on GitHub here: https://github.com/llvm/llvm-project/issues/62949 Repository:

[PATCH] D151051: [clang-tidy] Optimize misc-confusable-identifiers

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Memoizing the calls to getPrimaryContext()... LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151051/new/

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

nridge accepted this revision. nridge added a comment. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 ___ cfe-commits mailing list

[clang] b92fb33 - [CodeGen] Remove unused member variable NextBlockInfo

Author: Kazu Hirata Date: 2023-05-25T23:41:34-07:00 New Revision: b92fb33409bb46ca3a1a8ead5cbb958b7f130442 URL: https://github.com/llvm/llvm-project/commit/b92fb33409bb46ca3a1a8ead5cbb958b7f130442 DIFF: https://github.com/llvm/llvm-project/commit/b92fb33409bb46ca3a1a8ead5cbb958b7f130442.diff

[clang] 71decdf - [CodeGen] Remove unused declaration EmitMoveFromReturnSlot

Author: Kazu Hirata Date: 2023-05-25T23:52:09-07:00 New Revision: 71decdfee0b0f0ebb066327d8eb1c15146e67d0c URL: https://github.com/llvm/llvm-project/commit/71decdfee0b0f0ebb066327d8eb1c15146e67d0c DIFF: https://github.com/llvm/llvm-project/commit/71decdfee0b0f0ebb066327d8eb1c15146e67d0c.diff

[PATCH] D147894: [clang-format][doc] SortIncludes documentation: remove contradiction in its description

michael-g-matthews added a comment. If this is considered fully approved, would someone with commit access be able to commit this on my behalf? This is my first contribution so I do not have access. My name and email are Mike Matthews and michael.g.matthe...@gmail.com. Thank you! CHANGES

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ugh, yeah, so it has come to this. I championed my idea of granulalizing checkers into modeling and reporting components since what... 2018? I think the goal is still something to shoot

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 525950. tomasz-kaminski-sonarsource added a comment. Updated MoveChecker to handle CXXLifetimeExtendedObjects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 525961. tomasz-kaminski-sonarsource added a comment. Remove excessive reformating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 Files:

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rG6feaa5416bf6: [clangd] Implement configs to stop clangd produce a certain semantic tokens (authored by daiyousei-qz, committed by nridge). Changed prior to commit:

[clang-tools-extra] 6feaa54 - [clangd] Implement configs to stop clangd produce a certain semantic tokens

Author: Qingyuan Zheng Date: 2023-05-26T03:25:35-04:00 New Revision: 6feaa5416bf63f9609478d4458485c7306506e26 URL: https://github.com/llvm/llvm-project/commit/6feaa5416bf63f9609478d4458485c7306506e26 DIFF:

[clang] 10518fe - [clang-format][doc] Fix contradiction in SortIncludes description

Author: Mike Matthews Date: 2023-05-26T01:58:57-07:00 New Revision: 10518feaf33760e77be46af62c41a1caf4ef1da2 URL: https://github.com/llvm/llvm-project/commit/10518feaf33760e77be46af62c41a1caf4ef1da2 DIFF: https://github.com/llvm/llvm-project/commit/10518feaf33760e77be46af62c41a1caf4ef1da2.diff

[PATCH] D147894: [clang-format][doc] SortIncludes documentation: remove contradiction in its description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10518feaf337: [clang-format][doc] Fix contradiction in SortIncludes description (authored by michael-g-matthews, committed by owenpan). Changed

[clang] aed7959 - [clang-format][doc] Fix a typo introduced in 9aab0db13fb6d

Author: Owen Pan Date: 2023-05-26T02:11:42-07:00 New Revision: aed795942b78876d004c146133d9077012256aff URL: https://github.com/llvm/llvm-project/commit/aed795942b78876d004c146133d9077012256aff DIFF: https://github.com/llvm/llvm-project/commit/aed795942b78876d004c146133d9077012256aff.diff

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11940-11943 - ExprResult Callee = getDerived().TransformExpr(E->getCallee()); - if (Callee.isInvalid()) -return ExprError(); - cor3ntin wrote: > I don't understand why we would not

[PATCH] D146987: [Assignment Tracking] Enable by default

hctim added a comment. Hey, found another error that looks to be different from @maskray's revert. $ bin/clang -c -O2 -g -ftrivial-auto-var-init=zero /tmp/repro.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

cor3ntin updated this revision to Diff 526034. cor3ntin added a comment. Address Erich's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151342/new/ https://reviews.llvm.org/D151342 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen updated this revision to Diff 526090. qianzhen added a comment. Update the option text to be more descriptive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 Files:

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

PiotrZSL accepted this revision. PiotrZSL added a comment. In D151431#4376181 , @balazske wrote: > Maybe we can remove the warning in all cases when the type is a POD type (or > add a check option)? **Leave it... **From a user perspective, it doesn't

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 526013. Endill edited the summary of this revision. Endill added a comment. Address feedback Docs contributed by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/fsh.ll:664 +; CHECK-NEXT:[[T1:%.*]] = and i32 [[A:%.*]], -65536 +; CHECK-NEXT:[[T2:%.*]] = call i32 @llvm.fshl.i32(i32 [[T1]], i32 [[T1]], i32 16) ; CHECK-NEXT:ret i32 [[T2]]

[PATCH] D151517: Fix wrong error message when compiling C souce code

jyu2 added a comment. In D151517#4374583 , @ABataev wrote: > Could you split it into 3 separate patch Thanks Alexey! Sure I am split into three. Here is first one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs updated this revision to Diff 526072. codemzs marked an inline comment as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Addresses @rjmccall suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151549: [clang][dataflow] Remove unnecessary `ASTContext` parameter from `ControlFlowContext::build` overload.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When introducing this new overload in

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11940-11943 - ExprResult Callee = getDerived().TransformExpr(E->getCallee()); - if (Callee.isInvalid()) -return ExprError(); - I don't understand why we would not need to transform

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis added inline comments. Comment at: flang/lib/Lower/OpenMP.cpp:2552 + +void handleDeclareTarget(Fortran::lower::AbstractConverter , + Fortran::lower::pft::Evaluation , This seems to be the only function name with the 'handle'

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

This revision was automatically updated to reflect the committed changes. Closed by commit rG75cd8cdbde45: [Clang] Correctly handle generic lambda used as default template argument. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 75cd8cd - [Clang] Correctly handle generic lambda used as default template argument.

Author: Corentin Jabot Date: 2023-05-26T16:04:10+02:00 New Revision: 75cd8cdbde45d07800d5cefa6f7a213271245e4a URL: https://github.com/llvm/llvm-project/commit/75cd8cdbde45d07800d5cefa6f7a213271245e4a DIFF:

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

serge-sans-paille updated this revision to Diff 526059. serge-sans-paille retitled this revision from "[clang] Fix comdat for InlineBuiltin declarations" to "[clang] Restrict Inline Builtin to non-static, non-odr linkage". serge-sans-paille edited the summary of this revision. serge-sans-paille

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske updated this revision to Diff 526063. balazske marked an inline comment as done. balazske added a comment. Fixed the documentation issue. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske added a comment. The case of fully dependent type (`unique_ptr`) is not working in this checker and likely not in `SharedPtrArrayMismatchCheck`. I can fix this in a next patch (for both checkers). Maybe we can remove the warning in all cases when the type is a POD type (or add a check

[PATCH] D151477: [clang][ExtractAPI] Refactor serializer to the CRTP

dang added a comment. LGTM with minor changes Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:58 - virtual ~APISerializer() = default; }; It would be nice to keep this as default, i.e. ``` ~APISetVisitor() = default; ```

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

steakhal added a comment. I think I'm also for this change. I also wonder why we can't enable posix modeling by default. If we still can't, then when will we? Do you think it would make sense to enable them in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151553: [clang] Fix consteval operators in template contexts

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang used to reject consteval operators if they're used inside a template due to TreeTransform putting two different

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 526064. VitaNuo marked 13 inline comments as done. VitaNuo added a comment. Rework according to the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

shafik added a comment. Thank you for the patch! Please apply clang-format at least one of pre-commit failures is due to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151515/new/ https://reviews.llvm.org/D151515

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill added a comment. Thank you for the review! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 526044. pmatos added a comment. Update the patch by removing target specific changes in CGBuiltin. Leave fshl/fshr unchanged for rotates. This actually fixes a todo in fshl/r test. @nikic What do you think of the current patch? Repository: rG LLVM

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added inline comments. Comment at: llvm/test/Transforms/InstCombine/fsh.ll:664 +; CHECK-NEXT:[[T1:%.*]] = and i32 [[A:%.*]], -65536 +; CHECK-NEXT:[[T2:%.*]] = call i32 @llvm.fshl.i32(i32 [[T1]], i32 [[T1]], i32 16) ; CHECK-NEXT:ret i32 [[T2]]

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:159 + anyOf(isInstantiatedFrom(hasAnyName(FunVec)), + hasAnyReturnType(RetTypeVec) .bind("match";

[PATCH] D151517: Fix wrong error message when compiling C souce code

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151517/new/ https://reviews.llvm.org/D151517

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

efriedma added a comment. Relevant bit of the AST: `-ExprWithCleanups 0xd16a780 'void':'void' `-CXXOperatorCallExpr 0xd16a678 'void':'void' '()' |-ImplicitCastExpr 0xd16a5a8 'void (*)(int (&&)[]) const' | `-DeclRefExpr 0xd16a528 'void (int (&&)[]) const' lvalue CXXMethod

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. In D151383#4377043 , @PiotrZSL wrote: > LGTM, you may consider reducing commit message (aka review description by > removing example and error from it, and leaving just plain description of a > change). got it, will make

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers updated this revision to Diff 526192. nickdesaulniers added a comment. - also remove VisitExprWithCleanups, down to two outstanding test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151587/new/

[PATCH] D151581: [clang][modules] NFCI: Distinguish written/effective umbrella directories

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Module.h:655 + /// Retrieve the explicitly written umbrella directory for this module. + DirectoryName

[PATCH] D151388: [HWASan] use hwasan linker for Android 14+

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151388/new/ https://reviews.llvm.org/D151388 ___

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:604 def int_nvvm_f # operation # variant : ClangBuiltin, DefaultAttrsIntrinsic<[llvm_i16_ty], [llvm_i16_ty, llvm_i16_ty], tra wrote: > Availability of these

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > Do we need an install target for `${cuda_wrapper_bits_files}` for the > >

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. apologies, i just realized its a new test that you xfailed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___ cfe-commits mailing

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

MaskRay accepted this revision as: MaskRay. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1356 +Arg *tools::getLastCSProfileGenerateArg(const ArgList ) { + auto *CSPGOGenerateArg =

[clang] 0286b47 - [Driver] Remove redundant -z special case. NFC

Author: Fangrui Song Date: 2023-05-26T19:39:19-07:00 New Revision: 0286b47ae03356853736986f91f85c67115611ae URL: https://github.com/llvm/llvm-project/commit/0286b47ae03356853736986f91f85c67115611ae DIFF: https://github.com/llvm/llvm-project/commit/0286b47ae03356853736986f91f85c67115611ae.diff

[PATCH] D151608: [Sema] Remove unused function getFloat128Identifier

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit bb1ea2d6139a72340b426e114510c46d938645a6 Author: Nemanja Ivanovic Date: Mon May 9

[PATCH] D151607: [AST] Remove unused function removeLocalCVRQualifiers

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last use was removed by: commit 0eb06cb3aa2700508c20da28f22ff91e7b82a436 Author: Roy Jacobson Date: Tue Mar 14

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. i think the extra two failures are not related to you patch. so ignore comment about these libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. Here's a rough proof-of-concept patch coalescing i16/f16/bf16 to use the same Int16Regs register class: https://reviews.llvm.org/D151601 The changes are largely mechanical, replacing `%h` -> `%rs` in the tests and eliminating special cases we previously had for

[clang] af7aea3 - [Driver][test] Replace legacy -target with --target=

Author: Fangrui Song Date: 2023-05-26T19:01:39-07:00 New Revision: af7aea365a2ae8dc51938a614353e1586072ef83 URL: https://github.com/llvm/llvm-project/commit/af7aea365a2ae8dc51938a614353e1586072ef83 DIFF: https://github.com/llvm/llvm-project/commit/af7aea365a2ae8dc51938a614353e1586072ef83.diff

[clang-tools-extra] 7961848 - [clangd] Remove unused declaration onCallHierarchyOutgoingCalls

Author: Kazu Hirata Date: 2023-05-26T20:19:22-07:00 New Revision: 796184854c4db285bef503a4e57cd6c5aa54fa5d URL: https://github.com/llvm/llvm-project/commit/796184854c4db285bef503a4e57cd6c5aa54fa5d DIFF: https://github.com/llvm/llvm-project/commit/796184854c4db285bef503a4e57cd6c5aa54fa5d.diff

[clang] 273303a - [Sema] Remove unused declaration startLambdaDefinition

Author: Kazu Hirata Date: 2023-05-26T20:19:23-07:00 New Revision: 273303ad66a32e5e599bef5ee18c3a9f589e530d URL: https://github.com/llvm/llvm-project/commit/273303ad66a32e5e599bef5ee18c3a9f589e530d DIFF: https://github.com/llvm/llvm-project/commit/273303ad66a32e5e599bef5ee18c3a9f589e530d.diff

[clang] f354e97 - [MemProf] Clean up MemProf instrumentation pass invocation

Author: Teresa Johnson Date: 2023-05-26T17:38:49-07:00 New Revision: f354e971b09c244147ff59eb65b34487755598c0 URL: https://github.com/llvm/llvm-project/commit/f354e971b09c244147ff59eb65b34487755598c0 DIFF:

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

ronlieb added a comment. observing failure in our amdgpu buildbot , 3 tests see: https://lab.llvm.org/staging/#/builders/247/builds/947 7: __tgt_target_table *__tgt_rtl_load_binary(int32_t, __tgt_device_image *): Assertion `Table != nullptr && "Invalid table"' failed. if you have a quick fix,

[PATCH] D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151578/new/ https://reviews.llvm.org/D151578

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > tra wrote: > > qiongsiwu1 wrote: > > > Do we need an install target for `${cuda_wrapper_bits_files}` for the >

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: mattd, gchakrabarti, asavonic, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

shafik added a comment. This PR seems related to this crash: https://github.com/llvm/llvm-project/issues/62958 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307

[clang] e621757 - [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support

Author: M. Zeeshan Siddiqui Date: 2023-05-27T13:33:50+08:00 New Revision: e62175736551abf40a3410bc246f58e650eb8158 URL: https://github.com/llvm/llvm-project/commit/e62175736551abf40a3410bc246f58e650eb8158 DIFF:

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe62175736551: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and… (authored by codemzs, committed by pengfei). Changed prior

[PATCH] D151593: [MemProf] Clean up MemProf instrumentation pass invocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf354e971b09c: [MemProf] Clean up MemProf instrumentation pass invocation (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra updated this revision to Diff 526227. tra added a comment. Verified that install works correctly with individual component installations: cmake -DCOMPONENT=cuda-resource-headers -P ./cmake_install.cmake cmake -DCOMPONENT=clang-resource-headers -P ./cmake_install.cmake Repository: rG

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > qiongsiwu1 wrote: > > tra wrote: > > > qiongsiwu1 wrote: > > > > Do we need an install target for

[clang] ee15c1f - [Sema] Remove unused declaration ConvertIntegerToTypeWarnOnOverflow

Author: Kazu Hirata Date: 2023-05-26T20:07:49-07:00 New Revision: ee15c1fa84c2245866b0a202e896928621401f71 URL: https://github.com/llvm/llvm-project/commit/ee15c1fa84c2245866b0a202e896928621401f71 DIFF: https://github.com/llvm/llvm-project/commit/ee15c1fa84c2245866b0a202e896928621401f71.diff

[clang] 8078e77 - [AST] Remove unused declaration enumerateVFPtrs

Author: Kazu Hirata Date: 2023-05-26T20:07:51-07:00 New Revision: 8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e URL: https://github.com/llvm/llvm-project/commit/8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e DIFF: https://github.com/llvm/llvm-project/commit/8078e776c3c51a2c6620cc1f0d8493a3cc9f8a4e.diff

[clang] 54ab4b3 - [CodeGen] Remove unused declarations emitNonSPMDParallelCall and emitSPMDParallelCall

Author: Kazu Hirata Date: 2023-05-26T20:07:52-07:00 New Revision: 54ab4b3a2847127590cebdf17bc83288b7f03158 URL: https://github.com/llvm/llvm-project/commit/54ab4b3a2847127590cebdf17bc83288b7f03158 DIFF: https://github.com/llvm/llvm-project/commit/54ab4b3a2847127590cebdf17bc83288b7f03158.diff

[PATCH] D151609: [Driver] Remove unused class ForceSuccessCommand

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The last use was removed by: commit 6625680a581c5e29c53d9f58d864cc6cd3cd05f6 Author: Hans Wennborg Date: Tue

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 ___ cfe-commits mailing list

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Thanks for addressing all my concerns. LGTM except for a test issue I just commented on. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status =

[PATCH] D151572: [clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested by @efriedma in: https://reviews.llvm.org/D76096#4370369 Some minor code style fixes as well

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fixes PR#62001. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151575 Files:

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 526144. SlaterLatiao added a comment. - Add newline to end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files:

[PATCH] D151581: [clang][modules] NFCI: Distinguish written/effective umbrella directories

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For modules with

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526159. chaitanyav marked 4 inline comments as done. chaitanyav added a comment. Make changes as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 526163. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( Do we need an install target for `${cuda_wrapper_bits_files}` for the `cuda-resource-headers` component as well? It seems to be

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM, you may consider reducing commit message (aka review description by removing example and error from it, and leaving just plain description of a change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >