[clang] 993060e - [StaticAnalyzer] Fix block pointer type nullability check

Author: tripleCC Date: 2023-05-30T11:20:05+02:00 New Revision: 993060e1d31d07e9c44e7164d24f9f495197ca87 URL: https://github.com/llvm/llvm-project/commit/993060e1d31d07e9c44e7164d24f9f495197ca87 DIFF: https://github.com/llvm/llvm-project/commit/993060e1d31d07e9c44e7164d24f9f495197ca87.diff

[PATCH] D151651: [StaticAnalyzer] Fix block pointer type nullability check

This revision was automatically updated to reflect the committed changes. Closed by commit rG993060e1d31d: [StaticAnalyzer] Fix block pointer type nullability check (authored by tripleCC, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 526559. pmatos added a comment. Fix up some spacing issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 Files: clang/test/CodeGen/WebAssembly/wasm-rotate.c

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 526578. pmatos added a comment. Apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/LanguageExtensions.rst

[clang] 10d6562 - Fix "not all control paths return a value" MSVC warning. NFC.

Author: Simon Pilgrim Date: 2023-05-30T10:33:31+01:00 New Revision: 10d6562ff1bc0009024633b1fd6ab6c3abaea4b7 URL: https://github.com/llvm/llvm-project/commit/10d6562ff1bc0009024633b1fd6ab6c3abaea4b7 DIFF: https://github.com/llvm/llvm-project/commit/10d6562ff1bc0009024633b1fd6ab6c3abaea4b7.diff

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 526558. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D148614: [clang][Interp] Add frame depth checking

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:345-352 + if ((S.Current->getDepth() + 1) > S.getLangOpts().ConstexprCallDepth) { +S.FFDiag(S.Current->getSource(OpPC), + diag::note_constexpr_depth_limit_exceeded) +<<

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/lib/Interpreter/ValuePrinter.cpp:262 + +static llvm::Expected CompileDecl(Interpreter , + Decl *D) { v.g.vassilev wrote: > Let's add a FIXME here. The

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah added a comment. @awarzynski ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/ https://reviews.llvm.org/D151088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

ldrumm created this revision. ldrumm added reviewers: yaxunl, nikic, gandhi21299. Herald added a subscriber: StephenFan. Herald added a project: All. ldrumm requested review of this revision. Herald added a project: clang. The rest of the fetch/op intrinsics were added in e13246a2ec3

[PATCH] D150670: Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 526577. pmatos added a comment. Apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 Files: clang/test/CodeGen/WebAssembly/wasm-rotate.c

[clang] 9c561e8 - [clang] Add test for CWG1397

Author: Vlad Serebrennikov Date: 2023-05-30T12:09:02+03:00 New Revision: 9c561e8f3c2e8292bce9d7b36657144ba26a1c91 URL: https://github.com/llvm/llvm-project/commit/9c561e8f3c2e8292bce9d7b36657144ba26a1c91 DIFF:

[PATCH] D151034: [clang] Add test for CWG1397

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c561e8f3c2e: [clang] Add test for CWG1397 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151034/new/ https://reviews.llvm.org/D151034

[PATCH] D148614: [clang][Interp] Add frame depth checking

tbaeder updated this revision to Diff 526565. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148614/new/ https://reviews.llvm.org/D148614 Files: clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpFrame.h

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. gcc has the same warning so I wasn't expecting this cause to change problems, but looking more closely at gcc's behaviour it looks like it only warns for some builtin macros and not others (though glancing over the gcc source code it's not clear which macros and for

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

mstorsjo added a comment. FWIW, I've also run into noisy warnings caused by this, in a few places. D151662 fixes a bunch of clang's tests when run in MinGW configurations, and

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. small ping for a further review on this if possible! Thank you very much ahead of time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

PiotrZSL added a comment. Not too bad, you on a right road. Tests failed on windows, and clang-format failed. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:86 + llvm::SmallVector MainFileDecls; + for (auto *D : Result.Nodes.getNodeAs("top")->decls())

[clang] 536b76e - [NFC] [serialization] Refactor the outdated AbrrevToUse of VarDecl

Author: Chuanqi Xu Date: 2023-05-30T15:07:35+08:00 New Revision: 536b76e873c56994a7dc611a6081a7a79e9fb526 URL: https://github.com/llvm/llvm-project/commit/536b76e873c56994a7dc611a6081a7a79e9fb526 DIFF: https://github.com/llvm/llvm-project/commit/536b76e873c56994a7dc611a6081a7a79e9fb526.diff

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

mstorsjo added a comment. This causes failed asserts with `_FORTIFY_SOURCE` with the mingw-w64 headers. Here's a reduced reproducer: $ cat reduced.c typedef unsigned int size_t; void *memcpy(void *_Dst, const void *_Src, size_t _Size); extern __inline__

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme added inline comments. Comment at: clang/test/Driver/aix-integrated-as.c:9 +// CHECK-IAS32: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" "-emit-obj" +// CHECK-IAS32: "aix-integrated-as.o" + DiggerLin wrote: > both -fno-integrated-as and -fintegrated-as output

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Thanks for the comments! I'll re-assign the review to Haojian for now, so that we can hopefully make more progress this week. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:48 +void

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 526556. pmatos added a comment. Implement optimization when demanded bits are known, skip otherwise for rotates. @nikic Things look much better now. Thanks for your help with the changes in InstCombine. What do you think? Repository: rG LLVM Github

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/include/clang/Driver/Options.td:1030 NegFlag>; +def mprintf_kind_EQ : Joined<["-"], "mprintf-kind=">, Group, + HelpText<"Specify the printf lowering scheme (AMDGPU only), allowed values are " I'm a bit worried

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 526566. junaire marked 2 inline comments as done. junaire added a comment. Add LLVM preamble Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files:

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149013/new/ https://reviews.llvm.org/D149013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

nikic resigned from this revision. nikic added a comment. (Looks reasonable, but is pretty far outside my area of expertise...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://reviews.llvm.org/D151701

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:211 +struct StringData { + std::string Str = ""; + bool isConst = true; arsenm wrote: > Don't need = "" Can't you just use the raw StringRef out of getConstantStringInfo

[PATCH] D151704: [clang] Add test for CWG873

Endill created this revision. Endill added reviewers: clang-language-wg, shafik, erichkeane. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also add missing marking to the test of related issue 621.

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

PiotrZSL added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/IncludeCleanerTest.cpp:9 +#include + +using namespace clang::tidy::misc; PiotrZSL wrote: > this test file is fine, but there is no validation of output warning. > nwm, somehow I

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Endill accepted this revision. Endill added a comment. This revision is now accepted and ready to land. Thank you! I've asked Aaron what is the best way to check for MSVC-like triple before relanding this test. So today we both learned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5ddb623 - [clang][dataflow] Remove unnecessary `ASTContext` parameter from `ControlFlowContext::build` overload.

Author: Martin Braenne Date: 2023-05-30T07:05:35Z New Revision: 5ddb623952cacba0a3933dacd4c70439ca95c70d URL: https://github.com/llvm/llvm-project/commit/5ddb623952cacba0a3933dacd4c70439ca95c70d DIFF: https://github.com/llvm/llvm-project/commit/5ddb623952cacba0a3933dacd4c70439ca95c70d.diff

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. Friendly ping. Any thoughts on my previous comment @MaskRay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549 ___ cfe-commits

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme updated this revision to Diff 526545. Esme added a comment. Remove unnecessary check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150758/new/ https://reviews.llvm.org/D150758 Files: clang/lib/Driver/ToolChains/AIX.h

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal accepted this revision. steakhal added a comment. Can you commit this change or should I do it on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https://reviews.llvm.org/D150430

[clang] bf916ae - [clang] Solidate the implicit-module-header-maps.cpp lit test.

Author: Haojian Wu Date: 2023-05-30T08:41:36+02:00 New Revision: bf916aeebd8c96c0618a1ccbb01a1517710f8766 URL: https://github.com/llvm/llvm-project/commit/bf916aeebd8c96c0618a1ccbb01a1517710f8766 DIFF: https://github.com/llvm/llvm-project/commit/bf916aeebd8c96c0618a1ccbb01a1517710f8766.diff

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs abandoned this revision. codemzs added a comment. Closing this as it has been resolved by D150913 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 ___

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Those issues focus on `template` keyword being optional in certain

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

hokein added a comment. Thanks for the patch, and sorry for the long delay. You probably need to do a large rebase when updating this patch (since the include-cleaner clangd code has been changed a lot) This is a big patch, touching several pieces (I'd suggest split this patch, and narrow its

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

mstorsjo added a comment. In D150646#4379543 , @glandium wrote: > There seem to still be two problems with this change, with mingw: > > - with `-fms-extensions`: > > echo '#include "cpuid.h"' | ./clang/bin/clang++ > --target=x86_64-w64-windows-gnu

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

mstorsjo added a comment. In D151661#4379958 , @Endill wrote: > Thank you! > I've asked Aaron what is the best way to check for MSVC-like triple before > relanding this test. So today we both learned. Generally, the canonical way to check for it is

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Endill added a comment. In D151661#4380060 , @mstorsjo wrote: > In D151661#4379958 , @Endill wrote: > >> Thank you! >> I've asked Aaron what is the best way to check for MSVC-like triple before >> relanding this

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 526524. codemzs added a comment. Remove unused header file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D151549: [clang][dataflow] Remove unnecessary `ASTContext` parameter from `ControlFlowContext::build` overload.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ddb623952ca: [clang][dataflow] Remove unnecessary `ASTContext` parameter from… (authored by mboehme). Repository: rG LLVM Github Monorepo

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 526519. codemzs retitled this revision from "[Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type" to "[Clang][C++23] Implement core language changes from P1467R9

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

glandium added a comment. In D150646#4380058 , @mstorsjo wrote: > Regarding "fixed" - do you see any better way of fixing it there? As it's a > static inline function, there's no simple way of knowing whether it was > already defined or not; I went

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 526539. pmatos added a comment. Remove test portion attempting to test coroutines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files:

[PATCH] D151696: Remove CPU_SPECIFIC* MACROs and use unified getManglingForCPU

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23136 + TargetVarDecl->hasInit() && TargetVarDecl->hasGlobalStorage()) { +if (auto *Ex = TargetVarDecl->getInit()) + Visit(Ex); Better to expand `auto` here

[PATCH] D151515: [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4433 +// where H is the initializer list. +Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); + } Is `VK_XValue` correct here? The standards quote says it is

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

fahadnayyar updated this revision to Diff 526596. fahadnayyar added a comment. Rebasing to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files:

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

erichkeane added a comment. I don't really see the justification here? Why do this change? If the intent is to just test a newer architecture, we can add tests for that, not change existing ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm updated this revision to Diff 526600. rsandifo-arm added a comment. Avoid most uses of `<< 0`. Add comments to those that remain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148702/new/ https://reviews.llvm.org/D148702 Files:

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

ldrumm added a comment. In D151701#4380666 , @yaxunl wrote: > HIP did not add fetch/sub since fetch/sub x can be trivially implemented > through fetch/add -x and performance-wise equivalent. There is existing isel for `global_atomic_sub` for RDNA

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

MaskRay added a comment. In D150549#4352174 , @jobnoorman wrote: > In D150549#4351614 , @MaskRay wrote: > >> In D150549#4349531 , @jobnoorman >> wrote: >> >>> In

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

MaskRay added a comment. In D151590#4379087 , @qiongsiwu1 wrote: > Thanks for the patch! > > Recently we added the options `mxcoff-roptr` and `mno-xcoff-roptr` > https://reviews.llvm.org/D144190 that fall into this the scope of this patch > (e.g. >

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 526610. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files:

[clang] f64f760 - [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

Author: Manna, Soumi Date: 2023-05-30T08:00:12-07:00 New Revision: f64f760e2d20340ef7d1a95c8598a90e42ac31e7 URL: https://github.com/llvm/llvm-project/commit/f64f760e2d20340ef7d1a95c8598a90e42ac31e7 DIFF: https://github.com/llvm/llvm-project/commit/f64f760e2d20340ef7d1a95c8598a90e42ac31e7.diff

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf64f760e2d20: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

balazske added a comment. There are still some problems with dependencies, the `ErrnoChecker` really needs now the `StdCLibraryFunctions` checker (to be turned on and run before) but this is not enforced. The checker order looks to work but not enforced specially. Repository: rG LLVM

[PATCH] D151727: [clang] Replace dyn_cast with cast in MemRegion::getMemorySpace

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151727/new/ https://reviews.llvm.org/D151727

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

hassnaa-arm added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the

[clang] 0da99ff - [clang][analyzer][NFC] Remove unnecessary casts around Allocate function calls

Author: Dmitri Gribenko Date: 2023-05-30T18:10:15+02:00 New Revision: 0da99ffe1afc526844f4146c95b4b2ab251de1a9 URL: https://github.com/llvm/llvm-project/commit/0da99ffe1afc526844f4146c95b4b2ab251de1a9 DIFF:

[PATCH] D151726: [clang][analyzer][NFC] Remove unnecessary casts around Allocate function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0da99ffe1afc: [clang][analyzer][NFC] Remove unnecessary casts around Allocate function calls (authored by gribozavr). Repository: rG LLVM Github

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

erichkeane added a comment. Is this a builtin that is supposed to model something in the standard? It isn't clear to me how this one is supposed to work. Comment at: clang/test/SemaCXX/type-traits.cpp:3439 + #endif // __cplusplus >= 202002L }; Is there a

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://reviews.llvm.org/D151701

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:104 + ApplyFirstIncludeSpeller() { +for (const auto : + include_cleaner::IncludeSpellingStrategy::entries()) {

[PATCH] D151726: [clang] Remove unnecessary casts around Allocate function calls

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151726/new/ https://reviews.llvm.org/D151726

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 526665. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

tra added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:248 + auto ISAVer = llvm::AMDGPU::getIsaVersion(Opts.CPU); + HasImage = ISAVer.Major != 9 || ISAVer.Minor != 4; } My usual nit about negations: `!(ISAVer.Major == 9 && ISAVer.Minor ==

[PATCH] D151553: [clang] Fix consteval operators in template contexts

erichkeane added a comment. Like @cor3ntin I'm concerned about removing the transform call. I'm just as concerned that it caused no regressions... If we have to transform the arguments, then this can be a dependent thing, which means the callee should be possible to be dependent, right? Thus

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

yaxunl added a comment. HIP did not add fetch/sub since fetch/sub x can be trivially implemented through fetch/add -x and performance-wise equivalent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://reviews.llvm.org/D151701

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This should be rebased after D140744 removed `// REQUIRES: x86_64-target-arch` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

MaskRay updated this revision to Diff 526614. MaskRay added a comment. Handle -mxcoff-roptr as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151590/new/ https://reviews.llvm.org/D151590 Files: clang/include/clang/Driver/Options.h

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151525/new/ https://reviews.llvm.org/D151525 ___ cfe-commits mailing list

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D151623#4380885 , @philnik wrote: > In D151623#4380760 , @erichkeane > wrote: > >> Is this a

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

balazske updated this revision to Diff 526623. balazske added a comment. Updated documentation and removed occurrences of old checker name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151225/new/ https://reviews.llvm.org/D151225 Files:

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4c4c777308: [clang] Extend __is_trivially_equality_comparable to check for hidden friends (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0e4c4c7 - [clang] Extend __is_trivially_equality_comparable to check for hidden friends

Author: Nikolas Klauser Date: 2023-05-30T08:33:31-07:00 New Revision: 0e4c4c77730810db235d377d49ba5860dfa0bd8d URL: https://github.com/llvm/llvm-project/commit/0e4c4c77730810db235d377d49ba5860dfa0bd8d DIFF:

[PATCH] D151725: [clang] Move dyn_cast's into if statements for readability

gribozavr created this revision. gribozavr added a reviewer: NoQ. Herald added subscribers: steakhal, martong. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151721/new/ https://reviews.llvm.org/D151721 ___ cfe-commits mailing list

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

erichkeane added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:994 +static_assert(sobj.f(), ""); // expected-error {{constant expression}} expected-note {{in call to 'sobj.f()'}} +static_assert(sptr->f(), ""); // expected-error {{constant

[PATCH] D151725: [clang] Move dyn_cast's into if statements for readability

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think should mention "NFC" for such commits. Also, we tend to use the "analyzer" tag for CSA related changes. BTW thanks for these simplifications. Repository: rG LLVM Github

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the base

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:23106 +class GlobalDeclRefChecker final +: public ConstStmtVisitor { + SmallVector DeclVector; Use just a StmtVisitor, if you still dropping const modifier. Comment

[clang] 0989ce9 - [clang][analyzer][NFC] Move dyn_cast's into if statements for readability

Author: Dmitri Gribenko Date: 2023-05-30T18:22:43+02:00 New Revision: 0989ce947e3dd64f3e29e7c34f186c0a23c0323d URL: https://github.com/llvm/llvm-project/commit/0989ce947e3dd64f3e29e7c34f186c0a23c0323d DIFF:

[PATCH] D151725: [clang][analyzer][NFC] Move dyn_cast's into if statements for readability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0989ce947e3d: [clang][analyzer][NFC] Move dyn_casts into if statements for readability (authored by gribozavr). Repository: rG LLVM Github

[PATCH] D151709: [Clang][SVE2.1] Add builtins for svrevd

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in:

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

erichkeane added a comment. I'm a little dense today perhaps, but I don't get the use case for this? Can you ELI-EWG? Is this an attribute we expect our users to use? The name is horrifyingly long for users to use, but perhaps that is a good thing. Comment at:

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2902 S.Diag(AL.getRange().getBegin(), diag::err_attribute_wrong_decl_type) -<< AL << ExpectedTypeOrNamespace; +<< AL << 0 <<

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +//

[PATCH] D151623: [clang] Extend __is_trivially_equality_comparable to check for hidden friends

philnik added a comment. In D151623#4380760 , @erichkeane wrote: > Is this a builtin that is supposed to model something in the standard? It > isn't clear to me how this one is supposed to work. No, this is for optimization purposes. It is true when

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

bryanpkc updated this revision to Diff 526621. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134680/new/ https://reviews.llvm.org/D134680 Files: clang/include/clang/Basic/arm_sme.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

awarzynski added a comment. Thanks Tom, mostly makes sense, but I suggest the following: - `EmitMLIR` --> `EmitFIR` (nfc, just clarifying the name), - `EmitHLFIRToFIR` --> `EmitHLFIR` (functional change). More comments inline. Comment at:

[PATCH] D151726: [clang] Remove unnecessary casts around Allocate function calls

gribozavr created this revision. gribozavr added a reviewer: NoQ. Herald added subscribers: steakhal, martong. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D151723: [clang][analyzer][NFC] Remove unnecessary FALLTHROUGH markers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaa95c7de5b7: [clang][analyzer][NFC] Remove unnecessary FALLTHROUGH markers (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES

[clang] daa95c7 - [clang][analyzer][NFC] Remove unnecessary FALLTHROUGH markers

Author: Dmitri Gribenko Date: 2023-05-30T18:16:35+02:00 New Revision: daa95c7de5b7d004bd6c48f5099b7b88f1f5d16d URL: https://github.com/llvm/llvm-project/commit/daa95c7de5b7d004bd6c48f5099b7b88f1f5d16d DIFF:

[clang] d6e1909 - Mark header as textual

Author: Adrian Prantl Date: 2023-05-30T09:21:39-07:00 New Revision: d6e1909526fea196e20566d7d66c1b6ca04fa9e5 URL: https://github.com/llvm/llvm-project/commit/d6e1909526fea196e20566d7d66c1b6ca04fa9e5 DIFF: https://github.com/llvm/llvm-project/commit/d6e1909526fea196e20566d7d66c1b6ca04fa9e5.diff

  1   2   3   >