[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added a comment. I am thinking we probably want to rename the option as -fhip-emit-relocatable and limit it to be used with -cuda-device-only and -fno-gpu-rdc only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.l

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel marked 4 inline comments as done. ymandel added a comment. Rebased, thanks! Comment at: clang/include/clang/Analysis/Analyses/IntervalPartition.h:73 + + // Whether this node is the head of a feedback edge within the interval. + bool IsFeedbackHead = false; ---

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added a comment. In D153667#4455998 , @jhuber6 wrote: > In D153667#4455943 , @yaxunl wrote: > >> For -fno-gpu-rdc case we do not use lto. Since -fno-gpu-rdc has one TU only, >> we use the non-lto backend t

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes added a comment. In D153667#4450724 , @jhuber6 wrote: > In D153667#4450705 , @jrbyrnes > wrote: > >> In D153667#4450517 , @jhuber6 >> wrote: >> >>> What's the d

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Test failure is clang-format on ASTConsumers.cpp. Fix that please (whatever it wants?) otherwise, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D153798: [clang-format] Correctly annotate operator free function call

rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:319 + Prev->Previous->isOneOf(tok::period, tok::arrow)) || + (!Line.MustBeDeclaration && !Line.InMacroBody); Contexts.back().IsExpression = OperatorCalledAsMemberFunction;

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 535414. yronglin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h clan

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

tianshilei1992 added a comment. I think it's better to just limit it to AMDGPU for now. BTW, it might be worth to check if heap-to-stack will push it back to stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/

[clang] 00971f0 - [NFC][Doc] Update feature support doc `clang/docs/OpenMPSupport.rst` to correct

Author: Shilei Tian Date: 2023-06-28T11:07:29-04:00 New Revision: 00971f08604b29437af806263737a131bab1cf49 URL: https://github.com/llvm/llvm-project/commit/00971f08604b29437af806263737a131bab1cf49 DIFF: https://github.com/llvm/llvm-project/commit/00971f08604b29437af806263737a131bab1cf49.diff L

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet updated this revision to Diff 535418. courbet added a comment. Add a specific message for return-by-ref of `pt_guarded_by` variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 Files: clang/

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535419. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h c

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added a comment. In D153131#4456019 , @aaronpuchert wrote: > Tried this on our code base, and the number of new warnings seems acceptable. > I'll still need to look through them in more detail, but there is one > suspicious warning that boils d

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

arsenm added a comment. In D153883#4456342 , @tianshilei1992 wrote: > I think it's better to just limit it to AMDGPU for now. > BTW, it might be worth to check if heap-to-stack will push it back to stack. If you're really going to go for backend workaro

[PATCH] D153883: [Clang][OpenMP] Enable use of __kmpc_alloc_shared for VLAs defined in AMD GPU offloaded regions

ABataev added a comment. In D153883#4456342 , @tianshilei1992 wrote: > I think it's better to just limit it to AMDGPU for now. I rather doubt this is a good decision. Better to support for all targets. NVPTX supports(ed) (IIRC) static allocation and in

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 535425. eopXD marked 2 inline comments as done. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/includ

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang added a comment. Starting to come together nicely, but I think now would be a good time to write some tests. I am particularly interested in more complex situations like inheritance hierarchies. Comment at: clang/include/clang/ExtractAPI/API.h:25 #include "clang/Basic/S

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

nicolerabjohn added a comment. In D152818#4442116 , @rjmccall wrote: > Does https://reviews.llvm.org/D143241 solve the original problem here, or is > there something deeper? It does not solve the problem, at least for my test case (linked in https://gi

[PATCH] D153908: [dataflow] Use consistent, symmetrical, non-mutating erased signature for join()

ymandel added a comment. LGTM, thanks Sam! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153908/new/ https://reviews.llvm.org/D153908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/IntervalPartitionTest.cpp:21 +namespace { +template using NodeData = CFGInterval::NodeData; +} // namespace Another redundant anonymous namespace here. Repository: rG LLVM Github Monorep

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIActionBase.h:25 +/// +/// Deriving from this class equipts an action with all the necessary tools to +/// generate ExractAPI information in form of symbol-graphs

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456483 , @nicolerabjohn wrote: > In D152818#4442116 , @rjmccall > wrote: > >> Does https://reviews.llvm.org/D143241 solve the original problem here, or is >> there somethin

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

hazohelet updated this revision to Diff 535433. hazohelet marked an inline comment as done. hazohelet edited the summary of this revision. hazohelet added a comment. Removed FIXME comment that is already addressed in D153690 CHANGES SINCE LAST ACTION https:/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:78 +// The value '7' is a hint to this pass to not alter the frm value. +if (FRMImm == 7) + continue; Use `RISCVFPRndMode::DYN`? =

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 535438. eopXD marked 6 inline comments as done. eopXD added a comment. Address more comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:21 #include "llvm/ADT/StringSwitch.h" +#include "llvm/CodeGen/MachineInstr.h" #include "llvm/MC/MCInstrDesc.h" We can't include a CodeGen header in MCTargetDesc

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:78 + +// The value '7' is a hint to this pass to not alter the frm value. +if (FRMImm == RISCVFPRndMode::DYN) Don't write 7 here Repository: rG L

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

rsmith added a comment. I think the behavior change for the testcase here is correct, though I'm not sure that the patch is getting that behaviour change in the right way. Per [temp.type]/1.4 (http://eel.is/c++draft/temp.type#1.4), > Two template-ids are the same if [...] their corresponding te

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10395-10399 +if (CGF.ConstantFoldsToSimpleInteger(IfCond, CondConstant)) { + IfCondVal = CGF.Builder.getInt1(CondConstant); +} else { + IfCondVal = CGF.EvaluateExprAsBool(IfCond); +

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 535446. eopXD marked 2 inline comments as done. eopXD added a comment. Address more comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 ___

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/IntervalPartition.cpp:121 +Index.emplace(N, ID); + Graph.Intervals.emplace_back(ID, Header, std::move(Data.Nodes)); } It would probably take for me some time to understand what is going on here

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb added a comment. Per this Discourse post , I think it'd be best for the example I asked to be in your commit message to actually be in your release notes. Sorry for the churn! CHANGES SINCE LAST ACTION

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek created this revision. phosek added reviewers: smeenai, beanz. Herald added subscribers: Enna1, abrachet, dberris. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. On Linux crt

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek updated this revision to Diff 535452. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 Files: compiler-rt/CMakeLists.txt compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/lib/CMakeLists.txt

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/IntervalPartition.cpp:121 +Index.emplace(N, ID); + Graph.Intervals.emplace_back(ID, Header, std::move(Data.Nodes)); } xazax.hun wrote: > It would probabl

[PATCH] D153954: [WIP][clang][analyzer] Relax alpha.cplusplus.EnumCastOutOfRange checker

shafik added a comment. I did not look at this in detail but I don't think this approach is correct. I fixed this for constant evaluation the other day and you can find the details here: D130058 The test suite I wrote should be sufficient for you to validate y

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

aaron.ballman added a comment. In D152818#4456510 , @zahiraam wrote: > In D152818#4456483 , @nicolerabjohn > wrote: > >> In D152818#4442116 , @rjmccall >> wrote: >> >>>

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 535455. TIFitis marked an inline comment as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10395-10399 +if (CGF.ConstantFoldsToSimpleInteger(IfCond, CondConstant)) { + IfCondVal = CGF.Builder.getInt1(CondConstant); +} else { + IfCondVal = CGF.EvaluateExprAsBool(IfCond); +

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes updated this revision to Diff 535456. jrbyrnes added a comment. Naming + -cuda-device-only and -fno-gpu-rdc only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/clang/Drive

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. Thank you for taking a look! I found a bunch of issues pointing at the same diagnostics, but I'm not sure if they track exactly what I test here: https://github.com/llvm/llvm-project/issues/17775 https://github.com/llvm/llvm-project/issues/36539 https://github.com/llvm/llv

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; Can you pass `<< BS.getSourceRange()` here?

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 535459. schittir added a comment. Hope clang-format likes this patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892 Files: clang/lib/ARCMigrate/TransProperties.cpp clang/lib/AST/ExprConstant.cpp c

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456717 , @aaron.ballman wrote: > In D152818#4456510 , @zahiraam > wrote: > >> In D152818#4456483 , >> @nicolerabjohn wrote: >> >>>

[PATCH] D153957: [C++20] [Modules] Allow Stmt::Profile to treat lambdas as equal conditionally

shafik added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:188 StmtProfilerWithoutPointers(llvm::FoldingSetNodeID &ID, ODRHash &Hash) -: StmtProfiler(ID, false), Hash(Hash) {} +: StmtProfiler(ID, false, false), Hash(Hash) {} ni

[PATCH] D153857: [clang] Fix new-expression with elaborated-type-specifier

shafik added a comment. In D153857#4455480 , @Fznamznon wrote: >> MSVC rejects the first but accepts the second which I think is wrong but >> worth testing: >> >> alignof(struct B {}); >> sizeof(struct B{}); > > These don't have `new` so they are not aff

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

schittir updated this revision to Diff 535466. schittir added a comment. Not sure what clang-format wants. I hope it likes this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153926/new/ https://reviews.llvm.org/D153926 Files: clang/include/clang/AST/RawCommentList.h clang/in

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3335-3337 +bool IsRDCMode = Args.hasFlag(options::OPT_fgpu_rdc, + options::OPT_fno_gpu_rdc, false); +bool DeviceOnly = C.getDriver().offloadDeviceOnly(); ---

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7374 auto *E = ExprWithCleanups::Create( Context, SubExpr, Cleanup.cleanupsHaveSideEffects(), Cleanups); Because we may potentially pass some cleanups here (which are outs

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a comment. I don't think it's correct to assume that all string arguments to attributes are unevaluated, but it is hard to tell where to draw the line sometimes. Backing up a step, as I understand P2361 , an unevaluated string is one which is

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

aaron.ballman added a comment. In D152818#4456797 , @zahiraam wrote: > In D152818#4456717 , @aaron.ballman > wrote: > >> In D152818#4456510 , @zahiraam >> wrote: >> >>>

[PATCH] D153580: [SystemZ][z/OS] Add support for z/OS link step (executable and shared libs)

zibi accepted this revision. zibi added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153580/new/ https://reviews.llvm.org/D153580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 535472. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

dblaikie added a comment. Got some details on how much this costs? (eg: `bloaty` comparison for a clang bootstrap with/without this patch applied?) Could you provide a quick summary of why this debug info is required? The definition should be provided in whatever translation unit defines the var

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added a subscriber: cfe-commits. probinson added a comment. + cfe-commits which didn't get added automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 ___ cfe-commits mailing list

[clang] 85bdea0 - clang: Use new frexp intrinsic for builtins and add f16 version

Author: Matt Arsenault Date: 2023-06-28T14:50:17-04:00 New Revision: 85bdea023f5116f789095b606554739403042a21 URL: https://github.com/llvm/llvm-project/commit/85bdea023f5116f789095b606554739403042a21 DIFF: https://github.com/llvm/llvm-project/commit/85bdea023f5116f789095b606554739403042a21.diff

[PATCH] D149716: clang: Use new frexp intrinsic for builtins and add f16 version

arsenm closed this revision. arsenm added a comment. 85bdea023f5116f789095b606554739403042a21 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149716/new/ https://reviews.llvm.org/D149716 __

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

jrbyrnes updated this revision to Diff 535484. jrbyrnes added a comment. Use member variabls + add diagnostic + tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/clang/Driver/Op

[clang] bf8e92c - HIP: Use frexp builtins in math headers

Author: Matt Arsenault Date: 2023-06-28T15:06:54-04:00 New Revision: bf8e92c0e792cbe3c9cc50607a1e33c6912ffd0e URL: https://github.com/llvm/llvm-project/commit/bf8e92c0e792cbe3c9cc50607a1e33c6912ffd0e DIFF: https://github.com/llvm/llvm-project/commit/bf8e92c0e792cbe3c9cc50607a1e33c6912ffd0e.diff

[clang] 82a3969 - Revert "[Clang] Reset FP options before function instantiations"

Author: Serge Pavlov Date: 2023-06-29T02:07:41+07:00 New Revision: 82a3969d710f5fb7a2ee4c9afadb648653923fef URL: https://github.com/llvm/llvm-project/commit/82a3969d710f5fb7a2ee4c9afadb648653923fef DIFF: https://github.com/llvm/llvm-project/commit/82a3969d710f5fb7a2ee4c9afadb648653923fef.diff

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

Fznamznon updated this revision to Diff 535489. Fznamznon added a comment. Rebase, don't use MaybeCreateExprWithCleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153962/new/ https://reviews.llvm.org/D153962 Files: clang/docs/ReleaseNotes.rs

[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. I checked the ISA manual about mbcnt and I agree that its value should only depend on thread position in warp and not on CFG. It is possible that the side effect of preventing it from merging

[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

zahiraam added a comment. In D152818#4456872 , @aaron.ballman wrote: > In D152818#4456797 , @zahiraam > wrote: > >> In D152818#4456717 , >> @aaron.ballman wrote: >> >>>

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman added a comment. In D105759#4456864 , @aaron.ballman wrote: > I don't think it's correct to assume that all string arguments to attributes > are unevaluated, but it is hard to tell where to draw the line sometimes. > Backing up a step, as

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 535491. sammccall added a comment. rebase, primarily on the SAT-inputs-are-ordered change (SetVector etc) clarify that Formula::print output is supposed to be reliably stable. This is useful for testing downstream analyses: having a representation of formul

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#4456864 , @aaron.ballman wrote: > I don't think it's correct to assume that all string arguments to attributes > are unevaluated, but it is hard to tell where to draw the line sometimes. > Backing up a step, as I un

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. new changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3328-3330 + CompileDeviceOnly = C.getDriver().offloadDeviceOnly(); + Relocatable = Args.hasFlag(options::OPT_fgpu_rdc, + options::OPT_fno_gpu_rdc, /*Default=*/false); -

[clang] 3cf8b98 - [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

Author: Nikolas Klauser Date: 2023-06-28T13:34:02-07:00 New Revision: 3cf8b982042e91d9aabb880ccc7a556256187ff9 URL: https://github.com/llvm/llvm-project/commit/3cf8b982042e91d9aabb880ccc7a556256187ff9 DIFF: https://github.com/llvm/llvm-project/commit/3cf8b982042e91d9aabb880ccc7a556256187ff9.dif

[PATCH] D153890: [clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cf8b982042e: [clang] Fix checking the equality comparator of base classes in… (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

HazardyKnusperkeks added a comment. Is this still an issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89918/new/ https://reviews.llvm.org/D89918 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D154000: HIP: Directly call round builtins

arsenm created this revision. arsenm added reviewers: JonChesterfield, yaxunl, jhuber6. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Pretty sure these lround->round cases are just wrong https://reviews.llvm.org/D154000 Files: clang/li

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added a comment. As mentioned, you may consider landing llvm patch then wait a bit so that (a) people can experiment with the clang patch better (b) prevent the llvm/clang patches to be both reverted, if some issue has been identified with the llvm patch. (Don't worry that a feature doe

[PATCH] D153600: Implement -frecord-command-line for XCOFF

scott.linder added a comment. Sorry for the delay in review, I am not too familiar with XCOFF so I was hoping someone else would take a look first. If my understanding of the COFF docs I could find is correct then this LGTM save for some nits/suggestions Comment at: llvm/lib

[clang] fe65043 - HIP: Directly call floor builtins

Author: Matt Arsenault Date: 2023-06-28T16:57:53-04:00 New Revision: fe65043a67c85345887339f371cca1a0c735a639 URL: https://github.com/llvm/llvm-project/commit/fe65043a67c85345887339f371cca1a0c735a639 DIFF: https://github.com/llvm/llvm-project/commit/fe65043a67c85345887339f371cca1a0c735a639.diff

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

jrbyrnes updated this revision to Diff 535519. jrbyrnes marked 3 inline comments as done. jrbyrnes added a comment. Address Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/c

[PATCH] D153667: [HIP]: Add -fhip-emit-relocatable to override link job creation for -fno-gpu-rdc

jrbyrnes added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3328-3330 + CompileDeviceOnly = C.getDriver().offloadDeviceOnly(); + Relocatable = Args.hasFlag(options::OPT_fgpu_rdc, + options::OPT_fno_gpu_rdc, /*Default=*/false);

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

chiyuze added a comment. Regarding cost, only BPF target triggers this debug info generation for extern variables. There is no impact on x86 builds of clang: Without patch: bloaty build/RelWithDebInfo/83d47ba15a1229a21aaca8a8d6a33e0e90aabfd4/bin/clang FILE SIZEVM SIZE ---

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 8ed7aa59f489715d39d32e72a787b8e75cfda151

[PATCH] D153926: [NFC] Initialize class member pointers to nullptr.

owenpan accepted this revision. owenpan added a comment. In D153926#4456833 , @schittir wrote: > Not sure what clang-format wants. I hope it likes this patch. The clang-format part LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

MaskRay added a comment. I wonder whether you have ready-to-use instructions to test this for folks who are not familiar with Linux kernel/eBPF. (I happened to start to read eBPF one week ago, but I guess it would take some time for me to be more familiar with it, even if I contributed some stu

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

MaskRay added a comment. > This patch is required so that we can still use kconfig in such BPF programs > compiled from C++. Assuming that you mean https://www.kernel.org/doc/html/next/kbuild/kconfig-language.html#kconfig-language , how is Kconfig relevant here? Clang BPF supports `-mcpu=v[12

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

owenpan added a comment. This is no longer an issue in version 17, e.g. 7a4cdbe : $ clang-format void main() { // clang-format off #define Sum(x, y) ((x) + (y)) Sum(1, 2); #undef Sum // clang

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn updated this revision to Diff 535546. Caslyn marked 12 inline comments as done. Caslyn added a comment. Changes per review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152953/new/ https://reviews.llvm.org/D152953 Files: clang-tools-extr

[PATCH] D152953: [clang-tidy] Introduce fuchsia-global-variables check

Caslyn added a comment. Hi Piotr - I'm sorry for the delay in getting back to you. Thank you again for your review comments. I did my best trying to get the right combination of matchers that limit the candidates and allow the exceptions that we want. I wasn't successful in figuring out a way t

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik added a comment. I think I am going to land this as is and if we can come up w/ an example that covers the `annot_typename` I can do a follow-up. As this is now it fixes a crash bug. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

efriedma added a comment. I'm not confident that isUsed() works the way you want it to in this context. In particular, if the code in question runs before we've translated the whole translation unit, the isUsed() bit could change. If you want that's more obviously safe, you could just check i

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

rnk added a comment. Can you please add a test case for the issue that caused the revert? I wanted to dig into that to try to understand why the extra copy was being emitted. I think you mentioned it has something to do with increasing the alignment. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang added a comment. In D154007#4457561 , @efriedma wrote: > I'm not confident that isUsed() works the way you want it to in this context. > In particular, if the code in question runs before we've translated the > whole translation unit, the isUse

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5103 -if (Addr.getAlignment() < Align && +if (CallInfo.isDelegateCall()) { + NeedCopy = false; akhuang wrote: > I think the problem is that it tries to do a copy here b

[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5103 -if (Addr.getAlignment() < Align && +if (CallInfo.isDelegateCall()) { + NeedCopy = false; rnk wrote: > akhuang wrote: > > I think the problem is that it tries

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

evelez7 updated this revision to Diff 535559. evelez7 marked 6 inline comments as done. evelez7 added a comment. Address some review feedback Remove RK_Struct, RK_Union from CXXClassRecord::classof, use std::string for AccessControl, style and remove unused imports Repository: rG LLVM Github

[PATCH] D154016: [clang][modules] Avoid serializing all diag mappings in non-deterministic order

benlangmuir created this revision. benlangmuir added reviewers: steven_wu, jansvoboda11, akyrtzi. Herald added a subscriber: mgrang. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When writing a pcm

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

ellis abandoned this revision. ellis added a comment. Moved to https://reviews.llvm.org/D154014 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152762/new/ https://reviews.llvm.org/D152762 ___ cfe-commits

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

ellis created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: MaskRay, phosek, vitalybuka, samsonov, hctim. ellis updated this revision to Diff 535560. ellis added a comment. ellis published this rev

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

avl added a comment. this LGTM. please, wait if James has any concern. Comment at: llvm/unittests/Support/raw_ostream_test.cpp:525 + ASSERT_TRUE(Perms) << "should be able to get permissions"; + // Verify that writeToOutput doesn't set exe bit. + EXPECT_EQ(Perms.get(), llvm::

[PATCH] D153898: [DebugInfo] Enable debug info emission for extern variables in C++

dblaikie accepted this revision. dblaikie added a comment. In D153898#4457263 , @chiyuze wrote: > Regarding cost, only BPF target triggers this debug info generation for > extern variables. Ah, OK - if that's what you need for BPF and it doesn't affect

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4457209 , @MaskRay wrote: > As mentioned, you may consider landing llvm patch then wait a bit so that (a) > people can experiment with the clang patch better (b) prevent the llvm/clang > patches to be both reverted,

[PATCH] D154014: [SpecialCaseList] Use Globs instead of Regex

MaskRay added a comment. > This is a breaking change since some SCLs might use .* or (abc|def) which are > supported regexes but not valid globs. Since we have just cut clang 16.x this > is a good time to make this change. My user has some ignore lists, but there is no `^[a-z]+:.*\(` or `^[a-z]

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

<    1   2   3   >