[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

2023-07-01 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154191/new/ https://reviews.llvm.org/D154191 ___ cfe-commits mailing

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread Haohai, Wen via Phabricator via cfe-commits
HaohaiWen updated this revision to Diff 536518. HaohaiWen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D154191: [LTO] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

2023-07-01 Thread Haojian Wu via Phabricator via cfe-commits
hokein closed this revision. hokein added a comment. committed in 6ecc6b1250b253816703cbca18af432b95fb4089 and dc6c8b8d1e357acf6440824afaf6b6547b34aeeb .

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. I'd really prefer you put what you need to modify `mutable` instead of removing the `const` from everything else. But that's just my opinion. Comment at: clang/include/clang/Format/Format.h:1905 + /// + /// In C: /// \code

[PATCH] D153741: [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation.

2023-07-01 Thread Alexey Lapshin via Phabricator via cfe-commits
avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. LGTM. please pay attention to the clang format issues reported during pre-merge build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153741/new/

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149084: [clang-tidy] Added bugprone-multi-level-implicit-pointer-conversion check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149084/new/ https://reviews.llvm.org/D149084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/ https://reviews.llvm.org/D153298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153423/new/ https://reviews.llvm.org/D153423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152713: [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152713/new/ https://reviews.llvm.org/D152713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151495: [clang-tidy] Improve build-in type handling in bugprone-swapped-arguments

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151495/new/ https://reviews.llvm.org/D151495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152713: [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression

2023-07-01 Thread Evgeny Shulgin via Phabricator via cfe-commits
Izaron accepted this revision. Izaron added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152713/new/ https://reviews.llvm.org/D152713

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Ok, thanks for clarifying. However I still don’t understand the “why” aspect here. You’re writing > so that lld specific flags can be append before inputs Are you planning on adding such flags in a later patch, position dependent flags that need to be supplied

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D154176#4466186 , @mstorsjo wrote: > Ok, thanks for clarifying. However I still don’t understand the “why” aspect > here. You’re writing > >> so that lld specific flags can be append before inputs > > Are you planning on

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread Haohai, Wen via Phabricator via cfe-commits
HaohaiWen added a comment. In D154176#4466190 , @mstorsjo wrote: > In D154176#4466186 , @mstorsjo > wrote: > >> Ok, thanks for clarifying. However I still don’t understand the “why” aspect >> here. You’re

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

2023-07-01 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - but it would be good to fix silvermont / westmere cases as well with suitable test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153458: [clang-tidy] Model noexcept more properly in bugprone-exception-escape

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153458/new/ https://reviews.llvm.org/D153458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152713: [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc1dc914a8ca2: [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] c1dc914 - [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression

2023-07-01 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-07-01T16:20:38Z New Revision: c1dc914a8ca240650d7411d25c75ad7e2a5974e9 URL: https://github.com/llvm/llvm-project/commit/c1dc914a8ca240650d7411d25c75ad7e2a5974e9 DIFF: https://github.com/llvm/llvm-project/commit/c1dc914a8ca240650d7411d25c75ad7e2a5974e9.diff LOG:

[PATCH] D154284: [C11] Correct global atomic pointer initialization from an integer constant

2023-07-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: efriedma, rjmccall. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This is a follow-up to 2e275e24355cb224981f9beb2b026a3169fc7232

[PATCH] D154151: [clang-tidy] Improve documentation for modernize-use-std-print check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8fdbc8712c5b: [clang-tidy] Improve documentation for modernize-use-std-print check (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8fdbc87 - [clang-tidy] Improve documentation for modernize-use-std-print check

2023-07-01 Thread Piotr Zegar via cfe-commits
Author: Mike Crowe Date: 2023-07-01T08:40:21Z New Revision: 8fdbc8712c5b65617331b3de43bedd302e9cdbc1 URL: https://github.com/llvm/llvm-project/commit/8fdbc8712c5b65617331b3de43bedd302e9cdbc1 DIFF: https://github.com/llvm/llvm-project/commit/8fdbc8712c5b65617331b3de43bedd302e9cdbc1.diff LOG:

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

2023-07-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Give the author some time is okay, but I think we can and should commandeer at some point and abandon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89918/new/ https://reviews.llvm.org/D89918

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

2023-07-01 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:223 - if (SpaceOffset != 0) -return BreakableToken::Split(SpaceOffset + 1, 0); + if (NewLine != 0) +return BreakableToken::Split(NewLine, 0);

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

2023-07-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:223 - if (SpaceOffset != 0) -return BreakableToken::Split(SpaceOffset + 1, 0); + if (NewLine != 0) +return BreakableToken::Split(NewLine, 0); What if the new

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

2023-07-01 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 536531. sstwcw added a comment. - Add tests for newline outside of column limit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files:

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

2023-07-01 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154283: [clang-tidy] Fix width/precision argument order in modernize-use-std-print

2023-07-01 Thread Mike Crowe via Phabricator via cfe-commits
mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

2023-07-01 Thread Iain Sandoe via Phabricator via cfe-commits
iains updated this revision to Diff 536524. iains added a comment. rebased, fixed some format issues; again to support p1815 work only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files:

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

2023-07-01 Thread Iain Sandoe via Phabricator via cfe-commits
iains planned changes to this revision. iains added a comment. changes are needed to address review comments - but this revision is needed as a parent to other work (so might need to be rebased from time to time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-07-01 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: openmp/runtime/test/target/target_thread_limit.cpp:28 +// OMP51: target: parallel +// OMP51: target: parallel + This doesn't check much. You need to verify a 5th or print the team size. Same for the rest

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3896 llvm::Type *OrigBaseElemTy = Addr.getElementType(); -Addr = Builder.CreateElementBitCast(Addr, Int8Ty); barannikov88 wrote: > jrtc27 wrote: > > This one isn't a direct

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] jrtc27 wrote: > jrtc27 wrote: > > JOE1994

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Nikita Popov via Phabricator via cfe-commits
nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. The entire change is NFC cleanup, it makes no sense to separate it. Please revert to previous patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-01 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 536555. sstwcw added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-01 Thread sstwcw via Phabricator via cfe-commits
sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 ///const char* x = - /// "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; + ///"veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; /// \endcode

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D154176#4466230 , @HaohaiWen wrote: > In D154176#4466190 , @mstorsjo > wrote: > >> In

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3896 llvm::Type *OrigBaseElemTy = Addr.getElementType(); -Addr = Builder.CreateElementBitCast(Addr, Int8Ty); JOE1994 wrote: > barannikov88 wrote: > > jrtc27 wrote: > > > This one

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] jrtc27 wrote: > JOE1994 wrote: > > nikic

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] JOE1994 wrote: > nikic wrote: > > JOE1994

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages Note that a few test fails because this patch depends on https://reviews.llvm.org/D105759 There are some issue

2023-07-01 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a subscriber: arphaman. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...data are evaluated in the same evaluation context and that cleanup occurs once

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 created this revision. JOE1994 added reviewers: barannikov88, nikic. Herald added subscribers: luke, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal,

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] Repository: rG LLVM Github Monorepo

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCall(F, Buf.getPointer()));

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

2023-07-01 Thread Mike Crowe via Phabricator via cfe-commits
mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCall(F, Buf.getPointer()));

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:158 /// This method is to be deprecated. Use `Address::withElementType` instead. + [[deprecated("Use `Address::withElementType` instead.")]] nikic wrote: > JOE1994 wrote: > > > This

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 updated this revision to Diff 536552. JOE1994 added a comment. - Undo some refactorings to make the diff more consistent with commit message (following feedback from @jrtc27) - Remove method CreateElementBitCast (following feedback from @nikic) Repository: rG LLVM Github Monorepo

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 accepted this revision. jrtc27 added a comment. Thanks for the updated diff (would have also been happy with having a new commit *before* this one that does the non-trivial changes, but this works too and can be followed up with the cleanups you were making if you want to) Repository:

[PATCH] D154285: [clang] Remove CGBuilderTy::CreateElementBitCast

2023-07-01 Thread Youngsuk Kim via Phabricator via cfe-commits
JOE1994 updated this revision to Diff 536554. JOE1994 added a comment. - Add back in refactorings that either drop existing calls to CreateElementBitCast, or merge to Address creation. - Update commit message to clarify that we're employing 3 different methods to remove existing calls to

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-01 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 2 inline comments as done. sstwcw added a comment. In D154093#4466246 , @HazardyKnusperkeks wrote: > I'd really prefer you put what you need to modify `mutable` instead of > removing the `const` from everything else. But that's just my

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG289828b1c0a6: [Driver][MSVC] Move lld specific flags before inputs (authored by HaohaiWen, committed by hh whh...@live.com). Repository: rG LLVM

[clang] 289828b - [Driver][MSVC] Move lld specific flags before inputs

2023-07-01 Thread via cfe-commits
Author: Haohai Wen Date: 2023-07-02T09:29:09+08:00 New Revision: 289828b1c0a6bc6eed8a634376a5152adae2283b URL: https://github.com/llvm/llvm-project/commit/289828b1c0a6bc6eed8a634376a5152adae2283b DIFF: https://github.com/llvm/llvm-project/commit/289828b1c0a6bc6eed8a634376a5152adae2283b.diff

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

2023-07-01 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 536566. owenpan added a comment. Re-annotate */&/&& only if `isCpp()` is true. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

2023-07-01 Thread Haohai, Wen via Phabricator via cfe-commits
HaohaiWen created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D154070

[PATCH] D153017: [analyzer] Fix false negative when using a nullable parameter directly without binding to a variable

2023-07-01 Thread tripleCC via Phabricator via cfe-commits
tripleCC marked an inline comment as done. tripleCC added a comment. In D153017#4428432 , @steakhal wrote: > LGTM; I'll commit this on Monday. Hi steakhal again, sorry to bother you. Do you mind committing the revision for me ? Repository: rG LLVM

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

2023-07-01 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:16384 + Expr *SizeExpression, + Expr *PtrExpression, ASTContext , + EvalResult ) const {

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

2023-07-01 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. In D154209#4466304 , @RKSimon wrote: > LGTM - but it would be good to fix silvermont / westmere cases as well with > suitable test coverage Thanks review! After D151696 landed, they can be

[clang] c0e23bc - [clang] P1816R0 and P2082R1 should work for cxx20 and after only

2023-07-01 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2023-07-01T17:23:41-07:00 New Revision: c0e23bcdfb743f4d7d05e215fb60c987f629498d URL: https://github.com/llvm/llvm-project/commit/c0e23bcdfb743f4d7d05e215fb60c987f629498d DIFF: https://github.com/llvm/llvm-project/commit/c0e23bcdfb743f4d7d05e215fb60c987f629498d.diff

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

2023-07-01 Thread tripleCC via Phabricator via cfe-commits
tripleCC added a comment. I don't have commit access, would you mind committing the revision for me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/ https://reviews.llvm.org/D154221 ___

[clang] 0a9d2fa - [clang][Interp][NFC] Fix a test to actually test something

2023-07-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-02T06:49:55+02:00 New Revision: 0a9d2fa9ac9ec12eb4d50674d40fc73510fef405 URL: https://github.com/llvm/llvm-project/commit/0a9d2fa9ac9ec12eb4d50674d40fc73510fef405 DIFF: https://github.com/llvm/llvm-project/commit/0a9d2fa9ac9ec12eb4d50674d40fc73510fef405.diff

[clang] 381e805 - [clang][Sema][NFC] Make worklist in CheckForIntOverflow const

2023-07-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-07-02T06:49:55+02:00 New Revision: 381e8052d0966a247f811cfc301059393d3c650a URL: https://github.com/llvm/llvm-project/commit/381e8052d0966a247f811cfc301059393d3c650a DIFF: https://github.com/llvm/llvm-project/commit/381e8052d0966a247f811cfc301059393d3c650a.diff