[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin added a comment. @tahonermann I'll probably merge that EoW unless you scream! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153621/new/ https://reviews.llvm.org/D153621 ___ cfe-commits mailing

[PATCH] D154884: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154884/new/ https://reviews.llvm.org/D154884

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

rjmccall added inline comments. Comment at: clang/include/clang/AST/Stmt.h:603 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 32 - 8 -

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer I think there is a minor "The test checks too little" issue as we can utilize the test to check a few

[PATCH] D150803: [WebAssembly] Support `annotate` clang attributes for marking functions.

brendandahl updated this revision to Diff 539191. brendandahl added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: lld/test/wasm/func-attr-tombstone.s

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/Intrinsics.td:1102 -let IntrProperties = [IntrInaccessibleMemOnly, IntrWillReturn] in { +/// IntrStrictFP - The intrinsic is allowed

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

This revision was automatically updated to reflect the committed changes. Closed by commit rG30962268e7a5: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3096226 - [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

Author: Craig Topper Date: 2023-07-11T12:01:35-07:00 New Revision: 30962268e7a559d8714cca4d1af742915c9d29b1 URL: https://github.com/llvm/llvm-project/commit/30962268e7a559d8714cca4d1af742915c9d29b1 DIFF: https://github.com/llvm/llvm-project/commit/30962268e7a559d8714cca4d1af742915c9d29b1.diff

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

scchan updated this revision to Diff 539173. scchan added a comment. addressed comments from yaxunl, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/ https://reviews.llvm.org/D154881 Files: clang/lib/Driver/Driver.cpp

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

philnik updated this revision to Diff 539183. philnik added a comment. Herald added a reviewer: NoQ. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153920/new/ https://reviews.llvm.org/D153920 Files:

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

MaskRay added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

kpn updated this revision to Diff 539204. kpn added a comment. Move test and change to round-tripping as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154991/new/ https://reviews.llvm.org/D154991 Files: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added a comment. @dblaikie Would you be willing to look at the debugger side of things in a subsequent patch? I'm not familiar with debug symbol code gen so I'm not sure I'd be able to improve thing the right way. Comment at:

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:338 int Priority = Categories.getIncludePriority( -CurInclude.Name, /*CheckMainHeader=*/FirstIncludeOffset < 0); +CurInclude.Name, /*CheckMainHeader=*/true);

[clang] f5326fb - clang: add a missing dependency on ClangDriverOptions

Author: Jon Roelofs Date: 2023-07-11T10:07:09-07:00 New Revision: f5326fbe12d7ed006262d35c90803d3dd3907f82 URL: https://github.com/llvm/llvm-project/commit/f5326fbe12d7ed006262d35c90803d3dd3907f82 DIFF: https://github.com/llvm/llvm-project/commit/f5326fbe12d7ed006262d35c90803d3dd3907f82.diff

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + dexonsmith wrote: > john.brawn wrote: > > rjmccall wrote: > > > john.brawn wrote: > > > > rjmccall wrote: > > > > > This is going to fire on every single

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

MaskRay added a comment. The code change looks good but the driver test will cause an issue. I think we need a fake sysroot tree under `Inputs/`. Otherwise if we have a system cross gcc at `/usr/lib/gcc{,-cross}/powerpc64le-unknown-eabi/12`, Clang Driver will pick up these files. This is really

[PATCH] D154910: [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned long/uint64_t.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df12f30551e: [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned… (authored by craig.topper). Repository: rG LLVM

[clang] 2df12f3 - [ARM][AArch64] Make ACLE __clzl/__clzll return unsigned int instead of unsigned long/uint64_t.

Author: Craig Topper Date: 2023-07-11T10:42:25-07:00 New Revision: 2df12f30551e0cb9ecfd49a0cacf929e785c15da URL: https://github.com/llvm/llvm-project/commit/2df12f30551e0cb9ecfd49a0cacf929e785c15da DIFF: https://github.com/llvm/llvm-project/commit/2df12f30551e0cb9ecfd49a0cacf929e785c15da.diff

[PATCH] D154658: Optimize emission of `dynamic_cast` to final classes.

rjmccall added a comment. In D154658#4482202 , @rsmith wrote: > In D154658#4481225 , @rjmccall > wrote: > >> In D154658#4479213 , @rsmith wrote: >> >>> I think (hope?)

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

arsenm added inline comments. Comment at: llvm/test/Feature/fp-intrinsics-attr.ll:1 +; RUN: opt -passes=verify -S < %s | FileCheck %s + Should move to test/Assembler and round trip through llvm-as and llvm-dis like other similar tests Repository: rG LLVM

[clang] 06611e3 - [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

Author: Jan Svoboda Date: 2023-07-11T11:17:24-07:00 New Revision: 06611e361363a4c209aaccd0ee24652d2c56cafb URL: https://github.com/llvm/llvm-project/commit/06611e361363a4c209aaccd0ee24652d2c56cafb DIFF: https://github.com/llvm/llvm-project/commit/06611e361363a4c209aaccd0ee24652d2c56cafb.diff

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

MaskRay added inline comments. Comment at: clang/test/Driver/lto-aix.c:76 // CSPGO: "-bplugin_opt:-cs-profile-generate" "-bplugin_opt:-cs-profile-path=default_%m.profraw" +// +// Test integrated assembler options This `^//$` line is not useful. Some tests use

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 539219. void added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D154999: [clang-tidy] Add bugprone-std-forward-type-mismatch check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects instances

[PATCH] D140727: [XRay] Add initial support for loongarch64

MaskRay added inline comments. Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:30 +// are 2RI12-type and 2RI16-type. +inline static uint32_t +encodeInstruction2RIx(uint32_t Opcode, uint32_t Rd, uint32_t Rj, Early xray code unfortunately does not respect

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b66b3417c02: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when… (authored by qiongsiwu1). Repository: rG LLVM

[clang] 0b66b34 - [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

Author: Qiongsi Wu Date: 2023-07-11T13:24:09-04:00 New Revision: 0b66b3417c026e145708d0e20bfd05a72e79f12a URL: https://github.com/llvm/llvm-project/commit/0b66b3417c026e145708d0e20bfd05a72e79f12a DIFF: https://github.com/llvm/llvm-project/commit/0b66b3417c026e145708d0e20bfd05a72e79f12a.diff

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

kpn created this revision. kpn added reviewers: pengfei, chapuni, akshaykhadse, craig.topper, arsenm. Herald added a subscriber: jdoerfert. Herald added a project: All. kpn requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang,

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rG06611e361363: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef` (authored by

[PATCH] D154359: [clang] Reset FP options before template instantiation

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5093 +FpPragmaStack.CurrentValue = FPOptionsOverride(); + if (addInstantiatedParametersToScope(Function, PatternDecl, Scope, This seems to be fixing the crash.

[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

craig.topper updated this revision to Diff 539221. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154915/new/ https://reviews.llvm.org/D154915 Files: clang/include/clang/Basic/BuiltinsAArch64.def

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 539222. eopXD added a comment. Under RISCVInsertReadWriteCSR, add implicit depdendency to MI if rounding mode is FRM_DYN. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though there might be a minor typo with a test comment. Comment at: clang/test/Sema/asm-goto.cpp:56 + // expected-note@+1 {{jump enters a statement

[clang-tools-extra] 2ce765e - [clang-tidy] Don't split \r\n in modernize-use-std-print check

Author: Mike Crowe Date: 2023-07-11T19:22:31Z New Revision: 2ce765eb2f4feb7555d1416842c542743990b004 URL: https://github.com/llvm/llvm-project/commit/2ce765eb2f4feb7555d1416842c542743990b004 DIFF: https://github.com/llvm/llvm-project/commit/2ce765eb2f4feb7555d1416842c542743990b004.diff LOG:

[clang-tools-extra] b389a62 - [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

Author: Mike Crowe Date: 2023-07-11T19:22:32Z New Revision: b389a62518ad54ae5a183efa43f8408571b2b8cb URL: https://github.com/llvm/llvm-project/commit/b389a62518ad54ae5a183efa43f8408571b2b8cb DIFF: https://github.com/llvm/llvm-project/commit/b389a62518ad54ae5a183efa43f8408571b2b8cb.diff LOG:

[PATCH] D154788: [clang-tidy] Don't split \r\n in modernize-use-std-print check

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ce765eb2f4f: [clang-tidy] Dont split \r\n in modernize-use-std-print check (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154884: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGb389a62518ad: [clang-tidy] Make MatchesAnyListedNameMatcher cope with unnamed Decl (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

aaron.ballman added a comment. Thank you for the fix! This generally LGTM, but I did find some extra test cases to add. Comment at: clang/test/AST/ast-print-method-decl.cpp:1 +// RUN: %clang_cc1 -ast-print %s -o - | FileCheck %s + I think the file should be

[PATCH] D154903: clangd: Provide the resource dir via environment variable

madscientist added a comment. Thanks for adding Sam. I tried to do this but failed: his Phabricator handle isn't available in CODE_OWNERS.txt and my attempts to add him via his email address failed. I have no Phabricator fu! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

hans added a comment. In D154295#4482818 , @HaohaiWen wrote: > In D154295#4477203 , @hans wrote: > >> In D154295#4477165 , @HaohaiWen >> wrote: >> It would be nice

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/DirectoryEntry.h:211 + + static constexpr int NumLowBitsAvailable = 3; +}; benlangmuir wrote: > I suggest not hard-coding it if you can get

[clang] 7d6c2e1 - [clang] Use llvm.is_fpclass to implement FP classification functions

Author: Serge Pavlov Date: 2023-07-11T21:34:53+07:00 New Revision: 7d6c2e18114de9900d1b012cf9c219803b183f63 URL: https://github.com/llvm/llvm-project/commit/7d6c2e18114de9900d1b012cf9c219803b183f63 DIFF: https://github.com/llvm/llvm-project/commit/7d6c2e18114de9900d1b012cf9c219803b183f63.diff

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d6c2e18114d: [clang] Use llvm.is_fpclass to implement FP classification functions (authored by sepavloff). Changed prior to commit:

[PATCH] D154701: [clang] Overridden CXXMethodDecl::isVirtual() assertion failed before fully imported.

balazske added a comment. It is possible to reproduce the same problem with this test added to ASTImporterTest.cpp: TEST_P(ASTImporterOptionSpecificTestBase, ImportVirtualOverriddenMethodTest) { const char *Code = R"( void f1(); class A { virtual void

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added a comment. Herald added a subscriber: wangpc. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152658/new/ https://reviews.llvm.org/D152658 ___ cfe-commits mailing list

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 539105. qiongsiwu1 added a comment. Fixing inconsistent braces. Thanks for the feedback @hubert.reinterpretcast ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 539119. ivanmurashko added a comment. rebase before the final push Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files:

[PATCH] D150320: [clang][modules][deps] Avoid checks for relocated modules

jansvoboda11 updated this revision to Diff 539122. jansvoboda11 added a comment. Rename the new preprocessor option, fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150320/new/ https://reviews.llvm.org/D150320 Files:

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154962/new/ https://reviews.llvm.org/D154962 ___ cfe-commits mailing list

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539131. DmitryPolukhin added a comment. Moved test to clang/unittests/Driver/ToolChainTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files:

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added a comment. In D41416#4488517 , @Hahnfeld wrote: > In D41416#4487516 , @ChuanqiXu wrote: > >> But some local in tree tests got failed. I took some time to investigate >> them but I didn't get

[clang] 7ec844c - [Doc][clang] Some PGO documentation improvements.

Author: Wael Yehia Date: 2023-07-11T16:26:48Z New Revision: 7ec844c881a23bf0d2e4450ac9ca97091490084f URL: https://github.com/llvm/llvm-project/commit/7ec844c881a23bf0d2e4450ac9ca97091490084f DIFF: https://github.com/llvm/llvm-project/commit/7ec844c881a23bf0d2e4450ac9ca97091490084f.diff LOG:

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:288 + } + for (auto : LazySpecializations) { +Record.push_back(SpecInfo.DeclID); SAtacker wrote: > ChuanqiXu wrote: > > v.g.vassilev wrote: > > > We

[PATCH] D150479: [clang][modules] Skip submodule & framework re-definitions in module maps

jansvoboda11 updated this revision to Diff 539156. jansvoboda11 added a comment. Skip re-definitions of frameworks too, add new tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150479/new/ https://reviews.llvm.org/D150479 Files:

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

dim requested changes to this revision. dim added a comment. This revision now requires changes to proceed. FWIW, this fix works for the test cases I had via https://bugs.freebsd.org/269067 and https://github.com/llvm/llvm-project/issues/60182, but I got the following failure during check-all:

[PATCH] D154969: [dataflow] document flow condition

sammccall created this revision. sammccall added a reviewer: ymandel. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

tmatheson added a comment. I would prefer the simplicity of adding a check in the intrinsic itself, rather than adding the target-specific builtins. Slightly worse codegen at -O0 doesn't matter imho. However I don't feel very strongly about it, so if others are happy with this then LGTM.

[PATCH] D153892: [NFC] Initialize class member pointers to nullptr.

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Sindhu! This looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153892/new/ https://reviews.llvm.org/D153892

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7322f2d5ed54: [clangd] Use canonical path as resolved path for includes. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added a comment. In D154602#4483600 , @MaskRay wrote: > Thanks for the patch! But I share the concern that the test is added to a > wrong layer > (https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer).

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

Hahnfeld added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:786-788 +uint32_t DeclID = ~0U; +unsigned ODRHash = ~0U; +bool IsPartial = false; ChuanqiXu wrote: > Maybe this can save some space. Can you elaborate why this would

[PATCH] D154893: [Clang] Fix some triviality computations

shafik added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1269 /// Determine whether this class has a non-trivial copy constructor /// (C++ [class.copy]p6, C++11 [class.copy]p12) bool hasNonTrivialCopyConstructor() const { These

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. Thank you for your patience while WG14 finalized the feature and I wrapped my head around the moving parts involved. I think this is shaping up nicely, but there's still some diagnostic issues. The biggest ones are: - We should have an extension warning for array

[PATCH] D145302: [clangd] Add library for clangd main function

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:40 +bool arm::isArmBigEndian(const llvm::Triple , const ArgList ) { + bool IsBigEndian = false; + We do not need this variable. After an early return, we can just `return

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

danix800 created this revision. danix800 added a project: clang-tools-extra. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without targets registered gives: `error: MS-style inline assembly is not

[PATCH] D154935: [clang][dataflow] Introduce `getFieldValue()` test helpers.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:94 Environment Env(DAContext, *Fun); - Value *Val = Env.createValue(Ty); - ASSERT_NE(Val, nullptr); - StructValue *SVal =

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

dexonsmith added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + john.brawn wrote: > rjmccall wrote: > > john.brawn wrote: > > > rjmccall wrote: > > > > This is going to fire on every single ordinary lookup that finds

[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

tmatheson added a comment. Also thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154915/new/ https://reviews.llvm.org/D154915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154969: [dataflow] document flow condition

ymandel added a comment. Nice! Definitely should have been defined earlier... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154969/new/ https://reviews.llvm.org/D154969 ___ cfe-commits mailing list

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

shafik added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:337 +void RedeclarableTemplateDecl::loadLazySpecializationsImpl( + bool OnlyPartial/*=false*/) const { // Grab the most recent declaration to ensure we've

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther updated this revision to Diff 539132. cwalther added a comment. Oops, forgot to run git-clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:786-788 +uint32_t DeclID = ~0U; +unsigned ODRHash = ~0U; +bool IsPartial = false; Hahnfeld wrote: > ChuanqiXu wrote: > > Maybe this can save some space. > Can you

[PATCH] D154961: [clang][dataflow] Include fields initialized in an `InitListExpr` in `getModeledFields()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, we were including these fields only

[PATCH] D154965: [clang][dataflow] Fix initializaing a reference field with an `InitListExpr`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I added a test for this as the ongoing

[clang-tools-extra] 7322f2d - [clangd] Use canonical path as resolved path for includes.

Author: Viktoriia Bakalova Date: 2023-07-11T15:36:20Z New Revision: 7322f2d5ed547f7281af2d79a229f6620b1708ac URL: https://github.com/llvm/llvm-project/commit/7322f2d5ed547f7281af2d79a229f6620b1708ac DIFF: https://github.com/llvm/llvm-project/commit/7322f2d5ed547f7281af2d79a229f6620b1708ac.diff

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

jansvoboda11 updated this revision to Diff 539127. jansvoboda11 added a comment. Expose new preprocessor option as a `-cc1` flag, move test from `ClangScanDeps` to `Modules` directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150478/new/

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

aqjune added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1653 - if (ShMask[I] >= 0) { -assert(ShMask[I] < (int)NumElts && "Not expecting narrowing shuffle"); Constant *NewCElt = NewVecC[ShMask[I]];

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

aqjune added a comment. Hi, thanks for your hard work! Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1653 - if (ShMask[I] >= 0) { -assert(ShMask[I] < (int)NumElts && "Not expecting narrowing shuffle"); Constant *NewCElt =

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154905/new/ https://reviews.llvm.org/D154905

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

hokein created this revision. hokein added reviewers: sammccall, kadircet. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154963 Files:

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + rjmccall wrote: > john.brawn wrote: > > rjmccall wrote: > > > This is going to fire on every single ordinary lookup that finds multiple > > >

[PATCH] D154905: [clang] Implement `PointerLikeTraits` for `{File,Directory}EntryRef`

jansvoboda11 updated this revision to Diff 539089. jansvoboda11 added a comment. Forward `NumLowBitsAvailable` to `PointerLikeTypeTraits` of the underlying pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154905/new/

[PATCH] D154969: [dataflow] document flow condition

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:528 - /// Returns the token that identifies the flow condition of the environment.

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 539113. pscoro added a comment. Some small changes, still non functional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 Files:

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo updated this revision to Diff 539121. VitaNuo added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154962/new/ https://reviews.llvm.org/D154962 Files: clang-tools-extra/clangd/Headers.cpp Index:

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 added inline comments. Comment at: clang/test/AST/ast-print-method-decl.cpp:15 + // CHECK-NEXT: }; +}; aaron.ballman wrote: > I'd also like to see test cases along the lines of: > ``` > struct B { > template > B(Ty); > B(int X) : B((float)X) {}

[clang] 7f0ef7f - Fix profiling of overloaded postincrement / postdecrement.

Author: Richard Smith Date: 2023-07-11T08:41:21-07:00 New Revision: 7f0ef7f304b1b91694f14e5c9c10de2aa6f38c95 URL: https://github.com/llvm/llvm-project/commit/7f0ef7f304b1b91694f14e5c9c10de2aa6f38c95 DIFF: https://github.com/llvm/llvm-project/commit/7f0ef7f304b1b91694f14e5c9c10de2aa6f38c95.diff

[clang] 14742f2 - [PowerPC] Truncate exponent parameter for vec_cts, vec_ctf

Author: Zarko Todorovski Date: 2023-07-11T11:52:07-04:00 New Revision: 14742f2a689c825adebc54cbade9c89fbe426da8 URL: https://github.com/llvm/llvm-project/commit/14742f2a689c825adebc54cbade9c89fbe426da8 DIFF:

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14742f2a689c: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 539142. john.brawn added a comment. Use BitVector, change how Decls are deleted, adjust test to avoid potentially-conflicting using-declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 Files:

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin updated this revision to Diff 539152. yronglin added a comment. Address John's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

dim added a comment. In D148474#4490041 , @dim wrote: > FWIW, this fix works for the test cases I had via > https://bugs.freebsd.org/269067 and > https://github.com/llvm/llvm-project/issues/60182, but I got the following > failure This was with

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.cpp:57-61 + auto CanonicalPath = + File ? getCanonicalPath(File->getFileEntry().getLastRef(), +

<    1   2   3   >