[PATCH] D154915: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85b27ace5256: [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in… (authored by craig.topper). Repository: rG LLVM

[clang] 85b27ac - [ARM][AArch64] Add ARM specific builtin for clz that is not undefined for 0 in ubsan.

Author: Craig Topper Date: 2023-07-12T09:29:18-07:00 New Revision: 85b27ace52560da6f37d58a8460885adcf147c8b URL: https://github.com/llvm/llvm-project/commit/85b27ace52560da6f37d58a8460885adcf147c8b DIFF: https://github.com/llvm/llvm-project/commit/85b27ace52560da6f37d58a8460885adcf147c8b.diff

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539602. xgupta added a comment. Add documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:110-111 + +static_assert(false, Leaks{}); //expected-error {{the message in a static assertion must be produced by a constant expression}} \ + //

[PATCH] D153989: [compiler-rt] Move crt into builtins

nathanchance added a comment. This change appears to break `-DCOMPILER_RT_BUILD_CRT=OFF`: $ cmake -B build -S llvm -DCMAKE_BUILD_TYPE=Release -DCOMPILER_RT_BUILD_CRT=OFF -DLLVM_ENABLE_PROJECTS='clang;compiler-rt;lld' ... CMake Error at cmake/modules/AddLLVM.cmake:1935 (add_dependencies):

[PATCH] D154359: [clang] Reset FP options before template instantiation

sepavloff added inline comments. Comment at: clang/test/CodeGen/fp-template.cpp:28 +// CHECK-LABEL: define {{.*}} float @_ZN7PR6354211stable_sortIiEEffT_( +// CHECK: fadd float + zahiraam wrote: > Shouldn't we be expecting a constraint add here? Yes, you

[PATCH] D154359: [clang] Reset FP options before template instantiation

sepavloff updated this revision to Diff 539597. sepavloff added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154359/new/ https://reviews.llvm.org/D154359 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

aaron.ballman added a comment. In D155078#4493468 , @ldionne wrote: > Ok, this is ready to go. More context around this change: > > I created a clang-specific CI pipeline > (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now >

[PATCH] D155081: Specify the developer policy around links to external resources

smeenai added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin marked 3 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:110-111 + +static_assert(false, Leaks{}); //expected-error {{the message in a static assertion must be produced by a constant expression}} \ +

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539593. xgupta marked 3 inline comments as done. xgupta added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

aaron.ballman added subscribers: erichkeane, tahonermann, ldionne, hubert.reinterpretcast. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1553-1558 +def err_static_assert_invalid_size : Error< + "the message in a static

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4816 + case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tu: + case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_tama: + case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tama: not related to

[clang] 7d54aae - Revert "[Clang] Diagnose jumps into statement expressions"

Author: Corentin Jabot Date: 2023-07-12T17:54:16+02:00 New Revision: 7d54aae2f122cac8989af0b978938152c6b08454 URL: https://github.com/llvm/llvm-project/commit/7d54aae2f122cac8989af0b978938152c6b08454 DIFF:

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin added a comment. Wait for CI green Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539584. paulkirth added a comment. Use `--` for LLD options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 539583. Sedeniono added a comment. @owenpan Oh wow, you are right. Phabricator shows that there are two separate commits, under "Revision Contents" > "Commits", and their commit messages. But apparently there is no way to download some proper *.patch file

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 539578. capfredf edited the summary of this revision. capfredf added a comment. @v.g.vassilev I moved the ReplCodeCompletionConsumer class out of the header file, since it is not needed elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

simpal01 updated this revision to Diff 539582. simpal01 added a comment. Addressing Review comment - Removing the variable IsBigEndian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154786/new/ https://reviews.llvm.org/D154786 Files:

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

Sedeniono created this revision. Sedeniono added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added a reviewer: rymiel. Sedeniono requested review of this revision. - adjustToUnmodifiedLine:

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. This patch breaks building the Linux kernel for PowerPC, which uses `asm goto` with a local label in a statement expression for the WARN macro. It seems like something with the scoping is going wrong.

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 539572. capfredf marked 2 inline comments as done. capfredf edited the summary of this revision. capfredf added a comment. Herald added a subscriber: arphaman. - rename - Do not export ReplCompletionConsumer - remove commented code Repository: rG LLVM

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. See https://github.com/google/llvm-premerge-checks/pull/452 for the other side of this change. https://github.com/google/llvm-premerge-checks/pull/452 must land after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin updated this revision to Diff 539563. yronglin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Stmt.h

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf marked 5 inline comments as done. capfredf added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:117 ASTContext (); + void CodeComplete(llvm::StringRef Input, size_t Col, size_t Line = 1); const CompilerInstance *getCompilerInstance()

[PATCH] D154999: [clang-tidy] Add bugprone-std-forward-type-mismatch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/std-forward-type-mismatch.rst:28 +is a mismatch between the type passed as an argument and the template parameter. + Excessive newline. Repository: rG LLVM

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. I like this a lot! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539558. xgupta edited the summary of this revision. xgupta added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files:

[PATCH] D142569: [OpenMP] Introduce kernel environment

JonChesterfield added a comment. How does a function find the corresponding kernel environment at runtime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 ___

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539553. ldionne added a comment. Poke CI after fixing Clang CI pipeline clone URL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files:

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

steakhal added inline comments. Comment at: clang/test/Analysis/stream-note.c:61-62 FILE *F1 = fopen("foo1.c", "r"); // expected-note {{Stream opened here}} + // stdargs-note@-1 {{'fopen' is successful}} + // stdargs-note@-2 {{'fopen' is successful}} if (!F1)

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

steakhal added inline comments. Comment at: clang/test/Analysis/stream-note.c:61-62 FILE *F1 = fopen("foo1.c", "r"); // expected-note {{Stream opened here}} + // stdargs-note@-1 {{'fopen' is successful}} + // stdargs-note@-2 {{'fopen' is successful}} if (!F1)

[PATCH] D155084: [analyzer] Fix crash in MoveChecker when it tries to report duplicate issue.

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All.

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 539544. qiongsiwu1 added a comment. Address test case review comments. Thanks so much @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 539545. pscoro added a comment. Small changes, flang-rt seems to work with the flang-new driver now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 Files:

[PATCH] D154991: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91f886a40d3f: [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default. (authored by kpn). Repository: rG LLVM Github

[clang] 91f886a - [FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.

Author: Kevin P. Neal Date: 2023-07-12T09:55:53-04:00 New Revision: 91f886a40d3fbabfc539c2bd8977a1ccb45aa450 URL: https://github.com/llvm/llvm-project/commit/91f886a40d3fbabfc539c2bd8977a1ccb45aa450 DIFF: https://github.com/llvm/llvm-project/commit/91f886a40d3fbabfc539c2bd8977a1ccb45aa450.diff

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. Ok, this is ready to go. More context around this change: I created a clang-specific CI pipeline (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now trigger inside that pipeline instead of inside the libc++ pipeline

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345; to automate closing + the issue in GitHub. If the patch has been

[clang] fb9a741 - [CodeGen][NFCI] Avoid calls to setTargetAttributes on definitions

Author: Alex Gatea Date: 2023-07-12T09:29:11-04:00 New Revision: fb9a74122ef7730ae9839c63c4b7e9a78549d8e6 URL: https://github.com/llvm/llvm-project/commit/fb9a74122ef7730ae9839c63c4b7e9a78549d8e6 DIFF: https://github.com/llvm/llvm-project/commit/fb9a74122ef7730ae9839c63c4b7e9a78549d8e6.diff

[PATCH] D155081: Specify the developer policy around links to external resources

arsenm added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539534. ldionne added a comment. Poke CI after fixing pipeline settings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files:

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman created this revision. aaron.ballman added reviewers: rnk, lattner, doug.gregor, probinson, ldionne, arsenm, mehdi_amini. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a subscriber: wdng. Herald added a project: LLVM. This specifies the

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

ldionne abandoned this revision. ldionne added a comment. Superseded by D155078 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141423/new/ https://reviews.llvm.org/D141423

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

ldionne abandoned this revision. ldionne added a comment. This will be superseded by D155078 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138042/new/ https://reviews.llvm.org/D138042

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource updated this revision to Diff 539529. tomasz-kaminski-sonarsource marked 5 inline comments as done. tomasz-kaminski-sonarsource added a comment. Switched to ranges when applicable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539526. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Touch a file inside Clang to test the triggering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a3322bab069: [clang] Create a buildkite-pipeline.yml file for clang (authored by philnik, committed by ldionne). Changed prior to commit:

[clang] 2a3322b - [clang] Create a buildkite-pipeline.yml file for clang

Author: Nikolas Klauser Date: 2023-07-12T08:33:22-04:00 New Revision: 2a3322bab069166dd0da8474534d0b8dad25b949 URL: https://github.com/llvm/llvm-project/commit/2a3322bab069166dd0da8474534d0b8dad25b949 DIFF:

[PATCH] D155075: [clang][dataflow] Add `DataflowEnvironment::createObject()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. This consolidates the code used in

[PATCH] D155074: [clang][dataflow] Add a test for not explicitly initialized fields in aggregate initialization.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155074

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cor3ntin added a comment. Thanks for working on this! I left some comments, i hope it helps! Comment at: clang/include/clang/Sema/Sema.h:1277 +/// as PotentiallyEvaluated. +RuntimeEvaluated }; I think I'd prefer a boolean for that,

[PATCH] D153589: [NFC] Initialize pointer fields and remove a needless null check.

HazardyKnusperkeks added a comment. Can you mark this change as closed? If you'd put "Differential Revision: https://reviews.llvm.org/D153589; in your commit message this would have happened automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153589/new/

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/paren-list-agg-init.cpp:276-285 +namespace gh62863 { +int (&)[] = static_cast(42); +// beforecxx20-warning@-1 {{aggregate initialization of type 'int[1]'

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:369-370 + QuotedName, /*CheckMainHeader=*/!MainIncludeFound); + if (Priority == 0) +MainIncludeFound = true; auto CatOffset =

[PATCH] D154761: [clang][Interp] Diagnose callsite for implicit functions

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154761/new/ https://reviews.llvm.org/D154761

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

hokein updated this revision to Diff 539506. hokein added a comment. Make the MainFileFound stateless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154963/new/ https://reviews.llvm.org/D154963 Files:

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

cor3ntin requested changes to this revision. cor3ntin added a comment. This revision now requires changes to proceed. Marking that as needing revision while the author explores the direction outlined by Richard :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

cor3ntin added a comment. This looks reasonable to me. But can you add an entry into clang/docs/ReleaseNotes.rst? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154716/new/ https://reviews.llvm.org/D154716

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 539502. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1936-1938 +for (LocalScope::const_iterator I = DstPos; I != BasePos; ++I) + if (I.pointsToFirstDeclaredVar()) +appendScopeBegin(Block, *I, S); steakhal

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin marked an inline comment as done. yronglin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin updated this revision to Diff 539501. cor3ntin added a comment. Add tests for deleted methods and methods whose constraints are not satisfied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154290/new/ https://reviews.llvm.org/D154290

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin marked 2 inline comments as done. yronglin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked an inline comment as done. yronglin added a comment. Thanks for your review! @aaron.ballman @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin marked an inline comment as done. yronglin added inline comments. Comment at: clang/include/clang/AST/Stmt.h:603 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

steakhal added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1819-1826 + for (std::size_t idx = 1, count = LocalScopeEndMarkers.size(); idx < count; + ++idx) { +LocalScope::const_iterator B = LocalScopeEndMarkers[idx]; +LocalScope::const_iterator E =

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin updated this revision to Diff 539493. yronglin added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:369-370 + QuotedName, /*CheckMainHeader=*/!MainIncludeFound); + if (Priority == 0) +MainIncludeFound = true; auto CatOffset = CategoryEndOffsets.find(Priority);

[PATCH] D155067: [clang][dataflow] Strengthen flow condition assertions.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of asserting merely that the flow condition doesn't imply that a

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227012cbd71f: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github

[clang] 227012c - [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

Author: Akash Banerjee Date: 2023-07-12T12:03:28+01:00 New Revision: 227012cbd71f7f55c9f28f561a069628a964a97a URL: https://github.com/llvm/llvm-project/commit/227012cbd71f7f55c9f28f561a069628a964a97a DIFF:

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

hokein updated this revision to Diff 539481. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: arphaman. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154963/new/

[PATCH] D154636: [8/8][RISCV] Add rounding mode control variant for vfredosum, vfredusum, vfwredosum, vfwredusum

eopXD updated this revision to Diff 539478. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154636/new/ https://reviews.llvm.org/D154636 Files:

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

eopXD updated this revision to Diff 539473. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154635/new/ https://reviews.llvm.org/D154635 Files:

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:16417-16418 + } + if (!Scope.destroy()) +return false; + aaron.ballman wrote: > Rather than use an RAII object and destroy it manually, let's use `{}` to > scope the RAII object

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rGce7356f08194: [clang-format] Dont eat two semicolons after namespace (authored by

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1116ed2beb1c: [clang-format] Correctly count a tabs width in a comment (authored by HazardyKnusperkeks). Changed prior to commit:

[clang] ce7356f - [clang-format] Don't eat two semicolons after namespace

Author: Björn Schäpers Date: 2023-07-12T12:23:20+02:00 New Revision: ce7356f08194083c205b92e77d1a4cd515a2a5b8 URL: https://github.com/llvm/llvm-project/commit/ce7356f08194083c205b92e77d1a4cd515a2a5b8 DIFF:

[clang] 1116ed2 - [clang-format] Correctly count a tab's width in a comment

Author: Björn Schäpers Date: 2023-07-12T12:23:19+02:00 New Revision: 1116ed2beb1cd62a4b450efead481009af19df62 URL: https://github.com/llvm/llvm-project/commit/1116ed2beb1cd62a4b450efead481009af19df62 DIFF:

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource updated this revision to Diff 539470. tomasz-kaminski-sonarsource marked 3 inline comments as done. tomasz-kaminski-sonarsource added a comment. Apply review suggestion and replaced make_scope_exit with SaveAndRestore that was already used in file. Repository: rG

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, rsmith, cor3ntin, erichkeane, tbaeder. Herald added a project: All. hazohelet requested review of this revision. Herald added projects: clang, libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer:

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin updated this revision to Diff 539467. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Rename EvaluateCharPointerAsString => EvaluateCharRangeAsString - Improve diag messages - Form an overload set to diagnose invalid overloads - Add more tests Repository: rG

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko abandoned this revision. ivanmurashko added a comment. The diff is not required after https://reviews.llvm.org/D145302 deployed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145228/new/ https://reviews.llvm.org/D145228

[PATCH] D140727: [XRay] Add initial support for loongarch64

Ami-zhang updated this revision to Diff 539465. Ami-zhang added a comment. Hide some symbols and using some macros in asm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140727/new/ https://reviews.llvm.org/D140727 Files:

[PATCH] D140727: [XRay] Add initial support for loongarch64

Ami-zhang added inline comments. Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:30 +// are 2RI12-type and 2RI16-type. +inline static uint32_t +encodeInstruction2RIx(uint32_t Opcode, uint32_t Rd, uint32_t Rj, MaskRay wrote: > Early xray code unfortunately

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or refactoring, adding documentation etc..) Add your unit tests in

[PATCH] D146809: [clang-repl] Implement Value pretty printing

v.g.vassilev commandeered this revision. v.g.vassilev edited reviewers, added: junaire; removed: v.g.vassilev. v.g.vassilev added a comment. Jun has moved on in his career and I'd like to take responsibility for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

balazske added a comment. I do not have the knowledge to approve this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983 ___ cfe-commits mailing list

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a subscriber: aaron.ballman. v.g.vassilev added a comment. @capfredf this seems to be heading in a good direction. Please find another round of comments. @aaron.ballman, I could not find a person that's active in that area. Could

[PATCH] D154634: [6/8][RISCV] Add rounding mode control variant for vfsqrt, vfrec7

eopXD updated this revision to Diff 539447. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154634/new/ https://reviews.llvm.org/D154634 Files:

[PATCH] D154633: [5/8][RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac

eopXD updated this revision to Diff 539443. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154633/new/ https://reviews.llvm.org/D154633 Files:

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. In D145302#4492595 , @mstorsjo wrote: > In D145302#4491973 , @glandium > wrote: > >> This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > I also ran into this; I pushed a fix

[PATCH] D154632: [4/8][RISCV] Add rounding mode control variant for vfmacc, vfnmacc, vfmsac, vfnmsac, vfmadd, vfnmadd, vfmsub, vfnmsub

eopXD updated this revision to Diff 539439. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154632/new/ https://reviews.llvm.org/D154632 Files:

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. I am unable to provoke any problem with my tests by putting various things in `/usr/lib/gcc/`, and I also can’t find any code that would go looking there on the code path that is exercised by these tests. Can you give me a hint where that code is, so I can try harder

[PATCH] D154631: [3/8][RISCV] Add rounding mode control variant for vfmul, vfdiv, vfrdiv, vfwmul

eopXD updated this revision to Diff 539434. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154631/new/ https://reviews.llvm.org/D154631 Files:

[PATCH] D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block

danix800 added a comment. Thanks! @thieta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154983/new/ https://reviews.llvm.org/D154983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

eopXD updated this revision to Diff 539430. eopXD added a comment. Change: - Rebase upon latest main and updated parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154629/new/ https://reviews.llvm.org/D154629 Files:

[PATCH] D145302: [clangd] Add library for clangd main function

mstorsjo added a comment. In D145302#4491973 , @glandium wrote: > This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: I also ran into this; I pushed a fix in a20d57e83441a69fa2bab86593b18cc0402095d2

<    1   2   3   >