[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D156224#4531659 , @cor3ntin wrote: > Thanks for the quick fix. Any idea why it would only show up on ppc64 > @aaron.ballman ? Not certain, to be honest. The diagnostic is enabled by `-Wextra` so I would have imagined

[clang] d031ff3 - [Sema] Fix handling of functions that hide classes

2023-07-25 Thread John Brawn via cfe-commits
Author: John Brawn Date: 2023-07-25T12:30:41+01:00 New Revision: d031ff38779bd688c514136dbdcce3169ee82b6e URL: https://github.com/llvm/llvm-project/commit/d031ff38779bd688c514136dbdcce3169ee82b6e DIFF: https://github.com/llvm/llvm-project/commit/d031ff38779bd688c514136dbdcce3169ee82b6e.diff

[clang] 71be91e - HIP: Directly call rint builtins

2023-07-25 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-07-25T07:54:11-04:00 New Revision: 71be91eba96d80d15689e4f516141c533c3c086d URL: https://github.com/llvm/llvm-project/commit/71be91eba96d80d15689e4f516141c533c3c086d DIFF:

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

2023-07-25 Thread John Brawn via Phabricator via cfe-commits
john.brawn added a comment. The first version of this that I committed caused a failure in clang/test/Modules/stress1.cpp so I reverted it. I've now committed a new version that handles the removal of existing decl when isPreferredLookupResult is true in a slightly different way, which should

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

2023-07-25 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can break release builds that set

[clang] 0d12683 - Revert "[OpenMP] Add the `ompx_attribute` clause for target directives"

2023-07-25 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-07-25T07:57:36-04:00 New Revision: 0d12683046ca75fb08e285f4622f2af5c82609dc URL: https://github.com/llvm/llvm-project/commit/0d12683046ca75fb08e285f4622f2af5c82609dc DIFF: https://github.com/llvm/llvm-project/commit/0d12683046ca75fb08e285f4622f2af5c82609dc.diff

[clang] e7ab698 - HIP: Directly call nearbyint builtins

2023-07-25 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-07-25T07:56:31-04:00 New Revision: e7ab6982de87b14c9584e1267cd755561b4c063c URL: https://github.com/llvm/llvm-project/commit/e7ab6982de87b14c9584e1267cd755561b4c063c DIFF:

[PATCH] D156229: [clang][dataflow] Remove checks that test for consistency between `StructValue` and `AggregateStorageLocation`.

2023-07-25 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that the redundancy between these two classes has been eliminated, these

[clang-tools-extra] 4706251 - Clear release notes for 18.x

2023-07-25 Thread Tobias Hieta via cfe-commits
Author: Tobias Hieta Date: 2023-07-25T13:58:49+02:00 New Revision: 4706251a3186c34da0ee8fd894f7e6b095da8fdc URL: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc DIFF: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc.diff

[clang] 4706251 - Clear release notes for 18.x

2023-07-25 Thread Tobias Hieta via cfe-commits
Author: Tobias Hieta Date: 2023-07-25T13:58:49+02:00 New Revision: 4706251a3186c34da0ee8fd894f7e6b095da8fdc URL: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc DIFF: https://github.com/llvm/llvm-project/commit/4706251a3186c34da0ee8fd894f7e6b095da8fdc.diff

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

2023-07-25 Thread Alex Bradbury via Phabricator via cfe-commits
asb added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. imkiva wrote: > wangpc wrote: > > I think the comment is outdated

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. I had copied the warning-flags from the build-bot command line and ended up as follows: -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-07-25 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. This seems functionally correct to me, but I'd welcome opinions from others who work more with the C intrinsics on if this is the best way to implement the overloading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

2023-07-25 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2469-2472 + // User csa_mark_sanitize function is for the analyzer only + #ifdef __clang_analyzer__ +void csa_mark_sanitized(const void *); + #endif I was thinking of this when I

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

2023-07-25 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Feel free to add the comment about the implications of using the flag in the docs. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:270

[clang] 18914f7 - OpenMP: Fix broken c++ mode comment

2023-07-25 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-07-25T08:36:19-04:00 New Revision: 18914f795523b7099cad0cf16ac4cd062ac998d4 URL: https://github.com/llvm/llvm-project/commit/18914f795523b7099cad0cf16ac4cd062ac998d4 DIFF:

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

2023-07-25 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks updated this revision to Diff 543918. HazardyKnusperkeks marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D156228: [clang-format][NFCish] Obey debug settings

2023-07-25 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added a reviewer: klimek. HazardyKnusperkeks added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. Also affects: clang-ppc64-aix https://lab.llvm.org/buildbot/#/builders/214/builds/8649 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a subscriber: aaron.ballman. cor3ntin added a comment. Thanks for the quick fix. Any idea why it would only show up on ppc64 @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. It could also be a different version of gtest or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224 ___ cfe-commits mailing

[clang] d0b54bb - [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Corentin Jabot via cfe-commits
Author: Kai Stierand Date: 2023-07-25T13:58:30+02:00 New Revision: d0b54bb50e5110a004b41fc06dadf3fee70834b7 URL: https://github.com/llvm/llvm-project/commit/d0b54bb50e5110a004b41fc06dadf3fee70834b7 DIFF: https://github.com/llvm/llvm-project/commit/d0b54bb50e5110a004b41fc06dadf3fee70834b7.diff

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0b54bb50e51: [Clang] use unsigned integer constants in unit-test | fixes build error on… (authored by kiloalphaindia, committed by cor3ntin).

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I was able to confirm on my machine that the warnings are no longer emitted. They were there when i committed the initial patch, i just missed them. Sorry about that Repository: rG

[PATCH] D156184: [OpenMP] Add the `ompx_attribute` clause for target directives

2023-07-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D156184#4531193 , @antmo wrote: > Hi, it looks like this patch broke some flang bots: > > - https://lab.llvm.org/buildbot/#/builders/176/builds/3408 > - https://lab.llvm.org/buildbot/#/builders/198/builds/4028 > -

[PATCH] D156230: [clang][dataflow][NFC] Eliminate variable only used in assertion.

2023-07-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (if you prefer to keep the named variable, `(void)StructVal2` is also fine) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156230/new/

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

2023-07-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added subscribers: philnik, Mordante, ldionne. aaron.ballman added a comment. In D152003#4531404 , @Fznamznon wrote: >> should we try to land that today? > > I'm not sure. It causes failures in libc++ testing: > > Failed Tests (3): >

[clang] 73105a5 - HIP: Fix broken version check for deprecated macro

2023-07-25 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-07-25T08:36:19-04:00 New Revision: 73105a54725ec11165dd8c90ca3b7a0b1b9cd6e3 URL: https://github.com/llvm/llvm-project/commit/73105a54725ec11165dd8c90ca3b7a0b1b9cd6e3 DIFF:

[PATCH] D154123: [HIP] Start document HIP support by clang

2023-07-25 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/docs/HIPSupport.rst:30 + +Clang provides partial HIP support on Intel GPUs using the CHIP-Star project ``_. CHIP-Star implements the HIP runtime over

<    1   2   3   4