[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1494-1505 +Decl *Sema::getCurLocalScopeDecl() { + if (const BlockScopeInfo *BSI = getCurBlock()) +return BSI->TheDecl; + else if (const LambdaScopeInfo *LSI = getCurLambda()) +return LSI->CallOpera

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

srividya-sundaram added a comment. In D157129#4564766 , @steakhal wrote: > I went over the patch and I found only a single debatable case for taking by > reference. > To clarify why I would prefer taking by value: value semantics is good for > local rea

[PATCH] D157331: [clang] Implement C23

enh added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + ZijunZhao wrote: > enh wrote: > > ZijunZhao wrote: > > > enh wrote: > > > > hiraditya wrote: > > >

[clang-tools-extra] 5b95d17 - [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

Author: Fabian Wolff Date: 2023-08-09T00:55:45+02:00 New Revision: 5b95d17da1f0719f0af711e032d36b18fcb92070 URL: https://github.com/llvm/llvm-project/commit/5b95d17da1f0719f0af711e032d36b18fcb92070 DIFF: https://github.com/llvm/llvm-project/commit/5b95d17da1f0719f0af711e032d36b18fcb92070.diff

[PATCH] D157436: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for single quote character literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b95d17da1f0: [clang-tidy] `performance-faster-string-find` generates incorrect fixes for… (authored by fwolff). Repository: rG LLVM Github Monore

[PATCH] D157331: [clang] Implement C23

hiraditya added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) enh wrote: > hiraditya wrote: > > xbolva00 wrote: > > > yabinc wrote: > > > > enh wrote: > > > >

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx created this revision. AlexVlx added reviewers: rjmccall, efriedma, yaxunl, arsenm. AlexVlx added a project: clang. Herald added a project: All. AlexVlx requested review of this revision. Herald added subscribers: cfe-commits, wdng. After https://reviews.llvm.org/D153092, for targets that

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 ___

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. eandrews requested review of this revision. InterfacePointerType is dere

[PATCH] D155850: [Clang][CodeGen][RFC] Add codegen support for C++ Parallel Algorithm Offload

keryell added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5542 + if (!getLangOpts().HIPStdPar) +ErrorUnsupported(E, "builtin function"); AlexVlx wrote: > efriedma wrote: > > AlexVlx wrote: > > > efriedma wrote: > > > > This doesn't make se

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

NoQ added a comment. Ok I think this looks great and almost good to go. I love how the core change in the grouping algorithm is actually tiny and simple! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1891-1892 + for (unsigned i = 0; i < NumParms; i++) { +if (!Parms

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

NoQ added a comment. Ooo nice!! > Extend PointerAssignmentGadget and PointerInitGadget to generate fix-its for > cases where the left-hand side has won't fix strategy and the right-hand side > has std::span strategy. Hmm, is this intertwined with other changes, or is this completely separate?

[clang] 61709bb - [OpenMP] Ensure wrapper headers are included on both host and device

Author: Joseph Huber Date: 2023-08-08T19:07:47-05:00 New Revision: 61709bbae37af4e01cf93c6d112ba984bbd9a7ea URL: https://github.com/llvm/llvm-project/commit/61709bbae37af4e01cf93c6d112ba984bbd9a7ea DIFF: https://github.com/llvm/llvm-project/commit/61709bbae37af4e01cf93c6d112ba984bbd9a7ea.diff

[PATCH] D157438: [OpenMP] Ensure wrapper headers are included on both host and device

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61709bbae37a: [OpenMP] Ensure wrapper headers are included on both host and device (authored by jhuber6). Repository: rG LLVM Github Monorepo CHA

[PATCH] D157410: [Flang] Enable Rpass flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:521 + // -R[no-]group[=regexp] and -R[no-]everything flags + Args.AddAllArgs(CmdArgs, options::OPT_R_Group); These are options, not flags (boolean). Repository: rG LLVM Githu

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I see you've started to address the big comment in D157441 , so, LGTM, thanks a lot for splitting stuff up! I have one tiny stylistic nitpick.

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a05a5215f69: [RISCV] Support vector crypto extension C intrinsics (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. > Thanks! We might need someone from clangd to help here. The logs do not have > any information explaining what's failing with the test, and looking at the > test code, I struggle to see how these changes would impact that test. We've > had some significant issues w

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

MaskRay accepted this revision. MaskRay added a comment. Some test suggestions Comment at: clang/lib/Basic/Targets/LoongArch.cpp:203 + StringRef ArchName = getCPU(); + Builder.defineMacro("__loongarch_arch", Twine("\"") + ArchName + Twine("\"")); + Use the `

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 updated this revision to Diff 548423. jansvoboda11 added a comment. Rebase, remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files: clang-tools-extra/clangd/Compil

[PATCH] D157054: [clang] NFC: Use compile-time option spelling when generating command line

jansvoboda11 updated this revision to Diff 548425. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157054/new/ https://reviews.llvm.org/D157054 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/li

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

pengfei added a comment. The description is not clear to me. You should describe the reason rather than phenomenon. My understanding is double colon cannot operator cannot resolve functions with parentheses. But I didn't find enough proof in Google. It'd be more persuasive if you can find it a

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

dyung added a comment. The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for example https://lab.llvm.org/buildbot/#/builders/139/builds/47055. Is the test missing a `REQUIRES: riscv-registered-target` line by any chance? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added a comment. In D138810#4571579 , @dyung wrote: > The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for > example https://lab.llvm.org/buildbot/#/builders/139/builds/47055. > > Is the test missing a `REQUIRES: riscv-registe

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

4vtomat created this revision. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. 4vtomat requested review of this revision. Herald added subs

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157467/new/ https://reviews.llvm.org/D157467 ___ c

[clang] adb76c3 - [RISCV] Add missing REQUIRES for zvk-invalid.c test

Author: 4vtomat Date: 2023-08-08T18:45:37-07:00 New Revision: adb76c31ec42a12690ae0c86edd368f7f066480d URL: https://github.com/llvm/llvm-project/commit/adb76c31ec42a12690ae0c86edd368f7f066480d DIFF: https://github.com/llvm/llvm-project/commit/adb76c31ec42a12690ae0c86edd368f7f066480d.diff LOG:

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb76c31ec42: [RISCV] Add missing REQUIRES for zvk-invalid.c test (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 updated this revision to Diff 548434. danix800 edited the summary of this revision. danix800 added a comment. Cleanup duplicated boilerplate testcase code. Append a few extra child nodes of `CoyieldExpr` dumped in testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157296/n

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

danix800 added a comment. I'll finish this patch when CI build succeeds. For future improvement I might start with the idea of marking those generated inner exprs as implicit, this seems to be easier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157296/new/ https://reviews.llvm.org/D1

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining updated this revision to Diff 548442. SixWeining marked an inline comment as done. SixWeining added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155824/new/ https://reviews.llvm.org/D155824 Files

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

SixWeining marked an inline comment as done. SixWeining added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:203 + StringRef ArchName = getCPU(); + Builder.defineMacro("__loongarch_arch", Twine("\"") + ArchName + Twine("\"")); + MaskRay wro

[clang] f62c925 - [LoongArch] Support -march=native and -mtune=

Author: Weining Lu Date: 2023-08-09T10:29:50+08:00 New Revision: f62c9252fc0f1fa0a0f02033659db052c2202a4c URL: https://github.com/llvm/llvm-project/commit/f62c9252fc0f1fa0a0f02033659db052c2202a4c DIFF: https://github.com/llvm/llvm-project/commit/f62c9252fc0f1fa0a0f02033659db052c2202a4c.diff LO

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. SixWeining marked an inline comment as done. Closed by commit rGf62c9252fc0f: [LoongArch] Support -march=native and -mtune= (authored by SixWeining). Repository: rG

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. Got it. The explanation makes sense. A well designed and scaling solution is what I (and probably every one) want. Then from the expectation, the difference between supporting header modules and C++20 named modules from the **user** side may be: - For supporting head

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

vsapsai accepted this revision. vsapsai added a comment. The existing `FilenameAsRequested` usage looks good to me. Unfortunately, don't know how to make sure all places where `FilenameAsRequested` is required instead of `Filename` are updated. Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 201c105 - [NFC] [C++20] [Modules] Adopt a test case from MSVC

Author: Chuanqi Xu Date: 2023-08-09T11:14:43+08:00 New Revision: 201c10537a3c1ad4a86b840834c204575d10d589 URL: https://github.com/llvm/llvm-project/commit/201c10537a3c1ad4a86b840834c204575d10d589 DIFF: https://github.com/llvm/llvm-project/commit/201c10537a3c1ad4a86b840834c204575d10d589.diff LO

[clang-tools-extra] ebb0a21 - [GlobPattern] Update invalid glob pattern diagnostic for unmatched '['

Author: Fangrui Song Date: 2023-08-08T20:25:10-07:00 New Revision: ebb0a210995dcf69d9696f8e14629e1378e63a21 URL: https://github.com/llvm/llvm-project/commit/ebb0a210995dcf69d9696f8e14629e1378e63a21 DIFF: https://github.com/llvm/llvm-project/commit/ebb0a210995dcf69d9696f8e14629e1378e63a21.diff

[PATCH] D157471: [OpenMP][OMPD][Doc] Update the implementation details of OMPD

Vigneshbalu created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. Vigneshbalu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. Updating the correc

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D156948: [clang][modules] Add -Wsystem-headers-in-module=

iana accepted this revision. iana added inline comments. Comment at: clang/include/clang/Basic/DiagnosticOptions.h:128 + /// whether -Wsystem-headers is enabled on a per-module basis. + std::vector SystemHeaderWarningsModules; + benlangmuir wrote: > jansvoboda1

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

craig.topper added a comment. Is it possible to test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157474/new/ https://reviews.llvm.org/D157474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

wangpc created this revision. wangpc added reviewers: kito-cheng, eopXD, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jo

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman updated this revision to Diff 548473. aidengrossman added a comment. Reformat using arc as manually uploading patch messes up formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157334/new/ https://reviews.llvm.org/D157334 File

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing updated this revision to Diff 548477. yubing added a comment. Herald added a subscriber: mstorsjo. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp c

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing updated this revision to Diff 548478. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp clang/test/CodeGen/mangle-windows-regcall

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing updated this revision to Diff 548479. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp clang/test/CodeGen/mangle-windows-regcall

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test case was fixed in commit rG2c4620c1

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

hazohelet added a comment. We need some tests for dtors because they are handled differently from other functions. I think the current ExprConstant part would not cover the explicitly-called dtors because the `HandleDestructorImpl` only has access to `CallLoc` and not source range. Also new int

<    1   2   3