[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4330-4331 +ExprResult Res = FixOverloadedFunctionReference(From, Found, Fn); +if (Res.isInvalid()) + return ExprError(); cor3ntin

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 created this revision. danix800 added reviewers: balazske, aaron.ballman. danix800 added a project: clang. Herald added subscribers: pengfei, martong, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549337. XinWang10 added a comment. - mv driver implement to x86 specific code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files:

[PATCH] D157705: [clang][AST] TestNodeDumper learned to output template specialization kind

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157705

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. XinWang10 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc, MaskRay. Herald added projects: clang, LLVM. Gather instructions could lead to

[clang-tools-extra] 30fed17 - [clang-tidy][NFC] Enable exceptions in no-suspend-with-lock.cpp

Author: Piotr Zegar Date: 2023-08-11T07:29:06Z New Revision: 30fed17a08cda324b557498a6db18dd4a0281daa URL: https://github.com/llvm/llvm-project/commit/30fed17a08cda324b557498a6db18dd4a0281daa DIFF: https://github.com/llvm/llvm-project/commit/30fed17a08cda324b557498a6db18dd4a0281daa.diff LOG:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:156-158 +/// Parse a remark command line argument. It may be missing, disabled/enabled by +/// '-R[no-]group' or specified with a regular expression by '-Rgroup=regexp'. +/// On top of that,

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts updated this revision to Diff 549288. Keenuts added a comment. Revert "clang-format" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155978/new/ https://reviews.llvm.org/D155978 Files: clang/lib/Basic/Targets.cpp

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 549314. cor3ntin added a comment. Rebase, add C tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156237/new/ https://reviews.llvm.org/D156237 Files: clang/docs/ReleaseNotes.rst

[clang-tools-extra] 5568f28 - [clang-tidy][NFC] Update gen-static-analyzer-docs.py

Author: Piotr Zegar Date: 2023-08-11T10:36:45Z New Revision: 5568f28c868eb13033d64189560ee0e62d745285 URL: https://github.com/llvm/llvm-project/commit/5568f28c868eb13033d64189560ee0e62d745285 DIFF: https://github.com/llvm/llvm-project/commit/5568f28c868eb13033d64189560ee0e62d745285.diff LOG:

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

pmatos added inline comments. Comment at: llvm/include/llvm/TargetParser/Triple.h:106 +wasm32, // WebAssembly with 32-bit pointers +wasm64, // WebAssembly with 64-bit pointers renderscript32, // 32-bit RenderScript Keenuts wrote: > pmatos

[clang] 6e0fc88 - Fix examples after C2x renaming

Author: Aaron Ballman Date: 2023-08-11T08:01:17-04:00 New Revision: 6e0fc88836a8ecc4520f6be09d392c03e21d8b40 URL: https://github.com/llvm/llvm-project/commit/6e0fc88836a8ecc4520f6be09d392c03e21d8b40 DIFF: https://github.com/llvm/llvm-project/commit/6e0fc88836a8ecc4520f6be09d392c03e21d8b40.diff

[clang-tools-extra] cd9e923 - [clang-tidy][NFC] Update add_new_check.py to handle more proper list.rst

Author: Piotr Zegar Date: 2023-08-11T11:02:28Z New Revision: cd9e92309d1733219f439d663ec9a4c3d59e6650 URL: https://github.com/llvm/llvm-project/commit/cd9e92309d1733219f439d663ec9a4c3d59e6650 DIFF: https://github.com/llvm/llvm-project/commit/cd9e92309d1733219f439d663ec9a4c3d59e6650.diff LOG:

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang.

[PATCH] D157651: [RISCV] Rewrite CheckInvalidVLENandLMUL to avoid floating point.

4vtomat accepted this revision. 4vtomat added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Sema/SemaChecking.cpp:4484 + unsigned EGS = EGW / ElemSize; + // If EGS is more than our minimum number of elements we're done. + if

[PATCH] D157681: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157681 Files:

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

danix800 created this revision. danix800 added reviewers: balazske, aaron.ballman. danix800 added a project: clang. Herald added subscribers: pengfei, martong, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157687

[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

wangpc added a comment. In D149017#4579179 , @zixuan-wu wrote: > Is it going to commit? This patch is stuck since the patch to support function/lambda is WIP (I may not work on it recently). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts marked 4 inline comments as done. Keenuts added a comment. Thanks for the review  Reverted clang-format patch, and answered inline. Comment at: llvm/include/llvm/TargetParser/Triple.h:106 +wasm32, // WebAssembly with 32-bit pointers +wasm64, //

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zfhmin is available

jacquesguan updated this revision to Diff 549311. jacquesguan added a comment. remove zfmin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157693/new/ https://reviews.llvm.org/D157693 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. accepting current revision, one minor change is still required, adding that separately Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549268. XinWang10 added a comment. - restore blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td

[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

zixuan-wu added a comment. Is it going to commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149017/new/ https://reviews.llvm.org/D149017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

tbaeder added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2063-2064 bool isInstance() const { return !isStatic(); } + bool isExplicitObjectMemberFunction() const; + bool isImplicitObjectMemberFunction() const; + const ParmVarDecl

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

wangpc added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7527 + // -mno-gather, -mno-scatter support + if (Args.hasArg(options::OPT_mno_gather)) { +CmdArgs.push_back("-target-feature"); Put these in

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zfhmin is available

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck, luke. Herald added subscribers: s.egerton, simoncook. Herald added a project: All. jacquesguan requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. Added minor changes requested by Vassil Comment at: clang/docs/ClangRepl.rst:296 + +For example, the CPPYY code makes use of this feature to enable

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts marked an inline comment as done. Keenuts added inline comments. Comment at: llvm/include/llvm/TargetParser/Triple.h:106 +wasm32, // WebAssembly with 32-bit pointers +wasm64, // WebAssembly with 64-bit pointers renderscript32, // 32-bit

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

danix800 added a comment. By `FromContext` dump it's easy to observe that there're two different `FunctionTemplateDecl` (`0x5590cff48048` and `0x5590cff481f8`): |-FriendDecl 0x5590cff48048 col:42 | `-FunctionTemplateDecl 0x5590cff47f80 parent 0x5590cfefeda8 col:42 m | |-...

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 549298. RIscRIpt added a comment. Rebase onto main (bump) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475/new/ https://reviews.llvm.org/D134475 Files: clang/docs/ReleaseNotes.rst

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL updated this revision to Diff 549336. PiotrZSL added a comment. Micro fix ("" characters). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157702/new/ https://reviews.llvm.org/D157702 Files: clang/docs/analyzer/checkers.rst Index:

[clang-tools-extra] 0ce056a - [C23] Rename C2x -> C23; NFC

Author: Aaron Ballman Date: 2023-08-11T07:43:43-04:00 New Revision: 0ce056a814f8dbfd8d9b7720ce1df489c6ba5ddb URL: https://github.com/llvm/llvm-project/commit/0ce056a814f8dbfd8d9b7720ce1df489c6ba5ddb DIFF: https://github.com/llvm/llvm-project/commit/0ce056a814f8dbfd8d9b7720ce1df489c6ba5ddb.diff

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

This revision was automatically updated to reflect the committed changes. Closed by commit rGa563ced78bb4: [clang-tidy] Implement cppcoreguidelines CP.52 (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a563ced - [clang-tidy] Implement cppcoreguidelines CP.52

Author: Chris Cotter Date: 2023-08-11T07:13:59Z New Revision: a563ced78bb4bda31babb85e88a89b49ffd61a90 URL: https://github.com/llvm/llvm-project/commit/a563ced78bb4bda31babb85e88a89b49ffd61a90 DIFF: https://github.com/llvm/llvm-project/commit/a563ced78bb4bda31babb85e88a89b49ffd61a90.diff LOG:

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 549251. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 Files:

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping Comment at: clang/test/AST/Interp/literals.cpp:1047 - // expected-warning {{variable length array folded to constant array}} -} Ignore this block, that's just from rebasing. CHANGES SINCE LAST

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

fakepaper56 updated this revision to Diff 549262. fakepaper56 added a comment. Update docs/RISCVUsage.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files:

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added a comment. Please update docs/RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.llvm.org/D152793 ___ cfe-commits mailing list

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return false; cor3ntin wrote: > Shouldn't

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157072/new/ https://reviews.llvm.org/D157072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157663: [Driver] Default riscv*- triples to -fdebug-default-version=4

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, I am OK with that, actually our downstream toolchain has downgrade the dwarf version to 4 too, because binutils/gdb not well support before... Repository: rG LLVM Github

[clang] f6b94e0 - [NFC] Document the solution to pr61006 and a test for it

Author: Chuanqi Xu Date: 2023-08-11T14:57:32+08:00 New Revision: f6b94e0026e27dd0603e5ba39886920c02ad79f0 URL: https://github.com/llvm/llvm-project/commit/f6b94e0026e27dd0603e5ba39886920c02ad79f0 DIFF: https://github.com/llvm/llvm-project/commit/f6b94e0026e27dd0603e5ba39886920c02ad79f0.diff

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

pmatos added subscribers: iliya-diyachkov, zuban32. pmatos added a comment. Thanks for the patch. Left a few comments. Others can take a better look, I am sure. Maybe @iliya-diyachkov or @zuban32 can take a look as well. Comment at: llvm/include/llvm/TargetParser/Triple.h:106

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

PiotrZSL updated this revision to Diff 549263. PiotrZSL added a comment. Add call to DiagnosticEngine::hasSourceManager() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157649/new/ https://reviews.llvm.org/D157649 Files:

[clang] c9335eb - Rename C2x -> C23 in WWW pages

Author: Aaron Ballman Date: 2023-08-11T08:56:01-04:00 New Revision: c9335eb20f45f48b53f1f820334edad71da6f37f URL: https://github.com/llvm/llvm-project/commit/c9335eb20f45f48b53f1f820334edad71da6f37f DIFF: https://github.com/llvm/llvm-project/commit/c9335eb20f45f48b53f1f820334edad71da6f37f.diff

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549370. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files:

[clang] 0f73a24 - [clang][Sema] Skip access check on arrays of zero-length element

Author: dingfei Date: 2023-08-11T22:05:04+08:00 New Revision: 0f73a2406a16f3a69dd6e62f0faa3a4aa05c5d84 URL: https://github.com/llvm/llvm-project/commit/0f73a2406a16f3a69dd6e62f0faa3a4aa05c5d84 DIFF: https://github.com/llvm/llvm-project/commit/0f73a2406a16f3a69dd6e62f0faa3a4aa05c5d84.diff LOG:

[clang] afff91d - [ASTImporter][NFC] Fix typo in testcase

Author: dingfei Date: 2023-08-11T22:06:56+08:00 New Revision: afff91de082d1347d81c413a424f0a1b6fb02774 URL: https://github.com/llvm/llvm-project/commit/afff91de082d1347d81c413a424f0a1b6fb02774 DIFF: https://github.com/llvm/llvm-project/commit/afff91de082d1347d81c413a424f0a1b6fb02774.diff LOG:

[PATCH] D157584: [clang][Sema] Skip access check on arrays of zero-length element

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f73a2406a16: [clang][Sema] Skip access check on arrays of zero-length element (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157637: [ASTImporter][NFC] Fix typo in testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafff91de082d: [ASTImporter][NFC] Fix typo in testcase (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D157517: [AArch64][SVE] Add asm predicate constraint Uph

This revision was automatically updated to reflect the committed changes. Closed by commit rGc52d9509d40d: [AArch64][SVE] Add asm predicate constraint Uph (authored by MattDevereau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157517/new/

[clang] c52d950 - [AArch64][SVE] Add asm predicate constraint Uph

Author: Matt Devereau Date: 2023-08-11T14:48:19Z New Revision: c52d9509d40d3048914b144618232213e6076e05 URL: https://github.com/llvm/llvm-project/commit/c52d9509d40d3048914b144618232213e6076e05 DIFF: https://github.com/llvm/llvm-project/commit/c52d9509d40d3048914b144618232213e6076e05.diff

[PATCH] D155081: Specify the developer policy around links to external resources

tahonermann added a comment. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141714: Fix ast print of variables with attributes

strimo378 added a comment. @aaron.ballman I had today a teams meeting with @giulianobelinassi and we discussed both patches as well as that we want to work together in improving AST print. Both patches are fine for us since they improve the attribute printing. The features of the respective

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd44f80a5a8: [clang-tidy] Fix crash when diagnostic is emit with invalid location (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a66de37fc0: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 549449. yronglin added a comment. Only create addational metarialized temporary in for-range-init. FIXME: Need to handle function default argument, and add more test to make sure the generated LLVM IR is correct. Repository: rG LLVM Github Monorepo

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

bob80905 added a comment. Shouldn't this new builtin be mentioned in Release Notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:903-906 +def mno_gather : Flag<["-"], "mno-gather">, Flags<[NoXarchOption]>, + HelpText<"Disable generation of gather instructions in auto-vectorization(x86 only)">; +def

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549365. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files:

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman updated this revision to Diff 549369. aaron.ballman added a comment. Accidentally uploaded a partial diff instead of the full set of changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 Files: llvm/docs/DeveloperPolicy.rst

[PATCH] D157727: [clang] Fix copy-and-paste error in CXXRecordDecl tabledef

cblichmann created this revision. cblichmann added reviewers: clang, rsmith, zahiraam. cblichmann added a project: clang. Herald added a project: All. cblichmann requested review of this revision. Herald added a subscriber: cfe-commits. This change just updates the comment in the tabledef, no

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

steakhal added a comment. In D157702#4580384 , @PiotrZSL wrote: > In D157702#4580310 , @steakhal > wrote: > >> Do we have other typos like this? > > I don't think so, only mess in overall documentation: >

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

steakhal accepted this revision. steakhal added a comment. Looks safe and good. I'm interested in the diff though. Let me know once you have the results. I wanna have a look before we land this. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:184 +//

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

steakhal added a comment. Isn't D153954 superseded this one? If so, consider abandoning it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150647/new/ https://reviews.llvm.org/D150647

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155773/new/ https://reviews.llvm.org/D155773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575 + // If we are here with a 'target teams loop' then we are emitting the + // 'parallel' region of the 'target teams distribute parallel for' + // emitted in place of the 'target teams

[PATCH] D156565: Diagnose use of VLAs in C++ by default

Endill added a comment. In D156565#4547909 , @aaron.ballman wrote: > In D156565#4543503 , @aaron.ballman > wrote: > >> In D156565#4543414 , @jrtc27 wrote: >> >>> Given

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

ilya-biryukov created this revision. ilya-biryukov added reviewers: shafik, rsmith. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The standard specified that Clang should 'search' for members in

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

ilya-biryukov added a comment. This change seems to expose a bug in Clang in C++20 see godbolt . I believe following code should compile, but it does not: struct X { virtual ~X(); virtual bool operator ==(X); bool operator !=(X); };

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. As I don't use this checker, thus I cannot speak of my experience. However, the reasons look solid and I'm fine with moving this checker to `unix.StdCLibraryFunctions`. Let some time for

[PATCH] D154603: [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker

steakhal added a comment. I'm sorry starting the review of this one only now, but I'm quite booked. Is it still relevant? If so, I'll continue. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:116-117 +const NoteTag *Note = +

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:967 S.getScopeForContext(EqFD->getEnclosingNamespaceContext())); NonMembers.suppressAccessDiagnostics(); for (NamedDecl *Op : NonMembers) { I believe we should

[PATCH] D155081: Specify the developer policy around links to external resources

cor3ntin accepted this revision. cor3ntin added a comment. This seems very reasonable to me Comment at: llvm/docs/DeveloperPolicy.rst:264 +#. Ensure that links in source code and test files are to publicly available + resources and are used primarily to add additional

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoScatter Does "Prefer no gather

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

steakhal added a comment. Do we have other typos like this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157702/new/ https://reviews.llvm.org/D157702 ___ cfe-commits mailing list

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Correct. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157702/new/ https://reviews.llvm.org/D157702

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL added a comment. In D157702#4580310 , @steakhal wrote: > Do we have other typos like this? I don't think so, only mess in overall documentation: https://github.com/llvm/llvm-project/issues/64614 I updated gen-static-analyzer-docs.py, and it

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

Mordante accepted this revision as: libc++. Mordante added a comment. I only looked at the libc++ changes. The libc++ AIX CI failures are unrelated to your patch. LGTM modulo one nit. Comment at:

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. BTW, I noticed something strange with `-pgo-function-entry-coverage` when merging via llvm-profdata. In this file `compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c`, I ran the following: // RUN: %clang_pgogen -o %t.cov.normal -mllvm

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cjdb added inline comments. Comment at: clang/test/SemaCXX/warn-constant-evaluated-constexpr.cpp:38 constexpr int fn5() { - if constexpr (__builtin_is_constant_evaluated()) // expected-warning {{'__builtin_is_constant_evaluated' will always evaluate to 'true' in a manifestly

[clang] 61c1e92 - Update documentation for C23 attribute spellings

Author: Aaron Ballman Date: 2023-08-11T08:42:49-04:00 New Revision: 61c1e925319e933869b6fe2db4e8d348986880b8 URL: https://github.com/llvm/llvm-project/commit/61c1e925319e933869b6fe2db4e8d348986880b8 DIFF: https://github.com/llvm/llvm-project/commit/61c1e925319e933869b6fe2db4e8d348986880b8.diff

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 549367. victorkingi marked an inline comment as done. victorkingi added a comment. addressing comments with code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[clang-tools-extra] e6f18b7 - [clangd] Remove extra dependancies for clangd

Author: Ahsan Saghir Date: 2023-08-11T08:57:12-05:00 New Revision: e6f18b75d7ffeb6d5a5cb740a61f38f8f122fee1 URL: https://github.com/llvm/llvm-project/commit/e6f18b75d7ffeb6d5a5cb740a61f38f8f122fee1 DIFF: https://github.com/llvm/llvm-project/commit/e6f18b75d7ffeb6d5a5cb740a61f38f8f122fee1.diff

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6f18b75d7ff: [clangd] Remove extra dependancies for clangd (authored by saghir, committed by lei). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

lei updated this revision to Diff 549374. lei added a comment. Rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155540/new/ https://reviews.llvm.org/D155540 Files: clang-tools-extra/clangd/tool/CMakeLists.txt Index:

[clang] 177ec17 - [libclang] Expose arguments of clang::annotate

Author: fridtjof Date: 2023-08-11T10:03:39-04:00 New Revision: 177ec17944af5fb87445017c3ac9028bbc1d710f URL: https://github.com/llvm/llvm-project/commit/177ec17944af5fb87445017c3ac9028bbc1d710f DIFF: https://github.com/llvm/llvm-project/commit/177ec17944af5fb87445017c3ac9028bbc1d710f.diff

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

This revision was automatically updated to reflect the committed changes. Closed by commit rG177ec17944af: [libclang] Expose arguments of clang::annotate (authored by fridtjof, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

aaron.ballman added a comment. In D151373#4578560 , @fridtjof wrote: > It was the unit test I added - I forgot to properly dispose of the EvalResult > there I've re-landed the changes in 177ec17944af5fb87445017c3ac9028bbc1d710f

[PATCH] D155081: Specify the developer policy around links to external resources

rZhBoYao added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345; to automate closing + the issue in GitHub. If the patch has been

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4578582 , @ellis wrote: > I've just published https://reviews.llvm.org/D157664, so you'll want to > rebase ontop of it if it lands soon. I would also like to see some more tests > added to `instrprof-merge-error.c`

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 549443. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files:

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:809-811 + Updater.AddAvailableValue( + Alloca.getParent(), + getInitialValueOfAllocation(, nullptr, VectorTy)); This is very specifically handling alloca, not any

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:122 llvm::DenseSet SeenSymbols; + std::string ResourceDir = HS->getHeaderSearchOpts().ResourceDir; // FIXME: Find a way to have less code duplication

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos updated this revision to Diff 549359. vhscampos added a comment. - Addressed the one comment regarding code. - Changed the test to use update_cc_test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos marked 3 inline comments as done. vhscampos added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:6 + unsigned int y : 16; +}; + tmatheson wrote: > This would be easier to check if the structs had

  1   2   >