[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added inline comments. Comment at: llvm/include/llvm/Object/ArchiveWriter.h:43 +enum SymtabWritingMode { + NoSymtab, // Do not write symbol table. Below you use `SymtabWritingMode::` for all members, so just make this enum scoped.

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

This revision was automatically updated to reflect the committed changes. Closed by commit rGec483c29a95c: [clang][ASTMatcher] Add matcher for MacroQualifiedType (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157780: [ASTImporter] Add import of MacroQualifiedType

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0eeb6cdbd7: [clang][ASTImporter] Add import of MacroQualifiedType (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ec483c2 - [clang][ASTMatcher] Add matcher for 'MacroQualifiedType'

Author: dingfei Date: 2023-08-16T18:03:16+08:00 New Revision: ec483c29a95cbaef460e3c8523af91ee1cc43e55 URL: https://github.com/llvm/llvm-project/commit/ec483c29a95cbaef460e3c8523af91ee1cc43e55 DIFF: https://github.com/llvm/llvm-project/commit/ec483c29a95cbaef460e3c8523af91ee1cc43e55.diff LOG:

[clang] 3b0eeb6 - [clang][ASTImporter] Add import of 'MacroQualifiedType'

Author: dingfei Date: 2023-08-16T18:03:16+08:00 New Revision: 3b0eeb6cdbd7d8f662f12c4d90bdaee7a01a6354 URL: https://github.com/llvm/llvm-project/commit/3b0eeb6cdbd7d8f662f12c4d90bdaee7a01a6354 DIFF: https://github.com/llvm/llvm-project/commit/3b0eeb6cdbd7d8f662f12c4d90bdaee7a01a6354.diff LOG:

[clang] eabc7ad - [clang][ASTImporter] Remove extra FunctionTemplateDecl introduced by templated friend

Author: dingfei Date: 2023-08-16T18:03:16+08:00 New Revision: eabc7add1f96e0b580cf4acf4f42ed3eb99df47b URL: https://github.com/llvm/llvm-project/commit/eabc7add1f96e0b580cf4acf4f42ed3eb99df47b DIFF: https://github.com/llvm/llvm-project/commit/eabc7add1f96e0b580cf4acf4f42ed3eb99df47b.diff LOG:

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeabc7add1f96: [clang][ASTImporter] Remove extra FunctionTemplateDecl introduced by templated… (authored by dingfei fd...@feysh.com). Repository:

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf marked 2 inline comments as done. qiucf added a comment. Thanks, fixed by rG2459ed67805c . `nmmintrin.h` just includes `smmintrin.h` so it's not critical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 added a comment. I added some missing (simple) setter methods to Decl and Expr classes. I did not comment them since typically simple setter methods are uncommented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/

[clang] 18252e6 - [Driver][unittest] Unbreak ToolChainTest.cpp compilation with -Werror

Author: Rainer Orth Date: 2023-08-16T10:37:14+02:00 New Revision: 18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e URL: https://github.com/llvm/llvm-project/commit/18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e DIFF: https://github.com/llvm/llvm-project/commit/18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e.diff

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet updated this revision to Diff 550662. kadircet marked an inline comment as done. kadircet added a comment. - Rename helper, update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157905/new/ https://reviews.llvm.org/D157905

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43 + // This results in surprising behavior from users point of view (we + // generate a usage of stdio.h, in places unrelated to

[PATCH] D78441: Delete NaCl support

MaskRay added a comment. In D78441#4074689 , @MaskRay wrote: > In D78441#4067440 , @dschuff wrote: > >> Sorry, no :) > > Is there a timeline for the removal? @dschuff :) Repository: rG LLVM Github Monorepo

[PATCH] D157905: [include-cleaner] Filter references to identity macros

sammccall accepted this revision. sammccall added a comment. still LG, comments are still confusing me a little Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43 + // This results in surprising behavior from users point of view (we + // generate a

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2581 + unsigned VectorWidth) { + if (!getTarget().getTriple().isX86() || VectorWidth < 512) +return; skan wrote: > Minor suggestion.

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

qiucf created this revision. qiucf added reviewers: nemanjai, stefanp, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[clang] 2459ed6 - [PowerPC] Add nmmintrin.h to copy list

Author: Qiu Chaofan Date: 2023-08-16T18:15:08+08:00 New Revision: 2459ed67805c1c6bd9d7db2f1e481b318960d7d8 URL: https://github.com/llvm/llvm-project/commit/2459ed67805c1c6bd9d7db2f1e481b318960d7d8 DIFF: https://github.com/llvm/llvm-project/commit/2459ed67805c1c6bd9d7db2f1e481b318960d7d8.diff

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

tschuett added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:227 + // Specifies, using a regex, which successful optimization passes done, + // to include in the final optimization record file generated. If not provided awarzynski

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei updated this revision to Diff 550669. pengfei marked an inline comment as done. pengfei added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157485/new/ https://reviews.llvm.org/D157485 Files:

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

eddyz87 added a comment. Hi @dblaikie, After this revision landed yesterday one BPF kernel selftest (written in C) stopped building. I narrowed the issue to the following example: #define SEC(n) __attribute__((section(n))) const int with_init SEC("foo") = 1; const int no_init

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

awarzynski updated this revision to Diff 550668. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 Files: clang/include/clang/Driver/Options.td

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550683. zyounan added a comment. Rebase and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/ExprConcepts.h

[PATCH] D158056: [clang] Implement constexpr operator[] for vectors

DaPorkchop_ created this revision. DaPorkchop_ added reviewers: erichkeane, rsmith, efriedma, void. Herald added a project: All. DaPorkchop_ requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements the array subscript operator for

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added a comment. hey @victorkingi , I am still unsure about parsing these remarks options in two places: - CompilerInvocation.cpp - ExecuteCompilerInvocation.cpp I think that it is important to clarify the relations between the two. In particular, it's normally the job of

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy added a comment. In D156312#4589251 , @steakhal wrote: > I don't think we should do anything about it unless it's frequent enough. > Try to come up with a heuristic to be able to measure how often this happens, > if you really care. > Once

[clang] 373fcd5 - [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

Author: Kadir Cetinkaya Date: 2023-08-16T10:22:16+02:00 New Revision: 373fcd5d73a3ed5bedff771bcf6a3aba981155cc URL: https://github.com/llvm/llvm-project/commit/373fcd5d73a3ed5bedff771bcf6a3aba981155cc DIFF:

[PATCH] D157868: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rG373fcd5d73a3: [clang] Use RecoveryExprs for broken defaultargs, instead of OpaqueValueExprs (authored by

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) HazardyKnusperkeks wrote: > Is a bit clearer. I moved this function up to here from below and only removed a couple

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan created this revision. zyounan added reviewers: saar.raz, erichkeane, ilya-biryukov, aaron.ballman. Herald added a subscriber: kadircet. Herald added a project: All. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, stefanp, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `smmintrin.h` uses

[PATCH] D157485: [X86][RFC] Support new feature AVX10

skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:927 + !STI.hasFeature(X86::FeatureAVX10_512bit)) +report_fatal_error("ZMM registers are not supported without AVX10-512BIT"); switch (TSFlags & X86II::OpPrefixMask) {

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158055 Files: clang/include/clang/AST/Decl.h

[clang] ae84ad1 - [Driver] Select newest GCC installation on Solaris

Author: Rainer Orth Date: 2023-08-16T09:57:59+02:00 New Revision: ae84ad15efd7ef7da95146e900ec72ceadf98058 URL: https://github.com/llvm/llvm-project/commit/ae84ad15efd7ef7da95146e900ec72ceadf98058 DIFF: https://github.com/llvm/llvm-project/commit/ae84ad15efd7ef7da95146e900ec72ceadf98058.diff

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae84ad15efd7: [Driver] Select newest GCC installation on Solaris (authored by ro). Changed prior to commit:

[clang] d77cba6 - [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

Author: Victor Campos Date: 2023-08-16T10:45:01+01:00 New Revision: d77cba6d474ab8ce5ece126499522de414c8089c URL: https://github.com/llvm/llvm-project/commit/d77cba6d474ab8ce5ece126499522de414c8089c DIFF: https://github.com/llvm/llvm-project/commit/d77cba6d474ab8ce5ece126499522de414c8089c.diff

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

This revision was automatically updated to reflect the committed changes. vhscampos marked an inline comment as done. Closed by commit rGd77cba6d474a: [Clang][DebugInfo] Emit narrower base types for structured binding declarations… (authored by vhscampos). Repository: rG LLVM Github Monorepo

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. Having worked with phabricator for a long time, this is the first time I've seen it "pull a github" where it just doesn't want to show you the content of anything in the review. Ugh, sorry for that! You can click on Changeset List above to see the list of changed

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550713. zyounan added a comment. Adapt to D157554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.h:76-81 +RK_Missing,// Remark argument not present on the command line. +RK_Enabled,// Remark enabled via '-Rgroup'. +RK_EnabledEverything, // Remark

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. (This will look different/better after D155858 , taking it off my radar until then) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

sammccall created this revision. sammccall added reviewers: kadircet, aaron.ballman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Document the valid states: invalid/unset/pointer (Currently both

[PATCH] D158093: [Sema] Clean up ActionResult type a little. NFCI

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot for doing this, i think this makes it a lot more obvious that this is a tristate struct rather than invalid just being a bit that can bit set for both null and non-null

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. friendly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157989: [NFC] Initialize pointer field

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1ddc5850b1: [NFC][OpenMP] Initialize pointer field (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

tschuett added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:227 + // Specifies, using a regex, which successful optimization passes done, + // to include in the final optimization record file generated. If not provided victorkingi

[clang] 5d9ccd7 - [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

Author: Akash Banerjee Date: 2023-08-16T16:35:28+01:00 New Revision: 5d9ccd7a96930351519ccbe5f85b127faa0dda9a URL: https://github.com/llvm/llvm-project/commit/5d9ccd7a96930351519ccbe5f85b127faa0dda9a DIFF:

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d9ccd7a9693: [OpenMP] Migrate dispatch related utility functions from Clang codegen to… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550725. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h

[clang] 871ee94 - [clang][ExprConst] Use call source range for 'in call to' diags

Author: Timm Bäder Date: 2023-08-16T15:22:29+02:00 New Revision: 871ee94141123f40cf0310ca89123c6c416c3d84 URL: https://github.com/llvm/llvm-project/commit/871ee94141123f40cf0310ca89123c6c416c3d84 DIFF: https://github.com/llvm/llvm-project/commit/871ee94141123f40cf0310ca89123c6c416c3d84.diff

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

This revision was automatically updated to reflect the committed changes. Closed by commit rG871ee9414112: [clang][ExprConst] Use call source range for in call to diags (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156604?vs=548520=550724#toc Repository: rG LLVM

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

dang added a comment. Looks mostly good. Quick Question how do we handle inheritance to a template parameter? Comment at: clang/include/clang/ExtractAPI/API.h:665 + +struct ClassTemplateSpecRecord : CXXClassRecord { + ClassTemplateSpecRecord(StringRef USR, StringRef Name,

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet updated this revision to Diff 550790. kadircet added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman. Herald added a reviewer: njames93. - Apply filtering only to macros that expand to themselves Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157905: [include-cleaner] Filter references to identity macros

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:43 + // This results in surprising behavior from users point of view (we + // generate a usage of stdio.h, in places unrelated to

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev added a comment. Could you also add the nesting tests for outer scope directive? Currently it tests only for inner CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 ___ cfe-commits mailing

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:9079 +auto *IDC = TC->getImmediatelyDeclaredConstraint(); +assert(IDC && "ImmediatelyDeclaredConstraint can't be null here."); +ExprResult Constraint = SubstExpr(IDC, MLTAL);

[PATCH] D158056: [clang] Implement constexpr operator[] for vectors

DaPorkchop_ updated this revision to Diff 550731. DaPorkchop_ added a comment. Fixed test code for `CodeGenCXX/temporaries.cpp` Creating and extracting a reference to a temporary vector's element is now able to be evaluated at compile time, which made this test case fail (since it was looking

[PATCH] D151315: [clangd] Add a switch to specify a default clangd configuration file

sammccall added a comment. Sorry about the delay, I think this is OK to add. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:500 +"User config is from clangd/config.yaml in the following directories \n" +"(unless specified with --default-config):\n"

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw added a comment. In D141177#4592158 , @aaron.ballman wrote: > @theo-lw -- are you planning to continue working on this review? (It's okay > if you're not, I'm more wondering if I should remove you as the assignee on >

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added a comment. In D141177#4592361 , @theo-lw wrote: > In D141177#4592158 , @aaron.ballman > wrote: > >> @theo-lw -- are you planning to continue working on this review? (It's okay >> if you're

[PATCH] D129061: [Lex] Diagnose macro in command lines

aaron.ballman added a comment. This review went cold for about a year now (sorry for not noticing we hadn't answered your question!), so I'm uncertain if @jackhong12 is still interested in pursuing this. If not, that's totally fine, just let us know so we can remove you as the assignee on the

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

eddyz87 added a comment. As an additional data point, the same example but w/o section specification compiles fine: const int with_init = 1; const int no_init; And puts both globals to the same section: $ clang -c t.c -o - | llvm-readelf --section-headers -s - Section Headers:

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

tbaeder updated this revision to Diff 550696. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158069/new/ https://reviews.llvm.org/D158069 Files: clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Pointer.h clang/unittests/AST/CMakeLists.txt

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder abandoned this revision. tbaeder added a comment. Superseeded by https://reviews.llvm.org/D156027. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550719. victorkingi marked 9 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

sammccall added a comment. Thanks for working on this! FWIW I had an old draft of this feature that may have interesting ideas: https://reviews.llvm.org/D122827 Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:44 +for (const auto : +

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

tbaeder accepted this revision. tbaeder added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc;

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: JDevlieghere, zaks.anna, rjmccall, ahatanak. Herald added subscribers: steakhal, jdoerfert, martong, pengfei, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. aaron.ballman requested review of this revision.

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

hans added a comment. Apologies for the delay, I'm still catching up with my post-vacation backlog. (For my notes, this came up in https://reviews.llvm.org/D153709) I think the root of this bug is how class-level dll attributes get propagated to class members. Here is an example: template

[PATCH] D156441: [clangd]Fix addUsing tweak doesn't traverse same-level anon namespaces

sammccall added a comment. This would be a great fix to have! However I don't think the specific changes to the RecursiveASTVisitor are correct. I can see a couple of approaches: 1. prevent the RecursiveASTVisitor from traversing into uninteresting contexts, and drop the Encloses check in

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree this is a mess: the reason we think objective-c++-header is safe is that we have built-in support, but in the presence of query-driver that's not enough. In terms of testing this:

[clang-tools-extra] a94c44c - [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

Author: Felix Date: 2023-08-16T15:02:56Z New Revision: a94c44cc0a5601e977b5cc1d2cfdee1488be62e9 URL: https://github.com/llvm/llvm-project/commit/a94c44cc0a5601e977b5cc1d2cfdee1488be62e9 DIFF: https://github.com/llvm/llvm-project/commit/a94c44cc0a5601e977b5cc1d2cfdee1488be62e9.diff LOG:

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rGa94c44cc0a56: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. At the moment, the TargetParser architecture is extensible. This complicates the addition of new architectures, operating systems, and so on. In the main discussion, it was proposed to redesign the architecture of this module in order to increase the possibility of

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. I'd hope there are common code paths where `isVLSTBuiltinType` would still be useful but I guess this step is required to make that happen anyway. If you permit a minor

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 550703. donat.nagy added a comment. Updated the release notes. This could be the final version of this commit if you agree that it's good enough. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 Files:

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

sammccall added a comment. Thanks, this does look better. I agree with Nathan's comments and will leave final stamp to him. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:144 + + // This variable would be discarded directly at the end of this function. We +

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis updated this revision to Diff 550729. TIFitis added a comment. Updated test with correct function attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157994/new/ https://reviews.llvm.org/D157994 Files:

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155833/new/ https://reviews.llvm.org/D155833 ___ cfe-commits mailing list

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/test/Driver/optimization-remark.f90:7 +! RUN: %flang_fc1 %s -O1 -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS +! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass -emit-llvm -o - 2>&1 | FileCheck %s

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 550776. DiggerLin marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:519-521 + if (const ElaboratedType *ET = dyn_cast(BaseType)) { +if (const TemplateSpecializationType *TST = +dyn_cast(ET->getNamedType())) { I think you can skip the

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 550910. ZijunZhao added a comment. 1. separate two files in clang/test/C/C2x 2. make some update about the macro __STDC_VERSION_STDCKDINT_H__ add the test for testing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

xur accepted this revision. xur added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

dhoekwater added a comment. This patch will make it difficult to write tests for MFS on AArch64 before it is officially enabled. Currently, because clang performs the Triple check, we can use `-enable-split-machine-functions` to run tests with MFS on Arm, but after this patch the flag won't do

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added a comment. In D157750#4593582 , @dhoekwater wrote: > This patch will make it difficult to write tests for MFS on AArch64 before it > is officially enabled. Currently, because clang performs the Triple check, we > can use

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

SlaterLatiao updated this revision to Diff 550927. SlaterLatiao added a comment. - Refactor instantiating members into 2 functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156546/new/ https://reviews.llvm.org/D156546 Files:

[clang] 314a5d7 - Simplify a conditional in order to avoid a warning under MSVC

Author: Justin Bogner Date: 2023-08-16T16:19:57-07:00 New Revision: 314a5d707fe70369e3e1a6ac561d64884896dbd7 URL: https://github.com/llvm/llvm-project/commit/314a5d707fe70369e3e1a6ac561d64884896dbd7 DIFF: https://github.com/llvm/llvm-project/commit/314a5d707fe70369e3e1a6ac561d64884896dbd7.diff

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 550937. evelez7 marked 5 inline comments as done. evelez7 added a comment. Address review feedback - Handle inheriting from a template parameter. - Add a new test to check inheriting from a template parameter. - Move base class gathering to a new private

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:37 + let Inst{12} = 0; + let Inst{11-7} = rs1; + let Inst{6-2} = 0b0; Do we need the rs1 variable or can we use rs1val here? We usually have the rs1 field

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 550940. capfredf added a comment. up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h

[PATCH] D158135: [Clang] Add __builtin_bcopy

cseo created this revision. Herald added a project: All. cseo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add __builtin_bcopy to the list of GNU builtins. This was causing a series of test failures in glibc. Fixes #51409. Fixes

[clang] 52c62d4 - Reland "[modules] Fix error about the same module being defined in different .pcm files when using VFS overlays."

Author: Volodymyr Sapsai Date: 2023-08-16T18:27:17-07:00 New Revision: 52c62d46a0c8ebf6023233cabc5beb4ee2687c78 URL: https://github.com/llvm/llvm-project/commit/52c62d46a0c8ebf6023233cabc5beb4ee2687c78 DIFF:

[PATCH] D157485: [X86][RFC] Support new feature AVX10

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:739 + if (HasAVX10_512BIT) +Builder.defineMacro("__AVX10_512BIT__"); + This is untested? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 updated this revision to Diff 550953. evelez7 added a comment. Update Spec naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

evelez7 updated this revision to Diff 550958. evelez7 added a comment. Update to use the new Template class constructor instead of old getFragments. Also better functional style for appending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158045: [clang][SVE] Rename isVLSTBuiltinType, NFC

jacquesguan added a comment. In D158045#4592331 , @paulwalker-arm wrote: > I'd hope there are common code paths where `isVLSTBuiltinType` would still be > useful but I guess this step is required to make that happen anyway. > > If you permit a minor

[clang] bb5f64a - Add Requires x86 target to test due to failure in clang-armv8-quick

Author: usama hameed Date: 2023-08-16T15:09:14-07:00 New Revision: bb5f64a6fc059fcf81b4b9ffe035f5063956ddd8 URL: https://github.com/llvm/llvm-project/commit/bb5f64a6fc059fcf81b4b9ffe035f5063956ddd8 DIFF: https://github.com/llvm/llvm-project/commit/bb5f64a6fc059fcf81b4b9ffe035f5063956ddd8.diff

  1   2   3   >