[PATCH] D157956: [clangd] don't add inlay hint for dependent type in structured binding

2023-08-20 Thread Nathan Ridge via Phabricator via cfe-commits
nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! A future enhancement to consider could be, in the following testcase: template struct Pair { T t; U u; }; template void foobar(Pair arg) { auto [a, b] =

[clang] 39236e9 - [clang][Interp] Fix lifetime diagnostics for dead records

2023-08-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-08-20T11:38:29+02:00 New Revision: 39236e9c60e50278d042304b13823e116b68ce78 URL: https://github.com/llvm/llvm-project/commit/39236e9c60e50278d042304b13823e116b68ce78 DIFF: https://github.com/llvm/llvm-project/commit/39236e9c60e50278d042304b13823e116b68ce78.diff

[PATCH] D152132: [clang][Interp] Fix lifetime diagnostics for dead records

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39236e9c60e5: [clang][Interp] Fix lifetime diagnostics for dead records (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ebbedc4 - [clang][Sema][NFC] Remove TileLoc parameter from getDestructorName()

2023-08-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-08-20T11:02:12+02:00 New Revision: ebbedc46f17ddfcb51d9781daa56d5dd011c3bb2 URL: https://github.com/llvm/llvm-project/commit/ebbedc46f17ddfcb51d9781daa56d5dd011c3bb2 DIFF: https://github.com/llvm/llvm-project/commit/ebbedc46f17ddfcb51d9781daa56d5dd011c3bb2.diff

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

2023-08-20 Thread Nathan Ridge via Phabricator via cfe-commits
nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for the patch! My thoughts are: - As mentioned in the issue, I think this fills a logical gap: clangd-indexer is an alternative way of generating a project index to clangd's

[clang] 8a58f0d - [clang][Interp] Handle global composite temporaries

2023-08-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-08-20T11:15:17+02:00 New Revision: 8a58f0d370b004ec0c8f4af003da6b370f17ff44 URL: https://github.com/llvm/llvm-project/commit/8a58f0d370b004ec0c8f4af003da6b370f17ff44 DIFF: https://github.com/llvm/llvm-project/commit/8a58f0d370b004ec0c8f4af003da6b370f17ff44.diff

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a58f0d370b0: [clang][Interp] Handle global composite temporaries (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

2023-08-20 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:106 +int x3[__builtin_offsetof(struct X2, X2::static_a) == 0 ? 1 : -1]; // expected-error{{no member named 'static_a'}} +int x4[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no

[clang] e1dfbc4 - [clang][Sema][NFC] Modernize ActOnCallExpr

2023-08-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-08-20T10:37:58+02:00 New Revision: e1dfbc4e24dde8d09aa9f0e9f2228d732e002d0a URL: https://github.com/llvm/llvm-project/commit/e1dfbc4e24dde8d09aa9f0e9f2228d732e002d0a DIFF: https://github.com/llvm/llvm-project/commit/e1dfbc4e24dde8d09aa9f0e9f2228d732e002d0a.diff

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

2023-08-20 Thread Yurong via Phabricator via cfe-commits
yronglin updated this revision to Diff 551871. yronglin added a comment. Do not spass MaterializePRValueInDiscardStatement in PushExpressionEvaluationContext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/

[PATCH] D157130: [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

2023-08-20 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157130/new/ https://reviews.llvm.org/D157130

[PATCH] D157956: [clangd] don't add inlay hint for dependent type in structured binding

2023-08-20 Thread Vincent Hong via Phabricator via cfe-commits
v1nh1shungry added a comment. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157956/new/ https://reviews.llvm.org/D157956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78441: Delete NaCl support

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. In D78441#4593287 , @dschuff wrote: > Deprecation is progressing > (https://groups.google.com/a/chromium.org/g/chromium-extensions/c/v8H1UHnPotY/m/NmzrIv_VBAAJ) > but we are still supporting it on some platforms, (and using clang's

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

2023-08-20 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:167 + FEATURE_WP, + FEATURE_LZCNT = 57, + FEATURE_MOVBE, ` = 57` redundant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

2023-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13318-13320 +Value *Idxs[] = {Builder.getInt32(0), Builder.getInt32(i - 1)}; +Value *Features = Builder.CreateAlignedLoad( +Int32Ty,

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

2023-08-20 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. Thanks for implementing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158065/new/ https://reviews.llvm.org/D158065 ___ cfe-commits

[PATCH] D158360: [docs] Update the static analyzer bug reporting page

2023-08-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: NoQ, steakhal, zaks.anna, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. aaron.ballman requested review of this revision.

[clang] f01f2de - [CodeGen] Modernize CallArgList (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T09:42:59-07:00 New Revision: f01f2de5409dadec8a31e417fb183f222d3486f6 URL: https://github.com/llvm/llvm-project/commit/f01f2de5409dadec8a31e417fb183f222d3486f6 DIFF: https://github.com/llvm/llvm-project/commit/f01f2de5409dadec8a31e417fb183f222d3486f6.diff

[clang] 477457c - [CodeGen] Modernize NullReturnState (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T09:43:01-07:00 New Revision: 477457c3a7c3ca5f6042a35e61226df0f56aec34 URL: https://github.com/llvm/llvm-project/commit/477457c3a7c3ca5f6042a35e61226df0f56aec34 DIFF: https://github.com/llvm/llvm-project/commit/477457c3a7c3ca5f6042a35e61226df0f56aec34.diff

[clang] c6bcdc4 - [CodeGen] Modernize GuardInfo (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T09:43:02-07:00 New Revision: c6bcdc42c1a7bfaa44d7823bb72444925e0b383b URL: https://github.com/llvm/llvm-project/commit/c6bcdc42c1a7bfaa44d7823bb72444925e0b383b DIFF: https://github.com/llvm/llvm-project/commit/c6bcdc42c1a7bfaa44d7823bb72444925e0b383b.diff

[clang] bd31c36 - [AST] Modernize FunctionTypeDepthState (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T09:42:56-07:00 New Revision: bd31c36fd0c8efa57dea9c078d191d01d24e929f URL: https://github.com/llvm/llvm-project/commit/bd31c36fd0c8efa57dea9c078d191d01d24e929f DIFF: https://github.com/llvm/llvm-project/commit/bd31c36fd0c8efa57dea9c078d191d01d24e929f.diff

[clang] 7a68060 - [AST] Modernize ExternalLayout (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T09:42:57-07:00 New Revision: 7a6806073dd802e475b6fe9ae05e618927d4fd14 URL: https://github.com/llvm/llvm-project/commit/7a6806073dd802e475b6fe9ae05e618927d4fd14 DIFF: https://github.com/llvm/llvm-project/commit/7a6806073dd802e475b6fe9ae05e618927d4fd14.diff

[PATCH] D158367: [AMDGPU] Add target feature gds/gws to clang

2023-08-20 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/TargetParser/TargetParser.cpp:289 Features["image-insts"] = true; + Features["gds"] = true; + Features["gws"] = true; Gds feature is unused CHANGES SINCE LAST ACTION

[PATCH] D158378: [Driver] move Minix header search path management to the driver

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a project: All. brad requested review of this revision. As has been done for other OS's. Move the header path management to the driver. Repository: rG LLVM Github Monorepo

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

2023-08-20 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. @sammccall Hi, Sam. Thanks for your high-quality comments! It is valuable. All the low-level inline comments are helpful. But I didn't reply them for the suggested direction in the higher level comments. I'll repeat your suggestion in my mind again to avoid any

[clang] 9b987e0 - [Sema] Modernize ShadowMapEntry (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T22:07:59-07:00 New Revision: 9b987e08963dc001f1447e80fa77c17b3e612d68 URL: https://github.com/llvm/llvm-project/commit/9b987e08963dc001f1447e80fa77c17b3e612d68 DIFF: https://github.com/llvm/llvm-project/commit/9b987e08963dc001f1447e80fa77c17b3e612d68.diff

[clang] 760e0c3 - [StaticAnalyzer] Modernize CFNumberChecker (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T22:08:01-07:00 New Revision: 760e0c353787d73a02c609d8abed7ed75baed7df URL: https://github.com/llvm/llvm-project/commit/760e0c353787d73a02c609d8abed7ed75baed7df DIFF: https://github.com/llvm/llvm-project/commit/760e0c353787d73a02c609d8abed7ed75baed7df.diff

[clang] abed823 - [Sema] Modernize UsageInfo (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T22:07:58-07:00 New Revision: abed823dfe6b2cc337f5d20109b519db901e09af URL: https://github.com/llvm/llvm-project/commit/abed823dfe6b2cc337f5d20109b519db901e09af DIFF: https://github.com/llvm/llvm-project/commit/abed823dfe6b2cc337f5d20109b519db901e09af.diff

[clang] 848be08 - [StaticAnalyzer] Modernize DeleteBugVisitor (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T22:08:02-07:00 New Revision: 848be088658da0d07680e129a6a7f79a7f31d2f3 URL: https://github.com/llvm/llvm-project/commit/848be088658da0d07680e129a6a7f79a7f31d2f3 DIFF: https://github.com/llvm/llvm-project/commit/848be088658da0d07680e129a6a7f79a7f31d2f3.diff

[clang] 6f31908 - [StaticAnalyzer] Modernize InvalidationInfo (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T22:08:04-07:00 New Revision: 6f31908d20131953b266f44a05b93971475dd2ad URL: https://github.com/llvm/llvm-project/commit/6f31908d20131953b266f44a05b93971475dd2ad DIFF: https://github.com/llvm/llvm-project/commit/6f31908d20131953b266f44a05b93971475dd2ad.diff

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

2023-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13318-13320 +Value *Idxs[] = {Builder.getInt32(0), Builder.getInt32(i - 1)}; +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs),

[PATCH] D158158: [clang] Set FP options in Sema when instantiating CompoundStmt

2023-08-20 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0baf85c33109: [clang] Set FP options in Sema when instantiating CompoundStmt (authored by sepavloff). Changed prior to commit:

[clang] 0baf85c - [clang] Set FP options in Sema when instantiating CompoundStmt

2023-08-20 Thread Serge Pavlov via cfe-commits
Author: Serge Pavlov Date: 2023-08-21T12:36:41+07:00 New Revision: 0baf85c331090fbe2d2b42214ed0664d55feb0b5 URL: https://github.com/llvm/llvm-project/commit/0baf85c331090fbe2d2b42214ed0664d55feb0b5 DIFF: https://github.com/llvm/llvm-project/commit/0baf85c331090fbe2d2b42214ed0664d55feb0b5.diff

[PATCH] D157385: [clang][CFG] Cleanup functions

2023-08-20 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. For me this looks good, but I'd like @NoQ to sign off on it. Comment at: clang/lib/Analysis/CFG.cpp:1874 +if (needsAutomaticDestruction(D)) DeclsNonTrivial.push_back(D); I'm wondering if you should rename this

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

2023-08-20 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D152246#4484366 , @tbaeder wrote: > So, the problem with this (type of) analysis is that we don't have a perfect > view of the (global) program state, right? The CFG is per-function, and any > other function (etc.)

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 551872. brad added a comment. Also use concat() in addLibStdCxxIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files:

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

2023-08-20 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13318-13320 +Value *Idxs[] = {Builder.getInt32(0), Builder.getInt32(i - 1)}; +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs),

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

2023-08-20 Thread Brian Cain via Phabricator via cfe-commits
bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D158378: [Driver] move Minix header search path management to the driver

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. In D158378#4602289 , @MaskRay wrote: > Thank you for driving the migration! > > case llvm::Triple::Minix: > AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", > "", "", "", triple); > >

[PATCH] D158385: [tsan] Respect !nosanitize metadata and remove gcov special case

2023-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: Sanitizers, dvyukov, melver, vitalybuka, Enna1. Herald added a subscriber: hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

2023-08-20 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc updated this revision to Diff 551890. wangpc added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D158378: [Driver] move Minix header search path management to the driver

2023-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D158378#4602375 , @brad wrote: > In D158378#4602289 , @MaskRay wrote: > >> Thank you for driving the migration! >> >> case llvm::Triple::Minix: >>

[clang] 6acff53 - [X86] Support -march=gracemont

2023-08-20 Thread Freddy Ye via cfe-commits
Author: Freddy Ye Date: 2023-08-21T08:49:01+08:00 New Revision: 6acff5390d0504ef0e805a7266a48398fb67876c URL: https://github.com/llvm/llvm-project/commit/6acff5390d0504ef0e805a7266a48398fb67876c DIFF: https://github.com/llvm/llvm-project/commit/6acff5390d0504ef0e805a7266a48398fb67876c.diff

[PATCH] D158046: [X86] Support -march=gracemont

2023-08-20 Thread Freddy, Ye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acff5390d05: [X86] Support -march=gracemont (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158378: [Driver] move Minix header search path management to the driver

2023-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Thank you for driving the migration! case llvm::Triple::Minix: AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", "", "", "", triple); The GCC 4.4.3 thing is from 3e2ee147d0ddb23592b2ec8294381b5e1801cc62 (2010).

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

2023-08-20 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan marked an inline comment as done. jacquesguan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14906 +// specified +if (S.Context.areCompatibleRVVTypes(QualType(OriginalTarget, 0), +QualType(Source,

[clang-tools-extra] dc10bd4 - [clangd] don't add inlay hint for dependent type in structured binding

2023-08-20 Thread Yuanjing Hong via cfe-commits
Author: Yuanjing Hong Date: 2023-08-21T11:10:40+08:00 New Revision: dc10bd43a103d0e252c4fb4d30913f99b4f418fe URL: https://github.com/llvm/llvm-project/commit/dc10bd43a103d0e252c4fb4d30913f99b4f418fe DIFF: https://github.com/llvm/llvm-project/commit/dc10bd43a103d0e252c4fb4d30913f99b4f418fe.diff

[PATCH] D157956: [clangd] don't add inlay hint for dependent type in structured binding

2023-08-20 Thread Vincent Hong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdc10bd43a103: [clangd] dont add inlay hint for dependent type in structured binding (authored by v1nh1shungry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152423: [RISCV] Add function that check extension name with version

2023-08-20 Thread Piyou Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b60e1e821b4: [RISCV] Add function that check extension name with version (authored by BeMg). Herald added a subscriber: sunshaoce. Repository:

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

2023-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to

[clang] c4e4b64 - [docs] Update the static analyzer bug reporting page

2023-08-20 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-08-20T10:49:29-04:00 New Revision: c4e4b64c1249f1fc438abb72e2115d334c5ba476 URL: https://github.com/llvm/llvm-project/commit/c4e4b64c1249f1fc438abb72e2115d334c5ba476 DIFF: https://github.com/llvm/llvm-project/commit/c4e4b64c1249f1fc438abb72e2115d334c5ba476.diff

[PATCH] D158360: [docs] Update the static analyzer bug reporting page

2023-08-20 Thread Aaron Ballman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4e4b64c1249: [docs] Update the static analyzer bug reporting page (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

2023-08-20 Thread Ignat Loskutov via Phabricator via cfe-commits
loskutov created this revision. loskutov added reviewers: sbenza, PiotrZSL. loskutov added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. loskutov requested review of this revision. Herald added a

[PATCH] D158360: [docs] Update the static analyzer bug reporting page

2023-08-20 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Makes sense to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158360/new/ https://reviews.llvm.org/D158360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 3d22dac - Revert "[clang][test] Refine clang machine-function-split tests."

2023-08-20 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2023-08-20T10:38:29-04:00 New Revision: 3d22dac6c3b97d7bb92f243886dfb0d32a5c42e9 URL: https://github.com/llvm/llvm-project/commit/3d22dac6c3b97d7bb92f243886dfb0d32a5c42e9 DIFF: https://github.com/llvm/llvm-project/commit/3d22dac6c3b97d7bb92f243886dfb0d32a5c42e9.diff

[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

2023-08-20 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. reverted in 3d22dac6c3b97d7bb92f243886dfb0d32a5c42e9 for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157565/new/ https://reviews.llvm.org/D157565

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

2023-08-20 Thread Yurong via Phabricator via cfe-commits
yronglin updated this revision to Diff 551845. yronglin added a comment. Fix ci failure, and introduce an variable in ExpressionEvaluationContextRecord to rewrite default argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/

[clang] 4d434f7 - [Sema] Modernize Usage (NFC)

2023-08-20 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-08-20T09:43:04-07:00 New Revision: 4d434f76967f2fea344fc9de2686a9295c16e56d URL: https://github.com/llvm/llvm-project/commit/4d434f76967f2fea344fc9de2686a9295c16e56d DIFF: https://github.com/llvm/llvm-project/commit/4d434f76967f2fea344fc9de2686a9295c16e56d.diff

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 551854. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Program.cpp

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. All the dependencies have been pushed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

2023-08-20 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao created this revision. rZhBoYao added reviewers: clang-language-wg, aaron.ballman, jyknight. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a language extension, if an invalid a UDL's

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

2023-08-20 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao added a comment. D158372 addresses comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.llvm.org/D153156 ___ cfe-commits

[clang] 6dfe555 - [clang][Interp] Rework initializers

2023-08-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-08-20T13:33:08+02:00 New Revision: 6dfe55569d88ff654d13e6c09267eff0cd9c9f0d URL: https://github.com/llvm/llvm-project/commit/6dfe55569d88ff654d13e6c09267eff0cd9c9f0d DIFF: https://github.com/llvm/llvm-project/commit/6dfe55569d88ff654d13e6c09267eff0cd9c9f0d.diff

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

2023-08-20 Thread Arkadiy Yudintsev via Phabricator via cfe-commits
d0nc1h0t created this revision. d0nc1h0t added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a comment. d0nc1h0t requested review of this revision. NOTE:

[PATCH] D158367: [AMDGPU] Add target feature gds/gws to clang

2023-08-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm, foad. Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Herald added a

[PATCH] D156027: [clang][Interp] Rework how initializers work

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dfe55569d88: [clang][Interp] Rework initializers (authored by tbaeder). Changed prior to commit:

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

2023-08-20 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. In D158066#4593961 , @qiucf wrote: > CC @amyk @quinnp Any comments about the naming? > > I see some `__builtin_ppc_xxx` are aliased into `__builtin_xxx` by > `defineXLCompatMacros`. But these are not XL-compatible builtins, and

[clang] b1aa7cd - [clang][Sema][NFC] Make some locals const in getUndefinedButUsed()

2023-08-20 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-08-20T13:55:25+02:00 New Revision: b1aa7cd8a9f3793a04e15af813082b996519be44 URL: https://github.com/llvm/llvm-project/commit/b1aa7cd8a9f3793a04e15af813082b996519be44 DIFF: https://github.com/llvm/llvm-project/commit/b1aa7cd8a9f3793a04e15af813082b996519be44.diff

[PATCH] D158361: [clang][Sema] Fix a copy/paste bug in ~Sema()

2023-08-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added a reviewer: saar.raz. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158361 Files:

[PATCH] D158360: [docs] Update the static analyzer bug reporting page

2023-08-20 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Makes sense to me, thanks! I'm not sure though how much we wanna invest into maintaining these handwritten htmls. I would prefer moving away from these. It would likely also fit more

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

2023-08-20 Thread Yurong via Phabricator via cfe-commits
yronglin updated this revision to Diff 551851. yronglin added a comment. Fix ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added a reviewer: devnexen. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. As has been done for other OS's. Move the header path management to the driver. Also I noticed with