[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 555973. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaConcept.cpp

[clang] [clang][dataflow] Eliminate uses of `RecordValue::getChild()`. (PR #65329)

2023-09-06 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/65329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-06 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet added a comment. @cor3ntin Gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.llvm.org/D155610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AArch64]: Refactor target parser to use BitVector. (PR #65423)

2023-09-06 Thread David Green via cfe-commits
https://github.com/davemgreen review_requested https://github.com/llvm/llvm-project/pull/65423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-06 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + bool IsUnwindTablesDefault(const llvm::opt::ArgList ) const {

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet review_requested https://github.com/llvm/llvm-project/pull/65444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet review_requested https://github.com/llvm/llvm-project/pull/65444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/65444: None From 0b33a1277beb1ec518cb000923d02d78365bfd82 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Tue, 5 Sep 2023 19:19:47 +0200 Subject: [PATCH] [clangd][unittests] Limit paralelism for clangd

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread kadir çetinkaya via cfe-commits
kadircet wrote: @HighCommander4 @AaronBallman FYI https://github.com/llvm/llvm-project/pull/65444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/65444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #65407)

2023-09-06 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler

2023-09-06 Thread Stephen Tozer via Phabricator via cfe-commits
StephenTozer updated this revision to Diff 556011. StephenTozer added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Significant patch updates: Changed attribute from "disable-post-ra" to `optdebug`, following the direction that the discussion on the

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

2023-09-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Given that we still need to check for substitution errors in untaken branches, this look reasonable (especially as i think you are right that alternative approaches are likely to be more complex) however i think it does require a comment, and I'd like @erichkeane to

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

2023-09-06 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5809e7e7bc: [clang][Interp] Enable existing source_location tests (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7e5809e - [clang][Interp] Enable existing source_location tests

2023-09-06 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-06T15:05:45+02:00 New Revision: 7e5809e7e7bc9a828427b6540a51d45884d8 URL: https://github.com/llvm/llvm-project/commit/7e5809e7e7bc9a828427b6540a51d45884d8 DIFF: https://github.com/llvm/llvm-project/commit/7e5809e7e7bc9a828427b6540a51d45884d8.diff

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Daniel Grumberg via cfe-commits
daniel-grumberg wrote: This is a follow up on https://reviews.llvm.org/D142560 I couldn't find Dana on here to but in the the reviewer list. Maybe @gribozavr can help locate them? https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger

2023-09-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158646/new/ https://reviews.llvm.org/D158646

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D151834#4639600 , @zahiraam wrote: > In D151834#4639536 , @aaron.ballman > wrote: > >> LGTM, but please add a release note describing the changes when you land >> them. > >

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

2023-09-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. hi @hiraditya , i believe your issues should disappear starting with 9a26d2c6d35f574d7a4b06a5a22f8a1c063cb664 . LMK if you're still facing problems and want to move forward with such a patch

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

2023-09-06 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 556004. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files:

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a subscriber: Endill. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note because there are user-facing changes regarding what the feature test macros return or what

[PATCH] D159441: [include-cleaner] Weaken signal for boosting preferred headers

2023-09-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG73b2c86d95dc: [include-cleaner] Weaken signal for boosting preferred headers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
@@ -0,0 +1,71 @@ +; RUN: mkdir -p %t/logs +; RUN: rm -rf %t/logs + +; Basic dump before and after a single module pass +; RUN: opt %s -disable-output -passes='no-op-module' -ir-dump-directory %t/logs -dump-after=no-op-module -dump-before=no-op-module +; RUN: find %t/logs -type f

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
@@ -0,0 +1,71 @@ +; RUN: mkdir -p %t/logs +; RUN: rm -rf %t/logs + +; Basic dump before and after a single module pass +; RUN: opt %s -disable-output -passes='no-op-module' -ir-dump-directory %t/logs -dump-after=no-op-module -dump-before=no-op-module +; RUN: find %t/logs -type f

[clang] 92ac46e - [clang][Interp] Handle CXXParenListInitExprs

2023-09-06 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-06T15:26:54+02:00 New Revision: 92ac46e703cfa0a5313f83d5c5fa3b298edaa777 URL: https://github.com/llvm/llvm-project/commit/92ac46e703cfa0a5313f83d5c5fa3b298edaa777 DIFF: https://github.com/llvm/llvm-project/commit/92ac46e703cfa0a5313f83d5c5fa3b298edaa777.diff

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

2023-09-06 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92ac46e703cf: [clang][Interp] Handle CXXParenListInitExprs (authored by tbaeder). Changed prior to commit:

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

2023-09-06 Thread Viktoriia Bakalova via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG625891288087: [clangd][clang-tidy] Add missing symbols to the symbol map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159462/new/

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg created https://github.com/llvm/llvm-project/pull/65481: For declarations declared inside a macro, e.g.: ``` `#define MAKE_FUNC(suffix) \ /// Not selected doc comment \ void func_##suffix(void) { } /// Doc comment foo MAKE_FUNC(foo) ///

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Prioritze decl comments from macro expansion site (PR #65481)

2023-09-06 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg review_requested https://github.com/llvm/llvm-project/pull/65481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 556029. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

2023-09-06 Thread Ding Fei via cfe-commits
https://github.com/danix800 created https://github.com/llvm/llvm-project/pull/65448: Fixes #54377 >From 2b04f714f1e1985546ff7ed00c131591316782b8 Mon Sep 17 00:00:00 2001 From: dingfei Date: Wed, 6 Sep 2023 10:03:21 +0800 Subject: [PATCH] [analyzer] Reduce constraint on modulo with small

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread kadir çetinkaya via cfe-commits
@@ -209,14 +213,17 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult ) { // main file. if (auto Replacement = HeaderIncludes.insert(llvm::StringRef{Spelling}.trim("\"<>"), - Angled,

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread kadir çetinkaya via cfe-commits
@@ -199,6 +200,9 @@ void IncludeCleanerCheck::check(const MatchFinder::MatchResult ) { tooling::HeaderIncludes HeaderIncludes(getCurrentMainFile(), Code, FileStyle->IncludeStyle); + // `tooling::HeaderIncludes::insert` will not

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread kadir çetinkaya via cfe-commits
@@ -224,7 +224,8 @@ Changes in existing checks - Improved :doc:`misc-include-cleaner ` check by adding option - `DeduplicateFindings` to output one finding per symbol occurrence. + `DeduplicateFindings` to output one finding per symbol occurrence + and avoid fixes

[clang] [analyzer] Reduce constraint on modulo with small concrete range (PR #65448)

2023-09-06 Thread Ding Fei via cfe-commits
https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/65448: >From 235f39a6a5137e53239105727798d4540e5dd563 Mon Sep 17 00:00:00 2001 From: dingfei Date: Wed, 6 Sep 2023 10:03:21 +0800 Subject: [PATCH] [analyzer] Reduce constraint on modulo with small concrete range

[clang] be12f26 - [clang][dataflow][NFC] Remove stale comment. (#65322)

2023-09-06 Thread via cfe-commits
Author: martinboehme Date: 2023-09-06T09:52:30+02:00 New Revision: be12f26dc00cad8bcd575b176a453a1c7c4fdff5 URL: https://github.com/llvm/llvm-project/commit/be12f26dc00cad8bcd575b176a453a1c7c4fdff5 DIFF: https://github.com/llvm/llvm-project/commit/be12f26dc00cad8bcd575b176a453a1c7c4fdff5.diff

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

2023-09-06 Thread Martin Böhme via Phabricator via cfe-commits
mboehme accepted this revision. mboehme added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2498 +TEST(TransferTest, ReturnStructWithInheritance) { + // This is a crash repro. (Returning a

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-06 Thread via cfe-commits
@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value , Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast()) { -[[maybe_unused]] auto *RecordVal2 = cast(); - -// Values to be merged are always associated with the same location in

[clang] [clang][dataflow] Merge `RecordValue`s with different locations correctly. (PR #65319)

2023-09-06 Thread via cfe-commits
@@ -121,18 +121,18 @@ static Value *mergeDistinctValues(QualType Type, Value , Value *MergedVal = nullptr; if (auto *RecordVal1 = dyn_cast()) { -[[maybe_unused]] auto *RecordVal2 = cast(); - -// Values to be merged are always associated with the same location in

[PATCH] D158804: [Clang] Fix crash in Parser::ParseDirectDeclarator by adding check that token is not an annotation token

2023-09-06 Thread Nathan Ridge via Phabricator via cfe-commits
nridge accepted this revision. nridge added a subscriber: rjmccall. nridge added a comment. This revision is now accepted and ready to land. I'm not well versed in the parser code, but the fix clearly avoids the assertion in `getIdentifierInfo()`, and both @aaron.ballman and @rjmccall indicated

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

2023-09-06 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the help in resolving the resource dir issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-06 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)

2023-09-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/65457: m_x86_Features_Group always turn `mno-` into `-target-feature-`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`. >From be58af68f221bb65788e74f8cfe4952c1038ae70 Mon

[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)

2023-09-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang review_requested https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)

2023-09-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang review_requested https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

2023-09-06 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo created this revision. Herald added subscribers: kadircet, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group yo m_Group. NFCI (PR #65457)

2023-09-06 Thread via cfe-commits
https://github.com/XinWang10 approved this pull request. LGTM, could work on my side. https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c5fabac - [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group to m_Group. NFCI (#65457)

2023-09-06 Thread via cfe-commits
Author: Phoebe Wang Date: 2023-09-06T18:08:29+08:00 New Revision: c5fabaccef5a8566bd65a6f242be65d75096bea8 URL: https://github.com/llvm/llvm-project/commit/c5fabaccef5a8566bd65a6f242be65d75096bea8 DIFF: https://github.com/llvm/llvm-project/commit/c5fabaccef5a8566bd65a6f242be65d75096bea8.diff

[clang] [X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group to m_Group. NFCI (PR #65457)

2023-09-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/65457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/65462: None >From 20aa3e3225f6ea48df00ea05bcbfcc5cc2278af5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 8 Aug 2023 14:11:33 +0200 Subject: [PATCH 1/2] [clang][CFG]

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] (PR #65462)

2023-09-06 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] Consider cleanup functions for thread safety analysis (PR #65462)

2023-09-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/65462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158259: [clang][RISCV] Support operators for RVV sizeless vector types

2023-09-06 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan marked an inline comment as done. jacquesguan added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158259/new/ https://reviews.llvm.org/D158259 ___ cfe-commits mailing list

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65466: This follows the RISC-V work done in 4b40ced4e5ba10b841516b3970e7699ba8ded572. This uses AArch64's target parser instead. We just list the names, without the "+" on them, which matches RISC-V's format.

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AArch64] Add --print-supported-extensions support (PR #65466)

2023-09-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] d71adeb - [include-cleaner] Map the 4-argument move overload to the algorithm header.

2023-09-06 Thread Viktoriia Bakalova via cfe-commits
Author: Viktoriia Bakalova Date: 2023-09-06T11:38:56Z New Revision: d71adebb9fb875a5fd23acdbe0cf0799092fa4ca URL: https://github.com/llvm/llvm-project/commit/d71adebb9fb875a5fd23acdbe0cf0799092fa4ca DIFF: https://github.com/llvm/llvm-project/commit/d71adebb9fb875a5fd23acdbe0cf0799092fa4ca.diff

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

2023-09-06 Thread Viktoriia Bakalova via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header. (authored by VitaNuo). Repository: rG LLVM Github

[clang-tools-extra] [clangd][unittests] Limit paralelism for clangd unittests (PR #65444)

2023-09-06 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/65444: From 627082183a34c5b497db1c0eb775b8c3d0bbf06b Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Tue, 5 Sep 2023 19:19:47 +0200 Subject: [PATCH] [clangd][unittests] Limit paralelism for clangd unittests We

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

2023-09-06 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet added a comment. To generate only the necessary diagnostic information, we need to know the evaluation result of the entire constraint expression. So, the ideal way I can think of would be first to evaluate the nodes and, simultaneously, cache the results using `DenseMap` or

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

2023-09-06 Thread Thomas Preud'homme via cfe-commits
@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

2023-09-06 Thread Thomas Preud'homme via cfe-commits
@@ -34,29 +35,22 @@ } -def get_line2func_list(args, clang_args): +def get_line2func_list(clang_cmd: Command): ret = collections.defaultdict(list) # Use clang's JSON AST dump to get the mangled name -json_dump_args = [args.clang] + clang_args + ["-fsyntax-only",

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

2023-09-06 Thread Thomas Preud'homme via cfe-commits
@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] [update_cc_test_checks] Use lit's shell to run commands (PR #65333)

2023-09-06 Thread Thomas Preud'homme via cfe-commits
@@ -306,52 +276,79 @@ def main(): run_list = [] line2func_list = collections.defaultdict(list) -subs = { -"%s": ti.path, -"%t": tempfile.NamedTemporaryFile().name, -"%S": os.path.dirname(ti.path), -} +

[clang] 6258912 - [clangd][clang-tidy] Add missing symbols to the symbol map.

2023-09-06 Thread Viktoriia Bakalova via cfe-commits
Author: Viktoriia Bakalova Date: 2023-09-06T13:42:12Z New Revision: 6258912880876edd44944e130aef01b33480168b URL: https://github.com/llvm/llvm-project/commit/6258912880876edd44944e130aef01b33480168b DIFF: https://github.com/llvm/llvm-project/commit/6258912880876edd44944e130aef01b33480168b.diff

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

2023-09-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157810/new/

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

2023-09-06 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159463

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

2023-09-06 Thread Guillot Tony via Phabricator via cfe-commits
to268 updated this revision to Diff 556008. to268 added a comment. This updates fixes the `_Atomic auto` diagnostic, the previous diagnostic was confusing since it was referencing a C++ feature (std::is_trivially_copyable). I have a few diagnostic issues remaining, some parts need to take place

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

2023-09-06 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. @aaronpuchert Do you think warning on assignment of function pointers with mismatched attributes is would be a viable way forward? This is what https://github.com/elmarco/clang/commit/bac94282a5c8e3b0410ee8c0522fbdb872ade00c tries to implement IIUC. CHANGES SINCE

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

2023-09-06 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93d2d37e709: [clang][Interp] Handle SourceLocExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b93d2d3 - [clang][Interp] Handle SourceLocExprs

2023-09-06 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-06T14:45:49+02:00 New Revision: b93d2d37e70942c951055019428708982b4e8d72 URL: https://github.com/llvm/llvm-project/commit/b93d2d37e70942c951055019428708982b4e8d72 DIFF: https://github.com/llvm/llvm-project/commit/b93d2d37e70942c951055019428708982b4e8d72.diff

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

2023-09-06 Thread Nathan Gauër via Phabricator via cfe-commits
Keenuts added a comment. In D155978#4639094 , @mpaszkowski wrote: > @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I > think that this solution despite being a "hack" seems to be the most > straightforward. Eventual

[clang-tools-extra] 73b2c86 - [include-cleaner] Weaken signal for boosting preferred headers

2023-09-06 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-09-06T14:46:33+02:00 New Revision: 73b2c86d95dc510d6972aaa4b44688aebebd89f1 URL: https://github.com/llvm/llvm-project/commit/73b2c86d95dc510d6972aaa4b44688aebebd89f1 DIFF:

[clang] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/4] Add flags to dump IR to a file before and after LLVM passes

[clang-tools-extra] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-06 Thread Nuri Amari via cfe-commits
https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/65179: >From 5d395c85b84e5a554df4b092014d38123e666c6c Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Tue, 29 Aug 2023 10:10:57 -0700 Subject: [PATCH 1/4] Add flags to dump IR to a file before and after LLVM passes

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note describing the changes when you land them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread Aaron Jarmusch via cfe-commits
https://github.com/ajarmusch labeled https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread Aaron Jarmusch via cfe-commits
https://github.com/ajarmusch labeled https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread Aaron Jarmusch via cfe-commits
https://github.com/ajarmusch review_requested https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread Aaron Jarmusch via cfe-commits
https://github.com/ajarmusch created https://github.com/llvm/llvm-project/pull/65483: Fix for an issue where clang was not adding the address space according to the data layout, instead was using the default which resulted in a crash at times. The fix includes changes to the cases of

[clang] [Clang][OpenMP] Clang adding the addrSpace according to DataLayout fix (PR #65483)

2023-09-06 Thread Aaron Jarmusch via cfe-commits
https://github.com/ajarmusch review_requested https://github.com/llvm/llvm-project/pull/65483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151834: Include math-errno with fast-math

2023-09-06 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D151834#4639536 , @aaron.ballman wrote: > LGTM, but please add a release note describing the changes when you land them. @aaron.ballman thanks for the reviews. Added some note in the RN, let me know if that is enough.

  1   2   3   4   5   >