[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-15 Thread via cfe-commits
https://github.com/eywdck2l closed https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae90f68 - [clang-format] Disable string breaking in JS for now (#66372)

2023-09-15 Thread via cfe-commits
Author: sstwcw Date: 2023-09-15T12:36:09Z New Revision: ae90f689a59fa0ac0b29ca49743757842ba32bf4 URL: https://github.com/llvm/llvm-project/commit/ae90f689a59fa0ac0b29ca49743757842ba32bf4 DIFF: https://github.com/llvm/llvm-project/commit/ae90f689a59fa0ac0b29ca49743757842ba32bf4.diff LOG:

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-15 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/66372 >From a736d84df61e3e7c1a4c8b22c7cd1e7524499d64 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Thu, 14 Sep 2023 13:04:56 + Subject: [PATCH 1/2] [clang-format] Disable string breaking in JS for now See the

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()

2023-09-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 556849. Hahnfeld retitled this revision from "[Lex] Handle repl_input_end in Preprocessor::LexAll()" to "[Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()". Hahnfeld added a comment. Rebase on D158413

[PATCH] D158414: [LexerTest] Use LexTokensUntilEOF() in StringifyArgs

2023-09-15 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld updated this revision to Diff 556848. Hahnfeld retitled this revision from "[LexerTest] Use LexAll() in StringifyArgs" to "[LexerTest] Use LexTokensUntilEOF() in StringifyArgs". Hahnfeld edited the summary of this revision. CHANGES SINCE LAST ACTION

[clang] [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (PR #66359)

2023-09-15 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/66359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0069004 - [clang][dataflow] Add a test for context-sensitive analysis on a self-referential class. (#66359)

2023-09-15 Thread via cfe-commits
Author: martinboehme Date: 2023-09-15T14:31:10+02:00 New Revision: 0069004856dd216ffed48a860a38b986dfe3e871 URL: https://github.com/llvm/llvm-project/commit/0069004856dd216ffed48a860a38b986dfe3e871 DIFF: https://github.com/llvm/llvm-project/commit/0069004856dd216ffed48a860a38b986dfe3e871.diff

[clang] [clang][AST] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread Ding Fei via cfe-commits
danix800 wrote: LGTM! If no further comment I'll merge this in a day or two. https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Parse formulas from text (PR #66424)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/66424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [dataflow] Parse formulas from text (PR #66424)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
@@ -87,6 +87,9 @@ class alignas(const Formula *) Formula { ArrayRef Operands, unsigned Value = 0); + // Parse Formulas using Arena rather than caling this function directly. ymand wrote: nit: Maybe prefix

[clang] [dataflow] Parse formulas from text (PR #66424)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/66424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-transformer] Allow stencils to read from system headers. (PR #66480)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
@@ -230,7 +230,7 @@ class SelectorStencil : public StencilInterface { // message. If it's valid, then something else is the cause and we just // return the generic failure message. if (auto Err = - tooling::validateEditRange(*RawRange,

[clang] [clang-transformer] Allow stencils to read from system headers. (PR #66480)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
@@ -91,6 +91,10 @@ StringRef getExtendedText(const T , tok::TokenKind Next, llvm::Error validateEditRange(const CharSourceRange , const SourceManager ); +/// Determines whether \p Range is one that can be read from. +llvm::Error

[clang] [clang-transformer] Allow stencils to read from system headers. (PR #66480)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-transformer] Allow stencils to read from system headers. (PR #66480)

2023-09-15 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/66480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-09-15 Thread via cfe-commits
https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-09-15 Thread via cfe-commits
@@ -2129,7 +2129,7 @@ Decl *TemplateDeclInstantiator::VisitFunctionDecl( Function = CXXDeductionGuideDecl::Create( SemaRef.Context, DC, D->getInnerLocStart(), InstantiatedExplicitSpecifier, NameInfo, T, TInfo, -D->getSourceRange().getEnd(),

[clang] [clang][Interp] Handle AttributedStmts (PR #66495)

2023-09-15 Thread via cfe-commits
@@ -628,6 +630,12 @@ bool ByteCodeStmtGen::visitAsmStmt(const AsmStmt *S) { return this->emitInvalid(S); } +template +bool ByteCodeStmtGen::visitAttributedStmt(const AttributedStmt *S) { + // Ignore all attributes. cor3ntin wrote: We can add a fix me

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-09-15 Thread via cfe-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 >From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH] Choose the correct deduction guide If there are two guides, one of them

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66498)

2023-09-15 Thread Ding Fei via cfe-commits
https://github.com/danix800 edited https://github.com/llvm/llvm-project/pull/66498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66498)

2023-09-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Changes NonLoc symbolic SVal to Loc casts are not supported except for nonloc::ConcreteInt. This change simplifies the source SVals so that the more casts can go through nonloc::ConcreteInt->loc::ConcreteInt path.

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Ding Fei via cfe-commits
danix800 wrote: Fixed and resubmited #66498 https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66498)

2023-09-15 Thread Ding Fei via cfe-commits
https://github.com/danix800 created https://github.com/llvm/llvm-project/pull/66498 NonLoc symbolic SVal to Loc casts are not supported except for nonloc::ConcreteInt. This change simplifies the source SVals so that the more casts can go through nonloc::ConcreteInt->loc::ConcreteInt path.

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
ktf wrote: @s-barannikov, AFAICT, that would not work because the overwrite is not unconditional, but it will actually check for default initialised content. Basically the current mechanics relies on default initialisation rather than being "uninitialised". This for sure does not work with

[clang] [clang][Interp] Handle AttributedStmts (PR #66495)

2023-09-15 Thread Aaron Ballman via cfe-commits
@@ -628,6 +630,12 @@ bool ByteCodeStmtGen::visitAsmStmt(const AsmStmt *S) { return this->emitInvalid(S); } +template +bool ByteCodeStmtGen::visitAttributedStmt(const AttributedStmt *S) { + // Ignore all attributes. AaronBallman wrote: Is this what we

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-15 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. Nice bugfix; I have only one tangential remark. https://github.com/llvm/llvm-project/pull/66493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-15 Thread via cfe-commits
@@ -398,7 +400,7 @@ void StackAddrEscapeChecker::checkEndFunction(const ReturnStmt *RS, }(Referrer->getMemorySpace()); // This cast supposed to succeed. DonatNagyE wrote: Perhaps explain why will the cast succeed (or, alternatively, just remove this

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-15 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/66493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Pass full path of source TD file to gen_rst_from_td. [NFC] (PR #66497)

2023-09-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This change is needed to be able to refer to TD files that are not stored in ${CMAKE_CURRENT_SOURCE_DIR}. -- Full diff: https://github.com/llvm/llvm-project/pull/66497.diff 1 Files Affected: - (modified)

[clang] [clang][docs] Pass full path of source TD file to gen_rst_from_td. [NFC] (PR #66497)

2023-09-15 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli created https://github.com/llvm/llvm-project/pull/66497 This change is needed to be able to refer to TD files that are not stored in ${CMAKE_CURRENT_SOURCE_DIR}. >From 1887649a491b353f4e6a9a318fa2b150db268868 Mon Sep 17 00:00:00 2001 From: Francesco Petrogalli

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-15 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > I'll add a test. immediate contexts are recursive, constant evaluated > contexts are not, i don't think there is a case where you would get an > additional evaluation context that is not for a full expression, and if you > have a full expression you do expect the immediate

[clang] 73371fa - [clang][Interp][NFC] Remove unused includes

2023-09-15 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-15T13:37:35+02:00 New Revision: 73371faf05887fbe84916456b7c200b07978e7b5 URL: https://github.com/llvm/llvm-project/commit/73371faf05887fbe84916456b7c200b07978e7b5 DIFF: https://github.com/llvm/llvm-project/commit/73371faf05887fbe84916456b7c200b07978e7b5.diff

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D147844#4641735 , @ldionne wrote: > Ping. What's missing to land this? Folks have raised enough concerns about chattiness

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: > Why don't just turn SLocEntry into a POD (if it is not yet already) and use > SmallVector::resize_for_overwrite? That way the vector will not be > initialized and the OS will only allocate physical memory on the first access > to a page. Never mind, it isn't "just", the

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Since SM_90 CUDA supports specifying additional argument to the launch_bounds attribute: maxBlocksPerCluster, to express the maximum number of CTAs that can be part of the cluster. See:

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

2023-09-15 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda created https://github.com/llvm/llvm-project/pull/66496 Since SM_90 CUDA supports specifying additional argument to the launch_bounds attribute: maxBlocksPerCluster, to express the maximum number of CTAs that can be part of the cluster. See:

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Balazs Benics via cfe-commits
steakhal wrote: I thought "Mergeing" would wait and confirm if the checks pass, and only merge it if they succeed. Apparently, it's not the case here xD The tests now break even on x86 linux. Could you please have a look? @danix800 https://github.com/llvm/llvm-project/pull/66463

[clang] 7af24c7 - Disable writing an output file to the source directory in Driver test

2023-09-15 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-09-15T13:19:13+02:00 New Revision: 7af24c765d0255e6fa4a9f564e0d3699e0cfa107 URL: https://github.com/llvm/llvm-project/commit/7af24c765d0255e6fa4a9f564e0d3699e0cfa107 DIFF:

[PATCH] D156511: [clang][Interp] Diagnose more unkonwn DeclRefExprs

2023-09-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder closed this revision. tbaeder added a comment. Looks like I squashed this into https://reviews.llvm.org/D156509 for some reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156511/new/ https://reviews.llvm.org/D156511

[clang] 03693d5 - Revert "[analyzer] Simplify SVal for simple NonLoc->Loc casts (#66463)"

2023-09-15 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-09-15T13:18:34+02:00 New Revision: 03693d5b40f187921ead5a502fa3cf72ce30fea4 URL: https://github.com/llvm/llvm-project/commit/03693d5b40f187921ead5a502fa3cf72ce30fea4 DIFF: https://github.com/llvm/llvm-project/commit/03693d5b40f187921ead5a502fa3cf72ce30fea4.diff

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

2023-09-15 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23c39f9a9e14: [clang][Interp] Diagnose unknown parameter values (authored by tbaeder). Changed prior to commit:

[clang] 23c39f9 - [clang][Interp] Diagnose unknown parameter values

2023-09-15 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-15T13:10:19+02:00 New Revision: 23c39f9a9e14caae7b0113e306bf2faf1e4f88f3 URL: https://github.com/llvm/llvm-project/commit/23c39f9a9e14caae7b0113e306bf2faf1e4f88f3 DIFF: https://github.com/llvm/llvm-project/commit/23c39f9a9e14caae7b0113e306bf2faf1e4f88f3.diff

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-09-15 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. @shafik @aaron.ballman does any of you want to commandeer this diff? seems simple enough of a change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150075/new/ https://reviews.llvm.org/D150075

[PATCH] D154893: [Clang] Fix some triviality computations

2023-09-15 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. In D154893#4646405 , @cor3ntin wrote: > @royjacobson ^ I did not have a lot of time for Clang the last few months unfortunately. I might take a look at this again next month when I'll have a bit more time. Repository:

[clang] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-15 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: > Could I land it now? Yes https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

2023-09-15 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG177f9ab2fbd8: [clang][Interp] Check pointer inc/dec ops for initialization (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[clang] 177f9ab - [clang][Interp] Check pointer inc/dec ops for initialization

2023-09-15 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-15T13:04:04+02:00 New Revision: 177f9ab2fbd868fb9cc7d5504e56a241e8e79329 URL: https://github.com/llvm/llvm-project/commit/177f9ab2fbd868fb9cc7d5504e56a241e8e79329 DIFF: https://github.com/llvm/llvm-project/commit/177f9ab2fbd868fb9cc7d5504e56a241e8e79329.diff

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: Why don't just turn SLocEntry into a POD and use SmallVector::resize_for_overwrite? That way the vector will not be initialized and the OS will only allocate physical memory on the first access to a page. https://github.com/llvm/llvm-project/pull/66430

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ebf3dd - [analyzer] Simplify SVal for simple NonLoc->Loc casts (#66463)

2023-09-15 Thread via cfe-commits
Author: Ding Fei Date: 2023-09-15T13:00:32+02:00 New Revision: 3ebf3dd30da219f9f9aee12f42d45d18d55e7580 URL: https://github.com/llvm/llvm-project/commit/3ebf3dd30da219f9f9aee12f42d45d18d55e7580 DIFF: https://github.com/llvm/llvm-project/commit/3ebf3dd30da219f9f9aee12f42d45d18d55e7580.diff

[clang] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-15 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > I run this check on two bigger projects, didn't found anything (I was > expecting it wont). > > So at least in case of false-positives it looks fine. I also run in some project and find nothing. Could I land it now? https://github.com/llvm/llvm-project/pull/66055

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal resolved https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-15 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/65844 >From db98faff4cfc86657ee8f47dac0e1e2a441049b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 9 Sep 2023

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal resolved https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal resolved https://github.com/llvm/llvm-project/pull/66463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle AttributedStmts (PR #66495)

2023-09-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Just ignore the attributes. -- Full diff: https://github.com/llvm/llvm-project/pull/66495.diff 3 Files Affected: - (modified) clang/lib/AST/Interp/ByteCodeStmtGen.cpp (+8) - (modified) clang/lib/AST/Interp/ByteCodeStmtGen.h

[clang] [clang][Interp] Handle AttributedStmts (PR #66495)

2023-09-15 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/66495 Just ignore the attributes. >From c1c216058408cf54771bfdac71b0bcf28110f292 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 12:55:04 +0200 Subject: [PATCH] [clang][Interp]

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Basically, the issue was that we should have unwrap the base region before we special handle temp object regions. Fixes https://github.com/llvm/llvm-project/issues/66221 I also decided to add some extra range information to

[clang] [clang][AST] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi resolved https://github.com/llvm/llvm-project/pull/66041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix StackAddrEscapeChecker crash on temporary object fields (PR #66493)

2023-09-15 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/66493 Basically, the issue was that we should have unwrap the base region before we special handle temp object regions. Fixes https://github.com/llvm/llvm-project/issues/66221 I also decided to add some extra range

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041 >From a1635d87e4b56b501403f1add333c97b96b30a0f Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang][AST] fix lack comparison of declRefExpr in

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Ding Fei via cfe-commits
https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/66463 >From d48b57387e3dc1c2f3fdeae00fe1596b3466638d Mon Sep 17 00:00:00 2001 From: dingfei Date: Fri, 15 Sep 2023 14:01:26 +0800 Subject: [PATCH] [analyzer] Simplify SVal for simple NonLoc->Loc casts NonLoc

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Ding Fei via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=debug.ExprInspection \ +// RUN: -analyzer-config eagerly-assume=false \ +// RUN: -verify + +void clang_analyzer_eval(int); + +void

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Ding Fei via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=debug.ExprInspection \ +// RUN: -analyzer-config eagerly-assume=false \ +// RUN: -verify + +void clang_analyzer_eval(int); + +void

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041 >From f74271d018d413832290e9d021ad6f25209a35fd Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang][AST] fix lack comparison of declRefExpr in

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-15 Thread Simon Pilgrim via cfe-commits
@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget , return DAG.getMemcpy( Chain, DL, DstPtr, SrcPtr, DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL), - Align(Subtarget.isTarget64BitLP64() ? 8 : 4),

[clang] [analyzer] Simplify SVal for simple NonLoc->Loc casts (PR #66463)

2023-09-15 Thread Ding Fei via cfe-commits
@@ -264,7 +264,8 @@ ProgramStateRef ExprEngine::handleLValueBitCast( } // Delegate to SValBuilder to process. SVal OrigV = state->getSVal(Ex, LCtx); - SVal V = svalBuilder.evalCast(OrigV, T, ExTy); + SVal SimplifiedOrigV = svalBuilder.simplifySVal(state, OrigV); +

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/12] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > @vgvassilev done. > > @ChuanqiXu9 I think I addressed all your additional comments and updated the > PR. Please let me know if you have further ones or if you want me to squash > the commits into one. I think we need to add some test on the clang modules side. I am

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread Ding Fei via cfe-commits
@@ -2320,5 +2320,14 @@ TEST_F(StructuralEquivalenceStmtTest, UnresolvedLookup) { EXPECT_TRUE(testStructuralMatch(t)); } +TEST_F(StructuralEquivalenceStmtTest, DeclRefENoEq) { danix800 wrote: ```suggestion TEST_F(StructuralEquivalenceStmtTest, DeclRefExpr)

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
ktf wrote: @vgvassilev done. @ChuanqiXu9 I think I addressed all your additional comments and updated the PR. Please let me know if you have further ones or if you want me to squash the commits into one. https://github.com/llvm/llvm-project/pull/66430

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf edited https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread Ding Fei via cfe-commits
@@ -218,6 +218,8 @@ Bug Fixes in This Version (`#65156 `_) - Clang no longer considers the loss of ``__unaligned`` qualifier from objects as an invalid conversion during method function overload resolution. +- Fix lack of

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-09-15 Thread Arthur Laurent via cfe-commits
Arthapz wrote: Oh nice going to try this :) https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/11] Introduce PagedVector

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-09-15 Thread via cfe-commits
https://github.com/HoBoIs created https://github.com/llvm/llvm-project/pull/66487 If there is 2 guides one of them generated from a non-templated constructor and one of them from a templated constructor the standard gives priority to the first. Clang detected ambiguity before, now the correct

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf edited https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From b952f0577dfe8112f394bd5392212f843c0cc86e Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/10] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > @ChuanqiXu9 I have added a simple unit test, which has 100% code coverage as > far as I can tell and covers the usecase the container will be used for. > > @nikic This is in the context of improving the memory used when loading > modules, in particular my usecase is the

[clang] [clang-tidy]add new check `bugprone-compare-pointer-to-member-virtual-function` (PR #66055)

2023-09-15 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: I run this check on two bigger projects, didn't found anything (I was expecting it wont). So at least in case of false-positives it looks fine. https://github.com/llvm/llvm-project/pull/66055 ___ cfe-commits mailing list

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041 >From 011c3997ac72918b23db511b94184e9fc5351a54 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in

[clang-tools-extra] [include-cleaner] Respect the UsingShadowDecl when find headers for ambiguous std symbols. (PR #66485)

2023-09-15 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/66485 In libcpp, the `std::remove(const char*)` is a using decl in std namespace `using ::remove`, which was not handled correctly in `headerForAmbiguousStdSymbol` >From ffd109a7b4273d6a1dc5810b64039a110a4147c9 Mon

[clang] [clang] fix lack comparison of declRefExpr in ASTStructuralEquivalence (PR #66041)

2023-09-15 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/66041 >From c6022432afb24b4788e6d5065f583b29a1a5277a Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Tue, 12 Sep 2023 10:51:35 +0800 Subject: [PATCH] [clang] fix lack comparison of declRefExpr in

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-09-15 Thread Gábor Spaits via cfe-commits
https://github.com/spaits ready_for_review https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
brad0 wrote: Because of where the chunk is being added in the Solaris ToolChain (and what I had in my tree for *BSD's) it is checking for the ```nostdlib, nodefaultlibs, or r``` flags, where as the Gnu path does not. I just want to make sure the behavior is consistent.

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
brad0 wrote: One thing to add to this. I noticed the Gnu addition does not check for `nostdlib, nodefaultlibs, or r` flags like the C++ library chunk does. With the proposed diff and what I had initially being right under the C++ chunk in the Solaris and *BSD ToolChain they would be checking

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 deleted https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
@@ -4,6 +4,7 @@ ! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU ! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,DARWIN +! RUN: %flang -### -target

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-09-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 556838. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp clang/lib/Analysis/ThreadSafetyCommon.cpp

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-09-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,126 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,126 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-15 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,126 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

<    1   2   3   4   5   >