[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/66683 >From 5b4748e3ae06a5b90ecb2c84b7df989a94733175 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 18 Sep 2023 11:38:12 -0700 Subject: [PATCH 1/2] In ExprRequirement building, treat OverloadExpr as

[clang] 256a0b2 - [clang] Correct source locations for instantiations of function templates.

2023-09-18 Thread Tom Honermann via cfe-commits
Author: Tom Honermann Date: 2023-09-18T12:51:45-07:00 New Revision: 256a0b298c68b89688b80350b034daf2f7785b67 URL: https://github.com/llvm/llvm-project/commit/256a0b298c68b89688b80350b034daf2f7785b67 DIFF: https://github.com/llvm/llvm-project/commit/256a0b298c68b89688b80350b034daf2f7785b67.diff

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

2023-09-18 Thread Tom Honermann via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG256a0b298c68: [clang] Correct source locations for instantiations of function templates. (authored by tahonermann). Repository: rG LLVM Github

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 1/5] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang] 4898c33 - [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (#65887)

2023-09-18 Thread via cfe-commits
Author: vabridgers Date: 2023-09-18T15:18:33-05:00 New Revision: 4898c33527f90b067f353a115442a9a702319fce URL: https://github.com/llvm/llvm-project/commit/4898c33527f90b067f353a115442a9a702319fce DIFF: https://github.com/llvm/llvm-project/commit/4898c33527f90b067f353a115442a9a702319fce.diff

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Artem Belevich via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim closed https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][AIX] Fix up TOC register if unw_getcontext is called from a different module (PR #66549)

2023-09-18 Thread via cfe-commits
https://github.com/stephenpeckham commented: No further comments https://github.com/llvm/llvm-project/pull/66549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Changes Enable -rpath, -shared, and -static for the flang frontend. This brings it in line with clang. Fixes issue #65546. --- Full diff: https://github.com/llvm/llvm-project/pull/66702.diff 2 Files Affected: - (modified)

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-18 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu created https://github.com/llvm/llvm-project/pull/66702 Enable -rpath, -shared, and -static for the flang frontend. This brings it in line with clang. Fixes issue #65546. >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-18 Thread Alexander Smarus via cfe-commits
https://github.com/lxbndr updated https://github.com/llvm/llvm-project/pull/65215 >From c97d9a28ef8cdb232670a960a46bc30b269983f7 Mon Sep 17 00:00:00 2001 From: Alexander Smarus Date: Tue, 19 Sep 2023 00:34:54 +0300 Subject: [PATCH] Workaround for MSVC ARM64 build performance regression ---

[PATCH] D158476: [driver] Search for compatible Android runtime directories

2023-09-18 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama accepted this revision. pirama added a comment. LGTM from the Android platform/NDK side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___ cfe-commits

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

2023-09-18 Thread Erich Keane via cfe-commits
erichkeane wrote: Even after seeing your explaination, I don't find the images particularly useful or helpful. They are convoluted and confusing, and I don't think they add value here. As far as being checked in: First, Git does really poorly with binary files. Second, if we were doing

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-09-18 Thread Félix-Antoine Constantin via Phabricator via cfe-commits
felix642 added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159436/new/ https://reviews.llvm.org/D159436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] cacdb90 - [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (#66699)

2023-09-18 Thread via cfe-commits
Author: cor3ntin Date: 2023-09-19T00:24:43+02:00 New Revision: cacdb90bd7f8352d62e8e89a6309902c6e523293 URL: https://github.com/llvm/llvm-project/commit/cacdb90bd7f8352d62e8e89a6309902c6e523293 DIFF: https://github.com/llvm/llvm-project/commit/cacdb90bd7f8352d62e8e89a6309902c6e523293.diff

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/66699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

2023-09-18 Thread Scott McPeak via cfe-commits
smcpeak wrote: Is there a different tool and/or style of diagram that would be preferable? https://github.com/llvm/llvm-project/pull/66436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. (Sorry for the wall of text) In D74094#4646297 , @tellenbach wrote: > No real comment on the issue itself but on the example as a former Eigen > maintainer (sorry for the noise if that's all obvious for you): Woah! Deus

[clang] [clang][CodeGen] Emit annotations for function declarations. (PR #66716)

2023-09-18 Thread Brendan Dahl via cfe-commits
brendandahl wrote: This is relanding the patch from [here](https://reviews.llvm.org/D156172). It fixes the [backout failure](https://reviews.llvm.org/rG88b7e06dcf9723d0869b0c6bee030b4140e4366d) and adds a test for it. https://github.com/llvm/llvm-project/pull/66716

[clang] 915ebb0 - [driver] Address missed feedback from https://reviews.llvm.org/D158476

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T16:28:04-07:00 New Revision: 915ebb07dfc53486eccf0dc09b6411929a463e98 URL: https://github.com/llvm/llvm-project/commit/915ebb07dfc53486eccf0dc09b6411929a463e98 DIFF: https://github.com/llvm/llvm-project/commit/915ebb07dfc53486eccf0dc09b6411929a463e98.diff

[PATCH] D158476: [driver] Search for compatible Android runtime directories

2023-09-18 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D158476#4647652 , @MaskRay wrote: > nits Sorry, this came in right as I committed the diff. I pushed rG915ebb07dfc53486eccf0dc09b6411929a463e98 to

[clang] [clang] Fix null dereference on return in lambda attribute statement expr (PR #66643)

2023-09-18 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik updated https://github.com/llvm/llvm-project/pull/66643 >From 4545c9c691a7affcab6cfe4e1b9b2a7715ab3f8b Mon Sep 17 00:00:00 2001 From: Piotr Fusik Date: Mon, 18 Sep 2023 19:56:10 +0200 Subject: [PATCH] [clang] Fix null dereference on return in lambda attribute

[clang] Support target names with dots in more utilities (PR #65812)

2023-09-18 Thread via cfe-commits
https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812 >From 5f5e57a5c01088e7f0b9276ed02dd436a3f9cc0a Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH 1/2] Support: hoist lld's executable name code to Path Instead of

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-09-18 Thread Krystian Stasiowski via cfe-commits
@@ -650,17 +642,16 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) { DependentFunctionTemplateSpecializationInfo * DFTSInfo = D->getDependentSpecializationInfo(); -// Templates. -Record.push_back(DFTSInfo->getNumTemplates()); -for (int i=0, e =

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I remember that there is a defect that we may place the GRO on the coroutine frame. And my instinct reaction is that would this patch be covered by forcing GRO to not live on the coroutine frame? https://github.com/llvm/llvm-project/pull/66706

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

2023-09-18 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat updated this revision to Diff 556995. 4vtomat added a comment. Add VRM2, VRM4 and VRM8 to CalleeSaved register list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154576/new/ https://reviews.llvm.org/D154576 Files:

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-09-18 Thread Ian Anderson via Phabricator via cfe-commits
iana added a comment. In D159064#4647709 , @vsapsai wrote: > Still going through the patch and through the discussion. But wanted to ask > if there are any complications in reverting this change? For libc++ we've > discussed that we don't really know

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

2023-09-18 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/66330 >From 8eb805beb037ba824fdf01dd8528b797a80de7ad Mon Sep 17 00:00:00 2001 From: 4vtomat Date: Wed, 13 Sep 2023 22:59:30 -0700 Subject: [PATCH 1/3] [RISCV] Install sifive_vector.h to riscv-resource-headers ---

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

2023-09-18 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat resolved https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

2023-09-18 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat edited https://github.com/llvm/llvm-project/pull/66330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-18 Thread Tobias Hieta via cfe-commits
https://github.com/tru approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

2023-09-18 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVCallingConv.td:52 // Same as CSR_Interrupt, but including all 64-bit FP registers. def CSR_XLEN_F64_Interrupt: CalleeSavedRegs<(add CSR_Interrupt, (sequence

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar commented: Thanks for all the fixes, this is looking very good. Did another pass and left some local suggestions. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -1625,6 +1625,38 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-18 Thread Ian Anderson via Phabricator via cfe-commits
iana marked an inline comment as done. iana added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:176 COMPATIBLE_LANGOPT(CPlusPlusModules, 1, 0, "C++ modules syntax") +LANGOPT(BuiltinHeadersInSystemModules, 1, 0, "builtin headers belong to system

[clang] [RISCV] Install sifive_vector.h to riscv-resource-headers (PR #66330)

2023-09-18 Thread Brandon Wu via cfe-commits
@@ -623,6 +623,11 @@ install( EXCLUDE_FROM_ALL COMPONENT riscv-resource-headers) +install( 4vtomat wrote: Yes, we are missing from add_header_target("riscv-resource-headers" "${riscv_files};${riscv_generated_files}"). I think we can just put

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

2023-09-18 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Except few nits in documentation looks fine. Probably one day in future we can add same for bools. Make sure that documentation of impacted checks is correct, so it says that argument is

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Artem Belevich via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes When dealing with short-circuiting coroutines (e.g. `expected`), the deferred calls that resolve the `get_return_object` are currently being emitted *after* we delete the coroutine frame. This was caught by ASAN when using

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-18 Thread Alexander Smarus via cfe-commits
lxbndr wrote: A short summary of changes: - added link to the issue - narrowed checks to aim cl.exe only (clang-cl.exe doesn't need this) - changed approach a bit. Now we're looking for /O2 and /O1 flags in the general flag set for the current configuration. Last effective found flag is

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Emit annotations for function declarations. (PR #66716)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Previously, annotations were only emitted for function definitions. With this change annotations are also emitted for declarations. Also, emitting function annotations is now deferred until the end so that the most up to date declaration

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From e99bda447b2de2d356539028db7503bdc2e93273 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH] Introduce PagedVector class The

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Emit annotations for function declarations. (PR #66716)

2023-09-18 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl created https://github.com/llvm/llvm-project/pull/66716 Previously, annotations were only emitted for function definitions. With this change annotations are also emitted for declarations. Also, emitting function annotations is now deferred until the end so that

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

2023-09-18 Thread Scott McPeak via cfe-commits
smcpeak wrote: And more generally, is there a preferred overall approach to documenting AST structures? My basic idea was to follow the example set by the [The AST Library](https://clang.llvm.org/docs/InternalsManual.html#the-ast-library) in the Internals Manual, but expanded to cover

[clang] [RISCV] Recognize veyron-v1 processor in clang driver. (PR #66703)

2023-09-18 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/66703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/66310 >From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Thu, 14 Sep 2023 09:17:39 +0800 Subject: [PATCH 1/2] [X86] Align 128/256 variants to use void * as 512 variants.

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf resolved https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
@@ -2979,7 +2979,7 @@ _mm256_xor_si256(__m256i __a, __m256i __b) ///A pointer to the 32-byte aligned memory containing the vector to load. /// \returns A 256-bit integer vector loaded from memory. static __inline__ __m256i __DEFAULT_FN_ATTRS256

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf resolved https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
@@ -645,7 +645,7 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS _mm_mul_epi32(__m128i __V1, /// \returns A 128-bit integer vector containing the data stored at the ///specified memory location. static __inline__ __m128i __DEFAULT_FN_ATTRS -_mm_stream_load_si128(__m128i

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf resolved https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
@@ -358,6 +358,12 @@ __m128i test_mm_stream_load_si128(__m128i const *a) { return _mm_stream_load_si128(a); } +__m128i test_mm_stream_load_si128_void(void const *a) { FreddyLeaf wrote: 3e463d3c41bb8e8391c62dd95910d009b4b39b7d

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf resolved https://github.com/llvm/llvm-project/pull/66310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Align 128/256 variants to use void * as 512 variants. (PR #66310)

2023-09-18 Thread Freddy Ye via cfe-commits
@@ -1223,6 +1223,12 @@ __m256i test_mm256_stream_load_si256(__m256i const *a) { return _mm256_stream_load_si256(a); } +__m256i test_mm256_stream_load_si256_const(void const *a) { FreddyLeaf wrote: 3e463d3 https://github.com/llvm/llvm-project/pull/66310

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Vassil Vassilev via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/66658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes GCC makes `-print-prog-name=ld` a special case that looks up the linker that will be used according to the `-fuse-ld=...` option state. This makes Clang follow suit. --- Full diff: https://github.com/llvm/llvm-project/pull/66698.diff 2

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/66699 `CXXCtorInitializer` may not refer to a FieldDecl because it might also denote another constructor call. Fixes #66324 >From b7438d2ea42fbdaabaea186fb0d185712fd48826 Mon Sep 17 00:00:00 2001 From: Corentin

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66699 >From c3267c587368eec3744640f895f9fc88d6c4414d Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 18 Sep 2023 23:06:11 +0200 Subject: [PATCH] [Clang] Fix a crash in the diagnostic emission of invalid

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Roland McGrath via cfe-commits
https://github.com/frobtech ready_for_review https://github.com/llvm/llvm-project/pull/66698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Recognize veyron-v1 processor in clang driver. (PR #66703)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim created https://github.com/llvm/llvm-project/pull/66703 Subsequent PRs will add the scheduling model and support for macro fusions. >From 414ecd5d2abe13767668a89045be2ef2f460509d Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Mon, 18 Sep 2023 17:01:40 -0400

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: I think the 2013 GCC feature adding -fuse-ld= made this change, which is, frankly, strange. I wish that we don't this... lld has several names. For windows-msvc target triples it is `lld-link`, and for wasm triples it is wasm-ld. https://github.com/llvm/llvm-project/pull/66698

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread Björn Pettersson via cfe-commits
bjope wrote: I reverted this patch since buildbots have been complaining for almost an hour. Here is the first failure mail I got: ``` The Buildbot has detected a failed build on builder clang-armv8-quick while building clang. Full details are available at:

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Giulio Eulisse via cfe-commits
@@ -7944,9 +7944,13 @@ void ASTReader::PrintStats() { std::fprintf(stderr, "*** AST File Statistics:\n"); unsigned NumTypesLoaded = - TypesLoaded.size() - llvm::count(TypesLoaded, QualType()); + TypesLoaded.size() - std::count(TypesLoaded.materialisedBegin(),

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-18 Thread Amy Huang via cfe-commits
@@ -10752,6 +10752,68 @@ Value *CodeGenFunction::EmitAArch64BuiltinExpr(unsigned BuiltinID, return Load; } + if (BuiltinID == AArch64::BI_CopyDoubleFromInt64 || + BuiltinID == AArch64::BI_CopyFloatFromInt32 || + BuiltinID == AArch64::BI_CopyInt32FromFloat ||

<    1   2   3   4   5   >