[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

zyn0217 wrote: Ping~ Looking for a review :) https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperands for inline asm (PR #67018)

https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/67018 >From 6f232ccd6dd273b9eecec7f583877a3a5a3696c3 Mon Sep 17 00:00:00 2001 From: eopXD Date: Thu, 21 Sep 2023 06:34:57 -0700 Subject: [PATCH] [Clang][RISCV] Handle RVV tuple types correctly as OutputOperand for

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/67331 Inside `writePrettyPrintFunction()`, we check if we need to emit the given argument: ```C++ if (!arg->isOptional() || arg->getIsOmitted() == "false") { FoundNonOptArg = true; continue; } ``` For the

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/66702 >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Mon, 18 Sep 2023 15:18:24 -0600 Subject: [PATCH 1/5] [flang][Driver] Support -rpath, -shared, and -static in

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

https://github.com/chapuni requested changes to this pull request. Hang on, would it expose build paths to installed headers? https://github.com/llvm/llvm-project/pull/65744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

sunshaoce wrote: I am not sure how to keep only the `llvm-project//Filename` path except by hard-coding. Or how to keep only the base file name? This could limit it to within 80 characters. https://github.com/llvm/llvm-project/pull/65744 ___

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf created https://github.com/llvm/llvm-project/pull/67349 Differential Revision: https://reviews.llvm.org/D159128 >From 0515d9d0901bc00b26787b1774ef003d5f0b8567 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH] [ClangRepl]

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

rengolin wrote: > @tru I'd ask @AaronBallman. My vote would be to reformat. Not as a requirement for this patch, I imagine? https://github.com/llvm/llvm-project/pull/65744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66846 >From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 19 Sep 2023 16:15:20 +0800 Subject: [PATCH 1/2] [clang-analysis]Fix false positive in mutation check when

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66846 >From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 19 Sep 2023 16:15:20 +0800 Subject: [PATCH 1/2] [clang-analysis]Fix false positive in mutation check when

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

AaronBallman wrote: > > @tru I'd ask @AaronBallman. My vote would be to reformat. > > Not as a requirement for this patch, I imagine? If we wanted to reformat the file as an NFC commit (before or after this patch), that would be fine. But let's please not reformat as part of this patch (that

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/ldionne resolved https://github.com/llvm/llvm-project/pull/66545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4650244 , @carlosgalvezp wrote: > @shafik @aaron.ballman @dblaikie > > Hello! Just wanted to check if there's any blockers for merging this patch? > We are now on Clang 18, i.e. 2 releases after the warning was

[clang] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

@@ -274,8 +288,8 @@ const Stmt *ExprMutationAnalyzer::findDirectMutation(const Expr *Exp) { const auto NonConstMethod = cxxMethodDecl(unless(isConst())); const auto AsNonConstThis = expr(anyOf( - cxxMemberCallExpr(callee(NonConstMethod), -

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

@@ -274,8 +288,8 @@ const Stmt *ExprMutationAnalyzer::findDirectMutation(const Expr *Exp) { const auto NonConstMethod = cxxMethodDecl(unless(isConst())); const auto AsNonConstThis = expr(anyOf( - cxxMemberCallExpr(callee(NonConstMethod), -

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

tarunprabhu wrote: > I think Windows does not work likely because `ld` is absent in PATH. You need > `-Bxxx/bin` to specify a directory that contains `ld`, but I don't remember > whether `ld.exe` is needed instead. I think what I saw on the buildkite was Link.exe, but I don't know if that is

[clang] Introduce paged vector (PR #66430)

https://github.com/kuhar approved this pull request. Thanks for all the changes, LGTM. Please wait for a second approval before submitting if you can. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list

[clang] [clang][Interp] Fix compiling undefined templated functions (PR #67232)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Remove declarations from `DeclToLoc` when their lifetime ends. (PR #67300)

https://github.com/Xazax-hun approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/67300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -314,5 +317,14 @@ def getStdFlag(cfg, std): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( +name="executor", +type=str, +default=f"{sys.executable} {Path(__file__).resolve().parent.parent.parent

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -314,5 +317,14 @@ def getStdFlag(cfg, std): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( +name="executor", +type=str, +default=f"{sys.executable} {Path(__file__).resolve().parent.parent.parent

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T ==

[clang] e8a74f2 - [Driver] Use addOptInFlag for some HIP options. NFC

Author: Fangrui Song Date: 2023-09-25T10:05:11-07:00 New Revision: e8a74f2334ed82a422f0779d1b5dbc9550e394fb URL: https://github.com/llvm/llvm-project/commit/e8a74f2334ed82a422f0779d1b5dbc9550e394fb DIFF: https://github.com/llvm/llvm-project/commit/e8a74f2334ed82a422f0779d1b5dbc9550e394fb.diff

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/docs/HIPSupport.rst:266 + +- ``-hipstdpar`` / ``--hipstdpar`` enables algorithm offload, which depending on + phase, has the following effects: Newer long options that don't use the common prefix like `-f` are

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

https://github.com/dkrupp created https://github.com/llvm/llvm-project/pull/67352 This commit renames alpha.security.taint.TaintPropagation checker to optin.security.taint.TaintPropagation. This checker was stabilized and improved by recent commits thus it's ready for production use. The

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/5] Adding OpenMP Offloading Backend for C++ Parallel

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/5] Adding OpenMP Offloading Backend for C++ Parallel

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

https://github.com/AaronBallman approved this pull request. LGTM (fine to land without tests as it only adds comments to generated header files) https://github.com/llvm/llvm-project/pull/65744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

orcguru wrote: > Missing an update in `recordRelocation()` similar as the patch: > https://reviews.llvm.org/D155415. > > Working on it now. Done. Added one test case aix-tls-ld-xcoff-reloc-large.ll to track this kind of issue. If full set of test case is necessary, please let me know, and I

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

@@ -59,4 +60,8 @@ void llvm::emitSourceFileHeader(StringRef Desc, raw_ostream ) { printLine(OS, Prefix, ' ', Suffix); printLine(OS, "\\*===", '-', "===*/"); OS << '\n'; + + // Print the path of source file + if (!Record.getInputFilename().empty()) +OS << "//

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

sdkrystian wrote: Ping @erichkeane & @shafik -- I left comments responding to your feedback https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

arichardson wrote: > > I think it would be good if all of them did it, the reason I didn't is that > > I limited it to the ones I can test locally. Seeing as there is probably CI > > coverage for all of the configs, should I try updating the remaining ones? > > Yes, I think it makes sense for

[clang] [clang][dataflow] Avoid putting an assertion in an `LLVM_DEBUG` block. (PR #67313)

https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/67313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] dae7e2d - [libunwind] Pass -Wl,--export-dynamic on all supported platforms (#67205)

Author: Alexander Richardson Date: 2023-09-25T16:42:08+01:00 New Revision: dae7e2da795b262837007dc96d7681b819376382 URL: https://github.com/llvm/llvm-project/commit/dae7e2da795b262837007dc96d7681b819376382 DIFF:

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: https://github.com/sunshaoce updated https://github.com/llvm/llvm-project/pull/65744 >From 23d0b738bf40ea44e159f4f8d7355d4d6bc0688d Mon Sep 17 00:00:00 2001 From: Shao-Ce SUN Date: Sat, 23 Sep 2023 11:38:33 +0800 Subject:

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: sunshaoce wrote: Addressed. Thanks! Now it is ``` /*===- TableGen'erated file -*- C++ -*-===*\ |**| |* ValueTypes

[clang] f726da1 - [Driver] -include: deprecate probing .gch (#67084)

Author: Fangrui Song Date: 2023-09-25T09:56:28-07:00 New Revision: f726da1193baf51e0a66453cc32dcffb8a9121d4 URL: https://github.com/llvm/llvm-project/commit/f726da1193baf51e0a66453cc32dcffb8a9121d4 DIFF: https://github.com/llvm/llvm-project/commit/f726da1193baf51e0a66453cc32dcffb8a9121d4.diff

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 557315. efriedma added a comment. Updated with my attempt at guest exit thunks. Seems to be working for simple cases, but I'm not sure this is actually working properly (I'm still seeing LNK1000 crashes). Repository: rG LLVM Github Monorepo CHANGES

[clang] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

https://github.com/DavidTruby closed https://github.com/llvm/llvm-project/pull/67125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

erichkeane wrote: I don't have any comments, though someone with knowledge of teh clang-tools-extra stuff would be nice to take a look, as well as someone familiar with the serialization. @AaronBallman . ALSO, this might need a release note and does this need to be mailed to the 'breaking

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added a comment. Note we have a second crash linked to this PR: https://github.com/llvm/llvm-project/issues/67173#issuecomment-1733647699 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837

[clang] 4cd3741 - Add documentation for the constructor and destructor attributes

Author: Aaron Ballman Date: 2023-09-25T12:22:54-04:00 New Revision: 4cd37415b24098c6822b2dbbf0e66d7e5f649624 URL: https://github.com/llvm/llvm-project/commit/4cd37415b24098c6822b2dbbf0e66d7e5f649624 DIFF: https://github.com/llvm/llvm-project/commit/4cd37415b24098c6822b2dbbf0e66d7e5f649624.diff

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

majaha wrote: > These are just non-wasm options, so they mean nothing to wasm. Yes, and using them gives no warning. > Wasm simply doesn't do anything with respect to these options and wasm is not > overriding them. --trap-unreachable is absolutely overridden, in exactly the same place as

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

jansvoboda11 wrote: The "Index/annotate-module.m" test fails with this patch. For run line 29, the previous input is: ``` Punctuation: "#" [1:1 - 1:2] inclusion directive=Module/Sub2.h (/Users/Jan/Code/upstream-llvm/clang/test/Index/../Modules/Inputs/Module.framework/Headers/Sub2.h)

[clang] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

zahiraam wrote: > This implementation has bugs, see [#66114 > (comment)](https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259) @RIscRIpt Thanks. Will look at them. https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

ldionne wrote: > Thank you for your review! Here are some comments and my thoughts. > > > Note that you should probably rebase your patch onto main and force-push to > > update the PR > > Does it mean that I can rebase and force-push since (it should be avoided in > normal case but) this is

[clang-tools-extra] AMDGPU: Duplicate instead of COPY constants from VGPR to SGPR (PR #66882)

jplehr wrote: Sure, I'll look into it later today and get back to you. https://github.com/llvm/llvm-project/pull/66882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

arichardson wrote: > Is there a reason why _all_ configurations shouldn't be doing this? I think it would be good if all of them did it, the reason I didn't is that I limited it to the ones I can test locally. Seeing as there is probably CI coverage for all of the configs, should I try

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

@@ -0,0 +1,21 @@ +// RUN: %clang_cc1 -verify -fopenmp %s +// RUN: %clang_cc1 -verify -fopenmp-simd %s +// RUN: %clang_cc1 -verify -fopenmp -fopenmp-targets=nvptx64 %s + +void foo() { +} + +void bar() { +#pragma omp target ompx_bare // expected-error {{unexpected OpenMP clause

[clang] 364757d - [clang][Interp] Fix compiling undefined templated functions (#67232)

Author: Timm Baeder Date: 2023-09-25T17:28:44+02:00 New Revision: 364757d2d5e1498239566941f8ba334e9846c53b URL: https://github.com/llvm/llvm-project/commit/364757d2d5e1498239566941f8ba334e9846c53b DIFF: https://github.com/llvm/llvm-project/commit/364757d2d5e1498239566941f8ba334e9846c53b.diff

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

goldsteinn wrote: > I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One > is trivial, one is probably easy, and then one with the new stuff. So PR based on PR? The thing is there are dependencies between commits. My expectation is that I will push commits as they are

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,135 @@ + +#include "clang/Frontend/CodeSnippetHighlighter.h" +#include "clang/Basic/DiagnosticOptions.h" +#include

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

AaronBallman wrote: > I am not sure how to keep only the `llvm-project//Filename` path except > by hard-coding. Or how about only keeping the base file name? This could > limit it to within 80 characters. I'd recommend using this API:

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6569 + + if (Args.hasArg(options::OPT_hipstdpar_interpose_alloc)) +CmdArgs.push_back("-hipstdpar-interpose-alloc"); This can use AddLastArg. CHANGES SINCE LAST ACTION

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

Caslyn wrote: Hi @ilya-biryukov - it seems this PR caused a couple test failures in RecursiveASTVisitorTests/ on the Fuchsia windows-x64 builder. Could you take a look to verify whether an additional fix (or revert) is needed? [clang-windows-x64-test

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/66545 >From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Mon, 25 Sep 2023 08:22:27 -0700 Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

jdoerfert wrote: I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One is trivial, one is probably easy, and then one with the new stuff. https://github.com/llvm/llvm-project/pull/66036 ___ cfe-commits mailing list

[clang] [clang][Interp] Fix compiling undefined templated functions (PR #67232)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

https://github.com/jansvoboda11 approved this pull request. Thanks! LGTM. https://github.com/llvm/llvm-project/pull/67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___ cfe-commits mailing list

[clang] AMDGPU: Duplicate instead of COPY constants from VGPR to SGPR (PR #66882)

rovka wrote: @jplehr Thanks for pointing that out. I tried reproducing the failure locally (Ubuntu 22.04 running on AMD hardware) but couldn't manage to run the tests for amdgcn-amd-amdhsa, although the AMDGPU target is in LLVM_TARGETS_TO_BUILD. I'm assuming this is because I'm missing some

[clang-tools-extra] AMDGPU: Duplicate instead of COPY constants from VGPR to SGPR (PR #66882)

rovka wrote: @jplehr Thanks for pointing that out. I tried reproducing the failure locally (Ubuntu 22.04 running on AMD hardware) but couldn't manage to run the tests for amdgcn-amd-amdhsa, although the AMDGPU target is in LLVM_TARGETS_TO_BUILD. I'm assuming this is because I'm missing some

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Inside `writePrettyPrintFunction()`, we check if we need to emit the given argument: ```C++ if (!arg-isOptional() || arg-getIsOmitted() == "false") { FoundNonOptArg = true; continue; } ``` For the `AssumeAligned` attribute, the

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

https://github.com/ldionne commented: Is there a reason why *all* configurations shouldn't be doing this? https://github.com/llvm/llvm-project/pull/67201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67205 >From 27c0526c4b21e2b19eeeae3c23928421437b885a Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Fri, 22 Sep 2023 16:11:49 -0700 Subject: [PATCH] [libunwind] Pass -Wl,--export-dynamic on all supported

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/67205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( arichardson wrote: Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.

[clang] [libc++] Re-enable the clang_modules_include test for Objective-C++ (PR #66801)

ldionne wrote: @mordante I'm not certain what's going on here, I get ``` [...]/clang_modules_include.gen.py/__std_clang_module.compile.pass.mm:22:2: error: import of module 'std' imported non C++20 importable modules 22 | @import std; | ^ 1 error generated. ``` Can you assist? It

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules): AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"), ], ), +Parameter( arichardson wrote: Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -134,3 +134,8 @@ ABI Affecting Changes Build System Changes + +- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are relying on this, the new replacement + is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

@@ -134,3 +134,8 @@ ABI Affecting Changes Build System Changes + +- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are relying on this, the new replacement + is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,135 @@ + +#include "clang/Frontend/CodeSnippetHighlighter.h" +#include "clang/Basic/DiagnosticOptions.h" +#include

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

ldionne wrote: You could add it to all the `.cfg.in` files (I think we agree that it's what makes sense in theory) and then see whether the flags change in the configurations tested in the CI. https://github.com/llvm/llvm-project/pull/67201 ___

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/67084 >From 0e3417287a71454339cff40e20d5c2e41b728485 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 12 Sep 2023 18:31:18 -0700 Subject: [PATCH] [Driver] -include: deprecate probing .gch (#67084) `-include

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T ==

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This commit renames alpha.security.taint.TaintPropagation checker to optin.security.taint.TaintPropagation. This checker was stabilized and improved by recent commits thus it's ready for production use. The checker is placed in the

[clang] 247b7d0 - [cmake] Add LLVM_FORCE_VC_REVISION option (#67125)

Author: David Truby Date: 2023-09-25T14:32:52+01:00 New Revision: 247b7d068497de085b7fd66c6531034afa9709f0 URL: https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0 DIFF: https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0.diff

[clang] c1300ef - [Driver] Remove FreeBSD/riscv32 support (#67277)

Author: Brad Smith Date: 2023-09-25T09:43:10-04:00 New Revision: c1300efc78a17374065744c8985b4598fb8c3166 URL: https://github.com/llvm/llvm-project/commit/c1300efc78a17374065744c8985b4598fb8c3166 DIFF: https://github.com/llvm/llvm-project/commit/c1300efc78a17374065744c8985b4598fb8c3166.diff

[clang] [Driver] Remove FreeBSD/riscv32 support (PR #67277)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/67277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156711: [clang][ExprConstant] Fix assertion failure in constant expression folding

antmo abandoned this revision. antmo added a comment. yes indeed you fixed this @shafik. thanks for the update. abandoning this revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156711/new/ https://reviews.llvm.org/D156711

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/66846 >From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 19 Sep 2023 16:15:20 +0800 Subject: [PATCH 1/4] [clang-analysis]Fix false positive in mutation check when

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

@@ -59,4 +60,8 @@ void llvm::emitSourceFileHeader(StringRef Desc, raw_ostream ) { printLine(OS, Prefix, ' ', Suffix); printLine(OS, "\\*===", '-', "===*/"); OS << '\n'; + + // Print the path of source file + if (!Record.getInputFilename().empty()) +OS << "//

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T ==

[clang] [Inliner] Improve attribute propagation to callsites when inlining. (PR #66036)

jdoerfert wrote: > > I don't think 10 commit PRs are helpful. This should be 3 PRs at least. One > > is trivial, one is probably easy, and then one with the new stuff. > > So PR based on PR? The thing is there are dependencies between commits. My > expectation is that I will push commits as

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T ==

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1261 HelpText<"HIP runtime installation path, used for finding HIP version and adding HIP include path.">; +def hipstdpar : Flag<["-", "--"], "hipstdpar">, + Visibility<[ClangOption,

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Differential Revision: https://reviews.llvm.org/D159128 --- Patch is 20.30 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/67349.diff 5 Files Affected: - (modified)

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

dyung added a comment. In D147655#4650663 , @rjmccall wrote: > I've been informed that Apple's change to the default ABI compatibility mode > is in our private fork, so this is not your problem; sorry for the noise. > > I'm not sure why we decided to do

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

haoNoQ wrote: (Yeah we still have those false positives, though `memset` isn't actually covered yet as a potential sink: https://godbolt.org/z/6h5x87vMc) https://github.com/llvm/llvm-project/pull/67352 ___ cfe-commits mailing list

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/6] Adding OpenMP Offloading Backend for C++ Parallel

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/66968 >From b35340e47de896c9933c54ce617538c46cf01488 Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Wed, 20 Sep 2023 17:06:10 -0700 Subject: [PATCH 1/6] Adding OpenMP Offloading Backend for C++ Parallel

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema , Decl *D, const ParsedAttr ) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema , Decl *D, const ParsedAttr ) { - uint32_t priority =

  1   2   3   4   >