[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added a comment. In D153131#4653362 , @aaronpuchert wrote: > In D153131#4653345 , @aeubanks > wrote: > >> This is finding lots of real issues in code, which is awesome, but could I >> request that this

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68565 >From f57f952989ee64d419dc51e9ecf9786720ece3ff Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/2] [AArch64][SME] Remove immediate argument restriction for

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

cor3ntin wrote: Thanks for this patch! Our policy is to not mix functional changes and formatting changes. Could you change the PR to have only the changes you made, wit no formatting change? You can format your patch with `git clang-format` which only formats the lines that you changed.

[clang-tools-extra] llvm-canon (PR #68176)

nikic wrote: Using the term for MIR is okay, because it does not have a pre-existing notion of canonical form. Doing the same for IR is not okay, because it already has a canonical form and this pass does not produce it. Calling this `ir-normalizer` instead of `ir-canonicalizer` should convey

[clang] llvm-canon (PR #68176)

nikic wrote: Using the term for MIR is okay, because it does not have a pre-existing notion of canonical form. Doing the same for IR is not okay, because it already has a canonical form and this pass does not produce it. Calling this `ir-normalizer` instead of `ir-canonicalizer` should convey

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

@@ -0,0 +1,118 @@ +//===- ModuleFilesInfo.h -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

@@ -0,0 +1,118 @@ +//===- ModuleFilesInfo.h -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

@@ -0,0 +1,118 @@ +//===- ModuleFilesInfo.h -*- C++-*-===// ChuanqiXu9 wrote: Done by renaming. I don't quite understand the sentence "the modules are the inputs for something in particular.".

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

@@ -0,0 +1,118 @@ +//===- ModuleFilesInfo.h -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang] [MinGW] Explicitly always pass the -fno-use-init-array (PR #68571)

mstorsjo wrote: This is an alternative to #68570. This has the upside that the `UseInitArray` flag is set to the correct value throughout the chain, for any other potential users of the field, in case it would affect code generation in other places. The downside is that if we only go with

[clang] [analyzer] Compute length of string literal initializers (#66990) (PR #68368)

https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/68368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Compute length of string literal initializers (#66990) (PR #68368)

https://github.com/DonatNagyE requested changes to this pull request. As far as I see the code that you added doesn't check whether the global variable is a constant or not. Please add a check for this (examine the type of the declaration `decl`) and consider adding test cases which validate

[clang] [analyzer] Compute length of string literal initializers (#66990) (PR #68368)

@@ -930,9 +930,24 @@ SVal CStringChecker::getCStringLength(CheckerContext , ProgramStateRef , const StringLiteral *strLit = cast(MR)->getStringLiteral(); return svalBuilder.makeIntVal(strLit->getLength(), sizeTy); } + case MemRegion::NonParamVarRegionKind: { +

[clang] [clang][dataflow] Various formatting tweaks to HTMLLogger. (PR #68392)

https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/68392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://github.com/DonatNagyE edited

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -84,33 +104,70 @@

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: @@ -84,33 +104,70 @@

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/mathstuf edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema , Decl *D, const ParsedAttr ) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema , Decl *D, const ParsedAttr ) { - uint32_t priority =

[clang] [Clang][Frontend] Fix a crash when -Wdocumentation is used (PR #68525)

AaronBallman wrote: > > Is there a way we could come up with a test for this? > > Unfortunately, I don't think so. I cannot reduce the 600k lines of > preprocessed code to a small test case that will crash the clang frontend. Have you tried using creduce or other such tool? (We generally

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

nikic added a comment. In D155688#4653347 , @fiigii wrote: > How does this patch work with `visitGEPOfGEP` that does a reverse > transformation? > > // Replace: gep (gep %P, long B), long A, ... > // With:T = long A+B; gep %P, T, ... The

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

kekcheburec added a comment. In D70401#4653409 , @zixuan-wu wrote: > ping? Pong  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/68572 …… (#68394)" The new warnings are now under a separate flag `-Wthread-safety-reference-return`. The plan is: - Start with a period where people can opt into the new warnings with

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

llvmbot wrote: @llvm/pr-subscribers-clang Changes …… (#68394)" The new warnings are now under a separate flag `-Wthread-safety-reference-return`. The plan is: - Start with a period where people can opt into the new warnings with `-Wthread-safety-reference-return` or

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

legrosbuffle wrote: @aeubanks FYI https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Various formatting tweaks to HTMLLogger. (PR #68392)

https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/68392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::iota (PR #68494)

https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68364 >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Wed, 4 Oct 2023 15:55:55 -0500 Subject: [PATCH 1/4] [OpenMPIRBuilder] Add clauses to teams This patch adds

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

@@ -1917,8 +1917,13 @@ class OpenMPIRBuilder { /// /// \param Loc The location where the teams construct was encountered. /// \param BodyGenCB Callback that will generate the region code. + /// \param NumTeamsUpper Upper bound on the number of teams. + /// \param

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/kiranchandramohan commented: Is this change for OMP 5.0 and before? https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/kiranchandramohan edited https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

@@ -1917,8 +1917,13 @@ class OpenMPIRBuilder { /// /// \param Loc The location where the teams construct was encountered. /// \param BodyGenCB Callback that will generate the region code. + /// \param NumTeamsUpper Upper bound on the number of teams. + /// \param

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/kiranchandramohan commented: Is this change for OMP 5.0 and before? https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/kiranchandramohan edited https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle delegating constructors (PR #67823)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle variadic functions (PR #67814)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://github.com/DonatNagyE edited

[clang-tools-extra] [clang-tidy] add namespace qualifier NFC (PR #68579)

https://github.com/metaflow created https://github.com/llvm/llvm-project/pull/68579 for daca97216cf132d733513f992d49e3c722aabf40 #68134 adds a namespace as we are not using llvm::StringRef yet >From c91b8034ddcd97fb255ccafe7a153056c0c2f446 Mon Sep 17 00:00:00 2001 From: Mikhail Goncharov

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/mathstuf edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

@@ -2352,26 +2352,126 @@ static void handleUnusedAttr(Sema , Decl *D, const ParsedAttr ) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema , Decl *D, const ParsedAttr ) { - uint32_t priority =

[clang] 85feb93 - [OpenMP] Fix setting visibility on declare target variables

Author: Joseph Huber Date: 2023-10-09T07:56:43-05:00 New Revision: 85feb9347f77859a877e767692e1c11d00cf6ffd URL: https://github.com/llvm/llvm-project/commit/85feb9347f77859a877e767692e1c11d00cf6ffd DIFF: https://github.com/llvm/llvm-project/commit/85feb9347f77859a877e767692e1c11d00cf6ffd.diff

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67673 >From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 28 Sep 2023 09:20:12 -0400 Subject: [PATCH 1/7] Diagnose problematic uses of constructor/destructor

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

@@ -1917,8 +1917,13 @@ class OpenMPIRBuilder { /// /// \param Loc The location where the teams construct was encountered. /// \param BodyGenCB Callback that will generate the region code. + /// \param NumTeamsUpper Upper bound on the number of teams. + /// \param

[libclc] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

@@ -1917,8 +1917,13 @@ class OpenMPIRBuilder { /// /// \param Loc The location where the teams construct was encountered. /// \param BodyGenCB Callback that will generate the region code. + /// \param NumTeamsUpper Upper bound on the number of teams. + /// \param

[clang] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

@@ -1917,8 +1917,13 @@ class OpenMPIRBuilder { /// /// \param Loc The location where the teams construct was encountered. /// \param BodyGenCB Callback that will generate the region code. + /// \param NumTeamsUpper Upper bound on the number of teams. + /// \param

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

@@ -1917,8 +1917,13 @@ class OpenMPIRBuilder { /// /// \param Loc The location where the teams construct was encountered. /// \param BodyGenCB Callback that will generate the region code. + /// \param NumTeamsUpper Upper bound on the number of teams. + /// \param

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://github.com/DonatNagyE edited

[clang-tools-extra] [clang-tidy] add namespace qualifier NFC (PR #68579)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes for daca97216cf132d733513f992d49e3c722aabf40 #68134 adds a namespace as we are not using llvm::StringRef yet --- Full diff: https://github.com/llvm/llvm-project/pull/68579.diff 1 Files Affected: - (modified)

[clang] 2856e72 - [analyzer][NFC] Remove outdated FIXME comment (#68211)

Author: DonatNagyE Date: 2023-10-09T13:56:20+02:00 New Revision: 2856e729f3640c500499a84fb741b15775e529cf URL: https://github.com/llvm/llvm-project/commit/2856e729f3640c500499a84fb741b15775e529cf DIFF: https://github.com/llvm/llvm-project/commit/2856e729f3640c500499a84fb741b15775e529cf.diff

[clang] [analyzer][NFC] Remove outdated FIXME comment (PR #68211)

https://github.com/DonatNagyE closed https://github.com/llvm/llvm-project/pull/68211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67673 >From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 28 Sep 2023 09:20:12 -0400 Subject: [PATCH 1/5] Diagnose problematic uses of constructor/destructor

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM -- that release note is *awesome*, thank you for that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393

[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67673 >From 02565df450927fac88062f526a167c9beb518c2f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 28 Sep 2023 09:20:12 -0400 Subject: [PATCH 1/7] Diagnose problematic uses of constructor/destructor

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

shraiysh wrote: > Is this change for OMP 5.0 and before? No, it should be for all the standards since `num_teams` was introduced. Why do you think it is for OMP 5.0 and before, but not for 5.1 and 5.2? I will try to address it and clarify. https://github.com/llvm/llvm-project/pull/68364

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

shraiysh wrote: > Is this change for OMP 5.0 and before? No, it should be for all the standards since `num_teams` was introduced. Why do you think it is for OMP 5.0 and before, but not for 5.1 and 5.2? I will try to address it and clarify. https://github.com/llvm/llvm-project/pull/68364

[libclc] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

shraiysh wrote: > Is this change for OMP 5.0 and before? No, it should be for all the standards since `num_teams` was introduced. Why do you think it is for OMP 5.0 and before, but not for 5.1 and 5.2? I will try to address it and clarify. https://github.com/llvm/llvm-project/pull/68364

[clang] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

shraiysh wrote: > Is this change for OMP 5.0 and before? No, it should be for all the standards since `num_teams` was introduced. Why do you think it is for OMP 5.0 and before, but not for 5.1 and 5.2? I will try to address it and clarify. https://github.com/llvm/llvm-project/pull/68364

[libclc] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68364 >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Wed, 4 Oct 2023 15:55:55 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Add clauses to teams This patch adds

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68364 >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Wed, 4 Oct 2023 15:55:55 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Add clauses to teams This patch adds

[libunwind] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68364 >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Wed, 4 Oct 2023 15:55:55 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Add clauses to teams This patch adds

[clang-tools-extra] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh reopened https://github.com/llvm/llvm-project/pull/68364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMPIRBuilder] Add ThreadLimit and NumTeamsUpper clauses to teams clause (PR #68364)

https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68364 >From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Wed, 4 Oct 2023 15:55:55 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Add clauses to teams This patch adds

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

@@ -45,6 +45,10 @@ class GlobalCompilationDatabase { return std::nullopt; } + virtual std::vector getAllFilesInProjectOf(PathRef File) const { mathstuf wrote: Probably easiest to see it by the writer code

[clang-tools-extra] 60f7aa1 - [clang-tidy] add namespace qualifier NFC (#68579)

Author: Mikhail Goncharov Date: 2023-10-09T13:58:13+02:00 New Revision: 60f7aa1a6ccb4214aec8838096abbdc1b37169a5 URL: https://github.com/llvm/llvm-project/commit/60f7aa1a6ccb4214aec8838096abbdc1b37169a5 DIFF:

[clang-tools-extra] [clang-tidy] add namespace qualifier NFC (PR #68579)

https://github.com/metaflow closed https://github.com/llvm/llvm-project/pull/68579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

https://github.com/mathstuf edited https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Pointer.h:81-88 + /// Equality operators are just for tests. + bool operator==(const Pointer ) const { +return Pointee == P.Pointee && Base == P.Base && Offset == P.Offset; + } + + bool operator!=(const

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

@@ -9665,18 +9665,34 @@ Value *CodeGenFunction::EmitSMEZero(const SVETypeFlags , Value *CodeGenFunction::EmitSMELdrStr(const SVETypeFlags , SmallVectorImpl , unsigned IntID) { - if (Ops.size() == 3)

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

@@ -9665,18 +9665,34 @@ Value *CodeGenFunction::EmitSMEZero(const SVETypeFlags , Value *CodeGenFunction::EmitSMELdrStr(const SVETypeFlags , SmallVectorImpl , unsigned IntID) { - if (Ops.size() == 3)

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

@@ -8,7 +8,7 @@ // CHECK-C-LABEL: @test_svldr_vnum_za( // CHECK-CXX-LABEL: @_Z18test_svldr_vnum_zajPKv( // CHECK-NEXT: entry: -// CHECK-NEXT:tail call void @llvm.aarch64.sme.ldr(i32 [[SLICE_BASE:%.*]], ptr [[PTR:%.*]]) kmclaughlin-arm wrote: Were these

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

@@ -8,31 +8,28 @@ // CHECK-C-LABEL: @test_svstr_vnum_za( // CHECK-CXX-LABEL: @_Z18test_svstr_vnum_zajPv( // CHECK-NEXT: entry: -// CHECK-NEXT:tail call void @llvm.aarch64.sme.str(i32 [[SLICE_BASE:%.*]], ptr [[PTR:%.*]]) +// CHECK-NEXT:tail call void

[clang] [analyzer] Removing untrusted buffer size taint warning (PR #68607)

https://github.com/dkrupp created https://github.com/llvm/llvm-project/pull/68607 alpha.security.taint.TaintPropagation checker emitted a false warning to the following code char buf[100]; size_t size = tainted(); if (size > 100) return; memset(buf, 0, size); // warn: untrusted data used as

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

https://github.com/bjope updated https://github.com/llvm/llvm-project/pull/68590 From 44eedec9dae39e72d5474426a15a07d9be4144fc Mon Sep 17 00:00:00 2001 From: Bjorn Pettersson Date: Mon, 9 Oct 2023 16:13:39 +0200 Subject: [PATCH 1/3] [Sema] Handle large shift counts in GetExprRange GetExprRange

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

llvmbot wrote: @llvm/pr-subscribers-clang Changes GetExprRange did not expect that very large shift counts when narrowing the range based on logical right shifts. So with inputs such as *a 123456789012345678901uwb it would hit assertions about trying to convert a too large APInt into

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

AMS21 wrote: If there are no more problems, I would kindly ask for this to be merged :) https://github.com/llvm/llvm-project/pull/68359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f9bd62f - [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (#68359)

Author: AMS21 Date: 2023-10-09T16:40:18+02:00 New Revision: f9bd62fb8f666e818a4bf0f0dbcb77a0a223c97a URL: https://github.com/llvm/llvm-project/commit/f9bd62fb8f666e818a4bf0f0dbcb77a0a223c97a DIFF: https://github.com/llvm/llvm-project/commit/f9bd62fb8f666e818a4bf0f0dbcb77a0a223c97a.diff LOG:

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/68359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Implement matrix inverse (PR #67382)

https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Implement matrix inverse (PR #67382)

https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Implement the 'counted_by' attribute" (PR #68603)

https://github.com/alexfh created https://github.com/llvm/llvm-project/pull/68603 This reverts commit 9a954c693573281407f6ee3f4eb1b16cc545033d, which causes clang crashes when compiling with `-fsanitize=bounds`. See

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,226 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -85,7 +86,7 @@ class ProfiledCallGraph { std::queue Queue; for (auto : ContextTracker.getRootContext().getAllChildContext()) { ContextTrieNode *Callee = - addProfiledFunction(ContextTracker.getFuncNameFor(Callee)); +

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

dkrupp wrote: @haoNoQ thanks for pointing out #61826 umbrella issue, I somehow missed that. I see this TaintPropagation checker as a generic flexible tool to find potential vulnerable data flows between any taint source and taint sink. The user should be configure sources and sinks in the

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

https://github.com/bjope updated https://github.com/llvm/llvm-project/pull/68590 From 44eedec9dae39e72d5474426a15a07d9be4144fc Mon Sep 17 00:00:00 2001 From: Bjorn Pettersson Date: Mon, 9 Oct 2023 16:13:39 +0200 Subject: [PATCH 1/2] [Sema] Handle large shift counts in GetExprRange GetExprRange

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

@@ -219,6 +219,10 @@ Bug Fixes in This Version - Clang no longer considers the loss of ``__unaligned`` qualifier from objects as an invalid conversion during method function overload resolution. +- Fixed an issue when a shift count larger than ``__INT64_MAX__``, in a right

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c2x -triple=x86_64-unknown-linux %s + +// Regression test for bug where we used to hit assertion due to shift amount erichkeane wrote: ```suggestion // Regression test for bug where we used to hit

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c2x -triple=x86_64-unknown-linux %s + +// Regression test for bug where we used to hit assertion due to shift amount +// being larger than 64 bits. We want to see a warning about too large shift +// amount. +void

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c2x -triple=x86_64-unknown-linux %s + +// Regression test for bug where we used to hit assertion due to shift amount +// being larger than 64 bits. We want to see a warning about too large shift +// amount. +void

[clang] [Sema] Handle large shift counts in GetExprRange (PR #68590)

@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c2x -triple=x86_64-unknown-linux %s + +// Regression test for bug where we used to hit assertion due to shift amount +// being larger than 64 bits. We want to see a warning about too large shift +// amount. +void

  1   2   3   4   >