[clang] [mlir] Add ContractionOpInterface utility functions for vector matrix multiplication (PR #68945)

2023-10-16 Thread Diego Caballero via cfe-commits
@@ -86,6 +86,39 @@ def LinalgContractionOpInterface : OpInterface<"ContractionOpInterface"> { /*methodBody=*/[{ return mlir::isRowMajorBatchMatmul($_op.getIndexingMaps()); }]>, +InterfaceMethod< +/*desc=*/[{ + Returns whether the given op has index

[clang] [mlir] Add ContractionOpInterface utility functions for vector matrix multiplication (PR #68945)

2023-10-16 Thread Diego Caballero via cfe-commits
@@ -96,6 +96,79 @@ bool mlir::isRowMajorBatchMatmul(ArrayAttr indexingMaps) { return indexingMaps == maps; } +bool mlir::isVecmat(ArrayAttr indexingMaps) { + if (indexingMaps.size() != 3) +return false; + auto map0 = cast(indexingMaps[0]).getValue(); d

[clang] [mlir] Add ContractionOpInterface utility functions for vector matrix multiplication (PR #68945)

2023-10-16 Thread Diego Caballero via cfe-commits
https://github.com/dcaballe commented: Awesome! Just a couple of minor comments from my side! https://github.com/llvm/llvm-project/pull/68945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [mlir] Add ContractionOpInterface utility functions for vector matrix multiplication (PR #68945)

2023-10-16 Thread via cfe-commits
@@ -86,6 +86,39 @@ def LinalgContractionOpInterface : OpInterface<"ContractionOpInterface"> { /*methodBody=*/[{ return mlir::isRowMajorBatchMatmul($_op.getIndexingMaps()); }]>, +InterfaceMethod< +/*desc=*/[{ + Returns whether the given op has index

[clang] [CUDA][HIP] Fix init var diag in temmplate (PR #69081)

2023-10-16 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/69081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-16 Thread David Blaikie via cfe-commits
dwblaikie wrote: > Wouldn't it be better to go the other way around? i.e. have a > `[[clang::compressed_bitfield]]` (or whatever) which influences the ABI, so > it's possible to do stuff like > > ```c++ > [[clang::compressed_bitfield]] bool IsSomething : 1; > [[clang::compressed_bitfield]] MyE

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-16 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

2023-10-16 Thread via cfe-commits
philnik777 wrote: > > Wouldn't it be better to go the other way around? i.e. have a > > `[[clang::compressed_bitfield]]` (or whatever) which influences the ABI, so > > it's possible to do stuff like > > ``` > > [[clang::compressed_bitfield]] bool IsSomething : 1; > > [[clang::compressed_bitfiel

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/69207 >From 7771acd00ace1362e580531f1a3ed63f81cfa5a3 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Mon, 14 Aug 2023 03:04:36 +0200 Subject: [PATCH 1/4] [clang-tidy] mo

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
@@ -122,6 +122,8 @@ Improvements to clang-tidy if any :program:`clang-tidy` subprocess exits with a non-zero code or if exporting fixes fails. +- Do not emit a `return` for fixes of `modernize-avoid-bind` when the function returns void. 5chmidti wrote: d

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
@@ -554,6 +555,8 @@ getLambdaProperties(const MatchFinder::MatchResult &Result) { LP.Callable.Materialization = getCallableMaterialization(Result); LP.Callable.Decl = getCallMethodDecl(Result, LP.Callable.Type, LP.Callable.Materialization); + if (LP.Callable.Decl) +

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

2023-10-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1213 std::optional SubExprT = classify(SubExpr); - if (E->getStorageDuration() == SD_Static) { + bool IsStatic = E->getStorageDuration() == SD_Static; + if (GlobalDecl || IsStatic) { -

[clang] [AMDGPU] Add an option to disable unsafe uses of atomic xor (PR #69229)

2023-10-16 Thread Pierre-Andre Saulais via cfe-commits
pasaulais wrote: Hi @jansvoboda11, @arsenm, I haven't yet got a commit merged to LLVM and can't request a review through the UI. Could I get a review on this patch? Thanks in advance and apologies if I've missed a step in the submission process. https://github.com/llvm/llvm-project/pull/69229

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread Piotr Zegar via cfe-commits
@@ -343,6 +343,10 @@ Changes in existing checks ` check to identify calls to static member functions with out-of-class inline definitions. +- Improved :doc:`modernize-avoid-bind PiotrZSL wrote: put this in alphabetical order, use double `` for return, as

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Release notes still need some work, except that looks fine. https://github.com/llvm/llvm-project/pull/69207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,142 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,142 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ +//===--===// ldionne wrote: Not attached to this file: We should have simple documentation for this new backend somewhere in our `.rst` tree. It should explain what restriction

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,73 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,220 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,220 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,220 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,31 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,72 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,142 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,142 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,220 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,73 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-16 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,220 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] dd0fba1 - [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (#68379)

2023-10-16 Thread via cfe-commits
Author: antangelo Date: 2023-10-16T15:17:36-04:00 New Revision: dd0fba11690f9fef304d5f48cde646e5eca8d3c0 URL: https://github.com/llvm/llvm-project/commit/dd0fba11690f9fef304d5f48cde646e5eca8d3c0 DIFF: https://github.com/llvm/llvm-project/commit/dd0fba11690f9fef304d5f48cde646e5eca8d3c0.diff LOG

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-16 Thread via cfe-commits
https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68820 >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH 1/3] Add support for -fcx-limited-range and #pragma CX_LIMTED_RAN

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Erich Keane via cfe-commits
@@ -560,11 +560,12 @@ ParsedTargetAttr TargetInfo::parseTargetAttr(StringRef Features) const { } // While we're here iterating check for a different target cpu. -if (Feature.startswith("arch=")) { +if (Feature.startswith("arch=") || Feature.startswith("cpu="))

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Erich Keane via cfe-commits
@@ -560,11 +560,12 @@ ParsedTargetAttr TargetInfo::parseTargetAttr(StringRef Features) const { } // While we're here iterating check for a different target cpu. -if (Feature.startswith("arch=")) { +if (Feature.startswith("arch=") || Feature.startswith("cpu="))

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Erich Keane via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for t

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Erich Keane via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for t

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Aaron Ballman via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for t

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Aaron Ballman via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for t

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/69240 Deploying #67766 to a large internal codebase uncovers many bugs (many are probably benign but need cleaning up). There are also issues in high-profile open-source projects like v8. Add a cl::opt to disable builti

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Fangrui Song (MaskRay) Changes Deploying #67766 to a large internal codebase uncovers many bugs (many are probably benign but need cleaning up). There are also issues in high-profile open-source projects like v8. Add a cl::opt to d

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/69242 Extended IgnoreConversionFromTypes option to include types without a declaration, such as built-in types. >From 56bf257baff400189651c71a1639fbad8faa3a19 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Mon, 16

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Extended IgnoreConversionFromTypes option to include types without a declaration, such as built-in types. --- Full diff: https://github.com/llvm/llvm-project/pull/69242.diff 3 Files Affected: - (modif

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/69207 >From 7771acd00ace1362e580531f1a3ed63f81cfa5a3 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Mon, 14 Aug 2023 03:04:36 +0200 Subject: [PATCH 1/5] [clang-tidy] mo

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

2023-10-16 Thread Shoaib Meenai via cfe-commits
Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: smeenai wrote: https://github.com/boostorg/mpl/issues/69 is still a problem, unfortunately. https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/69244 Out of line class template declaration specializations aren't created at the time they have their template arguments checked, so we previously weren't doing any amount of work to substitute the constraints be

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/69244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes Out of line class template declaration specializations aren't created at the time they have their template arguments checked, so we previously weren't doing any amount of work to substitute the constraints

[PATCH] D157331: [clang] Implement C23

2023-10-16 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Thanks, my concerns in the tests have been addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/69242 >From 56bf257baff400189651c71a1639fbad8faa3a19 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Mon, 16 Oct 2023 19:43:21 + Subject: [PATCH 1/2] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-16 Thread via cfe-commits
https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/69242 >From 56bf257baff400189651c71a1639fbad8faa3a19 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Mon, 16 Oct 2023 19:43:21 + Subject: [PATCH 1/2] [clang-tidy] Improved cppcoreguidelines-narrowing-con

[clang] b7de1d0 - [Clang][NFC] Use correct tool name for NVIDIA's 'nvlink'

2023-10-16 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-10-16T15:41:01-05:00 New Revision: b7de1d07e5298bdd97816043360ea334378f5565 URL: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565 DIFF: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565.diff

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/69244 >From 021ec9d584dffc6852a777effc50843bd0facaa1 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 16 Oct 2023 13:02:14 -0700 Subject: [PATCH 1/2] [CONCEPTS]Corrected comparison of constraints with out of li

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/69249 Skip TrailingAnnotation when looking for TrailingReturnArrow. Fixes #69234. >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject: [

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Skip TrailingAnnotation when looking for TrailingReturnArrow. Fixes #69234. --- Full diff: https://github.com/llvm/llvm-project/pull/69249.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnot

[clang-tools-extra] c5b617c - [clang-tidy][NFC] Clarify documentation for misc-definitions-in-headers

2023-10-16 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-10-16T20:50:38Z New Revision: c5b617c5e53d7af81c621d200e2cd03324538541 URL: https://github.com/llvm/llvm-project/commit/c5b617c5e53d7af81c621d200e2cd03324538541 DIFF: https://github.com/llvm/llvm-project/commit/c5b617c5e53d7af81c621d200e2cd03324538541.diff LOG: [

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for t

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for t

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/69244 >From 810d49553eac0e42697283b008810cdc37971dd0 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 16 Oct 2023 13:02:14 -0700 Subject: [PATCH 1/2] [CONCEPTS]Corrected comparison of constraints with out of li

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
erichkeane wrote: I did a force-push with the hope that it'll get the code-formatter to start recognizing what is going on, it seems to be doing some wacky things? https://github.com/llvm/llvm-project/pull/69244 ___ cfe-commits mailing list cfe-commit

[clang] [Clang] Handle real and imaginary parts of complex lvalue in `APValue::printPretty` (PR #69252)

2023-10-16 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/69252 This patch handles formatting of real and imaginary parts of complex lvalue. Fixes #69218. >From 8f0ebe5b5cfed069c8274c0761559d6595d4dea8 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 17 Oct 2023 05:1

[clang] [Clang] Handle real and imaginary parts of complex lvalue in `APValue::printPretty` (PR #69252)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yingwei Zheng (dtcxzyw) Changes This patch handles formatting of real and imaginary parts of complex lvalue. Fixes #69218. --- Full diff: https://github.com/llvm/llvm-project/pull/69252.diff 2 Files Affected: - (modified) clang/lib/AST

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Björn Schäpers via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) + continue; +const auto *Next = T

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Björn Schäpers via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) HazardyKnusperkeks wrote: Why do

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-10-16 Thread Fangrui Song via cfe-commits
MaskRay wrote: These tests just need a `--target=x86_64-linux-gnu`: which is how clang/test/Driver tests these stuff. Non-ELF platforms such as Apple, Windows, and AIX, may not support some options. Ideally we should express that the test works for every ELF platform or everything except bare

[clang] 5f4ed78 - [clang-format] Allow default values for template parameters in lambda (#69052)

2023-10-16 Thread via cfe-commits
Author: Emilia Kond Date: 2023-10-17T00:38:33+03:00 New Revision: 5f4ed780d348c810a7d4c1dd9354abf79094364b URL: https://github.com/llvm/llvm-project/commit/5f4ed780d348c810a7d4c1dd9354abf79094364b DIFF: https://github.com/llvm/llvm-project/commit/5f4ed780d348c810a7d4c1dd9354abf79094364b.diff L

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) owenca wrote: Because `TT_Traili

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/69249 >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating TrailingReturnArrow Skip T

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-16 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: For reference, can you give a couple examples of code where this is triggering? If this is triggering in practice, do we want a real driver option to control the sanitizer? The alignment attributes themselves? https://github.com/llvm/llvm-project/pull/69240 __

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

2023-10-16 Thread Owen Pan via cfe-commits
owenca wrote: See #69249. https://github.com/llvm/llvm-project/pull/67780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Artem Dergachev via cfe-commits
@@ -392,19 +393,26 @@ void DynamicTypePropagation::checkPostCall(const CallEvent &Call, } } -/// TODO: Handle explicit casts. -/// Handle C++ casts. -/// -/// Precondition: the cast is between ObjCObjectPointers. ExplodedNode *DynamicTypePropagation::dynamicTypePropa

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

2023-10-16 Thread via cfe-commits
@@ -293,6 +293,10 @@ Changes in existing checks ` check to enforce a stricter match with the swap function signature, eliminating false-positives. +- Improved :doc:`readability-const-params-in-decls EugeneZelenko wrote: Please keep alphabetical order (by

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Artem Dergachev via cfe-commits
@@ -492,11 +492,13 @@ void check_required_cast() { void check_cast_behavior(OSObject *obj) { OSArray *arr1 = OSDynamicCast(OSArray, obj); - clang_analyzer_eval(arr1 == obj); // expected-warning{{TRUE}} -// expected-note@-1{{TRUE}} -

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/69057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

2023-10-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69103 >From 354a8e4034afd82e6ea854848a86b9011e26269b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Fri, 13 Oct 2023 19:27:15 +0100 Subject: [PATCH 1/3] Fix #68492: point to the correct const location --- .../read

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-16 Thread David Li via cfe-commits
https://github.com/david-xl approved this pull request. https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/2] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > For reference, can you give a couple examples of code where this is > triggering? > > If this is triggering in practice, do we want a real driver option to control > the sanitizer? The alignment attributes themselves? I am not sure we need special driver flag for that. @M

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/2] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-16 Thread Owen Pan via cfe-commits
owenca wrote: > This allows git-clang-format to be used on a Windows terminal without > manually needing to find the path and invoke the python interpreter. We have > a similar script for `scan-build`. Can you open an issue and link to it from here? It seems `git clang-format` works in Comman

[clang] Enable v for RISCV64 Android (PR #69261)

2023-10-16 Thread via cfe-commits
https://github.com/hiraditya created https://github.com/llvm/llvm-project/pull/69261 None >From c3203b8f9ee863283c897f9910505e70a6181110 Mon Sep 17 00:00:00 2001 From: AdityaK <1894981+hiradi...@users.noreply.github.com> Date: Mon, 16 Oct 2023 16:01:53 -0700 Subject: [PATCH] Enable v for RISCV6

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka created https://github.com/llvm/llvm-project/pull/69262 This change adds the PLATFORM XMACRO to simplify the addition of new MachO platforms and reduce the number of required changes. Many of the changes needed for adding a new platform are mechanical, such as adding

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Juergen Ributzka (ributzka) Changes This change adds the PLATFORM XMACRO to simplify the addition of new MachO platforms and reduce the number of required changes. Many of the changes needed for adding a new platform are mechanical,

[clang] Enable v for RISCV64 Android (PR #69261)

2023-10-16 Thread via cfe-commits
https://github.com/hiraditya edited https://github.com/llvm/llvm-project/pull/69261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Davide Italiano via cfe-commits
https://github.com/dcci approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b225934a4b0d2944958a53269665b00e7eae4875 d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 --

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH 1/2] [llvm] Use XMACROS for MachO platforms. This change adds

<    1   2   3   4   >