[clang] [clang][dataflow][NFC] Move `parseAll()` to TestingSupport and rename `parseFormulas()` (PR #70437)

2023-10-27 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/70437 I'm working on a patch that will use this function from a different test. >From 34daee21bca7dbfe906e270a88e829e6beb79c97 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Fri, 27 Oct 2023 09:27:12 +

[clang] 6c3bc91 - [clang-format][NFC] Remove more extraneous newlines in unit tests

2023-10-27 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-27T02:22:36-07:00 New Revision: 6c3bc910588f962e49470098ccc3b13c29cae493 URL: https://github.com/llvm/llvm-project/commit/6c3bc910588f962e49470098ccc3b13c29cae493 DIFF: https://github.com/llvm/llvm-project/commit/6c3bc910588f962e49470098ccc3b13c29cae493.diff

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 1ae7edddc79a0e96fd4b142d09b0752aa3d9ff85 Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH] use: create instead of protected Constructor handle: expected ---

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

2023-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad Smith (brad0) Changes Same as 12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d --- Full diff: https://github.com/llvm/llvm-project/pull/70434.diff 5 Files Affected: - (modified) clang/lib/Driver/ToolChains/DragonFly.cpp (+3) - (modified)

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70434 Same as 12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d >From 0c21090272eb3e1d6477585ef223413dc627a451 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 05:13:59 -0400 Subject: [PATCH] [Driver] Silence

[clang] [clang]set invalid for lambda which missing capture `this` (PR #70432)

2023-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/70432 It can suppression further crash. Fixes: #67687 >From c12aeb6f2a83b9cb3c3815e72d57638cf7de43a0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 27 Oct 2023 16:51:59 +0800 Subject: [PATCH] WIP fix

[clang-tools-extra] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-27 Thread via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/68413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread via cfe-commits
philnik777 wrote: Why does the proxy not satisfy `weakly_incrementable`? Is it maybe just missing some member functions? https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread via cfe-commits
philnik777 wrote: Why does the proxy not satisfy `weakly_incrementable`? Is it maybe just missing some member functions? https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 converted_to_draft https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain (PR #70429)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70429 None >From d8a4aecf5a22382fe57f654616fa59358477d9a4 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 04:53:19 -0400 Subject: [PATCH] [Driver] Handle Flang in same manner between Gnu and

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-27 Thread Owen Pan via cfe-commits
owenca wrote: IMO, the new behavior is consistent with the [documentation](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#columnlimit) for `ColumnLimt: 0`. https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kohei Asano (khei4) Changes This patch fixes the code example on CommonOptionParser on https://intel.github.io/llvm-docs/clang/LibTooling.html CommonOptionParser's constructor is protected and we can use `CommonOptionParser::create`

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 created https://github.com/llvm/llvm-project/pull/70427 This patch fixes the code example on CommonOptionParser on https://intel.github.io/llvm-docs/clang/LibTooling.html CommonOptionParser's constructor is protected and we can use `CommonOptionParser::create` instead

[clang] e9a7876 - [C++20] [Modules] Chose BMI from for module m with the last

2023-10-27 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-10-27T16:52:21+08:00 New Revision: e9a7876c2c81423f2289aa85eeac32d7a55cd3c8 URL: https://github.com/llvm/llvm-project/commit/e9a7876c2c81423f2289aa85eeac32d7a55cd3c8 DIFF: https://github.com/llvm/llvm-project/commit/e9a7876c2c81423f2289aa85eeac32d7a55cd3c8.diff

[clang] e64e478 - [clang][Interp][NFC] Rename a parameter

2023-10-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-27T10:43:35+02:00 New Revision: e64e4784ee1c3ed9bb06458e9c427542927224ab URL: https://github.com/llvm/llvm-project/commit/e64e4784ee1c3ed9bb06458e9c427542927224ab DIFF: https://github.com/llvm/llvm-project/commit/e64e4784ee1c3ed9bb06458e9c427542927224ab.diff

[clang] 051fade - [clang][Interp][NFC] Use delegate() address-of operators

2023-10-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-27T10:43:35+02:00 New Revision: 051fade10f03515b0980c58541fe4c28220e0e67 URL: https://github.com/llvm/llvm-project/commit/051fade10f03515b0980c58541fe4c28220e0e67 DIFF: https://github.com/llvm/llvm-project/commit/051fade10f03515b0980c58541fe4c28220e0e67.diff

[clang] [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (PR #69817)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c149ff3 - [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (#69817)

2023-10-27 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-27T04:43:19-04:00 New Revision: c149ff3d372a70e7d9de838a1ff0357394b8d017 URL: https://github.com/llvm/llvm-project/commit/c149ff3d372a70e7d9de838a1ff0357394b8d017 DIFF: https://github.com/llvm/llvm-project/commit/c149ff3d372a70e7d9de838a1ff0357394b8d017.diff

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-27 Thread Balázs Kéri via cfe-commits
https://github.com/balazske commented: The fix looks good but the formatting of the test code could be better, like in the other tests. https://github.com/llvm/llvm-project/pull/68774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-27 Thread Balázs Kéri via cfe-commits
@@ -1373,6 +1373,40 @@ TEST_P(ASTImporterOptionSpecificTestBase, ImportCorrectTemplatedDecl) { ASSERT_EQ(ToTemplated1, ToTemplated); } +TEST_P(ASTImporterOptionSpecificTestBase, + ImportTemplateSpecializationStaticMember) { + auto FromCode = R"( + template

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-27 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/68774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-10-27 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu accepted this revision. zixuan-wu added a comment. This revision is now accepted and ready to land. LGTM if nobody objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401

[clang] [ASAN] For Asan instrumented global, emit two symbols, one with actual size and other with instrumented size. (PR #70166)

2023-10-27 Thread Mitch Phillips via cfe-commits
hctim wrote: I talked with some folks internally and we came to the consensus that this'll almost certainly break some debugging tools and such, it probably won't effect the runtime of binaries, but I wouldn't say that this is a super confidence-inspiring thing to do. > AMD language runtimes

[clang] Disable memtag sanitization for global fnptrs going into .ctors (PR #70186)

2023-10-27 Thread Mitch Phillips via cfe-commits
hctim wrote: (friendly ping @eugenis / @vitalybuka) https://github.com/llvm/llvm-project/pull/70186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { cor3ntin wrote: @erichkeane @AaronBallman wdyt?

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-10-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,816 @@ +// RUN: %clang_cc1 -verify -std=c++2a -fsyntax-only

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { cor3ntin wrote: I had a chat with @Endilll offline.

[clang] [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (PR #69817)

2023-10-27 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/69817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: That's a good point. I'm not opposed to wrap this attribute if we must. I'd like to hear from @AaronBallman on this matter. https://github.com/llvm/llvm-project/pull/70349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver][NFC] Make use of final (PR #70416)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70416 None >From 6247344956c34137ced2ae89be1154bd31173d46 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 02:22:21 -0400 Subject: [PATCH] [Driver][NFC] Make use of final ---

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread Timm Baeder via cfe-commits
tbaederr wrote: Sure but clang 16 will emit a warning for them: https://godbolt.org/z/jnsc4336G - are we passing `-Wno-unknown-attributes` to the build? https://github.com/llvm/llvm-project/pull/70349 ___ cfe-commits mailing list

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @tbaederr As highlighted in https://github.com/llvm/llvm-project/pull/69104, this attribute doesn't change semantics of the program, so it's safe to ignore. https://github.com/llvm/llvm-project/pull/70349 ___ cfe-commits mailing list

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread Timm Baeder via cfe-commits
tbaederr wrote: Since this is done unconditionally, doesn't this mean we now need an unreleased clang to compile? Or are `[[clang::]]` attributes just ignored if they are unknown? https://github.com/llvm/llvm-project/pull/70349 ___ cfe-commits

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread Vlad Serebrennikov via cfe-commits
@@ -20,7 +20,7 @@ namespace clang { /// Describes the different kinds of linkage /// (C++ [basic.link], C99 6.2.2) that an entity may have. -enum Linkage : unsigned char { +enum Linkage : unsigned { Endilll wrote: This case is similar to `TypeDependence` we

[clang] [RISCV] Support Xsfvfnrclipxfqf extensions (PR #68297)

2023-10-27 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-27 Thread via cfe-commits
@@ -751,13 +751,8 @@ class Preprocessor { std::unique_ptr CurTokenLexer; /// The kind of lexer we're currently working with. - enum CurLexerKind { -CLK_Lexer, -CLK_TokenLexer, -CLK_CachingLexer, -CLK_DependencyDirectivesLexer, -

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-27 Thread via cfe-commits
https://github.com/cor3ntin commented: This is excellent! I made some naming suggestion. Now that we don't have an enum i think it is clearer to drop the "kind" terminology https://github.com/llvm/llvm-project/pull/70381 ___ cfe-commits mailing list

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-27 Thread via cfe-commits
@@ -643,23 +643,7 @@ void Preprocessor::SkipTokensWhileUsingPCH() { while (true) { bool InPredefines = (CurLexer && CurLexer->getFileID() == getPredefinesFileID()); -switch (CurLexerKind) { -case CLK_Lexer: - CurLexer->Lex(Tok); - break; -

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-27 Thread via cfe-commits
@@ -751,13 +751,8 @@ class Preprocessor { std::unique_ptr CurTokenLexer; /// The kind of lexer we're currently working with. - enum CurLexerKind { -CLK_Lexer, -CLK_TokenLexer, -CLK_CachingLexer, -CLK_DependencyDirectivesLexer, -

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-27 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/70381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4