[clang] ce800c2 - Fix clang/test/Sema/code_align.c for Arm v7 #70762

2023-11-21 Thread Muhammad Omair Javaid via cfe-commits
Author: Muhammad Omair Javaid Date: 2023-11-21T13:00:52+05:00 New Revision: ce800c27768400aa3efba882bcac120f2bdd6eeb URL: https://github.com/llvm/llvm-project/commit/ce800c27768400aa3efba882bcac120f2bdd6eeb DIFF:

[clang] [llvm] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-21 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. Thanks. LGTM https://github.com/llvm/llvm-project/pull/71545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

2023-11-21 Thread via cfe-commits
martinboehme wrote: I'm intentionally not responding to comments in the code for now -- wanted to wrap up this high-level discussion first. > Overall seemed good (mostly just piping), but I think we need more > explanation (on the review thread and somewhere appropriate in the code) of >

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/72974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/72974 >From 012096290352438668d8f4bb7a97179952a87a3a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 18 Nov 2023 00:20:05 + Subject: [PATCH] [clang][DebugInfo] Create evaluateConstantInitializer helper

[llvm] [clang] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

2023-11-21 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/72849 >From 3b1d34afb1ae365f48716ae5eb9202a474adf234 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 20 Nov 2023 10:49:27 + Subject: [PATCH 1/2] [AArch64][SME2] Add ldr_zt, str_zt builtins and

[clang] [Driver] Default Generic_GCC aarch64_be to -fasynchronous-unwind-tables (PR #72971)

2023-11-21 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 created https://github.com/llvm/llvm-project/pull/72971 This patch defaults Generic_GCC aarch64_be to use -fasynchronous-unwind-tables and ensures consistent behavior with aarch64 little endian. >From f8adcd49a4627926ac8009c595c6b0103589e600 Mon Sep 17

[llvm] [clang] [clang-tools-extra] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

2023-11-21 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/69469 From 0fdc57b49002afd8aa54043837ee4155688b4c36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Tue, 17 Oct 2023 11:51:27 +0200 Subject: [PATCH 1/2] [clang][Analyzer] Move checker

[clang] [llvm] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-21 Thread via cfe-commits
https://github.com/simpal01 reopened https://github.com/llvm/llvm-project/pull/71545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
@@ -7581,3 +7580,59 @@ alignment boundary. Its value must be a power of 2, between 1 and 4096 }]; } + +def CoroLifetimeBoundDoc : Documentation { + let Category = DocCatDecl; + let Content = [{ +The ``[[clang::coro_lifetimebound]]`` is a class attribute which can be

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. Thanks, looks good from my side. Some nits. https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
@@ -7580,10 +7580,15 @@ static void visitLifetimeBoundArguments(IndirectLocalPath , Expr *Call, if (ObjectArg && implicitObjectParamIsLifetimeBound(Callee)) VisitLifetimeBoundArg(Callee, ObjectArg); + bool checkCoroCall = false; hokein wrote: nit:

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
@@ -0,0 +1,120 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + +template struct

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
@@ -7581,3 +7580,59 @@ alignment boundary. Its value must be a power of 2, between 1 and 4096 }]; } + +def CoroLifetimeBoundDoc : Documentation { + let Category = DocCatDecl; + let Content = [{ +The ``[[clang::coro_lifetimebound]]`` is a class attribute which can be

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -19,7 +19,7 @@ TWEAK_TEST(DefineOutline); TEST_F(DefineOutlineTest, TriggersOnFunctionDecl) { FileName = "Test.cpp"; - // Not available unless in a header file. + // Not available for free function unless in a header file. kadircet wrote: can you add

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -349,6 +349,44 @@ TEST_F(DefineOutlineTest, ApplyTest) { } } +TEST_F(DefineOutlineTest, InCppFile) { + FileName = "Test.cpp"; + + struct { +llvm::StringRef Test; +llvm::StringRef ExpectedSource; + } Cases[] = { + // Member function with some adornments +

[clang] [llvm] [SVE2.1][Clang][LLVM]Add 128bits builtin in Clang and LLVM intrinisc (PR #71930)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto closed https://github.com/llvm/llvm-project/pull/71930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-11-21 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov approved this pull request. LGTM, cheers! Check the commit message, a double colon in `Co-authored-by::`. https://github.com/llvm/llvm-project/pull/70362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/72974 This patch extracts the logic to evaluate a C++ static data-member's constant initializer such that it can be used by an upcoming patch. It also makes the check for whether we are dealing with a constant

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-11-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to this commit. I think Zequan is investigating: https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] [C++20] [Modules] Introduce a tool 'clang-named-modules-querier' and two plugins 'ClangGetUsedFilesFromModulesPlugin' and 'ClangGetDeclsInModulesPlugin' (PR #72956)

2023-11-21 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/72956 >From 05453bc0da214ad69ab94d901c997c61fae86ab6 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 17 Nov 2023 14:57:02 +0800 Subject: [PATCH 1/2] [C++20] [Modules] Introduce a tool

[llvm] [clang-tools-extra] [clang] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

2023-11-21 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/69469 From 0fdc57b49002afd8aa54043837ee4155688b4c36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Tue, 17 Oct 2023 11:51:27 +0200 Subject: [PATCH] [clang][Analyzer] Move checker

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
@@ -7581,3 +7580,59 @@ alignment boundary. Its value must be a power of 2, between 1 and 4096 }]; } + +def CoroLifetimeBoundDoc : Documentation { + let Category = DocCatDecl; + let Content = [{ +The ``[[clang::coro_lifetimebound]]`` is a class attribute which can be

[clang-tools-extra] [clang] [llvm] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-11-21 Thread via cfe-commits
CarolineConcatto wrote: @momchil-velikov is the changes good? https://github.com/llvm/llvm-project/pull/70362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72851 >From 164bf1e94ec05e50be05d085ce2a4381711df11b Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH 1/7] Introduce [[clang::coro_lifetimebound]] (cherry picked from

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Michael Buch (Michael137) Changes This patch extracts the logic to evaluate a C++ static data-member's constant initializer such that it can be used by an upcoming patch. It also makes the check for whether we are dealing with a

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes This patch extracts the logic to evaluate a C++ static data-member's constant initializer such that it can be used by an upcoming patch. It also makes the check for whether we are dealing with a constant

[llvm] [clang-tools-extra] [BOLT][NFC] Extract a function for dump MCInst (PR #67225)

2023-11-21 Thread via cfe-commits
https://github.com/llongint updated https://github.com/llvm/llvm-project/pull/67225 >From 3ab91ae89c792b2034f47dd3a74992d912db29d7 Mon Sep 17 00:00:00 2001 From: hezuoqiang Date: Sat, 23 Sep 2023 13:23:16 +0800 Subject: [PATCH] [BOLT][NFC] Extract a function for dump MCInst. Extract a

[clang] [AArch64][SME2] Add FCLAMP, CNTP builtins for SME2 (PR #72487)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto commented: I would imagine you need to update the tests to add the arm_streaming into the functions. Is this correct? Or it is not needed anymore? https://github.com/llvm/llvm-project/pull/72487 ___ cfe-commits

[clang] Refactor ASTContext::getDeclAlign() (NFC) (PR #72977)

2023-11-21 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7f740be4acddd8acf46796229c46117b735a9be8 90938183b35284cff65d100f3cb5284b816f28cc --

[clang] Refactor ASTContext::getDeclAlign() (NFC) (PR #72977)

2023-11-21 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 updated https://github.com/llvm/llvm-project/pull/72977 >From 90938183b35284cff65d100f3cb5284b816f28cc Mon Sep 17 00:00:00 2001 From: Jonas Paulsson Date: Tue, 21 Nov 2023 12:10:03 +0100 Subject: [PATCH 1/2] Refactor ASTContext::getDeclAlign() (NFC) ---

[clang] [C++20] [Modules] Introduce a tool 'clang-named-modules-querier' and two plugins 'ClangGetUsedFilesFromModulesPlugin' and 'ClangGetDeclsInModulesPlugin' (PR #72956)

2023-11-21 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/72956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,120 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + +template struct

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72851 >From 164bf1e94ec05e50be05d085ce2a4381711df11b Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH 1/9] Introduce [[clang::coro_lifetimebound]] (cherry picked from

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-21 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/72974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

2023-11-21 Thread via cfe-commits
@@ -311,7 +318,10 @@ computeBlockInputState(const CFGBlock , AnalysisContext ) { } } - JoinedStateBuilder Builder(AC); + // When performing the join, only retain state for those expressions that are + // consumed by this block. This avoids performing joins and

[clang-tools-extra] [flang] [mlir] [clang] [lld] [llvm] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: This was implemented in https://github.com/llvm/llvm-project/pull/72851 and https://github.com/llvm/llvm-project/pull/71945. Closing this. https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list

[llvm] [clang-tools-extra] [clang] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

2023-11-21 Thread via cfe-commits
HaohaiWen wrote: > For my money this was merged prematurely. There are still outstanding > concerns about whether this transform is desirable, as well there is an > outstanding comment about the implementation itself. I'm fairly agnostic > about this code getting in, but I think it should be

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-21 Thread via cfe-commits
https://github.com/simpal01 closed https://github.com/llvm/llvm-project/pull/71545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-21 Thread via cfe-commits
simpal01 wrote: > Hi. From what I can tell the logic looks OK. We add the archextension in > places we expect to now? > > It is generally considered best practice to not have clang test that run the > entire pass pipeline. In this case it looks like it's trying to SLP vectorize > the code to

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -499,17 +473,64 @@ class DefineOutline : public Tweak { HeaderUpdates = HeaderUpdates.merge(*DelInline); } -auto HeaderFE = Effect::fileEdit(SM, SM.getMainFileID(), HeaderUpdates); -if (!HeaderFE) - return HeaderFE.takeError(); - -

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -499,17 +473,64 @@ class DefineOutline : public Tweak { HeaderUpdates = HeaderUpdates.merge(*DelInline); } -auto HeaderFE = Effect::fileEdit(SM, SM.getMainFileID(), HeaderUpdates); -if (!HeaderFE) - return HeaderFE.takeError(); - -

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -349,6 +349,44 @@ TEST_F(DefineOutlineTest, ApplyTest) { } } +TEST_F(DefineOutlineTest, InCppFile) { + FileName = "Test.cpp"; + + struct { +llvm::StringRef Test; +llvm::StringRef ExpectedSource; + } Cases[] = { + // Member function with some adornments +

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/69704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet commented: thanks, LG in general just some small adjustments https://github.com/llvm/llvm-project/pull/69704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -435,14 +407,17 @@ class DefineOutline : public Tweak { if (MD->getParent()->isTemplated()) return false; - // The refactoring is meaningless for unnamed classes and definitions - // within unnamed namespaces. + // The refactoring is

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread kadir çetinkaya via cfe-commits
@@ -435,14 +407,17 @@ class DefineOutline : public Tweak { if (MD->getParent()->isTemplated()) return false; - // The refactoring is meaningless for unnamed classes and definitions - // within unnamed namespaces. + // The refactoring is

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72851 >From 164bf1e94ec05e50be05d085ce2a4381711df11b Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH 1/8] Introduce [[clang::coro_lifetimebound]] (cherry picked from

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

2023-11-21 Thread Michael Buch via cfe-commits
Michael137 wrote: I extracted the parts that are clean-ups/bugfixes into a new PR: https://github.com/llvm/llvm-project/pull/72974 https://github.com/llvm/llvm-project/pull/72730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/72850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/72850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. LGTM Momchil! Thank you for the work. I left a comments in the tests for gather and scatter. But it should not block the patch to be merged. I just think we have more tests than needed.

[clang] [llvm] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

2023-11-21 Thread via cfe-commits
@@ -0,0 +1,248 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3 +; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve2p1,+bf16 < %s | FileCheck %s + +declare void @llvm.aarch64.sve.st1q.scatter.scalar.offset.nxv2i64.nxv2i64(,

[clang] [llvm] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

2023-11-21 Thread via cfe-commits
@@ -0,0 +1,249 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3 +; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve2p1,+bf16 < %s | FileCheck %s + +declare @llvm.aarch64.sve.ld1q.gather.scalar.offset.nxv2i64.nxv2i64(, ,

[llvm] [clang] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/71290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [InstCombine] Do not simplify lshr/shl arg if it is part of fshl rotate pattern. (PR #66115)

2023-11-21 Thread via cfe-commits
https://github.com/quic-eikansh updated https://github.com/llvm/llvm-project/pull/66115 >From 60b7c5c4250c69e8bda124649baa25d3c314e0ec Mon Sep 17 00:00:00 2001 From: Eikansh Gupta Date: Tue, 12 Sep 2023 05:14:43 -0700 Subject: [PATCH] [InstCombine] Do not simplify lshr/shl arg if it is part of

[clang-tools-extra] [flang] [mlir] [clang] [lld] [llvm] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72954 >From c863646669d0b2b54e1c1c353b063a8209730528 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Tue, 21 Nov 2023 06:51:48 +0100 Subject: [PATCH 1/6] [clangtidy]Allow safe suspensions in coroutine-hostile-raii

[lld] [flang] [mlir] [llvm] [clang-tools-extra] [clang] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 ready_for_review https://github.com/llvm/llvm-project/pull/72954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [flang] [mlir] [llvm] [clang-tools-extra] [clang] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Utkarsh Saxena (usx95) Changes Certain `awaitable` types could be safe to `co_await` on even when we have suspension-hostile RAII objects in scope. This PR adds a way for users to mark such safe `awaitable` and silence false

[llvm] [libcxx] [clang-tools-extra] [libcxxabi] [mlir] [compiler-rt] [clang] [libunwind] [lld] [libc] [lldb] [flang] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-21 Thread Shahid Iqbal via cfe-commits
https://github.com/shahidiqbal13 updated https://github.com/llvm/llvm-project/pull/72654 >From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001 From: Shahid Iqbal Date: Thu, 16 Nov 2023 11:26:43 -0500 Subject: [PATCH 1/7] TESTING infra --- clang/NOTES.txt | 2 ++ 1 file

[clang] [Driver] Default Generic_GCC aarch64_be to -fasynchronous-unwind-tables (PR #72971)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: dong jianqiang (dongjianqiang2) Changes This patch defaults Generic_GCC aarch64_be to use -fasynchronous-unwind-tables and ensures consistent behavior with aarch64 little endian. --- Full diff:

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-21 Thread via cfe-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/71545 >From e2b6fa1cb088f2c3cf05a38959a3f3d34eda92c5 Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Tue, 7 Nov 2023 13:05:08 + Subject: [PATCH 1/6] [ARM] .fpu equals fpv5-d16 disables floating point MVE

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

2023-11-21 Thread Haojian Wu via cfe-commits
@@ -0,0 +1,120 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + +template struct

[lld] [mlir] [llvm] [clang] [flang] [clang-tools-extra] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Maybe instead of "coro_raii_safe_suspend" we should just use an list of "allowed types" ? https://github.com/llvm/llvm-project/pull/72954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Refactor ASTContext::getDeclAlign() (NFC) (PR #72977)

2023-11-21 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/72977 @efriedma-quic @rjmccall While working on this (with the other patch: 72886), I found this refactoring at the top of the function which I like. What do you think? >From

[clang] [AArch64][SME2] Add PEXT, PSEL builtins for SME2 (PR #72827)

2023-11-21 Thread via cfe-commits
@@ -5,6 +5,11 @@ // RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64-none-linux-gnu \ // RUN: -target-feature +sve2p1 -S -O1 -Werror -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefix=CPP-CHECK // RUN: %clang_cc1 -fclang-abi-compat=latest -triple

[clang] Refactor ASTContext::getDeclAlign() (NFC) (PR #72977)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jonas Paulsson (JonPsson1) Changes @efriedma-quic @rjmccall While working on this (with the other patch: 72886), I found this refactoring at the top of the function which I like. What do you think? --- Full diff:

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

2023-11-21 Thread Michael Buch via cfe-commits
Michael137 wrote: > > My understanding was that the DIExpression parameter to > > DIGlobalVariableExpression was empty for global variables with locations. > > So the patch just encodes the constant into that expression if it's > > otherwise empty. > > I think in theory it can be non-empty

[clang] [AVR] make the AVR ABI Swift compatible (PR #72298)

2023-11-21 Thread Carl Peto via cfe-commits
carlos4242 wrote: > This is less about the implementation weeds of LLVM and more about the actual > details of your calling convention — the decisions about how arguments and > results are passed that are ultimately downstream of the choices made here. > Mostly, I'm encouraging you as a

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-11-21 Thread Balazs Benics via cfe-commits
=?utf-8?q?G=C3=A1bor?= Spaits,Gabor Spaits ,Gabor Spaits ,Gabor Spaits Message-ID: In-Reply-To: steakhal wrote: Yes, why not.. https://github.com/llvm/llvm-project/pull/66481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f4418f8 - [SystemZ][z/OS] Replace unconventional characters that are not within the ASCII range (#72906)

2023-11-21 Thread via cfe-commits
Author: Abhina Sree Date: 2023-11-21T07:51:17-05:00 New Revision: f4418f8813ee15d13217ab0dd995a2a519d9c688 URL: https://github.com/llvm/llvm-project/commit/f4418f8813ee15d13217ab0dd995a2a519d9c688 DIFF: https://github.com/llvm/llvm-project/commit/f4418f8813ee15d13217ab0dd995a2a519d9c688.diff

[clang] [SystemZ][z/OS] Replace unconventional characters that are not within the ASCII range (PR #72906)

2023-11-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/72906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [flang] [flang ]GETLOG runtime and extension implementation: get login username (PR #70917)

2023-11-21 Thread Yi Wu via cfe-commits
yi-wu-arm wrote: Hello @klausler, could you please share your thoughts or comments on this patch, particularly with regard to the Windows side? Thanks in advance. https://github.com/llvm/llvm-project/pull/70917 ___ cfe-commits mailing list

[clang] [SystemZ][z/OS] Replace unconventional characters that are not within the ASCII range (PR #72906)

2023-11-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/72906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Replace unconventional characters that are not within the ASCII range (PR #72906)

2023-11-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/72906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-21 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/69704 >From 27af98b5a9b71255b2873f25943ed23e42946b27 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 19 Oct 2023 17:51:11 +0200 Subject: [PATCH] [clangd] Allow "move function body out-of-line" in

[clang] [llvm] [AMDGPU] Improve selection of ballot.i64 intrinsic in wave32 mode. (PR #71556)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -2314,9 +2314,8 @@ void AMDGPUDAGToDAGISel::SelectBRCOND(SDNode *N) { SDValue VCMP = Cond->getOperand(0); auto CC = cast(Cond->getOperand(2))->get(); auto *CRHS = dyn_cast(Cond->getOperand(1)); -if ((CC == ISD::SETEQ || CC == ISD::SETNE) && CRHS &&

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
@@ -52,27 +52,41 @@ AST_MATCHER_P(Stmt, forEachPrevStmt, ast_matchers::internal::Matcher, } return IsHostile; } + +// Matches the expression awaited by the `co_await`. +AST_MATCHER_P(CoawaitExpr, awaiatable, ast_matchers::internal::Matcher, + InnerMatcher) {

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64][SVE2.1] Add intrinsics for quadword loads/stores with unscaled offset (PR #70474)

2023-11-21 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/70474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer]:fix valistChecker false negative in windows platform (PR #72951)

2023-11-21 Thread via cfe-commits
https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/72951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][SVE2.1] Add intrinsics for quadword loads/stores with unscaled offset (PR #70474)

2023-11-21 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/70474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2023-11-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/72892 >From b5360dd44bd5d8f10287e0a3641b0846e051a5c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 20 Nov 2023 11:53:40 +0100 Subject:

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2023-11-21 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/72892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 72d3bf2 - [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (#69469)

2023-11-21 Thread via cfe-commits
Author: Balázs Kéri Date: 2023-11-21T13:34:03+01:00 New Revision: 72d3bf2b87ff7fab1a189d76f516bc03eac3271d URL: https://github.com/llvm/llvm-project/commit/72d3bf2b87ff7fab1a189d76f516bc03eac3271d DIFF: https://github.com/llvm/llvm-project/commit/72d3bf2b87ff7fab1a189d76f516bc03eac3271d.diff

[clang] [clang-tools-extra] [llvm] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

2023-11-21 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/69469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_rotate{right, left} (PR #72984)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Tests are from test/Sema/constant-builtins-2.c again. --- Full diff: https://github.com/llvm/llvm-project/pull/72984.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/InterpBuiltin.cpp (+49) -

[clang] [clang][Interp] Implement __builtin_rotate{right, left} (PR #72984)

2023-11-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/72984 Tests are from test/Sema/constant-builtins-2.c again. >From efd400e2f928cfa2bd062c549a02bcbed5c8f95e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 21 Nov 2023 13:44:07 +0100 Subject:

[clang] [clang][dataflow] Remove deprecated synonyms from `Environment`. (PR #72987)

2023-11-21 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/72987 None >From 16434d49d87b3da8778de5ee3a0355eec2e2ba13 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 21 Nov 2023 13:07:23 + Subject: [PATCH] [clang][dataflow] Remove deprecated synonyms from

[clang] [clang][dataflow] Remove deprecated synonyms from `Environment`. (PR #72987)

2023-11-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/72987.diff 1 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h (-6) ``diff diff

[clang-tools-extra] [clang] [llvm] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

2023-11-21 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/70362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -1708,6 +1710,13 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction , } ++Iter; +if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) { + auto builder = jayfoad wrote: Upper case B for Builder.

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -388,6 +388,8 @@ class SIInsertWaitcnts : public MachineFunctionPass { // message. DenseSet ReleaseVGPRInsts; + // bool insertWaitcntAfterMemOp(MachineFunction ); jayfoad wrote: Remove all the unused code, don't just comment it out.

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -1708,6 +1710,13 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction , } ++Iter; +if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) { + auto builder = + BuildMI(Block, Iter, DebugLoc(), TII->get(AMDGPU::S_WAITCNT)) +

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-21 Thread Jay Foad via cfe-commits
@@ -0,0 +1,222 @@ +; Testing the -amdgpu-precise-memory-op option +; COM: llc -mtriple=amdgcn -mcpu=hawaii -mattr=+amdgpu-precise-memory-op -verify-machineinstrs < %s | FileCheck %s -check-prefixes=GFX7 jayfoad wrote: What is COM: ?

[lldb] [libcxx] [clang] [clang-tools-extra] [flang] [compiler-rt] [libc] [llvm] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-21 Thread via cfe-commits
@@ -10,9 +10,26 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "terminator.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h" +#include

[clang] [llvm] [clang-tools-extra] [flang] [lld] [mlir] [clangtidy] Allow safe suspensions in coroutine-hostile-raii check (PR #72954)

2023-11-21 Thread Piotr Zegar via cfe-commits
@@ -52,27 +52,41 @@ AST_MATCHER_P(Stmt, forEachPrevStmt, ast_matchers::internal::Matcher, } return IsHostile; } + +// Matches the expression awaited by the `co_await`. +AST_MATCHER_P(CoawaitExpr, awaiatable, ast_matchers::internal::Matcher, + InnerMatcher) {

  1   2   3   4   >