[clang] [Clang] Remove NetBSD workaround for FP eval method with older versions (PR #74025)

2023-11-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: Brad Smith (brad0) Changes NetBSD 7.x is long EoL. Make 8.x the minimum. --- Full diff: https://github.com/llvm/llvm-project/pull/74025.diff 2 Files Affected: - (modified) clang/lib/Basic/Targets/X86.h

[libcxx] [compiler-rt] [openmp] [libc] [lld] [libunwind] [clang-tools-extra] [clang] [libcxxabi] [llvm] [mlir] [lldb] [flang] Fix Logical expression used for merged conditional if in FlattenCFG pass (

2023-11-30 Thread via cfe-commits
https://github.com/mahtohappy updated https://github.com/llvm/llvm-project/pull/72522 Sorry, this diff is unavailable. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2023-11-30 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: Is there a separate PR open for "Add vector processing support to AMDGPU printf"? I think it's easiest to move this part forward first https://github.com/llvm/llvm-project/pull/72556 ___ cfe-commits mailing list

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-11-30 Thread Petr Hosek via cfe-commits
@@ -138,10 +164,34 @@ static const VersionTuple MultilibVersionCurrent(1, 0); struct MultilibSerialization { std::string Dir; std::vector Flags; + std::string Group; +}; + +struct MultilibGroupSerialization { + /* + * Future directions: + * + * If it's needed in

[clang-tools-extra] [clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-30 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Unless other comments brought up, I'll plan on merging this on Monday the 4th. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-11-30 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove NetBSD workaround for FP eval method with older versions (PR #74025)

2023-11-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74025 >From 00b44ae89a46af7159087789c25ba5c4942eca6f Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 30 Nov 2023 20:50:01 -0500 Subject: [PATCH] [Clang] Remove NetBSD/i386 workaround for FP eval method with older

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

2023-11-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/74025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Collapse fast unaligned access into a single feature [nfc-ish] (PR #73971)

2023-11-30 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM with nit. https://github.com/llvm/llvm-project/pull/73971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Collapse fast unaligned access into a single feature [nfc-ish] (PR #73971)

2023-11-30 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp edited https://github.com/llvm/llvm-project/pull/73971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Collapse fast unaligned access into a single feature [nfc-ish] (PR #73971)

2023-11-30 Thread Wang Pengcheng via cfe-commits
@@ -171,18 +171,12 @@ void riscv::getRISCVTargetFeatures(const Driver , const llvm::Triple , Features.push_back("-save-restore"); // -mno-unaligned-access is default, unless -munaligned-access is specified. - bool HasV = llvm::is_contained(Features, "+zve32x"); if

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2023-11-30 Thread Brad Smith via cfe-commits
brad0 wrote: @MaskRay Ping. https://github.com/llvm/llvm-project/pull/71157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

2023-11-30 Thread Matt Arsenault via cfe-commits
@@ -406,5 +410,9 @@ TARGET_BUILTIN(__builtin_amdgcn_cvt_pk_fp8_f32, "iffiIb", "nc", "fp8-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf8_f32, "ifiiIi", "nc", "fp8-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_fp8_f32, "ifiiIi", "nc", "fp8-insts") +// OpenCL

[clang] [openmp] [OpenMP] return empty stmt for `nothing` (PR #74042)

2023-11-30 Thread Sandeep Kosuri via cfe-commits
https://github.com/sandeepkosuri created https://github.com/llvm/llvm-project/pull/74042 - `nothing` directive was effecting the `if` block structure which it should not. So return an empty statement instead of an error statement while parsing to avoid this. >From

[clang] [openmp] [OpenMP] return empty stmt for `nothing` (PR #74042)

2023-11-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sandeep Kosuri (sandeepkosuri) Changes - `nothing` directive was effecting the `if` block structure which it should not. So return an empty statement instead of an error statement while parsing to avoid this. --- Full diff:

[llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-11-30 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/74008 >From 4cb5b087485124a7f2375fdc018b42a0401e6409 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 30 Nov 2023 15:41:37 -0800 Subject: [PATCH 1/2] [PGO][GlobalValue][LTO]In

[llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-11-30 Thread Mingming Liu via cfe-commits
@@ -246,11 +246,27 @@ std::string InstrProfError::message() const { char InstrProfError::ID = 0; -std::string getPGOFuncName(StringRef RawFuncName, - GlobalValue::LinkageTypes Linkage, +std::string getPGOFuncName(StringRef Name,

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

2023-11-30 Thread Matt Arsenault via cfe-commits
@@ -406,5 +410,9 @@ TARGET_BUILTIN(__builtin_amdgcn_cvt_pk_fp8_f32, "iffiIb", "nc", "fp8-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf8_f32, "ifiiIi", "nc", "fp8-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_fp8_f32, "ifiiIi", "nc", "fp8-insts") +// OpenCL

[clang] Thread safety analysis: Fix a bug in handling temporary constructors (PR #74020)

2023-11-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 668a4a238045e7f300b771f7e4cfa723d8bde237 ecb13c381d99010dc04a2da4e945dfd1132777fd --

[clang] [clang][AMDGPU] precommit test for ballot on Windows (PR #73920)

2023-11-30 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra updated https://github.com/llvm/llvm-project/pull/73920 >From 6b87550b48f5fae5c34304a14a302d37e81a Mon Sep 17 00:00:00 2001 From: Sameer Sahasrabuddhe Date: Fri, 1 Dec 2023 11:49:02 +0530 Subject: [PATCH] [clang][AMDGPU] precommit test for ballot on Windows The

[llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-11-30 Thread Mingming Liu via cfe-commits
@@ -300,12 +316,8 @@ getIRPGONameForGlobalObject(const GlobalObject , GlobalValue::LinkageTypes Linkage, StringRef FileName) { SmallString<64> Name; - if (llvm::GlobalValue::isLocalLinkage(Linkage)) { -

[clang] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-11-30 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,70 @@ +#!/bin/bash + +if [ $# -lt 2 ]; then + echo "Path to clang and llvm-profdata required!" + echo "Usage: update_icall_promotion_inputs.sh /path/to/updated/clang /path/to/updated/llvm-profdata" + exit 1 +else + CLANG=$1 + LLVMPROFDATA=$2 +fi + +# Allows the

[clang] d56e0d0 - clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (#66651)

2023-11-30 Thread via cfe-commits
Author: Romaric Jodin Date: 2023-12-01T16:34:44+09:00 New Revision: d56e0d07cc5ee8e334fd1ad403eef0b1a771384f URL: https://github.com/llvm/llvm-project/commit/d56e0d07cc5ee8e334fd1ad403eef0b1a771384f DIFF: https://github.com/llvm/llvm-project/commit/d56e0d07cc5ee8e334fd1ad403eef0b1a771384f.diff

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-11-30 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/66651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-11-30 Thread Matt Arsenault via cfe-commits
arsenm wrote: > lgtm, but a strict reading of the spec would filter out arbitrary other > ext_vector_types Still think this would be a good follow up https://github.com/llvm/llvm-project/pull/66651 ___ cfe-commits mailing list

[mlir] [clang-tools-extra] [flang] [compiler-rt] [llvm] [clang] [libcxx] [libc] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-11-30 Thread Andres Villegas via cfe-commits
=?utf-8?q?Andr=C3=A9s?= Villegas , =?utf-8?q?Andr=C3=A9s?= Villegas Message-ID: In-Reply-To: avillega wrote: Ping  https://github.com/llvm/llvm-project/pull/73194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Thread safety analysis: Fix a bug in handling temporary constructors (PR #74020)

2023-11-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: Ziqing Luo (ziqingluo-90) Changes The commit 54bfd04846156dbd5e0a6b88f539c3d4569a455f introduces general handling of constructor and destructor calls. Consider a pair of TEMPORARY constructor and

[clang] [Clang] Remove NetBSD workaround for FP eval method with older versions (PR #74025)

2023-11-30 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/74025 NetBSD 7.x is long EoL. Make 8.x the minimum. >From 90064d300b35f1eef7245d907d7f881d149020d1 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 30 Nov 2023 20:50:01 -0500 Subject: [PATCH] [Clang] Remove NetBSD

[llvm] [clang] [mlir] [openmp] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

2023-11-30 Thread via cfe-commits
dhruvachak wrote: After https://github.com/llvm/llvm-project/pull/73864, only reduction kernels may have the additional data submit for the kernel launch environment. If you have an INFO message like in https://github.com/llvm/llvm-project/pull/74030, you will see this additional INFO message

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

2023-11-30 Thread Vikram Hegde via cfe-commits
@@ -406,5 +410,9 @@ TARGET_BUILTIN(__builtin_amdgcn_cvt_pk_fp8_f32, "iffiIb", "nc", "fp8-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_bf8_f32, "ifiiIi", "nc", "fp8-insts") TARGET_BUILTIN(__builtin_amdgcn_cvt_sr_fp8_f32, "ifiiIi", "nc", "fp8-insts") +// OpenCL

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

2023-11-30 Thread Vikram Hegde via cfe-commits
https://github.com/vikramRH edited https://github.com/llvm/llvm-project/pull/72554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-11-30 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/74008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c1ad363 - [clang] Use the materialized temporary's type while creating the APValue (#73355)

2023-11-30 Thread via cfe-commits
Author: Younan Zhang Date: 2023-12-01T15:20:04+08:00 New Revision: c1ad363e6eba308fa94c47374ee98b3c79693a35 URL: https://github.com/llvm/llvm-project/commit/c1ad363e6eba308fa94c47374ee98b3c79693a35 DIFF: https://github.com/llvm/llvm-project/commit/c1ad363e6eba308fa94c47374ee98b3c79693a35.diff

[clang] [clang] Use the materialized temporary's type while creating the APValue (PR #73355)

2023-11-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/73355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [flang] [compiler-rt] [llvm] [clang] [libcxx] [libc] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-11-30 Thread Vitaly Buka via cfe-commits
=?utf-8?q?Andr=C3=A9s?= Villegas , =?utf-8?q?Andr=C3=A9s?= Villegas Message-ID: In-Reply-To: vitalybuka wrote: Make sure to click "re-request review" https://github.com/llvm/llvm-project/pull/73194 ___ cfe-commits mailing list

[clang] [Driver] Add support for -export-dynamic which can match GCC behavior. (PR #72781)

2023-11-30 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 closed https://github.com/llvm/llvm-project/pull/72781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread safety analysis: Fix a bug in handling temporary constructors (PR #74020)

2023-11-30 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 created https://github.com/llvm/llvm-project/pull/74020 The commit 54bfd04846156dbd5e0a6b88f539c3d4569a455f introduces general handling of constructor and destructor calls. Consider a pair of TEMPORARY constructor and destructor calls of a "SCOPED_CAPABILITY"

[libcxx] [libc] [clang-tools-extra] [clang] [llvm] [mlir] [compiler-rt] [flang] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-11-30 Thread Petr Hosek via cfe-commits
=?utf-8?q?Andr=C3=A9s?= Villegas , =?utf-8?q?Andr=C3=A9s?= Villegas Message-ID: In-Reply-To: https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/73194 ___ cfe-commits mailing list

[mlir] [clang-tools-extra] [flang] [compiler-rt] [llvm] [clang] [libcxx] [libc] [sanitizer_symbolizer] RenderContextual elements for symbolizer markup. (PR #73194)

2023-11-30 Thread Vitaly Buka via cfe-commits
=?utf-8?q?Andr=C3=A9s?= Villegas , =?utf-8?q?Andr=C3=A9s?= Villegas Message-ID: In-Reply-To: https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/73194 ___ cfe-commits mailing list

[clang] 5c60e2c - [clang-format][NFC] Reformat source code with clang-format style

2023-11-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-11-30T20:19:30-08:00 New Revision: 5c60e2ce78e79c2d15152e08d9e28fcf3a1d4e51 URL: https://github.com/llvm/llvm-project/commit/5c60e2ce78e79c2d15152e08d9e28fcf3a1d4e51 DIFF: https://github.com/llvm/llvm-project/commit/5c60e2ce78e79c2d15152e08d9e28fcf3a1d4e51.diff

[mlir] [llvm] [lldb] [libcxx] [clang-tools-extra] [libc] [clang] [openmp] [compiler-rt] [libunwind] [flang] [lld] [libcxxabi] Fix Logical expression used for merged conditional if in FlattenCFG pass (

2023-11-30 Thread Matt Arsenault via cfe-commits
@@ -25,13 +25,13 @@ define void @test_not_crash(i32 %in_a) #0 { entry: %cmp0 = icmp eq i32 %in_a, -1 %cmp1 = icmp ne i32 %in_a, 0 - %cond0 = and i1 %cmp0, %cmp1 + %cond0 = or i1 %cmp0, %cmp1 arsenm wrote: Original tests still changing? Needs new copies

[clang] [Tooling] Fix FixedCompilationDatabase with header compile flags (PR #73913)

2023-11-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sam McCall (sam-mccall) Changes Summary: The logic to strip positional args feels very fragile, but it's terribly useful when you want to use a tool on a file and have the exact argv. Today doesn't work with header-parsing actions because

[clang] [AArch64][SME2] Add multi-vector SEL (x2, x4) ACLE builtins & intrinsics (PR #73188)

2023-11-30 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/73188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 14ca8d4 - [clang] Fix a bug with qualified name lookup into current instantiation (#73018)

2023-11-30 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2023-11-30T10:46:35+01:00 New Revision: 14ca8d44d0f44ea5125b3c41b66276c902929a54 URL: https://github.com/llvm/llvm-project/commit/14ca8d44d0f44ea5125b3c41b66276c902929a54 DIFF:

[clang] [llvm] [compiler-rt] [mlir] [clang-tools-extra] [clang] Fix a bug with qualified name lookup into current instantiation (PR #73018)

2023-11-30 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/73018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use current rounding mode for float inc/dec (PR #73770)

2023-11-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/73770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [openmp] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

2023-11-30 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: This was brought up and discussed in the weekly meeting. https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use current rounding mode for float inc/dec (PR #73770)

2023-11-30 Thread Serge Pavlov via cfe-commits
https://github.com/spavloff updated https://github.com/llvm/llvm-project/pull/73770 >From 48ed25acfa5765af607efce2309605b96a09d477 Mon Sep 17 00:00:00 2001 From: Serge Pavlov Date: Wed, 29 Nov 2023 00:53:54 +0700 Subject: [PATCH 1/2] [clang] Use current rounding mode for float inc/dec

[clang] [clang-tools-extra] [llvm] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-30 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Ping. https://github.com/llvm/llvm-project/pull/70829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert updated https://github.com/llvm/llvm-project/pull/73672 >From 96464a9c37a532216e4df6c003aa1a8fcb448637 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Tue, 28 Nov 2023 16:22:32 + Subject: [PATCH 1/2] [AArch64] Warn when calling a NEON builtin in a streaming

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/73672 >From 96464a9c37a532216e4df6c003aa1a8fcb448637 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Tue, 28 Nov 2023 16:22:32 + Subject: [PATCH 1/2] [AArch64] Warn when calling a NEON builtin in a streaming

[llvm] [mlir] [clang-tools-extra] [mlir][benchmark] Fix broken benchmark script (PR #68841)

2023-11-30 Thread Kohei Yamaguchi via cfe-commits
https://github.com/sott0n updated https://github.com/llvm/llvm-project/pull/68841 >From 372847091b7d6a73a78eb9de2685cbca4d62c285 Mon Sep 17 00:00:00 2001 From: Kohei Yamaguchi Date: Thu, 12 Oct 2023 10:16:06 + Subject: [PATCH] [mlir][benchmark] Fix broken benchmark script ---

[clang] [clang] Use current rounding mode for float inc/dec (PR #73770)

2023-11-30 Thread Serge Pavlov via cfe-commits
@@ -4623,10 +4623,12 @@ struct IncDecSubobjectHandler { if (Old) *Old = APValue(Value); APFloat One(Value.getSemantics(), 1); +llvm::RoundingMode RM = +E->getFPFeaturesInEffect(Info.Ctx.getLangOpts()).getRoundingMode(); spavloff wrote:

[clang] [CUDA][HIP] Exclude external variables from constant promotion. (PR #73549)

2023-11-30 Thread Levon Ter-Grigoryan via cfe-commits
@@ -104,3 +106,17 @@ void fun() { (void) b; (void) var_host_only; } + +// NEG-NOT: external_func +extern __global__ void external_func(); +// NEG-NOT: @external_dep +extern void* const external_dep[] = { + (void*)(external_func) +}; +// NEG-NOT: @external_arr

[clang] [Tooling] Fix FixedCompilationDatabase with header compile flags (PR #73913)

2023-11-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6d2dfd37bd50b21ed90427052198bd1f06c761f8 61b0a506142990255f37fc5e52d56805bbba1889 --

[clang] [clang][NFC] Refactor expected directives in C++ DRs 1-99 (PR #73879)

2023-11-30 Thread Vlad Serebrennikov via cfe-commits
@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1 namespace dr7 { // dr7: 3.4 class A { public: ~A(); }; - class B : virtual private A {}; // expected-note 2 {{declared private here}} - class C : public B {} c; // expected-error 2 {{inherited virtual base class 'A' has

[flang] [libc] [clang] [mlir] [llvm] [libcxx] [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction (PR #73618)

2023-11-30 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/73618 >From 84770c82152f027588dd744bbfb91ed55377e007 Mon Sep 17 00:00:00 2001 From: Hristo Hristov Date: Sun, 30 Apr 2023 13:17:20 +0300 Subject: [PATCH 1/4] [libc++][memory] P1132R8: out_ptr - a scalable output

[llvm] [clang] [clang-tools-extra] [STLExtras] Add out-of-line definition of friend operator== for C++20 (PR #72348)

2023-11-30 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72348 >From b29aa485f2a541243d3764f4ed711ccc5a869519 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 15 Nov 2023 06:26:19 +0100 Subject: [PATCH 1/5] [STLExctras] Add out-of-line definition of friend operator==

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-11-30 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: DonatNagyE wrote: @Xazax-hun I added a few testcases that show the current behavior of the checker w.r.t. invalid

[clang-tools-extra] [clang] [llvm] [LoopVectorize] Improve algorithm for hoisting runtime checks (PR #73515)

2023-11-30 Thread David Sherwood via cfe-commits
https://github.com/david-arm updated https://github.com/llvm/llvm-project/pull/73515 >From 30251642f8c208c63f3f3097c337ef0d5bc633b5 Mon Sep 17 00:00:00 2001 From: David Sherwood Date: Mon, 27 Nov 2023 13:43:26 + Subject: [PATCH 1/3] [LoopVectorize] Improve algorithm for hoisting runtime

[clang] [clang-tools-extra] [llvm] [STLExtras] Add out-of-line definition of friend operator== for C++20 (PR #72348)

2023-11-30 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Sent out an [RFC](https://discourse.llvm.org/t/rfc-clang-17-0-6-would-be-minimum-version-to-build-llvm-in-c-20/75345). https://github.com/llvm/llvm-project/pull/72348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
@@ -492,6 +492,56 @@ transferCFGBlock(const CFGBlock , AnalysisContext , return State; } +static Environment initializeEnvironment(const Environment ) { + Environment ResultEnv = InitEnv.fork(); ymand wrote: Why `fork`? The function name implies that the

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. This is amazing! I spent a while searching for changes to join/widen to account for synthetic fields and then realized that (of course!) no special handling is needed! I also love that we now have the hooks we've wanted since the beginning.

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
@@ -73,7 +73,13 @@ class ScalarStorageLocation final : public StorageLocation { /// /// Contains storage locations for all modeled fields of the record (also /// referred to as "children"). The child map is flat, so accessible members of -/// the base class are directly

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
@@ -92,11 +96,39 @@ class DataflowAnalysisContext { /*Logger=*/nullptr}); ~DataflowAnalysisContext(); + /// Sets a callback that returns the names and types of the synthetic fields + /// to add to a `RecordStorageLocation` of a given type. +

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/73860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
@@ -492,6 +492,56 @@ transferCFGBlock(const CFGBlock , AnalysisContext , return State; } +static Environment initializeEnvironment(const Environment ) { ymand wrote: Why not include this function as part of the Environment API? At the least, please

[clang] [clang][dataflow] Add synthetic fields to `RecordStorageLocation` (PR #73860)

2023-11-30 Thread Yitzhak Mandelbaum via cfe-commits
@@ -54,6 +54,18 @@ void clang::dataflow::copyRecord(RecordStorageLocation , } } + for (const auto &[Name, PropLocSrc] : Src.synthetic_fields()) { +if (PropLocSrc->getType()->isRecordType()) { + copyRecord(*cast(PropLocSrc), +

[clang] [clang][NFC] Refactor expected directives in C++ DRs 1-99 (PR #73879)

2023-11-30 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > I could nit on the naming conventions here or there, but I think this overall > is such a vast improvement that I'd rather get 'this', then argue on names in > future files, and let this one lie. @erichkeane Now is the best time to bring those nits on, unless you want

[clang] [clang][NFC] Refactor expected directives in C++ DRs 1-99 (PR #73879)

2023-11-30 Thread Erich Keane via cfe-commits
erichkeane wrote: > > I could nit on the naming conventions here or there, but I think this > > overall is such a vast improvement that I'd rather get 'this', then argue > > on names in future files, and let this one lie. > > @erichkeane Now is the best time to bring those nits on, unless you

[clang] [clang][AMDGPU] fix the return type for ballot (PR #73906)

2023-11-30 Thread Matt Arsenault via cfe-commits
@@ -150,8 +150,8 @@ BUILTIN(__builtin_amdgcn_mqsad_u32_u8, "V4UiWUiUiV4Ui", "nc") // Ballot builtins. //===--===// -TARGET_BUILTIN(__builtin_amdgcn_ballot_w32, "Uib", "nc", "wavefrontsize32")

[clang] [clang][AMDGPU] fix the return type for ballot (PR #73906)

2023-11-30 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,15 @@ +// REQUIRES: amdgpu-registered-target +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -target-cpu gfx900 -x hip -emit-llvm -fcuda-is-device -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -target-cpu gfx900 -x hip -S -fcuda-is-device -o - %s

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1566380e6b47d7876c0f3eaa105097063dbe7cc8 c5c17a44bde23c488141514383b364a434f0e920 --

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/73672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Verifier] Check function attributes related to branch protection (NFC) (PR #70565)

2023-11-30 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/70565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-11-30 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/72107 >From

[clang] [llvm] [InstCombine] Infer disjoint flag on Or instructions. (PR #72912)

2023-11-30 Thread Nikita Popov via cfe-commits
nikic wrote: > Do we do that for other flags already? I based this off Add/Sub wrap flags. Add/Sub are not considered roots for demanded bits simplification, so we can't (reliably) perform this in there. `or` is a simplification root. > Are the KnownBits in SimplifyDemandedBit usable? We have

[clang-tools-extra] [llvm] [clang] [STLExtras] Add out-of-line definition of friend operator== for C++20 (PR #72348)

2023-11-30 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Clang 17.0.6 fixed https://github.com/llvm/llvm-project/issues/68901. This issue was not present in GCC or MSVC [godbolt](https://godbolt.org/z/YEhK37Mqj). I have added release notes. I will also file the RFC and wait for comments. https://github.com/llvm/llvm-project/pull/72348

[compiler-rt] [libc] [lld] [lldb] [clang-tools-extra] [llvm] [flang] [libcxx] [clang] Fix clang to recognize new C23 modifiers %w and %wf when printing (PR #71771)

2023-11-30 Thread Aaron Ballman via cfe-commits
@@ -286,7 +286,33 @@ clang::analyze_format_string::ParseLengthModifier(FormatSpecifier , lmKind = LengthModifier::AsInt3264; break; case 'w': - lmKind = LengthModifier::AsWide; ++I; break; + ++I; + if (I == E) return false; + if (*I == 'f')

[clang] 5234fe3 - [AArch64] Warn when calling a NEON builtin in a streaming function (#73672)

2023-11-30 Thread via cfe-commits
Author: Sam Tebbs Date: 2023-11-30T14:58:34Z New Revision: 5234fe31547737f4fc9d312946cb647968734da1 URL: https://github.com/llvm/llvm-project/commit/5234fe31547737f4fc9d312946cb647968734da1 DIFF: https://github.com/llvm/llvm-project/commit/5234fe31547737f4fc9d312946cb647968734da1.diff LOG:

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 closed https://github.com/llvm/llvm-project/pull/73672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-init: Add a hook... (PR #73921)

2023-11-30 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/73921 >From d729f95270aff076ff11ccb1ef12cfb6dc99a82d Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Thu, 30 Nov 2023 11:08:51 +0100 Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init: Add a

[clang] b04a419 - Minor refactororing of ASTContext::getDeclAlign() (NFC) (#72977)

2023-11-30 Thread via cfe-commits
Author: Jonas Paulsson Date: 2023-11-30T11:12:13+01:00 New Revision: b04a419be1cac5711029b511cfe16e6748a44a4d URL: https://github.com/llvm/llvm-project/commit/b04a419be1cac5711029b511cfe16e6748a44a4d DIFF:

[clang] Refactor ASTContext::getDeclAlign() (NFC) (PR #72977)

2023-11-30 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 closed https://github.com/llvm/llvm-project/pull/72977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libcxx] [clang-tools-extra] [clang] [lld] [mlir] [libc] [libunwind] [libcxxabi] [openmp] [flang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2023-11-30 Thread Mariya Podchishchaeva via cfe-commits
@@ -0,0 +1,86 @@ +// RUN: %clang_cc1 -std=c2x -verify -triple x86_64 -pedantic -Wno-conversion -Wno-constant-conversion %s + +/* WG14 N3018: Full + * The constexpr specifier for object definitions + */ + +#define ULLONG_MAX (__LONG_LONG_MAX__*2ULL+1ULL) +#define UINT_MAX

[clang] [clang][AMDGPU] precommit test for ballot on Windows (PR #73920)

2023-11-30 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra created https://github.com/llvm/llvm-project/pull/73920 The Clang declaration of the wave-64 builtin uses "UL" as the return type, which is interpreted as a 32-bit unsigned integer on Windows. This emits an incorrect LLVM declaration with i32 return type instead of

[clang] [clang][AMDGPU] precommit test for ballot on Windows (PR #73920)

2023-11-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sameer Sahasrabuddhe (ssahasra) Changes The Clang declaration of the wave-64 builtin uses "UL" as the return type, which is interpreted as a 32-bit unsigned integer on Windows. This emits an incorrect LLVM declaration with i32 return

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-init: Add a hook... (PR #73921)

2023-11-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e620035a28d5d957623aa7b4aeda35ab5130e2c9 e251c440b42fe67dee4022d08d05e96d30d6aa02 --

[clang-tools-extra] [clang] [llvm] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

2023-11-30 Thread Michael Buch via cfe-commits
Michael137 wrote: Test fix in flight... https://github.com/llvm/llvm-project/pull/72974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [lldb] [lld] [llvm] [flang] [libcxx] [libc] [clang-tools-extra] [compiler-rt] [openmp] [clang] [libcxxabi] [libunwind] [C23] Implement N3018: The constexpr specifier for object definitions (PR

2023-11-30 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/6] [C23] Implement N3018: The constexpr specifier

[lldb] [lld] [llvm] [flang] [libc] [libcxx] [clang-tools-extra] [compiler-rt] [clang] [libcxxabi] [libunwind] [AMDGPU] Add test for GCNRegPressure tracker bug (PR #73786)

2023-11-30 Thread Piotr Sobczak via cfe-commits
piotrAMD wrote: Rebased and added missing live-throughs. https://github.com/llvm/llvm-project/pull/73786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AMDGPU] Improve selection of ballot.i64 intrinsic in wave32 mode. (PR #71556)

2023-11-30 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: This is ready to be submitted if there're no objections. https://github.com/llvm/llvm-project/pull/71556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-init: Add a hook... (PR #73921)

2023-11-30 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/73921 >From a6bc3d7ef798f95fe6ae758e7a9502851e6d4b12 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Thu, 30 Nov 2023 11:08:51 +0100 Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init: Add a

[clang] [clang] Fix sanitizer bot failure after 14ca8d4 (PR #73928)

2023-11-30 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/73928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b9b37ea - [clang] Fix sanitizer bot failure after 14ca8d4 (#73928)

2023-11-30 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2023-11-30T13:34:11+01:00 New Revision: b9b37ea9493b5c1cadaf9cc8547a4525a6ab3854 URL: https://github.com/llvm/llvm-project/commit/b9b37ea9493b5c1cadaf9cc8547a4525a6ab3854 DIFF:

[compiler-rt] [llvm] [libcxxabi] [clang-tools-extra] [clang] [libunwind] [libc] [flang] [lldb] [libcxx] [lld] [libc] Add more functions in CPP/bit.h (PR #73814)

2023-11-30 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet closed https://github.com/llvm/llvm-project/pull/73814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [STLExtras] Add out-of-line definition of friend operator== for C++20 (PR #72348)

2023-11-30 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I am awaiting C++20 build bots to be updated to 17.0.6. (cc: @ilya-biryukov) > > FYI: @cor3ntin @AaronBallman with this change, clang 17.0.6 would be the > minimum version to build LLVM in C++20 after this change. Would you like me > to announce it somewhere or update

[clang] [analyzer] Switch to PostStmt callbacks in ArrayBoundV2 (PR #72107)

2023-11-30 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/72107 >From ab102e949994a4462382e4c10c0153d61fb00306 Mon Sep 17

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/73672 >From ba3d2c36ee3268b24864466d429a30fec92a69e3 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Tue, 28 Nov 2023 16:22:32 + Subject: [PATCH 1/4] [AArch64] Warn when calling a NEON builtin in a streaming

[clang] [AArch64] Warn when calling a NEON builtin in a streaming function (PR #73672)

2023-11-30 Thread Sam Tebbs via cfe-commits
@@ -2993,6 +2993,47 @@ static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext , llvm_unreachable("Invalid NeonTypeFlag!"); } +enum ArmStreamingType { + ArmNonStreaming, + ArmStreaming, + ArmStreamingCompatible, + ArmLocallyStreaming +}; + +static

  1   2   3   >