[lldb] [llvm] [clang] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

2024-01-18 Thread Davide Italiano via cfe-commits
https://github.com/dcci commented: LG https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread via cfe-commits
@@ -70,6 +70,8 @@ Changes to the LLVM IR * Added `llvm.exp10` intrinsic. +* Added a code model attribute for the global variable. heiher wrote: Thanks https://github.com/llvm/llvm-project/pull/78664 ___

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/78664 >From ccb95a2f40e94ab773dd8897dd287dba7a38 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 19 Jan 2024 11:13:39 +0800 Subject: [PATCH 1/2] [docs] Add llvm and clang release notes for the global-var code

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/78675 This file has sections for non-experimental and experimental extensions, but we keep forgetting to move things when we change the extension status. >From 55bd10f35b217161cfeb13b8798e584ece0b6bee Mon Sep 17

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Craig Topper (topperc) Changes This file has sections for non-experimental and experimental extensions, but we keep forgetting to move things when we change the extension status. --- Patch is 23.54 KiB, truncated to 20.00 KiB below,

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Rohit Aggarwal via cfe-commits
rohitaggarwal007 wrote: @florianhumblot @alexey-bataev @RKSimon @phoebewang Please review the pull request. https://github.com/llvm/llvm-project/pull/78560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/78664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 498e1c2 - [coroutine] Create coroutine body in the correct eval context (#78589)

2024-01-18 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2024-01-19T08:23:25+01:00 New Revision: 498e1c2257da552abc58aa75f6b9f776bf826f86 URL: https://github.com/llvm/llvm-project/commit/498e1c2257da552abc58aa75f6b9f776bf826f86 DIFF:

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

2024-01-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9fec33a - Revert "[BOLT] Fix unconditional output of boltedcollection in merge-fdata (#78653)"

2024-01-18 Thread Amir Ayupov via cfe-commits
Author: Amir Ayupov Date: 2024-01-18T19:59:09-08:00 New Revision: 9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae URL: https://github.com/llvm/llvm-project/commit/9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae DIFF: https://github.com/llvm/llvm-project/commit/9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae.diff

[clang] Reland "[clang] Fix CTAD for aggregates for nested template classes" (PR #78670)

2024-01-18 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/78670 Reland of #78387 Use the template pattern in determining whether to synthesize the aggregate deduction guide, and update DeclareImplicitDeductionGuideFromInitList to substitute outer template arguments. The

[clang] Reland "[clang] Fix CTAD for aggregates for nested template classes" (PR #78670)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes Reland of #78387 Use the template pattern in determining whether to synthesize the aggregate deduction guide, and update DeclareImplicitDeductionGuideFromInitList to substitute outer template arguments. The

[llvm] [clang] [RISCV] Add B extension (PR #76893)

2024-01-18 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: I will hold this PR util B extension is ratified (I think it won't take too long). Or, at least after llvm 18 branch is created. https://github.com/llvm/llvm-project/pull/76893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [RISCV] RISCV vector calling convention (1/2) (PR #77560)

2024-01-18 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng edited https://github.com/llvm/llvm-project/pull/77560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [lldb] [libcxxabi] [lld] [llvm] [libcxx] [clang] [polly] [clang-tools-extra] [libc] [mlir] [openmp] [compiler-rt] [libunwind] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov converted_to_draft https://github.com/llvm/llvm-project/pull/77967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [openmp] [clang] [mlir] [lldb] [compiler-rt] [clang-tools-extra] [lld] [llvm] [libc] [flang] [libc++][memory] P2868R1: Removing deprecated typedef `std::allocator::is_always_equal` (PR #78562

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/78562 >From fadaafbf791d5fe78f6ac9ee3494b128339781ba Mon Sep 17 00:00:00 2001 From: Zingam Date: Thu, 18 Jan 2024 09:47:40 +0200 Subject: [PATCH 1/6] [libc++][memory] P2868R1 - Removing deprecated typedef

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 461679f - [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (#78675)

2024-01-18 Thread via cfe-commits
Author: Craig Topper Date: 2024-01-18T23:15:24-08:00 New Revision: 461679f2925220f350c6bafb2d661c309c5e3ae8 URL: https://github.com/llvm/llvm-project/commit/461679f2925220f350c6bafb2d661c309c5e3ae8 DIFF: https://github.com/llvm/llvm-project/commit/461679f2925220f350c6bafb2d661c309c5e3ae8.diff

[clang] 407db48 - [Release Notes] [C++20] [Modules] Summarize modules related change to the release note for clang 18

2024-01-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-01-19T15:26:22+08:00 New Revision: 407db48eb4d387ae272bfbef9b12868806f1e830 URL: https://github.com/llvm/llvm-project/commit/407db48eb4d387ae272bfbef9b12868806f1e830 DIFF: https://github.com/llvm/llvm-project/commit/407db48eb4d387ae272bfbef9b12868806f1e830.diff

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Bhuminjay Soni via cfe-commits
11happy wrote: **Updates of Recent Commit:** - Incorporated all the naming and formatting suggestions by @5chmidti - Thanks @felix642 for such a great insight on testcases, actually those two you suggested were actually getting flagged when they shouldn't ,added changes so that they don't get

[clang-tools-extra] [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (PR #78630)

2024-01-18 Thread Daniil Dudkin via cfe-commits
https://github.com/unterumarmung updated https://github.com/llvm/llvm-project/pull/78630 >From 1951badf6ba8302da1431747412edf960f53b0b1 Mon Sep 17 00:00:00 2001 From: Daniil Dudkin Date: Fri, 19 Jan 2024 00:41:03 +0300 Subject: [PATCH] [clang-apply-replacements] Deduplicate Implementation of

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -1279,6 +1281,213 @@ void TargetLibraryInfoImpl::addVectorizableFunctionsFromVecLib( } break; } + case AMDLIBM: { +#define FIXED(NL) ElementCount::getFixed(NL) +const VecDesc VecFuncs[] = { phoebewang wrote: Move them to `VecFuncs.def`?

[clang] [llvm] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -129,7 +129,8 @@ class TargetLibraryInfoImpl { MASSV,// IBM MASS vector library. SVML, // Intel short vector math library. SLEEFGNUABI, // SLEEF - SIMD Library for Evaluating Elementary Functions. -ArmPL// Arm Performance

[clang] [llvm] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -3190,10 +3190,10 @@ def fno_experimental_isel : Flag<["-"], "fno-experimental-isel">, Group, - Values<"Accelerate,libmvec,MASSV,SVML,SLEEF,Darwin_libsystem_m,ArmPL,none">, + Values<"Accelerate,libmvec,MASSV,SVML,SLEEF,Darwin_libsystem_m,ArmPL,AMDLIBM,none">,

[clang] [flang] [libc] [openmp] [lldb] [llvm] [lld] [libcxx] [clang-tools-extra] [compiler-rt] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-01-18 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/12] Add profiling functions to libomptarget

[llvm] [clang-tools-extra] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-18 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: I believe this is ready to go now. All the tests have been converted to lit-style tests and everything has been wired up into a `check-mlgo-utils` CMake target. I talked with Mircea about the absl dependency. It's not in the tests anymore and the plan is to refactor in

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Improve structural equivalence of overloadable operators. (PR #72242)

2024-01-18 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/72242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9ca1a08 - [clang][ASTImporter] Improve structural equivalence of overloadable operators. (#72242)

2024-01-18 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-01-18T09:20:05+01:00 New Revision: 9ca1a08144a3caea8fd2f45fd4930ca796cf4166 URL: https://github.com/llvm/llvm-project/commit/9ca1a08144a3caea8fd2f45fd4930ca796cf4166 DIFF: https://github.com/llvm/llvm-project/commit/9ca1a08144a3caea8fd2f45fd4930ca796cf4166.diff

[clang] [llvm] [clang-tools-extra] [CGP] Avoid replacing a free ext with multiple other exts. (PR #77094)

2024-01-18 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/77094 >From 46fbecfce6c48795ea85fc9420067479f6d0b17a Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Fri, 5 Jan 2024 11:24:59 + Subject: [PATCH] [CGP] Avoid replacing a free ext with multiple other exts. Replacing

[llvm] [clang] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #78526)

2024-01-18 Thread Nikita Popov via cfe-commits
https://github.com/nikic requested changes to this pull request. Using anything but the size and alignment of the alloca type in a way that affects program semantics is illegal. https://github.com/llvm/llvm-project/pull/78526 ___ cfe-commits mailing

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-18 Thread Chuanqi Xu via cfe-commits
@@ -692,6 +692,13 @@ def warn_maybe_falloff_nonvoid_function : Warning< def warn_falloff_nonvoid_function : Warning< "non-void function does not return a value">, InGroup; +def warn_const_attr_with_pure_attr : Warning< + "'const' attribute imposes more restrictions,

[clang] [Clang][Sema] fix crash of attribute transform (PR #78088)

2024-01-18 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/78088 >From 7632f631ec949f91d2ecec2b6f16951f9288920f Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 14 Jan 2024 15:07:26 +0800 Subject: [PATCH] [Clang][Sema] fix crash of attribute transform ---

[flang] [clang] [llvm] [lld] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-18 Thread Pierre van Houtryve via cfe-commits
@@ -840,6 +845,12 @@ enum : unsigned { EF_AMDGPU_FEATURE_SRAMECC_OFF_V4 = 0x800, // SRAMECC is on. EF_AMDGPU_FEATURE_SRAMECC_ON_V4 = 0xc00, + + // Generic target versioning. This is contained in the list byte of EFLAGS. Pierre-vh wrote: It's already

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #78526)

2024-01-18 Thread Bill Wendling via cfe-commits
bwendling wrote: > We've discussed this before, years ago. Previously, the sticking point was: > how is LLVM going to know what the frontend considers the closest surrounding > subobject to be? The LLVM type doesn't give you that information, and it > seems like there's nowhere else that LLVM

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #78526)

2024-01-18 Thread Bill Wendling via cfe-commits
bwendling wrote: > Using anything but the size and alignment of the alloca type in a way that > affects program semantics is illegal. I'm sorry, but I don't understand your comment here. Could you supply some context? https://github.com/llvm/llvm-project/pull/78526

[clang] 4c65787 - [AMDGPU] Add GFX12 __builtin_amdgcn_s_sleep_var (#77926)

2024-01-18 Thread via cfe-commits
Author: Jay Foad Date: 2024-01-18T10:14:01Z New Revision: 4c65787f1e45199713f71f63817651ff2decd96c URL: https://github.com/llvm/llvm-project/commit/4c65787f1e45199713f71f63817651ff2decd96c DIFF: https://github.com/llvm/llvm-project/commit/4c65787f1e45199713f71f63817651ff2decd96c.diff LOG:

[clang] [AMDGPU] Add GFX12 __builtin_amdgcn_s_sleep_var (PR #77926)

2024-01-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/77926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [flang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-18 Thread Pierre van Houtryve via cfe-commits
@@ -253,6 +274,12 @@ AMDGPU::IsaVersion AMDGPU::getIsaVersion(StringRef GPU) { case GK_GFX1151: return {11, 5, 1}; case GK_GFX1200: return {12, 0, 0}; case GK_GFX1201: return {12, 0, 1}; + + // Generic targets use the earliest ISA version in their group.

[clang-tools-extra] [clang] [llvm] [AMDGPU] Work around s_getpc_b64 zero extending on GFX12 (PR #78186)

2024-01-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/78186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (re-land) (PR #71417)

2024-01-18 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > The enum we had in the past described the syntax of the new expression. Even if it was the case at some point, I'm not sure it held when I created the PR, which eliminated this kind of nasty mapping, encoding how this enum was actually used: ```cpp

[clang] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-18 Thread via cfe-commits
cor3ntin wrote: @Fznamznon I think that unless bots find something, this is good for 18. I don't see anything that concerns me https://github.com/llvm/llvm-project/pull/77753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [llvm] [lld] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-18 Thread Pierre van Houtryve via cfe-commits
@@ -4135,6 +4283,33 @@ Code object V5 metadata is the same as == == = +.. _amdgpu-amdhsa-code-object-metadata-v6: + +Code Object V6 Metadata + +.. warning:: + Code object

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
tbaederr wrote: > The only thing we need to make sure is that highlighting isn't done in CI/ > redirected output It now respects `DiagOpts->ShowColors`, so that should work. But I guess you're talking about a test. :) https://github.com/llvm/llvm-project/pull/66514

[clang] [Clang] Implement CWG2598: Union of non-literal types (PR #78195)

2024-01-18 Thread via cfe-commits
cor3ntin wrote: Looking at that again, i suspect I did not handle indirect fields properly. I'll try to get to that. Sorry! https://github.com/llvm/llvm-project/pull/78195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-18 Thread via cfe-commits
@@ -11802,6 +11802,27 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [flang] [lld] [llvm] [AMDGPU] Introduce Code Object V6 (PR #76954)

2024-01-18 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh updated https://github.com/llvm/llvm-project/pull/76954 >From 47d4f3ed4e27f2ce2b3b33c9b0ca4838b3011f22 Mon Sep 17 00:00:00 2001 From: pvanhout Date: Thu, 4 Jan 2024 14:12:00 +0100 Subject: [PATCH] [AMDGPU] Introduce Code Object V6 Introduce Code Object V6 in

[clang] [llvm] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Rohit Aggarwal (rohitaggarwal007) Changes Hi, AMD has it's own implementation of vector calls. This patch include the changes to enable the use of AMD's math library using -fveclib=AMDLIBM. --- Patch is 60.65 KiB, truncated to

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Bhuminjay Soni via cfe-commits
11happy wrote: A humble reminder. @PiotrZSL Can you please review this and suggest if any changes required?. Thank you https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang] [llvm] [CGP] Avoid replacing a free ext with multiple other exts. (PR #77094)

2024-01-18 Thread Florian Hahn via cfe-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/77094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [AMDGPU] CodeGen for GFX12 S_WAIT_* instructions (PR #77438)

2024-01-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/77438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-18 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/77753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] [openmp] [llvm] [clang] [AMDGPU] Add global_load_tr for GFX12 (PR #77772)

2024-01-18 Thread Piotr Sobczak via cfe-commits
piotrAMD wrote: Rebased and regenerated lit tests after GFX12 waitcnt codegen changes. https://github.com/llvm/llvm-project/pull/2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement CWG2598: Union of non-literal types (PR #78195)

2024-01-18 Thread via cfe-commits
groundswellaudio wrote: @Fznamznon @cor3ntin So https://github.com/llvm/llvm-project/pull/77753 doesn't solve the problem of an anonymous union not being literal when it should be, right? https://github.com/llvm/llvm-project/pull/78195 ___

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/78566 This removes a default argument that is currently broken in C++23 mode due to `std::default_delete` now being `constexpr`. This is a known problem (see #74963, #59966, #69996, and a couple more), fixing which

[clang-tools-extra] [llvm] [clang] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
@@ -819,10 +812,77 @@ class VPRecipeBase : public ilist_node_with_parent, } \ static inline bool classof(const VPRecipeBase *R) { \ return R->getVPDefID() == VPDefID;

[clang] [llvm] [clang-tools-extra] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
https://github.com/ayalz commented: Some nits and thoughts. https://github.com/llvm/llvm-project/pull/77023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
@@ -12,6 +12,8 @@ ///VPBlockBase, together implementing a Hierarchical CFG; /// 2. Pure virtual VPRecipeBase serving as the base class for recipes contained ///within VPBasicBlocks; +/// 3. Pure virtual VPSingleDefRecipe serving as a base class for recipes that +///

[clang-tools-extra] [clang] [llvm] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
https://github.com/ayalz edited https://github.com/llvm/llvm-project/pull/77023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread via cfe-commits
cor3ntin wrote: That looks reasonable. I really think we should land this, with checkpoints early in the clang 19 cycle to get actual data. The only thing we need to make sure is that highlighting isn't done in CI/ redirected output https://github.com/llvm/llvm-project/pull/66514

[clang] [llvm] [lld] [flang] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-18 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: I added a few more tests, I just didn't find how to test the flat-scratch stuff properly. Also, gfx904 is documented as not having absolute flat scratch, yet I don't see anything about that in the code (no related feature). I put gfx9-generic with flat scratch but I don't

[clang] [clang] Implement CWG1878 "`operator auto` template" (PR #78103)

2024-01-18 Thread Vlad Serebrennikov via cfe-commits
@@ -686,3 +686,19 @@ auto f(auto x) { // cxx14-error {{'auto' not allowed in function prototype}} } } + +struct DeducedTargetTypeOfConversionFunction { + operator auto() const { return char(); } + operator const auto() const { return float(); } Endilll

[clang] [clang] Implement CWG1878 "`operator auto` template" (PR #78103)

2024-01-18 Thread Vlad Serebrennikov via cfe-commits
@@ -11322,9 +11322,22 @@ Decl *Sema::ActOnConversionDeclarator(CXXConversionDecl *Conversion) { << ClassType << ConvType; } - if (FunctionTemplateDecl *ConversionTemplate -= Conversion->getDescribedFunctionTemplate()) + if

[llvm] [flang] [clang] [InstCombine] Canonicalize constant GEPs to i8 source element type (PR #68882)

2024-01-18 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Ping? https://github.com/llvm/llvm-project/pull/68882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AMDGPU] Add global_load_tr for GFX12 (PR #77772)

2024-01-18 Thread Piotr Sobczak via cfe-commits
piotrAMD wrote: Discussed it some more internally and the agreement was to keep the "global" and have one intrinsic for both instructions. Just updated the PR to reflect that - this effectively reverts the previous update. https://github.com/llvm/llvm-project/pull/2

[clang-tools-extra] [clangd] Don't collect templated decls for builtin templates (PR #78466)

2024-01-18 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/78466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't collect templated decls for builtin templates (PR #78466)

2024-01-18 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/78466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't collect templated decls for builtin templates (PR #78466)

2024-01-18 Thread Haojian Wu via cfe-commits
@@ -443,9 +443,15 @@ struct TargetFinder { Outer.add(TST->getAliasedType(), Flags | Rel::Underlying); // Don't *traverse* the alias, which would result in traversing the // template of the underlying type. - Outer.report( -

[clang] [llvm] [AMDGPU] Add global_load_tr for GFX12 (PR #77772)

2024-01-18 Thread Changpeng Fang via cfe-commits
https://github.com/changpeng approved this pull request. https://github.com/llvm/llvm-project/pull/2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 085eae6 - [C++20] [Modules] Allow to merge enums with the same underlying interger types

2024-01-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-01-18T17:09:35+08:00 New Revision: 085eae6b863881fb9fda323e5b672b04a00ed19e URL: https://github.com/llvm/llvm-project/commit/085eae6b863881fb9fda323e5b672b04a00ed19e DIFF: https://github.com/llvm/llvm-project/commit/085eae6b863881fb9fda323e5b672b04a00ed19e.diff

[llvm] [flang] [compiler-rt] [clang] [clang-tools-extra] [flang] use setsid to assign the child to prevent zombie as it will be clean up by init process (PR #77944)

2024-01-18 Thread Yi Wu via cfe-commits
yi-wu-arm wrote: Sorry, let me rebase on main, there are patches has been uploaded to solve this problem. The problem is listed here: https://github.com/llvm/llvm-project/issues/77803 In short, once a async ` EXECUTE_COMMAND_LINE` is called, all future `EXECUTE_COMMAND_LINE` will have a

[libc] [llvm] [flang] [compiler-rt] [clang] [clang-tools-extra] Apply kind code check on exitstat and cmdstat (PR #78286)

2024-01-18 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/78286 >From d56eca56c8e4c64e649febc43e2c48b6e5146680 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Tue, 16 Jan 2024 14:08:00 + Subject: [PATCH 1/6] change exitstat and cmsstat from AnyInt to DefaultInt ---

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (re-land) (PR #71417)

2024-01-18 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > I'd qualify this as a regression, by looking at that the commit was supposed > to be an NFC. Could you please confirm @Endilll? I'll leave to @AaronBallman to decide whether this is a functional change, but I can confirm that patch is working as intended, because there is an

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-18 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From fb05243d0c0c3702b1615239a9337df337ad0c7c Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 1/7] add warning and test ---

[flang] [clang-tools-extra] [compiler-rt] [llvm] [libc] [clang] [flang] use setsid to assign the child to prevent zombie as it will be clean up by init process (PR #77944)

2024-01-18 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/77944 >From b51f293d57a1ae96fab5d3b2a529186a78643c8c Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Fri, 12 Jan 2024 16:44:21 + Subject: [PATCH 1/3] use setsid to assign the child to prevent zombie as it will be

[clang] [flang] [lld] [llvm] [AMDGPU] Introduce GFX9/10.1/10.3/11 Generic Targets (PR #76955)

2024-01-18 Thread Pierre van Houtryve via cfe-commits
@@ -787,11 +788,15 @@ enum : unsigned { EF_AMDGPU_MACH_AMDGCN_GFX942= 0x04c, EF_AMDGPU_MACH_AMDGCN_RESERVED_0X4D = 0x04d, EF_AMDGPU_MACH_AMDGCN_GFX1201 = 0x04e, + EF_AMDGPU_MACH_AMDGCN_GFX9_GENERIC = 0x04f, + EF_AMDGPU_MACH_AMDGCN_GFX10_1_GENERIC =

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/66514 >From 34ca28505542d55f62da80d8fd3c2561535185d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 15 Sep 2023 15:51:39 +0200 Subject: [PATCH] [clang][Diagnostics] Highlight code snippets

[clang] [coroutines][coro_lifetimebound] Detect lifetime issues with lambda captures (PR #77066)

2024-01-18 Thread Utkarsh Saxena via cfe-commits
@@ -11220,6 +11220,11 @@ class Sema final { VarDecl *buildCoroutinePromise(SourceLocation Loc); void CheckCompletedCoroutineBody(FunctionDecl *FD, Stmt *); + // Heuristically tells if the function is get_return_object by matching usx95 wrote: Both done.

[compiler-rt] [llvm] [clang] [lld] [libcxx] [clang-tools-extra] [lldb] [libc] [flang] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

2024-01-18 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/78316 >From cf33d7ce01aafe0fa29b8a38a9824a0b03d24f05 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 16 Jan 2024 09:16:10 -0800 Subject: [PATCH 1/4] [clang] Fix assertion failure with deleted

[clang] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-18 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: @Endilll , are you ok with the changes? BTW, do we want this for 18, or it is better to wait and merge after cutoff? https://github.com/llvm/llvm-project/pull/77753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [clang-tools-extra] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
@@ -819,10 +812,77 @@ class VPRecipeBase : public ilist_node_with_parent, } \ static inline bool classof(const VPRecipeBase *R) { \ return R->getVPDefID() == VPDefID;

[llvm] [clang] [clang-tools-extra] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
@@ -819,10 +812,77 @@ class VPRecipeBase : public ilist_node_with_parent, } \ static inline bool classof(const VPRecipeBase *R) { \ return R->getVPDefID() == VPDefID;

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes This removes a default argument that is currently broken in C++23 mode due to `std::default_delete` now being `constexpr`. This is a known problem (see #74963, #59966, #69996, and a couple more), fixing which will

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
Sirraide wrote: Note sure why that one CI job got cancelled candidly, but I don’t think I can re-run it. https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [clang-tools-extra] [VPlan] Introduce VPSingleDefRecipe. (PR #77023)

2024-01-18 Thread via cfe-commits
@@ -912,25 +970,28 @@ class VPRecipeWithIRFlags : public VPRecipeBase { } else if (auto *Op = dyn_cast()) { OpType = OperationType::FPMathOp; FMFs = Op->getFastMathFlags(); +} else { + OpType = OperationType::Other; + AllFlags = 0;

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-18 Thread via cfe-commits
Sirraide wrote: CC @AaronBallman https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [LoopVectorize] Refine runtime memory check costs when there is an outer loop (PR #76034)

2024-01-18 Thread Rin Dobrescu via cfe-commits
@@ -2076,16 +2081,61 @@ class GeneratedRTChecks { LLVM_DEBUG(dbgs() << " " << C << " for " << I << "\n"); RTCheckCost += C; } -if (MemCheckBlock) +if (MemCheckBlock) { + InstructionCost MemCheckCost = 0; for (Instruction :

[llvm] [clang] [clang-tools-extra] [LoopVectorize] Refine runtime memory check costs when there is an outer loop (PR #76034)

2024-01-18 Thread Rin Dobrescu via cfe-commits
https://github.com/Rin18 edited https://github.com/llvm/llvm-project/pull/76034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [LoopVectorize] Refine runtime memory check costs when there is an outer loop (PR #76034)

2024-01-18 Thread Rin Dobrescu via cfe-commits
https://github.com/Rin18 commented: One small comment, but otherwise LGTM! I'll leave someone else more familiar with the code to approve the change. https://github.com/llvm/llvm-project/pull/76034 ___ cfe-commits mailing list

[clang] [llvm] [RISCV] Add support for new unprivileged extensions defined in profiles spec (PR #77458)

2024-01-18 Thread Luke Lau via cfe-commits
https://github.com/lukel97 updated https://github.com/llvm/llvm-project/pull/77458 >From fb8eebe1c7f5b4dec812c64d9a2572a98d59bdb8 Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Tue, 9 Jan 2024 19:42:10 +0700 Subject: [PATCH 1/7] [RISCV] Add support for new unprivileged extensions defined in

[clang-tools-extra] [clang] [llvm] [AMDGPU] Update uses of new VOP2 pseudos for GFX12 (PR #78155)

2024-01-18 Thread Jay Foad via cfe-commits
@@ -1,7 +1,8 @@ ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs < %s | FileCheck --check-prefixes=SI %s jayfoad wrote: Done as part of a merge from main to fix

[llvm] [flang] [clang] [InstCombine] Canonicalize constant GEPs to i8 source element type (PR #68882)

2024-01-18 Thread Nikita Popov via cfe-commits
nikic wrote: @dtcxzyw I'm going to merge this after LLVM 18 branches next week. https://github.com/llvm/llvm-project/pull/68882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-18 Thread via cfe-commits
@@ -692,6 +692,13 @@ def warn_maybe_falloff_nonvoid_function : Warning< def warn_falloff_nonvoid_function : Warning< "non-void function does not return a value">, InGroup; +def warn_const_attr_with_pure_attr : Warning< + "'const' attribute imposes more restrictions,

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (re-land) (PR #71417)

2024-01-18 Thread via cfe-commits
cor3ntin wrote: @steakhal Thanks for raising this. I agree this stretches the definition of NFC commit. But it was dully reviewed and approved https://github.com/llvm/llvm-project/pull/71322 We usually do not make any guarantees as the stability of the C++ interfaces, so as this test did

[clang] [Clang][Sema] fix crash of attribute transform (PR #78088)

2024-01-18 Thread Qizhi Hu via cfe-commits
@@ -7081,10 +7085,10 @@ QualType TreeTransform::TransformAttributedType( // FIXME: dependent operand expressions? if (getDerived().AlwaysRebuild() || modifiedType != oldType->getModifiedType()) { -// TODO: this is really lame; we should really be rebuilding the

[clang] [llvm] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

2024-01-18 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/77936 >From bbc6c11cd3def5acbb2ba2f2ddc45df2c399f9d6 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Wed, 10 Jan 2024 14:57:04 + Subject: [PATCH 1/6] [Clang][SME] Detect always_inline used with mismatched

[lldb] [clang] [compiler-rt] [flang] [lld] [llvm] [libcxx] [libc] [clang-tools-extra] AMDGPU/GFX12: Add new dot4 fp8/bf8 instructions (PR #77892)

2024-01-18 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd updated https://github.com/llvm/llvm-project/pull/77892 >From 628a3d2b42cdcbd903e0830ab7d631ea7dc422b9 Mon Sep 17 00:00:00 2001 From: Petar Avramovic Date: Wed, 10 Jan 2024 12:17:58 +0100 Subject: [PATCH 1/2] AMDGPU/GFX12: Add new dot4 fp8/bf8

  1   2   3   4   5   6   >