@@ -11,7 +11,7 @@
#error
// expected-error@-1 {{}}
-// CHECK: error: no expected directives found: consider use of
'expected-no-diagnostics'
+// CHECK: error: no expected directives found: consider use of
'{{.*}}-no-diagnostics'
tbaederr wrote:
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/78103
>From 522c7dff31a6f63995877674f9f4282ae60f7aaa Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 14 Jan 2024 19:45:04 +0300
Subject: [PATCH 1/5] [clang] Implement CWG1878 "`operator auto` template"
https://github.com/AaronBallman approved this pull request.
Other than the one diagnostic concern, the changes LGTM and I think are fine
for Clang 18.
https://github.com/llvm/llvm-project/pull/77753
___
cfe-commits mailing list
@@ -2765,10 +2765,14 @@ def err_constexpr_tag : Error<
"cannot be marked %sub{select_constexpr_spec_kind}1">;
def err_constexpr_dtor : Error<
"destructor cannot be declared %sub{select_constexpr_spec_kind}0">;
-def err_constexpr_dtor_subobject : Error<
- "destructor
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/76718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-01-18T15:15:05+01:00
New Revision: 30d458626d4fb7adf94b195e98de240b491c86c9
URL:
https://github.com/llvm/llvm-project/commit/30d458626d4fb7adf94b195e98de240b491c86c9
DIFF:
https://github.com/llvm/llvm-project/commit/30d458626d4fb7adf94b195e98de240b491c86c9.diff
https://github.com/piotrAMD closed
https://github.com/llvm/llvm-project/pull/2
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Piotr Sobczak
Date: 2024-01-18T15:14:42+01:00
New Revision: 57f6a3f7ea9bae0c429cd3b8a69e3a8b1d0eed41
URL:
https://github.com/llvm/llvm-project/commit/57f6a3f7ea9bae0c429cd3b8a69e3a8b1d0eed41
DIFF:
https://github.com/llvm/llvm-project/commit/57f6a3f7ea9bae0c429cd3b8a69e3a8b1d0eed41.diff
groundswellaudio wrote:
By looking at your tests on anonymous unions, I'd say that indirect fields are
handled correctly (perhaps they're not included in the fields range?, otherwise
the union-like class would not be considered literal) and that rather the
implicitly generated special member
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/75590
>From 93d58a2aaeaae142723c844a2f19d4bec7c6bdf1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Fri, 15 Dec 2023 13:11:16 +0100
Subject: [PATCH] [clang][Interp] Implement integral->complex
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/66514
>From 34ca28505542d55f62da80d8fd3c2561535185d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Fri, 15 Sep 2023 15:51:39 +0200
Subject:
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/77936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniel Grumberg (daniel-grumberg)
Changes
When generating declaration fragments for types that use typedefs to pointer
types ensure that we keep the user-defined typedef form instead of desugaring
the typedef.
rdar://102137655
---
Full
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/76218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vassil Vassilev
Date: 2024-01-18T16:06:04+02:00
New Revision: 1566f1ffc6b52bee659071d460123c1c4a358d01
URL:
https://github.com/llvm/llvm-project/commit/1566f1ffc6b52bee659071d460123c1c4a358d01
DIFF:
https://github.com/daniel-grumberg created
https://github.com/llvm/llvm-project/pull/78584
When generating declaration fragments for types that use typedefs to pointer
types ensure that we keep the user-defined typedef form instead of desugaring
the typedef.
rdar://102137655
>From
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/77806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jplehr closed https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jplehr wrote:
Closing this. Test is now part of feature-PR.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/77761
>From 62f31654ec66fe0e2a27200d0484d3c70d4ce2c1 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Wed, 20 Dec 2023 15:12:04 -0600
Subject: [PATCH 1/9] [Flang][OpenMP] Separate creation of work-sharing and
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 90802e652db348fd3218fcbfc3e6ac9e90702acd
e093db3f1bc432654c2105430f2f647f6d2ab362 --
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/76571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jplehr wrote:
While I add some documentation, I'd appreciate feedback especially on the lit
side of things. I would very much like to rename the pretty happy tripple-X
workaround for substitution debugging into something sane.
https://github.com/llvm/llvm-project/pull/76571
https://github.com/kparzysz edited
https://github.com/llvm/llvm-project/pull/77761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kparzysz closed
https://github.com/llvm/llvm-project/pull/77760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,10 +25,17 @@ namespace dataflow {
/// Maps statements to the environments of basic blocks that contain them.
class StmtToEnvMap {
public:
+ // `CurBlock` is the block currently being processed, and `CurState` is the
+ // pending state currently associated with this
https://github.com/martinboehme updated
https://github.com/llvm/llvm-project/pull/78127
>From d2fea007602cc4279a52e49db799aecd767dba70 Mon Sep 17 00:00:00 2001
From: Martin Braenne
Date: Thu, 18 Jan 2024 07:41:04 +
Subject: [PATCH 1/2] [clang][dataflow] Process terminator condition within
@@ -2178,7 +2178,7 @@
createAndSetPrivatizedLoopVar(Fortran::lower::AbstractConverter ,
template
static void createBodyOfOp(
Op , Fortran::lower::AbstractConverter , mlir::Location ,
-Fortran::lower::pft::Evaluation ,
+Fortran::lower::pft::Evaluation , bool
https://github.com/jplehr updated
https://github.com/llvm/llvm-project/pull/76571
>From bf25a538e7c020efde557b595eba64b804cbb817 Mon Sep 17 00:00:00 2001
From: JP Lehr
Date: Fri, 29 Dec 2023 04:32:24 -0500
Subject: [PATCH 1/3] [OpenMP][USM] Introduces -fopenmp-force-usm flag
This flag forces
https://github.com/AaronBallman approved this pull request.
The changes LGTM, thank you for this awesome refactoring! Thank you!
Please wait to land until after we branch for Clang 18 and after CI has finish
running (it'll be a race to see which happens first).
@@ -6571,11 +6571,14 @@ class AtomicExpr : public Expr {
/// \return empty atomic scope model if the atomic op code does not have
/// scope operand.
static std::unique_ptr getScopeModel(AtomicOp Op) {
-if (Op >= AO__opencl_atomic_load && Op <=
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/68324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/skatrak approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/77760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/76979
From c45d8c9ef074c8dbce862d88222e16c2e60be619 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Thu, 4 Jan 2024 18:16:12 +0100
Subject: [PATCH 1/3] [clang][analyzer] Add missing stream
@@ -2178,7 +2178,7 @@
createAndSetPrivatizedLoopVar(Fortran::lower::AbstractConverter ,
template
static void createBodyOfOp(
Op , Fortran::lower::AbstractConverter , mlir::Location ,
-Fortran::lower::pft::Evaluation ,
+Fortran::lower::pft::Evaluation , bool
https://github.com/kelbon updated
https://github.com/llvm/llvm-project/pull/78200
>From fb05243d0c0c3702b1615239a9337df337ad0c7c Mon Sep 17 00:00:00 2001
From: Kelbon Nik
Date: Mon, 15 Jan 2024 22:24:34 +0400
Subject: [PATCH 1/9] add warning and test
---
tomasz-kaminski-sonarsource wrote:
> > > The enum we had in the past described the syntax of the new expression.
> >
> >
> > Even if it was the case at some point, I'm not sure it held when I created
> > the PR, which eliminated this kind of nasty mapping, encoding how this enum
> > was
https://github.com/saiislam approved this pull request.
I tested with different combinations of compatible TargetIDs, the patch seems
to work fine.
Thanks a lot for working on this.
LGTM!
https://github.com/llvm/llvm-project/pull/78359
___
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
@@ -804,6 +806,46 @@ void FormatTokenLexer::handleTableGenMultilineString() {
FirstLineText, MultiLineString->OriginalColumn, Style.TabWidth,
Encoding);
}
+void FormatTokenLexer::handleTableGenNumericLikeIdentifier() {
+ FormatToken *Tok = Tokens.back();
+ //
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/78155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mbrkusanin approved this pull request.
https://github.com/llvm/llvm-project/pull/78155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > The enum we had in the past described the syntax of the new expression.
>
> Even if it was the case at some point, I'm not sure it held when I created
> the PR, which eliminated this kind of nasty mapping, encoding how this enum
> was actually used:
>
> ```c++
>
hnakamura5 wrote:
I checked simply the corner cases in unittest of this patch with the following
sample.
```
// test_id.td
class 01234Vector {
int 2dVector = 0x1abc;
int invalid_num = 0x1234x;
int 0x1234x = i;
}
def Def: 01234Vector<1>;
```
The followings are the result of
```
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/77637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-01-18T17:14:25+04:00
New Revision: f4fbbebb5edcaad459ce154c011f71fc38fe4052
URL:
https://github.com/llvm/llvm-project/commit/f4fbbebb5edcaad459ce154c011f71fc38fe4052
DIFF:
@@ -25,10 +25,17 @@ namespace dataflow {
/// Maps statements to the environments of basic blocks that contain them.
class StmtToEnvMap {
public:
+ // `CurBlock` is the block currently being processed, and `CurState` is the
+ // pending state currently associated with this
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/78127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/78127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/78103
>From 522c7dff31a6f63995877674f9f4282ae60f7aaa Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 14 Jan 2024 19:45:04 +0300
Subject: [PATCH 1/4] [clang] Implement CWG1878 "`operator auto` template"
philnik777 wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/73376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/math-fehr updated
https://github.com/llvm/llvm-project/pull/76400
>From 4363403ffcff10844c304426cb92bc559cf0d95c Mon Sep 17 00:00:00 2001
From: Mathieu Fehr
Date: Sat, 23 Dec 2023 17:11:46 +
Subject: [PATCH 1/2] [mlir][irdl] Add irdl.base operation
---
https://github.com/AaronBallman approved this pull request.
LGTM though we can clean some bits up in follow-ups
https://github.com/llvm/llvm-project/pull/71315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -54,36 +44,90 @@ bool Context::isPotentialConstantExpr(State , const
FunctionDecl *FD) {
bool Context::evaluateAsRValue(State , const Expr *E, APValue ) {
assert(Stk.empty());
ByteCodeExprGen C(*this, *P, Parent, Stk, Result);
- if (Check(Parent, C.interpretExpr(E)))
https://github.com/mariusz-sikora-at-amd closed
https://github.com/llvm/llvm-project/pull/75917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -54,36 +44,90 @@ bool Context::isPotentialConstantExpr(State , const
FunctionDecl *FD) {
bool Context::evaluateAsRValue(State , const Expr *E, APValue ) {
assert(Stk.empty());
ByteCodeExprGen C(*this, *P, Parent, Stk, Result);
- if (Check(Parent, C.interpretExpr(E)))
https://github.com/mariusz-sikora-at-amd closed
https://github.com/llvm/llvm-project/pull/77892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mariusz Sikora
Date: 2024-01-18T14:00:27+01:00
New Revision: 28b7e498b6a1dbfa1ac249acec45f948665ba58e
URL:
https://github.com/llvm/llvm-project/commit/28b7e498b6a1dbfa1ac249acec45f948665ba58e
DIFF:
llvmbot wrote:
@llvm/pr-subscribers-llvm-globalisel
Author: Pierre van Houtryve (Pierre-vh)
Changes
Note: please only review the last commit!
Using MMRAs, implement `builtin_amdgcn_fence_opencl` to allow device libs to
emit fences that only target one or more address spaces, instead of
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Pierre van Houtryve (Pierre-vh)
Changes
Note: please only review the last commit!
Using MMRAs, implement `builtin_amdgcn_fence_opencl` to allow device libs to
emit fences that only target one or more address spaces, instead of
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Pierre van Houtryve (Pierre-vh)
Changes
Note: please only review the last commit!
Using MMRAs, implement `builtin_amdgcn_fence_opencl` to allow device libs to
emit fences that only target one or more address spaces, instead of
llvmbot wrote:
@llvm/pr-subscribers-llvm-analysis
Author: Pierre van Houtryve (Pierre-vh)
Changes
Note: please only review the last commit!
Using MMRAs, implement `builtin_amdgcn_fence_opencl` to allow device libs to
emit fences that only target one or more address spaces, instead of
llvmbot wrote:
@llvm/pr-subscribers-llvm-selectiondag
@llvm/pr-subscribers-llvm-transforms
Author: Pierre van Houtryve (Pierre-vh)
Changes
Note: please only review the last commit!
Using MMRAs, implement `builtin_amdgcn_fence_opencl` to allow device libs to
emit fences that only target
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-llvm-globalisel
@llvm/pr-subscribers-clang
Author: Pierre van Houtryve (Pierre-vh)
Changes
Note: please only review the last commit
Allows Vulkan front-ends to properly implement the Vulkan memory model.
---
Patch
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Hirofumi Nakamura (hnakamura5)
Changes
TableGen allows the identifiers beginning with a number.
This patch add the support of the recognition of such identifiers.
---
Full diff: https://github.com/llvm/llvm-project/pull/78571.diff
AaronBallman wrote:
I'll commit on your behalf once CI comes back green.
https://github.com/llvm/llvm-project/pull/78566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1112,6 +1121,140 @@ prepareAndFilterRanges(const
SmallVectorImpl ,
return LineRanges;
}
+/// Creates syntax highlighting information in form of StyleRanges.
+///
+/// The returned unique ptr has always exactly size
+/// (\p EndLineNumber - \p StartLineNumber + 1). Each
https://github.com/hnakamura5 created
https://github.com/llvm/llvm-project/pull/78571
TableGen allows the identifiers beginning with a number.
This patch add the support of the recognition of such identifiers.
>From b472c08735b3ce3b6f7b81e499a2ef16c3faad4a Mon Sep 17 00:00:00 2001
From:
https://github.com/AaronBallman approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/78566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -54,36 +44,90 @@ bool Context::isPotentialConstantExpr(State , const
FunctionDecl *FD) {
bool Context::evaluateAsRValue(State , const Expr *E, APValue ) {
assert(Stk.empty());
ByteCodeExprGen C(*this, *P, Parent, Stk, Result);
- if (Check(Parent, C.interpretExpr(E)))
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/71315
>From b549c6aaa47b4b6b90e03cb2b4a59f323e95888d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 14:57:51 +0100
Subject: [PATCH] EvaluationResult
---
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/77294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Timm Baeder
Date: 2024-01-18T13:55:04+01:00
New Revision: 18d0a7e4c0d085de4e652e359bdd6778c43ec9bf
URL:
https://github.com/llvm/llvm-project/commit/18d0a7e4c0d085de4e652e359bdd6778c43ec9bf
DIFF:
https://github.com/llvm/llvm-project/commit/18d0a7e4c0d085de4e652e359bdd6778c43ec9bf.diff
nikic wrote:
@dtcxzyw I'm going to merge this after LLVM 18 branches next week.
https://github.com/llvm/llvm-project/pull/68882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11322,9 +11322,22 @@ Decl
*Sema::ActOnConversionDeclarator(CXXConversionDecl *Conversion) {
<< ClassType << ConvType;
}
- if (FunctionTemplateDecl *ConversionTemplate
-= Conversion->getDescribedFunctionTemplate())
+ if
dtcxzyw wrote:
Ping?
https://github.com/llvm/llvm-project/pull/68882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -686,3 +686,19 @@ auto f(auto x) { // cxx14-error {{'auto' not allowed in
function prototype}}
}
}
+
+struct DeducedTargetTypeOfConversionFunction {
+ operator auto() const { return char(); }
+ operator const auto() const { return float(); }
Endilll
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/78103
>From 522c7dff31a6f63995877674f9f4282ae60f7aaa Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 14 Jan 2024 19:45:04 +0300
Subject: [PATCH 1/4] [clang] Implement CWG1878 "`operator auto` template"
@@ -54,36 +44,90 @@ bool Context::isPotentialConstantExpr(State , const
FunctionDecl *FD) {
bool Context::evaluateAsRValue(State , const Expr *E, APValue ) {
assert(Stk.empty());
ByteCodeExprGen C(*this, *P, Parent, Stk, Result);
- if (Check(Parent, C.interpretExpr(E)))
@@ -1,7 +1,8 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs < %s | FileCheck
--check-prefixes=SI %s
jayfoad wrote:
Done as part of a merge from main to fix
yeah, something weird happened with this one that i haven't figured out yet.
This was a response to a review comment, and was on the review (and committed
as a part of that review!) but somehow I managed to 'recommit' it, not sure how.
So yeah I'm usually better at commit messages, but
https://github.com/kiranchandramohan approved this pull request.
LG.
https://github.com/llvm/llvm-project/pull/77760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Looking at that again, i suspect I did not handle indirect fields properly.
I'll try to get to that. Sorry!
https://github.com/llvm/llvm-project/pull/78195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kparzysz wrote:
Ping. Are there any unanswered questions or concerns about this change?
https://github.com/llvm/llvm-project/pull/77760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/lukel97 updated
https://github.com/llvm/llvm-project/pull/77458
>From fb8eebe1c7f5b4dec812c64d9a2572a98d59bdb8 Mon Sep 17 00:00:00 2001
From: Luke Lau
Date: Tue, 9 Jan 2024 19:42:10 +0700
Subject: [PATCH 1/7] [RISCV] Add support for new unprivileged extensions
defined in
tbaederr wrote:
> The only thing we need to make sure is that highlighting isn't done in CI/
> redirected output
It now respects `DiagOpts->ShowColors`, so that should work. But I guess you're
talking about a test. :)
https://github.com/llvm/llvm-project/pull/66514
Pierre-vh wrote:
I added a few more tests, I just didn't find how to test the flat-scratch stuff
properly.
Also, gfx904 is documented as not having absolute flat scratch, yet I don't see
anything about that in the code (no related feature). I put gfx9-generic with
flat scratch but I don't
@@ -4135,6 +4283,33 @@ Code object V5 metadata is the same as
== == =
+.. _amdgpu-amdhsa-code-object-metadata-v6:
+
+Code Object V6 Metadata
+
+.. warning::
+ Code object
@@ -423,6 +423,67 @@ TARGET_BUILTIN(__builtin_amdgcn_s_wakeup_barrier, "vi",
"n", "gfx12-insts")
TARGET_BUILTIN(__builtin_amdgcn_s_barrier_leave, "b", "n", "gfx12-insts")
TARGET_BUILTIN(__builtin_amdgcn_s_get_barrier_state, "Uii", "n", "gfx12-insts")
cor3ntin wrote:
That looks reasonable.
I really think we should land this, with checkpoints early in the clang 19
cycle to get actual data.
The only thing we need to make sure is that highlighting isn't done in CI/
redirected output
https://github.com/llvm/llvm-project/pull/66514
https://github.com/Rin18 commented:
One small comment, but otherwise LGTM! I'll leave someone else more familiar
with the code to approve the change.
https://github.com/llvm/llvm-project/pull/76034
___
cfe-commits mailing list
https://github.com/Rin18 edited https://github.com/llvm/llvm-project/pull/76034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2076,16 +2081,61 @@ class GeneratedRTChecks {
LLVM_DEBUG(dbgs() << " " << C << " for " << I << "\n");
RTCheckCost += C;
}
-if (MemCheckBlock)
+if (MemCheckBlock) {
+ InstructionCost MemCheckCost = 0;
for (Instruction :
https://github.com/ayalz approved this pull request.
Looks good to me, with the above nits.
https://github.com/llvm/llvm-project/pull/77023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Sirraide wrote:
Note sure why that one CI job got cancelled candidly, but I don’t think I can
re-run it.
https://github.com/llvm/llvm-project/pull/78566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Sirraide wrote:
CC @AaronBallman
https://github.com/llvm/llvm-project/pull/78566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
This removes a default argument that is currently broken in C++23 mode due to
`std::default_delete` now being `constexpr`. This is a known problem (see #74963, #59966, #69996, and a couple more), fixing which will
@@ -819,10 +812,77 @@ class VPRecipeBase : public
ilist_node_with_parent,
}
\
static inline bool classof(const VPRecipeBase *R) {
\
return R->getVPDefID() == VPDefID;
@@ -819,10 +812,77 @@ class VPRecipeBase : public
ilist_node_with_parent,
}
\
static inline bool classof(const VPRecipeBase *R) {
\
return R->getVPDefID() == VPDefID;
401 - 500 of 579 matches
Mail list logo
