[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-29 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > The newest version of this patch still doesn't work correctly. Switching the > new `LoadExternalSpecializationsLazily` to disabled by default (somehow the > argument didn't work on its own) instead crashes, most of the cases involving > `MultiOnDiskHashTable`. I suspect

[clang] [clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/79746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet requested changes to this pull request. https://github.com/llvm/llvm-project/pull/79746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-29 Thread kadir çetinkaya via cfe-commits
@@ -138,15 +138,9 @@ std::string getNamespaceScope(const Decl *D) { std::string printDefinition(const Decl *D, PrintingPolicy PP, const syntax::TokenBuffer ) { - if (auto *VD = llvm::dyn_cast(D)) { -if (auto *IE = VD->getInit()) { - //

[clang-tools-extra] [clang] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-29 Thread kadir çetinkaya via cfe-commits
@@ -1720,6 +1720,12 @@ void StmtPrinter::VisitInitListExpr(InitListExpr* Node) { OS << "{"; for (unsigned i = 0, e = Node->getNumInits(); i != e; ++i) { if (i) OS << ", "; +// TODO: There is duplicated functionality in APValue::printPretty. +// Would be good to

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Change AfterPlacementOperator to a boolean. Also add SBPO_None for never inserting a space before a left parenthesis and deprecate SBPO_Never, which meant never inserting a space except when after

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-29 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/78284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9f80ecb - [clang][ASTImporter] Improve import of variable template specializations. (#78284)

2024-01-29 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-01-29T10:04:17+01:00 New Revision: 9f80ecb308c989523cc32d4256f7ab61c5b788d7 URL: https://github.com/llvm/llvm-project/commit/9f80ecb308c989523cc32d4256f7ab61c5b788d7 DIFF: https://github.com/llvm/llvm-project/commit/9f80ecb308c989523cc32d4256f7ab61c5b788d7.diff

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-29 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > > The newest version of this patch still doesn't work correctly. Switching > > the new `LoadExternalSpecializationsLazily` to disabled by default (somehow > > the argument didn't work on its own) instead crashes, most of the cases > > involving `MultiOnDiskHashTable`. I

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-29 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: As far as I can tell from https://github.com/llvm/llvm-project/pull/76774#issuecomment-1914177330 above, the last push only changed the default value of `LoadExternalSpecializationsLazily`. In that case, my test results from

[clang] [Sema] Fix c23 not checking CheckBoolLikeConversion (PR #79588)

2024-01-29 Thread Pil Eghoff via cfe-commits
https://github.com/pileghoff updated https://github.com/llvm/llvm-project/pull/79588 >From 38d96aba5818091d48c40a46738f5adbf881b2a8 Mon Sep 17 00:00:00 2001 From: Pil Eghoff Date: Fri, 26 Jan 2024 13:30:17 +0100 Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion ---

[clang] [clang] WIP: Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/77890 >From 8f7d83aed173688ff1413b7c4445d4576efee872 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 24 Jan 2024 14:55:03 +0100 Subject: [PATCH] [clang] Implement Class Template Argument Deduction (CTAD) for type

[clang-tools-extra] [compiler-rt] [libc] [flang] [mlir] [libcxx] [lldb] [llvm] [clang] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-29 Thread David Green via cfe-commits
davemgreen wrote: OK. We would not usually add intrinsics like this without a strong motivating case, that could not be optimized in some other way. It is better to use target independent options when available, and inline assembly is available as a fallback if it is really needed. But I

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-29 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Linking to the issue this is seeking to address for reference: https://github.com/clangd/clangd/issues/1589 https://github.com/llvm/llvm-project/pull/78454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang-tools-extra] [clang] Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass"" (PR #74056)

2024-01-29 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/74056 >From 9be777d5b39852cf3c0b2538fd5f712922672caa Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Fri, 1 Dec 2023 18:00:13 +0900 Subject: [PATCH 1/2] Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass""

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/77890 >From becb1bdebc8d10296a5c9f1af64ebae5ca9b68b7 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 24 Jan 2024 14:55:03 +0100 Subject: [PATCH] [clang] Implement Class Template Argument Deduction (CTAD) for type

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

2024-01-29 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: @sam-mccall review ping :) I would particularly appreciate feedback on whether I should plan to set aside some time to implement the "deep lookup optimization" (from [this comment](https://reviews.llvm.org/D93829#4258101)), or whether the 2.5% increase in index memory

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/77890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] WIP: Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/77890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-29 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/79796 Change AfterPlacementOperator to a boolean. Also add SBPO_None for never inserting a space before a left parenthesis and deprecate SBPO_Never, which meant never inserting a space except when after new/delete.

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-01-29 Thread Matt Arsenault via cfe-commits
@@ -2561,6 +2567,70 @@ bool SIMemoryLegalizer::expandAtomicCmpxchgOrRmw(const SIMemOpInfo , return Changed; } +bool SIMemoryLegalizer::GFX9InsertWaitcntForPreciseMem(MachineFunction ) { arsenm wrote: can you just make this happen as a consequence of the

[clang] [llvm] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #79236)

2024-01-29 Thread Matt Arsenault via cfe-commits
@@ -2561,6 +2567,70 @@ bool SIMemoryLegalizer::expandAtomicCmpxchgOrRmw(const SIMemOpInfo , return Changed; } +bool SIMemoryLegalizer::GFX9InsertWaitcntForPreciseMem(MachineFunction ) { + const GCNSubtarget = MF.getSubtarget(); + const SIInstrInfo *TII =

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Missing changelog, otherwise LGTM https://github.com/llvm/llvm-project/pull/79788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Fixes #54051 This patch implements the C++20 feature -- CTAD for alias templates. It is an initial patch, which covers most of pieces, the major missing piece is to implement the associated constraints

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Haojian Wu via cfe-commits
https://github.com/hokein ready_for_review https://github.com/llvm/llvm-project/pull/77890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-29 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Thanks, the approach in this patch looks pretty good to me. My only feedback is to encapsulate the "hard coding" into a function like: ``` Option TryConvertToRename(const Diag *D, const Fix *F) ``` because I can imagine in the future coming across

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-29 Thread Andrey Ali Khan Bolshakov via cfe-commits
@@ -40,8 +40,12 @@ static const Expr *ignoreTransparentExprs(const Expr *E) { switch (E->getStmtClass()) { case Stmt::OpaqueValueExprClass: -E = cast(E)->getSourceExpr(); -break; +if (const clang::Expr *SE = cast(E)->getSourceExpr()) { + E = SE; +

[clang] [Clang, SystemZ] Split test into Driver and CodeGen parts (NFC) (PR #79808)

2024-01-29 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 approved this pull request. https://github.com/llvm/llvm-project/pull/79808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang, SystemZ] Split test into Driver and CodeGen parts (NFC) (PR #79808)

2024-01-29 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/79808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6d24291 - [Clang, SystemZ] Split test into Driver and CodeGen parts (NFC) (#79808)

2024-01-29 Thread via cfe-commits
Author: Nikita Popov Date: 2024-01-29T14:53:48+01:00 New Revision: 6d242914d784ed848d0f87bf6df9b6b2f2b27566 URL: https://github.com/llvm/llvm-project/commit/6d242914d784ed848d0f87bf6df9b6b2f2b27566 DIFF: https://github.com/llvm/llvm-project/commit/6d242914d784ed848d0f87bf6df9b6b2f2b27566.diff

[flang] [clang-tools-extra] [clang] [llvm] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-29 Thread Yi Wu via cfe-commits
@@ -5934,6 +5938,40 @@ IntrinsicLibrary::genSum(mlir::Type resultType, resultType, args); } +// SYSTEM +void IntrinsicLibrary::genSystem(llvm::ArrayRef args) { + assert(args.size() == 2); + mlir::Value command = fir::getBase(args[0]); + const

[flang] [clang-tools-extra] [clang] [llvm] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-29 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm edited https://github.com/llvm/llvm-project/pull/74309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: The "generic IR" thing is more emergent behaviour than a documented / intentional design. This patch is fine - we shouldn't set macros to nonsense values - but if this is a step towards building libc like the rocm-device-libs there may be push back on that one.

[clang] c9a6e99 - [AMDGPU] Do not emit arch dependent macros with unspecified cpu (#79660)

2024-01-29 Thread via cfe-commits
Author: Joseph Huber Date: 2024-01-29T08:46:14-06:00 New Revision: c9a6e993f7b349405b6c8f9244cd9cf0f56a6a81 URL: https://github.com/llvm/llvm-project/commit/c9a6e993f7b349405b6c8f9244cd9cf0f56a6a81 DIFF: https://github.com/llvm/llvm-project/commit/c9a6e993f7b349405b6c8f9244cd9cf0f56a6a81.diff

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/79660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-29 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [clang-tools-extra] [llvm] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-29 Thread Tom Eccles via cfe-commits
@@ -5934,6 +5938,40 @@ IntrinsicLibrary::genSum(mlir::Type resultType, resultType, args); } +// SYSTEM +void IntrinsicLibrary::genSystem(llvm::ArrayRef args) { + assert(args.size() == 2); + mlir::Value command = fir::getBase(args[0]); + const

[clang] [clang][ASTImporter] fix assert fail due to offset overflow (PR #79084)

2024-01-29 Thread Ding Fei via cfe-commits
@@ -9896,9 +9903,13 @@ Expected ASTImporter::Import(FileID FromID, bool IsBuiltin) { // FIXME: The filename may be a virtual name that does probably not // point to a valid file and we get no Entry here. In this case try with // the memory buffer

[clang-tools-extra] [flang] [clang] [llvm] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-29 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/74309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (PR #79614)

2024-01-29 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. Thanks. LGTM too. https://github.com/llvm/llvm-project/pull/79614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx] [libcxxabi] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -36,7 +36,12 @@ struct __cxa_exception; _LIBCPP_OVERRIDABLE_FUNC_VIS __cxa_exception* __cxa_init_primary_exception( void*, std::type_info*, -void( +# if defined(__USING_WASM_EXCEPTIONS__) ldionne wrote: Let's introduce a typedef name for this

[libunwind] [libcxxabi] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -15,6 +15,7 @@ #include <__libunwind_config.h> +#ifndef __wasm__ ldionne wrote: What is the purpose of this header if it's entirely empty on wasm? https://github.com/llvm/llvm-project/pull/79667 ___

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/79788 >From dde16b48d563b3e279872081bad148614e9d28a3 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Sun, 28 Jan 2024 22:42:53 -0800 Subject: [PATCH] [Clang][Sema] Fix crash when type used in return statement

[libunwind] [libcxx] [libcxxabi] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -35,7 +32,12 @@ struct _Unwind_LandingPadContext { // Communication channel between compiler-generated user code and personality // function -thread_local struct _Unwind_LandingPadContext __wasm_lpad_context; +#if __STDC_VERSION__ >= 202311L ldionne wrote:

[libcxx] [libunwind] [libcxxabi] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxxabi] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -10,14 +10,11 @@ // //===--===// +#if __STDC_VERSION__ < 202311L ldionne wrote: This change seems unrelated to the rest of the patch. https://github.com/llvm/llvm-project/pull/79667

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -12,6 +12,7 @@ #include #include "config.h" +#ifndef __wasm__ ldionne wrote: Similar question as above here. If this file is basically empty on wasm, we should instead avoid adding it in the CMakeLists.txt.

[libcxxabi] [libunwind] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -180,6 +180,7 @@ #endif #define _LIBUNWIND_HIGHEST_DWARF_REGISTER \ _LIBUNWIND_HIGHEST_DWARF_REGISTER_LOONGARCH +#elif defined(__wasm__) ldionne wrote: Why don't we define `_LIBUNWIND_CURSOR_SIZE` and friends on

[libcxxabi] [libunwind] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread via cfe-commits
@@ -7730,6 +7730,14 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">, } // let Visibility = [CC1Option] +def stdlib_hardening_EQ : Joined<["-"], "fstdlib-hardening=">, cor3ntin wrote: It is consistent with `-stdlib`

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Guillot Tony via cfe-commits
@@ -7805,10 +7805,38 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc, TypeSourceInfo *TInfo, diag::err_variable_object_no_init)) return ExprError(); } + } else if (LangOpts.C23 && +

[llvm] [clang] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-29 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/79316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/79788 >From f7f1007954503d013294c2e21ce2160dc7866164 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Sun, 28 Jan 2024 22:42:53 -0800 Subject: [PATCH] [Clang][Sema] Fix crash when type used in return statement

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-29 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/79608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zahira Ammarguellat (zahiraam) Changes This patch is to remove erroneous warning. See https://godbolt.org/z/bYP8P8nqY --- Full diff: https://github.com/llvm/llvm-project/pull/79821.diff 2 Files Affected: - (modified)

[clang] [Clang][NFC] Remove TemplateArgumentList::OnStack (PR #79760)

2024-01-29 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: So I like this! I think it is a good change. I WOULD like to see a release note. I know this isn't particularly 'user visible', but I think, paired with some sort of benchmark, that this would be useful to brag about. We often run out of stack space

[llvm] [clang-tools-extra] [libcxx] [libc++] Introduce one-sided binary search for lower_bound on non-random iterators, and use that to improve the average complexity of set_intersection. (PR #75230)

2024-01-29 Thread Iuri Chaer via cfe-commits
https://github.com/ichaer updated https://github.com/llvm/llvm-project/pull/75230 >From b65415f5b70591eae965cae1316054145d399158 Mon Sep 17 00:00:00 2001 From: Iuri Chaer Date: Tue, 17 Oct 2023 13:52:13 +0100 Subject: [PATCH 01/14] [libc++][test] Add lower_bound complexity validation tests

[clang-tools-extra] [clang] [llvm] LLVM_FAULTMAPS section can be put after the DWARF section. (PR #77107)

2024-01-29 Thread via cfe-commits
https://github.com/shamithoke updated https://github.com/llvm/llvm-project/pull/77107 >From a0ccb2cbe3882a6ea8bb020dd54460f57dd84a90 Mon Sep 17 00:00:00 2001 From: shami Date: Thu, 28 Dec 2023 21:29:36 +0530 Subject: [PATCH] LLVM_FAULTMAPS section can be put after the DWARF section. ---

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-29 Thread Andrey Ali Khan Bolshakov via cfe-commits
https://github.com/bolshakov-a updated https://github.com/llvm/llvm-project/pull/79764 >From b3debeb88fdc3d50f257be56f3e60ae7bf83cc07 Mon Sep 17 00:00:00 2001 From: Bolshakov Date: Sun, 28 Jan 2024 21:12:10 +0300 Subject: [PATCH] Fix crashes on 'StructuralValue' `OpaqueValueExpr` doesn't

[llvm] [clang] [clang-tools-extra] Add STACK_SIZES section for MachOS. (PR #77106)

2024-01-29 Thread via cfe-commits
https://github.com/shamithoke updated https://github.com/llvm/llvm-project/pull/77106 >From e939dbedfa4cd875858825e890310d2581bfa525 Mon Sep 17 00:00:00 2001 From: shami Date: Thu, 28 Dec 2023 21:19:36 +0530 Subject: [PATCH 1/2] Add STACK_SIZES section for MachOS. ---

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-29 Thread Amir Ayupov via cfe-commits
aaupov wrote: Status update: - [sanitizer-windows](https://lab.llvm.org/buildbot/#/builders/127): back to green starting with https://lab.llvm.org/buildbot/#/builders/127/builds/61505 - [libc-aarch64-ubuntu-fullbuild-dbg](https://lab.llvm.org/buildbot/#/builders/223): green

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-29 Thread Jimmy Z via cfe-commits
jimmy-zx wrote: Ping. Can one of you press the merge button? https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Only set the trailing bytes to zero when filling a partially … (PR #79502)

2024-01-29 Thread via cfe-commits
serge-sans-paille wrote: @nikic / @AaronBallman any thought on the general approach? https://github.com/llvm/llvm-project/pull/79502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-29 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/79796 >From d40f2ed71e72c9cee266e63abbae4b9aac1de47c Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 29 Jan 2024 00:43:19 -0800 Subject: [PATCH] [clang-format] Simplify the AfterPlacementOperator option Change

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Guillot Tony via cfe-commits
@@ -7639,6 +7639,8 @@ def err_attribute_arm_mve_polymorphism : Error< "'__clang_arm_mve_strict_polymorphism' attribute can only be applied to an MVE/NEON vector type">; def err_attribute_webassembly_funcref : Error< "'__funcref' attribute can only be applied to a function

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/79821 This patch is to remove warning. See https://godbolt.org/z/bYP8P8nqY >From c22d670259f1d9fc22b6e01bf19d1f2316b1d617 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 29 Jan 2024 04:56:13 -0800 Subject:

[lldb] [clang-tools-extra] [clang] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-29 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: @zmodem, thanks! Added the fix to #79764. https://github.com/llvm/llvm-project/pull/78041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix erroneous warning. (PR #79821)

2024-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/79821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-29 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM for the Static Analyzer. Thanks for fixing this crash. https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dinar Temirbulatov (dtemirbulatov) Changes …or size might be different. The compiler doesn't know in advance if the streaming and non-streaming vector-lengths are different, so it should be safe to give a warning diagnostic to warn the

[clang-tools-extra] [clang] [llvm] LLVM_FAULTMAPS section can be put after the DWARF section. (PR #77107)

2024-01-29 Thread via cfe-commits
shamithoke wrote: @espindola https://github.com/llvm/llvm-project/pull/77107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Only set the trailing bytes to zero when filling a partially … (PR #79502)

2024-01-29 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/79502 >From 376f62b2aa3e1c2ec37b53a66f7525ae02e54172 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 25 Jan 2024 22:12:55 +0100 Subject: [PATCH] [clang] Only set the trailing bytes to zero when

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Setting macros that are reserved names is really unappealing for people. I think that may depend on your background. For example, in the C standard library, there's a whole pile of `WANT` macros that users are expected to define before including a header file to opt in

[clang] [llvm] [clang-tools-extra] [DirectX] Rename DXILOperationCommon.h to DXILABI.h. NFC (PR #78224)

2024-01-29 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/78224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > This seems to have perturbed the HIP build. > > https://lab.llvm.org/staging/#/builders/22/builds/22 > > The problem is that we used to set `__AMDGCN_WAVEFRONTSIZE` for the host > > compilation as well in a bunch of the wave function macros. I think that > > this is just

[clang-tools-extra] [clang] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-01-29 Thread Raoul Wols via cfe-commits
@@ -138,15 +138,9 @@ std::string getNamespaceScope(const Decl *D) { std::string printDefinition(const Decl *D, PrintingPolicy PP, const syntax::TokenBuffer ) { - if (auto *VD = llvm::dyn_cast(D)) { -if (auto *IE = VD->getInit()) { - //

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-29 Thread Carl Peto via cfe-commits
carlos4242 wrote: > LGTM, but please rebase and resolve conflicts. done, rebased, tests pass locally https://github.com/llvm/llvm-project/pull/79037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-29 Thread Bevin Hansson via cfe-commits
https://github.com/bevin-hansson commented: We hit some odd behavior in our downstream after this patch. https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-29 Thread Bevin Hansson via cfe-commits
https://github.com/bevin-hansson edited https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-29 Thread Bevin Hansson via cfe-commits
@@ -4934,6 +4934,73 @@ class DependentDecltypeType : public DecltypeType, public llvm::FoldingSetNode { Expr *E); }; +class PackIndexingType final +: public Type, + public llvm::FoldingSetNode, + private llvm::TrailingObjects { + friend

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-29 Thread Bevin Hansson via cfe-commits
@@ -4934,6 +4934,73 @@ class DependentDecltypeType : public DecltypeType, public llvm::FoldingSetNode { Expr *E); }; +class PackIndexingType final +: public Type, + public llvm::FoldingSetNode, + private llvm::TrailingObjects { + friend

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-29 Thread Balazs Benics via cfe-commits
@@ -40,8 +40,12 @@ static const Expr *ignoreTransparentExprs(const Expr *E) { switch (E->getStmtClass()) { case Stmt::OpaqueValueExprClass: -E = cast(E)->getSourceExpr(); -break; +if (const clang::Expr *SE = cast(E)->getSourceExpr()) { + E = SE; +

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-29 Thread Balazs Benics via cfe-commits
steakhal wrote: > LGTM for the Static Analyzer. Actually, the other hunk also makes sense. LGTM. https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Support of TableGen tokens with unary operator like form, bang operators and numeric literals. (PR #78996)

2024-01-29 Thread Hirofumi Nakamura via cfe-commits
@@ -276,13 +276,44 @@ void FormatTokenLexer::tryMergePreviousTokens() { return; } } - // TableGen's Multi line string starts with [{ - if (Style.isTableGen() && tryMergeTokens({tok::l_square, tok::l_brace}, -

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Guillot Tony via cfe-commits
https://github.com/to268 updated https://github.com/llvm/llvm-project/pull/79845 >From fe082a252d7290730f39228736d93eeea992e041 Mon Sep 17 00:00:00 2001 From: Guillot Tony Date: Mon, 29 Jan 2024 15:14:32 +0100 Subject: [PATCH 1/2] Implementation base of N3006 Underspecified object declarations

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
cor3ntin wrote: Here is what I'd like to do @yronglin Revert the changes to BuildCXXDefaultInit. And land it in main. Then we'll have a few weeks to decide if we backport it to 18. Dies that sound good to you? https://github.com/llvm/llvm-project/pull/76361

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
@@ -429,7 +429,7 @@ C++23 implementation status Lifetime extension in range-based for loops https://wg21.link/P2718R0;>P2718R0 - No + Clang 18 cor3ntin wrote: ```suggestion Clang 19 ```

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Do you need me to merge that for you? https://github.com/llvm/llvm-project/pull/76361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [flang] [libcxx] [llvm] [compiler-rt] [libc] [lldb] [clang-tools-extra] [mlir] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From cff4446c697e4abfb18ea0a17ca2b6596c23015f Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:25:57 +0800 Subject: [PATCH 1/3] [Clang] Implement P2718R0 "Lifetime extension in range-based

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Reverted. I don't think there's a "proper" solution here since this seems to have leaked into the headers due to whoever set this up initially not properly setting these on the host. That seems to be endemic now, so the best we can do it just set it to some dummy values I

[clang-tools-extra] [clang] [llvm] [DirectX] Rename DXILOperationCommon.h to DXILABI.h. NFC (PR #78224)

2024-01-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/78224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-29 Thread via cfe-commits
https://github.com/martinboehme requested changes to this pull request. Thanks for catching this! Can you add a test that fails without the fix? See the existing test `ResultObjectLocation` in TransferTest.cpp -- you should be able to create a new test based on this that has a

[clang] [clang][dataflow] fix assert in `Environment::getResultObjectLocation` (PR #79608)

2024-01-29 Thread via cfe-commits
@@ -536,6 +536,11 @@ class TransferVisitor : public ConstStmtVisitor { copyRecord(*LocSrc, *LocDst, Env); Env.setStorageLocation(*S, *LocDst); +} else { + // CXXOperatorCallExpr can be prvalues, in which case we must create a + // record for them in

[mlir] [llvm] [clang] [AArch64] Replace LLVM IR function attributes for PSTATE.ZA. (PR #79166)

2024-01-29 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/79166 >From f11df4616d319d8f95ae3012ebd74e10b5072041 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Mon, 22 Jan 2024 16:50:41 +0100 Subject: [PATCH 1/2] [AArch64] Replace LLVM IR function attributes for

[llvm] [clang] [mlir] [AArch64] Replace LLVM IR function attributes for PSTATE.ZA. (PR #79166)

2024-01-29 Thread Sander de Smalen via cfe-commits
@@ -22,26 +22,32 @@ Below we describe the LLVM IR attributes and their relation to the C/C++ level ACLE attributes: ``aarch64_pstate_sm_enabled`` -is used for functions with ``__attribute__((arm_streaming))`` +is used for functions with ``__arm_streaming``

[mlir] [llvm] [clang] [AArch64] Replace LLVM IR function attributes for PSTATE.ZA. (PR #79166)

2024-01-29 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/79166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [AArch64] Replace LLVM IR function attributes for PSTATE.ZA. (PR #79166)

2024-01-29 Thread Sander de Smalen via cfe-commits
@@ -1098,11 +1098,15 @@ LogicalResult ModuleTranslation::convertOneFunction(LLVMFuncOp func) { llvmFunc->addFnAttr("aarch64_pstate_sm_compatible"); if (func.getArmNewZa()) -llvmFunc->addFnAttr("aarch64_pstate_za_new"); - else if (func.getArmSharedZa()) -

  1   2   3   4   5   6   >