[clang] f7d9337 - [Sema][NFC] Cleanups after 843cc474f (#87996)

2024-04-08 Thread via cfe-commits
Author: Younan Zhang Date: 2024-04-09T09:53:58+08:00 New Revision: f7d93373969b2b757f5d5ef5e157dabe3bb9b0ae URL: https://github.com/llvm/llvm-project/commit/f7d93373969b2b757f5d5ef5e157dabe3bb9b0ae DIFF: https://github.com/llvm/llvm-project/commit/f7d93373969b2b757f5d5ef5e157dabe3bb9b0ae.diff

[clang] [Sema][NFC] Cleanups after 843cc474f (PR #87996)

2024-04-08 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/87996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From c94d444b4317706c7434853c0c3490826bdbc110 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Haonan Yang via cfe-commits
https://github.com/haonanya edited https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] Revert "[Libomp] Place generated OpenMP headers into build resource d… (PR #88083)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pete Steinfeld (psteinfeld) Changes …irectory (#88007)" This reverts commit 8671429151d5e67d3f21a737809953ae8bdfbfde. This commit broke the flang build, so I'm reverting it. See the comments in merge request #88007 for more

[clang] [openmp] Revert "[Libomp] Place generated OpenMP headers into build resource d… (PR #88083)

2024-04-08 Thread Pete Steinfeld via cfe-commits
https://github.com/psteinfeld created https://github.com/llvm/llvm-project/pull/88083 …irectory (#88007)" This reverts commit 8671429151d5e67d3f21a737809953ae8bdfbfde. This commit broke the flang build, so I'm reverting it. See the comments in merge request #88007 for more information.

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Haonan Yang via cfe-commits
@@ -0,0 +1,94 @@ +// RUN: %clang -x c++ -fsanitize=implicit-bitfield-conversion -target x86_64-linux -S -emit-llvm -o - %s | FileCheck %s --check-prefixes=CHECK,CHECK-BITFIELD-CONVERSION +// RUN: %clang -x c++ -fsanitize=implicit-integer-conversion -target x86_64-linux -S

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Hey, @jhuber. This change broke the flang build. > > When I revert the change, everything builds cleanly. So I reverted it in > merge request #88083. > > After this change was added, I started getting messages like: > > ``` > [4/205] Building CXX object >

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Hey, @jhuber. This change broke the flang build. > > When I revert the change, everything builds cleanly. So I reverted it in > merge request #88083. > > After this change was added, I started getting messages like: > > ``` > [4/205] Building CXX object >

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > So the error is caused by your `c++` not supporting `__has_feature` > presumably. However I have no clue why that would happen due to this patch. I > believe in a few days @jdoerfert will flip the switch and we won't even allow > `libomptarget` to be built without using the

[clang] [clang-format] instanceof is a keyword only in Java/JavaScript (PR #88085)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #87907. --- Full diff: https://github.com/llvm/llvm-project/pull/88085.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+2-1) - (modified)

[clang] [ASTMatchers] fix captureVars assertion failure on capturesVariables (PR #76619)

2024-04-08 Thread Ding Fei via cfe-commits
https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/76619 >From 0ca1a2b2573d1f89a1b4d13cd43628a46c1e5c98 Mon Sep 17 00:00:00 2001 From: dingfei Date: Sun, 31 Dec 2023 00:32:01 +0800 Subject: [PATCH] [ASTMatchers] fix captureVars assertion failure on capturesVariables

[clang] [ASTMatchers] fix captureVars assertion failure on capturesVariables (PR #76619)

2024-04-08 Thread Ding Fei via cfe-commits
danix800 wrote: > LGTM but please add a release note so users know about the bug fix. Release note added. https://github.com/llvm/llvm-project/pull/76619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr (#88008) (PR #88014)

2024-04-08 Thread Ding Fei via cfe-commits
https://github.com/danix800 updated https://github.com/llvm/llvm-project/pull/88014 >From fbd0780923d40b0d8290280731239a722a7af7a9 Mon Sep 17 00:00:00 2001 From: dingfei Date: Tue, 9 Apr 2024 00:26:03 +0800 Subject: [PATCH 1/2] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid InitListExpr

[clang] [clang-format] instanceof is a keyword only in Java/JavaScript (PR #88085)

2024-04-08 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/88085 Fixes #87907. >From 0daef6caaac5d3779cda0d4cbbf9cd2514662b92 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 8 Apr 2024 20:29:26 -0700 Subject: [PATCH] [clang-format] instanceof is a keyword only in

[clang] c7db450 - [clang][NFC] Refactor `EvaluateBinaryTypeTrait` to accept `TypeSourceInfo`

2024-04-08 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-09T08:51:36+03:00 New Revision: c7db450e5c1a83ea768765dcdedfd50f3358d418 URL: https://github.com/llvm/llvm-project/commit/c7db450e5c1a83ea768765dcdedfd50f3358d418 DIFF:

[clang] a30662f - Rework the printing of attributes (#87281)

2024-04-08 Thread via cfe-commits
Author: Vassil Vassilev Date: 2024-04-09T07:14:43+03:00 New Revision: a30662fc2acdd73ca1a9217716299a4676999fb4 URL: https://github.com/llvm/llvm-project/commit/a30662fc2acdd73ca1a9217716299a4676999fb4 DIFF:

[clang] Rework the printing of attributes (PR #87281)

2024-04-08 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/87281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [C++26] Implement P2573R2: `= delete("should have a reason");` (PR #86526)

2024-04-08 Thread via cfe-commits
Sirraide wrote: > I wanted to make you aware of this new core issue > https://cplusplus.github.io/CWG/issues/2876.html (which i think we should > have tests for). Thanks So, as of now, this ```c++ using T = void (); using U = int; T a = delete ("hello"); U b = delete ("hello"), c, d = delete

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

2024-04-08 Thread Chuanqi Xu via cfe-commits
@@ -268,17 +268,34 @@ class alignas(8) Decl { /// } /// void A::f(); // SemanticDC == namespace 'A' ///// LexicalDC == global namespace - llvm::PointerUnion DeclCtx; + llvm::PointerIntPair< ChuanqiXu9 wrote: +1 for more comments. I

[clang] d412047 - [clang][Interp] Fix "Initializing" zero-size arrays

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:04:35+02:00 New Revision: d4120477130a5f9e472753068dcc627baddc44f6 URL: https://github.com/llvm/llvm-project/commit/d4120477130a5f9e472753068dcc627baddc44f6 DIFF: https://github.com/llvm/llvm-project/commit/d4120477130a5f9e472753068dcc627baddc44f6.diff

[clang] acff0b0 - [clang][Interp][NFC] Improve Record debugging

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:55:36+02:00 New Revision: acff0b03167f877f783d9386014e1ebc20db1c2f URL: https://github.com/llvm/llvm-project/commit/acff0b03167f877f783d9386014e1ebc20db1c2f DIFF: https://github.com/llvm/llvm-project/commit/acff0b03167f877f783d9386014e1ebc20db1c2f.diff

[clang] 11ba795 - [clang][Interp][NFC] Add sanity checks to This op

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:55:37+02:00 New Revision: 11ba795565c231a95a7e34bb0e4dff099234c736 URL: https://github.com/llvm/llvm-project/commit/11ba795565c231a95a7e34bb0e4dff099234c736 DIFF: https://github.com/llvm/llvm-project/commit/11ba795565c231a95a7e34bb0e4dff099234c736.diff

[clang] 5d1f779 - [clang][Interp][NFC] Add Dump debug op

2024-04-08 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-09T07:55:36+02:00 New Revision: 5d1f779540517f47abb4927f4ded51cac94fd366 URL: https://github.com/llvm/llvm-project/commit/5d1f779540517f47abb4927f4ded51cac94fd366 DIFF: https://github.com/llvm/llvm-project/commit/5d1f779540517f47abb4927f4ded51cac94fd366.diff

[clang] [Clang] [C++26] Implement P2573R2: `= delete("should have a reason");` (PR #86526)

2024-04-08 Thread via cfe-commits
Sirraide wrote: I’ve also added a parser test for that as well just now. https://github.com/llvm/llvm-project/pull/86526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add Clang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread Corbin Robeck via cfe-commits
CRobeck wrote: Probably want to add a test in: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx12.cl as well. https://github.com/llvm/llvm-project/pull/88076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Haonan Yang via cfe-commits
https://github.com/haonanya edited https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 25e3d2b - Revert "[Libomp] Place generated OpenMP headers into build resource d… (#88083)

2024-04-08 Thread via cfe-commits
Author: Pete Steinfeld Date: 2024-04-08T20:20:27-07:00 New Revision: 25e3d2b0fc1e2b4df19d7f18fbdd04c154e1d0e8 URL: https://github.com/llvm/llvm-project/commit/25e3d2b0fc1e2b4df19d7f18fbdd04c154e1d0e8 DIFF:

[clang] [openmp] Revert "[Libomp] Place generated OpenMP headers into build resource d… (PR #88083)

2024-04-08 Thread Pete Steinfeld via cfe-commits
https://github.com/psteinfeld closed https://github.com/llvm/llvm-project/pull/88083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaSYCL` (PR #88086)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch moves SYCL-related `Sema` functions into new `SemaSYCL` class, following the recent example of OpenACC and HLSL. This is a part of the effort to split `Sema`. Additional context can be

[clang] [clang] Introduce `SemaSYCL` (PR #88086)

2024-04-08 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/88086 This patch moves SYCL-related `Sema` functions into new `SemaSYCL` class, following the recent example of OpenACC and HLSL. This is a part of the effort to split `Sema`. Additional context can be found in

[clang] 5c056b3 - [clang-format] Clean up unit tests from commit 13be0d4a34c4

2024-04-08 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-04-08T21:20:18-07:00 New Revision: 5c056b32350e834924356b1af78504d261d24e42 URL: https://github.com/llvm/llvm-project/commit/5c056b32350e834924356b1af78504d261d24e42 DIFF: https://github.com/llvm/llvm-project/commit/5c056b32350e834924356b1af78504d261d24e42.diff

[clang] 62e9257 - Revert "Rework the printing of attributes (#87281)"

2024-04-08 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2024-04-09T05:03:34Z New Revision: 62e92573d28d62ab7e6438ac34d513b07c51ce09 URL: https://github.com/llvm/llvm-project/commit/62e92573d28d62ab7e6438ac34d513b07c51ce09 DIFF: https://github.com/llvm/llvm-project/commit/62e92573d28d62ab7e6438ac34d513b07c51ce09.diff

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-04-08 Thread Felix via cfe-commits
@@ -3369,6 +3369,59 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, bool Is64Bit = Subtarget.isPPC64(); bool HasAIXSmallLocalExecTLS = Subtarget.hasAIXSmallLocalExecTLS(); TLSModel::Model Model = getTargetMachine().getTLSModel(GV); + // Initialize

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-04-08 Thread Felix via cfe-commits
@@ -3369,6 +3369,59 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, bool Is64Bit = Subtarget.isPPC64(); bool HasAIXSmallLocalExecTLS = Subtarget.hasAIXSmallLocalExecTLS(); TLSModel::Model Model = getTargetMachine().getTLSModel(GV); + // Initialize

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-04-08 Thread Felix via cfe-commits
https://github.com/orcguru deleted https://github.com/llvm/llvm-project/pull/84132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From 24c3253093491d0fbe297bc10cba8552b7bef665 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > How about `llvm.offload`? This might need broader discussion but I'm fine > either way. I don't think it's too important here since these are effectively internal variables. However in the future I want to combine `cuda_offload_entires` and friends into just

[clang] [llvm] [Offload][NFC] Remove `omp_` prefix from offloading entries (PR #88071)

2024-04-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/88071 >From 198e77ad14ff83d2ed9ea80a1dcecafa1b1336a0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 8 Apr 2024 19:10:37 -0500 Subject: [PATCH] [Offload][NFC] Remove `omp_` prefix from offloading entries

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-04-08 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @jcsxky At the glance of the stacktrace, I suspect we probably need some mechanism of deferral codegen while instantiating the enclosing struct. Can you please file a separate issue? https://github.com/llvm/llvm-project/pull/82310 ___

[clang] [llvm] [AMDGPU] Add Clang builtins for amdgcn s_ttrace intrinsics (PR #88076)

2024-04-08 Thread Corbin Robeck via cfe-commits
https://github.com/CRobeck updated https://github.com/llvm/llvm-project/pull/88076 >From 1e2cab61cbf46e5cc73d7ee6523dcce1a75c7549 Mon Sep 17 00:00:00 2001 From: Corbin Robeck Date: Mon, 8 Apr 2024 19:58:57 -0500 Subject: [PATCH 1/3] add clang builtins for amdgcn s_ttrace intrinsics ---

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Pete Steinfeld via cfe-commits
psteinfeld wrote: Hey, @jhuber. This change broke the flang build. When I revert the change, everything builds cleanly. So I reverted it in merge request After this change was added, I started getting messages like: ``` [4/205] Building CXX object

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-08 Thread via cfe-commits
@@ -688,71 +682,51 @@ class TransferVisitor : public ConstStmtVisitor { return; } -llvm::DenseMap FieldLocs; -RecordInitListHelper InitListHelper(S); +RecordStorageLocation = Env.getResultObjectLocation(*S); +Env.setValue(*S,

[clang] 2921a09 - Make the argument -Xcuda-ptxas visible to the driver in cl-mode

2024-04-08 Thread Luke Drummond via cfe-commits
Author: Jefferson Le Quellec Date: 2024-04-08T14:11:43+01:00 New Revision: 2921a0928c71f4ee652a2478283e47ab5ffebf58 URL: https://github.com/llvm/llvm-project/commit/2921a0928c71f4ee652a2478283e47ab5ffebf58 DIFF:

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

2024-04-08 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @erichkeane PR updated. When we encounter a class member access expression with a nested-name-specifier that is invalid, should we simply ignore it and instead use the type of the object expression as the lookup context? This is the current behavior, but it leads to lots

[clang] [CLANG][DRIVER] Resolve Argument Visibility and Duplication Issue for Cuda ToolChain (PR #86807)

2024-04-08 Thread via cfe-commits
https://github.com/ldrumm closed https://github.com/llvm/llvm-project/pull/86807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Win32][ELF] Make CodeView a DebugInfoFormat only for COFF format (PR #87987)

2024-04-08 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/87987 This relands #87149. The previous commit exposed failures on some targets. The reason is only a few targets support COFF ObjectFormatType on Windows:

[clang] [Win32][ELF] Make CodeView a DebugInfoFormat only for COFF format (PR #87987)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Phoebe Wang (phoebewang) Changes This relands #87149. The previous commit exposed failures on some targets. The reason is only a few targets support COFF ObjectFormatType on Windows:

[clang] Reland "[Win32][ELF] Make CodeView a DebugInfoFormat only for COFF format" (PR #87987)

2024-04-08 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/87987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaHLSL` (PR #87912)

2024-04-08 Thread Chris B via cfe-commits
@@ -0,0 +1,37 @@ +//===- SemaHLSL.h - Semantic Analysis for HLSL constructs -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang] Introduce `SemaHLSL` (PR #87912)

2024-04-08 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. I really like this direction. Thank you for taking the initiative on cleaning Sema up! I had one small comment below, but you can take it or leave it. https://github.com/llvm/llvm-project/pull/87912

[clang] [clang] Introduce `SemaHLSL` (PR #87912)

2024-04-08 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/87912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Match against all plugins when parsing microsoft attributes (PR #86426)

2024-04-08 Thread Erich Keane via cfe-commits
@@ -345,6 +345,9 @@ Bug Fixes to Compiler Builtins Bug Fixes to Attribute Support ^^ +- Clang now correctly matches plugin attributes with microsoft ``[attribute]`` syntax. erichkeane wrote: > Microsoft attributes use single

[clang] Match against all plugins when parsing microsoft attributes (PR #86426)

2024-04-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5d7fd6a04a6748936dece9d90481b2ba4ec97e53 6ba913fb0d3efdb17ae481ccad63ccde2170d4e2 --

[libclc] [llvm] [WIP] Libclc tests (PR #87989)

2024-04-08 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/87989 None >From b87c2862491aed03f883d6b124a845b0d7c47699 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/2] [libclc] Refactor build system to allow in-tree

[libclc] [llvm] [WIP] Libclc tests (PR #87989)

2024-04-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 8461d901a770516cf2069fe3bce979a6f8fc8d76...29c9a184c11ed0ba46a8c91b6fbeea828c9fce0d

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-08 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Humble reminder! @PiotrZSL https://github.com/llvm/llvm-project/pull/84481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaHLSL` (PR #87912)

2024-04-08 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,37 @@ +//===- SemaHLSL.h - Semantic Analysis for HLSL constructs -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] 0e87366 - TextNodeDumper.cpp - remove empty switch to fix MSVC "switch statement contains 'default' but no 'case' labels" warning. NFC.

2024-04-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-04-08T14:31:46+01:00 New Revision: 0e8736694f752898ed7957a11a11c42f8f6a98d1 URL: https://github.com/llvm/llvm-project/commit/0e8736694f752898ed7957a11a11c42f8f6a98d1 DIFF: https://github.com/llvm/llvm-project/commit/0e8736694f752898ed7957a11a11c42f8f6a98d1.diff

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

2024-04-08 Thread Erich Keane via cfe-commits
erichkeane wrote: > @erichkeane PR updated. > > When we encounter a class member access expression with a > nested-name-specifier that is invalid, should we simply ignore it and instead > use the type of the object expression as the lookup context? This is the > current behavior, but it

[clang] f139387 - Fix MSVC "not all control paths return a value" warning. NFC.

2024-04-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-04-08T14:31:46+01:00 New Revision: f139387fb6e76a5249e8d7c2d124565e6b566ef4 URL: https://github.com/llvm/llvm-project/commit/f139387fb6e76a5249e8d7c2d124565e6b566ef4 DIFF: https://github.com/llvm/llvm-project/commit/f139387fb6e76a5249e8d7c2d124565e6b566ef4.diff

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-08 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/87320 >From 2d2aa88aab3e47e41588397471a90c03bb55d900 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Tue, 2 Apr 2024 08:00:00 + Subject: [PATCH 1/2] [clang][dataflow] Propagate locations from result

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

2024-04-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/87361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

2024-04-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/87361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reduce the size of Decl and classes derived from it (PR #87361)

2024-04-08 Thread Erich Keane via cfe-commits
@@ -268,17 +268,34 @@ class alignas(8) Decl { /// } /// void A::f(); // SemanticDC == namespace 'A' ///// LexicalDC == global namespace - llvm::PointerUnion DeclCtx; + llvm::PointerIntPair< erichkeane wrote: I don't think it ends

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-08 Thread via cfe-commits
@@ -460,25 +460,35 @@ class TransferVisitor : public ConstStmtVisitor { // So make sure we have a value if we didn't propagate one above. if (S->isPRValue() && S->getType()->isRecordType()) { if (Env.getValue(*S) == nullptr) { -Value *Val =

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-08 Thread via cfe-commits
@@ -385,6 +388,185 @@ getFieldsGlobalsAndFuncs(const Stmt , FieldSet , } } +namespace { + +// Visitor that builds a map from record prvalues to result objects. +// This traverses the body of the function to be analyzed; for each result +// object that it encounters, it

[clang] [clang-tools-extra] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base clas

2024-04-08 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > Sorry, I'm not really getting the question here. Obviously that 2nd error is > invalid and we shouldn't be emitting it, and doing the `::z` lookup inside of > `A` seems wrong to me. But I'm not sure I get the issue. We currently emit the second error. I'm asking if we

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-08 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM, Would be good to run it on llvm or any other code base, and check what it found. https://github.com/llvm/llvm-project/pull/84481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-08 Thread via cfe-commits
martinboehme wrote: I think all comments should be addressed. @Xazax-hun Should be ready for further review. @ymand LMK if you have any additional comments. https://github.com/llvm/llvm-project/pull/87320 ___ cfe-commits mailing list

[clang] [clang-tools-extra] [clang-tidy][dataflow] Add `bugprone-null-check-after-dereference` check (PR #84166)

2024-04-08 Thread via cfe-commits
@@ -110,6 +110,12 @@ New checks Detects error-prone Curiously Recurring Template Pattern usage, when the CRTP can be constructed outside itself and the derived class. +- New :doc:`bugprone-null-check-after-dereference + ` check. + + This check identifies redundant

[clang] [clang-tools-extra] [clang-tidy][dataflow] Add `bugprone-null-check-after-dereference` check (PR #84166)

2024-04-08 Thread via cfe-commits
@@ -217,34 +231,72 @@ void matchDereferenceExpr(const Stmt *stmt, Env.assume(Env.arena().makeNot(getVal(kIsNull, *RootValue).formula())); } -void matchCastExpr(const CastExpr *cond, const MatchFinder::MatchResult , - NullPointerAnalysisModel::TransferArgs

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

2024-04-08 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks. This seems to fix that problem. However, now I'm seeing missing dep in build ordering: ``` [1793/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv

[clang] [OpenACC] Implement Sema work for OpenACC Clauses (PR #87821)

2024-04-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/87821 >From ca5f957bb002d79997e630cdf1aaad5703ea2ba4 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 5 Apr 2024 10:53:47 -0700 Subject: [PATCH 1/2] [OpenACC] Implement Sema work for OpenACC Clauses Now that

[clang] [RISCV] Disallow target attribute use in multiversioning (PR #85899)

2024-04-08 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/85899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Doc][HLSL] Add documentation for root signature. (PR #83933)

2024-04-08 Thread Chris B via cfe-commits
https://github.com/llvm-beanz requested changes to this pull request. I think we need to break this PR up into different parts going to different places. Documenting the RootSignature grammar and usage in the Clang docs makes sense. I think documentation of the RootSignature binary format

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Jan Svoboda (jansvoboda11) Changes When writing out a PCM, we compute the set of module maps that did affect the compilation and we strip the rest to make the output independent of them. The most common way to read a module map

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clangd Author: Jan Svoboda (jansvoboda11) Changes Clang uses the `HeaderFileInfo` struct to track bits of information on header files, which gets used throughout the compiler. We also use this to compute the set of affecting

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/87848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/87848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Rework the printing of attributes (PR #87281)

2024-04-08 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/87281 >From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Mon, 1 Apr 2024 15:01:33 + Subject: [PATCH 01/11] Revert "Remove extra switch from 0323938d" This

[clang] Rework the printing of attributes (PR #87281)

2024-04-08 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/87281 >From 94f1c8653903cc3db55abd641c68a9dd11f05df3 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Mon, 1 Apr 2024 15:01:33 + Subject: [PATCH 1/5] Revert "Remove extra switch from 0323938d" This

[clang] [clang] Add CodeGen tests for CWG 6xx issues (PR #87876)

2024-04-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/87876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add CodeGen tests for CWG 6xx issues (PR #87876)

2024-04-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/87876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add CodeGen tests for CWG 6xx issues (PR #87876)

2024-04-08 Thread Erich Keane via cfe-commits
@@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -std=c++98 %s -triple x86_64-linux-gnu -emit-llvm -o - -fexceptions -fcxx-exceptions -pedantic-errors | llvm-cxxfilt -n | FileCheck %s --check-prefixes CHECK +// RUN: %clang_cc1 -std=c++11 %s -triple x86_64-linux-gnu -emit-llvm -o -

[clang] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-08 Thread John McCall via cfe-commits
rjmccall wrote: It'll be tested in a follow-up commit which actually adds parsing and Sema support for these as qualifiers. That should be sufficient rather than adding a whole unit-test apparatus. Daniil is just trying to avoid landing this in a single massive commit.

[clang] [compiler-rt] Fix "[clang][UBSan] Add implicit conversion check for bitfields" (PR #87761)

2024-04-08 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I'll land after presubmit checks https://github.com/llvm/llvm-project/pull/87761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread Joseph Huber via cfe-commits
@@ -10,12 +10,19 @@ include(ExtendPath) +# The generated headers will be placed in clang's resource directory if present. +if(${OPENMP_STANDALONE_BUILD}) + set(LIBOMP_HEADERS_INTDIR ${CMAKE_CURRENT_BINARY_DIR}) +else() + set(LIBOMP_HEADERS_INTDIR

[clang] [openmp] [Libomp] Place generated OpenMP headers into build resource directory (PR #88007)

2024-04-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: These headers are a part of the compiler's resource directory once installed. However, they are currently placed in the binary directory temporarily. This makes it more difficult to use the compiler

[clang-tools-extra] [clang-tidy] Allow renaming macro arguments (PR #87792)

2024-04-08 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: > the user may not have the ability to change the definition of the macro to be > able to appease the check My understanding of this PR is that the user would only need to change what they pass into the macro, not the macro itself, or? E.g. ```cpp -MY_MACRO(foo)

[clang] 4d6e67f - Fix build issue committed in 26fee0ff12

2024-04-08 Thread via cfe-commits
Author: erichkeane Date: 2024-04-08T09:08:21-07:00 New Revision: 4d6e67f677bdf40360e6aaba171bcdec93990b01 URL: https://github.com/llvm/llvm-project/commit/4d6e67f677bdf40360e6aaba171bcdec93990b01 DIFF: https://github.com/llvm/llvm-project/commit/4d6e67f677bdf40360e6aaba171bcdec93990b01.diff

[clang] [clang-tools-extra] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/87848 >From ee56548604be9473f33cd809c901886f37a3d8e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 5 Apr 2024 15:12:39 -0700 Subject: [PATCH 1/3] [clang][modules] Do not resolve `HeaderFileInfo`

[clang] Fix/interp init list unnamed bitfields (PR #87799)

2024-04-08 Thread via cfe-commits
@@ -0,0 +1,114 @@ +// UNSUPPORTED: asserts +// REQUIRES: asserts +// ^ this attempts to say "don't actually run this test", because it's broken sethp wrote: Sounds good, I'll take a look at it when I get a chance. https://github.com/llvm/llvm-project/pull/87799

[clang] Match against all plugins when parsing microsoft attributes (PR #86426)

2024-04-08 Thread via cfe-commits
https://github.com/apache-hb updated https://github.com/llvm/llvm-project/pull/86426 >From 245a21512d8658225b17b91b8af4764f54084e01 Mon Sep 17 00:00:00 2001 From: Elliot <35050275+apache...@users.noreply.github.com> Date: Sun, 24 Mar 2024 03:03:47 -0400 Subject: [PATCH 1/8] Match against all

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-08 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/87849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaHLSL` (PR #87912)

2024-04-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/87912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[AArch64] Add support for -ffixed-x30" (PR #88019)

2024-04-08 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/88019 This reverts commit e770153865c53c4fd72a68f23acff33c24e42a08. This wasn't reviewed, and the functionality in question was intentionally rejected the last time it was discussed in

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-04-08 Thread Akash Banerjee via cfe-commits
TIFitis wrote: @jsjodin @jdoerfert Hi, this patch has been sitting for a while now. Would be great to get it reviewed and accepted. Thanks. https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add test for CWG593 (PR #87752)

2024-04-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I hte this behavior, but it is to standard. https://github.com/llvm/llvm-project/pull/87752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Add handling of the `-nostdlibinc` option to ccc-analyzer (PR #88017)

2024-04-08 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/88017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >