john.brawn created this revision.
john.brawn added reviewers: rafael, ab.
john.brawn added a subscriber: cfe-commits.
john.brawn set the repository for this revision to rL LLVM.
The fix for this is in LLVM but it depends on how clang handles the alias
attribute, so add a test to the clang tests
jroelofs added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include __config_site
+
#ifdef __GNUC__
jroelofs wrote:
mclow.lists wrote:
espositofulvio wrote:
mclow.lists wrote:
I'm reluctant to do this; because every include file
Author: john.brawn
Date: Wed Aug 12 10:15:27 2015
New Revision: 244756
URL: http://llvm.org/viewvc/llvm-project?rev=244756view=rev
Log:
Add test for PR24379
The fix for this is in LLVM but it depends on how clang handles the alias
attribute, so add a test to the clang tests to make sure
mclow.lists added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include __config_site
+
#ifdef __GNUC__
espositofulvio wrote:
mclow.lists wrote:
I'm reluctant to do this; because every include file slows down compilation
- for every
rcraik added a comment.
ping 2!
http://reviews.llvm.org/D11582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D11980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasin updated this revision to Diff 31979.
krasin added a comment.
Windows compat
http://reviews.llvm.org/D11968
Files:
include/clang/Frontend/DependencyOutputOptions.h
include/clang/Frontend/Utils.h
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
krasin added a comment.
Thank you, Peter.
I will commit once I have restored my password (the email to Chris is sent)
http://reviews.llvm.org/D11968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
honggyu.kim accepted this revision.
honggyu.kim added a reviewer: honggyu.kim.
honggyu.kim added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D10356#219772, @krememek wrote:
Committed r244400
Thanks for accepting it!
http://reviews.llvm.org/D10356
Author: dblaikie
Date: Wed Aug 12 18:59:02 2015
New Revision: 244843
URL: http://llvm.org/viewvc/llvm-project?rev=244843view=rev
Log:
Wdeprecated: LambdaScopeInfos need to be copied, so make the ScopeInfo
hierarchy safely copyable
Making the base class's copy ctor protected and the derived
Author: dblaikie
Date: Wed Aug 12 18:09:24 2015
New Revision: 244829
URL: http://llvm.org/viewvc/llvm-project?rev=244829view=rev
Log:
-Wdeprecated: Job objects are stored in a vector yet are not really copyable,
make them movable instead
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
dougk created this revision.
dougk added a reviewer: chandlerc.
dougk added a subscriber: cfe-commits.
I think this conveys the intent better. Alternatively, since it's effectively
trying to take llvm::sys::path::parent_path() for a number of times determined
by the occurrences of '/' in one
martell updated this revision to Diff 32007.
martell added a comment.
Updated to address yaron's comments.
Okay for me to merge now ?
http://reviews.llvm.org/D11808
Files:
lib/Driver/MinGWToolChain.cpp
test/Driver/Inputs/mingw_clang_tree/mingw32/i686-w64-mingw32/include/.keep
Author: rsmith
Date: Wed Aug 12 19:45:11 2015
New Revision: 244852
URL: http://llvm.org/viewvc/llvm-project?rev=244852view=rev
Log:
Add SourceManager::dump() to dump the current set of SLocEntries.
Modified:
cfe/trunk/include/clang/Basic/SourceManager.h
On Wed, Aug 12, 2015 at 11:16 AM, David Blaikie dblai...@gmail.com wrote:
On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber tha...@chromium.org wrote:
On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie dblai...@gmail.com
wrote:
On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber tha...@chromium.org
george.burgess.iv created this revision.
george.burgess.iv added a subscriber: cfe-commits.
Attached is a fix for https://llvm.org/bugs/show_bug.cgi?id=15212 .
Summary: Tighten up some of the results for __builtin_object_size(ptr, type)
when given type == 1 or type == 3 + fixed a bug where we
- Original Message -
From: Dan Albert via cfe-commits cfe-commits@lists.llvm.org
To: Marshall Clow mclow.li...@gmail.com
Cc: Joerg Sonnenberger jo...@britannica.bec.de, cfe-commits
cfe-commits@lists.llvm.org
Sent: Wednesday, August 12, 2015 6:03:30 PM
Subject: Re: [PATCH] D11948:
My testing was varied. I could not get GCC or clang to optimize it away for
Linux, but both did for ARM Android.
Regardless, the fact that GCC is already doing this doesn't mean it's
desirable. We end up hunting and fixing bugs from this optimization this
every release, and our time could be
On Wed, Aug 12, 2015 at 6:05 PM, Richard Smith rich...@metafoo.co.uk
wrote:
On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva chisophu...@gmail.com wrote:
On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith rich...@metafoo.co.uk
wrote:
On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva
rjmccall added a comment.
You only have one attempt to define the function here; I don't see the problem.
Recall that I said to add a flag to getOrCreateLLVMFunction that says whether
the caller intends to define the function. The rule should be that only
callers that pass true should be
yaron.keren added a comment.
Yes, go ahead.
http://reviews.llvm.org/D11808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sunfish updated this revision to Diff 32025.
sunfish marked 3 inline comments as done.
sunfish added a comment.
Minor changes to address review comments.
Repository:
rL LLVM
http://reviews.llvm.org/D12002
Files:
include/clang/Basic/BuiltinsWebAssembly.def
Author: krasin
Date: Wed Aug 12 23:04:37 2015
New Revision: 244867
URL: http://llvm.org/viewvc/llvm-project?rev=244867view=rev
Log:
Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.
Summary:
Clang sanitizers, such as AddressSanitizer, ThreadSanitizer, MemorySanitizer,
Control
On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith rich...@metafoo.co.uk
wrote:
On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva chisophu...@gmail.com
wrote:
silvas added a subscriber: silvas.
Comment at: lib/Parse/Parser.cpp:2003
@@ +2002,3 @@
+Diag(Tok,
On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva chisophu...@gmail.com wrote:
On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith rich...@metafoo.co.uk
wrote:
On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva chisophu...@gmail.com
wrote:
silvas added a subscriber: silvas.
Comment
Author: rafael
Date: Wed Aug 12 20:07:06 2015
New Revision: 244855
URL: http://llvm.org/viewvc/llvm-project?rev=244855view=rev
Log:
Update for llvm api change.
Modified:
cfe/trunk/tools/driver/driver.cpp
Modified: cfe/trunk/tools/driver/driver.cpp
URL:
ismail added a comment.
Tests pass but, now when I tried to compile a file with -fopenmp I get:
LINK: fatal error LNK1104: cannot open file 'libomp.lib'
libomp.lib does exist in C:\Program Files\LLVM\lib but I guess we need to
pass the library path down to linker.
jroelofs updated this revision to Diff 31949.
jroelofs added a comment.
Add license text to the new file, and move the two has-no-threads tests to
test/libcxx.
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
include/CMakeLists.txt
include/__config
include/__config_site.in
diltsman updated this revision to Diff 31952.
diltsman marked an inline comment as done.
http://reviews.llvm.org/D10365
Files:
../llvm/tools/clang/include/clang/Tooling/JSONCompilationDatabase.h
../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp
On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki
daniel.marjam...@evidente.se wrote:
ideally there should be no -Wunused-parameter compiler warning when the
parameter is used.
would it feel better to move the FP warnings about virtual functions,
for instance to clang-tidy?
If you
Author: hans
Date: Wed Aug 12 11:40:42 2015
New Revision: 244761
URL: http://llvm.org/viewvc/llvm-project?rev=244761view=rev
Log:
ReleaseNotes: Small version nbr fix
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
alexfh added a comment.
Something weird happened with the file names in this CL after the latest
update, e.g. there are both `clang-tidy/CMakeLists.txt` and `CMakeLists.txt`.
How exactly did you create the Differential revision and update it?
Comment at:
davide updated this revision to Diff 31932.
davide added a comment.
- Refactored check
- Added test for -ffreestanding in C
- Changed the diagnostic emitted
Also, thanks for your time and guidance.
http://reviews.llvm.org/D11658
Files:
include/clang/Basic/DiagnosticSemaKinds.td
klimek added a comment.
Ok, we're very close now :) Thanks for taking the time to work through this!
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299
@@ +298,3 @@
+if (CommandFound) {
+ ErrorMessage = Multiple command and arguments
On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie dblai...@gmail.com wrote:
On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber tha...@chromium.org wrote:
On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki
daniel.marjam...@evidente.se wrote:
ideally there should be no -Wunused-parameter compiler
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
This is a first step towards making macro diagnostics better.
http://reviews.llvm.org/D11778
___
cfe-commits mailing list
On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber tha...@chromium.org wrote:
On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie dblai...@gmail.com
wrote:
On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber tha...@chromium.org wrote:
On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki
Author: aaronballman
Date: Wed Aug 12 14:00:39 2015
New Revision: 244792
URL: http://llvm.org/viewvc/llvm-project?rev=244792view=rev
Log:
RangRangify some more for loops; NFC.
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
LGTM!
~Aaron
On Wed, Aug 12, 2015 at 1:40 PM, Nathan Wilson nwilso...@gmail.com wrote:
nwilson updated this revision to Diff 31957.
nwilson added a comment.
Addressing comments which were discussed on the mailing list - Apply the same
text when diagnosing a free standing declaration as
Author: dougk
Date: Wed Aug 12 13:36:12 2015
New Revision: 244791
URL: http://llvm.org/viewvc/llvm-project?rev=244791view=rev
Log:
Don't compare getArchName() to tce as a string. NFC.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Driver/Driver.cpp
URL:
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks fine, go ahead once you're satisfied that the performance is OK for the
`requires excluded` / umbrella dir hack.
Comment at: include/clang/Basic/Module.h:363
@@ +362,3
chandlerc added a comment.
This isn't necessary. The TC that we assign to is a reference to the pointer in
the map. It should already be caching.
http://reviews.llvm.org/D11983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rsmith added a comment.
In principle, normalizing slashes on Windows makes sense here. But we shouldn't
use `llvm::sys::path::native`, because it's just too broken.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString1024 NativeFilename;
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244788: Stop printing macro backtraces that don't help
diagnostics. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D11778?vs=31425id=31965#toc
Repository:
rL LLVM
Author: alexfh
Date: Wed Aug 12 14:29:57 2015
New Revision: 244793
URL: http://llvm.org/viewvc/llvm-project?rev=244793view=rev
Log:
[clang-tidy] Make FileOptionsProvider fields protected to make extending it
easier
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.h
Modified:
On 08/12/15 11:24, James Y Knight wrote:
Sorry for the miscommunication, I thought you were going to commit it
already. LGTM.
Oh, I was waiting for someone to say something. Thanks.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be
On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: aaronballman
Date: Wed Aug 12 14:00:39 2015
New Revision: 244792
URL: http://llvm.org/viewvc/llvm-project?rev=244792view=rev
Log:
RangRangify some more for loops; NFC.
Modified:
Author: hans
Date: Wed Aug 12 14:45:01 2015
New Revision: 244797
URL: http://llvm.org/viewvc/llvm-project?rev=244797view=rev
Log:
Docs: keep copyright years up-to-date
Modified:
cfe/trunk/docs/conf.py
Modified: cfe/trunk/docs/conf.py
URL:
On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie dblai...@gmail.com wrote:
On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: aaronballman
Date: Wed Aug 12 14:00:39 2015
New Revision: 244792
URL:
On Wed, Aug 12, 2015 at 1:03 PM, Aaron Ballman aa...@aaronballman.com
wrote:
On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie dblai...@gmail.com wrote:
On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: aaronballman
Date: Wed Aug
50 matches
Mail list logo
