Author: klimek
Date: Fri Aug 14 06:47:51 2015
New Revision: 245040
URL: http://llvm.org/viewvc/llvm-project?rev=245040view=rev
Log:
Fix AST matcher documentation.
Fix a bug in the matcher docs where callExpr(on(...)) was in the examples,
but didn't work (on() only works for memberCallExpr).
Fix
alexfh closed this revision.
alexfh added a comment.
Committed revision 245045.
http://reviews.llvm.org/D11946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Fri Aug 14 08:39:57 2015
New Revision: 245048
URL: http://llvm.org/viewvc/llvm-project?rev=245048view=rev
Log:
misc-unused-parameters: Fix crasher with C forward declarations that
can leave out the parameter list.
Modified:
Author: davide
Date: Fri Aug 14 09:13:29 2015
New Revision: 245051
URL: http://llvm.org/viewvc/llvm-project?rev=245051view=rev
Log:
[Sema] main can't be declared as global variable, in C++.
So, we now reject that. We also warn for any external-linkage global
variable named main in C, because it
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:746
@@ -739,1 +745,3 @@
+return static_castDERIVED*(this)-hasTrait(MR, IK);
+ }
};
Hmm.. Either we completely encapsulate 'RegionAndSymbolInvalidationTraits' in
the
klimek added a comment.
Unfortunately I can't get the patch to apply cleanly due to different line
endings.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc created this revision.
pcc added a reviewer: rsmith.
pcc added subscribers: cfe-commits, Prazek.
This function can be used to create a metadata identifier for a specific
type. No functionality change, but this will be used by D11857 and D12026.
http://reviews.llvm.org/D12038
Files:
hans added a comment.
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kulpreet updated this revision to Diff 32174.
kulpreet added a comment.
- Incorporated feedback from Devin's review
- Moved LSM over to StringSet
http://reviews.llvm.org/D11572
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
aaron.ballman updated this revision to Diff 32175.
aaron.ballman added a comment.
Updated the patch to handle member initializers as well as base class
initializers. This changes the name of things from base to init as well.
http://reviews.llvm.org/D11784
Files:
(+ the new cfe-commits list; sorry for the spam)
On Fri, Aug 14, 2015 at 1:25 PM, Hans Wennborg h...@chromium.org wrote:
Reid and Nico suggested this should be merged to 3.7 together with
r244468 as it fixes an issue with libc++ when compiled with Clang on
x86_64 Android.
John, you're the
Author: rnk
Date: Fri Aug 14 14:03:02 2015
New Revision: 245083
URL: http://llvm.org/viewvc/llvm-project?rev=245083view=rev
Log:
Don't run explicit-modules-missing-files.cpp on Windows
It is flaky due to inability to remove files with open handles. We
could paper over it with rm -f, but then
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
On Fri, Aug 14, 2015 at 12:25 PM, Martell Malone
martellmal...@gmail.com wrote:
martell added a comment.
Hans this is something we most definitely should have in 3.7
It's a pretty big bugfix for this target :)
Author: zaks
Date: Fri Aug 14 15:22:22 2015
New Revision: 245093
URL: http://llvm.org/viewvc/llvm-project?rev=245093view=rev
Log:
[analyzer] Add checkers for OS X / iOS localizability issues
Add checkers that detect code-level localizability issues for OS X / iOS:
- A path sensitive checker
xazax.hun added a comment.
Addressed the suggestions.
Comment at: lib/StaticAnalyzer/Checkers/ObjCGenericsChecker.cpp:257
@@ +256,3 @@
+// However a downcast may also lose information. E. g.:
+// MutableMapT, U : Map
+// The downcast to mutable map loses the
martell added a comment.
Landed in http://reviews.llvm.org/rL245084
The commit parser is bugged :/
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Chris Bieneman be...@apple.com writes:
beanz added a comment.
dblaikie,
I've run this through check-all with no issues.
Might want to bootstrap with sanitizers or something. Strict aliasing
related bugs can be subtle.
___
cfe-commits mailing list
I'm OK with it if Richard gives owner's approval.
Cheers,
Hans
On Thu, Aug 13, 2015 at 8:27 PM, Martell Malone martellmal...@gmail.com wrote:
Hi Hans,
Is this bugfix something that can be merged into 3.7 ?
Kind Regards
Martell
On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone
beanz added a comment.
echristo,
I can move the makefile check to the autoconf check, but I think setting the
flags should stay in the clang CMakeLists/Makefile otherwise it will change
behavior. Today we only enable this flag for the clang subdirectory, not all of
LLVM.
Thoughts?
jfb added inline comments.
Comment at: lib/Basic/Targets.cpp:6938
@@ +6937,3 @@
+BigEndian = false;
+NoAsmVariants = true;
+SuitableAlign = 128;
True, leaving it as is sgtm.
Comment at: lib/Basic/Targets.cpp:6994
@@ +6993,3 @@
nwilson added a comment.
Ping
http://reviews.llvm.org/D11789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks! r245116.
On Fri, Aug 14, 2015 at 3:30 PM, Richard Smith rich...@metafoo.co.uk wrote:
Sorry for the delay, this LGTM for branch.
On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov 1101.deb...@gmail.com wrote:
Ping
--
AlexDenisov
Software Engineer, http://lowlevelbits.org
On 06 Aug
rsmith added a subscriber: rsmith.
Comment at: lib/AST/ExprConstant.cpp:6221-6223
@@ +6220,5 @@
+ //
+ // extern struct X { char buff[32]; int a, b, c; } *p;
+ // int a = __builtin_object_size(p-buff + 4, 3); // returns 28
+ // int b = __builtin_object_size(p-buff + 4,
On Fri, Aug 14, 2015 at 1:55 PM, John McCall rjmcc...@apple.com wrote:
On Aug 14, 2015, at 1:25 PM, Hans Wennborg h...@chromium.org wrote:
Reid and Nico suggested this should be merged to 3.7 together with
r244468 as it fixes an issue with libc++ when compiled with Clang on
x86_64 Android.
Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build (I’ll
clean up the patches and send those out separately). check-clang worked with
asan and ubsan enabled.
Is that sufficient pre-commit testing?
I still need to rework the Makefile side of the patch to match Eric’s
Sorry for the delay, this LGTM for branch.
On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov 1101.deb...@gmail.com wrote:
Ping
--
AlexDenisov
Software Engineer, http://lowlevelbits.org
On 06 Aug 2015, at 18:15, Hans Wennborg h...@chromium.org wrote:
Hi Alex,
What crash is that? I don't
rsmith added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:4700-4703
@@ +4699,6 @@
+if (Member-getAttrDLLExportAttr()) {
+ if (TSK == TSK_ExplicitInstantiationDeclaration)
+// Don't go any further if this is just an explicit instantiation
+//
ehsan added a comment.
Sorry, I kind of dropped the ball here!
At Mozilla we ended up deciding on allowing only a maximum of one of virtual,
final or override per function declaration, similar to the Google coding style,
so we won't need the KeepVirtual option. Should I still add it
sunfish updated this revision to Diff 32192.
sunfish marked an inline comment as done.
sunfish added a comment.
- set MaxAtomicInlineWidth to 0 for now (sets *_ATOMIC_*_LOCK_FREE to 1)
- enable LargeArrayAlign
- enable __int128
- various cleanups
Repository:
rL LLVM
sunfish added inline comments.
Comment at: lib/Basic/Targets.cpp:7010
@@ +7009,3 @@
+ { #ID, TYPE, ATTRS, HEADER, ALL_LANGUAGES, nullptr },
+#include clang/Basic/BuiltinsWebAssembly.def
+};
WebAssembly32TargetInfo is subclassed in LLVM code, and getTargetDefines
Author: nwilson
Date: Fri Aug 14 18:19:32 2015
New Revision: 245123
URL: http://llvm.org/viewvc/llvm-project?rev=245123view=rev
Log:
[CONCEPTS] Add diagnostic; invalid tag when concept specified
Summary: Adding check to emit diagnostic for invalid tag when concept is
specified and associated
Author: chapuni
Date: Fri Aug 14 21:05:49 2015
New Revision: 245146
URL: http://llvm.org/viewvc/llvm-project?rev=245146view=rev
Log:
clang-tools-extra/test/clang-tidy/modernize-pass-by-value.cpp: Appease
targeting MS to give -fno-delayed-template-parsing.
Modified:
sfantao updated this revision to Diff 32211.
sfantao added a comment.
This patch tries to avoid as much as possible changing the common
infrastructure, by adapting the CapturedDecl creation in SEMA and by adding
support to a second type of capture - ImplicitParamDecl (on top of the existent
jyknight updated this revision to Diff 32216.
jyknight added a comment.
Updated for review comments
http://reviews.llvm.org/D11845
Files:
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
test/Driver/integrated-as.s
Index: test/Driver/integrated-as.s
jyknight added inline comments.
Comment at: lib/Driver/Tools.cpp:2928
@@ +2927,3 @@
+/// Parses the various -fpic/-fPIC/-fpie/-fPIE arguments. Then,
+/// smooshes them together with platform defaults, to decide with
+/// whether this compile should be using PIC mode or not.
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Basic/Targets.cpp:7002
@@ +7001,3 @@
+ bool isCLZForZeroUndef() const override final { return false; }
+ bool hasInt128Type() const override final { return
sfantao added a comment.
Alexey, John,
Thanks for the review! I've tried to address your concerns in the last diff.
Please, check the inlined comments to find answers for the remarks of the
previous diff.
Thanks again!
Samuel
Comment at:
Author: majnemer
Date: Fri Aug 14 22:21:08 2015
New Revision: 245153
URL: http://llvm.org/viewvc/llvm-project?rev=245153view=rev
Log:
[MS ABI] Switch catchpad/cleanuppad to use tokens
Modified:
cfe/trunk/lib/CodeGen/CGCleanup.cpp
cfe/trunk/lib/CodeGen/CGException.cpp
Author: rsmith
Date: Fri Aug 14 19:34:15 2015
New Revision: 245136
URL: http://llvm.org/viewvc/llvm-project?rev=245136view=rev
Log:
[modules] Stop dropping 'module.timestamp' files into the current directory
when building with implicit modules disabled.
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245139: Delay emitting members of dllexport classes until
the class is fully parsed… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D11850?vs=32201id=32207#toc
Repository:
rL
Author: hans
Date: Fri Aug 14 20:18:16 2015
New Revision: 245139
URL: http://llvm.org/viewvc/llvm-project?rev=245139view=rev
Log:
Delay emitting members of dllexport classes until the class is fully parsed
(PR23542)
This enables Clang to correctly handle code such as:
struct
Chris Bieneman be...@apple.com writes:
Ok… I wrote some CMake goop to enable sanitizers on a bootstrap build
(I’ll clean up the patches and send those out separately). check-clang
worked with asan and ubsan enabled.
Is that sufficient pre-commit testing?
Yes, I'd expect that to shake out any
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
This patch needs tests.
We should treat the improvements to HTML uniquing separately from this patch.
But I think it's not a critical issue as of now and it can be considered
modocache created this revision.
modocache added a reviewer: cfe-commits.
Depends on http://reviews.llvm.org/D12047.
Add a unit test which demonstrates the bug reported in
https://llvm.org/bugs/show_bug.cgi?id=24404.
If the macro is enclosed within parentheses, the warning is reported as
On Fri, Aug 14, 2015 at 2:02 PM, Hans Wennborg h...@chromium.org wrote:
On Fri, Aug 14, 2015 at 1:55 PM, John McCall rjmcc...@apple.com wrote:
On Aug 14, 2015, at 1:25 PM, Hans Wennborg h...@chromium.org wrote:
Reid and Nico suggested this should be merged to 3.7 together with
r244468 as it
Author: chapuni
Date: Fri Aug 14 20:56:49 2015
New Revision: 245145
URL: http://llvm.org/viewvc/llvm-project?rev=245145view=rev
Log:
clangStaticAnalyzerCheckers: Update libdesp.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CMakeLists.txt
Modified:
modocache created this revision.
modocache added a reviewer: cfe-commits.
The tests that verify that accessing a property without using the result
emits a warning were needlessly complicated. Remove several layers of
abstraction to make the tests much simpler to read and reason about.
Author: jyknight
Date: Fri Aug 14 22:45:25 2015
New Revision: 245154
URL: http://llvm.org/viewvc/llvm-project?rev=245154view=rev
Log:
Tiny cleanup: move some Triple variables up to the top of the
function, and remove a duplicate var.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245063: Represent 2 parallel string arrays as one
string[][2] array. (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D11991?vs=31977id=32157#toc
Repository:
rL LLVM
On Fri, Aug 14, 2015 at 5:25 AM, Alexey Bataev via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: abataev
Date: Fri Aug 14 07:25:37 2015
New Revision: 245041
URL: http://llvm.org/viewvc/llvm-project?rev=245041view=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24371: Assert failure
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this! Looks good with a comment.
Comment at: clang-tidy/IncludeSorter.cpp:118
@@ +117,3 @@
+ if (SourceLocations.empty()) {
+// If there are no
angelgarcia updated this revision to Diff 32146.
angelgarcia added a comment.
Add comments.
http://reviews.llvm.org/D12017
Files:
clang-tidy/IncludeInserter.cpp
clang-tidy/IncludeSorter.cpp
clang-tidy/IncludeSorter.h
unittests/clang-tidy/IncludeInserterTest.cpp
Index:
aaron.ballman added a comment.
In http://reviews.llvm.org/D11784#224430, @alexfh wrote:
In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
One thing I am not certain of in this patch is how to test it. I have
Author: abataev
Date: Fri Aug 14 07:25:37 2015
New Revision: 245041
URL: http://llvm.org/viewvc/llvm-project?rev=245041view=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender 2.75.
blender uses statements expression in condition of the loop under control of
the
alexfh closed this revision.
alexfh added a comment.
Committed revision 245042.
http://reviews.llvm.org/D12017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Fri Aug 14 07:33:25 2015
New Revision: 245042
URL: http://llvm.org/viewvc/llvm-project?rev=245042view=rev
Log:
[clang-tidy] Fix IncludeInserter/IncludeSorter bug.
If there weren't any includes in the file, or all of them had 'IncludeKind'
greater than the desired one, then
alexfh added a comment.
In http://reviews.llvm.org/D11784#224433, @aaron.ballman wrote:
In http://reviews.llvm.org/D11784#224430, @alexfh wrote:
In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
Ah,
Author: djasper
Date: Fri Aug 14 07:44:06 2015
New Revision: 245043
URL: http://llvm.org/viewvc/llvm-project?rev=245043view=rev
Log:
clang-format: Don't remove space between #elif and parentheses.
Before:
#elif( )
After:
#elif ( )
Modified:
alexfh added a comment.
In http://reviews.llvm.org/D11784#224421, @aaron.ballman wrote:
In http://reviews.llvm.org/D11784#224386, @alexfh wrote:
One thing I am not certain of in this patch is how to test it. I have
some rudimentary tests, but am unable to test the note: diagnostics
angelgarcia updated this revision to Diff 32143.
angelgarcia added a comment.
Update tests.
http://reviews.llvm.org/D12017
Files:
clang-tidy/IncludeInserter.cpp
clang-tidy/IncludeSorter.cpp
clang-tidy/IncludeSorter.h
unittests/clang-tidy/IncludeInserterTest.cpp
Index:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Now the tests pass. Thanks for fixing the IncludeInserter bug!
http://reviews.llvm.org/D11946
___
cfe-commits mailing list
61 matches
Mail list logo
