nwilson updated this revision to Diff 32228.
nwilson added a comment.
Patch addressing comments; fix comment/documentation wording, scoping of
diagnostic and setting invalid declaration, and fix test.
I also modified the location of the diagnostic indicating an exception
specification is not
rjmccall added a comment.
Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate patch?
Comment at: lib/CodeGen/CGCXXABI.h:349-357
@@ -348,1 +348,11 @@
+ /// Checks if ABI requires extra virtual offset for vtable field.
+ virtual bool
+
Looks fixed now, thanks!
On Sat, Aug 15, 2015 at 8:41 AM, Alexander Kornienko ale...@google.com wrote:
... or this may have been fixed by r245144. In any case, please check again
and report if anything is still broken.
On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko ale...@google.com
majnemer added inline comments.
Comment at: test/CodeGenCXX/vtable-assume-load.cpp:40
@@ +39,3 @@
+// CHECK1: call void @llvm.assume(i1 %cmp.vtables)
+// CHECK1-LABLE: }
+
This check line looks misspelled.
http://reviews.llvm.org/D11859
thakis added a subscriber: thakis.
Comment at: Makefile:68
@@ -67,3 +67,3 @@
# http://gcc.gnu.org/PR41874
# http://gcc.gnu.org/PR41838
#
The first of these is marked fixed, the second has a works on trunk comment
(from 2010). Maybe this isn't needed with
AlexDenisov added a comment.
s/which is important/which is might be important'/
;)
IMHO, the purpose of the test is not just prove that functionality is working
as expected, but also prevent from regression, I completely agree that this
test can be cleaned up a bit, but I'd cover at least two
modocache added a comment.
Why do you think it's a cruft? Seems it's a bit more verbose than it should be
The verbosity is the cruft, in my opinion. Why spend thirty lines of code to
demonstrate behavior that could be demonstrated in just five?
but what is missing in your test is
modocache added a comment.
Cool, thanks @compnerd!
http://reviews.llvm.org/D11772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davide
Date: Sat Aug 15 10:23:14 2015
New Revision: 245162
URL: http://llvm.org/viewvc/llvm-project?rev=245162view=rev
Log:
[Sema] Be consistent about diagnostic wording: always use cannot.
Discussed with Richard Smith.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
RKSimon created this revision.
RKSimon added reviewers: craig.topper, echristo, mkuper.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Adds missing SSE/AVX 'undefined' intrinsics (PR24040):
_mm_undefined_pd + _mm256_undefined_pd
_mm_undefined_ps
kimgr added inline comments.
Comment at: lib/Driver/Tools.cpp:398
@@ +397,3 @@
+ FoundPTH = !UsePCH;
+}
+ }
kimgr wrote:
kimgr wrote:
kimgr wrote:
Add a `break;` here so we don't continue searching after a valid path has
11 matches
Mail list logo
