ismail added a comment.
In http://reviews.llvm.org/D11932#225158, @hfinkel wrote:
What library path should be passed (where did you build the OpenMP runtime
library)?
This is a default installation so the lib path is $PATH_TO_CLANG_EXE/../lib
which in my case is C:\Program Files\LLVM\lib
mkuper added a comment.
Thanks, Simon!
I've wanted to add the _undefined intrinsics for a while now, but never got to
it.
Anyway, this sort of implementation somewhat worries me.
Yes, I know that the gcc intrinsics do something very similar.
And I also know that in practice we'll get an undef
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp:215-220
@@ +214,8 @@
+ return assumeSymWithinInclusiveRange(State, Sym, From, To, InRange);
+return State;
+ } // end switch
+
+ case nonloc::ConcreteIntKind: {
+const
RKSimon added a comment.
Yes using that uninitialized value has worried me as well. I originally set it
to zero (and considered using __ LINE __ or __ COUNTER __) but both introduce
defined behaviour that I could see causing all sorts of problems further down
the line in debug vs release
a.sidorin added a comment.
Thank you for reply, Jordan.
I guess the regular pings didn't work, so it was worth trying the gentle one?
Sorry!
And it worked :)
I'll fix the issues you pointed.
http://reviews.llvm.org/D5102
___
cfe-commits
Prazek added a comment.
In http://reviews.llvm.org/D11859#225025, @rjmccall wrote:
Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate
patch?
I wasn't planning to. I am focusing now on upgrading GVN for using new
invariant.barrier metadata.
rjmccall added a comment.
In http://reviews.llvm.org/D11859#225384, @Prazek wrote:
In http://reviews.llvm.org/D11859#225025, @rjmccall wrote:
Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate
patch?
I wasn't planning to. I am focusing now on upgrading GVN for
Prazek marked an inline comment as done.
Comment at: lib/CodeGen/CGCXXABI.h:352
@@ +351,3 @@
+ isVirtualOffsetNeededForVTableField(CodeGenFunction CGF,
+ const CXXRecordDecl *NearestVBase) = 0;
+
rjmccall wrote:
This method
Author: yrnkrn
Date: Sun Aug 16 14:02:49 2015
New Revision: 245184
URL: http://llvm.org/viewvc/llvm-project?rev=245184view=rev
Log:
Enable passing test on Windows + MSYS.
Modified:
cfe/trunk/test/Preprocessor/macro-multiline.c
Modified: cfe/trunk/test/Preprocessor/macro-multiline.c
URL:
Prazek updated this revision to Diff 32262.
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGen/available-externally-hidden.cpp
cbeck88 removed rL LLVM as the repository for this revision.
cbeck88 updated this revision to Diff 32249.
cbeck88 added a comment.
- Fixed formatting in header
- Fixed handling of nested namespaces
- Added unit tests
djasper: I thought about it, I guess I don't have a particularly good reason
Prazek updated this revision to Diff 32263.
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGen/available-externally-hidden.cpp
ABataev added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1969
@@ -1945,3 +1968,3 @@
else
- return EmitCapturedFieldLValue(*this, CapturedStmtInfo-lookup(VD),
- CapturedStmtInfo-getContextValue());
+
Yes, please, forget to tell you. :)
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
14.08.2015 19:03, Hans Wennborg пишет:
On Fri, Aug 14, 2015 at 5:25 AM, Alexey Bataev via cfe-commits
cfe-commits@lists.llvm.org wrote:
Author: abataev
Date: Fri Aug 14 07:25:37
14 matches
Mail list logo
