Re: [PATCH] D12278: [X86] Add MSVC-compatible intrinsics for clac, stac, lgdt and sgdt

mkuper added inline comments. Comment at: lib/Headers/Intrin.h:961 @@ +960,3 @@ +static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) { + __builtin_ia32_lgdt(__ptr); +} compnerd wrote: > Why does this need a builtin? Is an inline assembly block using lgd

Re: [PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

silvas added a subscriber: silvas. silvas added a comment. In http://reviews.llvm.org/D12271#231204, @rnk wrote: > This looks good. > > As a larger issue, LLVM fast isel definitely won't pattern match this series > of shifts and selects to rotl at -O0. There are some users who want > branchless

Re: [PATCH] D12134: [DEBUG INFO] Source correlation for lambda captured values.

echristo added a comment. How about: 13. [apple, 14. banana, 15. cherry]{ 16. printf("apple = %d\n",apple); 17. printf("banana = %d\n",banana); 18. printf("cherry = %d\n",cherry); Should be 13, 14, 15 yes? -eric http://reviews.llvm.org/D12134 ___

[PATCH] D12313: Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.

mzolotukhin created this revision. mzolotukhin added reviewers: rsmith, aaron.ballman, doug.gregor, t.p.northover, ab, mcrosier, hfinkel, majnemer. mzolotukhin added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Currently clang provides no general way to generate nontemporal loa

Re: r245821 - [modules] Stop updating all identifiers when writing a module. This is

On Sun, Aug 23, 2015 at 8:33 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Sun Aug 23 22:33:22 2015 > New Revision: 245821 > > URL: http://llvm.org/viewvc/llvm-project?rev=245821&view=rev > Log: > [modules] Stop updating all identifiers when writin

Re: [PATCH] D11700: Added remove taint support to ProgramState.

krememek added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:444-448 @@ +443,7 @@ + + SymbolRef + getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const; + + const MemRegion* + getRegionFromStmt(const Stmt *S, const L

Re: [PATCH] D11700: Added remove taint support to ProgramState.

krememek added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:444-448 @@ +443,7 @@ + + SymbolRef + getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const; + + const MemRegion* + getRegionFromStmt(const Stmt *S, const L

[libcxx] r245922 - Mark test as XFAIL with MSAN until D12311 gets committed

Author: ericwf Date: Mon Aug 24 23:35:55 2015 New Revision: 245922 URL: http://llvm.org/viewvc/llvm-project?rev=245922&view=rev Log: Mark test as XFAIL with MSAN until D12311 gets committed Modified: libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.co

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek added a comment. @rsmith I wonder If we have to put invariant.group.barrier when we call regular new expression http://reviews.llvm.org/D12312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek created this revision. Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky. Prazek added a subscriber: cfe-commits. Keep in mind, that I will not push it untill I will update GVN for using !invariant.group metadata http://reviews.llvm.org/D12312 Files: include/clang/Driver/Opt

Re: [PATCH] D12278: [X86] Add MSVC-compatible intrinsics for clac, stac, lgdt and sgdt

compnerd added a subscriber: compnerd. Comment at: lib/Headers/Intrin.h:961 @@ +960,3 @@ +static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) { + __builtin_ia32_lgdt(__ptr); +} Why does this need a builtin? Is an inline assembly block using lgdt insuff

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 33037. nmusgrave marked 4 inline comments as done. nmusgrave added a comment. - Simplify function invocations http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h test/CodeGenCXX/sanitize-

Re: [PATCH] D11468: [Static Analyzer] The first implementation of nullability checker.

zaks.anna added a comment. Gabor, there is a lot of the same steps that all callbacks go through. I think refactoring those into subroutines will help with readability of the checker. Looking forward to seeing a new version soon! Anna. Comment at: lib/StaticAnalyzer/Checkers/N

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

On Mon, Aug 24, 2015 at 5:50 PM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > echristo added inline comments. > > > Comment at: include/clang/Driver/Options.td:1853 > @@ -1853,1 +1852,3 @@ > +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use link

[libcxx] r245918 - Refactor and fix more flaky shared_mutex tests

Author: ericwf Date: Mon Aug 24 20:28:52 2015 New Revision: 245918 URL: http://llvm.org/viewvc/llvm-project?rev=245918&view=rev Log: Refactor and fix more flaky shared_mutex tests Modified: libcxx/trunk/test/std/thread/thread.mutex/thread.mutex.requirements/thread.sharedtimedmutex.requiremen

Re: [PATCH] D11468: [Static Analyzer] The first implementation of nullability checker.

zaks.anna added a comment. Another partial review. Thanks! Anna. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:312 @@ +311,3 @@ + CheckerContext &C) const { + auto RetExpr = S->getRetValue(); + if (!RetExpr) --

Re: patch: clarify diagnostic when returned value doesn't match function return type

LGTM On Mon, Aug 10, 2015 at 7:08 PM, Nick Lewycky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This simple-minded patch extends the case where we report "no viable > conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable > conversion from returned value of type 'X' to

r245915 - [ARM NEON] Remove the old AArch64 vset_lane tests. NFC.

Author: ab Date: Mon Aug 24 20:00:05 2015 New Revision: 245915 URL: http://llvm.org/viewvc/llvm-project?rev=245915&view=rev Log: [ARM NEON] Remove the old AArch64 vset_lane tests. NFC. They are now properly tested, since r245901. Removed: cfe/trunk/test/CodeGen/arm64_vset_lane.c Removed: cf

[PATCH] D12306: [OpenMP] Implement the creation and registration of the offloading descriptor.

sfantao created this revision. sfantao added reviewers: ABataev, rjmccall, hfinkel. sfantao added a subscriber: cfe-commits. All the offloading information is bundled into a descriptor that is passed to the runtime library so that it can extract all the binaries and map variables properly. This

r245914 - Reimplement the PPC explicit option checking to be a bit more obvious

Author: echristo Date: Mon Aug 24 19:59:11 2015 New Revision: 245914 URL: http://llvm.org/viewvc/llvm-project?rev=245914&view=rev Log: Reimplement the PPC explicit option checking to be a bit more obvious that we're looking for conflicting options and give an explanation. Modified: cfe/trunk/

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

eugenis added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:44 @@ +43,3 @@ + // destructors. + const ASTRecordLayout &Layout = Context.getASTRecordLayout(D->getParent()); + This is unused. Comment at: lib/CodeGen/CGCXX.cpp:47 @@ +46,3 @@ +

Re: [PATCH] Have clang list the imported modules in the debug info

On Mon, Aug 24, 2015 at 5:33 PM, Adrian Prantl wrote: > > On Aug 24, 2015, at 4:17 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl wrote: > >> >> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: >> >> >> >> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote:

Re: patch: clarify diagnostic when returned value doesn't match function return type

I can't find any reference to a policy against changing diagnostics. We should be in the clear. vedant On Aug 24, 2015, at 5:49 PM, David Majnemer wrote: > On Mon, Aug 24, 2015 at 5:44 PM, Vedant Kumar via cfe-commits > wrote: > LGTM with a caveat. > > Changing diagnostic messages is scary b

Re: patch: clarify diagnostic when returned value doesn't match function return type

On Mon, Aug 24, 2015 at 5:44 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > LGTM with a caveat. > > Changing diagnostic messages is scary because it can inadvertently break > tools and IDE's. So there is a chance someone might want this reverted in > the future. But for no

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

echristo added inline comments. Comment at: include/clang/Driver/Options.td:1853 @@ -1853,1 +1852,3 @@ +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">, Group; +def linker_EQ : Joined<["-"], "linker=">, Alias, MetaVarName<"">; thakis wrote:

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

thakis added a subscriber: thakis. This revision is now accepted and ready to land. Comment at: include/clang/Driver/Options.td:1853 @@ -1853,1 +1852,3 @@ +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">, Group; +def linker_EQ : Joined<["-"], "linker=">, Alias

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

pcc added a subscriber: pcc. Comment at: test/Driver/fuse-ld.c:32-33 @@ +31,4 @@ +// RUN: -B%S/Inputs/basic_freebsd_tree/usr/bin 2>&1 \ +// RUN: | FileCheck %s -check-prefix=CHECK-FREEBSD-GOLD +// CHECK-FREEBSD-LINKER-GOLD: Inputs/basic_freebsd_tree/usr/bin{{/|\\+}}ld.gold +

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. One inline comment and then OK. -eric Comment at: test/Driver/fuse-ld.c:27-33 @@ -26,1 +26,9 @@ +// -linker= is an alias to fuse-ld. Don't need to retry all combination

r245913 - [clang-cl] Only respect /Oy- for x86_32

Author: majnemer Date: Mon Aug 24 19:46:45 2015 New Revision: 245913 URL: http://llvm.org/viewvc/llvm-project?rev=245913&view=rev Log: [clang-cl] Only respect /Oy- for x86_32 The /Oy- flag should have no effect for 64-bit X86, it has reliable unwind tables. Modified: cfe/trunk/include/clang/

Re: patch: clarify diagnostic when returned value doesn't match function return type

LGTM with a caveat. Changing diagnostic messages is scary because it can inadvertently break tools and IDE's. So there is a chance someone might want this reverted in the future. But for now it seems helpful :). vedant On Aug 24, 2015, at 1:19 PM, Nick Lewycky via cfe-commits wrote: > On 19

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

filcab updated this revision to Diff 33030. filcab marked an inline comment as done. filcab added a comment. Addressed Eric's comment. http://reviews.llvm.org/D11737 Files: include/clang/Driver/Options.td test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c ==

Re: [PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF closed this revision. EricWF added a comment. r245912. http://reviews.llvm.org/D12265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting so I can commit. Comment at: buildbot/osuosl/master/config/builders.py:1166 @@ +1165,3 @@ + 'name':"libcxx-sphinx-docs

Re: [PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF updated this revision to Diff 33029. EricWF marked 2 inline comments as done. http://reviews.llvm.org/D12265 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index: zorg/buildbot/builders/SphinxDocsBuilder.py

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 24, 2015, at 4:17 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl > wrote: > >> On Aug 24, 2015, at 2:01 PM, David Blaikie > > wrote: >> >> >> >> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl >

r245910 - Revert "broken test. uses system ld.gold"

Author: dschuff Date: Mon Aug 24 18:53:30 2015 New Revision: 245910 URL: http://llvm.org/viewvc/llvm-project?rev=245910&view=rev Log: Revert "broken test. uses system ld.gold" We should check in a basic_nacl_tree that works and also fix --sysroot Removed: cfe/trunk/test/Driver/Inputs/basic_na

r245908 - Use GetLinkerPath utility function to find linker for NaCl toolchain

Author: dschuff Date: Mon Aug 24 18:53:25 2015 New Revision: 245908 URL: http://llvm.org/viewvc/llvm-project?rev=245908&view=rev Log: Use GetLinkerPath utility function to find linker for NaCl toolchain Summary: This is more consistent with other targets and also makes the -fuse-ld flag work. Re

r245909 - broken test. uses system ld.gold

Author: dschuff Date: Mon Aug 24 18:53:28 2015 New Revision: 245909 URL: http://llvm.org/viewvc/llvm-project?rev=245909&view=rev Log: broken test. uses system ld.gold Added: cfe/trunk/test/Driver/Inputs/basic_nacl_tree/ cfe/trunk/test/Driver/Inputs/basic_nacl_tree/bin/ cfe/trunk/test/

r245906 - [ARM NEON] Use CGF cached Types instead of llvm::Type::get. NFC.

Author: ab Date: Mon Aug 24 18:47:29 2015 New Revision: 245906 URL: http://llvm.org/viewvc/llvm-project?rev=245906&view=rev Log: [ARM NEON] Use CGF cached Types instead of llvm::Type::get. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL:

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman wrote: > On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith > wrote: > > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman > > wrote: > >> > >> aaron.ballman created this revision. > >> aaron.ballman added reviewers: alexfh, rsmith. > >> aaron.ballman add

r245904 - [ARM NEON] Replace redundant code with a new GetFloatNeonType. NFC.

Author: ab Date: Mon Aug 24 18:41:31 2015 New Revision: 245904 URL: http://llvm.org/viewvc/llvm-project?rev=245904&view=rev Log: [ARM NEON] Replace redundant code with a new GetFloatNeonType. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL

r245901 - [ARM NEON] Add missing AArch64 vget tests.

Author: ab Date: Mon Aug 24 18:34:25 2015 New Revision: 245901 URL: http://llvm.org/viewvc/llvm-project?rev=245901&view=rev Log: [ARM NEON] Add missing AArch64 vget tests. Added: cfe/trunk/test/CodeGen/aarch64-neon-vget.c - copied, changed from r245893, cfe/trunk/test/CodeGen/arm64_vget

Re: [PATCH] D12038: CodeGen: Introduce CodeGenModule::CreateMetadataIdentifierForType.

pcc added a comment. @rsmith: Ping. http://reviews.llvm.org/D12038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

pcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:149 @@ +148,3 @@ +shared library boundaries are handled as if the callee was not compiled with +``-fsanitize=cfi-icall``. + kcc wrote: > mention that LTO is require explicitly? Done above. http

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

pcc updated this revision to Diff 33020. pcc added a comment. - Address comment http://reviews.llvm.org/D11857 Files: docs/ControlFlowIntegrity.rst include/clang/AST/Mangle.h include/clang/Basic/Sanitizers.def lib/AST/ItaniumMangle.cpp lib/AST/MicrosoftMangle.cpp lib/CodeGen/CGClass

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

echristo added inline comments. Comment at: include/clang/Driver/Options.td:1853-1854 @@ -1853,1 +1852,4 @@ +def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">, Group; +def linker : Separate<["-"], "linker">, Alias, MetaVarName<"">; +def linker_EQ : Joined<["-"]

Re: [PATCH] D12215: [UBSan] Add the ability to print more precise error kind in summary line.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245897: [UBSan] Add the ability to print more precise error kind in summary line. (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D12215?vs=32753&id=33019#toc Repository: rL

Re: [PATCH] Have clang list the imported modules in the debug info

On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl wrote: > > On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote: > >> >> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: >> >> >> >> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl wrote:

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

kcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:149 @@ +148,3 @@ +shared library boundaries are handled as if the callee was not compiled with +``-fsanitize=cfi-icall``. + mention that LTO is require explicitly? http://reviews.llvm.org/D1185

Re: [PATCH] D12287: Add replace-auto_ptr check.

alexfh added inline comments. Comment at: clang-tidy/modernize/ReplaceAutoPtrCheck.h:20 @@ +19,3 @@ + +class ReplaceAutoPtrCheck : public ClangTidyCheck { +public: Please add a class comment describing what the check does and why. http://reviews.llvm.org/D12287

[libclc] r245894 - Update mailing list reference.

Author: pcc Date: Mon Aug 24 17:43:24 2015 New Revision: 245894 URL: http://llvm.org/viewvc/llvm-project?rev=245894&view=rev Log: Update mailing list reference. Modified: libclc/trunk/www/index.html Modified: libclc/trunk/www/index.html URL: http://llvm.org/viewvc/llvm-project/libclc/trunk/

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith wrote: > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman > wrote: >> >> aaron.ballman created this revision. >> aaron.ballman added reviewers: alexfh, rsmith. >> aaron.ballman added a subscriber: cfe-commits. >> >> Per [except.handle]p10, the handler

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl > wrote: > >> On Aug 19, 2015, at 1:20 PM, David Blaikie > > wrote: >> >> >> >> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl >

Re: [PATCH] D12281: Tests no longer need the 'REQUIRES: SHELL' line.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D12281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman wrote: > aaron.ballman created this revision. > aaron.ballman added reviewers: alexfh, rsmith. > aaron.ballman added a subscriber: cfe-commits. > > Per [except.handle]p10, the handler for a constructor or destructor > function-try-block cannot refer

Re: [PATCH] Have clang list the imported modules in the debug info

+static void escape(llvm::raw_ostream &OS, StringRef String) { + for (auto C: String) { +if (strchr("\\\"", C)) + OS << '\\'; +OS << C; + } +} Do we not have an existing function somewhere to do that? Also, that strchr call is a very complex way of writing (C == '\\' || C == '"') O

[PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, rsmith. aaron.ballman added a subscriber: cfe-commits. Per [except.handle]p10, the handler for a constructor or destructor function-try-block cannot refer to a non-static member of the object under construction. This pat

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: lib/Sema/SemaExpr.cpp:4035 @@ +4034,3 @@ + // Build an unanalyzed expression if either operand is type-dependent. + if (Base->isTypeDependent() ||

[PATCH] D12299: [libcxx] ABI-Breaking Fix for ALL undefined behavior in .

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. This patch is an ABI-breaking version of D12297. However unlike D12297, this patch does not have any undefined behavior when `element_type` has a stricter alignment req

r245881 - [modules] Remove unnecessary deserialization of fully-external HeaderFileInfos for all files we've seen in this compilation.

Author: rsmith Date: Mon Aug 24 16:59:32 2015 New Revision: 245881 URL: http://llvm.org/viewvc/llvm-project?rev=245881&view=rev Log: [modules] Remove unnecessary deserialization of fully-external HeaderFileInfos for all files we've seen in this compilation. Modified: cfe/trunk/include/clang/

[PATCH] D12297: [libcxx] Fix most undefined behavior in

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, rsmith. EricWF added subscribers: cfe-commits, awi, rsmith. This patch partially fixes the undefined behavior in ``. The undefined behavior is caused by casting a pointer to `__node_base __end_` to the derived type `__

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

echristo added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:181-190 @@ -166,2 +180,12 @@ return; +if (LangOpts.CUDA && LangOpts.CUDAIsDevice && +LangOpts.CUDAUsesLibDevice) { + legacy::PassManager passes; + passes.add(

r245879 - [MS ABI] Don't emit stackrestore in cleanups

Author: majnemer Date: Mon Aug 24 16:34:21 2015 New Revision: 245879 URL: http://llvm.org/viewvc/llvm-project?rev=245879&view=rev Log: [MS ABI] Don't emit stackrestore in cleanups The stackrestore intrinsic isn't meaningful inside of a cleanup funclet. Modified: cfe/trunk/lib/CodeGen/CGCall.

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF updated the summary for this revision. EricWF updated this revision to Diff 32997. EricWF added a comment. Update diff to remove misc cleanup stuff. http://reviews.llvm.org/D11963 Files: CMakeLists.txt cmake/Modules/HandleLibcxxFlags.cmake include/CMakeLists.txt include/__config_

[libcxx] r245877 - Move test/std/utilities/date.time to proper stable name utilities/time/date.time

Author: ericwf Date: Mon Aug 24 16:27:25 2015 New Revision: 245877 URL: http://llvm.org/viewvc/llvm-project?rev=245877&view=rev Log: Move test/std/utilities/date.time to proper stable name utilities/time/date.time Added: libcxx/trunk/test/libcxx/utilities/time/ libcxx/trunk/test/libcxx/ut

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs closed this revision. jroelofs added a comment. r245876 http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245876 - Misc drive-by cleanups. NFC

Author: jroelofs Date: Mon Aug 24 16:20:07 2015 New Revision: 245876 URL: http://llvm.org/viewvc/llvm-project?rev=245876&view=rev Log: Misc drive-by cleanups. NFC http://reviews.llvm.org/D12294 Added: libcxx/trunk/test/libcxx/atomics/ libcxx/trunk/test/libcxx/atomics/libcpp-has-no-thread

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

EricWF added a comment. Actually commit this as is and I'll handle the other cleanup. http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after renaming `tested_elsewhere.pass.cpp` http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

EricWF added a comment. Can you move the `libcpp-has-no-threads` tests to `test/libcxx/atomics` instead of deleting them? (I imagine that's what you intended to do). Also `tested_elsewhere.pass.cpp` shouldn't really be called that because it contains the actual test. Could you rename it to some

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

tra added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:166-170 @@ +165,7 @@ +std::vector ModuleFuncNames; +// We need to internalize contents of the linked module but it +// has to be done *after* the linking because internalized +// s

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs updated this revision to Diff 32996. jroelofs added a comment. The diff uploaded strangely... trying again. http://reviews.llvm.org/D12294 Files: CMakeLists.txt test/libcxx/atomics/libcpp-has-no-threads.fail.cpp test/libcxx/atomics/libcpp-has-no-threads.pass.cpp test/std/atomic

[PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs created this revision. jroelofs added a reviewer: EricWF. jroelofs added a subscriber: cfe-commits. This separates out the bits of D11963 which were drive-by fixes, which aren't really relevant to the __config_site part of that change. http://reviews.llvm.org/D12294 Files: CMakeLists

Re: [PATCH] Have clang list the imported modules in the debug info

On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote: > > On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: > > > > On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl wrote: > >> >> On Jul 24, 2015, at 12:33 PM, David Blaikie wrote: >> >> *reads back through the thread* >> >> >> appreciated, it’s

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

yiranwang added a comment. A test case is as following. It has to be build by GCC 4.9 -O3 (maybe or later), with latest libc++, and for AARCH64+ANDROID target. AARCH64 requires 128 bit alignment for aligned_storage and 64 bit pointers, while gcc 4.9 alias analysis will do field-sensitive points

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF updated this revision to Diff 32992. EricWF added a comment. This patch takes @jroelof's idea and runs with it. However this patch doesn't require a `__config_site` header. The patch works modifying `build-libcxx/include/c++/v1/__config` by prepending the contents of `__config_site`. If

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF commandeered this revision. EricWF edited reviewers, added: jroelofs; removed: EricWF. EricWF added a comment. Stealing this revision. I have a different plan. http://reviews.llvm.org/D11963 ___ cfe-commits mailing list cfe-commits@lists.llvm

r245871 - Revert r245866.

Author: ahatanak Date: Mon Aug 24 15:30:57 2015 New Revision: 245871 URL: http://llvm.org/viewvc/llvm-project?rev=245871&view=rev Log: Revert r245866. This commit was causing buildbot failures. Removed: cfe/trunk/test/Driver/arm-float-abi.c Modified: cfe/trunk/lib/Driver/Tools.cpp Modif

Re: [PATCH] D11280: [CUDA] Improve CUDA compilation pipeline creation.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems like a decent incremental improvement. I think we still need to separate out the pipeline a bit further and have the cuda compilation just be separate actions that don't need th

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: > > > > On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl > wrote: > >> On Jul 24, 2015, at 12:33 PM, David Blaikie > > wrote: >> >> *reads back through the thread* > > appreciated, it’s l

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

echristo added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:166-170 @@ +165,7 @@ +std::vector ModuleFuncNames; +// We need to internalize contents of the linked module but it +// has to be done *after* the linking because internalized +

Re: patch: clarify diagnostic when returned value doesn't match function return type

On 19 August 2015 at 15:18, Nick Lewycky wrote: > On 10 August 2015 at 19:08, Nick Lewycky wrote: > >> This simple-minded patch extends the case where we report "no viable >> conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable >> conversion from returned value of type 'X' to

Re: [PATCH] D12155: ARM: Error out on apple darwin platforms if float-abi is "hard"

This revision was automatically updated to reflect the committed changes. Closed by commit rL245866: [ARM] Error out on apple darwin platforms if float-abi is "hard". (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D12155?vs=32561&id=32989#toc Repository: rL LLVM ht

Re: [PATCH] D11690: [CUDA] Added stubs for new attributes used by CUDA headers.

tra abandoned this revision. tra added a comment. There is no way to close revision. Abandoning it to get it off my list of pending changes. http://reviews.llvm.org/D11690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

r245867 - [libclang] For convenience to clients, make sure that nullability and __kindof annotations do not hide

Author: akirtzidis Date: Mon Aug 24 14:50:45 2015 New Revision: 245867 URL: http://llvm.org/viewvc/llvm-project?rev=245867&view=rev Log: [libclang] For convenience to clients, make sure that nullability and __kindof annotations do not hide the underlying type. rdar://22063577 Modified: cfe/

r245866 - [ARM] Error out on apple darwin platforms if float-abi is "hard".

Author: ahatanak Date: Mon Aug 24 14:50:35 2015 New Revision: 245866 URL: http://llvm.org/viewvc/llvm-project?rev=245866&view=rev Log: [ARM] Error out on apple darwin platforms if float-abi is "hard". Error out if the user tries to use float-abi="hard" since it isn't supported on darwin platforms

[libcxx] r245864 - Add release goals to TODO.txt

Author: ericwf Date: Mon Aug 24 14:33:40 2015 New Revision: 245864 URL: http://llvm.org/viewvc/llvm-project?rev=245864&view=rev Log: Add release goals to TODO.txt Modified: libcxx/trunk/TODO.TXT Modified: libcxx/trunk/TODO.TXT URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/TODO.TXT?r

r245861 - Fixing some copy-pasta comments; NFC.

Author: aaronballman Date: Mon Aug 24 13:50:01 2015 New Revision: 245861 URL: http://llvm.org/viewvc/llvm-project?rev=245861&view=rev Log: Fixing some copy-pasta comments; NFC. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/vie

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 32986. nmusgrave added a comment. - Refactored for simpler trivial field checking http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h test/CodeGenCXX/sanitize-dtor-nontrivial-virtual-base

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

george.burgess.iv updated this revision to Diff 32985. george.burgess.iv added a comment. Mostly redid the patch; removed OutermostExprEvaluator, moved evaluation intent into `EvaluationMode`, made it so the more interesting rulebreaking that `__builtin_object_size` allows is only allowed when e

Re: [PATCH] D11468: [Static Analyzer] The first implementation of nullability checker.

xazax.hun marked 11 inline comments as done. xazax.hun added a comment. Thank you for the review. I will upload the new version of the patch once the rest of it was reviewed. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:12 @@ +11,3 @@ +// checker is that, the

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev updated this revision to Diff 32974. ABataev marked 10 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10732 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/AST/DataRecu

Re: [PATCH] D10732: [OPENMP 4.0] Initial support for array sections.

ABataev marked 15 inline comments as done. ABataev added a comment. Richard, thanks for the review! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7680 @@ +7679,3 @@ +def err_omp_section_length_undefined : Error< + "section length is unspecified, but subscripted value i

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

fraggamuffin added a comment. Got it. Test results look good with this patch. Expected Passes: 7011 Expected Failures : 21 Unsupported Tests : 89 Unexpected Failures: 47 http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-

LLVM buildmaster will be tonight

Hello everyone, LLVM buildmaster will be restarted after 5 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D6551: Improvements to scan-build.

ayartsev updated this revision to Diff 32969. ayartsev added a comment. Updated the patch with r245621. OK to commit? http://reviews.llvm.org/D6551 Files: tools/scan-build/scan-build Index: tools/scan-build/scan-build === --- to

Re: [PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This looks good. As a larger issue, LLVM fast isel definitely won't pattern match this series of shifts and selects to rotl at -O0. There are some users who want branchless constant time rotates re

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 removed rL LLVM as the repository for this revision. olista01 updated this revision to Diff 32967. olista01 added a comment. Use a switch statement to check the target architecture. http://reviews.llvm.org/D12148 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/

[PATCH] D12287: Add replace-auto_ptr check.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. Migrate replace-auto_ptr check from clang-modernize to modernize module in clang-tidy. http://reviews.llvm.org/D12287 Files: clang-tidy/modernize/CMakeLists.txt clang

[libcxx] r245849 - Fix a crasher found by libFuzzer

Author: marshall Date: Mon Aug 24 10:57:09 2015 New Revision: 245849 URL: http://llvm.org/viewvc/llvm-project?rev=245849&view=rev Log: Fix a crasher found by libFuzzer Modified: libcxx/trunk/include/regex libcxx/trunk/test/std/re/re.alg/re.alg.search/grep.pass.cpp Modified: libcxx/trunk/

  1   2   >