Prazek added a comment.
I used "hanging out" in the meaning of being very slow, not sure if it is right
word for it.
http://reviews.llvm.org/D12719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Prazek added a comment.
I checked it, it is of course not infinite. I am not sure about n! in case of
assumes. I having 10 or 20 assumes will not make it slow. @rsmith was helping
me with it, and he thinks that for assumes it is O(n^2), because results are
memorized.
So it this case, 1000 assu
On 8 September 2015 at 20:27, Sanjoy Das
wrote:
> sanjoy added a comment.
>
> I don't think this is an infinite loop (Piotr, can you please verify
> this?), it is probably an O(n!) recursion where n == number of the
> assumptions.
>
> ScalarEvolution::isImpliedCond already guards for infinite loo
nlewycky added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
Prazek wrote:
> nlewycky wrote:
> > What is it about t
Prazek added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
nlewycky wrote:
> What is it about this check which is a
On Tue, Sep 8, 2015 at 1:41 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 8 15:41:52 2015
> New Revision: 247068
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247068&view=rev
> Log:
> Module Debugging: Emit debug type information into c
On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 8 14:20:27 2015
> New Revision: 247049
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247049&view=rev
> Log:
> Module Debugging: Emit debug type information into
nlewycky added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
What is it about this check which is a problem? Or put
hiraditya added a comment.
Please review my patch. Thanks.
http://reviews.llvm.org/D9924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky.
Prazek added a subscriber: cfe-commits.
Herald added a subscriber: sanjoy.
http://reviews.llvm.org/D12719
Files:
lib/Analysis/ScalarEvolution.cpp
test/Analysis/ScalarEvolution/avoid-assume-hang.ll
Index: test/Analysis/Sc
On Tue, Sep 8, 2015 at 3:51 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> rsmith added inline comments.
>
>
> Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264
> @@ +3262,4 @@
> + const NamespaceDecl *NSDecl = UD.getNominatedNamespace();
> + if (!NSDec
zaks.anna added a comment.
honggyu.kim,
Uniquing HTML reports is out of the scope of this patch and should be discussed
elsewhere (either send a design idea to cfe-dev, send a patch for review, or
file a bugzilla request).
I agree that this patch is a definite improvement to issue identificati
Thanks. Committed in r247117.
Steven
> On Sep 8, 2015, at 6:32 PM, John McCall wrote:
>
>> On Sep 8, 2015, at 6:19 PM, Steven Wu wrote:
>> CreateElementBitcast doesn’t seem to do what the name suggested. If you give
>> it VTy, it doesn’t grab the element type to generate bitcast. Is this
>>
Author: steven_wu
Date: Tue Sep 8 20:37:18 2015
New Revision: 247117
URL: http://llvm.org/viewvc/llvm-project?rev=247117&view=rev
Log:
Fix vld1_lane intrinsic generation
Fix a bug introduced in r246985 which causes assertion when generating
vld1_lane.
Modified:
cfe/trunk/lib/CodeGen/CGBuilt
> On Sep 8, 2015, at 6:19 PM, Steven Wu wrote:
> CreateElementBitcast doesn’t seem to do what the name suggested. If you give
> it VTy, it doesn’t grab the element type to generate bitcast. Is this
> by-design? If so, I need to do this:
> PtrOp0 = Builder.CreateElementBitCast(PtrOp0, VTy->getEle
CreateElementBitcast doesn’t seem to do what the name suggested. If you give it
VTy, it doesn’t grab the element type to generate bitcast. Is this by-design?
If so, I need to do this:
PtrOp0 = Builder.CreateElementBitCast(PtrOp0, VTy->getElementType());
Steven
>> On Sep 8, 2015, at 5:14 PM, St
piotrdz added a comment.
@alexfh: What do you think now? Are we getting nearer to making a commit?
Comment at:
clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp:60
@@ +59,3 @@
+ bool IsTemplateSpecialization;
+ DifferingParamsContainer DifferingParams;
+};
piotrdz updated this revision to Diff 34267.
piotrdz marked 10 inline comments as done.
piotrdz added a comment.
I hope this is the final re-write of my code. In this version, I addressed most
recent review comments, while also refactoring code to better handle template
specializations and corre
xazax.hun updated this revision to Diff 34285.
xazax.hun added a comment.
- Updated to newest trunk.
- Moved the feature behind an option.
- Fixed a crash when an operator() of a lambda is analyzed as a top level
function, and a ThisExpr is referring to the this in the enclosing scope (this
can
probinson added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264
@@ +3262,4 @@
+ const NamespaceDecl *NSDecl = UD.getNominatedNamespace();
+ if (!NSDecl->isAnonymousNamespace() ||
+ CGM.getTarget().getTriple().isPS4CPU()) {
+DBuilder.createImportedMo
mzolotukhin added a comment.
Thanks, Hal, Richard!
I committed the patch with requested changes in r247107.
Michael
Repository:
rL LLVM
http://reviews.llvm.org/D12313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
davidxl created this revision.
davidxl added reviewers: cfe-commits, bogner, silvas, xur.
See patch-1 for description
http://reviews.llvm.org/D12716
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/Backen
Author: pcc
Date: Tue Sep 8 19:01:31 2015
New Revision: 247105
URL: http://llvm.org/viewvc/llvm-project?rev=247105&view=rev
Log:
CodeGen: Add CFI unrelated cast checks to the new pointer code path.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
cfe/trunk/test/CodeGenCXX/cfi-cast.cpp
Modifie
eugenis added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1671
@@ -1670,1 +1670,3 @@
+ ASTContext &Context = CGF.getContext();
+ // Poison vtable and vtable ptr if they exist for this class.
You are poisoning the vtable pointer in the base des
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247104: Introduce __builtin_nontemporal_store and
__builtin_nontemporal_load. (authored by mzolotukhin).
Changed prior to commit:
http://reviews.llvm.org/D12313?vs=33492&id=34281#toc
Repository:
rL L
Author: mzolotukhin
Date: Tue Sep 8 18:52:33 2015
New Revision: 247104
URL: http://llvm.org/viewvc/llvm-project?rev=247104&view=rev
Log:
Introduce __builtin_nontemporal_store and __builtin_nontemporal_load.
Summary:
Currently clang provides no general way to generate nontemporal loads/stores.
Th
Author: dcoughlin
Date: Tue Sep 8 18:50:22 2015
New Revision: 247103
URL: http://llvm.org/viewvc/llvm-project?rev=247103&view=rev
Log:
Revert "[Static Analyzer] BugReporter.cpp:2869: Assertion failed:
!RemainingNodes.empty() && "No error node found in the trimmed graph""
This is making our inte
ahatanak added a comment.
In http://reviews.llvm.org/D11815#238209, @vkalintiris wrote:
> In http://reviews.llvm.org/D11815#237541, @ahatanak wrote:
>
> > In http://reviews.llvm.org/D11815#236368, @vkalintiris wrote:
> >
> > > In http://reviews.llvm.org/D11815#235394, @ahatanak wrote:
> > >
> > >
nmusgrave created this revision.
nmusgrave added reviewers: eugenis, kcc.
nmusgrave added a subscriber: cfe-commits.
After destruction, invocation of virtual functions prevented
by poisoning vtable pointer.
http://reviews.llvm.org/D12712
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/sanitiz
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247098: CodeGen: Introduce
CodeGenModule::CreateMetadataIdentifierForType. (authored by pcc).
Changed prior to commit:
http://reviews.llvm.org/D12038?vs=32173&id=34276#toc
Repository:
rL LLVM
http:/
Author: pcc
Date: Tue Sep 8 18:01:30 2015
New Revision: 247098
URL: http://llvm.org/viewvc/llvm-project?rev=247098&view=rev
Log:
CodeGen: Introduce CodeGenModule::CreateMetadataIdentifierForType.
This function can be used to create a metadata identifier for a specific
type. No functionality chan
rsmith added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264
@@ +3262,4 @@
+ const NamespaceDecl *NSDecl = UD.getNominatedNamespace();
+ if (!NSDecl->isAnonymousNamespace() ||
+ CGM.getTarget().getTriple().isPS4CPU()) {
+DBuilder.createImportedModul
Author: chapuni
Date: Tue Sep 8 17:47:32 2015
New Revision: 247093
URL: http://llvm.org/viewvc/llvm-project?rev=247093&view=rev
Log:
clang/test/Modules/ModuleDebugInfo.cpp: Add -triple %itanium to appease
ms-targeted builds.
I think DebugInfo tests may avoid MS stuff for now.
Modified:
cfe
Author: adrian
Date: Tue Sep 8 17:06:40 2015
New Revision: 247081
URL: http://llvm.org/viewvc/llvm-project?rev=247081&view=rev
Log:
Remove unneeded #include.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
http://llvm.org/viewvc/llvm-pro
probinson added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264
@@ +3262,4 @@
+ const NamespaceDecl *NSDecl = UD.getNominatedNamespace();
+ if (!NSDecl->isAnonymousNamespace() ||
+ CGM.getTarget().getTriple().isPS4CPU()) {
+DBuilder.createImportedMo
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:843
@@ +842,3 @@
+ if (!Length)
+return true;
+
There doesn't seem to be a test that cares about this returning true (as
compared to false).
Comment
zatrazz created this revision.
zatrazz added reviewers: t.p.northover, aemerson, pcc, rengolin.
zatrazz added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch enables MSan for aarch64/linux.
http://reviews.llvm.org/D12708
Files:
lib/Driver/ToolChains.cpp
Ind
Author: rjmccall
Date: Tue Sep 8 16:15:22 2015
New Revision: 247075
URL: http://llvm.org/viewvc/llvm-project?rev=247075&view=rev
Log:
Collect SEH captures in a set instead of a vector to avoid
doing redundant work if a variable is used multiple times.
Fixes PR24751.
Modified:
cfe/trunk/lib/
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
http://reviews.llvm.org/D12701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
Works for me, thanks.
http://reviews.llvm.org/D11664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated the summary for this revision.
tra updated this revision to Diff 34251.
tra added a comment.
Assume (and test) that NVPTX back-end includes NVVMReflect by default.
http://reviews.llvm.org/D11664
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/
Author: adrian
Date: Tue Sep 8 15:41:52 2015
New Revision: 247068
URL: http://llvm.org/viewvc/llvm-project?rev=247068&view=rev
Log:
Module Debugging: Emit debug type information into clang ObjC modules.
When -fmodule-format is set to "obj", emit debug info for all types
declared in a module or r
zaks.anna accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Checkers/ObjCGenericsChecker.cpp:226
@@ +225,3 @@
+/// Inputs:
+/// There is a static lower bound (SL)
+/// There is a static upper bound (SL <: SU)
--
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks fine to me.
Comment at: lib/CodeGen/CGBuiltin.cpp:114-128
@@ -113,1 +113,17 @@
+static Value *MakeNontemporalStore(CodeGenFunction &CGF, const CallExpr *E) {
+ Value
hfinkel added a comment.
In http://reviews.llvm.org/D12313#241697, @mzolotukhin wrote:
> Hi Richard, Hal,
>
> Does the patch look good now?
Looks good to me, but please wait for Richard on the changes he requested.
> Thanks,
> Michael
http://reviews.llvm.org/D12313
_
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This seems fine to me.
http://reviews.llvm.org/D12038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: rsmith
Date: Tue Sep 8 14:40:14 2015
New Revision: 247055
URL: http://llvm.org/viewvc/llvm-project?rev=247055&view=rev
Log:
[modules] Write the options records to a separate subblock rather than writing
them directly to the control block. These are fairly large, and in a build with
lots o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247052: [Shave]: add a -MT option to moviCompile if there
wasn't one (authored by dougk).
Changed prior to commit:
http://reviews.llvm.org/D12622?vs=34006&id=34239#toc
Repository:
rL LLVM
http://rev
Author: dougk
Date: Tue Sep 8 14:29:55 2015
New Revision: 247052
URL: http://llvm.org/viewvc/llvm-project?rev=247052&view=rev
Log:
[Shave]: add a -MT option to moviCompile if there wasn't one
Differential Revision: http://reviews.llvm.org/D12622
Modified:
cfe/trunk/lib/Driver/Tools.cpp
> On Sep 8, 2015, at 10:52 AM, Chandler Carruth wrote:
> None of my performance concerns were relevant to this change FWIW.
>
> I think the reason that this got "fixed" was because people had a tendancy to
> *rely* on the name downstream when we made it always present. =/ Personally,
> I like h
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
There are several fallouts from this review, so I decided to split this patch
up the following way:
1. I created a patch to incorporate the result of this review into
ObjCGenericsChecker: http://reviews.llvm.org/D12701
2. I
Author: adrian
Date: Tue Sep 8 14:20:27 2015
New Revision: 247049
URL: http://llvm.org/viewvc/llvm-project?rev=247049&view=rev
Log:
Module Debugging: Emit debug type information into clang modules.
When -fmodule-format is set to "obj", emit debug info for all types
declared in a module or refere
mzolotukhin added a comment.
Hi Richard, Hal,
Does the patch look good now?
Thanks,
Michael
http://reviews.llvm.org/D12313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Sean,
Ted provided more details off-list. He suspects that the problem is that we
likely don't add MemSpaceRegions to the worklist because every region is a
subregion of a MemSpaceRegion, and thus we would invalidate, by default, all
regions that were in the same MemSpace as the regions we w
I agree with Chandler the default should be no names for -Asserts builds.
What I wanted originally was that the stripping of names be a runtime
choice (since the performance overhead of it was minimal when I measured
it), so that when we need to debug with a production compiler, it would
still be
On Tue, Sep 8, 2015 at 10:52 AM, Chandler Carruth
wrote:
> None of my performance concerns were relevant to this change FWIW.
>
Good to know - if we wanted to go down this path I figure we could just
provide overloads - StringRef and Twine, the StringRef one could always use
the name, even in -A
echristo added a comment.
Inline comment.
Comment at: test/CodeGenCUDA/link-device-bitcode.cu:23-28
@@ +22,8 @@
+//
+// NVVMReflect is a target-specific pass runs after -emit-llvm prints
+// IR, so we need to check NVPTX to make sure that the pass did happen
+// and __nvvm_refle
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 247036
http://reviews.llvm.org/D11380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Sep 8 12:59:09 2015
New Revision: 247036
URL: http://llvm.org/viewvc/llvm-project?rev=247036&view=rev
Log:
Implementation of Boyer-Moore and Boyer-Moore-Horspool searchers for the LFTS.
Added:
libcxx/trunk/test/std/experimental/func/func.searchers/func.searchers.b
None of my performance concerns were relevant to this change FWIW.
I think the reason that this got "fixed" was because people had a tendancy
to *rely* on the name downstream when we made it always present. =/
Personally, I like having *no* names in a no-asserts build because it
ensures that absol
On Tue, Sep 8, 2015 at 10:26 AM, John McCall wrote:
> On Sep 8, 2015, at 8:25 AM, David Blaikie wrote:
> On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rjmccall
>> Date: Tue Sep 8 04:18:30 2015
>> New Revision: 246991
>>
>> URL: h
tra abandoned this revision.
tra added a comment.
Emitting IR is not sufficient to ensure that the kernels survive GDCE, so the
patch does not work with optimizations on.
http://reviews.llvm.org/D11666 would have to do for now.
http://reviews.llvm.org/D11993
_
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM i guess...
I'm a tiny bit surprised that you have to handle this here rather than
something else handling this for you... But not a lit surprised...
http://reviews.llvm.org/D12622
tra marked 2 inline comments as done.
tra added a comment.
http://reviews.llvm.org/D12453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 34230.
tra marked 2 inline comments as done.
tra added a comment.
Implementes Richard Smiths' suggestions:
Fixed attribute order in name mangling.
Replaced std::function with template argument.
http://reviews.llvm.org/D12453
Files:
include/clang/Basic/LangOpt
> On Sep 8, 2015, at 8:25 AM, David Blaikie wrote:
> On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: rjmccall
> Date: Tue Sep 8 04:18:30 2015
> New Revision: 246991
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246991&view=re
Author: nmusgrave
Date: Tue Sep 8 11:38:17 2015
New Revision: 247025
URL: http://llvm.org/viewvc/llvm-project?rev=247025&view=rev
Log:
Failing test highlighting no poisoning if dtor undeclared.
Summary:
If class or struct has not declared a destructor,
no destructor is emitted, and members are n
hintonda added a comment.
In http://reviews.llvm.org/D12646#241493, @bob.wilson wrote:
> On Darwin platforms, the libc++ headers are expected to be installed
> alongside clang. If you're not doing that, then you're building it wrong.
> Adding more fallback options for finding the headers just m
bob.wilson added a comment.
On Darwin platforms, the libc++ headers are expected to be installed alongside
clang. If you're not doing that, then you're building it wrong. Adding more
fallback options for finding the headers just makes things worse, because
instead of a clear failure, you're mor
thakis added a comment.
In http://reviews.llvm.org/D12646#241318, @hintonda wrote:
> In http://reviews.llvm.org/D12646#241308, @kubabrecka wrote:
>
> > In what scenario exactly are you seeing an issue? If it's a just-built
> > clang that can't find C++ headers, then you should just build the li
hintonda added a comment.
> I think it works if you a) check out libcxx into llvm/projects/libcxx b) run
> `make install` and c) run the binary from your install directory.
Yes, that works. But why shouldn't users be able to use the installed version?
Also, if you want to force users to eithe
kubabrecka added a comment.
> > I first noticed it when I tried to run the version of clang-tidy I'd just
> > built and found I had to pass the path for it to find iostream.
>
>
> I think it works if you a) check out libcxx into llvm/projects/libcxx b) run
> `make install` and c) run the bi
Yes, the run-time is now back to where it was before the regression. Thanks!
On Tue, Sep 8, 2015 at 8:16 AM, Manuel Klimek wrote:
> In r247018 I get a ~8x speedup on a synthetic benchmark I tried. Can you
> validate this fixes the regression?
>
> On Sat, Sep 5, 2015 at 12:56 AM Hans Wennborg wro
On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Tue Sep 8 04:18:30 2015
> New Revision: 246991
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246991&view=rev
> Log:
> When building the alloca for a local variable, set i
In r247018 I get a ~8x speedup on a synthetic benchmark I tried. Can you
validate this fixes the regression?
On Sat, Sep 5, 2015 at 12:56 AM Hans Wennborg wrote:
> On Fri, Aug 14, 2015 at 2:55 AM, Manuel Klimek via cfe-commits
> wrote:
> > Author: klimek
> > Date: Fri Aug 14 04:55:36 2015
> > N
Author: klimek
Date: Tue Sep 8 10:14:06 2015
New Revision: 247018
URL: http://llvm.org/viewvc/llvm-project?rev=247018&view=rev
Log:
Fix performance regression when running clang tools.
Brings tool start time for a large synthetic test case down from (on my
machine) 4 seconds to 0.5 seconds.
Mod
nmusgrave updated this revision to Diff 34220.
nmusgrave marked an inline comment as done.
nmusgrave added a comment.
- Rename test.
http://reviews.llvm.org/D12616
Files:
test/CodeGenCXX/sanitize-dtor-trivial.cpp
Index: test/CodeGenCXX/sanitize-dtor-trivial.cpp
==
ikudrin created this revision.
ikudrin added a subscriber: cfe-commits.
With Visual Studio 2015 release, a part of runtime library was extracted and
now comes with Windows Kits. This patch enables clang to use Universal CRT
library if %INCLUDE or %LIB environment varaibles are not specified.
S
Author: chapuni
Date: Tue Sep 8 09:19:13 2015
New Revision: 247015
URL: http://llvm.org/viewvc/llvm-project?rev=247015&view=rev
Log:
clang/test/CodeGen/complex-convert.c: Appease for targeting powerpc64-*.
Modified:
cfe/trunk/test/CodeGen/complex-convert.c
Modified: cfe/trunk/test/CodeGen/c
aaron.ballman added a comment.
This is looking great! Some mostly minor feedback below. The only things I
noticed that may require further consideration are throwing function parameters
and throwing exception handler variables -- I don't think those scenarios
should emit a diagnostic. The forme
On Tue, Sep 08, 2015 at 03:28:12PM +0200, Joerg Sonnenberger via cfe-commits
wro> We don't distinguish Solaris and OpenSolaris forks currently. As such,
> changing one for the other is not a good choice, especially since you
> are more likely to find clang users for Illumos, IMO.
>
> https://www.
On Tue, Sep 08, 2015 at 01:32:21PM +0200, Xan López via cfe-commits wrote:
> On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote:
> > > What do you consider as recent Solaris? When I asked, I've been told
> > > that Illumos has been providing __cxa_atexit since 2013. As such,
On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman wrote:
> On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek wrote:
> > On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman
> wrote:
> >>
> >> On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek
> wrote:
> >> > Yea, we had that discussion a few times, and I can never
On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek wrote:
> On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman wrote:
>>
>> On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek wrote:
>> > Yea, we had that discussion a few times, and I can never remember why we
>> > ended up in the state we're in.
>> > We definit
On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman wrote:
> On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek wrote:
> > Yea, we had that discussion a few times, and I can never remember why we
> > ended up in the state we're in.
> > We definitely had a time where we switched to just using the exact same
hintonda added a comment.
In http://reviews.llvm.org/D12646#241308, @kubabrecka wrote:
> In what scenario exactly are you seeing an issue? If it's a just-built clang
> that can't find C++ headers, then you should just build the libcxx project
> alongside.
clang++ defaults to -stdlib=libc++ f
Author: alexfh
Date: Tue Sep 8 07:26:32 2015
New Revision: 247007
URL: http://llvm.org/viewvc/llvm-project?rev=247007&view=rev
Log:
Add a redirection page to unbreak external links.
Apparently, there are some links to http://clang.llvm.org/extra/clang-tidy.html
in the wild. It's better to keep t
On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek wrote:
> Yea, we had that discussion a few times, and I can never remember why we
> ended up in the state we're in.
> We definitely had a time where we switched to just using the exact same name
> as the node's class name for the matchers.
> I *think*
On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote:
> > What do you consider as recent Solaris? When I asked, I've been told
> > that Illumos has been providing __cxa_atexit since 2013. As such,
> > disabling it for the Solaris family by default seems just wrong.
>
> Solaris
On Tue, Sep 08, 2015 at 01:09:02PM +0200, Joerg Sonnenberger via cfe-commits
wrote:
> On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> > There is no __cxa_finalize symbol available on recent Solaris OS
> > versions, so we need this flag to make non trivial C++ programs
kubabrecka added a comment.
In what scenario exactly are you seeing an issue? If it's a just-built clang
that can't find C++ headers, then you should just build the libcxx project
alongside.
Comment at: lib/Driver/ToolChains.cpp:290-295
@@ +289,8 @@
+
+ // FIXME: We shou
On Mon, Sep 07, 2015 at 11:50:55PM +, Eric Fiselier via cfe-commits wrote:
> EricWF added a comment.
>
> Why would we not use "-isysroot" on other platforms as well?
Because otherwise you can't link in a cross-compiling setup?
Joerg
___
cfe-commits
On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> There is no __cxa_finalize symbol available on recent Solaris OS
> versions, so we need this flag to make non trivial C++ programs run.
What do you consider as recent Solaris? When I asked, I've been told
that Illumos has
matto1990 accepted this revision.
matto1990 added a comment.
This revision is now accepted and ready to land.
Looks good to me now!
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247003: findDominatingStoreToReturn in CGCall.cpp didn't
check if a candidate store (authored by kuhar).
Changed prior to commit:
http://reviews.llvm.org/D12400?vs=34206&id=34207#toc
Repository:
rL L
Author: kuhar
Date: Tue Sep 8 05:36:42 2015
New Revision: 247003
URL: http://llvm.org/viewvc/llvm-project?rev=247003&view=rev
Log:
findDominatingStoreToReturn in CGCall.cpp didn't check if a candidate store
instruction used the ReturnValue as pointer operand or value operand. This
led to wrong co
kuhar updated this revision to Diff 34206.
kuhar added a comment.
Merge with the latest changes to CGCall.cpp
Repository:
rL LLVM
http://reviews.llvm.org/D12400
Files:
lib/CodeGen/CGCall.cpp
test/CodeGen/arm_function_epilog.cpp
Index: test/CodeGen/arm_function_epilog.cpp
===
Author: alexfh
Date: Tue Sep 8 05:31:36 2015
New Revision: 247002
URL: http://llvm.org/viewvc/llvm-project?rev=247002&view=rev
Log:
[clang-tidy] Fix run-clang-tidy.py.
Do not add "-*" to the list of checks. Make consistent the list of enabled
checks and the checks in use. Moreover, removing "-*"
Author: klimek
Date: Tue Sep 8 05:31:09 2015
New Revision: 247001
URL: http://llvm.org/viewvc/llvm-project?rev=247001&view=rev
Log:
Update code owners for AST matchers / libtooling.
Modified:
cfe/trunk/CODE_OWNERS.TXT
Modified: cfe/trunk/CODE_OWNERS.TXT
URL:
http://llvm.org/viewvc/llvm-pro
1 - 100 of 119 matches
Mail list logo
