Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko added a comment. Reid, thank you for the review! One last confirmation (see below), and I'll go ahead. Yours, Andrey Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void

Re: [PATCH] D12736: [PATCH] AST traversal from types to decls

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. This is great, thanks! http://reviews.llvm.org/D12736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r247431 - Revert "Module Debugging: Emit forward declarations for types that are defined in"

Author: adrian Date: Fri Sep 11 12:23:03 2015 New Revision: 247431 URL: http://llvm.org/viewvc/llvm-project?rev=247431=rev Log: Revert "Module Debugging: Emit forward declarations for types that are defined in" This reverts commit r247369 to facilitate reviewing of the following patch.

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

xazax.hun updated this revision to Diff 34554. xazax.hun added a comment. - Addressed the comments. http://reviews.llvm.org/D12767 Files: include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

xazax.hun added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is visited. + bool

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a comment. Right, I understand the behavior change, I'm just wondering why it results in link failures. There isn't a ton of public info about how ObjC++ EH interacts with C++ EH. Repository: rL LLVM http://reviews.llvm.org/D12743

[PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

mspertus created this revision. mspertus added a subscriber: cfe-commits. The Token visualizer in clang.natvis makes debugging Clang in Visual Studio much easier for keywords (because a given keyword is always the same), but it doesn't work very well for identifiers (because they are all

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

mspertus added a comment. Thanks, Aaron! Hal mentioned that I might need to ask you to commit on my behalf as I don't have commit access as of now. http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 11, 2015, at 8:27 AM, David Blaikie wrote: > > > > On Fri, Sep 11, 2015 at 8:18 AM, Adrian Prantl > wrote: > >> On Sep 10, 2015, at 6:56 PM, David Blaikie > > wrote:

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247426: [Static Analyzer] Lambda support. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12652?vs=34498=34555#toc Repository: rL LLVM http://reviews.llvm.org/D12652 Files:

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk added a comment. I think 'optimization' is a bit of a misnomer. There's a comment in this code that reads: "Can't do the optimization if it has non-C++ uses", so that's why I picked up the word. Without SimplifyPersonality(), some objective c++ code can no longer link against c++

r247436 - [CMake] Making the bootstrap-clear target always delete the boostrap build directories.

Author: cbieneman Date: Fri Sep 11 12:38:38 2015 New Revision: 247436 URL: http://llvm.org/viewvc/llvm-project?rev=247436=rev Log: [CMake] Making the bootstrap-clear target always delete the boostrap build directories. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt

Re: r247432 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 11 12:23:08 2015 > New Revision: 247432 > > URL: http://llvm.org/viewvc/llvm-project?rev=247432=rev > Log: > Module Debugging: Emit forward declarations for types

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a subscriber: rnk. rnk added a comment. I'm confused. I thought SimplifyPersonalityFunction was an optimization, but somehow it caused link failures? Why do you think this was an ABI break? Comment at: test/CodeGenObjCXX/exception-cxx.mm:8 @@ +7,3 @@ + throw 0;

r247434 - Update test expectations for LLVM asm printing change

Author: rnk Date: Fri Sep 11 12:27:53 2015 New Revision: 247434 URL: http://llvm.org/viewvc/llvm-project?rev=247434=rev Log: Update test expectations for LLVM asm printing change Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c URL:

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

This made the Chromium build sad. For example: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092/steps/compile/logs/stdio Reduction: $ clang -cc1 -triple i686-pc-windows-msvc18.0.0 -w -fms-extensions -fms-compatibility -fms-compatibility-version=18.0 -std=c++11

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r247442, thank you for the patch! http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r247442 - Extend the Token visualizer used by MSVC to display the identifier text for tok::identifier tokens.

Author: aaronballman Date: Fri Sep 11 13:35:18 2015 New Revision: 247442 URL: http://llvm.org/viewvc/llvm-project?rev=247442=rev Log: Extend the Token visualizer used by MSVC to display the identifier text for tok::identifier tokens. Patch by Mike Spertus. Modified:

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk marked an inline comment as done. vsk added a comment. Addressed Reid's comment w.r.t exception object type. Repository: rL LLVM http://reviews.llvm.org/D12743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12734: Another patch for modernize-loop-convert.

angelgarcia updated this revision to Diff 34535. angelgarcia added a comment. Add examples of 'default' usages. http://reviews.llvm.org/D12734 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopConvertCheck.h clang-tidy/modernize/LoopConvertUtils.cpp

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson added a comment. In http://reviews.llvm.org/D12358#241631, @cfe-commits wrote: > Hi Sean, > > Ted provided more details off-list. He suspects that the problem is that we > likely don't add MemSpaceRegions to the worklist because every region is a > subregion of a MemSpaceRegion, and

r247397 - clang/test/Modules/ExtDebugInfo.cpp: Use %itanium_abi_triple.

Author: chapuni Date: Fri Sep 11 03:56:12 2015 New Revision: 247397 URL: http://llvm.org/viewvc/llvm-project?rev=247397=rev Log: clang/test/Modules/ExtDebugInfo.cpp: Use %itanium_abi_triple. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp

r247392 - Fix \param in r247251. [-Wdocumentation]

Author: chapuni Date: Fri Sep 11 03:13:32 2015 New Revision: 247392 URL: http://llvm.org/viewvc/llvm-project?rev=247392=rev Log: Fix \param in r247251. [-Wdocumentation] Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL:

r247396 - clang/test/Modules/ExtDebugInfo.cpp: Use [[@LINE]].

Author: chapuni Date: Fri Sep 11 03:53:29 2015 New Revision: 247396 URL: http://llvm.org/viewvc/llvm-project?rev=247396=rev Log: clang/test/Modules/ExtDebugInfo.cpp: Use [[@LINE]]. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL:

[clang-tools-extra] r247399 - Another patch for modernize-loop-convert.

Author: angelgarcia Date: Fri Sep 11 05:02:07 2015 New Revision: 247399 URL: http://llvm.org/viewvc/llvm-project?rev=247399=rev Log: Another patch for modernize-loop-convert. Summary: 1. Avoid converting loops that iterate over the size of a container and don't use its elements, as this would

Re: PATCH: Expose the 'file' that is associated with a compile database command

On Thu, Sep 10, 2015 at 8:36 PM Argyrios Kyrtzidis wrote: > On Sep 10, 2015, at 1:48 AM, Manuel Klimek wrote: > > @@ -179,11 +185,13 @@ public: >/// \param Directory The base directory used in the > FixedCompilationDatabase. >static

[clang-tools-extra] r247394 - clang-tidy/misc-sizeof-container.cpp: Add explicit triple.

Author: chapuni Date: Fri Sep 11 03:16:30 2015 New Revision: 247394 URL: http://llvm.org/viewvc/llvm-project?rev=247394=rev Log: clang-tidy/misc-sizeof-container.cpp: Add explicit triple. For targeting LLP64, like Windows x86, size_t is not unsigned long.

r247451 - Record function attribute "stackrealign" instead of using backend option

Author: ahatanak Date: Fri Sep 11 13:55:09 2015 New Revision: 247451 URL: http://llvm.org/viewvc/llvm-project?rev=247451=rev Log: Record function attribute "stackrealign" instead of using backend option -force-align-stack. Also, make changes to the driver so that -mno-stack-realign is no longer

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

This revision was automatically updated to reflect the committed changes. Closed by commit rL247451: Record function attribute "stackrealign" instead of using backend option (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D11815?vs=33456=34569#toc Repository: rL

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp:53 @@ -52,3 +52,3 @@ - if (ExplodedNode *N = C.addTransition()) { + if (ExplodedNode *N = C.generateNonFatalErrorNode()) { if (!BT) zaks.anna wrote: > Can

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik updated the summary for this revision. rcraik updated this revision to Diff 34571. rcraik added a comment. switched to using getIntWidth instead of getTypeSize and updated the error and warning messages accordingly, as have the necessary test cases. The separate check for _Bool bitfields

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, please go ahead. Sorry it's taken so long to get this reviewed. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list

r247448 - Remove an unnecessary check. NFC

Author: adrian Date: Fri Sep 11 13:54:31 2015 New Revision: 247448 URL: http://llvm.org/viewvc/llvm-project?rev=247448=rev Log: Remove an unnecessary check. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL:

r247449 - Fix a typo and make this test stricter.

Author: adrian Date: Fri Sep 11 13:54:34 2015 New Revision: 247449 URL: http://llvm.org/viewvc/llvm-project?rev=247449=rev Log: Fix a typo and make this test stricter. Modified: cfe/trunk/test/Modules/ExtDebugInfo.m Modified: cfe/trunk/test/Modules/ExtDebugInfo.m URL:

r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

Author: adrian Date: Fri Sep 11 13:54:28 2015 New Revision: 247447 URL: http://llvm.org/viewvc/llvm-project?rev=247447=rev Log: Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC). Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified:

r247467 - [CMake] [Darwin] Add support for building bootstrap builds with -flto

Author: cbieneman Date: Fri Sep 11 15:42:57 2015 New Revision: 247467 URL: http://llvm.org/viewvc/llvm-project?rev=247467=rev Log: [CMake] [Darwin] Add support for building bootstrap builds with -flto When building with LTO the bootstrap builds need to depend on libLTO, llvm-ar, and

Re: r246877 - Increase accuracy of __builtin_object_size.

Hi George, After this commit we started to trap on the following case: #include typedef struct { int n; char key[1]; } obj_t; char *str = "hello"; int main() { obj_t* p = (obj_t*)malloc(strlen(str) + 1 + sizeof(int)); strcpy(p->key, str); free(p); return 0; } As far as I

r247464 - [MS ABI] Select an inheritance model in template arguments

Author: majnemer Date: Fri Sep 11 15:18:09 2015 New Revision: 247464 URL: http://llvm.org/viewvc/llvm-project?rev=247464=rev Log: [MS ABI] Select an inheritance model in template arguments We used to only select an inheritance model if the pointer to member was nullptr. Instead, select a model

Re: r246877 - Increase accuracy of __builtin_object_size.

> It might be reasonable for __builtin_object_size(..., 2) to give up if [...] That sounds like the best overall solution to me, as well. Working on a fix now. On Fri, Sep 11, 2015 at 1:22 PM, Richard Smith wrote: > On Fri, Sep 11, 2015 at 12:15 PM, Mikhail Zolotukhin

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Reduced it a bit: template void JSMethod(); class A { int printd(int); void printd(); }; void A::printd() { JSMethod(); } This test case will crash clang at the revision before this commit which means that something more mysterious/horrific is going on... On Fri, Sep 11, 2015

Re: [PATCH] D10018: C11 _Bool bitfield diagnostic

rcraik marked 3 inline comments as done. rcraik added a comment. http://reviews.llvm.org/D10018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: recordDecl() AST matcher

I don't think CXXRecordDecl is an anachronism, so much as an implementation detail; it makes sense to use a smaller class when in C mode, as we don't need most of the features and complexity that CXXRecordDecl brings with it. But... as a user of clang matchers, I don't think I'd want to care about

Re: r247447 - Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).

On Fri, Sep 11, 2015 at 11:54 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 11 13:54:28 2015 > New Revision: 247447 > > URL: http://llvm.org/viewvc/llvm-project?rev=247447=rev > Log: > Remove a redundant check from

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rjmccall added a comment. In http://reviews.llvm.org/D12743#244375, @vsk wrote: > Ah, ok. We have some objective-c++ code which calls into a boost routine > which throws an exception. That results in an undefined reference to > ___objc_personality_v0, because the boost library we linked

Re: [PATCH] D12406: [Analyzer] Add -analyzer-config option for function size the inliner considers as large

This revision was automatically updated to reflect the committed changes. Closed by commit rL247463: [analyzer] Add -analyzer-config option for function size the inliner… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12406?vs=34196=34574#toc Repository: rL LLVM

r247466 - [analyzer] Improve behavior if Clang not found.

Author: ayartsev Date: Fri Sep 11 15:41:09 2015 New Revision: 247466 URL: http://llvm.org/viewvc/llvm-project?rev=247466=rev Log: [analyzer] Improve behavior if Clang not found. - Eliminate 'No such file or directory at scan-build line ...' error if '$RealBin/bin/clang' or '$RealBin/clang'

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

xazax.hun added a comment. In general I like this change, the node handling of the checkers are more readable and reflects the intent in a clearer way. I have some comments inline. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:244 @@ +243,3 @@ +

r247462 - [Edit] Fix issue with tracking what macro argument inputs have been edited.

Author: akirtzidis Date: Fri Sep 11 15:09:11 2015 New Revision: 247462 URL: http://llvm.org/viewvc/llvm-project?rev=247462=rev Log: [Edit] Fix issue with tracking what macro argument inputs have been edited. This was not working correctly, leading to erroneously rejecting valid edits. Modified:

Re: recordDecl() AST matcher

On Fri, Sep 11, 2015 at 4:30 PM, Richard Smith wrote: > I don't think CXXRecordDecl is an anachronism, so much as an implementation > detail; it makes sense to use a smaller class when in C mode, as we don't > need most of the features and complexity that CXXRecordDecl

r247473 - Specify target triple in alwaysinline tests.

Author: eugenis Date: Fri Sep 11 16:10:12 2015 New Revision: 247473 URL: http://llvm.org/viewvc/llvm-project?rev=247473=rev Log: Specify target triple in alwaysinline tests. This should fix the tests on Windows (failing due to mangling differencies). Modified:

Re: [PATCH] D12759: [clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stlcontainers.

Indeed. But this has been fixed before I could get to it. On Thu, Sep 10, 2015 at 10:47 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aaron.ballman added a comment. > > This appears to have broken one of the bots: > >

[clang-tools-extra] r247489 - [clang-tidy] misc-sizeof-container: whitelist std::bitset<>.

Author: alexfh Date: Fri Sep 11 17:54:44 2015 New Revision: 247489 URL: http://llvm.org/viewvc/llvm-project?rev=247489=rev Log: [clang-tidy] misc-sizeof-container: whitelist std::bitset<>. It's fine to use sizeof on std::bitset<>, since it doesn't have any external storage, everything's inside.

r247488 - Add new test file missing from r247486.

Author: rsmith Date: Fri Sep 11 17:54:01 2015 New Revision: 247488 URL: http://llvm.org/viewvc/llvm-project?rev=247488=rev Log: Add new test file missing from r247486. Added: cfe/trunk/test/Modules/Inputs/template-default-args/d.h Added:

r247482 - When comparing two block captures for layout, don't crash

Author: rjmccall Date: Fri Sep 11 17:00:51 2015 New Revision: 247482 URL: http://llvm.org/viewvc/llvm-project?rev=247482=rev Log: When comparing two block captures for layout, don't crash if they have the same alignment and one was 'this'. Fixes PR24780. Modified:

r247476 - [Static Analyzer] Properly cash the configuration option for lambda support.

Author: xazax Date: Fri Sep 11 16:19:39 2015 New Revision: 247476 URL: http://llvm.org/viewvc/llvm-project?rev=247476=rev Log: [Static Analyzer] Properly cash the configuration option for lambda support. Modified: cfe/trunk/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp Modified:

r247477 - Let selector-expr-lvalue.mm actually test something.

Author: nico Date: Fri Sep 11 16:24:40 2015 New Revision: 247477 URL: http://llvm.org/viewvc/llvm-project?rev=247477=rev Log: Let selector-expr-lvalue.mm actually test something. I accidentally introduced a bug locally, and noticed that none of the tests caught it. No longer! Modified:

r247486 - [modules] When picking one of two template declarations as a lookup result,

Author: rsmith Date: Fri Sep 11 17:39:35 2015 New Revision: 247486 URL: http://llvm.org/viewvc/llvm-project?rev=247486=rev Log: [modules] When picking one of two template declarations as a lookup result, it's not sufficient to prefer the declaration with more default arguments, or the one that's

[PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added subscribers: cfe-commits, mzolotukhin. In C, a common idiom is: ``` struct Foo { int a; char cs[1] }; struct Foo *F = (struct Foo *)malloc(sizeof(Foo) + strlen(SomeString)); strcpy(F->cs,

[PATCH] D12797: Refactor LoopConvertCheck.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. Reorder the code in a more logical and understandable way. http://reviews.llvm.org/D12797 Files: clang-tidy/modernize/LoopConvertCheck.cpp

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp LINK : fatal error LNK1104: cannot open file 'kernel32.lib' clang-cl.exe: error: linker command failed with exit code 1104 (use -v to see invocation) Works fine after

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

The test was passing before r247253 without LLVM_ON_WIN32 defined in lib/Support/Locale.cpp, so the llvm::sys::unicode::* functions were used, which may mean that the LLVM_ON_WIN32 functions are overly restrictive. For example, Windows can output the UTF-8 character from source-col-map.c

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Hi, C:\Users\ismail\Desktop>set include INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

Thank you for this! I wasn't certain of what the right way to fix it was. :-) ~Aaron On Fri, Sep 11, 2015 at 9:29 AM, Yaron Keren via cfe-commits wrote: > Author: yrnkrn > Date: Fri Sep 11 08:29:12 2015 > New Revision: 247410 > > URL:

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Please, can you show the output of the following commands: 1) set include 2) set lib 3) clang-cl.exe -### -fms-compatibility-version=19 foo.cpp On 11.09.2015 17:44, İsmail Dönmez wrote: This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe

Re: PATCH: Expose the 'file' that is associated with a compile database command

> On Sep 11, 2015, at 12:21 AM, Manuel Klimek wrote: > > On Thu, Sep 10, 2015 at 8:36 PM Argyrios Kyrtzidis > wrote: >> On Sep 10, 2015, at 1:48 AM, Manuel Klimek > > wrote: >>

Re: [PATCH] D12767: [Static Analyzer] Properly clean up the dynamic type information for dead regions.

xazax.hun marked 2 inline comments as done. xazax.hun added a comment. http://reviews.llvm.org/D12767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

This revision was automatically updated to reflect the committed changes. Closed by commit rL247437: [test] Specify exception object type in two tests (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12743?vs=34408=34560#toc Repository: rL LLVM

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

Taking a look, would appreciate it if we didn't revert this until I give it a fair shot. Shouldn't take too long. On Fri, Sep 11, 2015 at 10:58 AM, Hans Wennborg wrote: > This made the Chromium build sad. For example: > >

r247404 - Fixed HasDeclarationMatcher to properly convert all types into decls where possible. Added objcObjectPointerType(), objcInterfaceDecl(), templateTypeParmType(), injectedClassNameType(), and

Author: aaronballman Date: Fri Sep 11 06:51:24 2015 New Revision: 247404 URL: http://llvm.org/viewvc/llvm-project?rev=247404=rev Log: Fixed HasDeclarationMatcher to properly convert all types into decls where possible. Added objcObjectPointerType(), objcInterfaceDecl(), templateTypeParmType(),

r247401 - [OPENMP] Preserve alignment of the original variables for the captured references.

Author: abataev Date: Fri Sep 11 05:29:41 2015 New Revision: 247401 URL: http://llvm.org/viewvc/llvm-project?rev=247401=rev Log: [OPENMP] Preserve alignment of the original variables for the captured references. Patch makes codegen to preserve alignment of the shared variables captured and used

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Richard? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig added a comment. In http://reviews.llvm.org/D12689#243674, @jroelofs wrote: > A testcase would be good, regardless of which of the proposed fixes ends up > being chosen. I will write it. http://reviews.llvm.org/D12689 ___ cfe-commits

Re: [PATCH] D12684: [INSTALL.txt] Fix formatting - 80 character line

vsk added a subscriber: vsk. vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks, LGTM. http://reviews.llvm.org/D12684 ___ cfe-commits mailing list

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added a comment. second attempt in r247494 Repository: rL LLVM http://reviews.llvm.org/D12087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

vsk added a subscriber: vsk. vsk added a comment. First off, welcome! And thanks for patch. This basically LGTM, but I have one small change I'd like to see (inline comment). Hm, the spec says "The sizeof operator shall not be applied to... an lvalue that designates a bit-field". Sounds like

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave updated this revision to Diff 34614. nmusgrave marked 2 inline comments as done. nmusgrave added a comment. - Fixed testing callback emission order to account for vptr. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp

Re: [PATCH] D12087: always_inline codegen rewrite

Thanks. I just reproduced it on release w/o asserts build and fixed locally. The other problem is fixed as well, I'll try re-landing now. I'll keep an eye on the bot later today and will revert again if necessary. On Fri, Sep 11, 2015 at 6:02 PM, H.J. Lu wrote: > On Fri,

r247494 - Always_inline codegen rewrite.

Author: eugenis Date: Fri Sep 11 20:07:37 2015 New Revision: 247494 URL: http://llvm.org/viewvc/llvm-project?rev=247494=rev Log: Always_inline codegen rewrite. Current implementation may end up emitting an undefined reference for an "inline __attribute__((always_inline))" function by generating

r247496 - clang/test/Driver/stackrealign.c REQUIRES clang-driver.

Author: chapuni Date: Fri Sep 11 20:29:35 2015 New Revision: 247496 URL: http://llvm.org/viewvc/llvm-project?rev=247496=rev Log: clang/test/Driver/stackrealign.c REQUIRES clang-driver. GCC driver, for example cygwin, both "-mstackrealign" "-mno-stackrealign" are passed. Modified:

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

nmusgrave updated this revision to Diff 34617. nmusgrave added a comment. - Poison vtable in either complete or base dtor. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index:

r247498 - Clean up trailing whitespace in the builtin headers

Author: silvas Date: Fri Sep 11 21:55:19 2015 New Revision: 247498 URL: http://llvm.org/viewvc/llvm-project?rev=247498=rev Log: Clean up trailing whitespace in the builtin headers Modified: cfe/trunk/lib/Headers/altivec.h cfe/trunk/lib/Headers/ammintrin.h

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:165 @@ -159,1 +164,3 @@ +/// Indicator of whether the most-derived object is an array. +bool MostDerivedIsArrayElement : 1; array -> array element. Comment at:

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:543 @@ +542,3 @@ + if (Fn->isUsedByMetadata()) +llvm::ValueAsMetadata::handleRAUW(Fn, StubFn); +} As the comment says. W/o this, the debug info for .alwaysinline instructions is

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis updated this revision to Diff 34610. eugenis added a comment. Fixed the debug info problem. Repository: rL LLVM http://reviews.llvm.org/D12087 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CodeGenModule.cpp

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

rsmith added a subscriber: rsmith. Comment at: include/clang/AST/Type.h:1210 @@ +1209,3 @@ +/// Which keyword(s) were used to create an AutoType. +enum struct AutoTypeKeyword : unsigned char { + /// \brief auto Please use `enum class` here; we don't use `enum

Re: [clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

On Fri, Sep 11, 2015 at 9:27 AM, Alexander Kornienko via cfe-commits wrote: > Thank you for the fix and sorry for breaking this again. I wonder what's the > reason windows-targeting enables -fdelayed-template-parsing? Because that's required for MSVC compatibility. >

Re: recordDecl() AST matcher

Ping? On Tue, Sep 8, 2015 at 9:26 AM, Manuel Klimek wrote: > On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman wrote: >> >> On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek wrote: >> > On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman

Re: [clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

Thank you for the fix and sorry for breaking this again. I wonder what's the reason windows-targeting enables -fdelayed-template-parsing? Would it be the right thing to always turn this off in clang-tidy? On Fri, Sep 11, 2015 at 10:16 AM, NAKAMURA Takumi via cfe-commits <

Re: recordDecl() AST matcher

Richard! We need an informed opinion :D On Fri, Sep 11, 2015 at 3:07 PM Aaron Ballman wrote: > Ping? > > On Tue, Sep 8, 2015 at 9:26 AM, Manuel Klimek wrote: > > On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman > wrote: > >> > >>

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

dcoughlin added a comment. I'll look at this today. Thanks for your patience! http://reviews.llvm.org/D12358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added inline comments. Comment at: lib/Sema/SemaType.cpp:5876 @@ +5875,3 @@ + +if (!IsCtorOrDtor) { + if (CurCC != DefaultCC || DefaultCC == ToCC) This looks like the !IsCtorOrDtor check that affects Itanium. Isn't it already handled for MS C++

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

On Fri, Sep 11, 2015 at 8:18 AM, Adrian Prantl wrote: > > On Sep 10, 2015, at 6:56 PM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie wrote: > >> >> >> On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via

Re: r247369 - Module Debugging: Emit forward declarations for types that are defined in

> On Sep 10, 2015, at 6:56 PM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie > wrote: > > > On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits >

r247421 - [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

Author: vedantk Date: Fri Sep 11 10:40:05 2015 New Revision: 247421 URL: http://llvm.org/viewvc/llvm-project?rev=247421=rev Log: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst When uses of personality functions were moved from LandingPadInst to Function, we forgot to update

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

vsk accepted this revision. vsk added a reviewer: vsk. vsk marked an inline comment as done. vsk added a comment. This revision is now accepted and ready to land. Committed r247421 http://reviews.llvm.org/D12743 ___ cfe-commits mailing list

r247426 - [Static Analyzer] Lambda support.

Author: xazax Date: Fri Sep 11 11:55:01 2015 New Revision: 247426 URL: http://llvm.org/viewvc/llvm-project?rev=247426=rev Log: [Static Analyzer] Lambda support. Differential Revision: http://reviews.llvm.org/D12652 Added: cfe/trunk/test/Analysis/lambda-notes.cpp Modified: