Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 34664. Alexander_Droste added a comment. - corrected some typos http://reviews.llvm.org/D12761 Files: tools/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td

Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

Thanks a lot! On Mon, Sep 14, 2015 at 3:49 PM, NAKAMURA Takumi wrote: > Makes sense. I have updated CLANG_TEST_DEPS in r247554. > > On Mon, Sep 14, 2015 at 9:38 PM Simon Atanasyan wrote: >> >> On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Utility.cpp:71 @@ +70,3 @@ + if (FR) { +VariableName = VR->getDecl()->getNameAsString() + "." + + FR->getDecl()->getNameAsString(); This

[clang-tools-extra] r247541 - Prune CRLF.

Author: chapuni Date: Mon Sep 14 06:13:39 2015 New Revision: 247541 URL: http://llvm.org/viewvc/llvm-project?rev=247541=rev Log: Prune CRLF. Modified: clang-tools-extra/trunk/modularize/Modularize.cpp Modified: clang-tools-extra/trunk/modularize/Modularize.cpp URL:

r247554 - [CMake] r247548 introduced llvm-readobj.

Author: chapuni Date: Mon Sep 14 07:42:52 2015 New Revision: 247554 URL: http://llvm.org/viewvc/llvm-project?rev=247554=rev Log: [CMake] r247548 introduced llvm-readobj. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL:

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

djasper added a comment. Ping? http://reviews.llvm.org/D11240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

On Mon, Sep 14, 2015 at 3:24 PM, NAKAMURA Takumi wrote: > Why is it tested in clang? Because the problem fixed by r247546 can be reproduced only in case of using inline assembler. And the problem is in the incorrect ELF header flag. So this test cannot be in llvm/test

[clang-tools-extra] r247536 - Test commit.

Author: mkurdej Date: Mon Sep 14 03:05:12 2015 New Revision: 247536 URL: http://llvm.org/viewvc/llvm-project?rev=247536=rev Log: Test commit. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified:

Re: r247548 - [mips] Add test case to check ABI flag emissions in case of inline assembler

Why is it tested in clang? FYI, update CLANG_TEST_DEPS in clang/test/CMakeLists.txt, if it would remain in clang/test. On Mon, Sep 14, 2015 at 8:24 PM Simon Atanasyan via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: atanasyan > Date: Mon Sep 14 06:23:02 2015 > New Revision: 247548

[clang-tools-extra] r247559 - [clang-tidy] misc-sizeof-container: whitelist std::array

Author: alexfh Date: Mon Sep 14 08:55:29 2015 New Revision: 247559 URL: http://llvm.org/viewvc/llvm-project?rev=247559=rev Log: [clang-tidy] misc-sizeof-container: whitelist std::array Modified: clang-tools-extra/trunk/clang-tidy/misc/SizeofContainerCheck.cpp

r247560 - Test commit

Author: rcraik Date: Mon Sep 14 09:08:18 2015 New Revision: 247560 URL: http://llvm.org/viewvc/llvm-project?rev=247560=rev Log: Test commit Remove some trailing whitespace Modified: cfe/trunk/lib/Basic/Builtins.cpp Modified: cfe/trunk/lib/Basic/Builtins.cpp URL:

Re: [PATCH] __attribute__((enable_if)) and non-overloaded member functions

Ping > Gently ping. > >> On Aug 26, 2015, at 2:40 PM, Ettore Speziale >> wrote: >> >> Forward to the right ML: >> Sorry about the extreme delay. This patch slipped through the cracks, and I only noticed it again when searching my email for enable_if.

Re: recordDecl() AST matcher

On Sat, Sep 12, 2015 at 11:06 PM, Manuel Klimek wrote: > > > On Sat, Sep 12, 2015, 9:25 PM Aaron Ballman wrote: >> >> On Sat, Sep 12, 2015 at 8:22 AM, Manuel Klimek wrote: >> > >> > >> > On Fri, Sep 11, 2015 at 10:39 PM Aaron Ballman

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

sepavloff updated this revision to Diff 34673. sepavloff added a comment. Updated diagnostics according to Sean's notes ('textual module' -> 'textual header') http://reviews.llvm.org/D11844 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

simoatze created this revision. simoatze added reviewers: kbarton, nemanjai, wschmidt. simoatze added a subscriber: cfe-commits. Enabling ThreadSanitizer on PPC64(BE/LE) platforms. The current patch will enable the flag "-fsanitize=thread" on Clang on PPC64 systems.

Re: [PATCH] D12369: [clang-format] Fix alignConsecutiveAssignments not working properly

berenm added a comment. I don't have credentials to commit it, anybody could do it for me if the diff is ok? Thanks! http://reviews.llvm.org/D12369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015, 8:40 AM Aaron Ballman wrote: > On Sat, Sep 12, 2015 at 11:06 PM, Manuel Klimek wrote: > > > > > > On Sat, Sep 12, 2015, 9:25 PM Aaron Ballman > wrote: > >> > >> On Sat, Sep 12, 2015 at 8:22 AM, Manuel

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

dougk updated the summary for this revision. dougk updated this revision to Diff 34682. dougk added a comment. Changes per review - but only a minimally correct change to finding the libraries. Using multilibs remains as a future task. Also renamed SHAVE::Linker to Myriad::Linker.

[clang-tools-extra] r247578 - [clang-tidy] misc-sizeof-container: remove fix-it hints

Author: alexfh Date: Mon Sep 14 11:51:52 2015 New Revision: 247578 URL: http://llvm.org/viewvc/llvm-project?rev=247578=rev Log: [clang-tidy] misc-sizeof-container: remove fix-it hints This turned out to be a rather noisy check, so automated fixes will only do harm. Remove them completely.

Re: recordDecl() AST matcher

So, back in the day when we implemented the matchers, we decided on actually wanting to remove all the CXX... AST nodes (there are more of them). I don't know how this would work as recordDecl already exists. But I'd be somewhat hesitant to introduce a cxxRecordDecl matcher if there is still a

r247584 - Update cxx-irgen.cpp test to allow signext in alwaysinline functions.

Author: sfantao Date: Mon Sep 14 12:41:32 2015 New Revision: 247584 URL: http://llvm.org/viewvc/llvm-project?rev=247584=rev Log: Update cxx-irgen.cpp test to allow signext in alwaysinline functions. This was causing an error in Power8 targets. Modified: cfe/trunk/test/Modules/cxx-irgen.cpp

[PATCH] D12848: [Static Analyzer] Nullability checker optimization.

xazax.hun created this revision. xazax.hun added reviewers: dcoughlin, zaks.anna, jordan_rose. xazax.hun added a subscriber: cfe-commits. Right now the nullability checker only tracks symbolic regions. For this reason if there are no dead symbols it is safe to skip the precondition checking. I

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 7:24 PM, Manuel Klimek wrote: > On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper wrote: > >> So, back in the day when we implemented the matchers, we decided on >> actually wanting to remove all the CXX... AST nodes (there are more of

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 10:30 AM Daniel Jasper wrote: > On Mon, Sep 14, 2015 at 7:24 PM, Manuel Klimek wrote: > >> On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper >> wrote: >> >>> So, back in the day when we implemented the matchers, we

Re: [PATCH] D12845: [Sparc]: Myriad toolchain should assume -gdwarf-3 in cc1 invocation

dougk added a comment. This patch is wrong. Fixes are pending. http://reviews.llvm.org/D12845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r247580 - [clang-tidy] updated misc-sizeof-container docs.

Author: alexfh Date: Mon Sep 14 11:56:57 2015 New Revision: 247580 URL: http://llvm.org/viewvc/llvm-project?rev=247580=rev Log: [clang-tidy] updated misc-sizeof-container docs. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-sizeof-container.rst Modified:

Re: recordDecl() AST matcher

This is the full patch that corrects all the compile errors MSVC was generating. If we have any platform-specific checkers, they may have been missed. But this should give an idea of the scope of the changes we're asking folks to make. ~Aaron On Mon, Sep 14, 2015 at 1:03 PM, Aaron Ballman

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper wrote: > So, back in the day when we implemented the matchers, we decided on > actually wanting to remove all the CXX... AST nodes (there are more of > them). > Note that Richard has paddled back on this and now says the CXX...

r247623 - [WebAssembly] Simplify code by avoiding duplicating the default behavior.

Author: djg Date: Mon Sep 14 16:54:32 2015 New Revision: 247623 URL: http://llvm.org/viewvc/llvm-project?rev=247623=rev Log: [WebAssembly] Simplify code by avoiding duplicating the default behavior. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified:

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

From the driver point of view, how does it know if it is targeting illumos or solaris? Do they use different triples? In any case, if there is interest in the future this patch can be extended to work on illumos by * Creating a shouldUseCxaAtexitByDefault and passing in whatever information is

Re: [PATCH] D1623: Support __builtin_ms_va_list.

cdavis5x added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3598 @@ -3599,1 +3597,3 @@ +Address CodeGenFunction::EmitVAArg(Address VAListAddr, QualType Ty, bool IsMS) { + return CGM.getTypes().getABIInfo().EmitVAArg(*this, VAListAddr, Ty, IsMS); }

r247624 - [WebAssembly] Define the atomic type sizes

Author: djg Date: Mon Sep 14 16:56:37 2015 New Revision: 247624 URL: http://llvm.org/viewvc/llvm-project?rev=247624=rev Log: [WebAssembly] Define the atomic type sizes WebAssembly's spec has now been updated to specify some guarantees about lock free atomic accesses. Update clang to match. This

Re: [PATCH] D12862: [WebAssembly] Define the atomic type sizes

This revision was automatically updated to reflect the committed changes. Closed by commit rL247624: [WebAssembly] Define the atomic type sizes (authored by djg). Changed prior to commit: http://reviews.llvm.org/D12862?vs=34731=34739#toc Repository: rL LLVM http://reviews.llvm.org/D12862

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek updated this revision to Diff 34761. Prazek marked 3 inline comments as done. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.cpp

r247614 - [Static Analyzer] Turn on some nullability checks by default.

Author: xazax Date: Mon Sep 14 15:34:06 2015 New Revision: 247614 URL: http://llvm.org/viewvc/llvm-project?rev=247614=rev Log: [Static Analyzer] Turn on some nullability checks by default. Differential Revision: http://reviews.llvm.org/D12858 Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko added a comment. OK -- I removed the check in Itanium ABI part, restored back the test and committed the patch. Thanks for reviewing! Repository: rL LLVM http://reviews.llvm.org/D12402 ___ cfe-commits mailing list

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 5:44 PM, Daniel Jasper wrote: > Ok. I am happy with this then. > > (Just personally grumpy having to write > cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ). I share your grumpiness about the cxxConstructorDecl, but probably won't share

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek updated this revision to Diff 34750. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.cpp test/CodeGenCXX/vtable-available-externally.cpp Index:

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

rtrieu added a comment. Why are you leaking the raw encoding of locations from the SourceManager? This is an internal implementation detail and should not be relied on externally. SourceLocation is the typical way to use locations. http://reviews.llvm.org/D12379

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406 @@ +393,15 @@ + +for (const auto : VtableLayout.vtable_components()) { + if (VtableComponent.isRTTIKind()) { +const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTIDecl(); +

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

rtrieu added a comment. In http://reviews.llvm.org/D12379#245850, @zhengkai wrote: > In http://reviews.llvm.org/D12379#245849, @rtrieu wrote: > > > Why are you leaking the raw encoding of locations from the SourceManager? > > This is an internal implementation detail and should not be relied

Re: [PATCH] D12858: [Static Analyzer] Turn on some nullability checks by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247614: [Static Analyzer] Turn on some nullability checks by default. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12858?vs=34720=34726#toc Repository: rL LLVM

r247618 - C11 _Bool bitfield diagnostic

Author: rcraik Date: Mon Sep 14 16:27:36 2015 New Revision: 247618 URL: http://llvm.org/viewvc/llvm-project?rev=247618=rev Log: C11 _Bool bitfield diagnostic Summary: Implement DR262 (for C). This patch will mainly affect bitfields of type _Bool Reviewers: fraggamuffin, rsmith Subscribers:

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman wrote: > On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote: > > > > > > On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman > > wrote: > >> > >> On Mon, Sep 14, 2015 at 2:45 PM,

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

majnemer added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406 @@ +393,15 @@ + +for (const auto : VtableLayout.vtable_components()) { + if (VtableComponent.isRTTIKind()) { +const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTIDecl(); +

Re: r247618 - C11 _Bool bitfield diagnostic

This also fires for bool in C++ files, even though the commit message saying C11 and _Bool. Given the test changes, I suppose that's intentional? This fires a lot on existing code, for example protobuf: ../../third_party/protobuf/src/google/protobuf/extension_set.h:465:10: error: width of

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai added a comment. In http://reviews.llvm.org/D12379#245849, @rtrieu wrote: > Why are you leaking the raw encoding of locations from the SourceManager? > This is an internal implementation detail and should not be relied on > externally. SourceLocation is the typical way to use

r247612 - [Static Analyzer] Nullability checker optimization.

Author: xazax Date: Mon Sep 14 15:31:46 2015 New Revision: 247612 URL: http://llvm.org/viewvc/llvm-project?rev=247612=rev Log: [Static Analyzer] Nullability checker optimization. Differential Revision: http://reviews.llvm.org/D12848 Modified:

Re: [PATCH] D12848: [Static Analyzer] Nullability checker optimization.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247612: [Static Analyzer] Nullability checker optimization. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12848?vs=34693=34725#toc Repository: rL LLVM

r247611 - Driver should forward at most one gdwarf-N flag to cc1as.

Author: dougk Date: Mon Sep 14 15:31:28 2015 New Revision: 247611 URL: http://llvm.org/viewvc/llvm-project?rev=247611=rev Log: Driver should forward at most one gdwarf-N flag to cc1as. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/integrated-as.s Modified:

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

dougk updated this revision to Diff 34729. dougk added a comment. Delete the overrides of getTool() and buildAssembler() in MyriadToolChain. http://reviews.llvm.org/D12541 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL247619: PR24595: Ignore calling convention modifiers for structors in MS ABI. (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D12402?vs=34477=34735#toc Repository: rL LLVM

r247619 - PR24595: Ignore calling convention modifiers for structors in MS ABI.

Author: asbokhan Date: Mon Sep 14 16:29:57 2015 New Revision: 247619 URL: http://llvm.org/viewvc/llvm-project?rev=247619=rev Log: PR24595: Ignore calling convention modifiers for structors in MS ABI. MS compiler ignores calling convention modifiers for structors. This patch makes clang do the

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

MyDeveloperDay updated this revision to Diff 34741. MyDeveloperDay added a comment. Handle subsequent catch statements http://reviews.llvm.org/D12492 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp

[PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek created this revision. Prazek added reviewers: rsmith, rjmccall, hans, majnemer. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp

Re: [PATCH] D12862: [WebAssembly] Define the atomic type sizes

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D12862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r247622 - [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64

Author: djg Date: Mon Sep 14 16:49:41 2015 New Revision: 247622 URL: http://llvm.org/viewvc/llvm-project?rev=247622=rev Log: [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64 This makes int_fast64_t and int_least64_t the same type as int64_t, and eliminates a difference

Re: [PATCH] D12861: [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64

This revision was automatically updated to reflect the committed changes. Closed by commit rL247622: [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64 (authored by djg). Changed prior to commit: http://reviews.llvm.org/D12861?vs=34727=34738#toc Repository: rL LLVM

r247634 - [Solaris] Default to -fno-cxa-finalize.

Author: rafael Date: Mon Sep 14 18:21:31 2015 New Revision: 247634 URL: http://llvm.org/viewvc/llvm-project?rev=247634=rev Log: [Solaris] Default to -fno-cxa-finalize. There is no __cxa_finalize symbol available on recent Solaris OS versions, so we need this flag to make non trivial C++ programs

r247640 - clang/test/CodeGenCXX/2009-04-23-bool2.cpp: Avoid -mms-bitfields to add explicit triple.

Author: chapuni Date: Mon Sep 14 18:50:08 2015 New Revision: 247640 URL: http://llvm.org/viewvc/llvm-project?rev=247640=rev Log: clang/test/CodeGenCXX/2009-04-23-bool2.cpp: Avoid -mms-bitfields to add explicit triple. FIXME: Better way to cancel -mms-bitfields? Modified:

Re: r247618 - C11 _Bool bitfield diagnostic

On Mon, Sep 14, 2015 at 5:55 PM, David Majnemer wrote: > On Mon, Sep 14, 2015 at 5:40 PM, Richard Smith > wrote: > >> On Mon, Sep 14, 2015 at 5:31 PM, David Majnemer > > wrote: >> >>> On Mon, Sep 14, 2015 at 5:28 PM,

Re: r247618 - C11 _Bool bitfield diagnostic

On Mon, Sep 14, 2015 at 6:10 PM, David Majnemer wrote: > On Mon, Sep 14, 2015 at 6:01 PM, Richard Smith > wrote: > >> On Mon, Sep 14, 2015 at 5:55 PM, David Majnemer > > wrote: >> >>> On Mon, Sep 14, 2015 at 5:40 PM,

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

rtrieu added a comment. In http://reviews.llvm.org/D12379#245868, @zhengkai wrote: > In http://reviews.llvm.org/D12379#245861, @rtrieu wrote: > > > In http://reviews.llvm.org/D12379#245850, @zhengkai wrote: > > > > > In http://reviews.llvm.org/D12379#245849, @rtrieu wrote: > > > > > > > Why are

r247646 - Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Mon Sep 14 19:37:06 2015 New Revision: 247646 URL: http://llvm.org/viewvc/llvm-project?rev=247646=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization purposes.

Re: r247651 - [MS ABI] Overwide bool bitfields should be permitted

On Mon, Sep 14, 2015 at 6:00 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Mon Sep 14 20:00:55 2015 > New Revision: 247651 > > URL: http://llvm.org/viewvc/llvm-project?rev=247651=rev > Log: > [MS ABI] Overwide bool bitfields should be permitted

Re: r247651 - [MS ABI] Overwide bool bitfields should be permitted

On Mon, Sep 14, 2015 at 6:03 PM, Richard Smith wrote: > On Mon, Sep 14, 2015 at 6:00 PM, David Majnemer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: majnemer >> Date: Mon Sep 14 20:00:55 2015 >> New Revision: 247651 >> >> URL:

r247643 - Prevent implicit re-interpret casts between ExtVector and Scalar types.

Author: scanon Date: Mon Sep 14 19:21:56 2015 New Revision: 247643 URL: http://llvm.org/viewvc/llvm-project?rev=247643=rev Log: Prevent implicit re-interpret casts between ExtVector and Scalar types. Previously, in certain cases lax vector conversions could occur between scalar floating-point

r247651 - [MS ABI] Overwide bool bitfields should be permitted

Author: majnemer Date: Mon Sep 14 20:00:55 2015 New Revision: 247651 URL: http://llvm.org/viewvc/llvm-project?rev=247651=rev Log: [MS ABI] Overwide bool bitfields should be permitted Overwide bool bitfields have eight bits of storage size, make sure we take the padding into account when

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

jordan_rose added a comment. Hm, interesting. I'm not sure this is even sufficient, though: what if I have a FieldRegion that's a sub-region of an ElementRegion with a symbolic index? RegionStore does everything by base regions, so we won't ever see that intermediate region with the symbolic

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai added a comment. In http://reviews.llvm.org/D12379#245861, @rtrieu wrote: > In http://reviews.llvm.org/D12379#245850, @zhengkai wrote: > > > In http://reviews.llvm.org/D12379#245849, @rtrieu wrote: > > > > > Why are you leaking the raw encoding of locations from the SourceManager? > >

r247653 - [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

Author: dcoughlin Date: Mon Sep 14 20:13:53 2015 New Revision: 247653 URL: http://llvm.org/viewvc/llvm-project?rev=247653=rev Log: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil. In Objective-C, method calls with nil receivers are essentially no-ops. They do not fault

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247653: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12123?vs=33836=34772#toc Repository: rL LLVM

Re: r247618 - C11 _Bool bitfield diagnostic

On Mon, Sep 14, 2015 at 5:31 PM, David Majnemer wrote: > On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>>

r247650 - small test bugfix

Author: prazek Date: Mon Sep 14 19:55:29 2015 New Revision: 247650 URL: http://llvm.org/viewvc/llvm-project?rev=247650=rev Log: small test bugfix Modified: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp Modified: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp URL:

r247660 - [analyzer] Restore behavior change introduced by r247657.

Author: dcoughlin Date: Mon Sep 14 22:28:27 2015 New Revision: 247660 URL: http://llvm.org/viewvc/llvm-project?rev=247660=rev Log: [analyzer] Restore behavior change introduced by r247657. r247657 fixed warnings about unused variables when compiling without asserts but changed behavior. This

Re: r247618 - C11 _Bool bitfield diagnostic

On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This also fires for bool in C++ files, even though the commit message > saying C11 and _Bool. Given the test changes, I suppose that's intentional? > This fires a lot on existing code, for example

Re: [PATCH] D1623: Support __builtin_ms_va_list.

cdavis5x updated this revision to Diff 34728. cdavis5x added a comment. Address review comments. - Pull out `va_arg` emission on `__builtin_ms_va_arg` to its own method on `ABIInfo`. That way, ABI implementers don't need to care that this extension even exists. - Attempt to push repeated

[PATCH] D12861: [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64

sunfish created this revision. sunfish added a reviewer: jfb. sunfish added a subscriber: cfe-commits. sunfish set the repository for this revision to rL LLVM. Herald added subscribers: dschuff, jfb. This makes int_fast64_t and int_least64_t the same type as int64_t, and eliminates a difference

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

klimek added a comment. First round of comments; some things are still a bit confusing, so I hope another round will help to weed them out. Comment at: include/clang/Tooling/Core/Replacement.h:223-224 @@ -222,1 +222,4 @@ +/// \brief Merges to sets of replacements with the

Re: recordDecl() AST matcher

Btw, I think generating them, potentially into several different headers to work around the compile time issue isn't such a bad idea. On Mon, Sep 14, 2015 at 11:45 PM, Manuel Klimek wrote: > Feel free to rename the AST nodes :) > > On Mon, Sep 14, 2015, 2:44 PM Daniel Jasper

r247535 - [Sema] Reject value-initialization of function types

Author: majnemer Date: Mon Sep 14 02:05:00 2015 New Revision: 247535 URL: http://llvm.org/viewvc/llvm-project?rev=247535=rev Log: [Sema] Reject value-initialization of function types T in the expression T() must be a non-array complete object type or the void type. Function types are neither.

[PATCH] D12852: [Static Analyzer] Moving nullability checkers to a top level package.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose. xazax.hun added a subscriber: cfe-commits. This patch is a preparation to enabling some of the nullability checks by default. 1. Moved nullability checkers to a top level package. The core package is

Re: [PATCH] D12852: [Static Analyzer] Moving nullability checkers to a top level package.

xazax.hun updated this revision to Diff 34705. xazax.hun added a comment. Removed an unintended comment formatting change. http://reviews.llvm.org/D12852 Files: lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm

r247586 - Revert "[opaque pointer type] update for LLVM API change"

Author: dblaikie Date: Mon Sep 14 13:02:04 2015 New Revision: 247586 URL: http://llvm.org/viewvc/llvm-project?rev=247586=rev Log: Revert "[opaque pointer type] update for LLVM API change" This was the wrong direction to take anyway (because ultimately the GlobalValue needed the pointee type

Re: [PATCH] D12852: [Static Analyzer] Moving nullability checkers to a top level package.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Please, explain in code why you are doing this. Otherwise, LGTM. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:139 @@ -138,2 +138,3 @@

r247590 - [Static Analyzer] Moving nullability checkers to a top level package.

Author: xazax Date: Mon Sep 14 13:31:34 2015 New Revision: 247590 URL: http://llvm.org/viewvc/llvm-project?rev=247590=rev Log: [Static Analyzer] Moving nullability checkers to a top level package. Differential Revision: http://reviews.llvm.org/D12852 Added:

Re: [PATCH] D12852: [Static Analyzer] Moving nullability checkers to a top level package.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247590: [Static Analyzer] Moving nullability checkers to a top level package. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12852?vs=34705=34713#toc Repository: rL LLVM

r247593 - [opaque pointer type] Fix a few uses of PointerType::getElementType in favor of uses of types already available elsewhere

Author: dblaikie Date: Mon Sep 14 13:38:22 2015 New Revision: 247593 URL: http://llvm.org/viewvc/llvm-project?rev=247593=rev Log: [opaque pointer type] Fix a few uses of PointerType::getElementType in favor of uses of types already available elsewhere These are a few cleanups I happened to have

[PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro created this revision. loladiro added a reviewer: bkramer. loladiro added a subscriber: cfe-commits. loladiro set the repository for this revision to rL LLVM. I feed custom buffers to clang, and since the buffers store an explicit length, I did not think to null-terminate them. However,

[PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

bader created this revision. bader added a reviewer: pekka.jaaskelainen. bader added a subscriber: cfe-commits. Patch by Pedro Ferreira. This patch was reviewed here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150629/thread.html#131992, but wasn't submitted into the tree.

Re: r247494 - Always_inline codegen rewrite.

Hi Evgeniy, I commit a small change to one of the regression tests to allow a signext to be generated: http://reviews.llvm.org/rL247584. It was causing an error in Power8 targets. In my view is an harmless change but you may want to take a look and see if that is fine by you. Thanks! Samuel

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 1:37 PM, Manuel Klimek wrote: > On Mon, Sep 14, 2015 at 10:30 AM Daniel Jasper wrote: >> >> On Mon, Sep 14, 2015 at 7:24 PM, Manuel Klimek wrote: >>> >>> On Mon, Sep 14, 2015 at 10:21 AM Daniel Jasper

Re: recordDecl() AST matcher

By this point, I see that change might be profitable overall. However, lets completely map this out. Changing just cxxRecordDecl() can actually increase confusion in other areas. Right now, not a single AST matcher has the cxx prefix (although a total of 28 stand for the corresponding CXX.. AST

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

zaks.anna added inline comments. Comment at: test/Analysis/free.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -analyze -analyzer-store=region -analyzer-checker=core,unix.Malloc -fblocks -verify %s +// RUN: %clang_cc1 -analyze -analyzer-store=region -analyzer-checker=core,unix.Malloc

Re: [PATCH] D12818: [Static Analyzer] Relaxing a caching out related assert.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247598: [Static Analyzer] Relaxing a caching out related assert. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12818?vs=34579=34719#toc Repository: rL LLVM

Re: r247494 - Always_inline codegen rewrite.

Thanks! On Mon, Sep 14, 2015 at 10:50 AM, Samuel F Antao wrote: > Hi Evgeniy, > > I commit a small change to one of the regression tests to allow a signext to > be generated: http://reviews.llvm.org/rL247584. > > It was causing an error in Power8 targets. In my view is an

r247598 - [Static Analyzer] Relaxing a caching out related assert.

Author: xazax Date: Mon Sep 14 14:00:08 2015 New Revision: 247598 URL: http://llvm.org/viewvc/llvm-project?rev=247598=rev Log: [Static Analyzer] Relaxing a caching out related assert. Differential Revision: http://reviews.llvm.org/D12818 Modified:

Re: recordDecl() AST matcher

On Mon, Sep 14, 2015 at 11:45 AM Daniel Jasper wrote: > By this point, I see that change might be profitable overall. However, > lets completely map this out. Changing just cxxRecordDecl() can actually > increase confusion in other areas. Right now, not a single AST matcher

r247603 - [Solaris] Add -lc also when linking shared libraries

Author: rafael Date: Mon Sep 14 14:30:53 2015 New Revision: 247603 URL: http://llvm.org/viewvc/llvm-project?rev=247603=rev Log: [Solaris] Add -lc also when linking shared libraries This is actually needed, otherwise libc won't be added at all. For instance when building libclang.so all the libc

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

george.burgess.iv updated this revision to Diff 34710. george.burgess.iv marked 4 inline comments as done. george.burgess.iv added a comment. Addressed all feedback -- added a walk of the Designator as suggested. Regarding `isDesignatorAtObjectEnd`: I'm assuming that the Index returned by

  1   2   >