r247740 - Don't crash when passing &@selector to a _Nonnull parameter. Fixes PR24774.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 18:17:17 2015 New Revision: 247740 URL: http://llvm.org/viewvc/llvm-project?rev=247740=rev Log: Don't crash when passing &@selector to a _Nonnull parameter. Fixes PR24774. The root cause here is that ObjCSelectorExpr is an rvalue, yet it can have its address taken.

Re: r247618 - C11 _Bool bitfield diagnostic

2015-09-15 Thread Richard Smith via cfe-commits
On Tue, Sep 15, 2015 at 12:38 PM, Nico Weber wrote: > With this patch, we warn on `bool a : 4;`, yet we don't warn on `bool b` > (which has 8 bits storage, 1 bit value). Warning on `bool b` is silly of > course, but why is warning on `bool a : 4` useful? That's like 50% more

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 34869. sfantao added a comment. Update code to use implicit parameters for the captured variables using `GenerateOpenMPCapturedStmtFunction`, similarly to what is done to other directives. `UseOnlyReferences` boolean was added to

r247733 - invariant.group-for-vptrs test fix

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 18:04:47 2015 New Revision: 247733 URL: http://llvm.org/viewvc/llvm-project?rev=247733=rev Log: invariant.group-for-vptrs test fix Modified: cfe/trunk/test/CodeGenCXX/invariant.group-for-vptrs.cpp Modified:

r247742 - [MS ABI] Add a C++ test for -fnew-ms-eh

2015-09-15 Thread David Majnemer via cfe-commits
Author: majnemer Date: Tue Sep 15 18:30:42 2015 New Revision: 247742 URL: http://llvm.org/viewvc/llvm-project?rev=247742=rev Log: [MS ABI] Add a C++ test for -fnew-ms-eh Added: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp Added: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp URL:

r247762 - Implementation and testing for poisoning vtable

2015-09-15 Thread Naomi Musgrave via cfe-commits
Author: nmusgrave Date: Tue Sep 15 19:38:22 2015 New Revision: 247762 URL: http://llvm.org/viewvc/llvm-project?rev=247762=rev Log: Implementation and testing for poisoning vtable ptr in dtor. Summary: After destruction, invocation of virtual functions prevented by poisoning vtable pointer.

Re: [PATCH] D12889: [Static Analyzer] Generics Checker: When an ObjC method returns a specialized object, track it properly.

2015-09-15 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:675 @@ +674,3 @@ + + QualType ResultType = Method->getReturnType().substObjCTypeArgs( + C, TypeArgs, ObjCSubstitutionContext::Result); zaks.anna wrote: >

r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

2015-09-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 15 19:55:50 2015 New Revision: 247765 URL: http://llvm.org/viewvc/llvm-project?rev=247765=rev Log: [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros. Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

2015-09-15 Thread Richard Trieu via cfe-commits
rtrieu added inline comments. Comment at: include/clang/Basic/SourceManager.h:333 @@ -332,2 +332,3 @@ + bool isMacroBodyExpansion() const { Remove unrelated whitespace change. Comment at: include/clang/Basic/SourceManager.h:1155-1164 @@

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
chapuni added a subscriber: chapuni. Comment at: lib/CodeGen/CGClass.cpp:1756 @@ +1755,3 @@ + class SanitizeDtorVTable final : public EHScopeStack::Cleanup { +const CXXDestructorDecl *Dtor; + It causes a warning in -Asserts. [-Wunused-private-field]

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

2015-09-15 Thread Akira Hatanaka via cfe-commits
ahatanak added inline comments. Comment at: include/clang/Basic/Attr.td:894 @@ -893,1 +893,3 @@ +def DisableTailCalls : InheritableAttr { + let Spellings = [GNU<"disable_tail_calls">, aaron.ballman wrote: > Pardon me if this is obvious, but -- are there times

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

2015-09-15 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 34872. ahatanak added a comment. Sorry for the delay in my response. I had discussions with the users who requested this feature and it turns out they were asking for two different kinds of attributes. They are both needed to disable tail call

Re: r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

2015-09-15 Thread Richard Smith via cfe-commits
On Sep 15, 2015 6:28 PM, "Sean Silva" wrote: > > > > On Tue, Sep 15, 2015 at 5:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: >> >> Author: rsmith >> Date: Tue Sep 15 19:55:50 2015 >> New Revision: 247765 >> >> URL:

[PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Artem Belevich via cfe-commits
tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. * Only the last of the --cuda-host-only/--cuda-device-only options has effect. * Added test cases. * Fixed printing of empty action lists for -ccc-print-phases http://reviews.llvm.org/D12892 Files:

Re: [PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Sounds good. Thanks! http://reviews.llvm.org/D12893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yuck. No better ideas off the top of my head other than diagnosing and erroring though. (Is that a possibility? :) -eric http://reviews.llvm.org/D12892

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Artem Belevich via cfe-commits
tra added a comment. In http://reviews.llvm.org/D12892#246699, @echristo wrote: > Yuck. No better ideas off the top of my head other than diagnosing and > erroring though. > > (Is that a possibility? :) I need to be able to override preceding options, so no error is intentional.

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Sure. Seems reasonable. Thanks! -eric http://reviews.llvm.org/D12892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247761 - clang/test/CodeGenCXX/exceptions-cxx-new.cpp: Don't assume the label "entry:".

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Sep 15 19:33:59 2015 New Revision: 247761 URL: http://llvm.org/viewvc/llvm-project?rev=247761=rev Log: clang/test/CodeGenCXX/exceptions-cxx-new.cpp: Don't assume the label "entry:". Seems it would be redundant. Modified:

Re: r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

2015-09-15 Thread Sean Silva via cfe-commits
On Tue, Sep 15, 2015 at 5:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Sep 15 19:55:50 2015 > New Revision: 247765 > > URL: http://llvm.org/viewvc/llvm-project?rev=247765=rev > Log: > [modules] Fix a corner case in the macro override

r247743 - Try to appease the build bots

2015-09-15 Thread David Majnemer via cfe-commits
Author: majnemer Date: Tue Sep 15 18:34:59 2015 New Revision: 247743 URL: http://llvm.org/viewvc/llvm-project?rev=247743=rev Log: Try to appease the build bots Modified: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp Modified: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp URL:

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

2015-09-15 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Oops, forgot to hit "Submit" yesterday. Sorry for the delay. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:28 @@ +27,3 @@ + +AST_MATCHER(QualType, isExpensiveToCopy) { + // We can't reason about dependent types. Ignore them.

r247767 - [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well.

2015-09-15 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Tue Sep 15 20:52:32 2015 New Revision: 247767 URL: http://llvm.org/viewvc/llvm-project?rev=247767=rev Log: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well. Move the logic looking for additional checkers in the

Re: [PATCH] D12891: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well.

2015-09-15 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247767: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12891?vs=34853=34864#toc Repository:

r247739 - [Static Analyzer] Added an XFAIL test for inlining when the type inference involves generic types.

2015-09-15 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Tue Sep 15 18:14:01 2015 New Revision: 247739 URL: http://llvm.org/viewvc/llvm-project?rev=247739=rev Log: [Static Analyzer] Added an XFAIL test for inlining when the type inference involves generic types. Added: cfe/trunk/test/Analysis/DynamicTypePropagation.m Added:

[PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

2015-09-15 Thread Artem Belevich via cfe-commits
tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. Paves the way for the upcoming patch where host-side compilation will need to know device-side triple. http://reviews.llvm.org/D12893 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp

[PATCH] D12895: Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.

2015-09-15 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: mclow.lists. thakis added a subscriber: cfe-commits. I wanted a demangler that can demangle both Itanium-style and Microsoft-style mangled symbols, and that runs on all of Windows, Linux, and Mac OS X. I used libcxxabi's cxa_demangle for

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao updated the summary for this revision. sfantao updated this revision to Diff 34870. sfantao added a comment. Rebase with the last changes in http://reviews.llvm.org/D12871. http://reviews.llvm.org/D12262 Files: include/clang/Basic/OpenMPKinds.h include/clang/Sema/Sema.h

Re: [PATCH] D12889: [Static Analyzer] Generics Checker: When an ObjC method returns a specialized object, track it properly.

2015-09-15 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:672 @@ +671,3 @@ + + if (IsDeclaredAsInstanceType) +return SelfType; If you swap this 'if' with the 'if' above, you do not need to check for

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-15 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34851. nmusgrave added a comment. - Remove commented-out block. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index:

[PATCH] D12891: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well.

2015-09-15 Thread Devin Coughlin via cfe-commits
dcoughlin created this revision. dcoughlin added reviewers: xazax.hun, zaks.anna. dcoughlin added a subscriber: cfe-commits. Move the logic looking for additional checkers in the SA_ADDITIONAL_CHECKERS environmental variable from SATestBuild's main() to runScanBuild(). This allows SATestAdd.py

r247723 - Emiting llvm.invariant.group.barrier when dynamic type changes

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 16:46:47 2015 New Revision: 247723 URL: http://llvm.org/viewvc/llvm-project?rev=247723=rev Log: Emiting llvm.invariant.group.barrier when dynamic type changes For more goto: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.html

r247725 - Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 16:46:55 2015 New Revision: 247725 URL: http://llvm.org/viewvc/llvm-project?rev=247725=rev Log: Decorating vptr load & stores with !invariant.group Adding !invariant.group to vptr load/stores for devirtualization purposes. For more goto:

r247726 - [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Tue Sep 15 16:52:42 2015 New Revision: 247726 URL: http://llvm.org/viewvc/llvm-project?rev=247726=rev Log: [CMake] Add cache scripts for Apple-style clang builds. Summary: These CMake cache scripts are my first pass at replicating Apple's packaging logic from autoconf.

[libcxx] r247704 - Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated doesn't change the fact that we have to test it.

2015-09-15 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Sep 15 12:12:49 2015 New Revision: 247704 URL: http://llvm.org/viewvc/llvm-project?rev=247704=rev Log: Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated doesn't change the fact that we have to test it. Modified:

Re: recordDecl() AST matcher

2015-09-15 Thread Richard Smith via cfe-commits
On Mon, Sep 14, 2015 at 2:41 PM, Manuel Klimek wrote: > > On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman > wrote: > >> On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote: >> > >> > >> > On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

2015-09-15 Thread Ismail Pazarbasi via cfe-commits
ismailp added a comment. I don't have ubigraph installed either. The purpose of the test isn't to check as to whether we can generate a conforming/sensible ubigraph output, but to ensure that this tiny patch works and clang doesn't crash. So, I'd keep it. But if you are worried about

r247706 - [OPENMP] Emit an additional note during analysis of 'if' clause.

2015-09-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Sep 15 12:23:56 2015 New Revision: 247706 URL: http://llvm.org/viewvc/llvm-project?rev=247706=rev Log: [OPENMP] Emit an additional note during analysis of 'if' clause. Patch adds emission of additional note for 'if' clauses with name modifiers in case if 'if' clause

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Interesting. I'm down with putting this in - would it make more sense to put this alongside the buildit bits in the llvm/utils repo? -eric http://reviews.llvm.org/D12817

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Chris Bieneman via cfe-commits
beanz added a comment. I had considered putting it in the LLVM repo, but this stuff actually works on standalone clang builds too, so I felt it might be better here. -Chris http://reviews.llvm.org/D12817 ___ cfe-commits mailing list

r247712 - Rebase tests after LLVM r247707.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 13:49:51 2015 New Revision: 247712 URL: http://llvm.org/viewvc/llvm-project?rev=247712=rev Log: Rebase tests after LLVM r247707. Modified: cfe/trunk/test/CodeGenCXX/init-invariant.cpp cfe/trunk/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp

r247714 - [modules] Make sure we make hidden UsingShadowDecls visible to redeclaration

2015-09-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 15 13:51:56 2015 New Revision: 247714 URL: http://llvm.org/viewvc/llvm-project?rev=247714=rev Log: [modules] Make sure we make hidden UsingShadowDecls visible to redeclaration lookup for the UsingShadowDecls themselves. Modified:

Re: [PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Alexey Bader via cfe-commits
bader added a comment. In http://reviews.llvm.org/D12855#246004, @pekka.jaaskelainen wrote: > The patch seems straightforward enough. BTW does someone know if anyone has > worked on the 'pipe' qualifier? I'm currently supporting Intel's implementation of 'pipe' qualifier and I'd like to

r247667 - Make clang/test/CodeGen/catch-undef-behavior.c* capable of -Asserts with "opt -instnamer".

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Sep 15 04:50:24 2015 New Revision: 247667 URL: http://llvm.org/viewvc/llvm-project?rev=247667=rev Log: Make clang/test/CodeGen/catch-undef-behavior.c* capable of -Asserts with "opt -instnamer". It reverts r231717. Modified:

r247696 - Mention that libcxx is required to build Compiler-RT tests on OS X.

2015-09-15 Thread Yury Gribov via cfe-commits
Author: ygribov Date: Tue Sep 15 10:05:47 2015 New Revision: 247696 URL: http://llvm.org/viewvc/llvm-project?rev=247696=rev Log: Mention that libcxx is required to build Compiler-RT tests on OS X. Modified: cfe/trunk/www/get_started.html Modified: cfe/trunk/www/get_started.html URL:

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

2015-09-15 Thread Jordan Rose via cfe-commits
jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Thanks for all the changes. This looks good to me! (And good catch for the constant expression case.) http://reviews.llvm.org/D5102

r247702 - Revert r247692: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 11:17:27 2015 New Revision: 247702 URL: http://llvm.org/viewvc/llvm-project?rev=247702=rev Log: Revert r247692: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC. Eric has replied and has demanded the patch be reverted. Modified:

r247676 - [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Alexey Bader via cfe-commits
Author: bader Date: Tue Sep 15 06:18:52 2015 New Revision: 247676 URL: http://llvm.org/viewvc/llvm-project?rev=247676=rev Log: [OpenCL] Add new types for OpenCL 2.0. Patch by Pedro Ferreira. Reviewers: pekka.jaaskelainen Differential Revision: http://reviews.llvm.org/D12855 Modified:

Re: r247618 - C11 _Bool bitfield diagnostic

2015-09-15 Thread Nico Weber via cfe-commits
With this patch, we warn on `bool a : 4;`, yet we don't warn on `bool b` (which has 8 bits storage, 1 bit value). Warning on `bool b` is silly of course, but why is warning on `bool a : 4` useful? That's like 50% more storage efficient than `bool b` ;-) It's possible that this is a good warning

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

2015-09-15 Thread Zhengkai Wu via cfe-commits
zhengkai added a comment. In http://reviews.llvm.org/D12379#245892, @rtrieu wrote: > In http://reviews.llvm.org/D12379#245868, @zhengkai wrote: > > > In http://reviews.llvm.org/D12379#245861, @rtrieu wrote: > > > > > In http://reviews.llvm.org/D12379#245850, @zhengkai wrote: > > > > > > > In

Re: [PATCH] D12835: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-15 Thread Quentin Colombet via cfe-commits
qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM. Thanks, -Quentin Repository: rL LLVM http://reviews.llvm.org/D12835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

2015-09-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added reviewers: rtrieu, rsmith. aaron.ballman added a comment. There is a -Wpessimizing-move frontend warning that Richard added not too long ago, which tells the user to remove calls to std::move() because they pessimize the code. The new functionality you are looking to add is

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Eric Christopher via cfe-commits
Ah sure. Make it so then. On Tue, Sep 15, 2015, 1:04 PM Chris Bieneman wrote: > beanz added a comment. > > Standalone as in using the base system's LLVM installation. So you don't > actually have to have an llvm checkout. > > There's goop in the root clang CMakeLists file to

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Piotr Padlewski via cfe-commits
Prazek marked an inline comment as done. Comment at: lib/CodeGen/CodeGenModule.cpp:3859 @@ -3848,4 +3858,3 @@ } else { -InternalId = llvm::MDNode::getDistinct(getLLVMContext(), - llvm::ArrayRef()); +InternalId =

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao abandoned this revision. sfantao added a comment. Closing revision. It has been replaced by http://reviews.llvm.org/D12871 has suggested by John. Thanks! Samuel http://reviews.llvm.org/D11361 ___ cfe-commits mailing list

Re: [PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

2015-09-15 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D12422#235509, @majnemer wrote: > We should probably do something about lambdas, they can't be imported or > exported but this can be done in a follow up patch. Follow-up in r247718. Repository: rL LLVM http://reviews.llvm.org/D12422

r247718 - MS ABI: Don't allow dllexport/import on lambdas

2015-09-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Sep 15 16:05:30 2015 New Revision: 247718 URL: http://llvm.org/viewvc/llvm-project?rev=247718=rev Log: MS ABI: Don't allow dllexport/import on lambdas This is to follow up on David's comment in http://reviews.llvm.org/D12422#235509 Modified:

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Richard Smith via cfe-commits
rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CodeGenModule.cpp:3859 @@ -3848,4 +3858,3 @@ } else { -InternalId = llvm::MDNode::getDistinct(getLLVMContext(), -

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Piotr Padlewski via cfe-commits
Prazek updated the summary for this revision. Prazek updated this revision to Diff 34833. http://reviews.llvm.org/D12026 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Alexey Bader via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247676: [OpenCL] Add new types for OpenCL 2.0. (authored by bader). Changed prior to commit: http://reviews.llvm.org/D12855?vs=34709=34796#toc Repository: rL LLVM http://reviews.llvm.org/D12855

[clang-tools-extra] r247689 - Remove garbage. The issue was fixed in r246856.

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Sep 15 09:01:09 2015 New Revision: 247689 URL: http://llvm.org/viewvc/llvm-project?rev=247689=rev Log: Remove garbage. The issue was fixed in r246856. Modified: clang-tools-extra/trunk/test/clang-tidy/llvm-include-order.cpp Modified:

r247692 - Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 09:08:28 2015 New Revision: 247692 URL: http://llvm.org/viewvc/llvm-project?rev=247692=rev Log: Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC. Summary: This is the first patch in the series to migrate Triple's

r247683 - Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 08:17:40 2015 New Revision: 247683 URL: http://llvm.org/viewvc/llvm-project?rev=247683=rev Log: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC. Summary: This is the first patch in the series to migrate Triple's (which are ambiguous) to

[clang-tools-extra] r247682 - [clang-tidy] Update check name in the comment. NFC.

2015-09-15 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Sep 15 08:13:48 2015 New Revision: 247682 URL: http://llvm.org/viewvc/llvm-project?rev=247682=rev Log: [clang-tidy] Update check name in the comment. NFC. Modified: clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py Modified:

r247668 - Doxygen fix InitializeBuiltins -> initializeBuiltins

2015-09-15 Thread Ismail Donmez via cfe-commits
Author: ismail Date: Tue Sep 15 04:53:14 2015 New Revision: 247668 URL: http://llvm.org/viewvc/llvm-project?rev=247668=rev Log: Doxygen fix InitializeBuiltins -> initializeBuiltins Modified: cfe/trunk/lib/Basic/Builtins.cpp Modified: cfe/trunk/lib/Basic/Builtins.cpp URL:

[libcxx] r247695 - Change initialization of mbstate_t objects in tests from '= {0}' to '= {}', which does the same thing, w/o having clang and gcc warn with -Wall.

2015-09-15 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Sep 15 09:46:03 2015 New Revision: 247695 URL: http://llvm.org/viewvc/llvm-project?rev=247695=rev Log: Change initialization of mbstate_t objects in tests from '= {0}' to '= {}', which does the same thing, w/o having clang and gcc warn with -Wall. Modified: