Re: [PATCH] D12664: Fixed comparison.

2015-09-15 Thread James Touton via cfe-commits
jtouton added a comment. Can I get this reviewed? http://reviews.llvm.org/D12664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247778 - CGClass.cpp: Fix a warning in -Asserts. [-Wunused-private-field]

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Sep 16 01:26:56 2015 New Revision: 247778 URL: http://llvm.org/viewvc/llvm-project?rev=247778&view=rev Log: CGClass.cpp: Fix a warning in -Asserts. [-Wunused-private-field] Modified: cfe/trunk/lib/CodeGen/CGClass.cpp Modified: cfe/trunk/lib/CodeGen/CGClass.cpp URL:

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

2015-09-15 Thread Akira Hatanaka via cfe-commits
ahatanak added inline comments. Comment at: include/clang/Basic/Attr.td:894 @@ -893,1 +893,3 @@ +def DisableTailCalls : InheritableAttr { + let Spellings = [GNU<"disable_tail_calls">, aaron.ballman wrote: > Pardon me if this is obvious, but -- are there times w

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

2015-09-15 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 34872. ahatanak added a comment. Sorry for the delay in my response. I had discussions with the users who requested this feature and it turns out they were asking for two different kinds of attributes. They are both needed to disable tail call optimization

Re: r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

2015-09-15 Thread Richard Smith via cfe-commits
On Sep 15, 2015 6:28 PM, "Sean Silva" wrote: > > > > On Tue, Sep 15, 2015 at 5:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: >> >> Author: rsmith >> Date: Tue Sep 15 19:55:50 2015 >> New Revision: 247765 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=247765&view=rev

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao updated the summary for this revision. sfantao updated this revision to Diff 34870. sfantao added a comment. Rebase with the last changes in http://reviews.llvm.org/D12871. http://reviews.llvm.org/D12262 Files: include/clang/Basic/OpenMPKinds.h include/clang/Sema/Sema.h lib/Basic/

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 34869. sfantao added a comment. Update code to use implicit parameters for the captured variables using `GenerateOpenMPCapturedStmtFunction`, similarly to what is done to other directives. `UseOnlyReferences` boolean was added to `GenerateOpenMPCapturedStm

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
chapuni added a subscriber: chapuni. Comment at: lib/CodeGen/CGClass.cpp:1756 @@ +1755,3 @@ + class SanitizeDtorVTable final : public EHScopeStack::Cleanup { +const CXXDestructorDecl *Dtor; + It causes a warning in -Asserts. [-Wunused-private-field] http://r

Re: [PATCH] D12891: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well.

2015-09-15 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247767: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can… (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D12891?vs=34853&id=34864#toc Repository:

r247767 - [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well.

2015-09-15 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Tue Sep 15 20:52:32 2015 New Revision: 247767 URL: http://llvm.org/viewvc/llvm-project?rev=247767&view=rev Log: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well. Move the logic looking for additional checkers in the SA_ADDITIONA

[PATCH] D12895: Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.

2015-09-15 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: mclow.lists. thakis added a subscriber: cfe-commits. I wanted a demangler that can demangle both Itanium-style and Microsoft-style mangled symbols, and that runs on all of Windows, Linux, and Mac OS X. I used libcxxabi's cxa_demangle for the

Re: r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

2015-09-15 Thread Sean Silva via cfe-commits
On Tue, Sep 15, 2015 at 5:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Sep 15 19:55:50 2015 > New Revision: 247765 > > URL: http://llvm.org/viewvc/llvm-project?rev=247765&view=rev > Log: > [modules] Fix a corner case in the macro override r

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

2015-09-15 Thread Richard Trieu via cfe-commits
rtrieu added inline comments. Comment at: include/clang/Basic/SourceManager.h:333 @@ -332,2 +332,3 @@ + bool isMacroBodyExpansion() const { Remove unrelated whitespace change. Comment at: include/clang/Basic/SourceManager.h:1155-1164 @@ -1

r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

2015-09-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 15 19:55:50 2015 New Revision: 247765 URL: http://llvm.org/viewvc/llvm-project?rev=247765&view=rev Log: [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros. Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp cf

Re: r247618 - C11 _Bool bitfield diagnostic

2015-09-15 Thread Richard Smith via cfe-commits
On Tue, Sep 15, 2015 at 12:38 PM, Nico Weber wrote: > With this patch, we warn on `bool a : 4;`, yet we don't warn on `bool b` > (which has 8 bits storage, 1 bit value). Warning on `bool b` is silly of > course, but why is warning on `bool a : 4` useful? That's like 50% more > storage efficient t

Re: [PATCH] D12889: [Static Analyzer] Generics Checker: When an ObjC method returns a specialized object, track it properly.

2015-09-15 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:680 @@ +679,3 @@ +return nullptr; + + QualType ResultType = Method->getReturnType().substObjCTypeArgs( From above: QualType StaticResultType = Method->getRetu

r247762 - Implementation and testing for poisoning vtable

2015-09-15 Thread Naomi Musgrave via cfe-commits
Author: nmusgrave Date: Tue Sep 15 19:38:22 2015 New Revision: 247762 URL: http://llvm.org/viewvc/llvm-project?rev=247762&view=rev Log: Implementation and testing for poisoning vtable ptr in dtor. Summary: After destruction, invocation of virtual functions prevented by poisoning vtable pointer.

Re: [PATCH] D12889: [Static Analyzer] Generics Checker: When an ObjC method returns a specialized object, track it properly.

2015-09-15 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:675 @@ +674,3 @@ + + QualType ResultType = Method->getReturnType().substObjCTypeArgs( + C, TypeArgs, ObjCSubstitutionContext::Result); zaks.anna wrote: > Coul

r247761 - clang/test/CodeGenCXX/exceptions-cxx-new.cpp: Don't assume the label "entry:".

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Sep 15 19:33:59 2015 New Revision: 247761 URL: http://llvm.org/viewvc/llvm-project?rev=247761&view=rev Log: clang/test/CodeGenCXX/exceptions-cxx-new.cpp: Don't assume the label "entry:". Seems it would be redundant. Modified: cfe/trunk/test/CodeGenCXX/exceptions-cxx

Re: [PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Sounds good. Thanks! http://reviews.llvm.org/D12893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

2015-09-15 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Oops, forgot to hit "Submit" yesterday. Sorry for the delay. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:28 @@ +27,3 @@ + +AST_MATCHER(QualType, isExpensiveToCopy) { + // We can't reason about dependent types. Ignore them. T

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Sure. Seems reasonable. Thanks! -eric http://reviews.llvm.org/D12892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Artem Belevich via cfe-commits
tra added a comment. In http://reviews.llvm.org/D12892#246699, @echristo wrote: > Yuck. No better ideas off the top of my head other than diagnosing and > erroring though. > > (Is that a possibility? :) I need to be able to override preceding options, so no error is intentional. http://revie

Re: [PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Commit message could use some more elaborating on why you'll need to know this information. Just a bit as the main commit will have a lot of that information. Thanks! -eric http://revie

[PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

2015-09-15 Thread Artem Belevich via cfe-commits
tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. Paves the way for the upcoming patch where host-side compilation will need to know device-side triple. http://reviews.llvm.org/D12893 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yuck. No better ideas off the top of my head other than diagnosing and erroring though. (Is that a possibility? :) -eric http://reviews.llvm.org/D12892 __

[PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

2015-09-15 Thread Artem Belevich via cfe-commits
tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. * Only the last of the --cuda-host-only/--cuda-device-only options has effect. * Added test cases. * Fixed printing of empty action lists for -ccc-print-phases http://reviews.llvm.org/D12892 Files:

[PATCH] D12891: [analyzer] SATestBuild.py: Move additional checkers logic so SATestAdd.py can use it as well.

2015-09-15 Thread Devin Coughlin via cfe-commits
dcoughlin created this revision. dcoughlin added reviewers: xazax.hun, zaks.anna. dcoughlin added a subscriber: cfe-commits. Move the logic looking for additional checkers in the SA_ADDITIONAL_CHECKERS environmental variable from SATestBuild's main() to runScanBuild(). This allows SATestAdd.py t

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-15 Thread Evgeniy Stepanov via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

r247752 - Remove accidental superfluous newline added in r247750.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 18:51:08 2015 New Revision: 247752 URL: http://llvm.org/viewvc/llvm-project?rev=247752&view=rev Log: Remove accidental superfluous newline added in r247750. Modified: cfe/trunk/unittests/Format/FormatTestJava.cpp Modified: cfe/trunk/unittests/Format/FormatTestJa

r247750 - clang-format: In Java, `assert` is followed by an expression.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 18:48:17 2015 New Revision: 247750 URL: http://llvm.org/viewvc/llvm-project?rev=247750&view=rev Log: clang-format: In Java, `assert` is followed by an expression. Before: assert a&& b; Now:assert a && b; Modified: cfe/trunk/lib/Format/FormatToken.h cfe/t

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-15 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34851. nmusgrave added a comment. - Remove commented-out block. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index: test/CodeGenCXX/sanitize-d

r247743 - Try to appease the build bots

2015-09-15 Thread David Majnemer via cfe-commits
Author: majnemer Date: Tue Sep 15 18:34:59 2015 New Revision: 247743 URL: http://llvm.org/viewvc/llvm-project?rev=247743&view=rev Log: Try to appease the build bots Modified: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp Modified: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp URL: htt

r247742 - [MS ABI] Add a C++ test for -fnew-ms-eh

2015-09-15 Thread David Majnemer via cfe-commits
Author: majnemer Date: Tue Sep 15 18:30:42 2015 New Revision: 247742 URL: http://llvm.org/viewvc/llvm-project?rev=247742&view=rev Log: [MS ABI] Add a C++ test for -fnew-ms-eh Added: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp Added: cfe/trunk/test/CodeGenCXX/exceptions-cxx-new.cpp URL:

r247740 - Don't crash when passing &@selector to a _Nonnull parameter. Fixes PR24774.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 18:17:17 2015 New Revision: 247740 URL: http://llvm.org/viewvc/llvm-project?rev=247740&view=rev Log: Don't crash when passing &@selector to a _Nonnull parameter. Fixes PR24774. The root cause here is that ObjCSelectorExpr is an rvalue, yet it can have its address tak

r247739 - [Static Analyzer] Added an XFAIL test for inlining when the type inference involves generic types.

2015-09-15 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Tue Sep 15 18:14:01 2015 New Revision: 247739 URL: http://llvm.org/viewvc/llvm-project?rev=247739&view=rev Log: [Static Analyzer] Added an XFAIL test for inlining when the type inference involves generic types. Added: cfe/trunk/test/Analysis/DynamicTypePropagation.m Adde

r247733 - invariant.group-for-vptrs test fix

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 18:04:47 2015 New Revision: 247733 URL: http://llvm.org/viewvc/llvm-project?rev=247733&view=rev Log: invariant.group-for-vptrs test fix Modified: cfe/trunk/test/CodeGenCXX/invariant.group-for-vptrs.cpp Modified: cfe/trunk/test/CodeGenCXX/invariant.group-for-vp

Re: [PATCH] D12889: [Static Analyzer] Generics Checker: When an ObjC method returns a specialized object, track it properly.

2015-09-15 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:672 @@ +671,3 @@ + + if (IsDeclaredAsInstanceType) +return SelfType; If you swap this 'if' with the 'if' above, you do not need to check for IsDeclaredAsInsta

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247726: [CMake] Add cache scripts for Apple-style clang builds. (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D12817?vs=34586&id=34842#toc Repository: rL LLVM http://revi

r247726 - [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Tue Sep 15 16:52:42 2015 New Revision: 247726 URL: http://llvm.org/viewvc/llvm-project?rev=247726&view=rev Log: [CMake] Add cache scripts for Apple-style clang builds. Summary: These CMake cache scripts are my first pass at replicating Apple's packaging logic from autocon

r247723 - Emiting llvm.invariant.group.barrier when dynamic type changes

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 16:46:47 2015 New Revision: 247723 URL: http://llvm.org/viewvc/llvm-project?rev=247723&view=rev Log: Emiting llvm.invariant.group.barrier when dynamic type changes For more goto: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.html http://reviews.llvm.org

r247724 - Added llvm.module flag for strict vtable pointers

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 16:46:50 2015 New Revision: 247724 URL: http://llvm.org/viewvc/llvm-project?rev=247724&view=rev Log: Added llvm.module flag for strict vtable pointers It is dangerous to do LTO on code with strict-vtable-pointers, because one module has invariant.group.barriers, an

r247725 - Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Tue Sep 15 16:46:55 2015 New Revision: 247725 URL: http://llvm.org/viewvc/llvm-project?rev=247725&view=rev Log: Decorating vptr load & stores with !invariant.group Adding !invariant.group to vptr load/stores for devirtualization purposes. For more goto: http://lists.llvm.org/

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

2015-09-15 Thread Piotr Padlewski via cfe-commits
Prazek accepted this revision. Prazek added a reviewer: Prazek. Prazek added a comment. This revision is now accepted and ready to land. Accept to close http://reviews.llvm.org/D12312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

2015-09-15 Thread Piotr Padlewski via cfe-commits
Prazek marked an inline comment as done. Prazek added a comment. http://reviews.llvm.org/D12312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-09-15 Thread Samuel Antao via cfe-commits
sfantao abandoned this revision. sfantao added a comment. Closing revision. It has been replaced by http://reviews.llvm.org/D12871 has suggested by John. Thanks! Samuel http://reviews.llvm.org/D11361 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Piotr Padlewski via cfe-commits
Prazek marked an inline comment as done. Comment at: lib/CodeGen/CodeGenModule.cpp:3859 @@ -3848,4 +3858,3 @@ } else { -InternalId = llvm::MDNode::getDistinct(getLLVMContext(), - llvm::ArrayRef()); +InternalId = llvm::MDNode::ge

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Richard Smith via cfe-commits
rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CodeGenModule.cpp:3859 @@ -3848,4 +3858,3 @@ } else { -InternalId = llvm::MDNode::getDistinct(getLLVMContext(), - llvm::ArrayRef

r247718 - MS ABI: Don't allow dllexport/import on lambdas

2015-09-15 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Sep 15 16:05:30 2015 New Revision: 247718 URL: http://llvm.org/viewvc/llvm-project?rev=247718&view=rev Log: MS ABI: Don't allow dllexport/import on lambdas This is to follow up on David's comment in http://reviews.llvm.org/D12422#235509 Modified: cfe/trunk/include/clan

Re: [PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

2015-09-15 Thread Hans Wennborg via cfe-commits
hans added a comment. In http://reviews.llvm.org/D12422#235509, @majnemer wrote: > We should probably do something about lambdas, they can't be imported or > exported but this can be done in a follow up patch. Follow-up in r247718. Repository: rL LLVM http://reviews.llvm.org/D12422 ___

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

2015-09-15 Thread Piotr Padlewski via cfe-commits
Prazek updated the summary for this revision. Prazek updated this revision to Diff 34833. http://reviews.llvm.org/D12026 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.cpp

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

2015-09-15 Thread Zhengkai Wu via cfe-commits
zhengkai added a comment. In http://reviews.llvm.org/D12379#245892, @rtrieu wrote: > In http://reviews.llvm.org/D12379#245868, @zhengkai wrote: > > > In http://reviews.llvm.org/D12379#245861, @rtrieu wrote: > > > > > In http://reviews.llvm.org/D12379#245850, @zhengkai wrote: > > > > > > > In http

Re: [PATCH] D12835: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-15 Thread Quentin Colombet via cfe-commits
qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM. Thanks, -Quentin Repository: rL LLVM http://reviews.llvm.org/D12835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

r247717 - Add test coverage for @encode(SEL); completely untested until now.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 15:05:20 2015 New Revision: 247717 URL: http://llvm.org/viewvc/llvm-project?rev=247717&view=rev Log: Add test coverage for @encode(SEL); completely untested until now. Modified: cfe/trunk/test/CodeGenObjC/encode-test.m Modified: cfe/trunk/test/CodeGenObjC/encode

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Eric Christopher via cfe-commits
Ah sure. Make it so then. On Tue, Sep 15, 2015, 1:04 PM Chris Bieneman wrote: > beanz added a comment. > > Standalone as in using the base system's LLVM installation. So you don't > actually have to have an llvm checkout. > > There's goop in the root clang CMakeLists file to support building cla

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Chris Bieneman via cfe-commits
beanz added a comment. Standalone as in using the base system's LLVM installation. So you don't actually have to have an llvm checkout. There's goop in the root clang CMakeLists file to support building clang as the top-level CMake tool, and all this stuff should work in that context as well.

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo added a comment. Standalone as "clang that only sorta depends on llvm"? http://reviews.llvm.org/D12817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

2015-09-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added reviewers: rtrieu, rsmith. aaron.ballman added a comment. There is a -Wpessimizing-move frontend warning that Richard added not too long ago, which tells the user to remove calls to std::move() because they pessimize the code. The new functionality you are looking to add is b

Re: [PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

2015-09-15 Thread Simone via cfe-commits
simoatze updated this revision to Diff 34830. simoatze added a comment. Ignore previous update. http://reviews.llvm.org/D12840 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp === --- lib/Driver/ToolChains.cpp +

Re: r247618 - C11 _Bool bitfield diagnostic

2015-09-15 Thread Nico Weber via cfe-commits
With this patch, we warn on `bool a : 4;`, yet we don't warn on `bool b` (which has 8 bits storage, 1 bit value). Warning on `bool b` is silly of course, but why is warning on `bool a : 4` useful? That's like 50% more storage efficient than `bool b` ;-) It's possible that this is a good warning fo

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

2015-09-15 Thread Zhengkai Wu via cfe-commits
zhengkai updated this revision to Diff 34826. zhengkai added a comment. Use the rtrieu's method to re write the implementation of SourceManager. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test

Re: [PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

2015-09-15 Thread Simone via cfe-commits
simoatze updated this revision to Diff 34825. simoatze added a comment. Added more context. http://reviews.llvm.org/D12840 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp === --- lib/Driver/ToolChains.cpp +++ l

Re: [PATCH] D11619: [OPENMP] allow static local variable on data-sharing attribute clause

2015-09-15 Thread Kelvin Li via cfe-commits
kkwli0 added a comment. Committed revision 247715. http://reviews.llvm.org/D11619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r247714 - [modules] Make sure we make hidden UsingShadowDecls visible to redeclaration

2015-09-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 15 13:51:56 2015 New Revision: 247714 URL: http://llvm.org/viewvc/llvm-project?rev=247714&view=rev Log: [modules] Make sure we make hidden UsingShadowDecls visible to redeclaration lookup for the UsingShadowDecls themselves. Modified: cfe/trunk/include/clang/Sema/

Re: [PATCH] D12712: Implementation and testing for poisoning vtable ptr in dtor.

2015-09-15 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34822. nmusgrave added a comment. - Re-checking testing for poisoning vtable. http://reviews.llvm.org/D12712 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-derived-class.cpp test/CodeGenCXX/sanitize-dtor-vtable.cpp Index: test/CodeGen

r247712 - Rebase tests after LLVM r247707.

2015-09-15 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 15 13:49:51 2015 New Revision: 247712 URL: http://llvm.org/viewvc/llvm-project?rev=247712&view=rev Log: Rebase tests after LLVM r247707. Modified: cfe/trunk/test/CodeGenCXX/init-invariant.cpp cfe/trunk/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp cfe/trunk

Re: recordDecl() AST matcher

2015-09-15 Thread Richard Smith via cfe-commits
On Mon, Sep 14, 2015 at 2:41 PM, Manuel Klimek wrote: > > On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman > wrote: > >> On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote: >> > >> > >> > On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman >> > wrote: >> >> >> >> On Mon, Sep 14, 2015 at 2:45 PM, Dani

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Chris Bieneman via cfe-commits
beanz added a comment. I had considered putting it in the LLVM repo, but this stuff actually works on standalone clang builds too, so I felt it might be better here. -Chris http://reviews.llvm.org/D12817 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

2015-09-15 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Interesting. I'm down with putting this in - would it make more sense to put this alongside the buildit bits in the llvm/utils repo? -eric http://reviews.llvm.org/D12817 _

r247706 - [OPENMP] Emit an additional note during analysis of 'if' clause.

2015-09-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Sep 15 12:23:56 2015 New Revision: 247706 URL: http://llvm.org/viewvc/llvm-project?rev=247706&view=rev Log: [OPENMP] Emit an additional note during analysis of 'if' clause. Patch adds emission of additional note for 'if' clauses with name modifiers in case if 'if' clause

[libcxx] r247704 - Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated doesn't change the fact that we have to test it.

2015-09-15 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Sep 15 12:12:49 2015 New Revision: 247704 URL: http://llvm.org/viewvc/llvm-project?rev=247704&view=rev Log: Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated doesn't change the fact that we have to test it. Modified: libcxx/trunk/test/

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

2015-09-15 Thread Ismail Pazarbasi via cfe-commits
ismailp added a comment. I don't have ubigraph installed either. The purpose of the test isn't to check as to whether we can generate a conforming/sensible ubigraph output, but to ensure that this tiny patch works and clang doesn't crash. So, I'd keep it. But if you are worried about other/unkn

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

2015-09-15 Thread Jordan Rose via cfe-commits
jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Thanks for all the changes. This looks good to me! (And good catch for the constant expression case.) http://reviews.llvm.org/D5102 __

r247702 - Revert r247692: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 11:17:27 2015 New Revision: 247702 URL: http://llvm.org/viewvc/llvm-project?rev=247702&view=rev Log: Revert r247692: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC. Eric has replied and has demanded the patch be reverted. Modified:

Re: [clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

2015-09-15 Thread Aaron Ballman via cfe-commits
On Tue, Sep 15, 2015 at 11:31 AM, Alexander Kornienko wrote: > On Fri, Sep 11, 2015 at 3:30 PM, Aaron Ballman > wrote: >> >> On Fri, Sep 11, 2015 at 9:27 AM, Alexander Kornienko via cfe-commits >> wrote: >> > Thank you for the fix and sorry for breaking this again. I wonder what's >> > the >> >

Re: [clang-tools-extra] r247393 - clang-tidy/readability-inconsistent-declaration-parameter-name.cpp: Appease MS-incompatibility [-fno-delayed-template-parsing]

2015-09-15 Thread Alexander Kornienko via cfe-commits
On Fri, Sep 11, 2015 at 3:30 PM, Aaron Ballman wrote: > On Fri, Sep 11, 2015 at 9:27 AM, Alexander Kornienko via cfe-commits > wrote: > > Thank you for the fix and sorry for breaking this again. I wonder what's > the > > reason windows-targeting enables -fdelayed-template-parsing? > > Because th

r247696 - Mention that libcxx is required to build Compiler-RT tests on OS X.

2015-09-15 Thread Yury Gribov via cfe-commits
Author: ygribov Date: Tue Sep 15 10:05:47 2015 New Revision: 247696 URL: http://llvm.org/viewvc/llvm-project?rev=247696&view=rev Log: Mention that libcxx is required to build Compiler-RT tests on OS X. Modified: cfe/trunk/www/get_started.html Modified: cfe/trunk/www/get_started.html URL: ht

[libcxx] r247695 - Change initialization of mbstate_t objects in tests from '= {0}' to '= {}', which does the same thing, w/o having clang and gcc warn with -Wall.

2015-09-15 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Sep 15 09:46:03 2015 New Revision: 247695 URL: http://llvm.org/viewvc/llvm-project?rev=247695&view=rev Log: Change initialization of mbstate_t objects in tests from '= {0}' to '= {}', which does the same thing, w/o having clang and gcc warn with -Wall. Modified: li

r247693 - Silencing a -Wreturn-type warning; NFC.

2015-09-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Sep 15 09:11:32 2015 New Revision: 247693 URL: http://llvm.org/viewvc/llvm-project?rev=247693&view=rev Log: Silencing a -Wreturn-type warning; NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CheckerManager.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/Checke

r247692 - Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 09:08:28 2015 New Revision: 247692 URL: http://llvm.org/viewvc/llvm-project?rev=247692&view=rev Log: Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC. Summary: This is the first patch in the series to migrate Triple's (

[clang-tools-extra] r247689 - Remove garbage. The issue was fixed in r246856.

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Sep 15 09:01:09 2015 New Revision: 247689 URL: http://llvm.org/viewvc/llvm-project?rev=247689&view=rev Log: Remove garbage. The issue was fixed in r246856. Modified: clang-tools-extra/trunk/test/clang-tidy/llvm-include-order.cpp Modified: clang-tools-extra/trunk/tes

r247686 - Revert r247684 - Replace Triple with a new TargetTuple ...

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 08:46:21 2015 New Revision: 247686 URL: http://llvm.org/viewvc/llvm-project?rev=247686&view=rev Log: Revert r247684 - Replace Triple with a new TargetTuple ... LLDB needs to be updated in the same commit. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp c

r247683 - Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

2015-09-15 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Sep 15 08:17:40 2015 New Revision: 247683 URL: http://llvm.org/viewvc/llvm-project?rev=247683&view=rev Log: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC. Summary: This is the first patch in the series to migrate Triple's (which are ambiguous)

[clang-tools-extra] r247682 - [clang-tidy] Update check name in the comment. NFC.

2015-09-15 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Sep 15 08:13:48 2015 New Revision: 247682 URL: http://llvm.org/viewvc/llvm-project?rev=247682&view=rev Log: [clang-tidy] Update check name in the comment. NFC. Modified: clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py Modified: clang-tools-extra/trunk/clan

r247681 - [OPENMP] Emit __kmpc_cancel_barrier() and code for 'cancellation point' only if 'cancel' is found.

2015-09-15 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Sep 15 07:52:43 2015 New Revision: 247681 URL: http://llvm.org/viewvc/llvm-project?rev=247681&view=rev Log: [OPENMP] Emit __kmpc_cancel_barrier() and code for 'cancellation point' only if 'cancel' is found. Patch improves codegen for OpenMP constructs. If the OpenMP regi

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

2015-09-15 Thread Daniel Jasper via cfe-commits
djasper updated this revision to Diff 34800. djasper marked 4 inline comments as done. djasper added a comment. Addressed (most) comments http://reviews.llvm.org/D11240 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/Format/Format.cpp lib/Format/FormatT

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

2015-09-15 Thread Daniel Jasper via cfe-commits
djasper marked 8 inline comments as done. Comment at: lib/Format/Format.cpp:1653 @@ +1652,3 @@ +Code.substr(Prev, (Pos != StringRef::npos ? Pos : Code.size()) - Prev); +if (!Line.endswith("\\")) { + if (IncludeRegex.match(Line, &Matches)) { klimek

r247668 - Doxygen fix InitializeBuiltins -> initializeBuiltins

2015-09-15 Thread Ismail Donmez via cfe-commits
Author: ismail Date: Tue Sep 15 04:53:14 2015 New Revision: 247668 URL: http://llvm.org/viewvc/llvm-project?rev=247668&view=rev Log: Doxygen fix InitializeBuiltins -> initializeBuiltins Modified: cfe/trunk/lib/Basic/Builtins.cpp Modified: cfe/trunk/lib/Basic/Builtins.cpp URL: http://llvm.o

r247678 - Run clang-format to unify the switch statement style as suggest here: http://reviews.llvm.org/D12855#246073.

2015-09-15 Thread Alexey Bader via cfe-commits
Author: bader Date: Tue Sep 15 07:18:29 2015 New Revision: 247678 URL: http://llvm.org/viewvc/llvm-project?rev=247678&view=rev Log: Run clang-format to unify the switch statement style as suggest here: http://reviews.llvm.org/D12855#246073. NFC. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp

Re: [PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Alexey Bader via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247676: [OpenCL] Add new types for OpenCL 2.0. (authored by bader). Changed prior to commit: http://reviews.llvm.org/D12855?vs=34709&id=34796#toc Repository: rL LLVM http://reviews.llvm.org/D12855

r247676 - [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Alexey Bader via cfe-commits
Author: bader Date: Tue Sep 15 06:18:52 2015 New Revision: 247676 URL: http://llvm.org/viewvc/llvm-project?rev=247676&view=rev Log: [OpenCL] Add new types for OpenCL 2.0. Patch by Pedro Ferreira. Reviewers: pekka.jaaskelainen Differential Revision: http://reviews.llvm.org/D12855 Modified: cf

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

2015-09-15 Thread Xan López via cfe-commits
On Mon, Sep 14, 2015 at 07:24:11PM -0400, Rafael Espíndola wrote: > From the driver point of view, how does it know if it is targeting > illumos or solaris? Do they use different triples? At this point, they do not, se we can't. > > In any case, if there is interest in the future this patch can

Re: [PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Pekka Jääskeläinen via cfe-commits
pekka.jaaskelainen added a comment. We are interested in the pipe. I don't think it makes sense to increase the patch size by running the stylifier. Perhaps in an additional patch after this? http://reviews.llvm.org/D12855 ___ cfe-commits mailing

r247667 - Make clang/test/CodeGen/catch-undef-behavior.c* capable of -Asserts with "opt -instnamer".

2015-09-15 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Sep 15 04:50:24 2015 New Revision: 247667 URL: http://llvm.org/viewvc/llvm-project?rev=247667&view=rev Log: Make clang/test/CodeGen/catch-undef-behavior.c* capable of -Asserts with "opt -instnamer". It reverts r231717. Modified: cfe/trunk/test/CodeGen/catch-undef-b

Re: [PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

2015-09-15 Thread Alexey Bader via cfe-commits
bader added a comment. In http://reviews.llvm.org/D12855#246004, @pekka.jaaskelainen wrote: > The patch seems straightforward enough. BTW does someone know if anyone has > worked on the 'pipe' qualifier? I'm currently supporting Intel's implementation of 'pipe' qualifier and I'd like to contr