Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki updated this revision to Diff 35482. danielmarjamaki marked 9 inline comments as done. danielmarjamaki added a comment. With the previous patch there was much noise when building Clang. I have fixed many false positives with improved handling of C++ code. However I have not been

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson added a comment. Thank you for your comments. @zaks.anna wrote: > What do you mean by "approximate"? I think @dcoughlin gave a perfect example in the following comment: @dcoughlin wrote: > This doesn't seem quite right. Consider: > > int i; > for (i = 0; i < 21; i += 3) {} >

Re: [Diffusion] rL248367: clang-format: Add initial #include sorting capabilities.

chapuni added subscribers: cfe-commits, chapuni. /cfe/trunk/lib/Tooling/Core/Replacement.cpp:408 FirstI may be in the end() when SecondI != end(). Then FirstI->getOffset() is invalid. I suggest to split the loop into - FirstI != First.end() && SecondI != Second.end(); - Tail-merge (either

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

klimek added a comment. It's not falling into oblivion, but it's not going to happen before next week, unless somebody else picks the review up. http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

pgousseau updated this revision to Diff 35505. pgousseau added a comment. Following Devin's review: Fix a comment in 'IsFirstBufInBound'. Remove incorrect assertion expecting 'RegionOffset::getOffset' to only return positives values. Add test cases for regions having negatives offsets. Updated

r248379 - Refactor library decision for -fopenmp support from Darwin into a

Author: joerg Date: Wed Sep 23 09:06:52 2015 New Revision: 248379 URL: http://llvm.org/viewvc/llvm-project?rev=248379=rev Log: Refactor library decision for -fopenmp support from Darwin into a function for sharing with other platforms. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

[PATCH] D13099: [Analyzer] Don’t invalidate CXXThis when conservatively evaluating const methods (PR 21606)

seaneveson created this revision. seaneveson added a subscriber: cfe-commits. Dear All, I would like to propose a patch that prevents the invalidation of ‘this’ when a method is const; fixing the test case given below, taken from PR 21606 (https://llvm.org/bugs/show_bug.cgi?id=21606). ```

Re: r248370 - [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

On Wed, Sep 23, 2015 at 11:29 AM, Vladimir Sukharev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vsukharev > Date: Wed Sep 23 04:29:32 2015 > New Revision: 248370 > > URL: http://llvm.org/viewvc/llvm-project?rev=248370=rev > Log: > [ARM] Fix crash "-target arm -mcpu=generic",

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

mclow.lists added a comment. Please DO NOT commit this patch. See http://cplusplus.github.io/LWG/lwg-active.html#2224 for a discussion of this code, and the (proposed) resolution is that this is undefined behavior. http://reviews.llvm.org/D13080

r248376 - [DeclPrinter] Don't crash when printing a using decl with a special name

Author: d0k Date: Wed Sep 23 08:43:16 2015 New Revision: 248376 URL: http://llvm.org/viewvc/llvm-project?rev=248376=rev Log: [DeclPrinter] Don't crash when printing a using decl with a special name Fixes PR24872. Modified: cfe/trunk/lib/AST/DeclPrinter.cpp

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

john.brawn added a comment. In http://reviews.llvm.org/D12903#251361, @rengolin wrote: > In http://reviews.llvm.org/D12903#249406, @thakis wrote: > > > Also also, this approach fundamentally doesn't work on Windows. > > > I don't think it's supposed to, anyway. :) Actually, I think it can work

r248378 - Add -fplugin=name.so option to the driver

Author: john.brawn Date: Wed Sep 23 08:55:40 2015 New Revision: 248378 URL: http://llvm.org/viewvc/llvm-project?rev=248378=rev Log: Add -fplugin=name.so option to the driver This translates to -load name.so in the cc1 command. We can't name the driver option -load, as that means "link against

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a comment. Won't it break hf-only builds, if you don't do both commits at the same time? http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r248370 - [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

On Wed, Sep 23, 2015 at 5:27 PM, Vladimir Sukharev < vladimir.sukha...@arm.com> wrote: > Hi Alexander, > > Sorry, forgot to run valgrind. > valgrind??? I thought, every LLVM developer must know about ASAN ;) > I’m gonna commit quick follow-up

r248391 - [Sema] Don't create an invalid source range for overlong initializer lists.

Author: d0k Date: Wed Sep 23 11:03:53 2015 New Revision: 248391 URL: http://llvm.org/viewvc/llvm-project?rev=248391=rev Log: [Sema] Don't create an invalid source range for overlong initializer lists. We took both source locations from the end of the initializer list what the code below doesn't

[PATCH] D13105: [OpenCL] Enable program scope variables for OpenCL2.0

Anastasia created this revision. Anastasia added a reviewer: pekka.jaaskelainen. Anastasia added a subscriber: cfe-commits. I would like to commit this change that enables program scope variables (PSVs) – an OpenCL2.0 feature (Section 6.5.1). There are three major changes in this patch. First

Re: [PATCH] D12901: [Static Analyzer] Intersecting ranges and 64 bit to 32 bit truncations causing "System is over constrained." assertions.

pgousseau added a comment. In http://reviews.llvm.org/D12901#248842, @xazax.hun wrote: > Hi! > > Thank you for the patch! Thanks for reviewing ! > What happens if you factor the "index + 1" expression out into a separate > variable? > E.g.: unsigned temp = index + 1; and use temp in the

[PATCH] D13109: [sanitizer] Enable lsan for AArch64

zatrazz created this revision. zatrazz added reviewers: rengolin, pcc, aemerson, t.p.northover. zatrazz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. compiler-rt related patch: http://reviews.llvm.org/D13108 http://reviews.llvm.org/D13109 Files:

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

john.brawn closed this revision. john.brawn added a comment. Committed in r248378. Repository: rL LLVM http://reviews.llvm.org/D12903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11908: Clang support for -fthinlto.

tejohnson updated this revision to Diff 35527. tejohnson added a comment. Updated the patch for the new LLVM/gold patch (http://reviews.llvm.org/D13107). Two changes: - I put back the original change to pass a new plugin option to gold. Since the function index design/name has been generalized

r248392 - [Lex] A source-file new-line in a raw string literal results in a new-line

Author: majnemer Date: Wed Sep 23 11:04:47 2015 New Revision: 248392 URL: http://llvm.org/viewvc/llvm-project?rev=248392=rev Log: [Lex] A source-file new-line in a raw string literal results in a new-line Our string literal parser copied any source-file new-line characters into the execution

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1616 @@ +1615,3 @@ +builder.isFeasible(false) && !StFalse && +BldCtx.blockCount() == AMgr.options.maxBlockVisitOnPath - 1) { + seaneveson wrote: > zaks.anna

RE: r248370 - [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

Ø valgrind??? I thought, every LLVM developer must know about ASAN ;) ASAN is not that great to quicktest such a small patches, and valgrind does its job in plug-and play manner. Or, which is recommended way to use ASAN as a pre-commit

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

DavidEGrayson added a comment. Hi John. I thought about your comment on line 1601 somewhat carefully and tried to imagine what it would look like. See my inline comment. Also, by the way, do you know if the results of the LLVM intrinsics like `llvm.smul.with.overflow.*` are guaranteed to be

r248400 - [CUDA] __global__ functions should always be visible externally.

Author: tra Date: Wed Sep 23 12:44:53 2015 New Revision: 248400 URL: http://llvm.org/viewvc/llvm-project?rev=248400=rev Log: [CUDA] __global__ functions should always be visible externally. Adjust __global__ functions with DiscardableODR linkage to use StrongODR linkage instead, so they are

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248408: [CUDA] Added CUDA installation detector class. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12989?vs=35531=35533#toc Repository: rL LLVM

Re: [PATCH] D13109: [sanitizer] Enable lsan for AArch64

samsonov added a subscriber: samsonov. samsonov accepted this revision. samsonov added a reviewer: samsonov. samsonov added a comment. This revision is now accepted and ready to land. OK to submit after compiler-rt support is submitted. http://reviews.llvm.org/D13109

Re: [PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

bob.wilson accepted this revision. bob.wilson added a comment. This revision is now accepted and ready to land. Good idea. The patch looks good. It will need to be coordinated with a change to compiler_rt build cc_kext_ios.a, though. Thanks for cleaning this up. http://reviews.llvm.org/D13113

[clang-tools-extra] r248418 - Fix loop-convert for const references to containers.

Author: klimek Date: Wed Sep 23 13:40:47 2015 New Revision: 248418 URL: http://llvm.org/viewvc/llvm-project?rev=248418=rev Log: Fix loop-convert for const references to containers. Previously we would use a non-const loop variable in the range-based loop for: void f(const std::vector ) { for

r248408 - [CUDA] Added CUDA installation detector class.

Author: tra Date: Wed Sep 23 13:13:25 2015 New Revision: 248408 URL: http://llvm.org/viewvc/llvm-project?rev=248408=rev Log: [CUDA] Added CUDA installation detector class. Added new option --cuda-path= which allows overriding default search paths. If it's not specified we look for CUDA

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

rjmccall added a comment. Yes, the main result is defined to be the true value mod 2^k even when overflow occurs. We do use the intrinsics to implement the existing fixed-width GCC builtins, which are meant to be useful not just for security checking, but for implementing arbitrary-precision

r248413 - Reverted r248408 "[CUDA] Added CUDA installation detector class."

Author: tra Date: Wed Sep 23 13:28:30 2015 New Revision: 248413 URL: http://llvm.org/viewvc/llvm-project?rev=248413=rev Log: Reverted r248408 "[CUDA] Added CUDA installation detector class." because included test fails on some platforms. Removed:

Re: [PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in

dirty updated this revision to Diff 35463. dirty added a comment. - Update patch with feedback from vsk: better handle errors from make_absolute(). Updating D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.

[PATCH] D13090: [clang-tidy] IdentifierNamingCheck should only emit warnings when declaration or usage is outside of macros

berenm created this revision. berenm added a reviewer: alexfh. berenm added a subscriber: cfe-commits. This fixes https://llvm.org/bugs/show_bug.cgi?id=24835. The patch might be slightly different after http://reviews.llvm.org/D13079 and http://reviews.llvm.org/D13081, but the idea is the same.

Re: [PATCH] D13090: [clang-tidy] IdentifierNamingCheck should only emit warnings when declaration or usage is outside of macros

berenm updated this revision to Diff 35468. berenm added a comment. Even better with the corresponding unit test fix. http://reviews.llvm.org/D13090 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming.cpp Index:

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

berenm changed the visibility of this Differential Revision from "berenm (Beren Minor)" to "Public (No Login Required)". berenm updated this revision to Diff 35465. berenm added a comment. Remove remaining commented code. http://reviews.llvm.org/D13081 Files:

Re: Implict casts disappeared from syntactic init list expressions in C++

Ping^2... Il 29/08/2015 10:01, Abramo Bagnara ha scritto: > Il 28/08/2015 23:27, Richard Smith ha scritto: >> On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara >> > wrote: >> >> Comparing the result of

Re: [PATCH] D13081: [clang-tidy] Implement FixitHints for identifier references in IdentifierNamingCheck

berenm updated this revision to Diff 35466. berenm added a comment. Fix incorrect line removal in unit test. http://reviews.llvm.org/D13081 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming.cpp Index:

Re: [PATCH] D13079: [clang-tidy] Code factorization and cleanup in IdentifierNamingCheck

berenm added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:508 @@ +507,3 @@ + auto = Failures[Decl]; + for (const auto : Failure.Usages) { +if (R == Range) Hopefully the number of ranges in Usages will stay low. If not,

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

berenm added a comment. Ping? Just to be sure it's not going to fall to oblivion. :) http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248367 - clang-format: Add initial #include sorting capabilities.

Author: djasper Date: Wed Sep 23 03:30:47 2015 New Revision: 248367 URL: http://llvm.org/viewvc/llvm-project?rev=248367=rev Log: clang-format: Add initial #include sorting capabilities. To implement this nicely, add a function that merges two sets of replacements that are meant to be done in

Re: [PATCH] D13080: [libc++] ~unique_ptr() should not set stored pointer to null

dcheng abandoned this revision. dcheng added a comment. OK, thanks for highlighting the proposed resolution. http://reviews.llvm.org/D13080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. The code LGTM, but there ought to be a way to add a LIT test for this. Looking for -object_path_lto, I found this: --- // RUN: %clang -target x86_64-apple-darwin10 -### %s \ // RUN:

r248436 - Forbid qualifiers on ObjC generic parameters and arguments, but

Author: rjmccall Date: Wed Sep 23 17:14:21 2015 New Revision: 248436 URL: http://llvm.org/viewvc/llvm-project?rev=248436=rev Log: Forbid qualifiers on ObjC generic parameters and arguments, but silently ignore them on arguments when they're provided indirectly (.e.g behind a template argument or

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

rtrieu added inline comments. Comment at: lib/Frontend/DiagnosticRenderer.cpp:442 @@ -419,1 +441,3 @@ +static bool checkLocForMacroArgExpansion(SourceLocation Loc, + const SourceManager , zhengkai wrote: > I have stated

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated this revision to Diff 35561. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c test/Misc/diag-macro-backtrace2.c

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai added inline comments. Comment at: lib/Frontend/DiagnosticRenderer.cpp:442 @@ -419,1 +441,3 @@ +/// Check if the current location fit in the macro argument expansion +/// Especially, it should fit in the same argument with all the other locations

[PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

beanz created this revision. beanz added reviewers: bogner, bob.wilson. beanz added a subscriber: cfe-commits. This corresponds to a patch to compiler-rt (D13112). Xcode 7 doesn't support targeting iOS5 and earlier. Instead of just dropping cc_kext_ios5, I've repurposed it to cc_kext_ios, and

Re: [PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

> On Sep 23, 2015, at 11:51 AM, Bob Wilson wrote: > > bob.wilson accepted this revision. > bob.wilson added a comment. > This revision is now accepted and ready to land. > > Good idea. The patch looks good. It will need to be coordinated with a change > to compiler_rt

r248430 - Remove wrong implication that value-dependent implies instantiation-dependent,

Author: rsmith Date: Wed Sep 23 16:30:47 2015 New Revision: 248430 URL: http://llvm.org/viewvc/llvm-project?rev=248430=rev Log: Remove wrong implication that value-dependent implies instantiation-dependent, and fix the only code that was depending on this so that it sets all the relevant flags

r248431 - PR14858: Initial support for proper sizeof... handling within alias templates.

Author: rsmith Date: Wed Sep 23 16:41:42 2015 New Revision: 248431 URL: http://llvm.org/viewvc/llvm-project?rev=248431=rev Log: PR14858: Initial support for proper sizeof... handling within alias templates. This doesn't quite get alias template equivalence right yet, but handles the egregious

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

rtrieu added inline comments. Comment at: lib/Frontend/DiagnosticRenderer.cpp:455 @@ -419,1 +454,3 @@ +static bool checkLocForMacroArgExpansion(SourceLocation Loc, + const SourceManager , rtrieu wrote: > zhengkai wrote: >

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated this revision to Diff 35556. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c test/Misc/diag-macro-backtrace2.c

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

The code LGTM, but there ought to be a way to add a LIT test for this. Looking for -object_path_lto, I found this: -- // RUN: %clang -target x86_64-apple-darwin10 -### %s \ // RUN: -mlinker-version=117 -flto 2> %t.log // RUN: cat %t.log // RUN: FileCheck -check-prefix=LINK_OBJECT_LTO_PATH %s <

r248435 - Remove warning on over-wide bit-field of boolean type; there's no risk that

Author: rsmith Date: Wed Sep 23 17:07:44 2015 New Revision: 248435 URL: http://llvm.org/viewvc/llvm-project?rev=248435=rev Log: Remove warning on over-wide bit-field of boolean type; there's no risk that someone thought all the bits would be value bits in this case. Also fix the wording of the

[clang-tools-extra] r248438 - Fix loop-convert for trivially copyable types.

Author: klimek Date: Wed Sep 23 17:28:14 2015 New Revision: 248438 URL: http://llvm.org/viewvc/llvm-project?rev=248438=rev Log: Fix loop-convert for trivially copyable types. Previously, we would rewrite: void f(const vector ) { for (size_t i = 0; i < v.size(); ++i) { to for (const auto :

r248432 - [analyzer] Improve localizability checks for iOS / OS X.

Author: dcoughlin Date: Wed Sep 23 16:43:21 2015 New Revision: 248432 URL: http://llvm.org/viewvc/llvm-project?rev=248432=rev Log: [analyzer] Improve localizability checks for iOS / OS X. Various improvements to the localization checker: * Adjusted copy to be consistent with diagnostic text in

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai marked an inline comment as done. Comment at: lib/Frontend/DiagnosticRenderer.cpp:442 @@ -419,1 +441,3 @@ +static bool checkLocForMacroArgExpansion(SourceLocation Loc, + const SourceManager , I have stated that I

Re: r247618 - C11 _Bool bitfield diagnostic

On Mon, Sep 21, 2015 at 3:21 PM, Alexey Samsonov wrote: > Do you plan to fix diagnostic emission for cases like "bool b : 4" in the > near future, or it makes sense to revert this change until we reach > consensus on the rules, and implementation? > Fixed in r248435. > On

r248424 - Push OpenMP linker flags after linker input on Darwin. Don't add any

Author: joerg Date: Wed Sep 23 15:07:56 2015 New Revision: 248424 URL: http://llvm.org/viewvc/llvm-project?rev=248424=rev Log: Push OpenMP linker flags after linker input on Darwin. Don't add any libraries if -nostdlib is specified. Test. Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

Random question. Is there any reason to generate clang-cl if you’re not on Windows? It may make sense to move clang-cl under the if(WIN32). -Chris > On Sep 21, 2015, at 3:44 PM, Hans Wennborg via cfe-commits > wrote: > > Author: hans > Date: Mon Sep 21 17:44:57

[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno created this revision. bruno added a reviewer: dexonsmith. bruno added subscribers: cfe-commits, kledzik, bob.wilson. bruno set the repository for this revision to rL LLVM. Usually, when using LTO with a clang installation newer than the system one, there's a libLTO.dylib version mismatch

r248426 - Support linking against OpenMP runtime on NetBSD.

Author: joerg Date: Wed Sep 23 15:11:00 2015 New Revision: 248426 URL: http://llvm.org/viewvc/llvm-project?rev=248426=rev Log: Support linking against OpenMP runtime on NetBSD. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/fopenmp.c Modified:

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated this revision to Diff 35554. zhengkai marked 11 inline comments as done. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

MyDeveloperDay added a comment. Actually the 2010 failure may be my fault, I only have Visual C# installed for VS2010 and not the C++ compilers, as such it doesn't seem to understand C/C++ as the content type if (!textBuffer.ContentType.IsOfType("C/C++")) is failing because the ContentType is

[PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

s.egerton created this revision. s.egerton added reviewers: dsanders, vkalintiris. s.egerton added a subscriber: cfe-commits. This is a follow on to post review comments on revision r248276. http://reviews.llvm.org/D13100 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

Re: r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

(Now including the list; sorry for the double emails.) Yes, because clang-cl does work on non-Windows. I don't think anyone has used it for actual cross-compilation from e.g. Linux to Windows yet, but it's a theoretical possibility. It's also useful for testing and developing clang-cl.

Re: r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

Cool! I wasn’t aware that it was useful on Linux. -Chris > On Sep 23, 2015, at 1:39 PM, Hans Wennborg wrote: > > (Now including the list; sorry for the double emails.) > > Yes, because clang-cl does work on non-Windows. I don't think anyone > has used it for actual

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

compnerd added a comment. It would fail to link previously anyways, since as Renato correctly explained, you would have objects that were built with the soft float attribute, and then were linking against hard float built object. http://reviews.llvm.org/D12996

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

chapuni added a subscriber: chapuni. Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492 @@ +1491,3 @@ +const llvm::opt::ArgList ) { + SmallVector CudaPathCandidates; + Fixed in r248459.

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

echristo added a subscriber: echristo. echristo added a comment. Aha, nice catch! -eric Repository: rL LLVM http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

Aha, nice catch! -eric On Wed, Sep 23, 2015 at 9:32 PM NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > > > Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492 > @@ +1491,3 @@ > +const

r248370 - [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

Author: vsukharev Date: Wed Sep 23 04:29:32 2015 New Revision: 248370 URL: http://llvm.org/viewvc/llvm-project?rev=248370=rev Log: [ARM] Fix crash "-target arm -mcpu=generic", without "-march=" An assertion hit has been fixed for cmdlines like $ clang --target=arm-linux-gnueabi -mcpu=generic

Re: [PATCH] D13013: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

This revision was automatically updated to reflect the committed changes. Closed by commit rL248370: [ARM] Fix crash "-target arm -mcpu=generic", without "-march=" (authored by vsukharev). Changed prior to commit: http://reviews.llvm.org/D13013?vs=35234=35472#toc Repository: rL LLVM

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

rengolin added a comment. IIUC, HF builds still produce soft float attributes, and that's the problem. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248458 - clang/test/Analysis/malloc-overflow2.c: Appease 32-bit targets.

Author: chapuni Date: Wed Sep 23 21:49:00 2015 New Revision: 248458 URL: http://llvm.org/viewvc/llvm-project?rev=248458=rev Log: clang/test/Analysis/malloc-overflow2.c: Appease 32-bit targets. size_t is not unsigned long for targeting i686 (and Windows x64). Modified:

Re: r248458 - clang/test/Analysis/malloc-overflow2.c: Appease 32-bit targets.

Thanks for fixing this! Devin > On Sep 23, 2015, at 7:49 PM, NAKAMURA Takumi via cfe-commits > wrote: > > Author: chapuni > Date: Wed Sep 23 21:49:00 2015 > New Revision: 248458 > > URL: http://llvm.org/viewvc/llvm-project?rev=248458=rev > Log: >

r248459 - cuda-path: StringRef cannot be used here.

Author: chapuni Date: Wed Sep 23 22:15:44 2015 New Revision: 248459 URL: http://llvm.org/viewvc/llvm-project?rev=248459=rev Log: cuda-path: StringRef cannot be used here. Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL:

Re: [PATCH] D9924: Discard malloc-overflow bug-report when a known size is malloc'ed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248446: [analyzer] Discard malloc-overflow bug-report when a known size is malloc'ed. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D9924?vs=35461=35572#toc Repository:

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated this revision to Diff 35574. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c test/Misc/diag-macro-backtrace2.c

Re: [PATCH] D13052: Add NamingStyle option to modernize-loop-convert.

alexfh added a comment. A few minor comments. Comment at: clang-tidy/modernize/LoopConvertCheck.h:68 @@ -67,2 +67,3 @@ Confidence::Level MinConfidence; + VariableNamer::NamingStyle NamingStyle; }; The variable can be const, the one above as well.

RE: r248370 - [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

On 23 Sep 2015 18:08, "Vladimir Sukharev" wrote: > > > > Ø valgrind??? I thought, every LLVM developer must know about ASAN ;) > > ASAN is not that great to quicktest such a small patches, and valgrind does its job in plug-and play manner. > > Or, which is recommended

Re: [PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

This revision was automatically updated to reflect the committed changes. Closed by commit rL248442: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures… (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D13113?vs=35538=35567#toc Repository:

Re: r248433 - [CUDA] Added CUDA installation detector class.

On Wed, Sep 23, 2015 at 2:49 PM, Artem Belevich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tra > Date: Wed Sep 23 16:49:39 2015 > New Revision: 248433 > > URL: http://llvm.org/viewvc/llvm-project?rev=248433=rev > Log: > [CUDA] Added CUDA installation detector class. > > Added

Re: r248433 - [CUDA] Added CUDA installation detector class.

Yes I can. Create a deep nested directly, create a symlink from there to your Inputs/CUDA, and run "clang -v --target=i386-unknown-linux --sysroot=/Inputs/CUDA". On Wed, Sep 23, 2015 at 4:47 PM, Artem Belevich wrote: > I'm looking into it. Can you reproduce it on linux? > > >

Re: r248433 - [CUDA] Added CUDA installation detector class.

How long is very long? I've tested on ubuntu with ~1600-character-long path and it works. Buildbot filed with a much shorter path: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/7416/consoleFull#-1841136826a1ca8a51-895e-46c6-af87-ce24fa4cd561 I'll unroll my change if I fail to

r248448 - Disabled one of the test runs in cuda-detect.cu

Author: tra Date: Wed Sep 23 19:15:47 2015 New Revision: 248448 URL: http://llvm.org/viewvc/llvm-project?rev=248448=rev Log: Disabled one of the test runs in cuda-detect.cu --sysroot apparently can't handle long paths which triggers test failure on some platforms. Modified:

[clang-tools-extra] r248449 - Use simpler interface for getting the pointee type for a node.

Author: klimek Date: Wed Sep 23 19:16:38 2015 New Revision: 248449 URL: http://llvm.org/viewvc/llvm-project?rev=248449=rev Log: Use simpler interface for getting the pointee type for a node. Modified: clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp Modified:

r248442 - [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

Author: cbieneman Date: Wed Sep 23 17:52:35 2015 New Revision: 248442 URL: http://llvm.org/viewvc/llvm-project?rev=248442=rev Log: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios Summary: This corresponds to a patch to compiler-rt

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai updated this revision to Diff 35573. http://reviews.llvm.org/D12379 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp lib/Frontend/DiagnosticRenderer.cpp test/Index/fix-its.m test/Misc/caret-diags-macros.c test/Misc/diag-macro-backtrace2.c

Re: r248433 - [CUDA] Added CUDA installation detector class.

I'm looking into it. Can you reproduce it on linux? On Wed, Sep 23, 2015 at 4:43 PM, Rui Ueyama wrote: > On Wed, Sep 23, 2015 at 2:49 PM, Artem Belevich via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: tra >> Date: Wed Sep 23 16:49:39 2015 >> New Revision:

r248454 - Improve the printing of ranges when macros are involved.

Author: rtrieu Date: Wed Sep 23 20:21:01 2015 New Revision: 248454 URL: http://llvm.org/viewvc/llvm-project?rev=248454=rev Log: Improve the printing of ranges when macros are involved. Trace the ranges through the macro backtrace better. This allows better range highlighting through all levels

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks Pierre! I will commit. http://reviews.llvm.org/D12571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13122: Enable SafeStack on all Linux platforms

eugenis created this revision. eugenis added reviewers: samsonov, pcc. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. I don't see the point in limiting it to x86/x86_64 in the driver. It is only slightly less broken on x86 than on other

r248456 - Make a test a bit shorter. No behavior change.

Author: nico Date: Wed Sep 23 20:34:27 2015 New Revision: 248456 URL: http://llvm.org/viewvc/llvm-project?rev=248456=rev Log: Make a test a bit shorter. No behavior change. Modified: cfe/trunk/test/Sema/warn-sizeof-arrayarg.c Modified: cfe/trunk/test/Sema/warn-sizeof-arrayarg.c URL:

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

This revision was automatically updated to reflect the committed changes. Closed by commit rL248454: Improve the printing of ranges when macros are involved. (authored by rtrieu). Changed prior to commit: http://reviews.llvm.org/D12379?vs=35575=35580#toc Repository: rL LLVM

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ +Sizes.push_back(Size); +MapTypes.push_back(MapType); + } + + // Keep track on whether the host function has to be executed. + auto OffloadErrorQType = +

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin updated this revision to Diff 35585. ikudrin added a comment. - Rebased to the top of history - Made pathes local to clang subtree http://reviews.llvm.org/D12832 Files: lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h Index: lib/Driver/ToolChains.h

r248463 - [Driver] Add support for Windows 10 SDK

Author: ikudrin Date: Thu Sep 24 00:16:36 2015 New Revision: 248463 URL: http://llvm.org/viewvc/llvm-project?rev=248463=rev Log: [Driver] Add support for Windows 10 SDK Summary: With Windows 10 SDK, Include and Lib directories now contain an additional subfolder with the name that corresponds