Re: r250440 - clang-format: Basic escaping when outputting XML.

Added in r250629. On Thu, Oct 15, 2015 at 11:43 AM, Nico Weber wrote: > test? > > On Thu, Oct 15, 2015 at 11:39 AM, Daniel Jasper via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: djasper >> Date: Thu Oct 15 13:39:31 2015 >> New Revision: 250440 >> >> URL:

r250631 - clang/test/Driver/ps4-linker-non-win.c: Make %T/ps4-ld executable, or the driver wouldn't find it.

Author: chapuni Date: Sat Oct 17 18:47:02 2015 New Revision: 250631 URL: http://llvm.org/viewvc/llvm-project?rev=250631=rev Log: clang/test/Driver/ps4-linker-non-win.c: Make %T/ps4-ld executable, or the driver wouldn't find it. Modified: cfe/trunk/test/Driver/ps4-linker-non-win.c Modified:

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

mprobst updated this revision to Diff 37695. mprobst marked 3 inline comments as done. mprobst added a comment. - add test - review comments, fix unary handling. - Extract canPrecedeRegexLiteral function. http://reviews.llvm.org/D13765 Files: lib/Format/Format.cpp

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

mprobst added inline comments. Comment at: lib/Format/Format.cpp:860 @@ +859,3 @@ +} +if (Prev) { + if (Prev->isOneOf(tok::plusplus, tok::minusminus)) { djasper wrote: > I understand and I actually find that hard to understand. I think a better >

r250647 - Make a bunch of static arrays const.

Author: ctopper Date: Sun Oct 18 00:29:26 2015 New Revision: 250647 URL: http://llvm.org/viewvc/llvm-project?rev=250647=rev Log: Make a bunch of static arrays const. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/lib/CodeGen/TargetInfo.cpp

r250646 - Add an unnecessary makeArrayRef I add earlier. I didn't realize range-based for loops worked with arrays.

Author: ctopper Date: Sun Oct 18 00:29:23 2015 New Revision: 250646 URL: http://llvm.org/viewvc/llvm-project?rev=250646=rev Log: Add an unnecessary makeArrayRef I add earlier. I didn't realize range-based for loops worked with arrays. Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp

r250645 - Use std::is_sorted instead of a manual loop.

Author: ctopper Date: Sun Oct 18 00:29:21 2015 New Revision: 250645 URL: http://llvm.org/viewvc/llvm-project?rev=250645=rev Log: Use std::is_sorted instead of a manual loop. Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp URL:

[clang-tools-extra] r250641 - Make a bunch of static arrays const.

Author: ctopper Date: Sun Oct 18 00:14:41 2015 New Revision: 250641 URL: http://llvm.org/viewvc/llvm-project?rev=250641=rev Log: Make a bunch of static arrays const. Modified: clang-tools-extra/trunk/clang-modernize/UseAuto/UseAutoMatchers.cpp

r250605 - [Frontend] Name variable correctly.

Author: davide Date: Sat Oct 17 01:46:39 2015 New Revision: 250605 URL: http://llvm.org/viewvc/llvm-project?rev=250605=rev Log: [Frontend] Name variable correctly. Reported by: Kim Grasman! Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified:

r250617 - Use a range-based for loop. Use std::end instead of pointer+array_lengthof. NFC

Author: ctopper Date: Sat Oct 17 12:10:43 2015 New Revision: 250617 URL: http://llvm.org/viewvc/llvm-project?rev=250617=rev Log: Use a range-based for loop. Use std::end instead of pointer+array_lengthof. NFC Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Modified:

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

michaelwu added a comment. Visibility can be set via command line args without any attributes in the AST, so I don't think that's sufficient. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37673. majnemer added a comment. - Remove TemplateName::BuiltinTemplate http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37676. majnemer added a comment. - Add test for __make_integer_seq http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h

Re: r250473 - Add an error when calling a builtin that requires features that don't

I'm reasonably certain you forgot to rebuild or ran make test in the wrong directory. Two reasons: a) This is pretty much my first patch. I mean, identical and I tried that. b) I actually tried this one and got: Testing Time: 217.41s Failing Tests (68): Clang ::

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37675. majnemer added a comment. - Make __make_integer_seq parameters as implicit - Remove Sema::Ident___make_integer_seq - Remove extraneous whitespace change http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

skalinichev added a comment. Isn't r246931 what you're looking for? > Index: expose visibility attribute > > Expose the previously unexposed visibility attribute via the python and C > bindings. Can't you use/improve that API instead? http://reviews.llvm.org/D13388

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37674. majnemer added a comment. - Rename BuiltinTemplateNameKind to BuiltinTemplateKind http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer added a comment. @rsmith, I've kept the caching of the `BuiltinTemplateDecl` for `__make_integer_seq` as we keep falling into the `LookupBuiltin`. Is there more that must be done to get "normal" lookups to find the decl? http://reviews.llvm.org/D13786

Re: r250473 - Add an error when calling a builtin that requires features that don't

On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473=rev > Log: > Add an error when calling a builtin that requires

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

djasper added inline comments. Comment at: lib/Format/Format.cpp:828 @@ +827,3 @@ + // Returns \c true if \p Tok can only be followed by an operand in JavaScript. + bool PrecedesOperand(FormatToken *Tok) { +// NB: This is not entirely correct, as an r_paren can introduce

r250621 - Replace a static compare function with a lambda. NFC

Author: ctopper Date: Sat Oct 17 15:18:46 2015 New Revision: 250621 URL: http://llvm.org/viewvc/llvm-project?rev=250621=rev Log: Replace a static compare function with a lambda. NFC Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp URL: