Re: [PATCH] D13853: clang-format: Treat --sort-includes that #include and #import mean the same thing.

thakis added inline comments. Comment at: lib/Format/Format.cpp:1735 @@ -1734,3 +1734,3 @@ llvm::Regex IncludeRegex( - R"(^[\t\ ]*#[\t\ ]*include[^"<]*(["<][^">]*[">]))"); + R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"); SmallVector

[PATCH] D13853: clang-format: Treat --sort-includes that #include and #import mean the same thing.

thakis created this revision. thakis added a reviewer: djasper. thakis added a subscriber: cfe-commits. Herald added a subscriber: klimek. clang accepts both #include and #import for includes (the latter having an implicit header guard). Let clang-format interleave both types if --sort-includes

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher writes: > I'm reasonably certain you forgot to rebuild or ran make test in the wrong > directory. You're right, I did something funny there. Sorry for the noise. > Two reasons: > > a) This is pretty much my first patch. I mean, identical and I tried that. >

r250665 - CodeGen: simplify TargetOptions setup

Author: compnerd Date: Sun Oct 18 15:24:53 2015 New Revision: 250665 URL: http://llvm.org/viewvc/llvm-project?rev=250665=rev Log: CodeGen: simplify TargetOptions setup Do direct assignment of boolean values and regroup. Use StringSwitch instead of custom cases. NFC. Modified:

r250671 - Update list of languages advertised in OVERVIEW: A tool to format C/C++/Java/JavaScript/Objective-C/Protobuf code.

Author: nico Date: Sun Oct 18 20:03:19 2015 New Revision: 250671 URL: http://llvm.org/viewvc/llvm-project?rev=250671=rev Log: Update list of languages advertised in OVERVIEW: A tool to format C/C++/Java/JavaScript/Objective-C/Protobuf code. If no arguments are specified, it formats the code

Re: r250473 - Add an error when calling a builtin that requires features that don't

No worries! :) On Sun, Oct 18, 2015, 5:42 PM Justin Bogner wrote: > Eric Christopher writes: > > I'm reasonably certain you forgot to rebuild or ran make test in the > wrong > > directory. > > You're right, I did something funny there. Sorry for the

r250666 - No functionality change, just fix whitespace, a typo and remove an unnecessary

Author: nicholas Date: Sun Oct 18 15:32:12 2015 New Revision: 250666 URL: http://llvm.org/viewvc/llvm-project?rev=250666=rev Log: No functionality change, just fix whitespace, a typo and remove an unnecessary emacs mode marker. (Changes left behind from another patch that ended up not working

r250672 - Update `clang-format -help` output in clang-format docs.

Author: nico Date: Sun Oct 18 20:08:30 2015 New Revision: 250672 URL: http://llvm.org/viewvc/llvm-project?rev=250672=rev Log: Update `clang-format -help` output in clang-format docs. -assume-filename, -fallback-style, and -sort-includes are new. (They're also longer than the previous options,

r250677 - Revert r250676 "Return an ArrayRef instead of having two out parameters of a pointer and length. NFC"

Author: ctopper Date: Sun Oct 18 22:17:00 2015 New Revision: 250677 URL: http://llvm.org/viewvc/llvm-project?rev=250677=rev Log: Revert r250676 "Return an ArrayRef instead of having two out parameters of a pointer and length. NFC" Modified: cfe/trunk/include/clang/Basic/TargetInfo.h

r250674 - docs: remote stale refs

Author: compnerd Date: Sun Oct 18 20:24:08 2015 New Revision: 250674 URL: http://llvm.org/viewvc/llvm-project?rev=250674=rev Log: docs: remote stale refs Since the attribute documentation is now auto-generated, the previous references are no longer valid. This prevented the docs build from

r250676 - Return an ArrayRef instead of having two out parameters of a pointer and length. NFC

Author: ctopper Date: Sun Oct 18 22:05:12 2015 New Revision: 250676 URL: http://llvm.org/viewvc/llvm-project?rev=250676=rev Log: Return an ArrayRef instead of having two out parameters of a pointer and length. NFC Modified: cfe/trunk/include/clang/Basic/TargetInfo.h

[PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

davide created this revision. davide added a reviewer: rsmith. davide added a subscriber: cfe-commits. davide set the repository for this revision to rL LLVM. Richard, this implements what you proposed in https://llvm.org/bugs/show_bug.cgi?id=25223 , hopefully in the correct way. This is what we

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D7639#266332, @Eugene.Zelenko wrote: > What is preventing to add this check to Clang-tidy? Just found another piece > of fresh C++ code in LLDB with (void) as argument list... To be honest, I don't know. This review had taken

r250681 - Make getTargetBuiltins return an ArrayRef instead of having two out parameters of a pointer and length. NFC

Author: ctopper Date: Sun Oct 18 23:51:35 2015 New Revision: 250681 URL: http://llvm.org/viewvc/llvm-project?rev=250681=rev Log: Make getTargetBuiltins return an ArrayRef instead of having two out parameters of a pointer and length. NFC Modified: cfe/trunk/include/clang/Basic/Builtins.h

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

LegalizeAdulthood updated this revision to Diff 37717. http://reviews.llvm.org/D7639 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantVoidArgCheck.cpp clang-tidy/readability/RedundantVoidArgCheck.h

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky added a comment. In http://reviews.llvm.org/D13643#266926, @aaron.ballman wrote: > I would spend some time digging into how GCC handles those cases, and use > that as a baseline that we can then improve upon. I like the fact that GCC > basically says "use parens to clarify your

r250678 - Recommit "Return an ArrayRef instead of having two out parameters of a pointer and length. NFC". Hopefully this time the bots will be happy.

Author: ctopper Date: Sun Oct 18 22:52:27 2015 New Revision: 250678 URL: http://llvm.org/viewvc/llvm-project?rev=250678=rev Log: Recommit "Return an ArrayRef instead of having two out parameters of a pointer and length. NFC". Hopefully this time the bots will be happy. Modified:

Re: r250671 - Update list of languages advertised in OVERVIEW: A tool to format C/C++/Java/JavaScript/Objective-C/Protobuf code.

I had committed this with svn commit tools/clang-format -m "Update list of languages advertised in `clang-format -h` output." and since I used "" and not '' the shell executed the `clang-format -h` bit and made the commit message look funny. Apologies. On Sun, Oct 18, 2015 at 6:03 PM, Nico

Re: r248782 - clang-format: Extend #include sorting functionality

On Tue, Sep 29, 2015 at 12:53 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Tue Sep 29 02:53:08 2015 > New Revision: 248782 > > URL: http://llvm.org/viewvc/llvm-project?rev=248782=rev > Log: > clang-format: Extend #include sorting functionality >

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

djasper closed this revision. djasper added a comment. Submitted as r250648. http://reviews.llvm.org/D13765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r250648 - clang-format: [JS] Handle string literals spanning character classes.

Author: djasper Date: Sun Oct 18 02:02:28 2015 New Revision: 250648 URL: http://llvm.org/viewvc/llvm-project?rev=250648=rev Log: clang-format: [JS] Handle string literals spanning character classes. If a RegExp contains a character group with a quote (/["]/), the trailing end of it is first

r250657 - Support linking against OpenMP runtime on FreeBSD.

Author: dim Date: Sun Oct 18 08:32:20 2015 New Revision: 250657 URL: http://llvm.org/viewvc/llvm-project?rev=250657=rev Log: Support linking against OpenMP runtime on FreeBSD. Summary: Similar to rL248426 (which was a followup to rL248379 and rL248424), add the required libraries for OpenMP on

Re: [Diffusion] rL248424: Push OpenMP linker flags after linker input on Darwin. Don't add any

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248379, http://reviews.llvm.org/rL248426, and http://reviews.llvm.org/rL250657. Together, these add support for linking

Re: [Diffusion] rL248379: Refactor library decision for -fopenmp support from Darwin into a

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248424, http://reviews.llvm.org/rL248426, and http://reviews.llvm.org/rL250657. Together, these add support for linking

Re: [Diffusion] rL248426: Support linking against OpenMP runtime on NetBSD.

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248379, http://reviews.llvm.org/rL248424, and http://reviews.llvm.org/rL250657. Together, these add support for linking

Re: [Diffusion] rL250657: Support linking against OpenMP runtime on FreeBSD.

dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248379, http://reviews.llvm.org/rL248424, and http://reviews.llvm.org/rL248426. Together, these add support for linking against OpenMP on FreeBSD and