Re: [PATCH] D10016: Refactor: Simplify boolean conditional return statements in lib/Frontend

LegalizeAdulthood updated this revision to Diff 38309. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10016 Files: lib/Frontend/VerifyDiagnosticConsumer.cpp Index: lib/Frontend/VerifyDiagnosticConsumer.cpp

Re: [libcxx] r249929 - Split out of .

Hi Eric, Understood, thanks! Michael > On Oct 24, 2015, at 1:18 AM, Eric Fiselier wrote: > > Hi Michael, > > Sorry I'm holding this patch up in review. The fix is quite "novel" and I > want to make sure we get it right. If we can't land it over the weekend I'll > ask Richard

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

LegalizeAdulthood added a comment. I do not have commit access; someone will need to commit this for me. http://reviews.llvm.org/D10025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47 @@ +46,3 @@ + + bool isChildProcess(const ProgramStateRef State) const; + a.sidorin wrote: > I think it's a good idea to make some functions static and/or move them out >

Getting fully qualified names of random qualtypes

As requested on cfe-dev, enclosed is a patch (that needs some style-related work) to calculate the complete fully qualified name of arbitrary Qualtypes, including recursively expanding template parameters and subtypes. Seems to me like it follows most of the conventions described here:

Re: [PATCH] D13954: CodeGen: Fix LLVM assertion if Swift and Clang emit Objective-C class reference in same LLVM module

slavapestov added a subscriber: slavapestov. slavapestov added a comment. Unfortunately the asm label attribute doesn’t seem to work in this case, at least on Darwin. I get two symbols in the IR, with the asm label having the \01 prefix from MangleContext::mangleName():

Re: [PATCH] D13954: CodeGen: Fix LLVM assertion if Swift and Clang emit Objective-C class reference in same LLVM module

Unfortunately the asm label attribute doesn’t seem to work in this case, at least on Darwin. I get two symbols in the IR, with the asm label having the \01 prefix from MangleContext::mangleName(): @"\01OBJC_CLASS_$_NSNumber" = common global %struct.art_class* null, align 8

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

LegalizeAdulthood updated this revision to Diff 38313. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10025 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp Index: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp

Re: [PATCH] D10024: Refactor: Simplify boolean conditional return statements in tools/libclang

LegalizeAdulthood updated this revision to Diff 38315. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update to latest. Update from comments. I don't have commit access. http://reviews.llvm.org/D10024 Files: tools/libclang/CIndex.cpp

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:149 @@ +148,3 @@ + + // see if it's an ordinary assignment + do { ygribov wrote: > a.sidorin wrote: > > You can use early return to escape do{}. > In this particular case -

Re: [PATCH] D10020: Refactor: Simplify boolean conditional return statements in lib/Serialization

LegalizeAdulthood updated this revision to Diff 38310. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10020 Files: lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp

Re: [PATCH] D10020: Refactor: Simplify boolean conditional return statements in lib/Serialization

LegalizeAdulthood added a comment. This changeset needs review, but I'm unsure of who to add as explicit reviewers. http://reviews.llvm.org/D10020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10021: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Checkers

LegalizeAdulthood updated this revision to Diff 38311. LegalizeAdulthood added a comment. Update to latest. This changeset needs review; I am unsure who to add as specific reviewers. http://reviews.llvm.org/D10021 Files: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp

Re: [PATCH] D10022: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Core

LegalizeAdulthood added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:692-693 @@ -691,4 +691,2 @@ CXXBasePaths Paths(false, false, false); - if (RD->lookupInBases( - [DeclName](const CXXBaseSpecifier *Specifier, CXXBasePath ) {

Re: [PATCH] D10014: Refactor: Simplify boolean conditional return statements in lib/Edit

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D10014#178294, @calabrese wrote: > I like the idea of all of these changes (this change list and the others), > but just a suggestion -- it looks like when the branch of the original > condition returns false, as was the case in the

r251214 - Simplify boolean conditional return statements in lib/Basic.

Author: rafael Date: Sat Oct 24 18:15:31 2015 New Revision: 251214 URL: http://llvm.org/viewvc/llvm-project?rev=251214=rev Log: Simplify boolean conditional return statements in lib/Basic. Patch by Richard. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D10010: Refactor: Simplify boolean conditional return statements in lib/AST

LegalizeAdulthood updated this revision to Diff 38321. LegalizeAdulthood added a comment. Update from latest. I do not have commit access. http://reviews.llvm.org/D10010 Files: lib/AST/ASTContext.cpp lib/AST/ASTDiagnostic.cpp lib/AST/Decl.cpp lib/AST/DeclCXX.cpp lib/AST/Expr.cpp

Re: [PATCH] D10012: Refactor: Simplify boolean conditional return statements in lib/CodeGen

r251213 On 24 October 2015 at 14:58, Richard wrote: > LegalizeAdulthood updated this revision to Diff 38317. > LegalizeAdulthood added a comment. > > Update to latest. > I do not have commit access. > > > http://reviews.llvm.org/D10012 > > Files: >

Re: [PATCH] D10019: Refactor: Simplify boolean conditional return statements in lib/Sema

LegalizeAdulthood updated this revision to Diff 38324. LegalizeAdulthood added a comment. Update from latest. Update from comments. I do not have commit access. http://reviews.llvm.org/D10019 Files: lib/Sema/SemaChecking.cpp lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaDecl.cpp

Re: [PATCH] D10012: Refactor: Simplify boolean conditional return statements in lib/CodeGen

LegalizeAdulthood updated this revision to Diff 38317. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10012 Files: lib/CodeGen/BranchFolding.cpp lib/CodeGen/CodeGenPrepare.cpp lib/CodeGen/LiveDebugVariables.cpp

Re: [PATCH] D10011: Refactor: Simplify boolean conditional return statements in lib/Basic

LegalizeAdulthood updated this revision to Diff 38318. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10011 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

Re: [PATCH] D10022: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Core

LegalizeAdulthood updated this revision to Diff 38319. LegalizeAdulthood added a comment. Update from latest http://reviews.llvm.org/D10022 Files: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp lib/StaticAnalyzer/Core/SValBuilder.cpp lib/StaticAnalyzer/Core/SymbolManager.cpp Index:

Re: [PATCH] D10014: Refactor: Simplify boolean conditional return statements in lib/Edit

LegalizeAdulthood updated this revision to Diff 38323. LegalizeAdulthood added a comment. Update from latest. I do not have commit access. http://reviews.llvm.org/D10014 Files: lib/Edit/RewriteObjCFoundationAPI.cpp Index: lib/Edit/RewriteObjCFoundationAPI.cpp

Re: [PATCH] D10017: Refactor: Simplify boolean conditional return statements in lib/Lex

LegalizeAdulthood updated this revision to Diff 38322. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10017 Files: lib/Lex/PPDirectives.cpp lib/Lex/PPMacroExpansion.cpp Index: lib/Lex/PPMacroExpansion.cpp

[clang-tools-extra] r251204 - Test commit

Author: piotrdz Date: Sat Oct 24 15:11:47 2015 New Revision: 251204 URL: http://llvm.org/viewvc/llvm-project?rev=251204=rev Log: Test commit Modified: clang-tools-extra/trunk/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp Modified:

r251218 - [analyzer] scan-build: Teach ccc-analyzer about -Xclang.

Author: dcoughlin Date: Sat Oct 24 20:30:18 2015 New Revision: 251218 URL: http://llvm.org/viewvc/llvm-project?rev=251218=rev Log: [analyzer] scan-build: Teach ccc-analyzer about -Xclang. Update ccc-analyzer to forward both -Xclang and its following argument to the the compiler driver.

Re: [PATCH] D14014: Checker of proper vfork usage

a.sidorin added a comment. I put some suggestions in inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47 @@ +46,3 @@ + + bool isChildProcess(const ProgramStateRef State) const; + I think it's a good idea to make some functions static

r251182 - clang/module.modulemap: s/Basic/BuiltinsR600.def/Basic/BuiltinsAMDGPU.def/

Author: chapuni Date: Sat Oct 24 02:16:41 2015 New Revision: 251182 URL: http://llvm.org/viewvc/llvm-project?rev=251182=rev Log: clang/module.modulemap: s/Basic/BuiltinsR600.def/Basic/BuiltinsAMDGPU.def/ Modified: cfe/trunk/include/clang/module.modulemap Modified:

Re: [libcxx] r249929 - Split out of .

Hi Michael, Sorry I'm holding this patch up in review. The fix is quite "novel" and I want to make sure we get it right. If we can't land it over the weekend I'll ask Richard to revert while we work on it. /Eric On Oct 23, 2015 10:13 PM, "Michael Zolotukhin via cfe-commits" <

Re: [libcxx] r249929 - Split out of .

Hi Richard, Is this patch ready for commit, or were you just checking an idea? Our bots are still failing to build povray, so we’re really looking forward for some fix:) Thanks, Michael > On Oct 15, 2015, at 6:21 PM, Manman Ren via cfe-commits > wrote: > >> >>