Author: ctopper
Date: Thu Nov 12 01:36:50 2015
New Revision: 252861
URL: http://llvm.org/viewvc/llvm-project?rev=252861&view=rev
Log:
Use %select to merge two diagnostics that only differ in one word and are
emitted in the same place. NFC
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLex
ahatanak updated this revision to Diff 40011.
ahatanak added a comment.
Address review comments.
http://reviews.llvm.org/D12547
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/attr-disable-tail-calls.c
danielmarjamaki added a comment.
In http://reviews.llvm.org/D12359#287522, @rsmith wrote:
> Why does this construct justify the compiler emitting a warning? It seems to
> be reporting a fact about the code rather than a bug, and as there are many
> coding styles where variables are not routinel
On Wed, Nov 11, 2015 at 6:59 PM, Richard Smith
wrote:
> On Wed, Nov 11, 2015 at 3:53 PM, Nathan Wilson via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nwilson
>> Date: Wed Nov 11 17:53:35 2015
>> New Revision: 252827
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=252827&vi
Author: nwilson
Date: Wed Nov 11 22:25:03 2015
New Revision: 252855
URL: http://llvm.org/viewvc/llvm-project?rev=252855&view=rev
Log:
[Sema] Remove unnecessary parens in check using logical or; NFC.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
htt
Author: compnerd
Date: Wed Nov 11 21:57:22 2015
New Revision: 252853
URL: http://llvm.org/viewvc/llvm-project?rev=252853&view=rev
Log:
libclang: add clang_Cursor_getCXXManglings
This function permits the mangling of a C++ 'structor. Depending on the ABI and
the declaration, the declaration may c
Author: compnerd
Date: Wed Nov 11 21:57:16 2015
New Revision: 252852
URL: http://llvm.org/viewvc/llvm-project?rev=252852&view=rev
Log:
libclang: add new StringSet type
This allows the return of a set of CXStrings from libclang. This is setup work
for an upcoming change to permit returning multip
Author: ahatanak
Date: Wed Nov 11 20:41:56 2015
New Revision: 252849
URL: http://llvm.org/viewvc/llvm-project?rev=252849&view=rev
Log:
[AttrDocs] Insert blank lines before and after code-block directives.
The code snippets were not being displayed. This commit fixes the bug.
Modified:
cfe/tr
Currently, we inline a function only if the call to isInlineViable returns
true, which means there are cases where we don't inline functions marked
always_inline. Is there a reason we haven't made changes to produce any
diagnostic in those cases? The comment also says "should be inlined
whenever po
On Wed, Nov 11, 2015 at 6:08 PM Akira Hatanaka wrote:
> I think you are suggesting we change the inliner to produce a diagnostic
> (error or warning?) when the callee is marked always_inline and its
> function attributes are not compatible with the caller's
> (functionsHaveCompatibleAttributes re
I think you are suggesting we change the inliner to produce a diagnostic
(error or warning?) when the callee is marked always_inline and its
function attributes are not compatible with the caller's
(functionsHaveCompatibleAttributes returns false). Is that correct?
On Wed, Nov 11, 2015 at 4:48 PM,
On Wed, Nov 11, 2015 at 5:38 PM Richard Smith wrote:
> On Wed, Nov 11, 2015 at 5:25 PM, Eric Christopher
> wrote:
>
>> On Wed, Nov 11, 2015 at 5:03 PM Richard Smith
>> wrote:
>>
>>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
>>
On Wed, Nov 11, 2015 at 5:25 PM, Eric Christopher
wrote:
> On Wed, Nov 11, 2015 at 5:03 PM Richard Smith
> wrote:
>
>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: echristo
>>> Date: Wed Nov 11 18:44:12 2015
>>> New Revi
Author: kremenek
Date: Wed Nov 11 19:31:27 2015
New Revision: 252841
URL: http://llvm.org/viewvc/llvm-project?rev=252841&view=rev
Log:
Change code owner for Clang Static Analyzer to Anna Zaks.
Modified:
cfe/trunk/CODE_OWNERS.TXT
Modified: cfe/trunk/CODE_OWNERS.TXT
URL:
http://llvm.org/viewv
On Wed, Nov 11, 2015 at 5:13 PM David Blaikie wrote:
> On Wed, Nov 11, 2015 at 4:54 PM, David Blaikie wrote:
>
>>
>>
>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: echristo
>>> Date: Wed Nov 11 18:44:12 2015
>>> New Rev
On Wed, Nov 11, 2015 at 5:03 PM Richard Smith wrote:
> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Wed Nov 11 18:44:12 2015
>> New Revision: 252834
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=252834
On Wed, Nov 11, 2015 at 4:54 PM, David Blaikie wrote:
>
>
> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Wed Nov 11 18:44:12 2015
>> New Revision: 252834
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=2
Author: dblaikie
Date: Wed Nov 11 19:09:58 2015
New Revision: 252840
URL: http://llvm.org/viewvc/llvm-project?rev=252840&view=rev
Log:
Refactor out some common code from r252834
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL:
http
On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Nov 11 18:44:12 2015
> New Revision: 252834
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252834&view=rev
> Log:
> Provide a frontend based error for always_inli
On Wed, Nov 11, 2015 at 3:53 PM, Nathan Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nwilson
> Date: Wed Nov 11 17:53:35 2015
> New Revision: 252827
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252827&view=rev
> Log:
> Add diagnostics which fall under [dcl.spec.concept
On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Nov 11 18:44:12 2015
> New Revision: 252834
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252834&view=rev
> Log:
> Provide a frontend based error for always_inli
Author: akirtzidis
Date: Wed Nov 11 18:46:57 2015
New Revision: 252836
URL: http://llvm.org/viewvc/llvm-project?rev=252836&view=rev
Log:
[CMake] Setup an install component for libclang and c-index-test.
Also don't create libclang dylib symlinks on darwin.
Modified:
cfe/trunk/CMakeLists.txt
FWIW we should also have the backend avoid inlining and perhaps produce a
diagnostic if something makes it there as well.
-eric
On Wed, Nov 11, 2015 at 4:46 PM Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Nov 11 18:44:12 2015
> New Revision
Author: echristo
Date: Wed Nov 11 18:44:04 2015
New Revision: 252832
URL: http://llvm.org/viewvc/llvm-project?rev=252832&view=rev
Log:
In preparation to use it in more places rename
checkBuiltinTargetFeatures to checkTargetFeatures and sink
the error handling into the function.
Modified:
cfe/
Author: echristo
Date: Wed Nov 11 18:44:07 2015
New Revision: 252833
URL: http://llvm.org/viewvc/llvm-project?rev=252833&view=rev
Log:
Move checkTargetFeatures to CodeGenFunction.cpp to make it
more obvious that it's generic.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/Cod
Author: echristo
Date: Wed Nov 11 18:44:12 2015
New Revision: 252834
URL: http://llvm.org/viewvc/llvm-project?rev=252834&view=rev
Log:
Provide a frontend based error for always_inline functions that require
target features that the caller function doesn't provide. This matches
the existing backend
Dushistov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114
@@ +113,3 @@
+ printMethodNameWithPramaTypes(Out, C, FName, M,
false);
+ const std::string NS =
qtNormalizeSignature(Out.str());
+
On Wed, Nov 11, 2015 at 11:58:34PM +, Jonathan Roelofs wrote:
> jroelofs added a subscriber: jroelofs.
>
>
> Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114
> @@ +113,3 @@
> + printMethodNameWithPramaTypes(Out, C, FName, M,
> false)
On 11/11/15 5:01 PM, Akira Hatanaka via cfe-commits wrote:
ahatanak added a comment.
In http://reviews.llvm.org/D14471#287412, @rengolin wrote:
In http://reviews.llvm.org/D14471#286380, @ahatanak wrote:
I think I can use macro __aarch64__ to have getAArch64TargetCPU
return "native" when th
ahatanak added a comment.
Sorry, there were mistakes in my comments.
What I meant to say is that changing getAArch64TargetCPU to return "native"
would break the case where clang is being run on an aarch64 host. The current
code in trunk will get the host cpu name (which I believe is currently a
Author: vedantk
Date: Wed Nov 11 18:11:19 2015
New Revision: 252828
URL: http://llvm.org/viewvc/llvm-project?rev=252828&view=rev
Log:
[Basic] Fix DRY violation, just call getLineTable() (NFC)
Modified:
cfe/trunk/lib/Basic/SourceManager.cpp
Modified: cfe/trunk/lib/Basic/SourceManager.cpp
URL:
ahatanak added a comment.
In http://reviews.llvm.org/D14471#287412, @rengolin wrote:
> In http://reviews.llvm.org/D14471#286380, @ahatanak wrote:
>
> > I think I can use macro __aarch64__ to have getAArch64TargetCPU return
> > "native" when the compiler is not run on an AArch64 platform, but it
jroelofs added a subscriber: jroelofs.
Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114
@@ +113,3 @@
+ printMethodNameWithPramaTypes(Out, C, FName, M,
false);
+ const std::string NS =
qtNormalizeSignature(Out.str
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252827: Add diagnostics which fall under
[dcl.spec.concept]p5 (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D14352?vs=39386&id=39986#toc
Repository:
rL LLVM
http://reviews.
Author: nwilson
Date: Wed Nov 11 17:53:35 2015
New Revision: 252827
URL: http://llvm.org/viewvc/llvm-project?rev=252827&view=rev
Log:
Add diagnostics which fall under [dcl.spec.concept]p5
Summary: Diagnose when a function concept declaration has parameter(s)
Reviewers: rsmith, faisalv, aaron.bal
Dushistov updated this revision to Diff 39985.
Dushistov added a comment.
mistype, actually I want to use '&&' here, not '||' to not create std::string,
if match failed.
http://reviews.llvm.org/D14170
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/Inputs/qt-simulator.h
Dushistov created this revision.
Dushistov added reviewers: dcoughlin, Ayal, xazax.hun, zaks.anna.
Dushistov added a subscriber: cfe-commits.
In Qt 4/5 it is possible connect classes methods in such way:
connect(ObjectPointer1, SIGNAL(methodOfObject1()), ObjectPointer2,
SLOT(methodOfObject2());
Author: mren
Date: Wed Nov 11 17:08:18 2015
New Revision: 252820
URL: http://llvm.org/viewvc/llvm-project?rev=252820&view=rev
Log:
[TLS on Darwin] treat all Darwin platforms in the same way.
rdar://problem/9001553
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
cfe/trunk/lib/CodeGen/It
Author: echristo
Date: Wed Nov 11 17:05:08 2015
New Revision: 252819
URL: http://llvm.org/viewvc/llvm-project?rev=252819&view=rev
Log:
Extract out a function onto CodeGenModule for getting the map of
features for a particular function, then use it to clean up some
code.
Modified:
cfe/trunk/li
Hello everyone,
LLVM buildmaster will be updated restarted after 7 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mren
Date: Wed Nov 11 16:42:31 2015
New Revision: 252814
URL: http://llvm.org/viewvc/llvm-project?rev=252814&view=rev
Log:
[TLS on Darwin] change how we handle globals with linkonce or weak linkage.
This is about how we handle static member of a template. Before this commit,
we use intern
kkwli0 marked 13 inline comments as done.
kkwli0 added a comment.
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
I'm adept of consistency :-) It's also easier to fix all similar patterns in
code then do such cleanups selectively. Actually, similar fixes were made
recently in Decl.cpp when casts were involved, but not new.
Comment at: lib/AST/ASTContext.cpp
rsmith added a comment.
Why does this construct justify the compiler emitting a warning? It seems to be
reporting a fact about the code rather than a bug, and as there are many coding
styles where variables are not routinely marked as const whenever possible,
this appears to be checking that th
Author: cbieneman
Date: Wed Nov 11 15:53:08 2015
New Revision: 252809
URL: http://llvm.org/viewvc/llvm-project?rev=252809&view=rev
Log:
[CMake] Fixing passthrough for variables starting with COMPILER_RT
This allows COMPILER_RT_* variables to be passed from the top-level CMake into
the external p
Dushistov marked an inline comment as done.
Dushistov added a comment.
http://reviews.llvm.org/D14170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2068
@@ -2064,1 +2067,3 @@
def err_attribute_pointers_only : Error;
+def err_attribute_constant_pointers_only : Error<
+ "%0 attribute only applies to constant pointer arguments">;
--
tstellarAMD added a project: 3.7.1-merged.
Users:
hfinkel (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rjmccall (Auditor)
http://reviews.llvm.org/rL246882
___
cfe-commits mailing list
cfe-commits@lists
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD accepted this commit.
tstellarAMD added a comment.
r252808
Users:
hfinkel (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rjmccall (Auditor)
http://reviews.llvm.org/rL246882
___
gbedwell added a subscriber: gbedwell.
gbedwell added a comment.
> > Also, I am really curious to know why CryptAcquireContext fails in those
> > cases!
>
>
> Me too. Once is a fluke, twice is a trend. Probably some obscure
> system-resource problem but it would be nice to be sure.
I'm
aaron.ballman added a comment.
Modulo the question you and David are discussing about variable templates (for
which I don't have an answer handy), I just have a few small testing nits.
Comment at: test/SemaCXX/unique-instantiations.cpp:24
@@ +23,3 @@
+template struct foo5;
probinson closed this revision.
probinson marked an inline comment as done.
probinson added a comment.
r252800, thanks!
http://reviews.llvm.org/D14583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
probinson marked an inline comment as done.
probinson added a comment.
In http://reviews.llvm.org/D14583#287406, @bcraig wrote:
> Looks good to me, but since this is in the LLVMSupport library, you should
> probably add llvm-commits to the subscriber list.
Ah, right, I should have. But I'm not
Author: dcoughlin
Date: Wed Nov 11 14:39:03 2015
New Revision: 252797
URL: http://llvm.org/viewvc/llvm-project?rev=252797&view=rev
Log:
[analyzer] Fix scan-build to handle missing output directories.
Cwd::abs_path has a somewhat tricky semantics: if it's operand directory does
not exist,
it'll r
rengolin added a comment.
In http://reviews.llvm.org/D14471#286380, @ahatanak wrote:
> I think I can use macro __aarch64__ to have getAArch64TargetCPU return
> "native" when the compiler is not run on an AArch64 platform, but it doesn't
> sound like that was what you had in mind?
Not at all.
On 11/11/15 8:07 AM, Aaron Ballman wrote:
This change causes MSVC to have two new projects sitting at the root
of the solution: scan-build and scan-view, neither of which appear to
do anything. Are these projects required for IDEs? If they're
installation-only projects, I think the CMake should
On 11/11/15 11:13 AM, Aaron Ballman via cfe-commits wrote:
Author: aaronballman
Date: Wed Nov 11 12:13:42 2015
New Revision: 252771
URL: http://llvm.org/viewvc/llvm-project?rev=252771&view=rev
Log:
Hiding the scan-build and scan-view projects under the Misc folder in IDEs
instead of having th
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Also, I am really curious to know why CryptAcquireContext fails in those cases!
Comment at: lib/Support/Windows/Process.inc:421
@@ +420,3 @@
+/
bcraig added a subscriber: bcraig.
bcraig added a comment.
Looks good to me, but since this is in the LLVMSupport library, you should
probably add llvm-commits to the subscriber list.
http://reviews.llvm.org/D14583
___
cfe-commits mailing list
cfe-
klimek added a comment.
Jordan, your call :)
http://reviews.llvm.org/D13973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson created this revision.
probinson added a reviewer: aaron.ballman.
probinson added a subscriber: cfe-commits.
We've had two reports in the past year that CryptAcquireContextW failed; but
without the Windows error code it's hard to know what's going on.
http://reviews.llvm.org/D14583
F
mgehre added a comment.
I won't be able to do more about this issue than what the fix currently does (+
corrections/maybe a loop).
If this is not the preferred solution, and something more general should be
done,
I will abandon this patch for now.
Currently, I cannot work on a more general sol
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:19
@@ -18,1 +18,3 @@
+AST_MATCHER_P(CXXForRangeStmt, hasRangeBeginEndStmt,
+ ast_matchers::internal::Matcher, InnerMatcher) {
This same
Author: davide
Date: Wed Nov 11 14:06:35 2015
New Revision: 252793
URL: http://llvm.org/viewvc/llvm-project?rev=252793&view=rev
Log:
[SemaDeclCXX] Use isTemplateParamScope() rather than accessing raw bits.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.
mgehre created this revision.
mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Inside a range-based for-loop over an array, the compiler
generates pointer arithmetic (end = array + size). Don't flag this.
http://reviews.llvm.org/D14582
Files
mgehre updated this revision to Diff 39953.
mgehre added a comment.
simplify code
http://reviews.llvm.org/D13746
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cp
mgehre updated this revision to Diff 39952.
mgehre added a comment.
update for review comments; removed bounds check on static arrays in favor of
clang-diagnostic-array-bounds
http://reviews.llvm.org/D13746
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/Cpp
Author: lcharles
Date: Wed Nov 11 13:34:47 2015
New Revision: 252785
URL: http://llvm.org/viewvc/llvm-project?rev=252785&view=rev
Log:
[Lit Test] Updated 26 Lit tests to be C++11 compatible.
Expected diagnostics have been expanded to vary by C++ dialect.
RUN line has also been expanded to: defaul
> On Nov 11, 2015, at 11:16 AM, Hal Finkel wrote:
>
> It seems like I dropped the ball on this. Yes, I recall being fine with them
> otherwise.
Thanks Hal! I’ll rebase the patches and land them over the next day or two.
Thanks,
Pete
>
> Thanks again,
> Hal
__
Author: mren
Date: Wed Nov 11 13:19:26 2015
New Revision: 252777
URL: http://llvm.org/viewvc/llvm-project?rev=252777&view=rev
Log:
[TLS] move setting tls_guard in tls_init.
We used to emit the store prior to branch in the entry block. To make it more
efficient, this commit moves it to the init bl
- Original Message -
> From: "Pete Cooper"
> To: "Hal Finkel"
> Cc: "Lang Hames" , "LLVM Commits"
> , cfe-commits@lists.llvm.org
> Sent: Monday, September 28, 2015 12:46:36 PM
> Subject: Re: [PATCH] Change memcpy/memmove/memset to have dest and
> source alignment
> Hey Hal
> Thanks for
mgehre updated this revision to Diff 39948.
mgehre added a comment.
Update for review comments
http://reviews.llvm.org/D14517
Files:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h
test/clang-tidy/cppcoreg
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D14200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tstellarAMD raised a concern with this commit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL244063
_
tstellarAMD resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL244063
___
cfe-co
dcoughlin added a comment.
Gabor,
This is an alpha checker. Do you anticipate turning it on by default?
Comments inline.
Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:28
@@ -24,1 +27,3 @@
namespace {
+enum class AllocKind {
+ SingletonNew,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252773: Fix bug in suggested fix that truncated variable
names to 1 character. (authored by sbenza).
Changed prior to commit:
http://reviews.llvm.org/D13899?vs=37885&id=39944#toc
Repository:
rL LLVM
Author: sbenza
Date: Wed Nov 11 12:40:36 2015
New Revision: 252773
URL: http://llvm.org/viewvc/llvm-project?rev=252773&view=rev
Log:
Fix bug in suggested fix that truncated variable names to 1 character.
Summary:
Fix bug in suggested fix that truncated variable names to 1 character.
Also, rework
zaks.anna added a comment.
> Just for the sake of explaining, lets say in 3 subsequent Analyzer releases
> the hashes are called “hash_1”, “hash_2” and “hash_3”.
> In the first release the suppression tool will record hash_1 to suppress a
> warning. Some developers will upgrade to the second
tyomitch created this revision.
tyomitch added a reviewer: rengolin.
tyomitch added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Clang-side update, corresponding to D14577
http://reviews.llvm.org/D14578
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
Author: aaronballman
Date: Wed Nov 11 12:13:42 2015
New Revision: 252771
URL: http://llvm.org/viewvc/llvm-project?rev=252771&view=rev
Log:
Hiding the scan-build and scan-view projects under the Misc folder in IDEs
instead of having them at the root view.
Modified:
cfe/trunk/tools/scan-build/
> Why isn't this just part of D14568?
It's in the other repository.
From: James Molloy [mailto:ja...@jamesmolloy.co.uk]
Sent: 11 November 2015 12:42
To: reviews+d14570+public+1de1f7f06e3d3...@reviews.llvm.org; Artyom Skrobov;
renato.go...@linaro.org; jo...@netbsd.org; Bernard Ogden
jroelofs added a comment.
In http://reviews.llvm.org/D14293#287174, @rmaprath wrote:
> Would it be OK if I commit the x86 buildbot changes (Dmitri approved these
> earlier) while the ARM buildbot changes are being reviewed? I suppose the
> changes would only take effect once @gkistanova restart
rmaprath added a comment.
Would it be OK if I commit the x86 buildbot changes (Dmitri approved these
earlier) while the ARM buildbot changes are being reviewed? I suppose the
changes would only take effect once @gkistanova restarts/reconfigs the
build-master ?
Cheers,
- Asiri
http://reviews
aaron.ballman added a comment.
In http://reviews.llvm.org/D12547#287153, @ahatanak wrote:
> Marking virtual functions as disable_tail_calls is fine since
> disable_tail_calls affects the call sites inside the body of the marked
> function. In your example, it prevents tail call optimization on
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Would you mind re-uploading this patch as a diff against upstream trunk with
full context?
http://reviews.llvm.org/D9600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
ahatanak added a comment.
Marking virtual functions as disable_tail_calls is fine since
disable_tail_calls affects the call sites inside the body of the marked
function. In your example, it prevents tail call optimization on call sites
inside B::g, but doesn't affect call sites in D::g.
http:
aaron.ballman added a comment.
Missing tests demonstrating use of the C++ spelling of the attribute. Perhaps a
test showing it on a member function would be useful.
Out of curiosity, what would be the expected behavior of the following:
struct B {
int g(int);
[[clang::disable_tail_cal
seaneveson added a comment.
In http://reviews.llvm.org/D10305#286385, @zaks.anna wrote:
> The reason I like names more than the numbers is that we may use different
> solutions for issue hash generation and some users might prefer one over the
> other. It is not necessarily clear which one is t
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:11
@@ +10,3 @@
+#include "MoveConstantArgumentCheck.h"
+
+namespace clang {
> I didn't find how it can be done, could you please advice?
This is the usual way we do it
aaron.ballman added inline comments.
Comment at: lib/AST/ASTContext.cpp:3857
@@ -3856,4 +3856,3 @@
void *Mem = Allocate(sizeof(ObjCObjectPointerType), TypeAlignment);
- ObjCObjectPointerType *QType =
-new (Mem) ObjCObjectPointerType(Canonical, ObjectT);
+ auto *QType = ne
aaron.ballman added a comment.
In http://reviews.llvm.org/D14560#286819, @hans wrote:
> Like the other patch, I'm not sure that using auto in all these places help
> readability.
I share these concerns.
Repository:
rL LLVM
http://reviews.llvm.org/D14560
aaron.ballman added inline comments.
Comment at: include/clang/AST/ASTVector.h:385
@@ -383,3 +384,3 @@
// Allocate the memory from the ASTContext.
- T *NewElts = new (C, llvm::alignOf()) T[NewCapacity];
+ auto *NewElts = new (C, llvm::alignOf()) T[NewCapacity];
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25
@@ +24,3 @@
+template
+static CharSourceRange removeNode(const MatchFinder::MatchResult &Result,
+ const T *PrevNode, const T *Node,
sbe
sbenza added inline comments.
Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25
@@ +24,3 @@
+template
+static CharSourceRange removeNode(const MatchFinder::MatchResult &Result,
+ const T *PrevNode, const T *Node,
aaron.ball
This change causes MSVC to have two new projects sitting at the root
of the solution: scan-build and scan-view, neither of which appear to
do anything. Are these projects required for IDEs? If they're
installation-only projects, I think the CMake should be guarded with
`if(NOT CMAKE_CONFIGURATION_T
alexfh added a comment.
Sorry for the delay. A few more comments.
Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:86
@@ +85,3 @@
+ if (!IndexExpr->isIntegerConstantExpr(Index, *Result.Context, nullptr,
+true)
Author: aaronballman
Date: Wed Nov 11 07:42:02 2015
New Revision: 252727
URL: http://llvm.org/viewvc/llvm-project?rev=252727&view=rev
Log:
Silencing a -Wreturn-type warning for control reaching the end of a non-void
function.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib
pxli168 added a subscriber: pxli168.
Comment at: test/CodeGenOpenCL/pipe_types.cl:5
@@ +4,3 @@
+
+void test1(read_only pipe int p) {
+// CHECK: define void @test1(%opencl.pipe_t* %p)
Great work!!
But I have tried your patch and find it does not support opencl gent
Hi Artyom,
Why isn't this just part of D14568?
Cheers,
James
On Wed, 11 Nov 2015 at 12:08 A. Skrobov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> tyomitch created this revision.
> tyomitch added reviewers: rengolin, joerg, bogden.
> tyomitch added a subscriber: cfe-commits.
> Herald
1 - 100 of 108 matches
Mail list logo