Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak added a comment. > If you can get the CPU name, return it. If not, return "native". If you're on > AArch64 and you can't get the CPU name, that's a bug that needs fixing. If > it's always "generic", that's another piece of code that needs fixing. If > whatever getCPU function you use d

r253016 - scan-build: Fix install.

Author: chapuni Date: Fri Nov 13 00:48:02 2015 New Revision: 253016 URL: http://llvm.org/viewvc/llvm-project?rev=253016&view=rev Log: scan-build: Fix install. Modified: cfe/trunk/tools/scan-build/CMakeLists.txt Modified: cfe/trunk/tools/scan-build/CMakeLists.txt URL: http://llvm.org/viewvc/

r253013 - [Sema] __is_constructible should return false for function types

Author: majnemer Date: Thu Nov 12 23:32:43 2015 New Revision: 253013 URL: http://llvm.org/viewvc/llvm-project?rev=253013&view=rev Log: [Sema] __is_constructible should return false for function types While functions types are complete, they cannot be constructed. This fixes PR25513. Modified:

r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

Author: rsmith Date: Thu Nov 12 23:14:45 2015 New Revision: 253012 URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev Log: [modules] When a declaration has non-trivial visibility, check whether it's actually hidden before we check its linkage. This avoids computing the linkage "too early

r253011 - clang/test/Driver/mips-mti-linux.c: Tweak to match DOSish paths.

Author: chapuni Date: Thu Nov 12 22:44:51 2015 New Revision: 253011 URL: http://llvm.org/viewvc/llvm-project?rev=253011&view=rev Log: clang/test/Driver/mips-mti-linux.c: Tweak to match DOSish paths. Modified: cfe/trunk/test/Driver/mips-mti-linux.c Modified: cfe/trunk/test/Driver/mips-mti-lin

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 40105. nwilson added a comment. - Remove marking a variable concept invalid when specialized since we'll only look at the primary template downstream. This removal let's us use the same recovery path as before when 'concept' is specified on a non-template.

r253010 - [modules] Follow the C++ standard's rule for linkage of enumerators: they have

Author: rsmith Date: Thu Nov 12 21:52:13 2015 New Revision: 253010 URL: http://llvm.org/viewvc/llvm-project?rev=253010&view=rev Log: [modules] Follow the C++ standard's rule for linkage of enumerators: they have the linkage of the enumeration. For enumerators of unnamed enumerations, extend the -W

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

I assume you are referring to the install-c-index-test target, this should not be added to IDEs after r253001. > On Nov 12, 2015, at 7:29 AM, Aaron Ballman wrote: > > Is this target needed by IDEs? It currently adds the target to the > root level of the solution in MSVC. > > ~Aaron > > On Wed

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

Thanks for pointing it out. r253001 sets up the destination to a different location only if ‘INTERNAL_INSTALL_PREFIX’ is set. > On Nov 12, 2015, at 5:50 AM, Ismail Donmez wrote: > > Fixed in r252890 > > On Thu, Nov 12, 2015 at 2:17 PM, Ismail Donmez > wrote: > Hi, > >

r253001 - [CMake] If 'INTERNAL_INSTALL_PREFIX' is set, use it for determining the install destination of c-index-test and the libclang headers.

Author: akirtzidis Date: Thu Nov 12 19:46:18 2015 New Revision: 253001 URL: http://llvm.org/viewvc/llvm-project?rev=253001&view=rev Log: [CMake] If 'INTERNAL_INSTALL_PREFIX' is set, use it for determining the install destination of c-index-test and the libclang headers. Modified: cfe/trunk/C

r252991 - Fix build

Author: jroelofs Date: Thu Nov 12 19:23:40 2015 New Revision: 252991 URL: http://llvm.org/viewvc/llvm-project?rev=252991&view=rev Log: Fix build Modified: cfe/trunk/tools/scan-view/CMakeLists.txt Modified: cfe/trunk/tools/scan-view/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

On Wed, Nov 11, 2015 at 10:11 PM, Daniel Marjamäki < daniel.marjam...@evidente.se> wrote: > danielmarjamaki added a comment. > > In http://reviews.llvm.org/D12359#287522, @rsmith wrote: > > > Why does this construct justify the compiler emitting a warning? It > seems to be reporting a fact about t

Re: [PATCH] D13388: Add support for querying the visibility of a cursor

michaelwu updated this revision to Diff 40100. michaelwu added a comment. This removes the test for protected visibility and improves documentation for clang_getCursorVisibility. http://reviews.llvm.org/D13388 Files: include/clang-c/Index.h test/Index/symbol-visibility.c tools/c-index-te

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

This revision was automatically updated to reflect the committed changes. Closed by commit rL252986: Add support for function attribute 'disable_tail_calls'. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D12547?vs=40060&id=40099#toc Repository: rL LLVM http://revi

r252986 - Add support for function attribute 'disable_tail_calls'.

Author: ahatanak Date: Thu Nov 12 18:42:21 2015 New Revision: 252986 URL: http://llvm.org/viewvc/llvm-project?rev=252986&view=rev Log: Add support for function attribute 'disable_tail_calls'. The ``disable_tail_calls`` attribute instructs the backend to not perform tail call optimization inside t

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. > The reason to squash all your patches together is that partial diffs from a > patch series don't work well with Phabricator's "Revision Update History" > tool. Also, it makes it hard to pull out a patch that I can apply on my local > tree to try it out.

r252981 - [scan-build] Create share directory similar to scan-view's

Author: jroelofs Date: Thu Nov 12 18:32:54 2015 New Revision: 252981 URL: http://llvm.org/viewvc/llvm-project?rev=252981&view=rev Log: [scan-build] Create share directory similar to scan-view's Added: cfe/trunk/tools/scan-build/share/ cfe/trunk/tools/scan-build/share/scanview.css -

r252977 - [scan-view] Rename 'Resources' --> 'share'

Author: jroelofs Date: Thu Nov 12 18:25:04 2015 New Revision: 252977 URL: http://llvm.org/viewvc/llvm-project?rev=252977&view=rev Log: [scan-view] Rename 'Resources' --> 'share' Added: cfe/trunk/tools/scan-view/share/ - copied from r252671, cfe/trunk/tools/scan-view/Resources/ Removed:

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a comment. Actually, now that I think about it more, `scan-build.cfg` doesn't belong in share at all. The location of an instance of it should be read in via a command-line argument, and it shouldn't be installed. http://reviews.llvm.org/D14629 ___

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a comment. Also, how is this different from `-analyzer-config`? http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14467: [MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I went ahead and ran some of your test cases through MSVC, and I agree with your results. This is pretty interesting behavior. Thanks for looking into it! Looks good. Comment at:

r252972 - clang/test/Driver/mips-mti-linux.c: Remove XFAIL. It shouldn't fail for targeting win32.

Author: chapuni Date: Thu Nov 12 17:56:37 2015 New Revision: 252972 URL: http://llvm.org/viewvc/llvm-project?rev=252972&view=rev Log: clang/test/Driver/mips-mti-linux.c: Remove XFAIL. It shouldn't fail for targeting win32. I will remove REQUIRES later. Modified: cfe/trunk/test/Driver/mips-m

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

jroelofs added a subscriber: jroelofs. jroelofs added a comment. `CommonStuff.pm` (which could stand to have a more descriptive name, `libscanbuild.pm` maybe?) and `scan-build.cfg` belong in `share`. http://reviews.llvm.org/D14629 ___ cfe-commits m

[PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev created this revision. ayartsev added a reviewer: zaks.anna. ayartsev added subscribers: jordan_rose, krememek, sylvestre.ledru, cfe-commits. A simple INI configuration file for scan-build with options - aliases to scan-build command line arguments. This configuration file can be used to

r252971 - Remove -Wobjc-weak-compat; there isn't a compelling use case for this.

Author: rjmccall Date: Thu Nov 12 17:39:39 2015 New Revision: 252971 URL: http://llvm.org/viewvc/llvm-project?rev=252971&view=rev Log: Remove -Wobjc-weak-compat; there isn't a compelling use case for this. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/S

r252967 - Avoid duplicated diagnostic when lookup for a nested-name-specifier fails due to ambiguity.

Author: rsmith Date: Thu Nov 12 16:40:09 2015 New Revision: 252967 URL: http://llvm.org/viewvc/llvm-project?rev=252967&view=rev Log: Avoid duplicated diagnostic when lookup for a nested-name-specifier fails due to ambiguity. Modified: cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp cfe/trunk/tes

r252961 - Mark clang/test/Driver/ms-bitfields.c as REQUIRES:clang-driver.

Author: chapuni Date: Thu Nov 12 16:25:38 2015 New Revision: 252961 URL: http://llvm.org/viewvc/llvm-project?rev=252961&view=rev Log: Mark clang/test/Driver/ms-bitfields.c as REQUIRES:clang-driver. Modified: cfe/trunk/test/Driver/ms-bitfields.c Modified: cfe/trunk/test/Driver/ms-bitfields.c

r252960 - [modules] Simplify and generalize the existing rule for finding hidden

Author: rsmith Date: Thu Nov 12 16:19:45 2015 New Revision: 252960 URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev Log: [modules] Simplify and generalize the existing rule for finding hidden declarations in redeclaration lookup. A declaration is now visible to lookup if: * It is vis

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. One inline comment then OK for now. -eric Comment at: lib/Driver/Tools.cpp:3227-3240 @@ -3226,2 +3226,16 @@ + if (IsCuda) { +const ToolChain *AuxToolChain; +if

Re: [PATCH] D13170: [CUDA] Driver changes to pass flags needed to use detected CUDA installation.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This needs a very long commit message describing exactly what's going on and why since it's not documented anywhere. Possibly in the code as well at AddPreprocessingOptions and other place

Re: [PATCH] D14556: [CUDA] Detect and link with CUDA's libdevice bitcode library.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. A couple of inline comments, but this is fine for now. We need a command line option to select CUDA version as well. -eric Comment at: lib/Driver/ToolChains.cpp:1635 @@

r252959 - DR407: Rationalize how we handle tags being hidden by typedefs. Even with

Author: rsmith Date: Thu Nov 12 16:04:34 2015 New Revision: 252959 URL: http://llvm.org/viewvc/llvm-project?rev=252959&view=rev Log: DR407: Rationalize how we handle tags being hidden by typedefs. Even with DR407, the C++ standard doesn't really say how this should work. Here's what we do (which i

r252957 - Revert r240335.

Author: rsmith Date: Thu Nov 12 15:55:58 2015 New Revision: 252957 URL: http://llvm.org/viewvc/llvm-project?rev=252957&view=rev Log: Revert r240335. This failed to solve the problem it was aimed at, and introduced just as many issues as it resolved. Realistically, we need to deal with the possibi

r252955 - Additional tests from r252690 that I forgot to 'svn add'.

Author: rsmith Date: Thu Nov 12 15:42:39 2015 New Revision: 252955 URL: http://llvm.org/viewvc/llvm-project?rev=252955&view=rev Log: Additional tests from r252690 that I forgot to 'svn add'. From a patch by Nicholas Allegra! Added: cfe/trunk/test/Sema/auto-type.c cfe/trunk/test/SemaCXX/a

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

ahatanak marked an inline comment as done. ahatanak added a comment. I'll commit this patch shortly. Thank you for the review. http://reviews.llvm.org/D12547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

On Thu, Nov 12, 2015 at 11:11 AM, David Blaikie wrote: > > > On Thu, Nov 12, 2015 at 6:36 AM, Aaron Ballman via cfe-commits > wrote: >> >> aaron.ballman added inline comments. >> >> >> Comment at: lib/AST/ASTContext.cpp:7930 >> @@ -7931,3 +7929,3 @@ >> >> -ASTMutationListener::~A

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D12547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman marked an inline comment as done. Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:37 @@ +36,3 @@ +} // end namespace + +namespace tidy { Your slight preference is my firmest desire! :-P Seriously, I think the code is more clear after implem

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman updated this revision to Diff 40078. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Addressing review comments. http://reviews.llvm.org/D14619 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ThrownExcep

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim added a comment. Note that http://reviews.llvm.org/rL252920 does not apply to 3.7 cleanly, a few minor modifications are needed. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith (Au

RE: r252834 - Provide a frontend based error for always_inline functions that require

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Eric Christopher via cfe-commits > Sent: Wednesday, November 11, 2015 4:44 PM > To: cfe-commits@lists.llvm.org > Subject: r252834 - Provide a frontend based error for always_inline > functi

Re: [PATCH] D14441: [OpenCL] Pipe types support.

pekka.jaaskelainen accepted this revision. This revision is now accepted and ready to land. Comment at: include/clang/Serialization/ASTBitCodes.h:911 @@ +910,3 @@ + TYPE_ADJUSTED = 42, + /// \brief An PipeType record. + TYPE_PIPE = 43 -

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

bcraig added a comment. Looks good to me. http://reviews.llvm.org/D14619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [Diffusion] rL244063: Add missing atomic libcall support.

jyknight added a comment. The concerns should be fixed by the followup commit http://reviews.llvm.org/rL252920. If merging to 3.7 branch, both revisions will need to be included. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compn

Re: [PATCH] D14385: Correct atomic libcall support for __atomic_*_fetch builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252920: Correct atomic libcall support for __atomic_*_fetch builtins. (authored by jyknight). Changed prior to commit: http://reviews.llvm.org/D14385?vs=39644&id=40068#toc Repository: rL LLVM http:/

r252920 - Correct atomic libcall support for __atomic_*_fetch builtins.

Author: jyknight Date: Thu Nov 12 12:37:29 2015 New Revision: 252920 URL: http://llvm.org/viewvc/llvm-project?rev=252920&view=rev Log: Correct atomic libcall support for __atomic_*_fetch builtins. In r244063, I had caused these builtins to call the same-named library functions, __atomic_*_fetch_S

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

alexfh added inline comments. Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:36 @@ +35,3 @@ + bool Diag = false; + for (const auto *Ctor : RD->ctors()) { +if (Ctor->isCopyConstructor()) { I'd slightly prefer this check to be expressed as a matcher:

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

jordan_rose added a comment. So we just throw out the whole notion of "metadata in use"? That can work. There are two things I'd be concerned about changing here: - What happens when you take a string's length, test it against something, throw it away, then remeasure the string? In this case we

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Let's just go with your simple version that makes the common case better. There are a lot of problems with `throw`, so I wouldn't worry about that right now. (By the way, we don't re

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman marked an inline comment as done. Comment at: test/clang-tidy/cert-throw-exception-type.cpp:2 @@ +1,3 @@ +// RUN: %check_clang_tidy %s cert-err60-cpp %t -- -- -std=c++11 -fcxx-exceptions + +struct S {}; > Doesn't this need an "| FileCheck %s" No, c

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman updated this revision to Diff 40064. aaron.ballman added a comment. Added new test cases http://reviews.llvm.org/D14619 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ThrownExceptionTypeCheck.cpp clang-tidy/cert/ThrownExceptionType

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

bcraig added a subscriber: bcraig. bcraig added a comment. I would love to see a test case with dynamic allocation. Something along the following... struct Allocates { int *x; Allocates() : x(new int(0)) {} Allocates(const Allocates &other) : x(new int(*other.x)) {} }; ... and then the

r252912 - Add support for driver option -mno-ms-bitfields.

Author: ahatanak Date: Thu Nov 12 11:21:22 2015 New Revision: 252912 URL: http://llvm.org/viewvc/llvm-project?rev=252912&view=rev Log: Add support for driver option -mno-ms-bitfields. This option is used to cancel -mms-bitfields on the command line. rdar://problem/15898553 Added: cfe/trunk/

Re: [PATCH] D14441: [OpenCL] Pipe types support.

bader updated this revision to Diff 40058. bader marked 13 inline comments as done. bader added a comment. Applied code review comments. http://reviews.llvm.org/D14441 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/RecursiveASTVisitor.h

[PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, sbenza. aaron.ballman added a subscriber: cfe-commits. This patch adds a new clang-tidy checker that flags throw expressions whose thrown type is not nothrow copy constructible. While the compiler is free to elide copy c

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

ahatanak updated this revision to Diff 40060. ahatanak marked 2 inline comments as done. ahatanak added a comment. Added "expected-no-diagnostics" to test case. http://reviews.llvm.org/D12547 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CGCall.cpp lib/S

Re: [PATCH] D14441: [OpenCL] Pipe types support.

bader added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1426 @@ +1425,3 @@ +struct PipeTypeInfo : TypeInfoCommon { +/// The access writes. +unsigned AccessWrites : 3; pekka.jaaskelainen wrote: > I think this needs a better comment than d

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

seaneveson added a comment. > If you have multiple users using a bug suppression system, I would design > such system using only a single hash version across all users; using a mix > seems error prone.. Once all of your users upgrade to a version of the > analyzer where a new hash version is av

Re: [PATCH] D14570: Handle ARMv6KZ naming

compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Wow, this is tricky: the code change is in LLVM, and test change in clang :(. However, this does seem to preserv

Re: r252872 - Update clang regression tests for 'norecurse'

Hi David, Honestly, I really don't know. I just updated them due to a change in LLVM - I hadn't considered doing an audit. James On Thu, 12 Nov 2015 at 16:08 David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Nov 12, 2015 at 2:56 AM, James Molloy via cfe-commits < > cf

Re: r252872 - Update clang regression tests for 'norecurse'

On Thu, Nov 12, 2015 at 2:56 AM, James Molloy via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jamesm > Date: Thu Nov 12 04:56:51 2015 > New Revision: 252872 > > URL: http://llvm.org/viewvc/llvm-project?rev=252872&view=rev > Log: > Update clang regression tests for 'norecurse' > > Fu

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

On Thu, Nov 12, 2015 at 6:36 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aaron.ballman added inline comments. > > > Comment at: lib/AST/ASTContext.cpp:7930 > @@ -7931,3 +7929,3 @@ > > -ASTMutationListener::~ASTMutationListener() { } > +ASTMutationListe

Re: [PATCH] D14578: Cull non-standard variants of ARM architectures (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL252904: Cull non-standard variants of ARM architectures (NFC) (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14578?vs=39943&id=40052#toc Repository: rL LLVM http://reviews

[libcxx] r252905 - Implement P0074: Making owner_less more flexible

Author: marshall Date: Thu Nov 12 09:56:44 2015 New Revision: 252905 URL: http://llvm.org/viewvc/llvm-project?rev=252905&view=rev Log: Implement P0074: Making owner_less more flexible Modified: libcxx/trunk/include/memory libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr

r252904 - Cull non-standard variants of ARM architectures (NFC)

Author: askrobov Date: Thu Nov 12 09:52:02 2015 New Revision: 252904 URL: http://llvm.org/viewvc/llvm-project?rev=252904&view=rev Log: Cull non-standard variants of ARM architectures (NFC) Summary: Clang-side update, corresponding to D14577 Reviewers: rengolin Subscribers: aemerson, cfe-commits

Re: [PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

jmolloy updated this revision to Diff 40050. jmolloy added a comment. Hi Aaron, Thanks, this should all be fixed now. Cheers, James Repository: rL LLVM http://reviews.llvm.org/D14615 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenCXX/main-norecurse.cpp test/CodeGenObjC/objc-lite

Re: [PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

jmolloy closed this revision. jmolloy added a comment. Thanks Aaron, committed in r252902. Repository: rL LLVM http://reviews.llvm.org/D14615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D14570: Handle ARMv6KZ naming

tyomitch added a comment. In http://reviews.llvm.org/D14570#288022, @joerg wrote: > The specific CPU was only chosen to match what the backend supported at the > time. As long as the feature set is identical, it doesn't really matter. The feature set isn't quite identical; default ARMv6 CPU fo

r252902 - [C++] Add the "norecurse" attribute to main() if in C++ mode

Author: jamesm Date: Thu Nov 12 09:36:04 2015 New Revision: 252902 URL: http://llvm.org/viewvc/llvm-project?rev=252902&view=rev Log: [C++] Add the "norecurse" attribute to main() if in C++ mode The C++ spec (3.6.1.3) says "The function `main` shall not be used within a program". This implies tha

Re: [PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

aaron.ballman added a comment. Yup. LG, thanks! Repository: rL LLVM http://reviews.llvm.org/D14615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. After fixing the FileCheck and grammar issues, LGTM! Repository: rL LLVM http://reviews.llvm.org/D14615 ___ cfe-commits mailing

[PATCH] D14616: [libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

rmaprath created this revision. rmaprath added reviewers: EricWF, jroelofs, mclow.lists, rengolin. rmaprath added a subscriber: cfe-commits. The macro TEST_HAS_NO_EXCEPTIONS seems to be defined very similar to _LIBCPP_NO_EXCEPTIONS, I'm thinking of getting rid of the former as the latter is more

Re: [PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

aaron.ballman added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:721 @@ +720,3 @@ + // to be norecurse by the standard (3.6.1.3 "The function main shall not be + // used within a program") + if (getLangOpts().CPlusPlus) Missing a period at the e

Re: [PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

jmolloy added inline comments. Comment at: test/CodeGenCXX/main-norecurse.cpp:1 @@ +1,2 @@ +// RUN: %clang_cc1 -emit-llvm %s -o - + Wow, I managed to forget in my copy-paste from another test to add "| FileCheck %s" here. I'll update this before committing. Re

[PATCH] D14615: [C++] Add the "norecurse" attribute to main() if in C++ mode

jmolloy created this revision. jmolloy added a reviewer: aaron.ballman. jmolloy added a subscriber: cfe-commits. jmolloy set the repository for this revision to rL LLVM. The C++ spec (3.6.1.3) says "The function `main` shall not be used within a program". This implies that it cannot recurse, so a

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

Is this target needed by IDEs? It currently adds the target to the root level of the solution in MSVC. ~Aaron On Wed, Nov 11, 2015 at 7:46 PM, Argyrios Kyrtzidis via cfe-commits wrote: > Author: akirtzidis > Date: Wed Nov 11 18:46:57 2015 > New Revision: 252836 > > URL: http://llvm.org/viewvc/ll

r252901 - Re-recommit: Add support for the new mips-mti-linux toolchain.

Author: vkalintiris Date: Thu Nov 12 09:26:54 2015 New Revision: 252901 URL: http://llvm.org/viewvc/llvm-project?rev=252901&view=rev Log: Re-recommit: Add support for the new mips-mti-linux toolchain. Last time, this caused two Windows buildbots and a single ARM buildbot to fail. I XFAIL'd the fa

r252900 - Silencing an MSVC warning about linkage specifications and C-incompatible UDTs by moving a function definition out of an extern "C" block.

Author: aaronballman Date: Thu Nov 12 09:25:06 2015 New Revision: 252900 URL: http://llvm.org/viewvc/llvm-project?rev=252900&view=rev Log: Silencing an MSVC warning about linkage specifications and C-incompatible UDTs by moving a function definition out of an extern "C" block. Modified: cfe/

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. If you you're familiar with git, I'm asking you to: squash, rebase, and `git diff -U999`, then upload the resulting patch. If you use svn, I'm asking you to: `svn diff -r$(FirstCommit):$(LastCommit) --diff-cmd=diff -x -U999`, and upload that. The reason to squash all

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

aaron.ballman added inline comments. Comment at: lib/AST/ASTContext.cpp:7930 @@ -7931,3 +7929,3 @@ -ASTMutationListener::~ASTMutationListener() { } +ASTMutationListener::~ASTMutationListener() = default; Eugene.Zelenko wrote: > aaron.ballman wrote: > > This is

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

aaron.ballman added inline comments. Comment at: test/SemaCXX/attr-disable-tail-calls.cpp:2 @@ +1,3 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only %s + +class B { Is this file missing an expected-no-diagnostics? http://reviews.llvm.org/D12547 ___

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one comment. Thank you! Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:107 @@ +106,3 @@ +diag(Matched->getExprLoc(), +

Re: [PATCH] D14517: Fix bug 25362 "cppcoreguidelines-pro-bounds-array-to-pointer-decay does not consider const"

alexfh added a comment. Still LG. http://reviews.llvm.org/D14517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki updated this revision to Diff 40040. danielmarjamaki added a comment. Moved NonConstUse from VarDecl to ParmVarDecl to avoid waste of memory http://reviews.llvm.org/D12359 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/Diagnosti

Re: [PATCH] D14570: Handle ARMv6KZ naming

joerg added a comment. The specific CPU was only chosen to match what the backend supported at the time. As long as the feature set is identical, it doesn't really matter. http://reviews.llvm.org/D14570 ___ cfe-commits mailing list cfe-commits@list

r252890 - Fix c-index-test install path

Author: ismail Date: Thu Nov 12 07:47:35 2015 New Revision: 252890 URL: http://llvm.org/viewvc/llvm-project?rev=252890&view=rev Log: Fix c-index-test install path Modified: cfe/trunk/tools/c-index-test/CMakeLists.txt Modified: cfe/trunk/tools/c-index-test/CMakeLists.txt URL: http://llvm.org

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

Fixed in r252890 On Thu, Nov 12, 2015 at 2:17 PM, Ismail Donmez wrote: > Hi, > > On Thu, Nov 12, 2015 at 2:46 AM, Argyrios Kyrtzidis via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> --- cfe/trunk/tools/c-index-test/CMakeLists.txt (original) >> +++ cfe/trunk/tools/c-index-test/CMakeLis

Re: [PATCH] D14582: [clang-tidy] cppcoreguidelines-pro-bounds-pointer-arithmetic: ignore generated pointer arithmetic

alexfh added a comment. It may be more effective to filter out expressions that operate on implicit variables, e.g. by adding this constraint to the binaryOperator matcher: unless(hasLHS(ignoringImpCasts(declRefExpr(to(isImplicit()) (maybe also for RHS). The benefit of this would be that

[PATCH] D14609: [ARM,AArch64] Fix __rev16l and __rev16ll intrinsics

olista01 created this revision. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. These two intrinsics are defined in arm_acle.h. __rev16l needs to rotate by 16 bits, bit it was actually rotating b

Re: r252836 - [CMake] Setup an install component for libclang and c-index-test.

Hi, On Thu, Nov 12, 2015 at 2:46 AM, Argyrios Kyrtzidis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > --- cfe/trunk/tools/c-index-test/CMakeLists.txt (original) > +++ cfe/trunk/tools/c-index-test/CMakeLists.txt Wed Nov 11 18:46:57 2015 > @@ -28,3 +28,12 @@ if (CLANG_HAVE_LIBXML) >inc

r252872 - Update clang regression tests for 'norecurse'

Author: jamesm Date: Thu Nov 12 04:56:51 2015 New Revision: 252872 URL: http://llvm.org/viewvc/llvm-project?rev=252872&view=rev Log: Update clang regression tests for 'norecurse' FunctionAttrs has just been taught how to infer 'norecurse'. Update clang tests for LLVM r252871. Modified: cfe/

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#287635, @ahatanak wrote: > I didn't include a test case because I didn't know how to write a test that > passes on an aarch64 host and fails on anything else. Do you know of any test > cases in trunk that pass or fail depending on whic

[libcxx] r252870 - [libcxx] Fixup a few fumbles in the initial no-exceptions XFAILs list.

Author: asiri Date: Thu Nov 12 04:41:57 2015 New Revision: 252870 URL: http://llvm.org/viewvc/llvm-project?rev=252870&view=rev Log: [libcxx] Fixup a few fumbles in the initial no-exceptions XFAILs list. The initial buildbot run found a few missing bits in the initial XFAIL list for the no-excepti

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/PointerArithChecker.cpp:28 @@ -24,1 +27,3 @@ namespace { +enum class AllocKind { + SingletonNew, dcoughlin wrote: > Is it necessary to distinguish so many cases here? For example, why do we

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added a comment. In http://reviews.llvm.org/D14203#287303, @dcoughlin wrote: > Gabor, > > This is an alpha checker. Do you anticipate turning it on by default? > > Comments inline. I could see two kinds of false positives with this checker when running this on the LLVM codebase. Whe

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. In http://reviews.llvm.org/D9600#287157, @jroelofs wrote: > Would you mind re-uploading this patch as a diff against upstream trunk with > full context? i'm not sure i do understand what do you ask. i wish i could upload these changes as a single patch, b