Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. Thanks for re-uploading! Comment at: tools/scan-build-py/README.md:39 @@ +38,3 @@ + +$ python setup.py build +$ python setup.py install Mind adding a CMakeLists.txt to drive these from the clang build itself?

r253207 - Handle ARMv6KZ naming

Author: askrobov Date: Mon Nov 16 08:05:48 2015 New Revision: 253207 URL: http://llvm.org/viewvc/llvm-project?rev=253207=rev Log: Handle ARMv6KZ naming Summary: Update for clang tests for D14568 Reviewers: rengolin, joerg, bogden Subscribers: aemerson, rengolin, cfe-commits Differential

Re: [PATCH] D14570: Handle ARMv6KZ naming

This revision was automatically updated to reflect the committed changes. Closed by commit rL253207: Handle ARMv6KZ naming (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14570?vs=39901=40280#toc Repository: rL LLVM http://reviews.llvm.org/D14570 Files:

r253213 - [Myriad]: pass the 'std=' option to moviCompile

Author: dougk Date: Mon Nov 16 09:38:40 2015 New Revision: 253213 URL: http://llvm.org/viewvc/llvm-project?rev=253213=rev Log: [Myriad]: pass the 'std=' option to moviCompile Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified:

Re: [PATCH] D14686: Protect against overloaded comma in random_shuffle and improve tests

gribozavr added inline comments. Comment at: test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35 @@ -30,1 +34,3 @@ } + +template mclow.lists wrote: > This is not how I would rewrite this test. > I would write a routine

r253211 - [ARM,AArch64] Fix __rev16l and __rev16ll intrinsics

Author: olista01 Date: Mon Nov 16 08:58:50 2015 New Revision: 253211 URL: http://llvm.org/viewvc/llvm-project?rev=253211=rev Log: [ARM,AArch64] Fix __rev16l and __rev16ll intrinsics These two intrinsics are defined in arm_acle.h. __rev16l needs to rotate by 16 bits, bit it was actually rotating

Re: [PATCH] D14570: Handle ARMv6KZ naming

Hi Renato, Ideally, shouldn't the clang tests be checking that the LLVM target parsing library is called with the correct arguments? then separate tests inside LLVM check that the target parser works correctly? As it stands, it seems like a very deliberate layering violation that could really do

Re: [PATCH] D14609: [ARM, AArch64] Fix __rev16l and __rev16ll intrinsics

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM. The 64-bit rev pattern can be added later. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14609

r253242 - When producing error messages for always_inline functions with the

Author: echristo Date: Mon Nov 16 12:29:59 2015 New Revision: 253242 URL: http://llvm.org/viewvc/llvm-project?rev=253242=rev Log: When producing error messages for always_inline functions with the target attribute, don't include "negative" subtarget features in the list of required features.

r253255 - Correctly handle type mismatches in the __weak copy/move-initialization

Author: rjmccall Date: Mon Nov 16 16:11:41 2015 New Revision: 253255 URL: http://llvm.org/viewvc/llvm-project?rev=253255=rev Log: Correctly handle type mismatches in the __weak copy/move-initialization peephole I added in r250916. rdar://23559789 Added: cfe/trunk/test/CodeGenObjC/arc-weak.m

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

Rather than trying to maintain the horrible duplication between DataRecursiveASTVisitor and RecursiveASTVisitor, can we just delete DataRecursiveASTVisitor? RecursiveASTVisitor is data-recursive too these days (and has a smarter implementation than DataRecursiveASTVisitor's from what I can see),

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

On Mon, Nov 16, 2015 at 7:09 PM, Richard Smith wrote: > On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote: > >> On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith >> wrote: >> >>> On Nov 13, 2015 7:23 PM, "Sean Silva"

Re: [PATCH] D14736: [analyzer] DeadStoresChecker: Treat locals captured by reference in C++ lambdas as escaped.

dcoughlin added a comment. This is PR 22834. https://llvm.org/bugs/show_bug.cgi?id=22834. http://reviews.llvm.org/D14736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith wrote: > On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: > > > > > > > > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > >> Author: rsmith > >>

[libcxx] r253293 - Creating release candidate rc1 from release_371 branch

Author: tstellar Date: Mon Nov 16 21:25:27 2015 New Revision: 253293 URL: http://llvm.org/viewvc/llvm-project?rev=253293=rev Log: Creating release candidate rc1 from release_371 branch Added: libcxx/tags/RELEASE_371/rc1/ (props changed) - copied from r253292,

[libunwind] r253307 - Creating release candidate rc1 from release_371 branch

Author: tstellar Date: Mon Nov 16 21:25:56 2015 New Revision: 253307 URL: http://llvm.org/viewvc/llvm-project?rev=253307=rev Log: Creating release candidate rc1 from release_371 branch Added: libunwind/tags/RELEASE_371/rc1/ (props changed) - copied from r253306,

Lit test C++11 Compatibility Patch #4

Hi Everyone, Here is the forth Lit tests C++11 compatibility patch. This patch mainly added new diagnostics expected for C++11. There are 34 tests in total. They fall into 3 categories. [2 tests] New Warnings regarding storage class specifier "register"/"auto" being deprecated/not-allowed.

[PATCH] D14737: Convert some ObjC msgSends to runtime calls

pete created this revision. pete added a reviewer: rjmccall. pete added a subscriber: cfe-commits. It is faster to directly call the ObjC runtime for methods such as retain/release instead of sending a message to those functions. This patch adds support for converting messages to

[clang-tools-extra] r253310 - modularize: add install rule

Author: compnerd Date: Mon Nov 16 23:09:18 2015 New Revision: 253310 URL: http://llvm.org/viewvc/llvm-project?rev=253310=rev Log: modularize: add install rule This allows modularize to be installed. Previously, no install rule would be created for it. Modified:

r253316 - [Sema] Remove unnecessary typecast of bool to int when passing arguments to diagnostics. NFC

Author: ctopper Date: Mon Nov 16 23:40:12 2015 New Revision: 253316 URL: http://llvm.org/viewvc/llvm-project?rev=253316=rev Log: [Sema] Remove unnecessary typecast of bool to int when passing arguments to diagnostics. NFC Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified:

r253314 - [Sema] Minor formatting fixes. NFC

Author: ctopper Date: Mon Nov 16 23:40:05 2015 New Revision: 253314 URL: http://llvm.org/viewvc/llvm-project?rev=253314=rev Log: [Sema] Minor formatting fixes. NFC Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/lib/Sema/SemaDeclObjC.cpp cfe/trunk/lib/Sema/SemaStmt.cpp

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 40253. ABataev marked 3 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h

r253190 - [CGDebugInfo] Set the size and align for reference types

Author: kfischer Date: Mon Nov 16 03:04:13 2015 New Revision: 253190 URL: http://llvm.org/viewvc/llvm-project?rev=253190=rev Log: [CGDebugInfo] Set the size and align for reference types In r253186, I changed the DIBuilder API to now take size and align for reference types as well. This was done

r253191 - Update for the gnu flavor being renamed to old-gnu.

Author: rafael Date: Mon Nov 16 03:12:12 2015 New Revision: 253191 URL: http://llvm.org/viewvc/llvm-project?rev=253191=rev Log: Update for the gnu flavor being renamed to old-gnu. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/amdgpu-toolchain.c

[PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This provides both a more uniform interface and makes libclang behave like clang tooling wrt relative paths against argv[0]. This is necessary for finding paths to a c++ standard library

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev updated this revision to Diff 40255. ABataev marked 4 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

klimek added inline comments. Comment at: include/clang-c/Index.h:5694-5695 @@ -5683,1 +5693,4 @@ /** + * \brief Same as clang_indexSourceFile but requires a full command line + * for \c command_line_args including argv[0]. + */ We should probably expand on why

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 40262. ABataev marked 2 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D11182 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h

Re: [PATCH] D14662: [ARM] Pass architecture to TargetParser defaulting to cope with API change

bsmith closed this revision. bsmith added a comment. Thanks, committed as r253199. Repository: rL LLVM http://reviews.llvm.org/D14662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

bkramer updated this revision to Diff 40269. bkramer added a comment. - Add a test case to make sure argv[0] handling actually works. - Clarify comments a bit. http://reviews.llvm.org/D14695 Files: include/clang-c/Index.h lib/Frontend/CreateInvocationFromCommandLine.cpp