Re: [PATCH] D14982: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract.

2015-11-27 Thread Alexandros Lamprineas via cfe-commits
labrinea updated this revision to Diff 41316. labrinea added a comment. @t.p.northover you were right, my patch was missing predefined guard macros for the instrinsics. I've now updated the patch. http://reviews.llvm.org/D14982 Files: include/clang/Basic/arm_neon.td lib/Basic/Targets.cpp

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

2015-11-27 Thread Kelvin Li via cfe-commits
kkwli0 closed this revision. kkwli0 added a comment. Committed revision 254207. http://reviews.llvm.org/D15029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254207 - [OpenMP] Parsing and sema support for thread_limit clause.

2015-11-27 Thread Kelvin Li via cfe-commits
Author: kli Date: Fri Nov 27 12:47:36 2015 New Revision: 254207 URL: http://llvm.org/viewvc/llvm-project?rev=254207=rev Log: [OpenMP] Parsing and sema support for thread_limit clause. http://reviews.llvm.org/D15029 Added: cfe/trunk/test/OpenMP/teams_thread_limit_messages.cpp Modified:

r254204 - Revert r254203: [mips] Interrupt attribute support.

2015-11-27 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Fri Nov 27 12:00:36 2015 New Revision: 254204 URL: http://llvm.org/viewvc/llvm-project?rev=254204=rev Log: Revert r254203: [mips] Interrupt attribute support. I forgot to credit the author. Removed: cfe/trunk/test/CodeGen/mips-interrupt-attr.c

Re: [PATCH] D14982: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract.

2015-11-27 Thread Tim Northover via cfe-commits
t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Tim. http://reviews.llvm.org/D14982 ___ cfe-commits mailing list

r254208 - Fixed default label in fully covered switch warning that was introduced in r254203.

2015-11-27 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Fri Nov 27 13:49:24 2015 New Revision: 254208 URL: http://llvm.org/viewvc/llvm-project?rev=254208=rev Log: Fixed default label in fully covered switch warning that was introduced in r254203. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified:

r254206 - int function without a return statement is invalid C++.

2015-11-27 Thread Artyom Skrobov via cfe-commits
Author: askrobov Date: Fri Nov 27 12:10:49 2015 New Revision: 254206 URL: http://llvm.org/viewvc/llvm-project?rev=254206=rev Log: int function without a return statement is invalid C++. Changing the return type to void. Modified: cfe/trunk/test/Tooling/clang-check-analyzer.cpp

r254205 - [mips] Interrupt attribute support.

2015-11-27 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Fri Nov 27 12:03:44 2015 New Revision: 254205 URL: http://llvm.org/viewvc/llvm-project?rev=254205=rev Log: [mips] Interrupt attribute support. Summary: This patch adds support for the interrupt attribute for mips32r2+. Patch by Simon Dardis. Reviewers: dsanders,

Re: [PATCH] D14146: Introduction of -miamcu option

2015-11-27 Thread Andrey Turetskiy via cfe-commits
aturetsk updated this revision to Diff 41309. aturetsk added a comment. Extended to take into account recent MCU related changes http://reviews.llvm.org/D14146 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp lib/Driver/Tools.h test/Driver/miamcu-opt.c

r254203 - [mips] Interrupt attribute support.

2015-11-27 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Fri Nov 27 11:39:20 2015 New Revision: 254203 URL: http://llvm.org/viewvc/llvm-project?rev=254203=rev Log: [mips] Interrupt attribute support. Summary: This patch adds support for the interrupt attribute for mips32r2+. Reviewers: dsanders, aaron.ballman Subscribers:

[PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

2015-11-27 Thread Oliver Stannard via cfe-commits
olista01 created this revision. olista01 added reviewers: t.p.northover, ab. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. This allows ARMv8.2-A to be targeted either by using "armv8.2a" in the

Re: [PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

2015-11-27 Thread Oliver Stannard via cfe-commits
olista01 removed rL LLVM as the repository for this revision. olista01 updated this revision to Diff 41302. olista01 added a comment. Removed obsolete logic for setting subtarget features, and fixed up v8.1-A tests to match. Also added a missing test for predefined macros.

Re: [PATCH] D14954: [x86] Exclusion of incorrect include headers paths for MCU target

2015-11-27 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254195: [x86] Exclusion of incorrect include headers paths for MCU target (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D14954?vs=41045=41286#toc Repository: rL LLVM

r254195 - [x86] Exclusion of incorrect include headers paths for MCU target

2015-11-27 Thread Andrey Bokhanko via cfe-commits
Author: asbokhan Date: Fri Nov 27 06:18:22 2015 New Revision: 254195 URL: http://llvm.org/viewvc/llvm-project?rev=254195=rev Log: [x86] Exclusion of incorrect include headers paths for MCU target Exclusion of /usr/include and /usr/local/include headers paths for MCU target. Differential

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Beren Minor via cfe-commits
berenm updated this revision to Diff 41296. berenm added a comment. [clang-format] Code cleanup and variable naming in WhitespaceManager::AlignTokens http://reviews.llvm.org/D14325 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

2015-11-27 Thread Strahinja Petrovic via cfe-commits
spetrovic updated this revision to Diff 41297. spetrovic marked 2 inline comments as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c test/CodeGen/x86_64-arguments.c Index: test/CodeGen/x86_64-arguments.c

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

2015-11-27 Thread Strahinja Petrovic via cfe-commits
spetrovic added a comment. Comments addressed. http://reviews.llvm.org/D14871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:197 @@ +196,3 @@ + // Keep track of the nesting level of matching tokens, i.e. the number of + // surrounding (), [], or {}. We will only align a sequence of matching + // token that share the same

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Beren Minor via cfe-commits
berenm updated this revision to Diff 41299. berenm marked an inline comment as done. berenm added a comment. Fix continue statements. http://reviews.llvm.org/D14325 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp Index:

Re: r254195 - [x86] Exclusion of incorrect include headers paths for MCU target

2015-11-27 Thread Hal Finkel via cfe-commits
Hi Andrey, This commit does not seem to match the description. What is it doing? Thanks again, Hal - Original Message - > From: "Andrey Bokhanko via cfe-commits" > To: cfe-commits@lists.llvm.org > Sent: Friday, November 27, 2015 6:18:23 AM > Subject: r254195

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks awesome :-) Comment at: lib/Format/WhitespaceManager.cpp:242-243 @@ -320,34 +241,4 @@ } -if (Changes[i].Kind == tok::r_brace) { - if

r254199 - Revert Sparc and SparcV9 to external assembler. Now that the CPU

2015-11-27 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Fri Nov 27 07:16:33 2015 New Revision: 254199 URL: http://llvm.org/viewvc/llvm-project?rev=254199=rev Log: Revert Sparc and SparcV9 to external assembler. Now that the CPU handling is corrected, the primary reason for forcing IAS as default is gone and the remaining issues are

Re: [PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

2015-11-27 Thread Bradley Smith via cfe-commits
bsmith added a subscriber: bsmith. Comment at: lib/Driver/Tools.cpp:868-876 @@ -867,4 +867,11 @@ - if (Triple.getSubArch() == llvm::Triple::SubArchType::ARMSubArch_v8_1a) { + switch (Triple.getSubArch()) { + case llvm::Triple::SubArchType::ARMSubArch_v8_1a:

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Beren Minor via cfe-commits
berenm marked 2 inline comments as done. Comment at: lib/Format/WhitespaceManager.cpp:197 @@ +196,3 @@ + // Keep track of the nesting level of matching tokens, i.e. the number of + // surrounding (), [], or {}. We will only align a sequence of matching + // token that share

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Beren Minor via cfe-commits
berenm added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:242-243 @@ -320,34 +241,4 @@ } -if (Changes[i].Kind == tok::r_brace) { - if (!FoundLeftBraceOnLine) -AlignSequence(); - FoundLeftBraceOnLine = false; -} else if

[clang-tools-extra] r254216 - [clang-tidy] google-explicit-constructor: improve the warning message

2015-11-27 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Fri Nov 27 20:25:02 2015 New Revision: 254216 URL: http://llvm.org/viewvc/llvm-project?rev=254216=rev Log: [clang-tidy] google-explicit-constructor: improve the warning message Also switch some more tests to %check_clang_tidy. Modified:

Re: [PATCH] D10802: [mips] Interrupt attribute support.

2015-11-27 Thread Simon Dardis via cfe-commits
sdardis updated this revision to Diff 41283. sdardis added a comment. Nit addressed. Daniel or Aaron, can one of you commit on my behalf? Thanks. Aaron, thanks for the review. http://reviews.llvm.org/D10802 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D14736: [analyzer] DeadStoresChecker: Treat locals captured by reference in C++ lambdas as escaped.

2015-11-27 Thread Gábor Horváth via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. In the meantime I realized dead store analysis only works with local variables, so I think I answered my comment. It was commited in r253630 .

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-27 Thread Daniel Jasper via cfe-commits
djasper added a comment. Sorry for being so slow to respond. Feel free to ping me more frequently ;-). Comment at: lib/Format/WhitespaceManager.cpp:197 @@ +196,3 @@ + // Keep track of the scope depth of matching tokens. We will only align a + // sequence of matching token