On Mon, Dec 07, 2015 at 01:32:14PM -0800, Richard Smith via cfe-commits wrote:
> Worse, it seems
> > even using __builtin_nan() for example doesn't work.
> >
>
> __builtin_nan() works fine for me, can you provide a testcase?
I take this part back, pilot error.
Joerg
labrinea added inline comments.
Comment at: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c:4
@@ -3,4 +3,3 @@
// RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \
-// RUN: -target-feature +v8.1a -O3 -S -o - %s \
-// RUN: | FileCheck %s --check-prefix=CHECK
Author: abadouh
Date: Tue Dec 8 06:34:38 2015
New Revision: 255012
URL: http://llvm.org/viewvc/llvm-project?rev=255012=rev
Log:
[x86][avx512] more changes in intrinsics to be align with gcc format
Differential Revision: http://reviews.llvm.org/D15328
Modified:
On Mon, Dec 07, 2015 at 01:32:14PM -0800, Richard Smith via cfe-commits wrote:
> C11 6.3.1.5/1: "If the value being converted is outside the range of values
> that can be represented, the behavior is undefined."
The value of 1e100 can be represented as +inf, even if not precisely.
This is a bit
danielmarjamaki updated this revision to Diff 42164.
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
Moved warning to clang-tidy.
In this patch I am more careful about function calls. Sometimes when it is
technically possible to use const it's still not a good
danielmarjamaki added a subscriber: alexfh.
danielmarjamaki added a reviewer: alexfh.
danielmarjamaki added a comment.
Alexander: I add you as reviewer since this was moved to clang-tidy.
http://reviews.llvm.org/D12359
___
cfe-commits mailing list
danielmarjamaki added a comment.
In http://reviews.llvm.org/D12359#304772, @danielmarjamaki wrote:
> Moved warning to clang-tidy.
>
> In this patch I am more careful about function calls. Sometimes when it is
> technically possible to use const it's still not a good idea.
>
> For instance when
Author: abataev
Date: Tue Dec 8 06:06:20 2015
New Revision: 255008
URL: http://llvm.org/viewvc/llvm-project?rev=255008=rev
Log:
[OPENMP 4.5] Parsing/sema for 'num_tasks' clause.
OpenMP 4.5 adds directives 'taskloop' and 'taskloop simd'. These directives
support clause 'num_tasks'. Patch adds
alexfh added a comment.
Wow, that's a patch with history ;)
My first comment is that the `misc` module mostly consists of checks that are
safe to turn on by default. This check does not necessarily meet this bar, so
I'd better move it to `readability`. You could also send a new patch, since
danielmarjamaki created this revision.
danielmarjamaki added reviewers: alexfh, aaron.ballman, rsmith.
danielmarjamaki added subscribers: cfe-commits, sberg.
This is a new clang-tidy checker that will warn when function parameters should
be const.
See also related discussions in
aaron.ballman added a subscriber: aaron.ballman.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2747
@@ +2746,3 @@
+"comparison of nonnull %select{function call|parameter}0 '%1' "
+"%select{not |}2equal to a null pointer is %select{true|false}2 on first "
+
aaron.ballman added a comment.
A few small nits, but mostly looks good. Thank you for this!
Comment at: utils/TableGen/ClangAttrEmitter.cpp:2404
@@ -2407,3 +2403,3 @@
static std::set CustomSubjectSet;
- std::set::iterator I = CustomSubjectSet.find(FnName);
+ const auto I =
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D15311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.
I have created a new revision: http://reviews.llvm.org/D15332
http://reviews.llvm.org/D12359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mcrosier added a comment.
Ping.
http://reviews.llvm.org/D15195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
| I've amended this change to permit constant-foldable UB in C variable
initializers again in r254992.
Works for us, thanks!
| | (2) Shouldn't it diagnose each bad expression in an initializer?
| That change would be unrelated to the one at hand -- this is the way we've
always behaved.
If it's
rmaprath updated this revision to Diff 42175.
rmaprath added a comment.
Addressing review comments by @mclow.lists:
Got rid of the `__noexcept` header by moving the `__throw_helper` function into
the `__config` header. The `__libcxx_noexceptions_abort` function now takes in
an extra parameter
jroelofs added inline comments.
Comment at: test/support/noexcept.h:10
@@ +9,3 @@
+//===--===//
+#ifdef _LIBCPP_NO_EXCEPTIONS
+
You should also add a header guard so that this doesn't get
aaron.ballman added a comment.
Ping
http://reviews.llvm.org/D15087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 42178.
rmaprath added a comment.
Added a header guard to the `noexcept.h` test support header (review comment by
@jroelofs).
http://reviews.llvm.org/D14653
Files:
include/__config
include/array
test/std/containers/sequences/array/at.pass.cpp
alexfh added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:20
@@ +19,3 @@
+void NonConstParameterCheck::registerMatchers(MatchFinder *Finder) {
+ // TODO: This checker doesn't handle C++ to start with. There are problems
+ // for example with
dberlin added a comment.
The license looks fine to me
http://reviews.llvm.org/D15087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:43
@@ +42,3 @@
+ Finder->addMatcher(returnStmt().bind("return"), this);
+}
+
I think it may be an improvement to unify all of the matchers that will
eventually be
alexfh added a comment.
Daniel, is the proposed solution fine?
http://reviews.llvm.org/D15087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenezelenko
Date: Tue Dec 8 12:00:11 2015
New Revision: 255033
URL: http://llvm.org/viewvc/llvm-project?rev=255033=rev
Log:
Use range loops and autos in lib/Serialization/ASTWriter.cpp.
Differential revision: http://reviews.llvm.org/D15311
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255033: Use range loops and autos in
lib/Serialization/ASTWriter.cpp. (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D15311?vs=42112=42190#toc
Repository:
rL LLVM
rjmccall added a comment.
Thanks!
Comment at: lib/Sema/SemaPseudoObject.cpp:249
@@ -248,1 +248,3 @@
+virtual bool useSetterResultAsExprResult(Expr *) const { return false; }
+virtual bool captureSetValueAsResult() const { return true; }
};
I think
beanz added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s
Author: hans
Date: Tue Dec 8 11:54:27 2015
New Revision: 255029
URL: http://llvm.org/viewvc/llvm-project?rev=255029=rev
Log:
Update clang-format-vs README
VS2013 is requried after r231084.
Modified:
cfe/trunk/tools/clang-format-vs/README.txt
Modified:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D15313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255042: Use range loops and autos in
utils/TableGen/ClangAttrEmitter.cpp and… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D15313?vs=42192=42197#toc
Repository:
rL
Okay, I'll bite: so what *does* UINT128_MAX actually convert to?
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Richard Smith via cfe-commits
Sent: Tuesday, December 08, 2015 10:52 AM
To: Joerg Sonnenberger; cfe-commits
Subject: Re: r254574 - PR17381: Treat undefined
On Tue, Dec 8, 2015 at 11:18 AM, Richard Smith
wrote:
> On Tue, Dec 8, 2015 at 10:59 AM, Robinson, Paul <
> paul_robin...@playstation.sony.com> wrote:
>
>> Okay, I'll bite: so what *does* UINT128_MAX actually convert to?
>>
>
> $ echo 'unsigned __int128 max = -1; float f
For CX_BinaryOperatorKind please change the enumerators to have an explicit
integer assignment; this is to emphasize that they are API contract and should
not change with subsequent changes (someone may inadvertently add a new
enumerator in the middle which will implicitly change all the
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
For CX_BinaryOperatorKind please change the enumerators to have an explicit
integer assignment; this is to emphasize that they are API contract and should
not change with subsequent changes (someone may inadvertently add a new
Eugene.Zelenko removed rL LLVM as the repository for this revision.
Eugene.Zelenko updated this revision to Diff 42192.
Eugene.Zelenko added a comment.
Replaced const auto with auto as suggested by Aaron.
http://reviews.llvm.org/D15313
Files:
utils/TableGen/ClangAttrEmitter.cpp
Index:
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I fixed Clang-tidy modernize-use-auto warnings. Autos are also used for pointer
variables
aaron.ballman added inline comments.
Comment at: lib/AST/ASTContext.cpp:299
@@ -299,3 +298,3 @@
// specialization?
-if (const ClassTemplateSpecializationDecl *CTSD =
+if (const auto *CTSD =
dyn_cast(CRD)) {
Can this now fit onto one
Eugene.Zelenko added inline comments.
Comment at: lib/AST/ASTContext.cpp:429
@@ -432,2 +428,3 @@
+ auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo);
return CFC;
}
jroelofs wrote:
> return new ...
Will fix in commit.
Repository:
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:7674
@@ +7673,3 @@
+: diag::warn_cast_nonnull_to_bool;
+Diag(E->getExprLoc(), DiagID) << int(IsParam) << S.str()
+ << E->getSourceRange() << Range << IsEqual;
Author: eugenezelenko
Date: Tue Dec 8 12:49:01 2015
New Revision: 255042
URL: http://llvm.org/viewvc/llvm-project?rev=255042=rev
Log:
Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp and generated
code.
Differential revision: http://reviews.llvm.org/D15313
Modified:
jroelofs added a subscriber: jroelofs.
Comment at: lib/AST/ASTContext.cpp:429
@@ -432,2 +428,3 @@
+ auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo);
return CFC;
}
return new ...
Repository:
rL LLVM
On Tue, Dec 8, 2015 at 10:59 AM, Robinson, Paul <
paul_robin...@playstation.sony.com> wrote:
> Okay, I'll bite: so what *does* UINT128_MAX actually convert to?
>
$ echo 'unsigned __int128 max = -1; float f = max;' |
~/clang-8/build/bin/clang -x c++ - -emit-llvm -S -o - -O3 | grep @f
@f = global
george.burgess.iv updated this revision to Diff 42204.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
- Addressed all feedback
- Refactored a loop to make its intent more clear
http://reviews.llvm.org/D15324
Files:
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Thank you for this, LGTM!
Comment at: lib/Sema/SemaChecking.cpp:7682
@@ +7681,3 @@
+ if (Callee->hasAttr())
samsonov added a comment.
Sorry for the late response. Ugh, flag naming is hard, and it's far too
complicated for sanitizers already.
However, I'm opposed to passing this down as `-fsanitize=` option =/. So far
we're trying to make values of `-fsanitize=` correspond *only* to different
kinds
danielaustin added a comment.
I'm not partial to what its called, or where it is. I'm completely ok with
-fsanitize-merge-checks
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
I'm not partial to what its called, or where it is. I'm completely ok with
-fsanitize-merge-checks
On Tue, Dec 8, 2015 at 1:07 PM Evgeniy Stepanov wrote:
> eugenis added a comment.
>
> Better -fsanitize-merge-checks, and it should apply to non-trap checks as
> well (i.e.
eugenis added a comment.
Better -fsanitize-merge-checks, and it should apply to non-trap checks as well
(i.e. SIGILL address should uniquely correspond to the failure source location).
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
samsonov added a comment.
That is, I presume it's highly unlikely user will need to have fine-grained
setup for deciding which UBSan checks should be merged, and which should not.
So, probably having a single `-fsanitize-merge-traps` /
`-fno-sanitize-merge-traps` option would be enough. I'd
jamesr added a comment.
Marshall - friendly ping. If you know a way to test functionality guarded by a
compile-time flag in the libcxx test suite I'd be happy to wire in tests for
this, but if that doesn't exist (and I think it does not currently) then I
think the only way to verify this is
Author: chapuni
Date: Wed Dec 9 01:52:46 2015
New Revision: 255098
URL: http://llvm.org/viewvc/llvm-project?rev=255098=rev
Log:
Reformat linefeeds.
Modified:
cfe/trunk/include/clang-c/Index.h
cfe/trunk/include/clang/Basic/StmtNodes.td
cfe/trunk/lib/AST/StmtProfile.cpp
Author: dgregor
Date: Tue Dec 8 16:43:32 2015
New Revision: 255065
URL: http://llvm.org/viewvc/llvm-project?rev=255065=rev
Log:
Module file extensions: pass a Sema through to the extension writer.
Module file extensions are likely to need access to
Sema/Preprocessor/ASTContext, and cannot get
Author: dgregor
Date: Tue Dec 8 16:45:17 2015
New Revision: 255066
URL: http://llvm.org/viewvc/llvm-project?rev=255066=rev
Log:
Objective-C properties: fix bogus use of "isa<>" on a QualType.
The code used "isa" to check the type and then "getAs" to look through
sugar; we need to look through
Sunil_Srivastava added a comment.
Please see the comment about getAllDiagnostics
Comment at: lib/Basic/Diagnostic.cpp:251-257
@@ -250,2 +250,9 @@
SourceLocation Loc) {
+ // Special handling for pragma clang diagnostic ...
wschmidt closed this revision.
wschmidt added a comment.
Committed as r255067.
http://reviews.llvm.org/D12840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: wschmidt
Date: Tue Dec 8 16:48:02 2015
New Revision: 255067
URL: http://llvm.org/viewvc/llvm-project?rev=255067=rev
Log:
[PPC64, TSAN] Enable thread sanitizer for PPC64
Patch by Simone Atzeni.
This enables the -fsanitize=thread flag for PPC64 and PPC64LE.
Modified:
Ping.
On Mon, Nov 23, 2015 at 6:55 PM, Richard Smith
wrote:
> Ping.
>
> On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith
> wrote:
>
>> Ping.
>>
>> On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith
>> wrote:
>>
>>> Hi,
>>>
>>> The
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Any more comments on this patch?
Thanks,
Samuel
http://reviews.llvm.org/D9888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov created this revision.
samsonov added reviewers: rsmith, kcc.
samsonov added a subscriber: cfe-commits.
Add the ability to suppress UBSan reports for files/functions/modules
at runtime. The user can now pass UBSAN_OPTIONS=suppressions=supp.txt
with the contents of the form:
eugenis created this revision.
eugenis added reviewers: kcc, pcc.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Clang-side cross-DSO CFI.
* Enabled with -fsanitize-cfi-cross-dso
* uses a runtime library, unlike "plain" CFI
* does not yet support
Author: vedantk
Date: Tue Dec 8 19:44:02 2015
New Revision: 255091
URL: http://llvm.org/viewvc/llvm-project?rev=255091=rev
Log:
[Basic] Rangify two for loops. NFC.
Modified:
cfe/trunk/lib/Basic/FileManager.cpp
Modified: cfe/trunk/lib/Basic/FileManager.cpp
URL:
Author: chapuni
Date: Tue Dec 8 22:35:57 2015
New Revision: 255094
URL: http://llvm.org/viewvc/llvm-project?rev=255094=rev
Log:
Revert r255001, "Add parse and sema for OpenMP distribute directive and all its
clauses excluding dist_schedule."
It causes memory leak. Some tests in test/OpenMP
RedX2501 updated this revision to Diff 42267.
RedX2501 added a comment.
Added explicit integer assignment to enum to emphasize api contract behaviour.
http://reviews.llvm.org/D10833
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor.py
include/clang-c/Index.h
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
There's no way to make a flag alias to two flags, so add a /WCL4 flag that maps
to the All, Extra diag groups.
Fixes PR25563.
http://reviews.llvm.org/D15350
Files:
docs/UsersManual.rst
thakis abandoned this revision.
thakis added a comment.
Forgot to add cfe-commits. I'll abandon this and send it out again.
http://reviews.llvm.org/D15349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: gbiv
Date: Tue Dec 8 16:02:00 2015
New Revision: 255058
URL: http://llvm.org/viewvc/llvm-project?rev=255058=rev
Log:
[Sema] Add warning when comparing nonnull and null
Currently, we emit warnings in some cases where nonnull function
parameters are compared against null. This patch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255058: [Sema] Add warning when comparing nonnull and null
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D15324?vs=42204=42221#toc
Repository:
rL LLVM
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
> There's no way to make a flag alias to two flags
Well, at least not with the alias mechanism in the option parser, but David
pointed out we could expand it manually in
samsonov added a comment.
That is, I presume it's highly unlikely user will need to have fine-grained
setup for deciding which UBSan checks should be merged, and which should not.
So, probably having a single `-fsanitize-merge-traps` /
`-fno-sanitize-merge-traps` option would be enough. I'd
eugenis added a comment.
I misunderstood the meaning of -fsanitize-trap, and now I prefer
-fsanitize-merge-traps for the flag name.
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rksimon
Date: Tue Dec 8 15:16:45 2015
New Revision: 255050
URL: http://llvm.org/viewvc/llvm-project?rev=255050=rev
Log:
[X86][AVX2] Stripped backend codegen tests
As discussed on the ml, backend tests need to be put in llvm/test/CodeGen/X86
as fast-isel tests using IR that is as close
hans added a comment.
Alexey & Chandler: Is there any ongoing communication here?
It would be great if we could resolve this, or at least figure out what the
status is, before we branch for 3.8 in a month or so.
http://reviews.llvm.org/D13802
___
74 matches
Mail list logo