r255655 - clang-cl: Add an alias for /wd4100

Author: nico Date: Tue Dec 15 11:07:16 2015 New Revision: 255655 URL: http://llvm.org/viewvc/llvm-project?rev=255655=rev Log: clang-cl: Add an alias for /wd4100 Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td cfe/trunk/test/Driver/cl-options.c Modified:

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > Jonathan, can you explain what specific use case does this patch address? Why > one severity level of native clang-tidy warnings (the current situation) is > not enough, and two levels are enough? I have

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#310992, @nemanjai wrote: > I think the correct course of action would be to allow/disallow promotion > based on a condition that the two types are the same/different > (respectively). I think a comparison of the float

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi updated this revision to Diff 42874. MaggieYi added a comment. Thanks, I have updated the test following your comments. http://reviews.llvm.org/D15222 Files: lib/Driver/Tools.cpp test/Driver/ps4-runtime-flags.c Index: test/Driver/ps4-runtime-flags.c

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Jonathan, can you explain what specific use case does this patch address? Why one severity level of native clang-tidy warnings (the current situation) is not enough, and two levels

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

aaron.ballman added a comment. Attribute implementation LGTM, but I do not know the semantics of ifunc well enough to comment on whether this implementation is correct or not. From what I can tell of GCC's documentation, it looks reasonable, but it would be good for Eric or John to take a look

[PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __cuda_runtime.h

tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. Currently it's easy to break CUDA compilation by passing "-isystem /path/to/cuda/include" to compiler which leads to compiler including real cuda_runtime.h from there instead of the wrapper we need.

[libclc] r255662 - AMDGPU: Add alias for tonga

Author: tstellar Date: Tue Dec 15 12:37:02 2015 New Revision: 255662 URL: http://llvm.org/viewvc/llvm-project?rev=255662=rev Log: AMDGPU: Add alias for tonga Patch by: Vedran Mileti Modified: libclc/trunk/configure.py Modified: libclc/trunk/configure.py URL:

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

aaron.ballman added inline comments. Comment at: tools/llvm-project/extra/test/clang-tidy/werrors-plural.cpp:7 @@ +6,3 @@ +// CHECK-WARN: warning: namespace 'j' not terminated with a closing comment [llvm-namespace-comment] +// CHECK-WERR: error: namespace 'j' not terminated

Re: [PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h

tra retitled this revision from "[CUDA] renamed cuda_runtime.h wrapper to __cuda_runtime.h" to "[CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h". tra updated the summary for this revision. tra added a reviewer: chandlerc. tra updated this revision to Diff 42882. tra added

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

sbenza updated this revision to Diff 42884. sbenza added a comment. Add a faster version of the qualified name matcher. It falls back to the previous version if it can't handle the name. http://reviews.llvm.org/D15506 Files: include/clang/ASTMatchers/ASTMatchersInternal.h

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai added a comment. I think the correct course of action would be to allow/disallow promotion based on a condition that the two types are the same/different (respectively). I think a comparison of the float semantics is a valid way to check this. Also, should operations between long

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

alexfh added a comment. In http://reviews.llvm.org/D15528#311053, @jroelofs wrote: > In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > > > Jonathan, can you explain what specific use case does this patch address? > > Why one severity level of native clang-tidy warnings (the current >

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

sbenza added inline comments. Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322 @@ +321,3 @@ + for (bool SkipUnwritten : SkipUnwrittenCases) { +llvm::SmallString<128> NodeName = StringRef("::"); +llvm::raw_svector_ostream OS(NodeName); yaron.keren

Re: [PATCH] D15518: [WinEH] Update clang to use operand bundles on call sites

majnemer updated this revision to Diff 42886. majnemer added a comment. - Address review comments http://reviews.llvm.org/D15518 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp

Re: r255382 - [clang-cl] Let /W4 map to -Wall -Wextra instead of just -Wall.

Looks like the warning is still emitted frequently. It looks like cl.exe processes /W4 before /wd4100 even though if it's passed as "/wd4100 /W4". clang-cl probably interprets this as "first, disable Wunused-parameter, then turn on everything in Wall and Wextra". I suppose we could process W1-4

Buildbot numbers for week of 12/06/2015 - 12/12/2015

Hello everyone, Below are some buildbot numbers for the last week of 12/06/2015 - 12/12/2015. Thanks Galina Top 10 fastest builders(not docs): lldb-amd64-ninja-freebsd11 clang-bpf-build llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast libomp-gcc-x86_64-linux-debian sanitizer-windows

Re: r255382 - [clang-cl] Let /W4 map to -Wall -Wextra instead of just -Wall.

(...but it looks like these are all just warnings. The reason the builder is red is In file included from C:\buildbot\slave-config\clang-x86-win2008-selfhost\llvm\unittests\Support\ThreadPool.cpp:10: C:\buildbot\slave-config\clang-x86-win2008-selfhost\llvm\include\llvm/Support/ThreadPool.h(73,50)

r255667 - Unsupport test that should not be run on Hexagon

Author: kparzysz Date: Tue Dec 15 13:14:24 2015 New Revision: 255667 URL: http://llvm.org/viewvc/llvm-project?rev=255667=rev Log: Unsupport test that should not be run on Hexagon Modified: cfe/trunk/test/CodeGen/ms_this.cpp Modified: cfe/trunk/test/CodeGen/ms_this.cpp URL:

r255627 - Add a new matcher to match character types.

Author: xazax Date: Tue Dec 15 02:35:45 2015 New Revision: 255627 URL: http://llvm.org/viewvc/llvm-project?rev=255627=rev Log: Add a new matcher to match character types. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL255630: [clang-tidy] Check for suspicious string assignments. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D15411?vs=42710=42824#toc Repository: rL LLVM

[clang-tools-extra] r255630 - [clang-tidy] Check for suspicious string assignments.

Author: xazax Date: Tue Dec 15 02:47:20 2015 New Revision: 255630 URL: http://llvm.org/viewvc/llvm-project?rev=255630=rev Log: [clang-tidy] Check for suspicious string assignments. It is possible to assign arbitrary integer types to strings. Sometimes it is the result of missing to_string call

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

xazax.hun added a comment. In http://reviews.llvm.org/D15411#310539, @alexfh wrote: > Thank you for the new awesome check! Thank you for the review. I committed the new matcher to clang as well. I went with isAnyCharacter name for now, but we can rename it anytime. Repository: rL LLVM

Re: [PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

This revision was automatically updated to reflect the committed changes. Closed by commit rL255635: [libclang] Add a flag to create the precompiled preamble on the first parse. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D15490?vs=42749=42826#toc Repository: rL LLVM

r255635 - [libclang] Add a flag to create the precompiled preamble on the first parse.

Author: d0k Date: Tue Dec 15 03:30:31 2015 New Revision: 255635 URL: http://llvm.org/viewvc/llvm-project?rev=255635=rev Log: [libclang] Add a flag to create the precompiled preamble on the first parse. Summary: The current default is to create the preamble on the first reparse, aka second parse.

r255625 - [OPENMP 4.5] Parsing/sema for 'hint' clause of 'critical' directive.

Author: abataev Date: Tue Dec 15 02:19:24 2015 New Revision: 255625 URL: http://llvm.org/viewvc/llvm-project?rev=255625=rev Log: [OPENMP 4.5] Parsing/sema for 'hint' clause of 'critical' directive. OpenMP 4.5 adds 'hint' clause to critical directive. Patch adds parsing/semantic analysis for this

Re: [Diffusion] rL255545: [PATCH] Adding checker to detect excess padding in records

chapuni added subscribers: cfe-commits, chapuni. /cfe/trunk/test/Analysis/padding_c.c:193 Seems it is incompatible to i686-linux. > error: 'warning' diagnostics expected but not seen: > File clang/test/Analysis/padding_c.c Line 194 (directive at > clang/test/Analysis/padding_c.c:193):

r255636 - clang/test/Analysis/padding_c.c: Suppress a test incompatible to i686-linux.

Author: chapuni Date: Tue Dec 15 03:37:01 2015 New Revision: 255636 URL: http://llvm.org/viewvc/llvm-project?rev=255636=rev Log: clang/test/Analysis/padding_c.c: Suppress a test incompatible to i686-linux. error: 'warning' diagnostics expected but not seen: File

r255639 - [OPENMP 4.5] Codegen for 'hint' clause of 'critical' directive

Author: abataev Date: Tue Dec 15 04:55:09 2015 New Revision: 255639 URL: http://llvm.org/viewvc/llvm-project?rev=255639=rev Log: [OPENMP 4.5] Codegen for 'hint' clause of 'critical' directive OpenMP 4.5 defines 'hint' clause for 'critical' directive. Patch adds codegen for this clause.

r255640 - [OPENMP 4.5] Fix test compatibility with 32 bit mode.

Author: abataev Date: Tue Dec 15 05:38:29 2015 New Revision: 255640 URL: http://llvm.org/viewvc/llvm-project?rev=255640=rev Log: [OPENMP 4.5] Fix test compatibility with 32 bit mode. Modified: cfe/trunk/test/OpenMP/critical_codegen.cpp Modified: cfe/trunk/test/OpenMP/critical_codegen.cpp

Re: [PATCH] D14441: [OpenCL] Pipe types support.

bader added a comment. Hi guys, Sorry for long silence. Unfortunately, I just can't find time to finish with this patch. Xiuli provided a valid test case that exposed issue with type caching, so I decided to not commit at as is (although I applied other minor style comments locally). I'm

Re: [PATCH] D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&

K-ballo updated this revision to Diff 42892. K-ballo marked 15 inline comments as done. K-ballo added a comment. Addressed review comments. Use `UNSUPPORTED` in `pairs.by.type.pass`. http://reviews.llvm.org/D14839 Files: include/__tuple include/array include/tuple include/utility

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Lgtm http://reviews.llvm.org/D15222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM modulo some wordsmithing in the documentation. Comment at: docs/ControlFlowIntegrity.rst:31 @@ +30,3 @@ +enabled, and are statically linked into the program. This may preclude

r255690 - clang/test/CodeGen/ms_this.cpp: Fix for -Asserts.

Author: chapuni Date: Tue Dec 15 16:42:28 2015 New Revision: 255690 URL: http://llvm.org/viewvc/llvm-project?rev=255690=rev Log: clang/test/CodeGen/ms_this.cpp: Fix for -Asserts. Modified: cfe/trunk/test/CodeGen/ms_this.cpp Modified: cfe/trunk/test/CodeGen/ms_this.cpp URL:

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

beanz updated this revision to Diff 42891. beanz added a comment. Cleaning up the python helper as per Sean's suggestions. http://reviews.llvm.org/D15462 Files: CMakeLists.txt utils/perf-training/CMakeLists.txt utils/perf-training/README.txt utils/perf-training/cxx/hello_world.cpp

r255685 - Fix clang/test/CodeGen/ms_this.cpp.

Author: chapuni Date: Tue Dec 15 16:19:00 2015 New Revision: 255685 URL: http://llvm.org/viewvc/llvm-project?rev=255685=rev Log: Fix clang/test/CodeGen/ms_this.cpp. Modified: cfe/trunk/test/CodeGen/ms_this.cpp Modified: cfe/trunk/test/CodeGen/ms_this.cpp URL:

[libcxx] r255686 - Remove unused _LIBCPP_HAS_NO_ALWAYS_INLINE_VARIADICS macro

Author: ericwf Date: Tue Dec 15 16:19:03 2015 New Revision: 255686 URL: http://llvm.org/viewvc/llvm-project?rev=255686=rev Log: Remove unused _LIBCPP_HAS_NO_ALWAYS_INLINE_VARIADICS macro Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

eugenis updated this revision to Diff 42914. eugenis marked 10 inline comments as done. Repository: rL LLVM http://reviews.llvm.org/D15367 Files: docs/ControlFlowIntegrity.rst docs/ControlFlowIntegrityDesign.rst docs/UsersManual.rst include/clang/Driver/Options.td

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

eugenis added inline comments. Comment at: docs/ControlFlowIntegrityDesign.rst:389 @@ +388,3 @@ + - Calls between different instrumented DSOs are also protected with + performance penalty compared to the monolithic CFI. + - Calls from instrumented DSO to an uninstrumented

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. In http://reviews.llvm.org/D15539#311343, @jroelofs wrote: > Could these large padding things be related to the fact that the test is used > as a performance check for the implementation? That being said, I have no > idea who is paying attention to the numbers that come

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

davidxl added a comment. I prefer using the profile from the original test case where Max count is not 1. Repository: rL LLVM http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

mclow.lists added a comment. do we even use `_NOEXCEPT_OR_FALSE` any more? http://reviews.llvm.org/D15516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r255683 - [libcxx] Enable noexcept for GCC 4.6 and greater

Author: ericwf Date: Tue Dec 15 16:16:47 2015 New Revision: 255683 URL: http://llvm.org/viewvc/llvm-project?rev=255683=rev Log: [libcxx] Enable noexcept for GCC 4.6 and greater Summary: This patch allows GCC 4.6 and above to use `noexcept` as opposed to `throw()`. Is it an ABI safe change to

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

pcc added a comment. LGTM Comment at: docs/ControlFlowIntegrityDesign.rst:389 @@ +388,3 @@ + - Calls between different instrumented DSOs are also protected, with + performance penalty (in addition to the monolithic CFI overhead). + - Calls from an instrumented DSO to an

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka writes: > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner > wrote: > >> Akira Hatanaka via cfe-commits writes: >> > ahatanak created this revision. >> > ahatanak added a subscriber: cfe-commits. >> > >> > This

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#311135, @alexfh wrote: > In http://reviews.llvm.org/D15528#311053, @jroelofs wrote: > > > In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > > > > > Jonathan, can you explain what specific use case does this patch address? > >

Re: [PATCH] D8652: [libcxx] Create internal namespace that hides all symbols.

EricWF abandoned this revision. EricWF added a comment. There hasn't been much interest in this approach and it won't work with the new linkage attributes. http://reviews.llvm.org/D8652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig created this revision. bcraig added a reviewer: mclow.lists. bcraig added a subscriber: cfe-commits. This test has a lot of classes with large amounts of manually inserted padding in them, presumable to prevent various optimizations. The test then creates lots of these objects on the

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added subscribers: howard.hinnant, jroelofs. jroelofs added a comment. Could these large padding things be related to the fact that the test is used as a performance check for the implementation? That being said, I have no idea who is paying attention to the numbers that come out of

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

zturner updated this revision to Diff 42895. zturner added a comment. Attempt to address remaining issues in patch. This is my first time touching anything having to do with clang, so there's a good chance I don't know what i'm doing and this needs more work. Let me know.

Re: [PATCH] D15518: [WinEH] Update clang to use operand bundles on call sites

This revision was automatically updated to reflect the committed changes. Closed by commit rL255675: [WinEH] Update clang to use operand bundles on call sites (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D15518?vs=42886=42901#toc Repository: rL LLVM

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

On Dec 15, 2015, at 5:30 PM, Jonathan Roelofs wrote: > > > Could these large padding things be related to the fact that the test is used > as a performance check for the implementation? That being said, I have no > idea who is paying attention to the numbers that

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

silvas added a comment. Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; they're likely to have more higher-level thoughts. Comment at: utils/perf-training/perf-helper.py:36 @@ +35,3 @@ + cmd.extend(findProfrawFiles(args[2])) +

r255731 - Reland "[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit"

Author: rnk Date: Tue Dec 15 18:26:37 2015 New Revision: 255731 URL: http://llvm.org/viewvc/llvm-project?rev=255731=rev Log: Reland "[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit" I forgot to initialize RecoverFP. Modified: cfe/trunk/lib/CodeGen/CGException.cpp

Re: [PATCH] D15463: [Objective-c] Fix a crash

Akira Hatanaka writes: > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner > wrote: > >> Akira Hatanaka writes: >> > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner >> > wrote: >> > >> >> Akira Hatanaka via

[libcxx] r255738 - Make noexcept specifications on __hash_table definitions match their declarations.

Author: ericwf Date: Tue Dec 15 18:53:04 2015 New Revision: 255738 URL: http://llvm.org/viewvc/llvm-project?rev=255738=rev Log: Make noexcept specifications on __hash_table definitions match their declarations. Modified: libcxx/trunk/include/__hash_table Modified:

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

eugenis marked an inline comment as done. eugenis added a comment. Repository: rL LLVM http://reviews.llvm.org/D15367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15463: [Objective-c] Fix a crash

On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner wrote: > Akira Hatanaka writes: > > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner > > wrote: > > > >> Akira Hatanaka via cfe-commits writes: > >> >

r255712 - Relax checks in cfi-cross-dso test.

Author: eugenis Date: Tue Dec 15 17:49:51 2015 New Revision: 255712 URL: http://llvm.org/viewvc/llvm-project?rev=255712=rev Log: Relax checks in cfi-cross-dso test. The test is failing with unnamed labels. Modified: cfe/trunk/test/CodeGenCXX/cfi-cross-dso.cpp Modified:

r255723 - These days, GCC has at least minimal documentation for its VLAIS extension.

Author: rsmith Date: Tue Dec 15 18:09:57 2015 New Revision: 255723 URL: http://llvm.org/viewvc/llvm-project?rev=255723=rev Log: These days, GCC has at least minimal documentation for its VLAIS extension. Modified: cfe/trunk/www/comparison.html Modified: cfe/trunk/www/comparison.html URL:

[libcxx] r255734 - Workaround nasty GCC bug that caused testsuite to hang

Author: ericwf Date: Tue Dec 15 18:35:45 2015 New Revision: 255734 URL: http://llvm.org/viewvc/llvm-project?rev=255734=rev Log: Workaround nasty GCC bug that caused testsuite to hang Modified: libcxx/trunk/include/utility Modified: libcxx/trunk/include/utility URL:

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell updated this revision to Diff 42933. martell added a comment. Sorry I was a bit slow getting around to this. Will do testcases if Yaron thinks this is okay http://reviews.llvm.org/D15006 Files: lib/Driver/MinGWToolChain.cpp lib/Driver/ToolChains.h Index: lib/Driver/ToolChains.h

r255728 - Revert "[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit"

Author: rnk Date: Tue Dec 15 18:20:21 2015 New Revision: 255728 URL: http://llvm.org/viewvc/llvm-project?rev=255728=rev Log: Revert "[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit" This reverts commit r255710. Modified: cfe/trunk/lib/CodeGen/CGException.cpp

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

Sean Silva writes: > silvas added a comment. > > Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; > they're likely to have more higher-level thoughts. I'm fine with the concept and Sean's LGTM should cover the details :) > > >

r255740 - [CMake] Add support for generating profdata for clang from training files

Author: cbieneman Date: Tue Dec 15 19:02:44 2015 New Revision: 255740 URL: http://llvm.org/viewvc/llvm-project?rev=255740=rev Log: [CMake] Add support for generating profdata for clang from training files Summary: This patch adds support for using LIT to drive generating PGO profile data for

r255727 - Fix grammar.

Author: rsmith Date: Tue Dec 15 18:19:23 2015 New Revision: 255727 URL: http://llvm.org/viewvc/llvm-project?rev=255727=rev Log: Fix grammar. Modified: cfe/trunk/www/comparison.html Modified: cfe/trunk/www/comparison.html URL:

r255736 - [cfi] Exclude ubsan runtime library from non-diag CFI builds (driver changes).

Author: eugenis Date: Tue Dec 15 18:38:42 2015 New Revision: 255736 URL: http://llvm.org/viewvc/llvm-project?rev=255736=rev Log: [cfi] Exclude ubsan runtime library from non-diag CFI builds (driver changes). Split the CFI runtime in two: cfi and cfi_diag. The latter includes UBSan runtime to

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

eugenis updated this revision to Diff 42918. Repository: rL LLVM http://reviews.llvm.org/D15367 Files: docs/ControlFlowIntegrity.rst docs/ControlFlowIntegrityDesign.rst docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h

r255694 - Cross-DSO control flow integrity (Clang part).

Author: eugenis Date: Tue Dec 15 17:00:20 2015 New Revision: 255694 URL: http://llvm.org/viewvc/llvm-project?rev=255694=rev Log: Cross-DSO control flow integrity (Clang part). Clang-side cross-DSO CFI. * Adds a command line flag -f[no-]sanitize-cfi-cross-dso. * Links a runtime library when

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

eugenis closed this revision. eugenis added a comment. r255694 Repository: rL LLVM http://reviews.llvm.org/D15367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r255710 - [SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit

Author: rnk Date: Tue Dec 15 17:47:40 2015 New Revision: 255710 URL: http://llvm.org/viewvc/llvm-project?rev=255710=rev Log: [SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit Modified: cfe/trunk/lib/CodeGen/CGException.cpp cfe/trunk/test/CodeGen/exceptions-seh.c

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

akyrtzi added a comment. LGTM. http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

LGTM. > On Dec 12, 2015, at 5:25 PM, Bruno Cardoso Lopes > wrote: > > bruno updated this revision to Diff 42649. > bruno added a comment. > > Thanks Duncan and Argyrios, updated a patch with the suggestions! > > > http://reviews.llvm.org/D15173 > > Files: >

Re: [PATCH] D15462: [CMake] Add support for generating profdata for clang from training files

This revision was automatically updated to reflect the committed changes. Closed by commit rL255740: [CMake] Add support for generating profdata for clang from training files (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D15462?vs=42891=42943#toc Repository: rL

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

vsk added a comment. Sure! Thanks. http://reviews.llvm.org/D15222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs created this revision. jroelofs added a reviewer: aaron.ballman. jroelofs added a subscriber: cfe-commits. http://reviews.llvm.org/D15528 Files: tools/llvm-project/extra/clang-tidy/ClangTidy.cpp tools/llvm-project/extra/clang-tidy/ClangTidy.h

Re: [PATCH] D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers]

aaron.ballman added a comment. In http://reviews.llvm.org/D15486#310572, @adek05 wrote: > @aaron.ballman I think this could be hard to achieve without an extra note if > you have something like: > > cat test2.c > int main() { > char *c = 'a'; > > char volatile** cc =

Re: [PATCH] D15534: [CUDA] renamed cuda_runtime.h wrapper to __clang_cuda_runtime_wrapper.h

jhen added a subscriber: jhen. Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:95 @@ -78,3 +94,3 @@ #define __CUDACC__ #include_next "cuda_runtime.h" Now that the name of this header has been changed, would it be appropriate to change this

Re: [PATCH] D14441: [OpenCL] Pipe types support.

pxli168 added a comment. Hi all, Bader had asked me to help him finished the patch set supporting the OpenCL2.0. His original work is based on llvm 3.6.2, and include almost everything needed for 2.0. Now I am working on the rest of the pipe support, include the full support to complex types

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

eugenis updated this revision to Diff 42902. eugenis added a comment. added the new flag to UserManual Repository: rL LLVM http://reviews.llvm.org/D15367 Files: docs/ControlFlowIntegrity.rst docs/ControlFlowIntegrityDesign.rst docs/UsersManual.rst include/clang/Driver/Options.td

Re: [PATCH] D15516: [libcxx] Enable noexcept for GCC 4.6 and greater

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Other than the `_NOEXCEPT_OR_FALSE` thing, this LGTM. http://reviews.llvm.org/D15516 ___ cfe-commits mailing list

Re: [PATCH] D15448: [analyzer] SVal Visitor.

zaks.anna added a comment. Can/Should something like this be used when dumping SVals (during debugging)? (Possibly in addition to the debug checker.) What are the advantages of implementing this using visitors? Can this be implemented similarly to SVal::dumpToStream? Do you envision other use

Re: [PATCH] D15448: [analyzer] SVal Visitor.

zaks.anna added a comment. Sorry, I forgot to read the description before commenting; I see it is intended to be used not only for debugging purposes:) http://reviews.llvm.org/D15448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r255645 - [Microsoft][C++] Clang doesn't support a use of "this" pointer inside inline asm

Author: mzuckerm Date: Tue Dec 15 08:04:18 2015 New Revision: 255645 URL: http://llvm.org/viewvc/llvm-project?rev=255645=rev Log: [Microsoft][C++] Clang doesn't support a use of "this" pointer inside inline asm Clang doesn’t support a use of “this” pointer inside inline asm. When I tried to

[PATCH] D15524: [GCC] Attribute ifunc support in clang

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: aaron.ballman, rjmccall. DmitryPolukhin added a subscriber: cfe-commits. This patch add support for GCC __attribute__((ifunc("resolver"))) for targets that use ELF as object file format. In general ifunc is a special kind of

r255647 - [Microsoft][C++] Clang doesn't support a use of "this" pointer inside inline asm

Author: mzuckerm Date: Tue Dec 15 08:35:51 2015 New Revision: 255647 URL: http://llvm.org/viewvc/llvm-project?rev=255647=rev Log: [Microsoft][C++] Clang doesn't support a use of "this" pointer inside inline asm add triple to test Differential Revision: http://reviews.llvm.org/D15115

r255744 - Print qualified display names when emitting CodeView

Author: rnk Date: Tue Dec 15 20:04:40 2015 New Revision: 255744 URL: http://llvm.org/viewvc/llvm-project?rev=255744=rev Log: Print qualified display names when emitting CodeView This is what debuggers expect. Words towards fixing PR21528. Added:

r255753 - [CodeGen] Use llvm::CmpInst::Predicate instead of unsigned for parameter types in EmitCompare to eliminate some later explicit casts. NFC.

Author: ctopper Date: Wed Dec 16 00:24:28 2015 New Revision: 255753 URL: http://llvm.org/viewvc/llvm-project?rev=255753=rev Log: [CodeGen] Use llvm::CmpInst::Predicate instead of unsigned for parameter types in EmitCompare to eliminate some later explicit casts. NFC. Modified:

Re: [PATCH] D15463: [Objective-c] Fix a crash

Thank you for the review. I added a test to check the "redeclaration of type parameter" error message and committed it as r255754. On Tue, Dec 15, 2015 at 4:55 PM, Justin Bogner wrote: > Akira Hatanaka writes: > > On Tue, Dec 15, 2015 at 12:55 PM,

Re: [PATCH] D15222: [Patch][Profile] add “--dependent-lib= libclang_rt.profile-x86_64.a” to the CC1 command line when enabling code coverage on PS4

MaggieYi added a comment. My patch changes 6 compiler flags, which are –coverage, -fprofile-arcs, -fprofile-generate, -fprofile-generate=, -fprofile-instr-generate, -fprofile-instr-generate=. I would like to keep line 7-10 in order to verify the change to using “hasFlag” instead of “hasArg”.

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier updated this revision to Diff 42854. mcrosier added a comment. Remove the FIXME, per Hal and Bob's request. I confirmed that gcc does not warn for invalid -fno-builtin-foo options. Also, pass the vector by reference and insert, rather than making an unnecessary copy on the return in

Re: [PATCH] D15463: [Objective-c] Fix a crash

This revision was automatically updated to reflect the committed changes. Closed by commit rL255754: [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D15463?vs=42560=42962#toc Repository: rL LLVM

r255754 - [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is

Author: ahatanak Date: Wed Dec 16 00:25:38 2015 New Revision: 255754 URL: http://llvm.org/viewvc/llvm-project?rev=255754=rev Log: [Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is called on an empty list. This commit makes Parser::parseObjCTypeParamListOrProtocolRefs return

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

EricWF added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder)

Re: [PATCH] D15227: [analyzer] Valist checkers.

zaks.anna added a comment. Looks good overall; comments below. Please, provide more information on real world code evaluation. Which codebases this has been tested on? What was the false positive rate? How many real bugs were found/fixed? What is the criteria for taking it out of alpha?