r256243 - [OpenCL] Fix atomic Builtins check for address spaces of non-atomic pointer

Author: stulova Date: Tue Dec 22 09:14:54 2015 New Revision: 256243 URL: http://llvm.org/viewvc/llvm-project?rev=256243=rev Log: [OpenCL] Fix atomic Builtins check for address spaces of non-atomic pointer If there are two pointers passed to an atomic Builtin, Clang doesn't allow the second

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

tberghammer abandoned this revision. tberghammer added a comment. Thank you for adding the new debugger tuning feature. I am using LLDB so "-glldb" will work for me perfectly. There is one thing we might consider is that the accelerator tables increasing the size of the binary by ~10%

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Thanks! Committed with a slight modification as address spaces are now handled correctly by convertToAtomicIntPointer helper method! Cheers Anastasia -Original Message- From: Pekka Jääskeläinen [mailto:pekka.jaaskelai...@tut.fi] Sent: 17 December 2015 08:35 To: Anastasia Stulova;

Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

alexfh added inline comments. Comment at: clang-tidy/google/DefinitionsInHeadersCheck.cpp:23 @@ +22,3 @@ +bool inHeaderFile(const SourceManager* SM, + const SourceLocation& Location) { + StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location));

[clang-tools-extra] r256261 - [clang-tidy] Added documentation for modernize-redundant-void-arg

Author: alexfh Date: Tue Dec 22 12:13:00 2015 New Revision: 256261 URL: http://llvm.org/viewvc/llvm-project?rev=256261=rev Log: [clang-tidy] Added documentation for modernize-redundant-void-arg Added: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-redundant-void-arg.rst Modified:

[PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

george.burgess.iv created this revision. george.burgess.iv added a reviewer: Anastasia. george.burgess.iv added a subscriber: cfe-commits. Clang generally treats booleans as 8-bit types, but lowers them to 1-bit types. This means we currently happily accept C++ code like: ``` typedef

r256278 - [ASTMatchers] Add booleanType() matcher.

Author: sbenza Date: Tue Dec 22 14:06:40 2015 New Revision: 256278 URL: http://llvm.org/viewvc/llvm-project?rev=256278=rev Log: [ASTMatchers] Add booleanType() matcher. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

eraman created this revision. eraman added reviewers: bogner, davidxl. eraman added a subscriber: cfe-commits. NFC. These hints are only used for inlining and the inliner now uses the same criteria to identify hot and cold callees and set appropriate thresholds without relying on these hints.

Re: r256216 - [WebAssembly] Remove the -target command-line flag from the ld commandline.

Well yes, but we have a Windows bot on http://lab.llvm.org:8011/console, right? On Tue, Dec 22, 2015 at 5:54 PM, Dan Gohman wrote: > It appears the reason it was only caught on Windows was that only Windows > appends ".exe" to executable files. Your change to match lld with

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

thakis added a subscriber: thakis. Comment at: compiler-rt/trunk/test/ubsan/TestCases/Integer/suppressions.cpp:1 @@ +1,2 @@ +// RUN: %clangxx -fsanitize=integer -g0 %s -o %t + This test fails on Windows. I tried to debug, but the usual way to run tests seems to

Buildbot numbers for week of 12/13/2015 - 12/19/2015

Hello everyone, Below are some buildbot numbers for the last week of 12/13/2015 - 12/19/2015. Thanks Galina Number of commits by project: project | commits ---+--- llvm | 293 cfe |

Re: r255382 - [clang-cl] Let /W4 map to -Wall -Wextra instead of just -Wall.

On Tue, Dec 15, 2015 at 2:56 PM, Nico Weber wrote: > Looks like the warning is still emitted frequently. It looks like cl.exe > processes /W4 before /wd4100 even though if it's passed as "/wd4100 /W4". > clang-cl probably interprets this as "first, disable Wunused-parameter,

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

kfunk added a comment. By the way; prove that it really works: http://wstaw.org/m/2015/12/23/kdevelop-clazy.png (loving it!) :) http://reviews.llvm.org/D15729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

thakis added a comment. It's because FlagParser::is_space() considers ':' as a space, so it thinks c:\ ends after the c and then starts parsing another flag at the \. Fix ideas: Don't treat : as space while in quotes, or use ; as separator on Windows. Repository: rL LLVM

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

thakis added a comment. And this in turn is because env strips the quotes: C:\src\chrome\src\third_party\llvm-bootstrap>env

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

thakis added a comment. I've looked at it some, and couldn't find a way of escaping quotes that lit doesn't strip but that ubsan accepts. '"c:\foo"' gets its quotes stripped by lit, so does """c:\foo""". \"c:\foo\" confuses lit enough that it tries to call lit.util.warning() which doesn't

r256284 - [ASTMatchers] Fix typo in booleanType() doc.

Author: sbenza Date: Tue Dec 22 15:06:36 2015 New Revision: 256284 URL: http://llvm.org/viewvc/llvm-project?rev=256284=rev Log: [ASTMatchers] Fix typo in booleanType() doc. Fix typo in booleanType() doc and recreate the LibASTMatchersReference.html reference document. Modified:

Re: r256278 - [ASTMatchers] Add booleanType() matcher.

On Tue, Dec 22, 2015 at 3:16 PM, Aaron Ballman wrote: > On Tue, Dec 22, 2015 at 3:06 PM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > > Date: Tue Dec 22 14:06:40 2015 > > New Revision: 256278 > > > > URL:

r256288 - Disable include sorting by default for Chromium style.

Author: nico Date: Tue Dec 22 16:42:56 2015 New Revision: 256288 URL: http://llvm.org/viewvc/llvm-project?rev=256288=rev Log: Disable include sorting by default for Chromium style. Include sorting generally can break .cc files, especially on Windows. Make this opt-in for Chromium style to give

Re: [PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

davidxl added a comment. This looks like a straightforward cleanup (the test cases have been in a previous patch). http://reviews.llvm.org/D15726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too

kfunk added a comment. Doing as requested by http://lists.llvm.org/pipermail/cfe-dev/2014-October/039381.html, let's put this up for review in its initial form, so we can discuss a better approach. http://reviews.llvm.org/D15729 ___ cfe-commits

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

thakis added a comment. Here's the error (I still don't know how to run single tests through lit, though): C:\src\chrome\src\third_party\llvm-bootstrap>env

r256286 - Make wasm-toolchain.c test pass on Windows.

Author: nico Date: Tue Dec 22 16:30:14 2015 New Revision: 256286 URL: http://llvm.org/viewvc/llvm-project?rev=256286=rev Log: Make wasm-toolchain.c test pass on Windows. Modified: cfe/trunk/test/Driver/wasm-toolchain.c Modified: cfe/trunk/test/Driver/wasm-toolchain.c URL:

Re: [PATCH] D15208: Patch for inline abort code generation

danielaustin updated this revision to Diff 43459. danielaustin added a comment. Test case added which looks for the existence of multiple trap basic blocks in generated LLVM-IR with optimization turned on. Flag renamed (-fmerge-traps/-fno-merge-traps) and placed in a more sensible location

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 43469. nwilson added a comment. Updating to r256247 http://reviews.llvm.org/D13357 Files: include/clang/AST/DeclTemplate.h include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp

Re: r256278 - [ASTMatchers] Add booleanType() matcher.

On Tue, Dec 22, 2015 at 3:06 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Tue Dec 22 14:06:40 2015 > New Revision: 256278 > > URL: http://llvm.org/viewvc/llvm-project?rev=256278=rev > Log: > [ASTMatchers] Add booleanType() matcher. > > Modified:

Re: [clang-tools-extra] r255886 - Remove clang-modernize.

Sure, will do On Dec 17, 2015 6:44 PM, "Aaron Ballman" wrote: > Can you also be sure to update the release notes for this change? > > ~Aaron > > On Thu, Dec 17, 2015 at 6:49 AM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh >

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:836 @@ -835,2 +835,3 @@ + bool IsConcept : 1; protected: This might make more sense on `TemplateDecl`, since we also want this flag for `VarTemplateDecl`s. In any case, please use

[libcxxabi] r256323 - Add new tests for throwing incomplete pointer types

Author: ericwf Date: Wed Dec 23 01:04:32 2015 New Revision: 256323 URL: http://llvm.org/viewvc/llvm-project?rev=256323=rev Log: Add new tests for throwing incomplete pointer types Modified: libcxxabi/trunk/test/incomplete_type.sh.cpp Modified: libcxxabi/trunk/test/incomplete_type.sh.cpp

r256319 - [Sema] Make an enum local to the only method that uses it. NFC

Author: ctopper Date: Tue Dec 22 23:44:46 2015 New Revision: 256319 URL: http://llvm.org/viewvc/llvm-project?rev=256319=rev Log: [Sema] Make an enum local to the only method that uses it. NFC Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL:

r256318 - [Sema] Use available enum types instead of integers. As one is used in a switch, this makes the compiler ensure the switch is fully covered. NFC

Author: ctopper Date: Tue Dec 22 23:44:43 2015 New Revision: 256318 URL: http://llvm.org/viewvc/llvm-project?rev=256318=rev Log: [Sema] Use available enum types instead of integers. As one is used in a switch, this makes the compiler ensure the switch is fully covered. NFC Modified:

[libcxxabi] r256322 - Fix PR25898 - Check for incomplete pointers types in can_catch(...)

Author: ericwf Date: Wed Dec 23 00:35:25 2015 New Revision: 256322 URL: http://llvm.org/viewvc/llvm-project?rev=256322=rev Log: Fix PR25898 - Check for incomplete pointers types in can_catch(...) Added: libcxxabi/trunk/test/incomplete_type.sh.cpp Modified:

Re: [PATCH] D15227: [analyzer] Valist checkers.

xazax.hun marked 9 inline comments as done. xazax.hun added a comment. It was tested on gcc and rAthena (https://github.com/rathena/rathena). It did not find any issues in those projects, but I was able to find some issues that I artificially put into those projects. Comment

r256240 - [mips] Add _GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.

Author: dsanders Date: Tue Dec 22 06:59:30 2015 New Revision: 256240 URL: http://llvm.org/viewvc/llvm-project?rev=256240=rev Log: [mips] Add _GCC_HAVE_SYNC_COMPARE_AND_SWAP macros. This fixes the 'pure virtual function called' failure with ThreadPool in a clang-built clang. This fixes the

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

davide added a subscriber: davide. davide accepted this revision. davide added a reviewer: davide. davide added a comment. This revision is now accepted and ready to land. The patch looks good, and the changes are localized to the DflyBSD driver so if you tested and works, I'm fine with it. I'll

r256238 - [OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive.

Author: abataev Date: Tue Dec 22 06:21:47 2015 New Revision: 256238 URL: http://llvm.org/viewvc/llvm-project?rev=256238=rev Log: [OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive. OpenMP 4.5 adds 'depend(sink:vec)' in 'ordered' directive for doacross loop

r256239 - [OPENMP] Revert r256238 to fix the problem with tests on Linux.

Author: abataev Date: Tue Dec 22 06:44:46 2015 New Revision: 256239 URL: http://llvm.org/viewvc/llvm-project?rev=256239=rev Log: [OPENMP] Revert r256238 to fix the problem with tests on Linux. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: r256216 - [WebAssembly] Remove the -target command-line flag from the ld commandline.

Thanks! On 21 December 2015 at 18:30, Dan Gohman via cfe-commits wrote: > Author: djg > Date: Mon Dec 21 17:30:41 2015 > New Revision: 256216 > > URL: http://llvm.org/viewvc/llvm-project?rev=256216=rev > Log: > [WebAssembly] Remove the -target command-line flag from

Re: [PATCH] D15705: Adding a scripted test for PR25717

Can't you use the preprocessor to produce a large output? See the testcase in https://llvm.org/bugs/show_bug.cgi?id=10651#c10 for example. Cheers, Rafael On 21 December 2015 at 20:07, Yunzhong Gao via cfe-commits wrote: > ygao created this revision. > ygao added

r256247 - clang-format: [JS] Support arrays of object-type literals.

Author: djasper Date: Tue Dec 22 09:48:35 2015 New Revision: 256247 URL: http://llvm.org/viewvc/llvm-project?rev=256247=rev Log: clang-format: [JS] Support arrays of object-type literals. Before: interface I { o: {} []; } After: interface I { o: {}[]; } Modified:

r256245 - clang-format: [JS] "operator" is not a keyword in Java/JavaScript.

Author: djasper Date: Tue Dec 22 09:47:56 2015 New Revision: 256245 URL: http://llvm.org/viewvc/llvm-project?rev=256245=rev Log: clang-format: [JS] "operator" is not a keyword in Java/JavaScript. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Format/FormatTestJS.cpp

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

berenm marked 8 inline comments as done. berenm added a comment. For information, I just tested the current diff under Visual Studio 2010 SP1 and everything looks fine as well. http://reviews.llvm.org/D12407 ___ cfe-commits mailing list

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

berenm added a comment. Actually, the main issue that I see is the difficulty to build the plugin itself. The project does not build out-of-the-box on VS2013, and I had to change the assembly references by hand. I have a patch to get the required assemblies in a more portable way using nuget

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

jrmarino added a subscriber: jrmarino. jrmarino added a comment. Hi, can someone take a look at http://reviews.llvm.org/D15166? It's a simple patch but critical for DragonFly. http://reviews.llvm.org/D15166 ___ cfe-commits mailing list

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

jrmarino added a comment. Hi Davide, Yes, the patch is tested it. We are carrying them in FreeBSD ports (which DragonFly uses), so they are being used now. http://reviews.llvm.org/D15166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov updated this revision to Diff 43442. a.makarov added a comment. Actual updated patch. Sorry for noise. http://reviews.llvm.org/D15373 Files: include/clang/Sema/Sema.h lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaType.cpp test/CodeGen/adding_defaulted_cc_attr_to_type.c

[libcxxabi] r256241 - Fix ARM __cxa_end_cleanup() and gc-sections.

Author: logan Date: Tue Dec 22 08:38:30 2015 New Revision: 256241 URL: http://llvm.org/viewvc/llvm-project?rev=256241=rev Log: Fix ARM __cxa_end_cleanup() and gc-sections. This commit adds SHF_ALLOC and SHF_EXECINSTR section flags to `.text.__cxa_end_cleanup` section. This fixes a link error

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov updated this revision to Diff 43440. a.makarov added a comment. I've updated the patch. Please, re-review it again. About creating attributed type - I think we shouldn't create it if we ignored specified CC attribute. Ignoring specified CC attribute (and emitting the warning, of

Re: [PATCH] D15613: Fix ARM __cxa_end_cleanup() and gc-sections.

logan closed this revision. logan added a comment. Thanks! Committed as http://reviews.llvm.org/rL256241. http://reviews.llvm.org/D15613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r256253 - [clang-tools-extra] Text formatting

Author: alexfh Date: Tue Dec 22 11:08:57 2015 New Revision: 256253 URL: http://llvm.org/viewvc/llvm-project?rev=256253=rev Log: [clang-tools-extra] Text formatting Modified: clang-tools-extra/trunk/docs/index.rst Modified: clang-tools-extra/trunk/docs/index.rst URL:

[clang-tools-extra] r256254 - Updated year (2014-2015).

Author: alexfh Date: Tue Dec 22 11:10:34 2015 New Revision: 256254 URL: http://llvm.org/viewvc/llvm-project?rev=256254=rev Log: Updated year (2014-2015). Modified: clang-tools-extra/trunk/LICENSE.TXT clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/LICENSE.TXT URL:

[clang-tools-extra] r256259 - [clang-tidy] Updates to documentation: formatting, titles, etc.

Author: alexfh Date: Tue Dec 22 11:36:49 2015 New Revision: 256259 URL: http://llvm.org/viewvc/llvm-project?rev=256259=rev Log: [clang-tidy] Updates to documentation: formatting, titles, etc. Modified: clang-tools-extra/trunk/clang-tidy/add_new_check.py

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

faisalv added a subscriber: Nate. Comment at: include/clang/AST/DeclTemplate.h:836 @@ -835,2 +835,3 @@ + bool IsConcept : 1; protected: rsmith wrote: > This might make more sense on `TemplateDecl`, since we also want this flag > for `VarTemplateDecl`s. In