r256665 - [TrailingObjects] Fix bug in "Convert classes in ExprObjC.h"

Author: jyknight Date: Thu Dec 31 00:01:19 2015 New Revision: 256665 URL: http://llvm.org/viewvc/llvm-project?rev=256665=rev Log: [TrailingObjects] Fix bug in "Convert classes in ExprObjC.h" (Detected by asan) Modified: cfe/trunk/lib/AST/ExprObjC.cpp Modified:

r256661 - [MSVC Compat] Diagnose multiple default ctors for dllexport'd classes

Author: majnemer Date: Wed Dec 30 23:36:46 2015 New Revision: 256661 URL: http://llvm.org/viewvc/llvm-project?rev=256661=rev Log: [MSVC Compat] Diagnose multiple default ctors for dllexport'd classes The MS ABI emits a special default constructor closure thunk if a default constructor has a

r256664 - [MS ABI] Remove mangleCXXCatchHandlerType

Author: majnemer Date: Wed Dec 30 23:36:54 2015 New Revision: 256664 URL: http://llvm.org/viewvc/llvm-project?rev=256664=rev Log: [MS ABI] Remove mangleCXXCatchHandlerType It's dead code, no functional change is intended. Modified: cfe/trunk/include/clang/AST/Mangle.h

r256663 - [MS ABI] Change the ArgBackRefMap to hold const qualified pointers

Author: majnemer Date: Wed Dec 30 23:36:52 2015 New Revision: 256663 URL: http://llvm.org/viewvc/llvm-project?rev=256663=rev Log: [MS ABI] Change the ArgBackRefMap to hold const qualified pointers Just a cleanup, no functional change is intended. Modified:

r256662 - [MS ABI] Replace dead code with an assertion

Author: majnemer Date: Wed Dec 30 23:36:50 2015 New Revision: 256662 URL: http://llvm.org/viewvc/llvm-project?rev=256662=rev Log: [MS ABI] Replace dead code with an assertion As per C++ [dcl.ref]p1, cv-qualified references are not valid. As such, change the mangler to assert that this event does

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added a comment. Should add a test case in test/Driver/instrprof-ld.c. Comment at: lib/CodeGen/BackendUtil.cpp:435 @@ +434,3 @@ + if (CodeGenOpts.ProfileIRInstr) { +assert (!CodeGenOpts.ProfileInstrGenerate); +if (!CodeGenOpts.InstrProfileOutput.empty())

r256666 - [OPENMP 4.5] Codegen for 'schedule' clause with monotonic/nonmonotonic modifiers.

Author: abataev Date: Thu Dec 31 00:52:34 2015 New Revision: 25 URL: http://llvm.org/viewvc/llvm-project?rev=25=rev Log: [OPENMP 4.5] Codegen for 'schedule' clause with monotonic/nonmonotonic modifiers. OpenMP 4.5 adds support for monotonic/nonmonotonic modifiers in 'schedule' clause.

Re: [PATCH] D15814: Implicit conversion from float->bool

On Dec 30, 2015 6:34 AM, "Aaron Ballman" wrote: > > aaron.ballman closed this revision. > aaron.ballman added a comment. > > Thanks! I've commit in r256643. > > > > Comment at: test/SemaCXX/warn-literal-conversion.cpp:49-50 > @@ +48,4 @@ > + // values. >

Re: [PATCH] D12200: Add framework for iterative compilation to clang

zoran.jovanovic updated this revision to Diff 43793. zoran.jovanovic added a comment. New patch version that corresponds to latest version of: http://reviews.llvm.org/D12199 http://reviews.llvm.org/D12200 Files: include/clang/Driver/Compilation.h include/clang/Driver/Driver.h

Re: [PATCH] D15726: Remove setting of inlinehint and cold attributes based on profile data

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D15726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D7164: Recognize "CC" and "clang-CC" as C++ compiler aliases on FreeBSD

dim abandoned this revision. dim added a comment. Abandoning this in favor of a wrapper shell script, which will call `/usr/bin/c++` instead. http://reviews.llvm.org/D7164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

DmitryPolukhin added a comment. Thank you for the review! I'm waiting for llvm part of ifunc support because it has to be committed first. http://reviews.llvm.org/D15524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood updated this revision to Diff 43800. LegalizeAdulthood added a comment. Add more unit tests. http://reviews.llvm.org/D8149 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp

[libcxx] r256652 - [libcxx] Fix for ALL undefined behavior in .

Author: ericwf Date: Wed Dec 30 14:57:59 2015 New Revision: 256652 URL: http://llvm.org/viewvc/llvm-project?rev=256652=rev Log: [libcxx] Fix for ALL undefined behavior in . Summary: This patch fixes std::list for builtin pointer types in the current ABI version and fixes std::list for all fancy

Re: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

gen_link_script.py is missing a license header. On Thu, Oct 22, 2015 at 5:39 PM, Alexey Samsonov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Seems to work now, thanks for the quick fix! > > On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote: > >> Hi Alexey, >> >>

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Minor changes; other than that, LGTM. Comment at: include/__config:43 @@ -42,1 +42,3 @@ +// Fix undefined behavior in how std::list stores it's linked nodes.

Re: [libcxx] r249798 - Split out of .

One problem with this patch: stdio.h can be used in .c files, and when building .c files with -gnu99 -pedantic, clang will complain about // comments. Not only does this stdio.h have // comments, it also pulls in some libc++ headers (__config) that have // comments as well. I suppose all the

Re: [PATCH] D15814: Implicit conversion from float->bool

On Wed, Dec 30, 2015 at 12:30 PM, Richard Smith wrote: > On Dec 30, 2015 6:34 AM, "Aaron Ballman" wrote: >> >> aaron.ballman closed this revision. >> aaron.ballman added a comment. >> >> Thanks! I've commit in r256643. >> >> >> >>

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood marked an inline comment as done. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4022 @@ +4021,3 @@ +/// functionProtoType() +/// matches "int (*f)(int)" and the type of "g". +AST_TYPE_MATCHER(FunctionProtoType, functionProtoType);

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

EricWF updated this revision to Diff 43802. EricWF added a comment. - Change ABI macro name to `_LIBCPP_ABI_LIST_REMOVE_NODE_POINTER_UB`. - Remove unnecessary variable pointed out in review. - Rename `__node_pointer_traits` to `__list_node_pointer_traits` to prevent name collisions.

r256651 - Implement [temp.deduct.type]p6: if the nested-name-specifier of a type is

Author: rsmith Date: Wed Dec 30 14:56:05 2015 New Revision: 256651 URL: http://llvm.org/viewvc/llvm-project?rev=256651=rev Log: Implement [temp.deduct.type]p6: if the nested-name-specifier of a type is dependent, the type is a non-deduced context. Modified:

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:2908 @@ -2893,1 +2907,3 @@ +/// \brief Matches \c FunctionDecls and FunctionProtoTypes that have a specific +/// parameter count. /// Can you document the expected parameter

Re: r256596 - Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode.

On Tue, Dec 29, 2015 at 11:17:28PM -, Nico Weber via cfe-commits wrote: > Author: nico > Date: Tue Dec 29 17:17:27 2015 > New Revision: 256596 > > URL: http://llvm.org/viewvc/llvm-project?rev=256596=rev > Log: > Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode. Do they really

[libcxx] r256654 - Use __rebind_pointer to avoid #ifdef block

Author: ericwf Date: Wed Dec 30 15:52:00 2015 New Revision: 256654 URL: http://llvm.org/viewvc/llvm-project?rev=256654=rev Log: Use __rebind_pointer to avoid #ifdef block Modified: libcxx/trunk/include/__hash_table libcxx/trunk/include/__tree libcxx/trunk/include/ext/hash_map

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

mattsta added a comment. Yeah, I fully understand the need to make sure it doesn't break again (or that this actually fixes it properly), but these changes are about the limit of my LLVM+Tidy internals understanding. (What's missing from this diff is the 20 hours across 4-6 months where I

[PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur created this revision. xur added reviewers: davidxl, silvas, bogner. xur added a subscriber: cfe-commits. This patch introduce a new toggle option -fprofile-ir-instr that enables IR level instrumentation. It needs to be used in combination with current PGO options. Without an existing PGO

Re: [libcxx] r249798 - Split out of .

On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote: > One problem with this patch: stdio.h can be used in .c files, and when > building .c files with -gnu99 -pedantic, > Do you mean -std=gnu89? > clang will complain about // comments. Not only does this stdio.h have // >

r256657 - Improve diagnostic for the case where a function template candidate is rejected

Author: rsmith Date: Wed Dec 30 20:02:54 2015 New Revision: 256657 URL: http://llvm.org/viewvc/llvm-project?rev=256657=rev Log: Improve diagnostic for the case where a function template candidate is rejected by overload resolution because deduction succeeds, but the substituted parameter type for

r256659 - [TrailingObjects] Convert classes in ExprObjC.h

Author: jyknight Date: Wed Dec 30 22:43:19 2015 New Revision: 256659 URL: http://llvm.org/viewvc/llvm-project?rev=256659=rev Log: [TrailingObjects] Convert classes in ExprObjC.h Modified: cfe/trunk/include/clang/AST/ExprObjC.h cfe/trunk/lib/AST/ExprObjC.cpp

[clang-tools-extra] r256633 - [clang-tidy] Fix configure build

Author: alexfh Date: Wed Dec 30 04:44:08 2015 New Revision: 256633 URL: http://llvm.org/viewvc/llvm-project?rev=256633=rev Log: [clang-tidy] Fix configure build Modified: clang-tools-extra/trunk/clang-tidy/tool/Makefile Modified: clang-tools-extra/trunk/clang-tidy/tool/Makefile URL:

[clang-tools-extra] r256636 - [clang-tidy] Use hasLocalStorage() to identify unnecessary copy initializations to exclude static local variables.

Author: alexfh Date: Wed Dec 30 05:35:50 2015 New Revision: 256636 URL: http://llvm.org/viewvc/llvm-project?rev=256636=rev Log: [clang-tidy] Use hasLocalStorage() to identify unnecessary copy initializations to exclude static local variables. Summary: Since local static variables can outlive

[clang-tools-extra] r256637 - [clang-tidy] Don't use delegating constructors

Author: alexfh Date: Wed Dec 30 05:39:30 2015 New Revision: 256637 URL: http://llvm.org/viewvc/llvm-project?rev=256637=rev Log: [clang-tidy] Don't use delegating constructors Modified: clang-tools-extra/trunk/clang-tidy/performance/UnnecessaryCopyInitialization.h Modified:

[clang-tools-extra] r256632 - [clang-tidy] Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

Author: alexfh Date: Wed Dec 30 04:24:40 2015 New Revision: 256632 URL: http://llvm.org/viewvc/llvm-project?rev=256632=rev Log: [clang-tidy] Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy Summary: The patch adds a new ClangTidy check that detects when

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL256632: [clang-tidy] Add UnnecessaryCopyInitialization check to new "performance"… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D15623?vs=43743=43776#toc Repository: rL

r256631 - clang-format: [JS] Support TypeScript 1.6 user defined type guards.

Author: djasper Date: Wed Dec 30 02:00:58 2015 New Revision: 256631 URL: http://llvm.org/viewvc/llvm-project?rev=256631=rev Log: clang-format: [JS] Support TypeScript 1.6 user defined type guards. Before: function foo(check: Object): check is{foo: string, bar: string, baz: string, foobar:

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

alexfh added a comment. In http://reviews.llvm.org/D15797#317793, @mattsta wrote: > It's difficult to track down *why* the invalid locations are happening > because by the time we get to an invalid location, all source location > information is lost. The best I've been able to come up with is

Re: [PATCH] D15623: Add UnnecessaryCopyInitialization check to new "performance" module in ClangTidy

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! I'll commit the patch for you. http://reviews.llvm.org/D15623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r256641 - Disable generating movt on FreeBSD.

Author: davide Date: Wed Dec 30 07:53:25 2015 New Revision: 256641 URL: http://llvm.org/viewvc/llvm-project?rev=256641=rev Log: Disable generating movt on FreeBSD. It's sort of an hack, but we have no choice. The linker in the base system doesn't handle that correctly (yet). Once FreeBSD will

Re: [PATCH] D15813: [libcxx] Refactoring target_info.py used by lit tests

bcraig added a comment. Apologies for the swarm of breakages this caused. Thanks for the late night (for me at least) locale fix EricWF! http://reviews.llvm.org/D15813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r256643 - When performing an implicit from float to bool, the floating point value must be *exactly* zero in order for the conversion to result in 0. This does not involve a conversion through an inte

Author: aaronballman Date: Wed Dec 30 08:26:07 2015 New Revision: 256643 URL: http://llvm.org/viewvc/llvm-project?rev=256643=rev Log: When performing an implicit from float to bool, the floating point value must be *exactly* zero in order for the conversion to result in 0. This does not involve

r256639 - [OPENMP 4.5] Allow 'ordered' clause on 'loop simd' constructs.

Author: abataev Date: Wed Dec 30 06:06:23 2015 New Revision: 256639 URL: http://llvm.org/viewvc/llvm-project?rev=256639=rev Log: [OPENMP 4.5] Allow 'ordered' clause on 'loop simd' constructs. OpenMP 4.5 allows to use 'ordered' clause without parameter on 'loop simd' constructs. Modified:

[PATCH] D15823: Support virtual-near-miss check.

congliu created this revision. congliu added a reviewer: alexfh. congliu added a subscriber: cfe-commits. Virtual function override near miss detection. Function complete. Test complete. Do not conduct Fix for now. http://reviews.llvm.org/D15823 Files: clang-tidy/misc/CMakeLists.txt

r256640 - clang-format: Slightly row back on r256343 by increasing penalty for

Author: djasper Date: Wed Dec 30 06:23:00 2015 New Revision: 256640 URL: http://llvm.org/viewvc/llvm-project?rev=256640=rev Log: clang-format: Slightly row back on r256343 by increasing penalty for breaking between array subscripts. Before: if ( &&

Re: [PATCH] D15814: Implicit conversion from float->bool

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r256643. Comment at: test/SemaCXX/warn-literal-conversion.cpp:49-50 @@ +48,4 @@ + // values. + bool b3 = 0.0f; + bool b4 = 0.0; +} rsmith wrote: > What about > >